GNU bug report logs - #20401
refill long lines in generated ChangeLog

Previous Next

Package: emacs;

Reported by: Glenn Morris <rgm <at> gnu.org>

Date: Tue, 21 Apr 2015 20:49:02 UTC

Severity: minor

Tags: wontfix

Found in version 25.0.50

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20401 in the body.
You can then email your comments to 20401 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#20401; Package emacs. (Tue, 21 Apr 2015 20:49:02 GMT) Full text and rfc822 format available.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: refill long lines in generated ChangeLog
Date: Tue, 21 Apr 2015 16:48:56 -0400
Package: emacs
Version: 25.0.50
Severity: minor

`make ChangeLog' creates entries longer than 80 columns; see example.
I had hoped that it would refill overly long lines.

2015-04-20  Glenn Morris  <rgm <at> gnu.org>

	Avoid non-nil current-load-list at startup
	* src/process.c (init_process_emacs): Move Fprovide statement...
	(syms_of_process): ... to here.

	* lisp/loadup.el (custom-current-group-alist): Reset before dumping.

	* lisp/startup.el (command-line) <site-run-file>: Avoid rogue value in emacs -Q.


Many bonus points if it fills it the "smart" way that I would have done
had I written it by hand. ;)

        * lisp/startup.el (command-line) <site-run-file>:
        Avoid rogue value in emacs -Q.

Yes, it's probably my fault. I was "forced" into it by git's IMO silly
"if more than one line, second line should be blank" convention.

But it's not just me that has written lines slightly too long.




Added indication that bug 20401 blocks19759 Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Tue, 21 Apr 2015 20:50:04 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20401; Package emacs. (Sun, 26 Apr 2015 01:25:02 GMT) Full text and rfc822 format available.

Message #8 received at 20401 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 20401 <at> debbugs.gnu.org
Subject: refill long lines in generated ChangeLog
Date: Sat, 25 Apr 2015 18:24:23 -0700
[Message part 1 (text/plain, inline)]
> it's not just me that has written lines slightly too long.

That's right, lots of people are doing it, and it makes more busywork when 
cleaning up ChangeLogs, which sucks.  I don't have much faith in fixing this 
automagically, as a lot could go wrong.

There's a much simpler fix (see attached) but Stefan nixed it (see 
<http://lists.gnu.org/archive/html/emacs-devel/2014-12/msg01640.html>) for 
reasons that I don't follow.  Perhaps we could take another run at him and he'll 
relent this time.

Another possibility is that we set the tab-width in ChangeLog files to 2, so 
that 78-character log lines fit in ChangeLog files when displayed via Emacs. 
(I'm *sure* nobody would complain about *that*. :-)

But really, it'd be simpler to shrink that "78" back to "72".
[0001-Encourage-shorter-commit-message-lines.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20401; Package emacs. (Mon, 27 Apr 2015 18:26:02 GMT) Full text and rfc822 format available.

Message #11 received at 20401 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 20401 <at> debbugs.gnu.org
Subject: Re: refill long lines in generated ChangeLog
Date: Mon, 27 Apr 2015 14:25:44 -0400
Paul Eggert wrote:

> I don't have much faith in fixing this automagically, as a lot could
> go wrong.

You're probably right. (Perhaps we could use Emacs to fill the entries tho'.)




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20401; Package emacs. (Mon, 27 Apr 2015 18:38:02 GMT) Full text and rfc822 format available.

Message #14 received at 20401 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 20401 <at> debbugs.gnu.org
Subject: Re: bug#20401: refill long lines in generated ChangeLog
Date: Mon, 27 Apr 2015 14:37:32 -0400
PS I'd appreciate the suggested font-lock warning for "long" VC log lines
(Though I commit from the released version, so it will be a while before
I can take advantage of it.)




Removed indication that bug 20401 blocks Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sat, 19 Mar 2016 22:12:02 GMT) Full text and rfc822 format available.

Added tag(s) wontfix. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 12 Feb 2017 01:23:01 GMT) Full text and rfc822 format available.

bug closed, send any further explanations to 20401 <at> debbugs.gnu.org and Glenn Morris <rgm <at> gnu.org> Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 12 Feb 2017 01:23:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 12 Mar 2017 11:24:03 GMT) Full text and rfc822 format available.

This bug report was last modified 8 years and 94 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.