GNU bug report logs - #20398
25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: martin rudalics <rudalics <at> gmx.at>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#20398: closed (25.0.50; Clicking `window-divider-last-pixel'
 in help for `window-divider')
Date: Tue, 03 May 2016 06:46:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 03 May 2016 08:44:38 +0200
with message-id <572848D6.4050306 <at> gmx.at>
and subject line Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider'
has caused the debbugs.gnu.org bug report #20398,
regarding 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
20398: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20398
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; Clicking `window-divider-last-pixel' in help for
 `window-divider'
Date: Tue, 21 Apr 2015 13:02:01 -0700 (PDT)

.. shows the error:
window-divider-first-pixel is void as a variable.

Help should show the doc string of the face, not the variable,


In GNU Emacs 25.0.50.1 (i686-pc-mingw32)
 of 2014-10-20 on LEG570
Bzr revision: 118168 rgm <at> gnu.org-20141020195941-icp42t8ttcnud09g
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --enable-checking=yes,glyphs CPPFLAGS=-DGLYPH_DEBUG=1'

[Message part 3 (message/rfc822, inline)]

From: martin rudalics <rudalics <at> gmx.at>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 20398-done <at> debbugs.gnu.org,
 Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help
 for `window-divider'
Date: Tue, 03 May 2016 08:44:38 +0200

>> So the patch is as below.  Any objections to apply this to the emacs-25
>> branch?
>
> [...]
>
>> -    (define-key map [down-mouse-2] 'widget-button-click)
>> -    (define-key map [down-mouse-1] 'widget-button-click)
>> +    (define-key map [mouse-2] 'widget-button-click)
>> +    (define-key map [mouse-1] 'widget-button-click)
>
> Isn't this a rather large change to go in at this point?  People may
> have rebound `down-mouse-1' (etc) instead of `mouse-1'...

No idea.  But counted as objection and therefore committed to master.
Closing the bug.

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.