GNU bug report logs - #20398
25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider'

Previous Next

Full log

Message #64 received at 20398 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 20398 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>,
 Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help
 for `window-divider'
Date: Mon, 02 May 2016 10:00:17 +0200

>> Shouldn't we then do the same here:
>>>>>> (define-key map [down-mouse-1] 'widget-button-click)
>
> I think so, yes.

So the patch is as below.  Any objections to apply this to the emacs-25
branch?

martin

diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el
index f0054be..0a0f458 100644
--- a/lisp/wid-edit.el
+++ b/lisp/wid-edit.el
@@ -852,8 +852,8 @@ widget-keymap
     (define-key map [(shift tab)] 'widget-backward)
     (put 'widget-backward :advertised-binding [(shift tab)])
     (define-key map [backtab] 'widget-backward)
-    (define-key map [down-mouse-2] 'widget-button-click)
-    (define-key map [down-mouse-1] 'widget-button-click)
+    (define-key map [mouse-2] 'widget-button-click)
+    (define-key map [mouse-1] 'widget-button-click)
     ;; The following definition needs to avoid using escape sequences that
     ;; might get converted to ^M when building loaddefs.el
     (define-key map [(control ?m)] 'widget-button-press)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.