From unknown Wed Jun 25 05:37:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#20398 <20398@debbugs.gnu.org> To: bug#20398 <20398@debbugs.gnu.org> Subject: Status: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' Reply-To: bug#20398 <20398@debbugs.gnu.org> Date: Wed, 25 Jun 2025 12:37:48 +0000 retitle 20398 25.0.50; Clicking `window-divider-last-pixel' in help for `wi= ndow-divider' reassign 20398 emacs submitter 20398 Drew Adams severity 20398 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 21 16:02:24 2015 Received: (at submit) by debbugs.gnu.org; 21 Apr 2015 20:02:24 +0000 Received: from localhost ([127.0.0.1]:35529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YkeND-0003S1-G1 for submit@debbugs.gnu.org; Tue, 21 Apr 2015 16:02:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54323) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YkeNB-0003Rd-J4 for submit@debbugs.gnu.org; Tue, 21 Apr 2015 16:02:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkeN0-00030j-EM for submit@debbugs.gnu.org; Tue, 21 Apr 2015 16:02:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkeN0-00030f-CR for submit@debbugs.gnu.org; Tue, 21 Apr 2015 16:02:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkeMz-0007Tv-JG for bug-gnu-emacs@gnu.org; Tue, 21 Apr 2015 16:02:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkeMu-0002z1-4h for bug-gnu-emacs@gnu.org; Tue, 21 Apr 2015 16:02:09 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:43353) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkeMt-0002yu-TH for bug-gnu-emacs@gnu.org; Tue, 21 Apr 2015 16:02:04 -0400 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t3LK22qx004362 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 Apr 2015 20:02:03 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t3LK22j3008943 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Tue, 21 Apr 2015 20:02:02 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t3LK22bI015480 for ; Tue, 21 Apr 2015 20:02:02 GMT MIME-Version: 1.0 Message-ID: <05342534-126d-44f4-b415-3159c44740f1@default> Date: Tue, 21 Apr 2015 13:02:01 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) .. shows the error: window-divider-first-pixel is void as a variable. Help should show the doc string of the face, not the variable, In GNU Emacs 25.0.50.1 (i686-pc-mingw32) of 2014-10-20 on LEG570 Bzr revision: 118168 rgm@gnu.org-20141020195941-icp42t8ttcnud09g Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking=3Dyes,glyphs CPPFLAGS=3D-DGLYPH_DEBUG=3D1' From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 22 04:09:07 2015 Received: (at 20398) by debbugs.gnu.org; 22 Apr 2015 08:09:07 +0000 Received: from localhost ([127.0.0.1]:35732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YkpiV-0007WY-Ds for submit@debbugs.gnu.org; Wed, 22 Apr 2015 04:09:07 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:43763) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YkpiS-0007W3-Ah for 20398@debbugs.gnu.org; Wed, 22 Apr 2015 04:09:05 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NN7004007EC8700@a-mtaout21.012.net.il> for 20398@debbugs.gnu.org; Wed, 22 Apr 2015 11:08:58 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NN7004TK7YX9700@a-mtaout21.012.net.il>; Wed, 22 Apr 2015 11:08:58 +0300 (IDT) Date: Wed, 22 Apr 2015 11:08:56 +0300 From: Eli Zaretskii Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' In-reply-to: <05342534-126d-44f4-b415-3159c44740f1@default> X-012-Sender: halo1@inter.net.il To: Drew Adams Message-id: <83bnig4mav.fsf@gnu.org> References: <05342534-126d-44f4-b415-3159c44740f1@default> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 20398 Cc: 20398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Tue, 21 Apr 2015 13:02:01 -0700 (PDT) > From: Drew Adams > > .. shows the error: > window-divider-first-pixel is void as a variable. Not here, it doesn't. It's possible that this problem was already fixed (you are using an ancient binary). Or it's possible that the recipe you used to trigger this is different from what I used (click "Help->Describe->Describe Face", then type "window-divider RET" at the prompt), in which case please show your recipe. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 22 05:34:33 2015 Received: (at 20398) by debbugs.gnu.org; 22 Apr 2015 09:34:33 +0000 Received: from localhost ([127.0.0.1]:35772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ykr3A-0001AE-Nf for submit@debbugs.gnu.org; Wed, 22 Apr 2015 05:34:33 -0400 Received: from mout.gmx.net ([212.227.17.20]:60256) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ykr39-0001A1-Iq for 20398@debbugs.gnu.org; Wed, 22 Apr 2015 05:34:32 -0400 Received: from [188.22.107.239] ([188.22.107.239]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0M6vSj-1ZVxz10fPZ-00wmIk; Wed, 22 Apr 2015 11:34:22 +0200 Message-ID: <55376B18.5090103@gmx.at> Date: Wed, 22 Apr 2015 11:34:16 +0200 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii , Drew Adams Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> In-Reply-To: <83bnig4mav.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:V+GQVjcjRDTfnnxXkzBtxXiE+dGuqhx7qP1yMYfrlbmWummOkxi XF20+/kNG5j07siTh4guUB0lsKAasr5AaksDKwM6uUZJyHhdxL/C+s0RVF1OkTv6TTAP1H6 +MK4qXB/ykZCkiBrOAVu3b+EfTdHqUPzr6dLDn8o7gvOhB/hvg6gSHCv9QSknShswqXHJaZ uLDEskR94Umbhh/iVpuiQ== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20398 Cc: 20398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> .. shows the error: >> window-divider-first-pixel is void as a variable. > > Not here, it doesn't. It's possible that this problem was already > fixed (you are using an ancient binary). Or it's possible that the > recipe you used to trigger this is different from what I used (click > "Help->Describe->Describe Face", then type "window-divider RET" at the > prompt), in which case please show your recipe. It happens in customization buffers. Here I can trigger it by M-x customize-face RET window-divider RET and mouse-clicking 'window-divider-first-pixel' in the doc-string. martin From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 22 06:26:56 2015 Received: (at 20398) by debbugs.gnu.org; 22 Apr 2015 10:26:56 +0000 Received: from localhost ([127.0.0.1]:35785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ykrrr-0002R4-GM for submit@debbugs.gnu.org; Wed, 22 Apr 2015 06:26:55 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:58843) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ykrro-0002Qn-MK for 20398@debbugs.gnu.org; Wed, 22 Apr 2015 06:26:53 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NN700600E92BY00@a-mtaout20.012.net.il> for 20398@debbugs.gnu.org; Wed, 22 Apr 2015 13:26:45 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NN7006YCECL0W90@a-mtaout20.012.net.il>; Wed, 22 Apr 2015 13:26:45 +0300 (IDT) Date: Wed, 22 Apr 2015 13:26:44 +0300 From: Eli Zaretskii Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' In-reply-to: <55376B18.5090103@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <838udk4fx7.fsf@gnu.org> References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 20398 Cc: 20398@debbugs.gnu.org, drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Wed, 22 Apr 2015 11:34:16 +0200 > From: martin rudalics > CC: 20398@debbugs.gnu.org > > I can trigger it by > > M-x customize-face RET window-divider RET > > and mouse-clicking 'window-divider-first-pixel' in the doc-string. That doesn't cause an error, just a message that it's not a variable. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 22 09:42:52 2015 Received: (at 20398) by debbugs.gnu.org; 22 Apr 2015 13:42:52 +0000 Received: from localhost ([127.0.0.1]:35977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YkuvU-0008Qe-97 for submit@debbugs.gnu.org; Wed, 22 Apr 2015 09:42:52 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:37285) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YkuvQ-0008QP-TF for 20398@debbugs.gnu.org; Wed, 22 Apr 2015 09:42:49 -0400 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t3MDggmH024040 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 22 Apr 2015 13:42:42 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t3MDgfmd016671 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 22 Apr 2015 13:42:41 GMT Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t3MDgfgp012503; Wed, 22 Apr 2015 13:42:41 GMT MIME-Version: 1.0 Message-ID: <6737a2dd-2bd3-47fa-acd9-e41550bbb25f@default> Date: Wed, 22 Apr 2015 06:42:40 -0700 (PDT) From: Drew Adams To: Eli Zaretskii , martin rudalics Subject: RE: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' References: <<05342534-126d-44f4-b415-3159c44740f1@default>> <<83bnig4mav.fsf@gnu.org>> <<55376B18.5090103@gmx.at>> <<838udk4fx7.fsf@gnu.org>> In-Reply-To: <<838udk4fx7.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20398 Cc: 20398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > > I can trigger it by > > M-x customize-face RET window-divider RET > > and mouse-clicking 'window-divider-first-pixel' in the doc-string. >=20 > That doesn't cause an error, just a message that it's not a > variable. The point is that from that customization buffer, for the related face whose help mentions this face, you should be able to get to this face. A guess is that it might suffice to put the word "face" before the face name in the doc string. Just a wild guess. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 22 18:50:17 2015 Received: (at 20398) by debbugs.gnu.org; 22 Apr 2015 22:50:17 +0000 Received: from localhost ([127.0.0.1]:36862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yl3TF-0005y1-59 for submit@debbugs.gnu.org; Wed, 22 Apr 2015 18:50:17 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:47970 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yl3TC-0005xq-Qh for 20398@debbugs.gnu.org; Wed, 22 Apr 2015 18:50:15 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Yl3TB-0007Sf-FI; Wed, 22 Apr 2015 18:50:13 -0400 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> X-Spook: cybercash AK-47 sweep North Korea SRI Kh-11 Albanian ANC X-Ran: wyH,;)z_7EE2Q_0wUsOca!KMp>2GL(Qcr&W-Vvlc7sQ.CZ5{vKkieE&2,fB[)ZUGX|KfHc X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 22 Apr 2015 18:50:13 -0400 In-Reply-To: <838udk4fx7.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 22 Apr 2015 13:26:44 +0300") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 20398 Cc: martin rudalics , 20398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Eli Zaretskii wrote: >> M-x customize-face RET window-divider RET >> >> and mouse-clicking 'window-divider-first-pixel' in the doc-string. > > That doesn't cause an error, just a message that it's not a variable. widget-documentation-link-action is surprisingly simplistic. It doesn't even know that faces exist. It should do what `help-make-xrefs' does, and use the presence of "face" etc in the doc string as a cue. Ideally it would reuse the same code. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 23 03:50:49 2015 Received: (at 20398) by debbugs.gnu.org; 23 Apr 2015 07:50:49 +0000 Received: from localhost ([127.0.0.1]:37075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YlBuK-00031D-Oy for submit@debbugs.gnu.org; Thu, 23 Apr 2015 03:50:48 -0400 Received: from mout.gmx.net ([212.227.17.20]:61954) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YlBuH-00030m-TG for 20398@debbugs.gnu.org; Thu, 23 Apr 2015 03:50:46 -0400 Received: from [88.117.55.138] ([88.117.55.138]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MYbFe-1YqC6v0RfO-00VS2M; Thu, 23 Apr 2015 09:50:39 +0200 Message-ID: <5538A449.6010308@gmx.at> Date: Thu, 23 Apr 2015 09:50:33 +0200 From: martin rudalics MIME-Version: 1.0 To: Glenn Morris , Eli Zaretskii Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:tZu79uGtJF8+szQObXCyiQI/C2u/GJa+wRWZNUvtnFfnPw1SYBm KBUmNFfy6fpbmc7qguvRGNpI2eohBP23wU2hR6h+pW1BvoZaPVyd/JqaFuACl0qsoRTPpAy c4oswpgZMbX7DMZ2Sk83WdzSSCr+0W8yViN/FvafvFLI9W7wdapZ0KbUG8yo1sPJKmMxLFr jD5QRpBZopbE/SkZvq7kA== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20398 Cc: 20398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > widget-documentation-link-action is surprisingly simplistic. I tried to make following links less simplistic in 557c7d6..62fe329 on master. > It doesn't even know that faces exist. > It should do what `help-make-xrefs' does, and use the presence of "face" > etc in the doc string as a cue. Ideally it would reuse the same code. Ideally, yes. Currently, I'm troubled by Debugger entered--Lisp error: (error "No selection is available") signal(error ("No selection is available")) error("No selection is available") gui-get-primary-selection() mouse-yank-primary((mouse-2 (# 615 (355 . 257) 4390875 nil 615 (42 . 14) nil (3 . 7) (8 . 16)))) funcall-interactively(mouse-yank-primary (mouse-2 (# 615 (355 . 257) 4390875 nil 615 (42 . 14) nil (3 . 7) (8 . 16)))) call-interactively(mouse-yank-primary nil nil) command-execute(mouse-yank-primary) with on any such link in a customization buffer. Can anyone see this? Does anyone have an idea where this mouse-2 yanking attempt comes from? martin From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 23 06:37:26 2015 Received: (at 20398) by debbugs.gnu.org; 23 Apr 2015 10:37:26 +0000 Received: from localhost ([127.0.0.1]:37163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YlEVZ-0007Jf-JO for submit@debbugs.gnu.org; Thu, 23 Apr 2015 06:37:25 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:36707) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YlEVW-0007JM-9T for 20398@debbugs.gnu.org; Thu, 23 Apr 2015 06:37:23 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NN9007009EZXR00@a-mtaout21.012.net.il> for 20398@debbugs.gnu.org; Thu, 23 Apr 2015 13:37:15 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NN9007ZN9I3R490@a-mtaout21.012.net.il>; Thu, 23 Apr 2015 13:37:15 +0300 (IDT) Date: Thu, 23 Apr 2015 13:37:16 +0300 From: Eli Zaretskii Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' In-reply-to: <5538A449.6010308@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <83vbgn1677.fsf@gnu.org> References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> <5538A449.6010308@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 20398 Cc: rgm@gnu.org, 20398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Thu, 23 Apr 2015 09:50:33 +0200 > From: martin rudalics > CC: 20398@debbugs.gnu.org > > I'm troubled by > > > Debugger entered--Lisp error: (error "No selection is available") > signal(error ("No selection is available")) > error("No selection is available") > gui-get-primary-selection() > mouse-yank-primary((mouse-2 (# 615 (355 . 257) 4390875 nil 615 (42 . 14) nil (3 . 7) (8 . 16)))) > funcall-interactively(mouse-yank-primary (mouse-2 (# 615 (355 . 257) 4390875 nil 615 (42 . 14) nil (3 . 7) (8 . 16)))) > call-interactively(mouse-yank-primary nil nil) > command-execute(mouse-yank-primary) > > > with on any such link in a customization buffer. Can anyone > see this? I see this. Everyone should, AFAICS. > Does anyone have an idea where this mouse-2 yanking attempt comes > from? It comes from the command loop. I think mouse-1 remapping, as implied by the return value of mouse-on-link-p, has something to do with that. From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 05:00:44 2015 Received: (at 20398) by debbugs.gnu.org; 2 May 2015 09:00:44 +0000 Received: from localhost ([127.0.0.1]:59115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YoTHv-0004qm-K8 for submit@debbugs.gnu.org; Sat, 02 May 2015 05:00:44 -0400 Received: from mout.gmx.net ([212.227.17.22]:54723) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YoTHs-0004qI-F1 for 20398@debbugs.gnu.org; Sat, 02 May 2015 05:00:41 -0400 Received: from [194.118.143.216] ([194.118.143.216]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MEFqW-1Z3tc13sAC-00FX4c; Sat, 02 May 2015 11:00:34 +0200 Message-ID: <55449178.8020309@gmx.at> Date: Sat, 02 May 2015 10:57:28 +0200 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> <5538A449.6010308@gmx.at> <83vbgn1677.fsf@gnu.org> In-Reply-To: <83vbgn1677.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:W4GKYm/KAapx9CcOLEvCBg4JiKIeU05DAsh3+UbK8JgJ9NZhMEe musHHXFyRQxOABa3yr8EuybIKQdE76h6TB0hAWb7SM81osMedHii7G4zO6DdrpvFBCjYbaL yQOI+6zOcwq2evhCks4/JZrZAfTOrefn06oNtecMP9DNgkBtGPevJS/tYS/Q1pGh7Kq0dL1 /W3twgjhI5C1coG8ivXrA== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20398 Cc: rgm@gnu.org, 20398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> Debugger entered--Lisp error: (error "No selection is available") >> signal(error ("No selection is available")) >> error("No selection is available") >> gui-get-primary-selection() >> mouse-yank-primary((mouse-2 (# 615 (355 . 257) 4390875 nil 615 (42 . 14) nil (3 . 7) (8 . 16)))) >> funcall-interactively(mouse-yank-primary (mouse-2 (# 615 (355 . 257) 4390875 nil 615 (42 . 14) nil (3 . 7) (8 . 16)))) >> call-interactively(mouse-yank-primary nil nil) >> command-execute(mouse-yank-primary) >> >> >> with on any such link in a customization buffer. Can anyone >> see this? > > I see this. Everyone should, AFAICS. > >> Does anyone have an idea where this mouse-2 yanking attempt comes >> from? > > It comes from the command loop. I think mouse-1 remapping, as > implied by the return value of mouse-on-link-p, has something to do > with that. If someone just told me how to investigate this. So far I failed miserably to do that :-( martin From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 05:10:09 2015 Received: (at 20398) by debbugs.gnu.org; 2 May 2015 09:10:10 +0000 Received: from localhost ([127.0.0.1]:59124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YoTR3-00056K-3W for submit@debbugs.gnu.org; Sat, 02 May 2015 05:10:09 -0400 Received: from mtaout28.012.net.il ([80.179.55.184]:45556) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YoTQx-00055f-9O for 20398@debbugs.gnu.org; Sat, 02 May 2015 05:10:05 -0400 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NNP00O00T2DS800@mtaout28.012.net.il> for 20398@debbugs.gnu.org; Sat, 02 May 2015 12:08:50 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NNP00NZZTEQW210@mtaout28.012.net.il>; Sat, 02 May 2015 12:08:50 +0300 (IDT) Date: Sat, 02 May 2015 12:09:40 +0300 From: Eli Zaretskii Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' In-reply-to: <55449178.8020309@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <83twvvpcq3.fsf@gnu.org> References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> <5538A449.6010308@gmx.at> <83vbgn1677.fsf@gnu.org> <55449178.8020309@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 20398 Cc: rgm@gnu.org, 20398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sat, 02 May 2015 10:57:28 +0200 > From: martin rudalics > CC: rgm@gnu.org, 20398@debbugs.gnu.org > > >> Does anyone have an idea where this mouse-2 yanking attempt comes > >> from? > > > > It comes from the command loop. I think mouse-1 remapping, as > > implied by the return value of mouse-on-link-p, has something to do > > with that. > > If someone just told me how to investigate this. So far I failed > miserably to do that :-( I cannot be that person: I also tried and failed. Sorry. From debbugs-submit-bounces@debbugs.gnu.org Sun May 03 01:42:26 2015 Received: (at 20398) by debbugs.gnu.org; 3 May 2015 05:42:26 +0000 Received: from localhost ([127.0.0.1]:60150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YomfZ-0003P3-Rt for submit@debbugs.gnu.org; Sun, 03 May 2015 01:42:26 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:19056) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YomfX-0003Oq-LP for 20398@debbugs.gnu.org; Sun, 03 May 2015 01:42:24 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AnEFAGvvdVRFpYts/2dsb2JhbAA3gVOfQYIugQiBdQEBBAFWIwULCzQSFBgNJIgTohGLeWsHAgECAQKDPgODcASjY4RY X-IPAS-Result: AnEFAGvvdVRFpYts/2dsb2JhbAA3gVOfQYIugQiBdQEBBAFWIwULCzQSFBgNJIgTohGLeWsHAgECAQKDPgODcASjY4RY X-IronPort-AV: E=Sophos;i="5.11,557,1422939600"; d="scan'208";a="118124501" Received: from 69-165-139-108.dsl.teksavvy.com (HELO ceviche.home) ([69.165.139.108]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 03 May 2015 01:42:18 -0400 Received: by ceviche.home (Postfix, from userid 20848) id C7EE26610A; Sun, 3 May 2015 01:42:17 -0400 (EDT) From: Stefan Monnier To: martin rudalics Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' Message-ID: References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> <5538A449.6010308@gmx.at> <83vbgn1677.fsf@gnu.org> <55449178.8020309@gmx.at> Date: Sun, 03 May 2015 01:42:17 -0400 In-Reply-To: <55449178.8020309@gmx.at> (martin rudalics's message of "Sat, 02 May 2015 10:57:28 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 20398 Cc: 20398@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > If someone just told me how to investigate this. So far I failed > miserably to do that :-( I'll have to try and investigate it, to see how/if I could help you with it, Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun May 03 11:04:56 2015 Received: (at 20398) by debbugs.gnu.org; 3 May 2015 15:04:57 +0000 Received: from localhost ([127.0.0.1]:60837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YovRw-0003qA-B8 for submit@debbugs.gnu.org; Sun, 03 May 2015 11:04:56 -0400 Received: from mout.gmx.net ([212.227.15.19]:64524) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YovRu-0003pv-5C for 20398@debbugs.gnu.org; Sun, 03 May 2015 11:04:54 -0400 Received: from [91.113.2.114] ([91.113.2.114]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MAgvb-1YzblI49oB-00Bwxe; Sun, 03 May 2015 17:04:44 +0200 Message-ID: <55463900.6090709@gmx.at> Date: Sun, 03 May 2015 17:04:32 +0200 From: martin rudalics MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> <5538A449.6010308@gmx.at> <83vbgn1677.fsf@gnu.org> <55449178.8020309@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:pEx+DEzj8z0dwNVMkOc1C5tQk1PXH/pVK/qAVzOuqPKLKx446oT 1Zog5IPQc8jQiu1ZCx0F3VRQNir1rh76H6bb5PCuzaomTFAfU6HvluQEXeWwhO55YLhTSoX gxWrpSdYwKbbXVRtZRlUyzwAxhNWV+CHRIAjp/5C2QVeX7OcTD3yPFy26rTKzltKy23xq6Z Wjj5bha3SU3ZleEeN3D7A== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20398 Cc: 20398@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > I'll have to try and investigate it, to see how/if I could help you with > it, It's been already reported as Bug#19185. The only solution I can think of is the trivial one below. martin --- a/lisp/wid-edit.el +++ b/lisp/wid-edit.el @@ -854,6 +854,9 @@ button end points." (define-key map [backtab] 'widget-backward) (define-key map [down-mouse-2] 'widget-button-click) (define-key map [down-mouse-1] 'widget-button-click) + ;; Avoid `mouse-yank-primary' with `mouse-1-click-follows-link' + ;; non-nil (Bug#19185). + (define-key map [mouse-2] 'widget-button-click) ;; The following definition needs to avoid using escape sequences that ;; might get converted to ^M when building loaddefs.el (define-key map [(control ?m)] 'widget-button-press) From debbugs-submit-bounces@debbugs.gnu.org Sun May 03 21:56:10 2015 Received: (at 20398) by debbugs.gnu.org; 4 May 2015 01:56:10 +0000 Received: from localhost ([127.0.0.1]:32893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yp5cA-0005FX-Ep for submit@debbugs.gnu.org; Sun, 03 May 2015 21:56:10 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:39523) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yp5c8-0005FL-OZ for 20398@debbugs.gnu.org; Sun, 03 May 2015 21:56:09 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AnEFAGvvdVRFpYts/2dsb2JhbAA3gVOfQYIugQiBdQEBBAFWIxALNBIUGA0kLodlohGLeShMAwODPgMDg20Eo2OEWA X-IPAS-Result: AnEFAGvvdVRFpYts/2dsb2JhbAA3gVOfQYIugQiBdQEBBAFWIxALNBIUGA0kLodlohGLeShMAwODPgMDg20Eo2OEWA X-IronPort-AV: E=Sophos;i="5.11,557,1422939600"; d="scan'208";a="118164020" Received: from 69-165-139-108.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([69.165.139.108]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 03 May 2015 21:56:03 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 2E9B3AE12D; Sun, 3 May 2015 21:56:02 -0400 (EDT) From: Stefan Monnier To: martin rudalics Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' Message-ID: References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> <5538A449.6010308@gmx.at> <83vbgn1677.fsf@gnu.org> <55449178.8020309@gmx.at> <55463900.6090709@gmx.at> Date: Sun, 03 May 2015 21:56:02 -0400 In-Reply-To: <55463900.6090709@gmx.at> (martin rudalics's message of "Sun, 03 May 2015 17:04:32 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 20398 Cc: 20398@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> I'll have to try and investigate it, to see how/if I could help you with it, > It's been already reported as Bug#19185. The only solution I can think > of is the trivial one below. Oh, yes I investigated already and IIRC the problem is in widget-button-click: it's bound to the down-event but is really a binding for the up event. IIRC I didn't manage to fully understand the problem, but my impression that widget-button-click should be split into two parts: one part bound to the down-event (which would mostly do the "redraw the button as pressed") and another bound to the up-event (which performs the actual action associated with the click). So I think the workaround you suggest is not that bad. It's not a full solution, but it does go in the right direction. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 14:27:45 2016 Received: (at control) by debbugs.gnu.org; 30 Apr 2016 18:27:45 +0000 Received: from localhost ([127.0.0.1]:58346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awZcG-0008F2-Tx for submit@debbugs.gnu.org; Sat, 30 Apr 2016 14:27:45 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:59380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awZcF-0008Eu-6h for control@debbugs.gnu.org; Sat, 30 Apr 2016 14:27:43 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1awZcC-0005P8-W4 for control@debbugs.gnu.org; Sat, 30 Apr 2016 20:27:42 +0200 Date: Sat, 30 Apr 2016 20:27:40 +0200 Message-Id: <87mvobdk9v.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #20398 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) forcemerge 20398 19185 From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 14:28:43 2016 Received: (at 20398) by debbugs.gnu.org; 30 Apr 2016 18:28:43 +0000 Received: from localhost ([127.0.0.1]:58351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awZdD-0008Gv-69 for submit@debbugs.gnu.org; Sat, 30 Apr 2016 14:28:43 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:59392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awZdB-0008Gn-C5 for 20398@debbugs.gnu.org; Sat, 30 Apr 2016 14:28:41 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1awZd4-0005Pe-8a; Sat, 30 Apr 2016 20:28:36 +0200 From: Lars Ingebrigtsen To: martin rudalics Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> <5538A449.6010308@gmx.at> <83vbgn1677.fsf@gnu.org> <55449178.8020309@gmx.at> <55463900.6090709@gmx.at> Date: Sat, 30 Apr 2016 20:28:33 +0200 In-Reply-To: <55463900.6090709@gmx.at> (martin rudalics's message of "Sun, 03 May 2015 17:04:32 +0200") Message-ID: <87inyzdk8e.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20398 Cc: 20398@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) martin rudalics writes: > It's been already reported as Bug#19185. The only solution I can think > of is the trivial one below. > > martin > > --- a/lisp/wid-edit.el > +++ b/lisp/wid-edit.el > @@ -854,6 +854,9 @@ button end points." > (define-key map [backtab] 'widget-backward) > (define-key map [down-mouse-2] 'widget-button-click) > (define-key map [down-mouse-1] 'widget-button-click) > + ;; Avoid `mouse-yank-primary' with `mouse-1-click-follows-link' > + ;; non-nil (Bug#19185). > + (define-key map [mouse-2] 'widget-button-click) > ;; The following definition needs to avoid using escape sequences that > ;; might get converted to ^M when building loaddefs.el [...] > So I think the workaround you suggest is not that bad. It's not a full > solution, but it does go in the right direction. Martin, you never applied your patch. Was there a reason for that? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 14:50:49 2016 Received: (at 20398) by debbugs.gnu.org; 30 Apr 2016 18:50:49 +0000 Received: from localhost ([127.0.0.1]:58392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awZya-0003fb-Uu for submit@debbugs.gnu.org; Sat, 30 Apr 2016 14:50:49 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:56401) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awZyZ-0003fT-1e for 20398@debbugs.gnu.org; Sat, 30 Apr 2016 14:50:47 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u3UIofwq011363; Sat, 30 Apr 2016 14:50:43 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 13FB8663ED; Sat, 30 Apr 2016 14:51:05 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' Message-ID: References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> <5538A449.6010308@gmx.at> <83vbgn1677.fsf@gnu.org> <55449178.8020309@gmx.at> <55463900.6090709@gmx.at> <87inyzdk8e.fsf@gnus.org> Date: Sat, 30 Apr 2016 14:51:05 -0400 In-Reply-To: <87inyzdk8e.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 30 Apr 2016 20:28:33 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5658=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5658> : inlines <4747> : streams <1627861> : uri <2200493> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20398 Cc: martin rudalics , Eli Zaretskii , 20398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) >> (define-key map [backtab] 'widget-backward) >> (define-key map [down-mouse-2] 'widget-button-click) >> (define-key map [down-mouse-1] 'widget-button-click) >> + ;; Avoid `mouse-yank-primary' with `mouse-1-click-follows-link' >> + ;; non-nil (Bug#19185). >> + (define-key map [mouse-2] 'widget-button-click) That seems to imply that widget-button-click will be run twice (once on the down part and once on the up part). How 'bout binding one of the two to `undefined' instead? Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 15:26:55 2016 Received: (at 20398) by debbugs.gnu.org; 30 Apr 2016 19:26:55 +0000 Received: from localhost ([127.0.0.1]:58443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awaXX-0006Cv-2o for submit@debbugs.gnu.org; Sat, 30 Apr 2016 15:26:55 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:57316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awaXV-0006Cn-QX for 20398@debbugs.gnu.org; Sat, 30 Apr 2016 15:26:54 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u3UJQp72012318; Sat, 30 Apr 2016 15:26:52 -0400 Received: by ceviche.home (Postfix, from userid 20848) id ACF87663ED; Sat, 30 Apr 2016 15:27:22 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' Message-ID: References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> <5538A449.6010308@gmx.at> <83vbgn1677.fsf@gnu.org> <55449178.8020309@gmx.at> <55463900.6090709@gmx.at> <87inyzdk8e.fsf@gnus.org> Date: Sat, 30 Apr 2016 15:27:22 -0400 In-Reply-To: (Stefan Monnier's message of "Sat, 30 Apr 2016 14:51:05 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5658=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5658> : inlines <4747> : streams <1627875> : uri <2200511> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20398 Cc: martin rudalics , Eli Zaretskii , 20398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) >>> (define-key map [backtab] 'widget-backward) >>> (define-key map [down-mouse-2] 'widget-button-click) >>> (define-key map [down-mouse-1] 'widget-button-click) >>> + ;; Avoid `mouse-yank-primary' with `mouse-1-click-follows-link' >>> + ;; non-nil (Bug#19185). >>> + (define-key map [mouse-2] 'widget-button-click) > That seems to imply that widget-button-click will be run twice (once on > the down part and once on the up part). > How 'bout binding one of the two to `undefined' instead? Or just *move* the binding from [down-mouse-2] to [mouse-2] (since it's a click binding and clicks should be bound to the up event rather than the down event). Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun May 01 04:24:07 2016 Received: (at 20398) by debbugs.gnu.org; 1 May 2016 08:24:07 +0000 Received: from localhost ([127.0.0.1]:59013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awmfe-0005kN-V0 for submit@debbugs.gnu.org; Sun, 01 May 2016 04:24:07 -0400 Received: from mout.gmx.net ([212.227.17.20]:54708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awmfd-0005js-H6 for 20398@debbugs.gnu.org; Sun, 01 May 2016 04:24:05 -0400 Received: from [192.168.1.101] ([212.95.7.30]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0LzHZ7-1bimkx0FiD-014Vvc; Sun, 01 May 2016 10:23:58 +0200 Message-ID: <5725BD16.6020900@gmx.at> Date: Sun, 01 May 2016 10:23:50 +0200 From: martin rudalics MIME-Version: 1.0 To: Stefan Monnier , Lars Ingebrigtsen Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> <5538A449.6010308@gmx.at> <83vbgn1677.fsf@gnu.org> <55449178.8020309@gmx.at> <55463900.6090709@gmx.at> <87inyzdk8e.fsf@gnus.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:umZg1iffEhHKgfMkFabXImY2xu/OIvTqdusCN3F1k6xLITNkGS6 5ITCBj21G70ZjYrw+VTh8/kTbRJzPK7uhaCy26Plkf36FTWnzj3KP3BCd2UJqmiQpHaPJvb Q1YmG3n4BpObLcfzuCn0mfwpVMzpamy6bh+PiyMSLi/yqC7m6jXMiLIuxFagfXe9UpZOvxl tcFYHXw5Az/wO2zUSDTSg== X-UI-Out-Filterresults: notjunk:1;V01:K0:b31/Y5Y9o2U=:McKej1tygpkwjlhy6PCdZ/ 2/fYGvzGxowWuJfuYEutpdzNIuLqs8SrN4ro2k8fkmnXVu7wv97W683tv51dgcyImdqxDyg9W gm8f+jAbEZOwF0rmNvga98BPFI67MuuSiY/Milw8ph5lrzbuln9glG6AMcIk7CiYNWGm3iXiD bGVOzYC68O2AD389DeaT7Z8WGAwGTbOkpX40I6DW5PyVRI8ceIKBAyX7mVqNfDxIrYW3AHeKc QZvsU8SJKLNzDpzljj0H8xMFQpfoe1xVG0Dk2K8UM5n4ronylDKa6Vr5iftNta1NHCbwuJf21 Y77HnDQzM8B/znWuVmUKJx3QbSu8QhWeg04MrVVGQMp1ZEVvnDuUWRKxlYuiqe8PvFFtuM04l iWWff0Uco5xcY7LHOlZi4PFqe++z5HbI6Wut3Mxkju+ur+UC7ep+OJ311aqFm2/X2YEjDZzci 521WmPPM6CFmHB+hlDNiGO1fS1u+Rjx61M28GtZiZzOdPCiUbv5y2alCwv6vQB//OcBetklKy Filg2tns6jSNVYHKAbCJz3sWv1ojRCeXLyyawZ9e4a5/+4B3KmQS4wJi4ZCXfqDv3Ph96TQoi H9AlnHqBK4fLyAKHKjTrKW+xD+FUYHgVq1mUrkDX/8yFR1q1cDFDntHHQGz4gS96Ne7trcN05 numkFcLwPW8ad+9/5Uqa59RlGRb/pmfkn7X7IOdkU4rwPfDVXLJz5PkpYSoXYAQmj74+uunDf 1aNArudsYF0VeKPuMlwLvEEywI2S+qYqUY/k2i0jvHyPhTopcXtFRD27hupSBv524kLNWxhaw WdLtdkn3O+snJi+P/K/nGS19Hv9Dg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20398 Cc: 20398@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >>>> (define-key map [backtab] 'widget-backward) >>>> (define-key map [down-mouse-2] 'widget-button-click) >>>> (define-key map [down-mouse-1] 'widget-button-click) >>>> + ;; Avoid `mouse-yank-primary' with `mouse-1-click-follows-link' >>>> + ;; non-nil (Bug#19185). >>>> + (define-key map [mouse-2] 'widget-button-click) > >> That seems to imply that widget-button-click will be run twice (once on >> the down part and once on the up part). >> How 'bout binding one of the two to `undefined' instead? > > Or just *move* the binding from [down-mouse-2] to [mouse-2] (since it's > a click binding and clicks should be bound to the up event rather than > the down event). Shouldn't we then do the same here: >>>> (define-key map [down-mouse-1] 'widget-button-click) martin From debbugs-submit-bounces@debbugs.gnu.org Sun May 01 04:24:12 2016 Received: (at 20398) by debbugs.gnu.org; 1 May 2016 08:24:12 +0000 Received: from localhost ([127.0.0.1]:59016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awmfk-0005ke-57 for submit@debbugs.gnu.org; Sun, 01 May 2016 04:24:12 -0400 Received: from mout.gmx.net ([212.227.17.20]:59878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awmfi-0005jt-Fu for 20398@debbugs.gnu.org; Sun, 01 May 2016 04:24:10 -0400 Received: from [192.168.1.101] ([212.95.7.30]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0Lyj4F-1biEWZ2YAJ-016AUV; Sun, 01 May 2016 10:23:56 +0200 Message-ID: <5725BD10.8050502@gmx.at> Date: Sun, 01 May 2016 10:23:44 +0200 From: martin rudalics MIME-Version: 1.0 To: Lars Ingebrigtsen Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> <5538A449.6010308@gmx.at> <83vbgn1677.fsf@gnu.org> <55449178.8020309@gmx.at> <55463900.6090709@gmx.at> <87inyzdk8e.fsf@gnus.org> In-Reply-To: <87inyzdk8e.fsf@gnus.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:pOEI1hEgo5lkRw2xt5/ZftHQNBcccrNK2LCy1vQZQg6Q/AAbS2m SFhtqJecii1LJxaA8Kwz4zbfH85pTee2vtM5Lt4rjnLJ9Qjp5ZDrpue4aPwnnkEes505CL3 01N4hJOv0TNkAgY6FqaTtyf646F70Q+UQtUyWPOP1rbkr3pqAA2Jge/inCDH3+JdJdB4bXQ P/XBDRbaQ2lL9FQZLOFBw== X-UI-Out-Filterresults: notjunk:1;V01:K0:2yuUM9v7SZo=:BMFnmsZpciwPP8wk6XdL8I uUAt/uQBIvtEUwHpHDas1cykojBBDciLR/NDW0qyXe+2kwK1p0qH+XI1yWFpiF3QJE4InFdvV MRAoqxk19Ju8MCM7adXWKMIJH/0SGWHuyfGlPQF1EMqM0nXBVS7vbNlreJosRBquz0NzYQadO LS7qlX43EmdGHoCA+g1KwmYpHW6OLAcEuFTiKtvzjBDJjDy4PWQvIoZ1dMKIFXuctCW6hcdy6 kntmzjDBQvr0k+NAUJIlijVPlhtg0LuXG4Fa1AsKo8NileLL7Nx5CG1NHOlZMPB8xlj86BMTa sUV0CtdDapDWzPtSRo38xR6bQm0ufyRwI/1/AmLbrIB6zWYnSoNLSkEhENTf6NxoB3oalWo17 OY+0efAxbgIBMTZq9WsKSAdPA4Ag28LaiY4bGMz479qR03nv8dDFjir++YQOZ0wPQ3IaCNNxk GQvt8D++HFISTpJflBtP3gCnH+1BTDReWJR4bWYllrqYSGEVpjdu4ofq7X9kU1tpbNRvq7bCr BlwZLyCBaTIptFfJ1KK0YVNZySJgbo6701DzAv16QEsRXzjHdJigaPa5udJbx1NvuR8bMm5l7 sb2DZZ6Kh622uKLz8j+cjNcnw8MUYQ+1Ujk9qd4zCb/NhzJQ48UmDV1DzVH8CE0iQfZ2b1Wr/ OfMw4iN5Pfmlx6Re4voCnYQYLKEFkUaYGPduBWp4GgBkIZ/IamsOaQbNbu9Ypjdx4SUf90ti8 OD0C0FlJVUGVx+CjpJwInZKJ1OoN8TAcMvC5j+k8ckJFClHXbxZkzMLCtluY2am1jqBSAx3wA kKWetvV1yv7R3G7s3f6kONSDLXnPg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20398 Cc: 20398@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >> So I think the workaround you suggest is not that bad. It's not a full >> solution, but it does go in the right direction. > > Martin, you never applied your patch. Was there a reason for that? It was a half-baked idea IIRC. This issue requires more work, I'm afraid. martin From debbugs-submit-bounces@debbugs.gnu.org Sun May 01 09:15:19 2016 Received: (at 20398) by debbugs.gnu.org; 1 May 2016 13:15:19 +0000 Received: from localhost ([127.0.0.1]:59127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awrDT-0005v6-D7 for submit@debbugs.gnu.org; Sun, 01 May 2016 09:15:19 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:52997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awrDR-0005uw-Cn for 20398@debbugs.gnu.org; Sun, 01 May 2016 09:15:18 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u41DFELH007159; Sun, 1 May 2016 09:15:15 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 1DA2C66404; Sun, 1 May 2016 09:15:47 -0400 (EDT) From: Stefan Monnier To: martin rudalics Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' Message-ID: References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> <5538A449.6010308@gmx.at> <83vbgn1677.fsf@gnu.org> <55449178.8020309@gmx.at> <55463900.6090709@gmx.at> <87inyzdk8e.fsf@gnus.org> <5725BD16.6020900@gmx.at> Date: Sun, 01 May 2016 09:15:47 -0400 In-Reply-To: <5725BD16.6020900@gmx.at> (martin rudalics's message of "Sun, 01 May 2016 10:23:50 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5659=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5659> : inlines <4747> : streams <1628267> : uri <2201046> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20398 Cc: 20398@debbugs.gnu.org, Lars Ingebrigtsen , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > Shouldn't we then do the same here: >>>>> (define-key map [down-mouse-1] 'widget-button-click) I think so, yes. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon May 02 04:00:41 2016 Received: (at 20398) by debbugs.gnu.org; 2 May 2016 08:00:41 +0000 Received: from localhost ([127.0.0.1]:32988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ax8mX-0005iR-7g for submit@debbugs.gnu.org; Mon, 02 May 2016 04:00:41 -0400 Received: from mout.gmx.net ([212.227.17.22]:53675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ax8mW-0005iF-3F for 20398@debbugs.gnu.org; Mon, 02 May 2016 04:00:40 -0400 Received: from [192.168.1.101] ([212.95.7.50]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0LejNC-1bSfya2oGc-00qQuB; Mon, 02 May 2016 10:00:30 +0200 Message-ID: <57270911.8010309@gmx.at> Date: Mon, 02 May 2016 10:00:17 +0200 From: martin rudalics MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> <5538A449.6010308@gmx.at> <83vbgn1677.fsf@gnu.org> <55449178.8020309@gmx.at> <55463900.6090709@gmx.at> <87inyzdk8e.fsf@gnus.org> <5725BD16.6020900@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:FFxCtH6nQfKzezpIbMnNZLzNFvqeOqBgEphyc/uzk7pRLlTN3Lj JwVoCuIpXKRCbjETYC+5/CLLsL2EEfTj76n4D7O6z2jnyOuSOKaADcNMqYcOtWWgGwoagqV t/2iIHZcF5lHMRFv6slVQRzezFVU+5wK+iYaQQCx9HOg+1KDENb6I8BZ2T6GK/wobwsZu21 JlAbcgAIbRmNFa4CYPNWQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:iSsQWeLMQ2U=:g6sq2P0pD21xF450R8bzml K7J1qGBHKav4gFPBnWQg8y9Fy5/HfkveHD1ANd0+gPZzG9HcT7GBRFT9I1+ukRcjdaim/orta JujkxdMOzyrUugqprmkmUE4Zdao5RUM/KJ1fbFELVRil8MrCtJUsXf2HLBp4ud5XPwyQJXM32 snawea373WPu3ZAL0cZR0tPwOvC6oBvr9HfZhUnY5ZMq7g9TVmdBknal4/2XNahw9lgs5v6wK jLy5JZk6PeVpCy6elcLhX0+iCyukw4Ee8leQEvv7RtcQx4+/sK2bjhPxRk+FxTieAFVqLHGt7 H4MaxTMd/zzt7KjMvqVz23WLHRASZyDDrtw+otQhEpECidZzE1Z6ABftZlieKa20XN52x5v+K 1YX/0pABLr6FqD0Jv2t5M5Nb9ixafJU77PYaa3gEFc2r4g+bu+H07uwi3fiEU8SvpyB00YrmF wowego0pOkrCKAb81Du5NPhsffCZB04/CyjAr+h3+dyqN7l8BK3+Vw4xiabAPwLu8ggwIEmGt V5IdRESZDtu8RMoXV7BNY1kcTvbJItBf8Q9GHqSO/isBWMJ7cFRUjtDiekC4zzY4VTK/pRee+ 3vu1Fy91ybI4sAxjkxTbKmQAnJhk/IjrHBWAbYIwSkIPl/l88oApF4rNTllC/vHNKay8QVrVG 67gM8ROBgkJfoACKFbF35P+PUmPbVGKFPWnG5YjxcoDGm08+1ZPc/70HAQnbTC6Pc6YJw9V3J ttEULNwQVS+uCOM660ISkIM0meErN2pVyR2/fIFQPNdVOx3zNi8nxx/QcbMKLgxUnzGx5h8sM xZ4gQRCVPEI7eXQzlhrJYCWEeyuCw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20398 Cc: 20398@debbugs.gnu.org, Lars Ingebrigtsen , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >> Shouldn't we then do the same here: >>>>>> (define-key map [down-mouse-1] 'widget-button-click) > > I think so, yes. So the patch is as below. Any objections to apply this to the emacs-25 branch? martin diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el index f0054be..0a0f458 100644 --- a/lisp/wid-edit.el +++ b/lisp/wid-edit.el @@ -852,8 +852,8 @@ widget-keymap (define-key map [(shift tab)] 'widget-backward) (put 'widget-backward :advertised-binding [(shift tab)]) (define-key map [backtab] 'widget-backward) - (define-key map [down-mouse-2] 'widget-button-click) - (define-key map [down-mouse-1] 'widget-button-click) + (define-key map [mouse-2] 'widget-button-click) + (define-key map [mouse-1] 'widget-button-click) ;; The following definition needs to avoid using escape sequences that ;; might get converted to ^M when building loaddefs.el (define-key map [(control ?m)] 'widget-button-press) From debbugs-submit-bounces@debbugs.gnu.org Mon May 02 13:14:03 2016 Received: (at 20398) by debbugs.gnu.org; 2 May 2016 17:14:03 +0000 Received: from localhost ([127.0.0.1]:34114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1axHQ3-00017R-0a for submit@debbugs.gnu.org; Mon, 02 May 2016 13:14:03 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:40973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1axHQ0-00016t-Ld for 20398@debbugs.gnu.org; Mon, 02 May 2016 13:14:01 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1axHPu-00060k-Rp; Mon, 02 May 2016 19:13:56 +0200 From: Lars Ingebrigtsen To: martin rudalics Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> <5538A449.6010308@gmx.at> <83vbgn1677.fsf@gnu.org> <55449178.8020309@gmx.at> <55463900.6090709@gmx.at> <87inyzdk8e.fsf@gnus.org> <5725BD16.6020900@gmx.at> <57270911.8010309@gmx.at> Date: Mon, 02 May 2016 19:13:53 +0200 In-Reply-To: <57270911.8010309@gmx.at> (martin rudalics's message of "Mon, 02 May 2016 10:00:17 +0200") Message-ID: <87zis8v0vi.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20398 Cc: 20398@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) martin rudalics writes: > So the patch is as below. Any objections to apply this to the emacs-25 > branch? [...] > - (define-key map [down-mouse-2] 'widget-button-click) > - (define-key map [down-mouse-1] 'widget-button-click) > + (define-key map [mouse-2] 'widget-button-click) > + (define-key map [mouse-1] 'widget-button-click) Isn't this a rather large change to go in at this point? People may have rebound `down-mouse-1' (etc) instead of `mouse-1'... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue May 03 02:45:01 2016 Received: (at 20398-done) by debbugs.gnu.org; 3 May 2016 06:45:02 +0000 Received: from localhost ([127.0.0.1]:34445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1axU4r-0008F1-Pc for submit@debbugs.gnu.org; Tue, 03 May 2016 02:45:01 -0400 Received: from mout.gmx.net ([212.227.15.15]:52341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1axU4p-0008EK-Q4 for 20398-done@debbugs.gnu.org; Tue, 03 May 2016 02:45:00 -0400 Received: from [192.168.1.101] ([212.95.7.87]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0Lkx9B-1bYCP80fSP-00ajWE; Tue, 03 May 2016 08:44:51 +0200 Message-ID: <572848D6.4050306@gmx.at> Date: Tue, 03 May 2016 08:44:38 +0200 From: martin rudalics MIME-Version: 1.0 To: Lars Ingebrigtsen Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> <5538A449.6010308@gmx.at> <83vbgn1677.fsf@gnu.org> <55449178.8020309@gmx.at> <55463900.6090709@gmx.at> <87inyzdk8e.fsf@gnus.org> <5725BD16.6020900@gmx.at> <57270911.8010309@gmx.at> <87zis8v0vi.fsf@gnus.org> In-Reply-To: <87zis8v0vi.fsf@gnus.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:jpPvpyP3ukQjHpNbfPWPIJjr0D999xVRji37qGvNjhXFU2l8xmf oIYaXpWUo9NUu4ve52mxNe2/TJ6CiJLYuGv6ORuRw/HzjMr7cW6LJzFhfIpd0gTBMCYlI+N 192XxIKSP8AHu2Q3wbIVgqqsOyjXgT+6nWNAZZrzWKlKEbOgYDIFGjtU+y9CChy6LevAmQ9 Y9NqRcoOB5lfN1w7Kvktg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Cq9TFCa81XM=:Wgm0n9GWkvrojPFHqeO0OF bVbKL1ZQ4ymuQWh7Yee2fRJbJaasUk3hygUg9pfnIenlyNllZaXA3/y+ywx1wPb9KwnCrhF8u 8/xBEAcmoIV9fmg10bIvp9wOudJWeXbMXZnaOv2h5cMTtyoURrpF88MIZ/j9dBAAgjFiXAwjM +GRwe2fxx81qfauJ+N4cM8STEkiN1w9VqgHZA6zlW6c0REX5vegwQd47WrhEyy7eTPfUalNTY 2TwlDNyp8srSnkQGfWwOYIDBpviza94n20qrD6/0t5m5trp3hylwV0Q2JQpW2rm3rFn8k3PMb 5/lUYstvCU3ygN+V4FLL+OcmTmMEhsnrp530gcfC0fOAZdfJwIzkr3/Eux3Qlrtj/at5LJCFY YvbLgCvA+H4mLsEKWu0TVcZTsVcKjut43jOMiLyKm/sHvGYdFt1Q2O7gnrsvSUn9Yhv7Hmnll /xmzDz2uEYUH1Tp93dPJ6rLASbkdJGkVtfGw/djjSO/QzofExMb/Uf+wbZwNWCVH9TlBycGk1 B5irtPbTb/WJMLyPAc/yY99F7OUMUj7RZwMnM04Rn+DDf4gr4NTvSHKlodTNZ5oHPiQ3e0g28 wf47edMi/qRrTnwsSzKvDro5/5xuJeQ/UtM8W9CjEJ4qmRVFkVM8RabSclh2bzj+/S7ZqkMlU bi34J+VUmyPdjjHokKoSI+dhqxneu/bpmAb0q7VViO17jEY+ooV57Z6wbydSVUz6QwJxqU8UV OTzukT7B/Pk4Iq6SU7xzLJkNOKqFk58MCt9yS9EVi9Q1SWyR96N+u5rpr6CdafHI/gg9r/JVZ CRkF3/9OA9CfoRvvYLAMgUpXjyfFg== X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 20398-done Cc: Eli Zaretskii , 20398-done@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) >> So the patch is as below. Any objections to apply this to the emacs-25 >> branch? > > [...] > >> - (define-key map [down-mouse-2] 'widget-button-click) >> - (define-key map [down-mouse-1] 'widget-button-click) >> + (define-key map [mouse-2] 'widget-button-click) >> + (define-key map [mouse-1] 'widget-button-click) > > Isn't this a rather large change to go in at this point? People may > have rebound `down-mouse-1' (etc) instead of `mouse-1'... No idea. But counted as objection and therefore committed to master. Closing the bug. martin From debbugs-submit-bounces@debbugs.gnu.org Tue May 03 12:42:10 2016 Received: (at 20398) by debbugs.gnu.org; 3 May 2016 16:42:10 +0000 Received: from localhost ([127.0.0.1]:35569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1axdOk-0000W6-Ec for submit@debbugs.gnu.org; Tue, 03 May 2016 12:42:10 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:34951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1axdOi-0000Vy-LJ for 20398@debbugs.gnu.org; Tue, 03 May 2016 12:42:09 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u43Gg6XN022276; Tue, 3 May 2016 12:42:06 -0400 Received: by pastel.home (Postfix, from userid 20848) id AD77F600E9; Tue, 3 May 2016 12:42:06 -0400 (EDT) From: Stefan Monnier To: martin rudalics Subject: Re: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' Message-ID: References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> <5538A449.6010308@gmx.at> <83vbgn1677.fsf@gnu.org> <55449178.8020309@gmx.at> <55463900.6090709@gmx.at> <87inyzdk8e.fsf@gnus.org> <5725BD16.6020900@gmx.at> <57270911.8010309@gmx.at> <87zis8v0vi.fsf@gnus.org> <572848D6.4050306@gmx.at> Date: Tue, 03 May 2016 12:42:06 -0400 In-Reply-To: <572848D6.4050306@gmx.at> (martin rudalics's message of "Tue, 03 May 2016 08:44:38 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5661=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5661> : inlines <4752> : streams <1629407> : uri <2202447> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20398 Cc: 20398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > No idea. But counted as objection and therefore committed to master. FWIW, I also think it was too risky for emacs-25. > Closing the bug. Thanks, Stefan From unknown Wed Jun 25 05:37:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 01 Jun 2016 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator