GNU bug report logs - #20391
24.5; Info-menu completing-read doesn't use DEF argument

Previous Next

Package: emacs;

Reported by: Howard Melman <hmelman <at> gmail.com>

Date: Tue, 21 Apr 2015 00:49:01 UTC

Severity: normal

Found in version 24.5

Fixed in version 25.1

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 20391-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Howard Melman <hmelman <at> gmail.com>
Cc: 20391-done <at> debbugs.gnu.org
Subject: Re: bug#20391: 24.5;
 Info-menu completing-read doesn't use DEF argument
Date: Mon, 27 Apr 2015 00:55:32 -0400
Version:25.1

> The Info-menu command in info.el uses completing-read but doesn't use the
> DEF argument. As a result, helm fails to choose the right default
> when invoked on an info menu line.

> Doing the obvious and appending "nil nil default" to completing-read
> in the Info-menu call did solve the problem for me with helm and did
> seem to still work without helm, but I'm not completely confident it's
> the correct thing. 

It looks correct, so that's what I installed.  Thank you.

> The next few lines of Info-menu say it's depending on completing-read
> allowing "" even when require-match is t and "" is invalid, but it just
> seems to be doing so to loop back to read another input.

I think this code can now be simplified, but I wasn't in the mood, so
I left it as is for now.


        Stefan




This bug report was last modified 10 years and 32 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.