GNU bug report logs - #20386
25.0.50; error when calling sgml-attributes and sgml-tag

Previous Next

Package: emacs;

Reported by: Matt Lundin <mdl <at> imapmail.org>

Date: Mon, 20 Apr 2015 19:16:02 UTC

Severity: normal

Tags: patch

Merged with 20895

Found in version 25.0.50

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 20386 <at> debbugs.gnu.org, Matt Lundin <mdl <at> imapmail.org>
Subject: bug#20386: 25.0.50; error when calling sgml-attributes and sgml-tag
Date: Mon, 27 Apr 2015 01:00:04 -0400

> There are a lot forms like
>
>   (skeleton-read '(completing-read
>                    "Attribute: "
>                    alist))
>
> I wonder if using a backtick and a comma in each:
>
>   (skeleton-read `(completing-read
>                    "Attribute: "
>                    ',alist))
>
> is the right thing to do.

Yes, that looks right, thank you.  Better would be to let skeleton-read
take a function as argument and use `funcall' instead of `eval'.


        Stefan
This bug report was last modified 9 years and 309 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.