From unknown Sat Sep 06 10:20:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20357: 25.0.50; deactivate-mark behavior broken Resent-From: Oleh Krehel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Apr 2015 10:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 20357@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.142926641011797 (code B ref -1); Fri, 17 Apr 2015 10:27:01 +0000 Received: (at submit) by debbugs.gnu.org; 17 Apr 2015 10:26:50 +0000 Received: from localhost ([127.0.0.1]:58631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yj3U1-00034D-NR for submit@debbugs.gnu.org; Fri, 17 Apr 2015 06:26:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50065) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yj3Ty-00033w-7f for submit@debbugs.gnu.org; Fri, 17 Apr 2015 06:26:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yj3Ts-0000l6-6f for submit@debbugs.gnu.org; Fri, 17 Apr 2015 06:26:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj3Ts-0000l2-3p for submit@debbugs.gnu.org; Fri, 17 Apr 2015 06:26:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj3Tr-0006i9-C5 for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 06:26:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yj3Tm-0000kh-AN for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 06:26:39 -0400 Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:33342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj3Tm-0000kd-2W for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 06:26:34 -0400 Received: by wgin8 with SMTP id n8so108391278wgi.0 for ; Fri, 17 Apr 2015 03:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=ZMEGqcBJDE6D072+lIDyVS4DA2E90g4vUqsxih4JppE=; b=dr5YrMl7TywJLsHj6iuj+F9aeRQQaoPWU5+81JSPWndN+GUrEZG4p5Tb6yCUWgYDxb HFms9Mw30BOLcYPM6SiYjEDEDcdKogu49vgjmK1o0baQgpl1F/PIVKKtDwuDnuJAYtwy ARe8DcBQvB0I9hbcHdvnPOr97FHkEwuQPtNHLavtyDybK9zM2o4s5fPKCs+j1al4PB8i EaB/5S3ZSvY8tnSkzuReWEfN7d0qRVdEI15uGRRY8iQ4EXuFSOSDTdUpaF0wcWAo7gOs Y9wuUYqCsXDAYBd+l8CaFncelgRFVPmdfAQPhQUuHk8jTU5eaLSlsmyH9mv+5nKvWDkr t8EA== X-Received: by 10.194.19.35 with SMTP id b3mr4569479wje.24.1429266393236; Fri, 17 Apr 2015 03:26:33 -0700 (PDT) Received: from firefly ([131.155.69.45]) by mx.google.com with ESMTPSA id hu1sm2043093wib.6.2015.04.17.03.26.32 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 17 Apr 2015 03:26:32 -0700 (PDT) From: Oleh Krehel Date: Fri, 17 Apr 2015 12:21:01 +0200 Message-ID: <87pp735a42.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This is a recent change, 24.5.2 doesn't have this bug. How to reproduce: 1. Mark some text. 2. Call this: (let (deactivate-mark) (indent-region (region-beginning) (region-end))) Expected behavior: the mark isn't deactivated. Actual behavior: the mark is deactivated. From unknown Sat Sep 06 10:20:54 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Oleh Krehel Subject: bug#20357: closed (Re: bug#20357: 25.0.50; deactivate-mark behavior broken) Message-ID: References: <87pp735a42.fsf@gmail.com> X-Gnu-PR-Message: they-closed 20357 X-Gnu-PR-Package: emacs Reply-To: 20357@debbugs.gnu.org Date: Fri, 17 Apr 2015 14:32:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1429281122-19634-1" This is a multi-part message in MIME format... ------------=_1429281122-19634-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #20357: 25.0.50; deactivate-mark behavior broken which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 20357@debbugs.gnu.org. --=20 20357: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D20357 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1429281122-19634-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 20357-done) by debbugs.gnu.org; 17 Apr 2015 14:31:32 +0000 Received: from localhost ([127.0.0.1]:59090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yj7Ip-00055K-N2 for submit@debbugs.gnu.org; Fri, 17 Apr 2015 10:31:31 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:35283) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yj7In-00055A-Tl for 20357-done@debbugs.gnu.org; Fri, 17 Apr 2015 10:31:30 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t3HEVS7F005420; Fri, 17 Apr 2015 10:31:28 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 112156610A; Fri, 17 Apr 2015 10:31:32 -0400 (EDT) From: Stefan Monnier To: Oleh Krehel Subject: Re: bug#20357: 25.0.50; deactivate-mark behavior broken Message-ID: References: <87pp735a42.fsf@gmail.com> Date: Fri, 17 Apr 2015 10:31:32 -0400 In-Reply-To: <87pp735a42.fsf@gmail.com> (Oleh Krehel's message of "Fri, 17 Apr 2015 12:21:01 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5279=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5279> : inlines <2743> : streams <1424004> : uri <1909127> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 20357-done Cc: 20357-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > (let (deactivate-mark) > (indent-region (region-beginning) > (region-end))) > Expected behavior: the mark isn't deactivated. > Actual behavior: the mark is deactivated. Oops, indeed. Fixed with the patch below, Stefan diff --git a/lisp/indent.el b/lisp/indent.el index 74e73a6..18c1fd4 100644 --- a/lisp/indent.el +++ b/lisp/indent.el @@ -537,7 +537,7 @@ column to indent to; if it is nil, use one of the three methods above." ;; In most cases, reindenting modifies the buffer, but it may also ;; leave it unmodified, in which case we have to deactivate the mark ;; by hand. - (deactivate-mark)) + (setq deactivate-mark t)) (defun indent-relative-maybe () "Indent a new line like previous nonblank line. ------------=_1429281122-19634-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 Apr 2015 10:26:50 +0000 Received: from localhost ([127.0.0.1]:58631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yj3U1-00034D-NR for submit@debbugs.gnu.org; Fri, 17 Apr 2015 06:26:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50065) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yj3Ty-00033w-7f for submit@debbugs.gnu.org; Fri, 17 Apr 2015 06:26:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yj3Ts-0000l6-6f for submit@debbugs.gnu.org; Fri, 17 Apr 2015 06:26:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj3Ts-0000l2-3p for submit@debbugs.gnu.org; Fri, 17 Apr 2015 06:26:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj3Tr-0006i9-C5 for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 06:26:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yj3Tm-0000kh-AN for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 06:26:39 -0400 Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:33342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj3Tm-0000kd-2W for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 06:26:34 -0400 Received: by wgin8 with SMTP id n8so108391278wgi.0 for ; Fri, 17 Apr 2015 03:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=ZMEGqcBJDE6D072+lIDyVS4DA2E90g4vUqsxih4JppE=; b=dr5YrMl7TywJLsHj6iuj+F9aeRQQaoPWU5+81JSPWndN+GUrEZG4p5Tb6yCUWgYDxb HFms9Mw30BOLcYPM6SiYjEDEDcdKogu49vgjmK1o0baQgpl1F/PIVKKtDwuDnuJAYtwy ARe8DcBQvB0I9hbcHdvnPOr97FHkEwuQPtNHLavtyDybK9zM2o4s5fPKCs+j1al4PB8i EaB/5S3ZSvY8tnSkzuReWEfN7d0qRVdEI15uGRRY8iQ4EXuFSOSDTdUpaF0wcWAo7gOs Y9wuUYqCsXDAYBd+l8CaFncelgRFVPmdfAQPhQUuHk8jTU5eaLSlsmyH9mv+5nKvWDkr t8EA== X-Received: by 10.194.19.35 with SMTP id b3mr4569479wje.24.1429266393236; Fri, 17 Apr 2015 03:26:33 -0700 (PDT) Received: from firefly ([131.155.69.45]) by mx.google.com with ESMTPSA id hu1sm2043093wib.6.2015.04.17.03.26.32 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 17 Apr 2015 03:26:32 -0700 (PDT) From: Oleh Krehel To: bug-gnu-emacs@gnu.org Subject: 25.0.50; deactivate-mark behavior broken Date: Fri, 17 Apr 2015 12:21:01 +0200 Message-ID: <87pp735a42.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This is a recent change, 24.5.2 doesn't have this bug. How to reproduce: 1. Mark some text. 2. Call this: (let (deactivate-mark) (indent-region (region-beginning) (region-end))) Expected behavior: the mark isn't deactivated. Actual behavior: the mark is deactivated. ------------=_1429281122-19634-1-- From unknown Sat Sep 06 10:20:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20357: 25.0.50; deactivate-mark behavior broken Resent-From: Oleh Krehel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Apr 2015 16:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 20357-done@debbugs.gnu.org Received: via spool by 20357-done@debbugs.gnu.org id=D20357.142928658612937 (code D ref 20357); Fri, 17 Apr 2015 16:04:01 +0000 Received: (at 20357-done) by debbugs.gnu.org; 17 Apr 2015 16:03:06 +0000 Received: from localhost ([127.0.0.1]:59210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yj8jR-0003MZ-IF for submit@debbugs.gnu.org; Fri, 17 Apr 2015 12:03:05 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:37316) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yj8jP-0003Lq-GU for 20357-done@debbugs.gnu.org; Fri, 17 Apr 2015 12:03:03 -0400 Received: by widdi4 with SMTP id di4so25596283wid.0 for <20357-done@debbugs.gnu.org>; Fri, 17 Apr 2015 09:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=byUMc27cUSQuOqEKb66eCJmbJWyetwgwi+NAHMCGqGs=; b=RXgUTZsCT1e+vxrHAIjd+thBkVxBqd1ai37XuC3HYncXKvah0Sp2ZUaYF+X+kPoO06 Gy2tcNIuLm3ty5IMDx7AQCKDUiNtN01ohRhLlWvknEmmfbT95J8IKl5lWtQrMXHbGzfa NCz1EOTPfYs+mvz4PJ6JK4JuFM2juW5AQV/eRuC30WLv4Du71YTR+dsTNFFB+yfSTbeT a22UYgMfGP69ZkIMngYllQ8s/d1JDPGWTs9uvmQYdsRJDl0dETXwqWOywZ8EZLCfwKcA ODEO1ByF8u1TdfVJHIF5ockn1zSfWyaGrs2c4uDcL3olYMDJtypNOk35v9bHh6IqsZ+n 4M4A== MIME-Version: 1.0 X-Received: by 10.194.59.4 with SMTP id v4mr7622473wjq.54.1429286577889; Fri, 17 Apr 2015 09:02:57 -0700 (PDT) Received: by 10.27.215.21 with HTTP; Fri, 17 Apr 2015 09:02:57 -0700 (PDT) In-Reply-To: References: <87pp735a42.fsf@gmail.com> Date: Fri, 17 Apr 2015 18:02:57 +0200 Message-ID: From: Oleh Krehel Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Stefan, On Fri, Apr 17, 2015 at 4:31 PM, Stefan Monnier wrote: >> (let (deactivate-mark) >> (indent-region (region-beginning) >> (region-end))) >> Expected behavior: the mark isn't deactivated. >> Actual behavior: the mark is deactivated. > > Oops, indeed. Fixed with the patch below, > > diff --git a/lisp/indent.el b/lisp/indent.el > index 74e73a6..18c1fd4 100644 > --- a/lisp/indent.el > +++ b/lisp/indent.el > @@ -537,7 +537,7 @@ column to indent to; if it is nil, use one of the three methods above." > ;; In most cases, reindenting modifies the buffer, but it may also > ;; leave it unmodified, in which case we have to deactivate the mark > ;; by hand. > - (deactivate-mark)) > + (setq deactivate-mark t)) > > (defun indent-relative-maybe () > "Indent a new line like previous nonblank line. This is still not the correct behavior. Example code: (with-temp-buffer (insert "foobar") (set-mark (point)) (goto-char (point-min)) (indent-region (point-min) (point-max)) mark-active) In 24.5 it returns nil, which is correct. While in 25 it returns t. Oleh From unknown Sat Sep 06 10:20:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20357: 25.0.50; deactivate-mark behavior broken Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Apr 2015 18:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Oleh Krehel Cc: 20357-done@debbugs.gnu.org Received: via spool by 20357-done@debbugs.gnu.org id=D20357.142929498028368 (code D ref 20357); Fri, 17 Apr 2015 18:23:01 +0000 Received: (at 20357-done) by debbugs.gnu.org; 17 Apr 2015 18:23:00 +0000 Received: from localhost ([127.0.0.1]:59306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YjAup-0007NU-Uh for submit@debbugs.gnu.org; Fri, 17 Apr 2015 14:23:00 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:51252) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YjAuo-0007NM-Sl for 20357-done@debbugs.gnu.org; Fri, 17 Apr 2015 14:22:59 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t3HIMuQO017249; Fri, 17 Apr 2015 14:22:56 -0400 Received: by pastel.home (Postfix, from userid 20848) id 309061FB6; Fri, 17 Apr 2015 14:22:56 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87pp735a42.fsf@gmail.com> Date: Fri, 17 Apr 2015 14:22:56 -0400 In-Reply-To: (Oleh Krehel's message of "Fri, 17 Apr 2015 18:02:57 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5279=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5279> : inlines <2748> : streams <1424093> : uri <1909294> X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > (with-temp-buffer > (insert "foobar") > (set-mark (point)) > (goto-char (point-min)) > (indent-region (point-min) > (point-max)) > mark-active) > In 24.5 it returns nil, which is correct. While in 25 it returns t. Why is it more correct to return nil than to return t? > This is a recent change, 24.5.2 doesn't have this bug. > > (let (deactivate-mark) > (indent-region (region-beginning) > (region-end))) > > Expected behavior: the mark isn't deactivated. At least in 24.4, the mark does get deactivated in my test. Stefan From unknown Sat Sep 06 10:20:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20357: 25.0.50; deactivate-mark behavior broken Resent-From: Oleh Krehel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Apr 2015 18:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 20357-done@debbugs.gnu.org Received: via spool by 20357-done@debbugs.gnu.org id=D20357.142929542529141 (code D ref 20357); Fri, 17 Apr 2015 18:31:01 +0000 Received: (at 20357-done) by debbugs.gnu.org; 17 Apr 2015 18:30:25 +0000 Received: from localhost ([127.0.0.1]:59311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YjB1z-0007Zv-57 for submit@debbugs.gnu.org; Fri, 17 Apr 2015 14:30:23 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:35757) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YjB1w-0007Yt-Lm for 20357-done@debbugs.gnu.org; Fri, 17 Apr 2015 14:30:21 -0400 Received: by wgyo15 with SMTP id o15so121916945wgy.2 for <20357-done@debbugs.gnu.org>; Fri, 17 Apr 2015 11:30:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=gd71L5KJArlUWewI5GagUcc3hliKJt7Bk4iUhn+9GrA=; b=tc0hdc3bdo39zLjICoMjdBi/AVTrZiVpysqtXaJcrzz+2TPZ5spoy+/6G+93LTc7Ry YSFju9eQhehRhvGUBqmVEvkTUelqHuJmRI2i+sxhC42AIw8H7qSY5cIFgwi6mY2nasmA W6vtsndWtnbw69MlYJPBsPfr4SqcVsuNxoJzcPfalItFybsV9KgztuKN4R5YTaAjJ5EC EP1SacmfzjTjnUT3yzID6MBEstbUl6cTYSWS9j4IbqyVAMjiu/thqrUteDOYI9TxV+Tu zzGC0fqh4c50ojlrL3Aj41mWb/HF2cP0dzFU6BQ707Vmujmdcdz5hOh4nYsfuvpxIq8n QFAg== MIME-Version: 1.0 X-Received: by 10.194.143.20 with SMTP id sa20mr8150244wjb.16.1429295414896; Fri, 17 Apr 2015 11:30:14 -0700 (PDT) Received: by 10.27.215.21 with HTTP; Fri, 17 Apr 2015 11:30:14 -0700 (PDT) In-Reply-To: References: <87pp735a42.fsf@gmail.com> Date: Fri, 17 Apr 2015 20:30:14 +0200 Message-ID: From: Oleh Krehel Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Fri, Apr 17, 2015 at 8:22 PM, Stefan Monnier wrote: >> (with-temp-buffer >> (insert "foobar") >> (set-mark (point)) >> (goto-char (point-min)) >> (indent-region (point-min) >> (point-max)) >> mark-active) >> In 24.5 it returns nil, which is correct. While in 25 it returns t. > > Why is it more correct to return nil than to return t? Because it's a long standing behavior that if you mark some stuff and press TAB, the mark will be deactivated. And in 25, the mark actually is deactivated outside of temp buffers, which is where I run my ERT tests. So the tests are passing for 24.5 and failing for 25, while the functions actually do work in both. > >> This is a recent change, 24.5.2 doesn't have this bug. >> >> (let (deactivate-mark) >> (indent-region (region-beginning) >> (region-end))) >> >> Expected behavior: the mark isn't deactivated. > > At least in 24.4, the mark does get deactivated in my test. This may be possible. Previously, I was testing using the emacs24 ppa install, that uses emacs-24.3. I've started testing with emacs-snapshot only this week, and the tests started failing. But when I've tested with 24.5 or 25 on my own machine, the tests were running fine. Oleh From unknown Sat Sep 06 10:20:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20357: 25.0.50; deactivate-mark behavior broken Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Apr 2015 19:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Oleh Krehel Cc: 20357-done@debbugs.gnu.org Received: via spool by 20357-done@debbugs.gnu.org id=D20357.1429298165782 (code D ref 20357); Fri, 17 Apr 2015 19:17:02 +0000 Received: (at 20357-done) by debbugs.gnu.org; 17 Apr 2015 19:16:05 +0000 Received: from localhost ([127.0.0.1]:59340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YjBkC-0000CY-Il for submit@debbugs.gnu.org; Fri, 17 Apr 2015 15:16:04 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:60592) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YjBk8-0000C2-Qz for 20357-done@debbugs.gnu.org; Fri, 17 Apr 2015 15:16:02 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t3HJFwiG007453; Fri, 17 Apr 2015 15:15:59 -0400 Received: by pastel.home (Postfix, from userid 20848) id 395E11178; Fri, 17 Apr 2015 15:15:58 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87pp735a42.fsf@gmail.com> Date: Fri, 17 Apr 2015 15:15:58 -0400 In-Reply-To: (Oleh Krehel's message of "Fri, 17 Apr 2015 20:30:14 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5279=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5279> : inlines <2749> : streams <1424113> : uri <1909324> X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) >>> (with-temp-buffer >>> (insert "foobar") >>> (set-mark (point)) >>> (goto-char (point-min)) >>> (indent-region (point-min) >>> (point-max)) >>> mark-active) >>> In 24.5 it returns nil, which is correct. While in 25 it returns t. >> Why is it more correct to return nil than to return t? > Because it's a long standing behavior that if you mark some stuff and > press TAB, the mark will be deactivated. That's still the case. The difference is that now it's deactivated by the command loop rather than by the command itself. Doing it in the command loop is the normal behavior (the one used for most other commands which cause the mark to be deactivated). >>> This is a recent change, 24.5.2 doesn't have this bug. >>> (let (deactivate-mark) >>> (indent-region (region-beginning) >>> (region-end))) >>> Expected behavior: the mark isn't deactivated. >> At least in 24.4, the mark does get deactivated in my test. It's also deactivated in Emacs-23.4 in my tests. > But when I've tested with 24.5 or 25 on my own machine, the tests were > running fine. I think we need to know more about what your tests really do. Maybe they should just be fixed to test (or (not mark-active) deactivate-mark) instead of only testing mark-active. Stefan