From unknown Sun Jun 22 00:29:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20334: What does all-completions with COLLECTION == obarray return? Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: michael_heerdegen@web.de, bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Apr 2015 15:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20334 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 20334@debbugs.gnu.org Cc: Michael Heerdegen X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Michael Heerdegen Received: via spool by submit@debbugs.gnu.org id=B.142911087224186 (code B ref -1); Wed, 15 Apr 2015 15:15:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Apr 2015 15:14:32 +0000 Received: from localhost ([127.0.0.1]:57209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YiP1M-0006I1-8k for submit@debbugs.gnu.org; Wed, 15 Apr 2015 11:14:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54998) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YiP1K-0006Hm-7q for submit@debbugs.gnu.org; Wed, 15 Apr 2015 11:14:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YiP1E-0007Fz-2s for submit@debbugs.gnu.org; Wed, 15 Apr 2015 11:14:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55282) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiP1D-0007Fv-W6 for submit@debbugs.gnu.org; Wed, 15 Apr 2015 11:14:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiP1D-0001OH-22 for bug-gnu-emacs@gnu.org; Wed, 15 Apr 2015 11:14:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YiP19-0007FP-Fd for bug-gnu-emacs@gnu.org; Wed, 15 Apr 2015 11:14:22 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:35465) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiP19-0007F6-3H for bug-gnu-emacs@gnu.org; Wed, 15 Apr 2015 11:14:19 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t3FFEHgK021724; Wed, 15 Apr 2015 11:14:17 -0400 Received: by pastel.home (Postfix, from userid 20848) id E255C15D9; Wed, 15 Apr 2015 11:14:16 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87k2xr7skh.fsf@web.de> <87iodaxvg0.fsf@web.de> <87lhi3hs6d.fsf@web.de> <87iod68tj3.fsf@web.de> <87twwh1omu.fsf@web.de> Date: Wed, 15 Apr 2015 11:14:16 -0400 In-Reply-To: <87twwh1omu.fsf@web.de> (Michael Heerdegen's message of "Wed, 15 Apr 2015 15:56:25 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5277=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5277> : inlines <2719> : streams <1422931> : uri <1907384> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) > I guess this should not happen, so it is a bug in Emacs in think. Indeed. Thanks for the test case. I reduced it to: (progn (intern "Bah=E1'=ED Date") ;this happens when requiring org (facep "Bah=E1'=ED Date") ;; Test if "Bah=E1'=ED Date" is the name of more than one interned sym= bol (let ((ss nil)) (mapatoms (lambda (s) (when (string=3D (symbol-name s) "Bah=E1'=ED D= ate") (push s ss))) nil) (length ss))) So the patch below fixes it, but it points at a problem in the C function `intern' which I haven't tracked down yet. Stefan diff --git a/src/xfaces.c b/src/xfaces.c index 9f8a816..d079be8 100644 --- a/src/xfaces.c +++ b/src/xfaces.c @@ -1822,7 +1822,8 @@ resolve_face_name (Lisp_Object face_name, bool signal= _p) Lisp_Object tortoise, hare; =20 if (STRINGP (face_name)) - face_name =3D intern (SSDATA (face_name)); + /* face_name =3D intern (SSDATA (face_name)); */ + face_name =3D Fintern (face_name, Qnil); =20 if (NILP (face_name) || !SYMBOLP (face_name)) return face_name; From unknown Sun Jun 22 00:29:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20334: What does all-completions with COLLECTION == obarray return? Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Apr 2015 15:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20334 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Michael Heerdegen , 20334@debbugs.gnu.org Received: via spool by 20334-submit@debbugs.gnu.org id=B20334.142911183926057 (code B ref 20334); Wed, 15 Apr 2015 15:31:02 +0000 Received: (at 20334) by debbugs.gnu.org; 15 Apr 2015 15:30:39 +0000 Received: from localhost ([127.0.0.1]:57233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YiPGw-0006mB-Ji for submit@debbugs.gnu.org; Wed, 15 Apr 2015 11:30:39 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45333 helo=mx2.suse.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YiPGp-0006lv-H9 for 20334@debbugs.gnu.org; Wed, 15 Apr 2015 11:30:32 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 1D37BAB13; Wed, 15 Apr 2015 15:30:30 +0000 (UTC) From: Andreas Schwab References: <87k2xr7skh.fsf@web.de> <87iodaxvg0.fsf@web.de> <87lhi3hs6d.fsf@web.de> <87iod68tj3.fsf@web.de> <87twwh1omu.fsf@web.de> X-Yow: TAPPING? You POLITICIANS! Don't you realize that the END of the ``Wash Cycle'' is a TREASURED MOMENT for most people?! Date: Wed, 15 Apr 2015 17:30:29 +0200 In-Reply-To: (Stefan Monnier's message of "Wed, 15 Apr 2015 11:14:16 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Stefan Monnier writes: > So the patch below fixes it, but it points at a problem in the > C function `intern' which I haven't tracked down yet. The C function only works with ASCII-only strings. Lisp_Object tem = oblookup (obarray, str, len, len); Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From unknown Sun Jun 22 00:29:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20334: What does all-completions with COLLECTION == obarray return? Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Apr 2015 16:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20334 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 20334@debbugs.gnu.org Cc: Michael Heerdegen Received: via spool by 20334-submit@debbugs.gnu.org id=B20334.142911454931228 (code B ref 20334); Wed, 15 Apr 2015 16:16:02 +0000 Received: (at 20334) by debbugs.gnu.org; 15 Apr 2015 16:15:49 +0000 Received: from localhost ([127.0.0.1]:57269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YiPye-00087b-3c for submit@debbugs.gnu.org; Wed, 15 Apr 2015 12:15:48 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:59215) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YiPyc-00087S-1c for 20334@debbugs.gnu.org; Wed, 15 Apr 2015 12:15:47 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t3FGFhtj010083; Wed, 15 Apr 2015 12:15:45 -0400 Received: by pastel.home (Postfix, from userid 20848) id C502115D9; Wed, 15 Apr 2015 12:15:43 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87k2xr7skh.fsf@web.de> <87iodaxvg0.fsf@web.de> <87lhi3hs6d.fsf@web.de> <87iod68tj3.fsf@web.de> <87twwh1omu.fsf@web.de> Date: Wed, 15 Apr 2015 12:15:43 -0400 In-Reply-To: (Stefan Monnier's message of "Wed, 15 Apr 2015 11:14:16 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5277=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5277> : inlines <2721> : streams <1422954> : uri <1907431> X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > (progn > (intern "Bah=E1'=ED Date") ;this happens when requiring org > (facep "Bah=E1'=ED Date") > ;; Test if "Bah=E1'=ED Date" is the name of more than one interned s= ymbol > (let ((ss nil)) > (mapatoms (lambda (s) (when (string=3D (symbol-name s) "Bah=E1'=ED= Date") > (push s ss))) > nil) > (length ss))) I installed the patch below which should fix this problem. Thanks. Stefan diff --git a/src/lread.c b/src/lread.c index 050e43e..fa9a63e 100644 --- a/src/lread.c +++ b/src/lread.c @@ -3778,8 +3778,11 @@ intern_1 (const char *str, ptrdiff_t len) Lisp_Object obarray =3D check_obarray (Vobarray); Lisp_Object tem =3D oblookup (obarray, str, len, len); =20 - return SYMBOLP (tem) ? tem : intern_driver (make_string (str, len), - obarray, tem); + return (SYMBOLP (tem) ? tem + /* The above `oblookup' was done on the basis of nchars=3D=3Dnbytes, so + the string has to be unibyte. */ + : intern_driver (make_unibyte_string (str, len), + obarray, tem)); } =20 Lisp_Object diff --git a/src/xfaces.c b/src/xfaces.c index b269722..d198c4b 100644 --- a/src/xfaces.c +++ b/src/xfaces.c @@ -1822,7 +1822,7 @@ resolve_face_name (Lisp_Object face_name, bool signal= _p) Lisp_Object tortoise, hare; =20 if (STRINGP (face_name)) - face_name =3D intern (SSDATA (face_name)); + face_name =3D Fintern (face_name, Qnil); =20 if (NILP (face_name) || !SYMBOLP (face_name)) return face_name; diff --git a/test/indent/perl.perl b/test/indent/perl.perl index 00ef312..ea48754 100755 --- a/test/indent/perl.perl +++ b/test/indent/perl.perl @@ -5,6 +5,15 @@ sub add_funds($) { return 0; } =20 +my $hash =3D { + foo =3D> 'bar', + format =3D> 'some', +}; + +sub some_code { + print "will not indent :("; +}; + use v5.14; =20 my $str=3D <) id 1YiQyX-0002w9-Vu for submit@debbugs.gnu.org; Wed, 15 Apr 2015 13:19:46 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:40355) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YiQyV-0002w0-RH for control@debbugs.gnu.org; Wed, 15 Apr 2015 13:19:44 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t3FHJgAZ024345 for ; Wed, 15 Apr 2015 13:19:43 -0400 Received: by pastel.home (Postfix, from userid 20848) id B56B515D9; Wed, 15 Apr 2015 13:19:42 -0400 (EDT) From: Stefan Monnier To: control@debbugs.gnu.org Subject: Re: bug#20334: What does all-completions with COLLECTION == obarray return? Message-ID: References: <87k2xr7skh.fsf@web.de> <87iodaxvg0.fsf@web.de> <87lhi3hs6d.fsf@web.de> <87iod68tj3.fsf@web.de> <87twwh1omu.fsf@web.de> Date: Wed, 15 Apr 2015 13:19:42 -0400 In-Reply-To: (Stefan Monnier's message of "Wed, 15 Apr 2015 12:15:43 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5277=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5277> : inlines <2722> : streams <1422979> : uri <1907475> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) close 20334 thanks From unknown Sun Jun 22 00:29:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20334: What does all-completions with COLLECTION == obarray return? Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Apr 2015 17:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20334 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 20334@debbugs.gnu.org Received: via spool by 20334-submit@debbugs.gnu.org id=B20334.142911867911864 (code B ref 20334); Wed, 15 Apr 2015 17:25:02 +0000 Received: (at 20334) by debbugs.gnu.org; 15 Apr 2015 17:24:39 +0000 Received: from localhost ([127.0.0.1]:57314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YiR3G-00035H-UA for submit@debbugs.gnu.org; Wed, 15 Apr 2015 13:24:39 -0400 Received: from mout.web.de ([212.227.17.11]:56407) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YiR3E-000352-Sp for 20334@debbugs.gnu.org; Wed, 15 Apr 2015 13:24:37 -0400 Received: from drachen.dragon ([94.217.116.84]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0M6UxL-1Zb3o6293D-00yO4m; Wed, 15 Apr 2015 19:24:29 +0200 From: Michael Heerdegen References: <87k2xr7skh.fsf@web.de> <87iodaxvg0.fsf@web.de> <87lhi3hs6d.fsf@web.de> <87iod68tj3.fsf@web.de> <87twwh1omu.fsf@web.de> Date: Wed, 15 Apr 2015 19:24:27 +0200 In-Reply-To: (Stefan Monnier's message of "Wed, 15 Apr 2015 12:15:43 -0400") Message-ID: <87wq1dgv90.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:znSNrMzHzR/adwJjmeS1KNAt96xBw2wUHMVahp7LzyE6pshPGqn +EZdlb28bhaiyefim/KiSpeFSPj2lb0LzpQXvdBpbRKfkLTPdS7AyJxRajcaBEmgfGA1CZA ql0z3p87m6dyYBP/TntJkJhbOLS9B+2TyneRXd7NBeLAeWbkbVMScuVXViF56C6lGZPvNtf ZmORQ/BtyAgCpnHm4byew== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Stefan Monnier writes: > I installed the patch below which should fix this problem. Thanks. It fixed my test case as well as the original issue in Helm. Thanks! P.S.: Your commit includes a change to test/indent/perl.perl that seems unrelated to this issue. Thanks again, Michael.