From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 09 16:06:04 2015 Received: (at submit) by debbugs.gnu.org; 9 Apr 2015 20:06:04 +0000 Received: from localhost ([127.0.0.1]:51515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgIiC-0004BP-HI for submit@debbugs.gnu.org; Thu, 09 Apr 2015 16:06:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47137) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgIiA-0004As-Bh for submit@debbugs.gnu.org; Thu, 09 Apr 2015 16:06:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgIi1-00042L-CM for submit@debbugs.gnu.org; Thu, 09 Apr 2015 16:05:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgIi1-00042H-AV for submit@debbugs.gnu.org; Thu, 09 Apr 2015 16:05:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgIi0-0000R6-G3 for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2015 16:05:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgIht-00040D-Vn for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2015 16:05:52 -0400 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:38712) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgIht-000407-Om for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2015 16:05:45 -0400 Received: by wiun10 with SMTP id n10so1794903wiu.1 for ; Thu, 09 Apr 2015 13:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version:content-type; bh=Rp8Jw7RFmtsB51wvUdLI/OVANWFhpfuXblCEkPjmhMI=; b=WaA8VUnIbiBxk0QVegbeACyeTe7hHGpDnCi57rFHPH4bmZty331MXYJ0evVtFOH814 5kGhiPyMXD/2+5kujMgX4Wumuauz2FvOwiExtLZeeQNGeTgqwXA4EdWmdBXyeLdnZxbA GRkshZL0IrVcGH9RcUZ1pGYvDrZBtX3qcEbS80ELClE0Siz/TRQHToIClpNnBKPezLGX gBO1L/HVJPke91CdTNTiO6Kq9VjtfERPomYcJ6WCAmcC4FnShoGIaI2m8hv6ADbpf2D4 6DVU0kMnHs2ae4MchT0sfYNLyv1Thjf+PnMVO/GsNtX5vhcvJtJDtTvIjfm2pOeYlpAg SfDw== X-Received: by 10.194.109.9 with SMTP id ho9mr62301374wjb.29.1428609945089; Thu, 09 Apr 2015 13:05:45 -0700 (PDT) Received: from axl ([82.102.93.54]) by mx.google.com with ESMTPSA id it5sm21595941wid.3.2015.04.09.13.05.43 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Apr 2015 13:05:44 -0700 (PDT) From: Dmitry Gutov To: bug-gnu-emacs@gnu.org Subject: 25.0.50; Use unified diff format by default, and recommend using it in reports and patches Date: Thu, 09 Apr 2015 23:05:42 +0300 Message-ID: <86bnix6p9l.fsf@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) That should involve changing the default `diff-switches' value and small changes to doc/emacs/files.texi and doc/emacs/trouble.texi. Let me know if I missed something. Barring any objections, I'll do that tomorrow-ish, on master. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 10 03:27:07 2015 Received: (at 20290) by debbugs.gnu.org; 10 Apr 2015 07:27:07 +0000 Received: from localhost ([127.0.0.1]:51756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgTLG-0004Lc-Sp for submit@debbugs.gnu.org; Fri, 10 Apr 2015 03:27:07 -0400 Received: from mtaout24.012.net.il ([80.179.55.180]:50346) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgTLD-0004L3-RF for 20290@debbugs.gnu.org; Fri, 10 Apr 2015 03:27:05 -0400 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NMK00J00X2GT900@mtaout24.012.net.il> for 20290@debbugs.gnu.org; Fri, 10 Apr 2015 10:18:24 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NMK00D6PXMOHK80@mtaout24.012.net.il>; Fri, 10 Apr 2015 10:18:24 +0300 (IDT) Date: Fri, 10 Apr 2015 10:26:56 +0300 From: Eli Zaretskii Subject: Re: bug#20290: 25.0.50; Use unified diff format by default, and recommend using it in reports and patches In-reply-to: <86bnix6p9l.fsf@yandex.ru> X-012-Sender: halo1@inter.net.il To: Dmitry Gutov Message-id: <83pp7cv3y7.fsf@gnu.org> References: <86bnix6p9l.fsf@yandex.ru> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 20290 Cc: 20290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Dmitry Gutov > Date: Thu, 09 Apr 2015 23:05:42 +0300 > > That should involve changing the default `diff-switches' value and small > changes to doc/emacs/files.texi and doc/emacs/trouble.texi. > > Let me know if I missed something. Please be sure to mention the change in NEWS, and tell there how to get back the old behavior. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 10 03:33:28 2015 Received: (at 20290) by debbugs.gnu.org; 10 Apr 2015 07:33:28 +0000 Received: from localhost ([127.0.0.1]:51761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgTRP-0004YM-Pa for submit@debbugs.gnu.org; Fri, 10 Apr 2015 03:33:28 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:43997 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgTRN-0004YB-DB for 20290@debbugs.gnu.org; Fri, 10 Apr 2015 03:33:26 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YgTRL-00080a-OW; Fri, 10 Apr 2015 03:33:23 -0400 From: Glenn Morris To: Dmitry Gutov Subject: Re: bug#20290: 25.0.50; Use unified diff format by default, and recommend using it in reports and patches References: <86bnix6p9l.fsf@yandex.ru> X-Spook: counter terrorism ANC advisors Mole [Hello to all my X-Ran: rxK~?|wb0fSUR9AyX1!P`"X?ppz20R>c?z'^y@D;eXR.63,KkjrY*AXbg~'|ln'EadYC81 X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 10 Apr 2015 03:33:23 -0400 In-Reply-To: <86bnix6p9l.fsf@yandex.ru> (Dmitry Gutov's message of "Thu, 09 Apr 2015 23:05:42 +0300") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 20290 Cc: 20290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) What's the reason for changing the long-standing default? * Use `diff -c' to make your diffs. Diffs without context are hard to install reliably. More than that, they are hard to study; we must always study a patch to decide whether we want to install it. Unidiff format is better than contextless diffs, but not as easy to read as `-c' format. Also, one day is not long enough to allow people time to respond, for any Emacs issue. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 10 08:25:18 2015 Received: (at 20290) by debbugs.gnu.org; 10 Apr 2015 12:25:19 +0000 Received: from localhost ([127.0.0.1]:51915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgXzq-0005OR-45 for submit@debbugs.gnu.org; Fri, 10 Apr 2015 08:25:18 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:36276) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgXzn-0005OB-CE for 20290@debbugs.gnu.org; Fri, 10 Apr 2015 08:25:15 -0400 Received: by wgsk9 with SMTP id k9so15804938wgs.3 for <20290@debbugs.gnu.org>; Fri, 10 Apr 2015 05:25:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=IbgZaG8AwKpmwhY3agUzy/gBslPrWwbK9wAGHnNL1lE=; b=B9xUXwI55ojR8llMpoGgiJudkpycRZI3jkhnHG83E9J/lbbICY14vfKO2qYImyq6JT yc1rIFCr7ZcWEnV36AtY+sAUiS3gJOurV6tHAkgEfrqWhQrRyTZaJZYH7N7OwiZ0PAVT 9MV0d7FiH2EKtdsOA2JrTsrh3YYAWOPuFPfXs7nN1jUFoqu1vGXi/YJrDQlta+CvilO+ 3ipq/9kv7iulB8abnjl0HdsRae9YCdS8uiMo48skz8WwH1ioM/zKyZxR9Q6fc4yWH+f7 3306UbO0z6qKZP85RvDnoltIhKk93IEk6cjYpxfjQEvmRcZ7T35GNei4AFI/0DyGyiHR Zp8g== X-Received: by 10.194.89.195 with SMTP id bq3mr2395519wjb.123.1428667187465; Fri, 10 Apr 2015 04:59:47 -0700 (PDT) Received: from [192.168.1.3] ([82.102.93.54]) by mx.google.com with ESMTPSA id it5sm24542461wid.3.2015.04.10.04.59.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Apr 2015 04:59:46 -0700 (PDT) Message-ID: <5527BB30.1010707@yandex.ru> Date: Fri, 10 Apr 2015 14:59:44 +0300 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#20290: 25.0.50; Use unified diff format by default, and recommend using it in reports and patches References: <86bnix6p9l.fsf@yandex.ru> <83pp7cv3y7.fsf@gnu.org> In-Reply-To: <83pp7cv3y7.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20290 Cc: 20290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 04/10/2015 10:26 AM, Eli Zaretskii wrote: > Please be sure to mention the change in NEWS, and tell there how to > get back the old behavior. Right, thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 10 08:27:13 2015 Received: (at 20290) by debbugs.gnu.org; 10 Apr 2015 12:27:13 +0000 Received: from localhost ([127.0.0.1]:51920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgY1g-0005Rq-Vw for submit@debbugs.gnu.org; Fri, 10 Apr 2015 08:27:13 -0400 Received: from mail-wg0-f43.google.com ([74.125.82.43]:36612) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgY1f-0005RV-8K for 20290@debbugs.gnu.org; Fri, 10 Apr 2015 08:27:11 -0400 Received: by wgsk9 with SMTP id k9so15872252wgs.3 for <20290@debbugs.gnu.org>; Fri, 10 Apr 2015 05:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=EnP/piZxggip4q3b09o8ZuMWnlRAcenhy/srbFmt89I=; b=hG8+79rteHQrXrxj4kSPh86nUhcgKzy8rqFHwLhWchaP4bUXxmDzx12Mvk1wAJBRp8 lPm9WSfFA5IRZOuFQPi/BulnmjJJiOiy5bSw+hmdpgdhWxZ1LIOZ89mgHOLvsMH4/q2q oRyrvUv4Wok9Odq9voBxf8cuR6kVcefyPAqWE3z5s+6hT/VLe8cfqd72uV+lwNiCPsyS R4NCyWi7nPMFIS3wBOfWyTXRjnPyxZ9o/KY/rOCAEcFEV1nOCH7Iv2fZBiNCOXZQKOGm bZeGbway2uIcvGt6oo8gXdVDuCL9dj88QUQvqwLl1wn5PpBkFs1GHvNIXXm8fr9JWrV8 FA8Q== X-Received: by 10.194.48.12 with SMTP id h12mr2762853wjn.74.1428668805650; Fri, 10 Apr 2015 05:26:45 -0700 (PDT) Received: from [192.168.1.3] ([82.102.93.54]) by mx.google.com with ESMTPSA id cf12sm2755386wjb.10.2015.04.10.05.26.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Apr 2015 05:26:44 -0700 (PDT) Message-ID: <5527C17E.1040404@yandex.ru> Date: Fri, 10 Apr 2015 15:26:38 +0300 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 MIME-Version: 1.0 To: Glenn Morris Subject: Re: bug#20290: 25.0.50; Use unified diff format by default, and recommend using it in reports and patches References: <86bnix6p9l.fsf@yandex.ru> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20290 Cc: 20290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 04/10/2015 10:33 AM, Glenn Morris wrote: > What's the reason for changing the long-standing default? Unified diffs are considerably more popular. IIRC Stefan prefers them, and the vast majority of patches we've received lately (even though Emacs's documentation asks for the context format), were unified. Which signals that users prefer, or at least are more used to, unified diffs. I've recently wanted to show off the "refinement" diff-mode feature to a colleague, and that stumbled on Emacs producing a context diff by default, so I had to go back to my machine, and look up which option to change (yes, I know there's a conversion command; haven't thought about that at the time). > * Use `diff -c' to make your diffs. Diffs without context are hard > to install reliably. More than that, they are hard to study; we > must always study a patch to decide whether we want to install it. This is about the "normal" diff format, which, uh, nobody ever uses now? > Unidiff format is better than contextless diffs, but not as easy > to read as `-c' format. And here I disagree: unified diffs are easier, because they clearly show you the changes. You don't need to compare the "before" and "after" in your head, to figure out what exactly changed. Maybe it can be a bit harder to read, but it's much easier to review. Note that we already indirectly ask the users to send their patches in the unified format in CONTRIBUTE, because that's what 'git format-patch' will create. > Also, one day is not long enough to allow people time to respond, > for any Emacs issue. Okay, let's wait until the next week. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 10 11:56:02 2015 Received: (at 20290) by debbugs.gnu.org; 10 Apr 2015 15:56:02 +0000 Received: from localhost ([127.0.0.1]:52548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgbHm-0003xb-Bp for submit@debbugs.gnu.org; Fri, 10 Apr 2015 11:56:02 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:48342) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgbHk-0003xC-88 for 20290@debbugs.gnu.org; Fri, 10 Apr 2015 11:56:01 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3lNkTV5xWPz3hhw6; Fri, 10 Apr 2015 17:55:58 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3lNkTV3vpgzvh27; Fri, 10 Apr 2015 17:55:58 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id OqH0C8Mc6pZf; Fri, 10 Apr 2015 17:55:57 +0200 (CEST) X-Auth-Info: rF+KkvHdCB1RAj3J+yV2YXYcfro7kpcSR8W5QgtNs8nUhuzwC+e5xMreVMG+HLM+ Received: from igel.home (ppp-46-244-162-109.dynamic.mnet-online.de [46.244.162.109]) by mail.mnet-online.de (Postfix) with ESMTPA; Fri, 10 Apr 2015 17:55:57 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 5A1E82C0D56; Fri, 10 Apr 2015 17:55:56 +0200 (CEST) From: Andreas Schwab To: Dmitry Gutov Subject: Re: bug#20290: 25.0.50; Use unified diff format by default, and recommend using it in reports and patches References: <86bnix6p9l.fsf@yandex.ru> <5527C17E.1040404@yandex.ru> X-Yow: YOW!! I am having FUN!! Date: Fri, 10 Apr 2015 17:55:56 +0200 In-Reply-To: <5527C17E.1040404@yandex.ru> (Dmitry Gutov's message of "Fri, 10 Apr 2015 15:26:38 +0300") Message-ID: <87lhi0gepf.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20290 Cc: Glenn Morris , 20290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: > Which signals that users prefer, or at least are more used to, unified > diffs. I've recently wanted to show off the "refinement" diff-mode feature > to a colleague, and that stumbled on Emacs producing a context diff by > default, The refinement works well with context diffs. > And here I disagree: unified diffs are easier, because they clearly show > you the changes. You don't need to compare the "before" and "after" in > your head, to figure out what exactly changed. That's where the refinement helps in the same way as with unified diffs. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 10 13:13:55 2015 Received: (at 20290) by debbugs.gnu.org; 10 Apr 2015 17:13:55 +0000 Received: from localhost ([127.0.0.1]:52602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgcV9-0005zp-4C for submit@debbugs.gnu.org; Fri, 10 Apr 2015 13:13:55 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:35692) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgcV6-0005zb-9C for 20290@debbugs.gnu.org; Fri, 10 Apr 2015 13:13:53 -0400 Received: by widdi4 with SMTP id di4so4199410wid.0 for <20290@debbugs.gnu.org>; Fri, 10 Apr 2015 10:13:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=apVU2Cu4Dn3Z4Ts9JTv5QtR5R6prblQKS5ENiVLIFHo=; b=sA2XHgCdX7uTcwiu614IqPLU4td9e/qnabaf4jJLidyzTY03Uk4vHiS7+0+0AwGS57 k4B65ZXpK+snENJtyqkLptTbzOP0/lrMUbkPiNptdD9NCYlI1rbwVsohiVtqCB5dvF8v b6G4At+9sTgv5URGSW++Y8HDNxfhhJAw951Q0Yyx81ZWkFT3VQD6EgXJf2J81Jmjw3af mQdUXBGbElAPKRjTXL3ddOcJjHFGxtDbCzJL4nIK+QWHQKtnoS5ttcugC3ZhiPxWVvE1 obWOue0plAF7mkGDPrb45xJFUzqQKpka5XpwE1LN0oSavxHwEJWlP/g62y5A54KnYPov ep1w== X-Received: by 10.180.188.193 with SMTP id gc1mr16738604wic.7.1428686026444; Fri, 10 Apr 2015 10:13:46 -0700 (PDT) Received: from [192.168.1.3] ([82.102.93.54]) by mx.google.com with ESMTPSA id df1sm449738wib.12.2015.04.10.10.13.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Apr 2015 10:13:45 -0700 (PDT) Message-ID: <552804C7.4080707@yandex.ru> Date: Fri, 10 Apr 2015 20:13:43 +0300 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 MIME-Version: 1.0 To: Andreas Schwab Subject: Re: bug#20290: 25.0.50; Use unified diff format by default, and recommend using it in reports and patches References: <86bnix6p9l.fsf@yandex.ru> <5527C17E.1040404@yandex.ru> <87lhi0gepf.fsf@igel.home> In-Reply-To: <87lhi0gepf.fsf@igel.home> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20290 Cc: 20290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 04/10/2015 06:55 PM, Andreas Schwab wrote: > The refinement works well with context diffs. Good point: it helps with their downside. However, the other person was unfamiliar with the context format, and myself, simply uncomfortable with it. > That's where the refinement helps in the same way as with unified diffs. And even more so, I'd say. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 12 19:30:12 2015 Received: (at 20290) by debbugs.gnu.org; 12 Apr 2015 23:30:12 +0000 Received: from localhost ([127.0.0.1]:54258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YhRKN-0005RC-Bl for submit@debbugs.gnu.org; Sun, 12 Apr 2015 19:30:11 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:41276) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YhRKK-0005Qg-74 for 20290@debbugs.gnu.org; Sun, 12 Apr 2015 19:30:09 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 5A60EA60004 for <20290@debbugs.gnu.org>; Sun, 12 Apr 2015 16:30:02 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RVWbejb1Lu2R for <20290@debbugs.gnu.org>; Sun, 12 Apr 2015 16:30:02 -0700 (PDT) Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 0C50B39E8015 for <20290@debbugs.gnu.org>; Sun, 12 Apr 2015 16:30:02 -0700 (PDT) Message-ID: <552AFFF9.90501@cs.ucla.edu> Date: Sun, 12 Apr 2015 16:30:01 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: 20290@debbugs.gnu.org Subject: Re: 25.0.50; Use unified diff format by default, and recommend using it in reports and patches Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20290 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) As I recall, RMS preferred diff -c to diff -u, and that is partly why trouble.texi suggests -c over -u and why diff-switches defaults to -c. Also, traditional Unix 'diff' lacked -u; although GNU diff had -u starting in 1990, diff -u wasn't standardized by POSIX until 2008. These days -u format is far more popular than -c format in practice, and I expect that most active Emacs developers prefer -u, so it's appropriate for Emacs to default to -u and for trouble.texi to suggest it. I suppose that in theory there is the issue of Emacs running on an older POSIXish platform where 'diff' does not support -u. I don't have access to any such platform, though. I can confirm that Solaris 10 diff (2005) supports '-u'. So perhaps we don't need to worry about this. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 12 23:04:11 2015 Received: (at 20290) by debbugs.gnu.org; 13 Apr 2015 03:04:11 +0000 Received: from localhost ([127.0.0.1]:54307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YhUfT-00027C-7H for submit@debbugs.gnu.org; Sun, 12 Apr 2015 23:04:11 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:49579) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YhUfQ-000273-9f for 20290@debbugs.gnu.org; Sun, 12 Apr 2015 23:04:09 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t3D33w0f018246; Sun, 12 Apr 2015 23:03:58 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id E73A3AE114; Sun, 12 Apr 2015 23:03:57 -0400 (EDT) From: Stefan Monnier To: Paul Eggert Subject: Re: bug#20290: 25.0.50; Use unified diff format by default, and recommend using it in reports and patches Message-ID: References: <86bnix6p9l.fsf@yandex.ru> <552AFFF9.90501@cs.ucla.edu> Date: Sun, 12 Apr 2015 23:03:57 -0400 In-Reply-To: <552AFFF9.90501@cs.ucla.edu> (Paul Eggert's message of "Sun, 12 Apr 2015 16:30:01 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5274=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5274> : inlines <2687> : streams <1421553> : uri <1905237> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 20290 Cc: 20290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > These days -u format is far more popular than -c format in practice, and > I expect that most active Emacs developers prefer -u, so it's appropriate > for Emacs to default to -u and for trouble.texi to suggest it. That's my impression as well. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 13 22:16:40 2015 Received: (at 20290-done) by debbugs.gnu.org; 14 Apr 2015 02:16:40 +0000 Received: from localhost ([127.0.0.1]:55358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YhqP1-0006tr-NI for submit@debbugs.gnu.org; Mon, 13 Apr 2015 22:16:40 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:33731) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YhqOy-0006tc-Ub for 20290-done@debbugs.gnu.org; Mon, 13 Apr 2015 22:16:37 -0400 Received: by wgin8 with SMTP id n8so99731266wgi.0 for <20290-done@debbugs.gnu.org>; Mon, 13 Apr 2015 19:16:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=RSN+Md0lp3h2X4yA7hFdyGc4sHtl8rdO/Pl2cSm0KAM=; b=Xh3ASt3EP4OvTL3sGzxY9oSzA6NvC7EFF2IDuRODlChF8ZV29oou9uoLIVwe7X5FDm DRjC0HZREoEoCS0baI7RG5kRdnDRxpIjvaczQGaN8sxFcHNacyVDvo/2j5DjYIkCVYNQ AXlhrjBeEWj6syrJ2gQbCtlyuDsvHT20kAPk+NP7PKagJHDMNgCdXDFGzVkxovqG0JOD jxGcV6+Yc3NX5eCedrUjkq3NfW62P79cf3k4IpjNlYgrlVtAuAVffIQkcDwILuOA4C9t Iq23uVuTB/dGmQEtJnMqdyp1/Wp0CN6BKqisin1MlA4G+KZRsTZflFp04t16TlgoUIoa yhqw== X-Received: by 10.180.35.8 with SMTP id d8mr6669523wij.39.1428977791299; Mon, 13 Apr 2015 19:16:31 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id wo10sm13774950wjb.35.2015.04.13.19.16.29 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Apr 2015 19:16:30 -0700 (PDT) Message-ID: <552C787C.70608@yandex.ru> Date: Tue, 14 Apr 2015 05:16:28 +0300 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 MIME-Version: 1.0 To: Paul Eggert , 20290-done@debbugs.gnu.org Subject: Re: bug#20290: 25.0.50; Use unified diff format by default, and recommend using it in reports and patches References: <86bnix6p9l.fsf@yandex.ru> <552AFFF9.90501@cs.ucla.edu> In-Reply-To: <552AFFF9.90501@cs.ucla.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20290-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 04/13/2015 02:30 AM, Paul Eggert wrote: > As I recall, RMS preferred diff -c to diff -u, and that is partly why > trouble.texi suggests -c over -u and why diff-switches defaults to -c. Yup, Stephen reminded of that in a recent emacs-devel thread, so I thought this would be a good time to try to change it. > These days -u format is far more popular than -c format in practice, and > I expect that most active Emacs developers prefer -u, so it's > appropriate for Emacs to default to -u and for trouble.texi to suggest it. This is done now. Thanks everyone. > I suppose that in theory there is the issue of Emacs running on an older > POSIXish platform where 'diff' does not support -u. I don't have access > to any such platform, though. I can confirm that Solaris 10 diff (2005) > supports '-u'. So perhaps we don't need to worry about this. I think the usual response is that users on outdated systems don't necessarily have to be able to use the latest-and-greatest Emacs. But in this case the incompatibility would be very minor: if someone actually encounters this problem, they'll only need to customize the relevant variable. From unknown Tue Jun 24 17:26:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 12 May 2015 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator