GNU bug report logs - #2028
23.0.60; (1) dired-guess-default should remove duplicates (2) doc string

Previous Next

Full log

View this message in rfc822 format

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 2028 <at> debbugs.gnu.org
Subject: bug#2028: 23.0.60; (1) dired-guess-default should remove duplicates (2) doc string
Date: Mon, 11 Jul 2011 15:39:57 +0200

"Drew Adams" <drew.adams <at> oracle.com> writes:

> `dired-guess-default' returns a list of default shell commands
> appropriate for its input, FILES.  It should remove duplicates from
> this list before returning it.

Ok; done.

> Also, the doc string is:
>
> "Guess a shell commands for FILES.  Return command or list of commands.
> See `dired-guess-shell-alist-user'."
>
> This is not correct grammatically. Suggestion:
>
> "Return a shell command, or a list of such, appropriate for FILES.
> See `dired-guess-shell-alist-user'."

I've changed it to something like that.

> BTW (I didn't check the code - just a naive question): Why do we
> return sometimes a single command instead of a singleton list of that
> command? What is gained by this added complexity? Is there some
> calling code that *must* receive a command and not a list of commands?

I'm guessing somebody extended the function at some point.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.