From drew.adams@oracle.com Sat Jan 24 10:41:47 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 24 Jan 2009 18:41:48 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0OIfiGq006483 for ; Sat, 24 Jan 2009 10:41:46 -0800 Received: from mail.gnu.org ([199.232.76.166]:43092 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LQnQQ-0008VY-4I for emacs-pretest-bug@gnu.org; Sat, 24 Jan 2009 13:40:10 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LQnRv-0004Yk-Ds for emacs-pretest-bug@gnu.org; Sat, 24 Jan 2009 13:41:43 -0500 Received: from acsinet11.oracle.com ([141.146.126.233]:45679) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LQnRv-0004Yc-0n for emacs-pretest-bug@gnu.org; Sat, 24 Jan 2009 13:41:43 -0500 Received: from acsinet13.oracle.com (acsinet13.oracle.com [141.146.126.235]) by acsinet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n0OIhSwk015129 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 24 Jan 2009 18:43:30 GMT Received: from acsmt704.oracle.com (acsmt704.oracle.com [141.146.40.82]) by acsinet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n0OIfa7W012269 for ; Sat, 24 Jan 2009 18:41:37 GMT Received: from dradamslap1 (/24.5.128.33) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 24 Jan 2009 10:41:35 -0800 From: "Drew Adams" To: Subject: 23.0.60; (1) dired-guess-default should remove duplicates (2) doc string Date: Sat, 24 Jan 2009 10:41:44 -0800 Message-ID: <000b01c97e53$68c70ab0$0200a8c0@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Acl+U2fTm5B2eRMmTTe+6BYpkKCwew== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 X-Source-IP: acsmt704.oracle.com [141.146.40.82] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090206.497B60E1.0100:SCFSTAT928724,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) `dired-guess-default' returns a list of default shell commands appropriate for its input, FILES. It should remove duplicates from this list before returning it. Also, the doc string is: "Guess a shell commands for FILES. Return command or list of commands. See `dired-guess-shell-alist-user'." This is not correct grammatically. Suggestion: "Return a shell command, or a list of such, appropriate for FILES. See `dired-guess-shell-alist-user'." BTW (I didn't check the code - just a naive question): Why do we return sometimes a single command instead of a singleton list of that command? What is gained by this added complexity? Is there some calling code that *must* receive a command and not a list of commands? It seems like any calling code would need to be able to handle the list case, including a singleton list, anyway. In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600) of 2009-01-04 on LENNART-69DE564 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping' From rgm@gnu.org Wed Feb 25 00:46:52 2009 Received: (at control) by emacsbugs.donarmstrong.com; 25 Feb 2009 08:46:53 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.0 required=4.0 tests=VALID_BTS_CONTROL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1P8kohG000430 for ; Wed, 25 Feb 2009 00:46:51 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LcFNa-0005tS-5e; Wed, 25 Feb 2009 03:44:34 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18853.1265.990432.936530@fencepost.gnu.org> Date: Wed, 25 Feb 2009 03:44:33 -0500 From: Glenn Morris To: control Subject: control message tags 2163 moreinfo unreproducible severity 2136 minor reassign 2136 emacs,ms-dos severity 2030 minor severity 2035 minor severity 2028 minor reassign 2466 spam severity 2257 minor severity 1193 minor From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 11 09:40:24 2011 Received: (at control) by debbugs.gnu.org; 11 Jul 2011 13:40:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgGim-000616-BO for submit@debbugs.gnu.org; Mon, 11 Jul 2011 09:40:24 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgGik-00060r-2l for control@debbugs.gnu.org; Mon, 11 Jul 2011 09:40:23 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QgGiS-0000WJ-C2 for control@debbugs.gnu.org; Mon, 11 Jul 2011 15:40:04 +0200 Date: Mon, 11 Jul 2011 15:40:03 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #2028 X-MailScanner-ID: 1QgGiS-0000WJ-C2 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1310996404.47514@mKXYpUtYnRQQgAUgtTaErA X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) tags 2028 fixed close 2028 24.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 11 09:58:09 2011 Received: (at 2028) by debbugs.gnu.org; 11 Jul 2011 13:58:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgGzx-0007Rg-49 for submit@debbugs.gnu.org; Mon, 11 Jul 2011 09:58:09 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgGzv-0007RD-EP for 2028@debbugs.gnu.org; Mon, 11 Jul 2011 09:58:08 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QgGzj-00010g-Hr; Mon, 11 Jul 2011 15:57:55 +0200 From: Lars Magne Ingebrigtsen To: "Drew Adams" Subject: Re: 23.0.60; (1) dired-guess-default should remove duplicates (2) doc string In-Reply-To: <000b01c97e53$68c70ab0$0200a8c0@us.oracle.com> (Drew Adams's message of "Sat, 24 Jan 2009 10:41:44 -0800") Date: Mon, 11 Jul 2011 15:39:57 +0200 Message-ID: References: <000b01c97e53$68c70ab0$0200a8c0@us.oracle.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Pocahaunted's _Make It Real_: "Save Yrself (It's Nice)" X-Hashcash: 1:23:110711:emacs-pretest-bug@gnu.org::HTxrO+N7bn+RuO+J:000000000000000000000000000000000000BJCl X-Hashcash: 1:23:110711:2028@debbugs.gnu.org::mb/VVcJlf/aGHq6h:00000000000000000000000000000000000000000cA2E X-Hashcash: 1:23:110711:drew.adams@oracle.com::feaHMRstpS176u51:0000000000000000000000000000000000000001FPKd MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QgGzj-00010g-Hr X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1310997475.65032@NGsHDWWp5KeUQ7A6l1o/WQ X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 2028 Cc: 2028@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) "Drew Adams" writes: > `dired-guess-default' returns a list of default shell commands > appropriate for its input, FILES. It should remove duplicates from > this list before returning it. Ok; done. > Also, the doc string is: > > "Guess a shell commands for FILES. Return command or list of commands. > See `dired-guess-shell-alist-user'." > > This is not correct grammatically. Suggestion: > > "Return a shell command, or a list of such, appropriate for FILES. > See `dired-guess-shell-alist-user'." I've changed it to something like that. > BTW (I didn't check the code - just a naive question): Why do we > return sometimes a single command instead of a singleton list of that > command? What is gained by this added complexity? Is there some > calling code that *must* receive a command and not a list of commands? I'm guessing somebody extended the function at some point. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Mon Aug 18 19:35:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 09 Aug 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator