GNU bug report logs - #20276
24.4; diff-mode doesn't handle unified diff file headers without tabs

Previous Next

Package: emacs;

Reported by: Gustav Hållberg <gustav <at> gmail.com>

Date: Tue, 7 Apr 2015 22:35:01 UTC

Severity: normal

Found in version 24.4

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log

Message #16 received at 20276-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Gustav Hållberg <gustav <at> gmail.com>
Cc: 20276-done <at> debbugs.gnu.org
Subject: Re: bug#20276: 24.4;
 diff-mode doesn't handle unified diff file headers without tabs
Date: Wed, 08 Apr 2015 21:48:49 -0400

> git diff also does for what it's worth.

Ah, indeed.  This doesn't bite us too hard because git also happens to
provide the "diff ..." line.

> True, but note that diff-font-lock-keywords is more permissive; it does not
> require the tab to be present.

Of course a false positive in diff-font-lock-keywords will only look
funny but won't affect actual behavior, which is why I thought it was OK
to be more permissive.

Anyway, I guess we have to bite this bullet, so I installed your patch
into "master".  Thanks,


        Stefan
This bug report was last modified 10 years and 99 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.