GNU bug report logs - #20257
[PATCH] 24.4.90; set-visited-file-name doesn't reset buffer-auto-save-file-name

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#20257: closed ([PATCH] 24.4.90; set-visited-file-name doesn't
 reset buffer-auto-save-file-name)
Date: Tue, 07 Apr 2015 18:59:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 07 Apr 2015 14:57:25 -0400
with message-id <jwv6197rcl9.fsf-monnier+emacsbugs <at> gnu.org>
and subject line Re: bug#20257: [PATCH] 24.4.90; set-visited-file-name doesn't reset buffer-auto-save-file-name
has caused the debbugs.gnu.org bug report #20257,
regarding [PATCH] 24.4.90; set-visited-file-name doesn't reset buffer-auto-save-file-name
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
20257: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20257
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Vitalie Spinu <spinuvit <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] 24.4.90;
 set-visited-file-name doesn't reset buffer-auto-save-file-name
Date: Sat, 04 Apr 2015 15:41:58 +0200

[Message part 3 (text/plain, inline)]

Hi,

Do (set-visited-file-name nil) and then rename the buffer. The buffer
will be auto-saved into the old visiting file.

  Vitalie

[0001-Stop-auto-saving-after-set-visited-file-name-with-ni.patch (text/x-diff, inline)]

From 9b68126dfe58478424ec2b726cc307b1c0d96b1a Mon Sep 17 00:00:00 2001
From: Vitalie Spinu <spinuvit <at> gmail.com>
Date: Sat, 4 Apr 2015 15:28:07 +0200
Subject: [PATCH] Stop auto-saving after `set-visited-file-name` with nil
 FILENAME

---
 lisp/files.el | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/lisp/files.el b/lisp/files.el
index 42b00ac..7d36608 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -3931,17 +3931,19 @@ the old visited file has been renamed to the new name FILENAME."
 	   (make-local-variable 'backup-inhibited)
 	   (setq backup-inhibited t)))
     (let ((oauto buffer-auto-save-file-name))
-      ;; If auto-save was not already on, turn it on if appropriate.
-      (if (not buffer-auto-save-file-name)
-	  (and buffer-file-name auto-save-default
-	       (auto-save-mode t))
-	;; If auto save is on, start using a new name.
-	;; We deliberately don't rename or delete the old auto save
-	;; for the old visited file name.  This is because perhaps
-	;; the user wants to save the new state and then compare with the
-	;; previous state from the auto save file.
-	(setq buffer-auto-save-file-name
-	      (make-auto-save-file-name)))
+      (cond ((null filename)
+	     (setq buffer-auto-save-file-name nil))
+	    ((not buffer-auto-save-file-name)
+	     ;; If auto-save was not already on, turn it on if appropriate.
+	     (and buffer-file-name auto-save-default (auto-save-mode t))
+	     (t
+	      ;; If auto save is on, start using a new name. We
+	      ;; deliberately don't rename or delete the old auto save
+	      ;; for the old visited file name.  This is because
+	      ;; perhaps the user wants to save the new state and then
+	      ;; compare with the previous state from the auto save
+	      ;; file.
+	      (setq buffer-auto-save-file-name (make-auto-save-file-name)))))
       ;; Rename the old auto save file if any.
       (and oauto buffer-auto-save-file-name
 	   (file-exists-p oauto)
-- 
2.1.0

[Message part 5 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Vitalie Spinu <spinuvit <at> gmail.com>
Cc: 20257-done <at> debbugs.gnu.org
Subject: Re: bug#20257: [PATCH] 24.4.90;
 set-visited-file-name doesn't reset buffer-auto-save-file-name
Date: Tue, 07 Apr 2015 14:57:25 -0400

Thank you, installed into master,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.