GNU bug report logs - #20256
25.0.50; css-mode: filling multi-line comments

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Simen Heggestøyl <simenheg <at> gmail.com>
Subject: bug#20256: closed (Re: bug#20256: 25.0.50; css-mode: filling
 multi-line comments)
Date: Sat, 18 Apr 2015 18:34:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#20256: 25.0.50; css-mode: filling multi-line comments

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 20256 <at> debbugs.gnu.org.

-- 
20256: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20256
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 20256-done <at> debbugs.gnu.org
Subject: Re: bug#20256: 25.0.50; css-mode: filling multi-line comments
Date: Sat, 18 Apr 2015 20:33:39 +0200

[Message part 3 (text/plain, inline)]

On Sat, Apr 18, 2015 at 4:06 PM, Stefan Monnier 
<monnier <at> IRO.UMontreal.CA> wrote:
> Thank you.  Looks good to me.

Installed.

> Maybe we should even try to move this fill function to prog-mode.el.

Sounds good!

-- Simen

[Message part 4 (text/html, inline)]

[Message part 5 (message/rfc822, inline)]

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; css-mode: filling multi-line comments
Date: Sat, 04 Apr 2015 15:12:31 +0200

[Message part 6 (text/plain, inline)]

Filling multi-line comments in `css-mode' is broken. Consider for
instance the following comment:

 /*
  * Multi-line comment here.
  * This comment spans
  * multiple
  * lines.
  * Better fill it!
  */

Filling it with a `fill-column' of 70, I'd expect the following
result:

 /*
  * Multi-line comment here.  This comment spans multiple lines.
  * Better fill it!
  */

But as of now, what we get is this:

 /* * Multi-line comment here.  * This comment spans * multiple *
 lines.  * Better fill it!  */

From this comment in `css-fill-paragraph', it sounds like it is
supposed to work, or has been working some time before:

 ;; Filling inside a comment whose comment-end marker is not \n.
 ;; This code is meant to be generic, so that it works not only for
 ;; css-mode but for all modes.

Could someone fill me in?

Alternatively, we could let `css-mode' borrow comment filling code
from `cc-mode', like `js-mode' and `js2-mode' do. Please let me know
if that would be an acceptable fix.

-- Simen

[Message part 7 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.