Subject: bug#20256: closed (Re: bug#20256: 25.0.50; css-mode: filling multi-line comments)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 18 Apr 2015 18:34:03 +0000

Your bug report

#20256: 25.0.50; css-mode: filling multi-line comments

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
20256: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20256
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#20256: 25.0.50; css-mode: filling multi-line comments
From: Simen Heggestøyl <[email-masked]>
To: Stefan Monnier <[email-masked]>
Cc: [email-masked]
Date: Sat, 18 Apr 2015 20:33:39 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

On Sat, Apr 18, 2015 at 4:06 PM, Stefan Monnier 
<[email-masked]> wrote:
> Thank you.  Looks good to me.

Installed.

> Maybe we should even try to move this fill function to prog-mode.el.

Sounds good!

-- Simen

Subject: 25.0.50; css-mode: filling multi-line comments
From: Simen Heggestøyl <[email-masked]>
To: [email-masked]
Date: Sat, 04 Apr 2015 15:12:31 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Filling multi-line comments in `css-mode' is broken. Consider for
instance the following comment:

  /*
   * Multi-line comment here.
   * This comment spans
   * multiple
   * lines.
   * Better fill it!
   */

Filling it with a `fill-column' of 70, I'd expect the following
result:

  /*
   * Multi-line comment here.  This comment spans multiple lines.
   * Better fill it!
   */

But as of now, what we get is this:

  /* * Multi-line comment here.  * This comment spans * multiple *
  lines.  * Better fill it!  */

 From this comment in `css-fill-paragraph', it sounds like it is
supposed to work, or has been working some time before:

  ;; Filling inside a comment whose comment-end marker is not \n.
  ;; This code is meant to be generic, so that it works not only for
  ;; css-mode but for all modes.

Could someone fill me in?

Alternatively, we could let `css-mode' borrow comment filling code
from `cc-mode', like `js-mode' and `js2-mode' do. Please let me know
if that would be an acceptable fix.

-- Simen