From unknown Fri Sep 05 08:57:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20249: [PATCH] tramp: tramp-flush-directory-property loops infinitly. Resent-From: arakawa@pp.iij4u.or.jp Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Apr 2015 01:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20249 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 20249@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.142802592821097 (code B ref -1); Fri, 03 Apr 2015 01:53:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Apr 2015 01:52:08 +0000 Received: from localhost ([127.0.0.1]:43523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YdqmE-0005UC-5Y for submit@debbugs.gnu.org; Thu, 02 Apr 2015 21:52:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49313) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YdpWe-0003a6-Q3 for submit@debbugs.gnu.org; Thu, 02 Apr 2015 20:31:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdpWY-0006er-IC for submit@debbugs.gnu.org; Thu, 02 Apr 2015 20:31:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdpWY-0006en-FL for submit@debbugs.gnu.org; Thu, 02 Apr 2015 20:31:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdpWX-0007aC-JF for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2015 20:31:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdpWT-0006eY-JL for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2015 20:31:49 -0400 Received: from mo-sw1501.iij4u.or.jp ([210.130.239.241]:44085 helo=mo-sw.iij4u.or.jp) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdpWS-0006eE-Pz for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2015 20:31:45 -0400 DKIM-Signature: v=1;a=rsa-sha256;c=relaxed/simple;d=pp.iij4u.or.jp;h=Date: Message-Id:To:Subject:From:Mime-Version:Content-Type: Content-Transfer-Encoding;i=arakawa@pp.iij4u.or.jp;s=20140530.iij4u;t= 1428021100; x=1429230700; bh=WNIAsgexbXN2iffkkoV/TDorQx+V68OwFhPmmKVbDU4=; b=MEd NLXTqcqsrsjbGDRJWtf3ulsIHy2n/uBsZ1/CIPVpTXQNnCmx2Rq2yygiPCsZZ1OqsfHr7wfQ1XHGh KnqlmRO7rpfzU9mJXlG7nDdLZMu/y5nSK1NVtfTWAkfoE24IImVR8bmbk2tqAQ2dpgaqU5OK7cMQY mK7AV5pYUqeBGsUET4nk2HASzFPpfHhER30eG/w4SiBp4bsibvlr5BybG3bLoyelrXDNDe3yKfdV0 Iva19d0+PpAtk+myAbKswn/8ue7mu1NfCPL5KVH6bQ030HWMNL4ZHKOboT/DgC6XCQDIzQF0YXILw zIqiqboYvG1J4Z17EyhBGISS0leyOgA==; Received: by mo-sw.iij4u.or.jp (4u-mo-sw1501) id t330Ve2s007581; Fri, 3 Apr 2015 09:31:40 +0900 Received: from localhost ([IPv6:2001:e41:a010:778a:7d27:3c3b:9313:6d87]) by mbox.iij4u.or.jp (4u-mbox1500) id t330VWb6017082 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 3 Apr 2015 09:31:39 +0900 Date: Fri, 03 Apr 2015 09:31:21 +0900 (=?UTF-8?Q?=E6=9D=B1=E4=BA=AC?= (=?UTF-8?Q?=E6=A8=99=E6=BA=96=E6=99=82?=)) Message-Id: <20150403.093121.1376099698840392615.arakawa@pp.iij4u.or.jp> From: arakawa@pp.iij4u.or.jp X-Mailer: Mew version 6.6 on Emacs 25.0.50 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Mailman-Approved-At: Thu, 02 Apr 2015 21:52:03 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hi, When tramp-flush-directory-property called with 'directory' which ends in slash, directory-file-name removes the trailing slash but 'file-truename' operation doesn't necessarily remove it. In that case, directory and truename always differ and tramp-flush-directory-property called infinitely. Best regards, Koichi Arakawa --- lisp/ChangeLog | 5 +++++ lisp/net/tramp-cache.el | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 38e45d0..3f86a43 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2015-04-03 Koichi Arakawa + + * net/tramp-cache.el (tramp-flush-directory-property): Fix an + infinite loop when 'directory' ends in slash. + 2015-04-02 Stefan Monnier * abbrev.el (define-abbrev-table): Treat a non-string "docstring" as diff --git a/lisp/net/tramp-cache.el b/lisp/net/tramp-cache.el index 1e24ea5..a418eb5 100644 --- a/lisp/net/tramp-cache.el +++ b/lisp/net/tramp-cache.el @@ -188,7 +188,8 @@ Remove also properties of all files in subdirectories." (truename (tramp-get-file-property key directory "file-truename" nil))) ;; Remove file properties of symlinks. (when (and (stringp truename) - (not (string-equal directory truename))) + (not (string-equal directory truename)) + (not (string-equal (concat directory "/") truename))) (tramp-flush-directory-property key truename)) (tramp-message key 8 "%s" directory) (maphash -- 2.3.4 From unknown Fri Sep 05 08:57:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20249: tramp: tramp-flush-directory-property loops infinitely Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Apr 2015 05:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20249 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 20249@debbugs.gnu.org Received: via spool by 20249-submit@debbugs.gnu.org id=B20249.142803975515347 (code B ref 20249); Fri, 03 Apr 2015 05:43:01 +0000 Received: (at 20249) by debbugs.gnu.org; 3 Apr 2015 05:42:35 +0000 Received: from localhost ([127.0.0.1]:43580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YduNG-0003zS-S2 for submit@debbugs.gnu.org; Fri, 03 Apr 2015 01:42:35 -0400 Received: from fely.am-1.org ([78.47.74.50]:37028) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YduNE-0003zI-Fb for 20249@debbugs.gnu.org; Fri, 03 Apr 2015 01:42:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=eKEYMKuKL92dflbht7EIRMHcGd+8LnrmM2FpVF+iODE=; b=mzm5Kyk7SLlpiJoaTYUG49sJZpPG0UQdZNFKDY9EGPNZaqgGdtqW7Ylq4OvFj8TzxmhcdUywJg+qw9z1RNKoEJRQh2EYKAUWs84wYGFKqf4+Q5bH0cz4GbrQF5app4rjn3fx68MvSbBTSV3YnK7G512cJSrqDnSsv0rRlIhY7EE=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YduNC-00053R-0B for 20249@debbugs.gnu.org; Fri, 03 Apr 2015 05:42:30 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YduN5-00058G-22 for 20249@debbugs.gnu.org; Fri, 03 Apr 2015 12:42:23 +0700 From: Ivan Shmakov References: <20150403.093121.1376099698840392615.arakawa@pp.iij4u.or.jp> Date: Fri, 03 Apr 2015 05:42:21 +0000 In-Reply-To: <20150403.093121.1376099698840392615.arakawa@pp.iij4u.or.jp> (arakawa@pp.iij4u.or.jp's message of "Fri, 03 Apr 2015 09:31:21 +0900 (=?UTF-8?Q?=E6=9D=B1=E4=BA=AC?= (=?UTF-8?Q?=E6=A8=99=E6=BA=96=E6=99=82?=))") Message-ID: <87sichu5s2.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Koichi Arakawa writes: [=E2=80=A6] > @@ -188,7 +188,8 @@ defun tramp-flush-directory-property (key directory) > (truename (tramp-get-file-property key directory "file-truename" nil)= )) > ;; Remove file properties of symlinks. > (when (and (stringp truename) > - (not (string-equal directory truename))) > + (not (string-equal directory truename)) > + (not (string-equal (concat directory "/") truename))) > (tramp-flush-directory-property key truename)) > (tramp-message key 8 "%s" directory) > (maphash I believe the above should use file-name-as-directory instead of a plain concat. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From unknown Fri Sep 05 08:57:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20249: [PATCH] tramp: tramp-flush-directory-property loops infinitly. Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Apr 2015 16:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20249 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: arakawa@pp.iij4u.or.jp Cc: 20249@debbugs.gnu.org Received: via spool by 20249-submit@debbugs.gnu.org id=B20249.142808024725261 (code B ref 20249); Fri, 03 Apr 2015 16:58:02 +0000 Received: (at 20249) by debbugs.gnu.org; 3 Apr 2015 16:57:27 +0000 Received: from localhost ([127.0.0.1]:44117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ye4uM-0006ZM-Ke for submit@debbugs.gnu.org; Fri, 03 Apr 2015 12:57:27 -0400 Received: from mout.gmx.net ([212.227.17.22]:57450) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ye4uK-0006Yy-Cv for 20249@debbugs.gnu.org; Fri, 03 Apr 2015 12:57:25 -0400 Received: from detlef.gmx.de ([87.146.42.125]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0M93Jp-1YjtNx0In7-00CPKy; Fri, 03 Apr 2015 18:57:16 +0200 From: Michael Albinus References: <20150403.093121.1376099698840392615.arakawa@pp.iij4u.or.jp> Date: Fri, 03 Apr 2015 18:57:14 +0200 In-Reply-To: <20150403.093121.1376099698840392615.arakawa@pp.iij4u.or.jp> (arakawa@pp.iij4u.or.jp's message of "Fri, 03 Apr 2015 09:31:21 +0900 (=?UTF-8?Q?=E6=9D=B1=E4=BA=AC?= (=?UTF-8?Q?=E6=A8=99=E6=BA=96=E6=99=82?=))") Message-ID: <87d23ljgk5.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:c2bs5VKsL511jDsacfmTRk1dKY0n9rOkTmyLEFFzw0lQ0FAWUWQ T1bSjOIgNlCWnvkQ/eFJ0L09E15oNy7hSCe+zMFlNxq59Pxpn5A065Llw72vrv/b3dBeWsY R1bIKGFJSGBdcrdbQT2oo0Z1DgST56fIy1S80jsw3KcRh9wunlQO2eROF/kHchAGv2GnUIw oEQ076ioh8pgCwyZ0aQTA== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) arakawa@pp.iij4u.or.jp writes: > Hi, Hi, > When tramp-flush-directory-property called with 'directory' which ends > in slash, directory-file-name removes the trailing slash but > 'file-truename' operation doesn't necessarily remove it. In that case, > directory and truename always differ and > tramp-flush-directory-property called infinitely. Thanks for the report. tramp-flush-file-property seems also be affected (but it doesn't recurse indefinitely). I have committed a patch to the master branch which shall fix all the cases. Could you, please, test it? > Best regards, > Koichi Arakawa Best regards, Michael. From unknown Fri Sep 05 08:57:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20249: [PATCH] tramp: tramp-flush-directory-property loops infinitly. Resent-From: "Koichi Arakawa" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Apr 2015 18:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20249 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: michael.albinus@gmx.de Cc: 20249@debbugs.gnu.org Received: via spool by 20249-submit@debbugs.gnu.org id=B20249.14280861872621 (code B ref 20249); Fri, 03 Apr 2015 18:37:01 +0000 Received: (at 20249) by debbugs.gnu.org; 3 Apr 2015 18:36:27 +0000 Received: from localhost ([127.0.0.1]:44142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ye6SB-0000gD-Au for submit@debbugs.gnu.org; Fri, 03 Apr 2015 14:36:27 -0400 Received: from mo-sw1500.iij4u.or.jp ([210.130.239.240]:54685 helo=mo-sw.iij4u.or.jp) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ye6S8-0000fv-4W for 20249@debbugs.gnu.org; Fri, 03 Apr 2015 14:36:26 -0400 DKIM-Signature: v=1;a=rsa-sha256;c=relaxed/simple;d=pp.iij4u.or.jp;h=Date: Message-Id:To:Cc:Subject:From:In-Reply-To:References:Mime-Version: Content-Type:Content-Transfer-Encoding;i=arakawa@pp.iij4u.or.jp;s= 20140530.iij4u; t=1428086176; x=1429295776; bh=kLijIFrz3VK2Ams9F64GNjduNWZwh1oAl TjbWMPhRLI=; b=V2syqXSTulB6aHjMzOHnlPHs75XQr+XybvdnbSaemuW45EEaRYAoCNb6I8FkN6p dKnd51PkVjdh1mRUyS+RoD6Y+xxEfqyMy2IDAHznafkt4gScuPxPjovCMhdA8+EBytoqUVxXFqnmx tkucAGmrAyem/55jgn1a8cwZ7S9Lsh5U7wY9aNRLJutA6w3kX57BbAEZy/IsVxJN72P+Wf4yB6juR yXbUTbljX/dApIYLXEgmk97A3MXKBGmEqIly6xfCKVib7LkUJMitQfeVIlXikoDKNFJTB8oaJuysj th2ljJZppu6UuMrvILirzFuCM4ZW60EgXJygBhr7tPuV5qIg==; Received: by mo-sw.iij4u.or.jp (4u-mo-sw1500) id t33IaFgI018983; Sat, 4 Apr 2015 03:36:16 +0900 Received: from localhost (corsica.s2factory.co.jp [122.220.15.114]) by mbox.iij4u.or.jp (4u-mbox1500) id t33IaECU030788 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Sat, 4 Apr 2015 03:36:15 +0900 Date: Sat, 04 Apr 2015 03:34:55 +0900 (=?UTF-8?Q?=E6=9D=B1=E4=BA=AC?= (=?UTF-8?Q?=E6=A8=99=E6=BA=96=E6=99=82?=)) Message-Id: <20150404.033455.2028150774309158706.arakawa@pp.iij4u.or.jp> From: "Koichi Arakawa" In-Reply-To: <87d23ljgk5.fsf@gmx.de> References: <20150403.093121.1376099698840392615.arakawa@pp.iij4u.or.jp> <87d23ljgk5.fsf@gmx.de> X-Mailer: Mew version 6.6 on Emacs 25.0.50 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi Michael, > Thanks for the report. tramp-flush-file-property seems also be affected > (but it doesn't recurse indefinitely). I have committed a patch to the > master branch which shall fix all the cases. Could you, please, test it? Sure. I have tested it and it works fine. Thank you. -- Koichi Arakawa From unknown Fri Sep 05 08:57:52 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: arakawa@pp.iij4u.or.jp Subject: bug#20249: closed (Re: bug#20249: [PATCH] tramp: tramp-flush-directory-property loops infinitly.) Message-ID: References: <877fttj9ov.fsf@gmx.de> <20150403.093121.1376099698840392615.arakawa@pp.iij4u.or.jp> X-Gnu-PR-Message: they-closed 20249 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 20249@debbugs.gnu.org Date: Fri, 03 Apr 2015 19:26:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1428089163-7080-1" This is a multi-part message in MIME format... ------------=_1428089163-7080-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #20249: [PATCH] tramp: tramp-flush-directory-property loops infinitly. which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 20249@debbugs.gnu.org. --=20 20249: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D20249 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1428089163-7080-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 20249-done) by debbugs.gnu.org; 3 Apr 2015 19:25:49 +0000 Received: from localhost ([127.0.0.1]:44157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ye7Dx-0001pm-4x for submit@debbugs.gnu.org; Fri, 03 Apr 2015 15:25:49 -0400 Received: from mout.gmx.net ([212.227.17.22]:54753) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ye7Du-0001pZ-HP for 20249-done@debbugs.gnu.org; Fri, 03 Apr 2015 15:25:47 -0400 Received: from detlef.gmx.de ([87.146.42.125]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MFAaV-1Yg11M270l-00GM20; Fri, 03 Apr 2015 21:25:39 +0200 From: Michael Albinus To: "Koichi Arakawa" Subject: Re: bug#20249: [PATCH] tramp: tramp-flush-directory-property loops infinitly. References: <20150403.093121.1376099698840392615.arakawa@pp.iij4u.or.jp> <87d23ljgk5.fsf@gmx.de> <20150404.033455.2028150774309158706.arakawa@pp.iij4u.or.jp> Date: Fri, 03 Apr 2015 21:25:36 +0200 In-Reply-To: <20150404.033455.2028150774309158706.arakawa@pp.iij4u.or.jp> (Koichi Arakawa's message of "Sat, 04 Apr 2015 03:34:55 +0900 =?utf-8?B?KOadseS6rAko5qiZ5rqW5pmCKSki?=) Message-ID: <877fttj9ov.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:VOWUru75PH2o6tf6gLXoLD8LedVnYS8H1ZVvbv1uOkXk/Vb1eDR XMZWc8uOP8jL665d9ASTF2T+Al0xBfOm0qi04aImOFgqNEmTgIVNblsK/o+5fqykudamEUG nNAd2GRwiWo3CLs3s2uFIAI1E2suTiGbvYUK3YPAwuJM8lteTaXrBKIGkdv7RMyZJZZ5as5 XmcIw83LuwS6MCC03V12Q== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20249-done Cc: 20249-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Version: 25.1 "Koichi Arakawa" writes: > Hi Michael, Hi, >> Thanks for the report. tramp-flush-file-property seems also be affected >> (but it doesn't recurse indefinitely). I have committed a patch to the >> master branch which shall fix all the cases. Could you, please, test it? > > Sure. I have tested it and it works fine. Thank you. Thanks for testing. I'm closing the bug. Best regards, Michael. ------------=_1428089163-7080-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Apr 2015 01:52:08 +0000 Received: from localhost ([127.0.0.1]:43523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YdqmE-0005UC-5Y for submit@debbugs.gnu.org; Thu, 02 Apr 2015 21:52:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49313) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YdpWe-0003a6-Q3 for submit@debbugs.gnu.org; Thu, 02 Apr 2015 20:31:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdpWY-0006er-IC for submit@debbugs.gnu.org; Thu, 02 Apr 2015 20:31:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdpWY-0006en-FL for submit@debbugs.gnu.org; Thu, 02 Apr 2015 20:31:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdpWX-0007aC-JF for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2015 20:31:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdpWT-0006eY-JL for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2015 20:31:49 -0400 Received: from mo-sw1501.iij4u.or.jp ([210.130.239.241]:44085 helo=mo-sw.iij4u.or.jp) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdpWS-0006eE-Pz for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2015 20:31:45 -0400 DKIM-Signature: v=1;a=rsa-sha256;c=relaxed/simple;d=pp.iij4u.or.jp;h=Date: Message-Id:To:Subject:From:Mime-Version:Content-Type: Content-Transfer-Encoding;i=arakawa@pp.iij4u.or.jp;s=20140530.iij4u;t= 1428021100; x=1429230700; bh=WNIAsgexbXN2iffkkoV/TDorQx+V68OwFhPmmKVbDU4=; b=MEd NLXTqcqsrsjbGDRJWtf3ulsIHy2n/uBsZ1/CIPVpTXQNnCmx2Rq2yygiPCsZZ1OqsfHr7wfQ1XHGh KnqlmRO7rpfzU9mJXlG7nDdLZMu/y5nSK1NVtfTWAkfoE24IImVR8bmbk2tqAQ2dpgaqU5OK7cMQY mK7AV5pYUqeBGsUET4nk2HASzFPpfHhER30eG/w4SiBp4bsibvlr5BybG3bLoyelrXDNDe3yKfdV0 Iva19d0+PpAtk+myAbKswn/8ue7mu1NfCPL5KVH6bQ030HWMNL4ZHKOboT/DgC6XCQDIzQF0YXILw zIqiqboYvG1J4Z17EyhBGISS0leyOgA==; Received: by mo-sw.iij4u.or.jp (4u-mo-sw1501) id t330Ve2s007581; Fri, 3 Apr 2015 09:31:40 +0900 Received: from localhost ([IPv6:2001:e41:a010:778a:7d27:3c3b:9313:6d87]) by mbox.iij4u.or.jp (4u-mbox1500) id t330VWb6017082 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 3 Apr 2015 09:31:39 +0900 Date: Fri, 03 Apr 2015 09:31:21 +0900 =?iso-2022-jp?B?KBskQkVsNX4bKEIgKBskQkk4PWA7fhsoQikp?= Message-Id: <20150403.093121.1376099698840392615.arakawa@pp.iij4u.or.jp> To: bug-gnu-emacs@gnu.org Subject: [PATCH] tramp: tramp-flush-directory-property loops infinitly. From: arakawa@pp.iij4u.or.jp X-Mailer: Mew version 6.6 on Emacs 25.0.50 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 02 Apr 2015 21:52:03 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hi, When tramp-flush-directory-property called with 'directory' which ends in slash, directory-file-name removes the trailing slash but 'file-truename' operation doesn't necessarily remove it. In that case, directory and truename always differ and tramp-flush-directory-property called infinitely. Best regards, Koichi Arakawa --- lisp/ChangeLog | 5 +++++ lisp/net/tramp-cache.el | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 38e45d0..3f86a43 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2015-04-03 Koichi Arakawa + + * net/tramp-cache.el (tramp-flush-directory-property): Fix an + infinite loop when 'directory' ends in slash. + 2015-04-02 Stefan Monnier * abbrev.el (define-abbrev-table): Treat a non-string "docstring" as diff --git a/lisp/net/tramp-cache.el b/lisp/net/tramp-cache.el index 1e24ea5..a418eb5 100644 --- a/lisp/net/tramp-cache.el +++ b/lisp/net/tramp-cache.el @@ -188,7 +188,8 @@ Remove also properties of all files in subdirectories." (truename (tramp-get-file-property key directory "file-truename" nil))) ;; Remove file properties of symlinks. (when (and (stringp truename) - (not (string-equal directory truename))) + (not (string-equal directory truename)) + (not (string-equal (concat directory "/") truename))) (tramp-flush-directory-property key truename)) (tramp-message key 8 "%s" directory) (maphash -- 2.3.4 ------------=_1428089163-7080-1--