GNU bug report logs - #20245
24.5; c++-mode font-lock broken by the last commit to emacs24 branch

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alan Mackenzie <acm <at> muc.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#20245: closed (24.5; c++-mode font-lock broken by the last
 commit to emacs24 branch)
Date: Fri, 03 Apr 2015 12:48:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 3 Apr 2015 12:46:53 +0000
with message-id <20150403124653.GE2867 <at> acm.fritz.box>
and subject line Re: bug#20245: 24.5; c++-mode font-lock broken by the last commit to emacs24 branch
has caused the debbugs.gnu.org bug report #20245,
regarding 24.5; c++-mode font-lock broken by the last commit to emacs24 branch
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
20245: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20245
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Oleh Krehel <ohwoeowho <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: acm <at> muc.de
Subject: 24.5; c++-mode font-lock broken by the last commit to emacs24 branch
Date: Thu, 02 Apr 2015 08:55:58 +0200

Hello,

The font-locking of at least C++ headers was broken in "d69e9f1".
Here's a screenshot: http://i.imgur.com/eT6X3hP.png. You can see three
artifacts there. They change number and location when I scroll.

It goes back to a good state if I revert the commit and re-compile.
I hope this gets fixed by 24.5 release, even by just reverting
"d69e9f1", since this one is a bigger bug than
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19669, which "d69e9f1" fixes.

Oleh

[Message part 3 (message/rfc822, inline)]

From: Alan Mackenzie <acm <at> muc.de>
To: Oleh Krehel <ohwoeowho <at> gmail.com>
Cc: 20245-done <at> debbugs.gnu.org
Subject: Re: bug#20245: 24.5; c++-mode font-lock broken by the last commit to
 emacs24 branch
Date: Fri, 3 Apr 2015 12:46:53 +0000

Hello, Oleh.

On Thu, Apr 02, 2015 at 12:19:36PM +0200, Oleh Krehel wrote:
> On Thu, Apr 2, 2015 at 11:51 AM, Alan Mackenzie <acm <at> muc.de> wrote:
> > In article <mailman.3171.1427958137.31049.bug-gnu-emacs <at> gnu.org> you wrote:

> >> The font-locking of at least C++ headers was broken in "d69e9f1".
> >> Here's a screenshot: http://i.imgur.com/eT6X3hP.png. You can see three
> >> artifacts there. They change number and location when I scroll.

> > This was fixed very recently in the master branch.  Would you please try
> > the same file in master to confirm that the fix is a fix.

> I just tried "23bb07e", the latest commit on master, but this issue isn't fixed.
> The include statements look the same as in the screenshot.

I've looked at this problem and now understand its cause.  It's too
involved to fix for Emacs 24.5, so we've decided to revert that commit,
as you've suggested.  A proper fix will surely be included in Emacs 25.1
(or 24.6, whichever comes first).

Thanks for taking the trouble to report this bug.  I'm closing it now.

> Oleh

-- 
Alan Mackenzie (Nuremberg, Germany).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.