GNU bug report logs - #20241
25.0.50; `setq' with only one argument

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Wed, 1 Apr 2015 14:54:02 UTC

Severity: wishlist

Found in version 25.0.50

Done: Alan Mackenzie <acm <at> muc.de>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Alan Mackenzie <acm <at> muc.de>
To: Artur Malabarba <bruce.connor.am <at> gmail.com>
Cc: John Wiegley <jwiegley <at> gmail.com>, 20241 <at> debbugs.gnu.org, Johan Bockgård <bojohan <at> gnu.org>, Andreas Schwab <schwab <at> suse.de>
Subject: bug#20241: 25.0.50; `setq' with only one argument
Date: Thu, 26 Nov 2015 21:19:47 +0000
Evening, Artur.

On Thu, Nov 26, 2015 at 04:38:37PM +0000, Artur Malabarba wrote:
> > +        (mapc 'byte-compile-form (cdr form))

> Use #' instead of ' please. ☺

:-).  That wasn't my bit of code, I just had to reindent it.  It dates
from a time before using #' became fashionable.  Maybe there's something
to be said for replacing all such uses (or which there are 15) in the
file.

On a more serious note, given how there's potential for `funcall' to
segfault (without my latest proposed fix), perhaps I should go through
the entire byte compiler checking for similar occurrences.

On another note, I've managed to byte compile elpa, and there are indeed
three occurrences of bad `setq's, like you said.  There were
byte-compiler errors (which aborted the compilation) in packages elcs,
and rudel-mode, so there just might be more in there.

-- 
Alan Mackenzie (Nuremberg, Germany).




This bug report was last modified 9 years and 238 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.