From unknown Sun Aug 17 10:24:20 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#20241 <20241@debbugs.gnu.org> To: bug#20241 <20241@debbugs.gnu.org> Subject: Status: 25.0.50; `setq' with only one argument Reply-To: bug#20241 <20241@debbugs.gnu.org> Date: Sun, 17 Aug 2025 17:24:20 +0000 retitle 20241 25.0.50; `setq' with only one argument reassign 20241 emacs submitter 20241 Drew Adams severity 20241 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 01 10:53:56 2015 Received: (at submit) by debbugs.gnu.org; 1 Apr 2015 14:53:56 +0000 Received: from localhost ([127.0.0.1]:42586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YdK1j-0002QG-Jm for submit@debbugs.gnu.org; Wed, 01 Apr 2015 10:53:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36353) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YdK1h-0002Q2-Lw for submit@debbugs.gnu.org; Wed, 01 Apr 2015 10:53:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdK1b-00037X-8v for submit@debbugs.gnu.org; Wed, 01 Apr 2015 10:53:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdK1a-00037O-VG for submit@debbugs.gnu.org; Wed, 01 Apr 2015 10:53:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdK1Z-0005Gt-SI for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2015 10:53:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdK1T-00035Q-LI for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2015 10:53:45 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:17236) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdK1T-000355-Fb for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2015 10:53:39 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t31ErbRj005414 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 1 Apr 2015 14:53:37 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t31Erawt007983 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Wed, 1 Apr 2015 14:53:36 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id t31Eravq025081 for ; Wed, 1 Apr 2015 14:53:36 GMT MIME-Version: 1.0 Message-ID: <16400d25-dff1-4bfb-b929-814714f9e20f@default> Date: Wed, 1 Apr 2015 07:53:36 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 25.0.50; `setq' with only one argument X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0021.oracle.com [156.151.31.71] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) See for example: `(setq mark-active)' in `compilation-goto-locus' (compile.el). setq' should not be called with only one argument. It "works", with the effect of assigning a value of nil, but it is poor form. Typically this is a sign of a typo. Beyond this particular occurrence, I think that a wrong-number-of-args error should be raised when `setq' is called with an odd number of arguments. That certainly corresponds to the syntax that is documented. And it corresponds to the doc explanations that using `setq' is the same as using `set' and quoting the variable. And it corresponds to the definition and behavior of `setq' in Common Lisp. In GNU Emacs 25.0.50.1 (i686-pc-mingw32) of 2014-10-20 on LEG570 Bzr revision: 118168 rgm@gnu.org-20141020195941-icp42t8ttcnud09g Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking=3Dyes,glyphs CPPFLAGS=3D-DGLYPH_DEBUG=3D1' From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 01 12:42:21 2015 Received: (at 20241) by debbugs.gnu.org; 1 Apr 2015 16:42:21 +0000 Received: from localhost ([127.0.0.1]:42630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YdLif-00050p-Fr for submit@debbugs.gnu.org; Wed, 01 Apr 2015 12:42:21 -0400 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:49011) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YdLid-00050g-NH for 20241@debbugs.gnu.org; Wed, 01 Apr 2015 12:42:20 -0400 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id B0C3985F0B; Wed, 1 Apr 2015 12:42:17 -0400 (EDT) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 3EED81E5B8C; Wed, 1 Apr 2015 12:41:54 -0400 (EDT) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 1B090B40DB; Wed, 1 Apr 2015 12:41:54 -0400 (EDT) From: Stefan Monnier To: Drew Adams Subject: Re: bug#20241: 25.0.50; `setq' with only one argument Message-ID: References: <16400d25-dff1-4bfb-b929-814714f9e20f@default> Date: Wed, 01 Apr 2015 12:41:54 -0400 In-Reply-To: <16400d25-dff1-4bfb-b929-814714f9e20f@default> (Drew Adams's message of "Wed, 1 Apr 2015 07:53:36 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Status: No X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20241 Cc: 20241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > Beyond this particular occurrence, I think that a wrong-number-of-args > error should be raised when `setq' is called with an odd number of > arguments. At the very least the byte-compiler should warn about it, indeed. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 23 09:31:39 2015 Received: (at 20241-done) by debbugs.gnu.org; 23 Nov 2015 14:31:40 +0000 Received: from localhost ([127.0.0.1]:49161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0s9a-0007wV-Aw for submit@debbugs.gnu.org; Mon, 23 Nov 2015 09:31:38 -0500 Received: from mail.muc.de ([193.149.48.3]:46936) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0s9B-0007v7-Jd for 20241-done@debbugs.gnu.org; Mon, 23 Nov 2015 09:31:32 -0500 Received: (qmail 83912 invoked by uid 3782); 23 Nov 2015 14:31:12 -0000 Date: 23 Nov 2015 14:31:12 -0000 Message-ID: <20151123143112.83911.qmail@mail.muc.de> From: Alan Mackenzie To: 20241-done@debbugs.gnu.org Subject: Re: bug#20241: 25.0.50; `setq' with only one argument Organization: muc.de e.V. In-Reply-To: X-Newsgroups: gnu.emacs.bug User-Agent: tin/2.3.1-20141224 ("Tallant") (UNIX) (FreeBSD/10.1-RELEASE-p16 (amd64)) X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 20241-done Cc: Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) In article you wrote: > See for example: `(setq mark-active)' in `compilation-goto-locus' > (compile.el). > setq' should not be called with only one argument. It "works", with the > effect of assigning a value of nil, but it is poor form. Typically this > is a sign of a typo. Fixed in emacs-25. The interpreter now signals a wrong-number-of-args error, and the byte compiler issues a warning. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 23 13:45:15 2015 Received: (at 20241) by debbugs.gnu.org; 23 Nov 2015 18:45:15 +0000 Received: from localhost ([127.0.0.1]:49837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0w71-00023I-4F for submit@debbugs.gnu.org; Mon, 23 Nov 2015 13:45:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59970) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0w6g-0001qY-91 for 20241@debbugs.gnu.org; Mon, 23 Nov 2015 13:45:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0w6f-0000Sb-EC for 20241@debbugs.gnu.org; Mon, 23 Nov 2015 13:44:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0w6f-0000SX-Aw; Mon, 23 Nov 2015 13:44:53 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1a0w6d-0002ge-QC; Mon, 23 Nov 2015 13:44:51 -0500 From: Glenn Morris To: 20241@debbugs.gnu.org Subject: Re: bug#20241: 25.0.50; `setq' with only one argument References: <16400d25-dff1-4bfb-b929-814714f9e20f@default> <20151123143112.83911.qmail@mail.muc.de> X-Spook: ammunition Basque Separatists Mexicles Extreme weather X-Ran: [=\~G6!/H+^$U`jJSyBk[X.ZJ{ (Alan Mackenzie's message of "23 Nov 2015 14:31:12 -0000") Message-ID: <62twoc5zdo.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: 20241 Cc: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.6 (-----) Alan Mackenzie wrote: >> setq' should not be called with only one argument. It "works", with the >> effect of assigning a value of nil, but it is poor form. Typically this >> is a sign of a typo. > > Fixed in emacs-25. The interpreter now signals a wrong-number-of-args > error, and the byte compiler issues a warning. What on earth is this incompatible change doing in a feature-frozen release branch? Also, the combination of a compiler _warning_ and a run-time _error_ makes no sense. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 23 13:54:26 2015 Received: (at 20241) by debbugs.gnu.org; 23 Nov 2015 18:54:26 +0000 Received: from localhost ([127.0.0.1]:49845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0wFt-0003lH-O5 for submit@debbugs.gnu.org; Mon, 23 Nov 2015 13:54:26 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34377) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0wFs-0003l9-Dq for 20241@debbugs.gnu.org; Mon, 23 Nov 2015 13:54:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0wFq-0002DG-U1 for 20241@debbugs.gnu.org; Mon, 23 Nov 2015 13:54:23 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0wFq-0002DC-Ql; Mon, 23 Nov 2015 13:54:22 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1a0wFq-0003fH-DJ; Mon, 23 Nov 2015 13:54:22 -0500 From: Glenn Morris To: 20241@debbugs.gnu.org Subject: Re: bug#20241: 25.0.50; `setq' with only one argument References: <16400d25-dff1-4bfb-b929-814714f9e20f@default> <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> X-Spook: virus Critical Infrastructure & Key Resources Firefly X-Ran: `mImL:&ARBNKS)L|*dnN:@a"e}}CD?U_~(^~*&y1fzp (Glenn Morris's message of "Mon, 23 Nov 2015 13:44:51 -0500") Message-ID: <5lh9o5yxt.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: 20241 Cc: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.6 (-----) >> Fixed in emacs-25. The interpreter now signals a wrong-number-of-args >> error, and the byte compiler issues a warning. > > What on earth is this incompatible change doing in a feature-frozen > release branch? Surely the sensible way to do this is just start with the compilation warning for now. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 23 14:29:38 2015 Received: (at 20241) by debbugs.gnu.org; 23 Nov 2015 19:29:38 +0000 Received: from localhost ([127.0.0.1]:49869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0wnx-0004pX-PY for submit@debbugs.gnu.org; Mon, 23 Nov 2015 14:29:38 -0500 Received: from mail.muc.de ([193.149.48.3]:24665) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0wnv-0004pD-O5 for 20241@debbugs.gnu.org; Mon, 23 Nov 2015 14:29:36 -0500 Received: (qmail 55960 invoked by uid 3782); 23 Nov 2015 19:29:34 -0000 Received: from acm.muc.de (p579E89A6.dip0.t-ipconnect.de [87.158.137.166]) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 23 Nov 2015 20:29:34 +0100 Received: (qmail 10325 invoked by uid 1000); 23 Nov 2015 19:31:38 -0000 Date: Mon, 23 Nov 2015 19:31:38 +0000 To: Glenn Morris Subject: Re: bug#20241: 25.0.50; `setq' with only one argument Message-ID: <20151123193138.GG2004@acm.fritz.box> References: <16400d25-dff1-4bfb-b929-814714f9e20f@default> <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62twoc5zdo.fsf@fencepost.gnu.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 20241 Cc: 20241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hello, Glenn. On Mon, Nov 23, 2015 at 01:44:51PM -0500, Glenn Morris wrote: > Alan Mackenzie wrote: > >> setq' should not be called with only one argument. It "works", with the > >> effect of assigning a value of nil, but it is poor form. Typically this > >> is a sign of a typo. > > > > Fixed in emacs-25. The interpreter now signals a wrong-number-of-args > > error, and the byte compiler issues a warning. > What on earth is this incompatible change doing in a feature-frozen > release branch? It's a bug fix. > Also, the combination of a compiler _warning_ and a run-time _error_ > makes no sense. Maybe, maybe not. It's not the byte compiler's habit to signal errors: it only does so in most exceptional circumstances. Possibly the thinking is that it's best to produce a .elc anyway, which can be inspected, rather than just to error out. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 23 17:17:50 2015 Received: (at 20241) by debbugs.gnu.org; 23 Nov 2015 22:17:50 +0000 Received: from localhost ([127.0.0.1]:49997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0zQj-0003CX-W8 for submit@debbugs.gnu.org; Mon, 23 Nov 2015 17:17:50 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:34570) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0zQP-0003BF-ET for 20241@debbugs.gnu.org; Mon, 23 Nov 2015 17:17:48 -0500 Received: by padhx2 with SMTP id hx2so204184777pad.1 for <20241@debbugs.gnu.org>; Mon, 23 Nov 2015 14:17:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mime-version:content-type; bh=vgSPglGwYyPhyr20Z5GM0gc+KCbyMS0enrd6EpDjl1A=; b=oUynZTQeXNX7LDalWHbkunfY+f9M6tV0MJ6dzhhLh8GomqUUMjQmpsJcCbUI4iaJSf eg3oV/BaXN4K4jdtQ7wEmSs7imahMp+wCs+/d5MS0ONUJN5RfxaEIe4+KTFlBuo+HEK7 Ai/LBayByoRBh+7GBB0yUrxvx/rNhNXjShS+dc8LZdavgXB+8AHxkdyfZhpyLT+m3u4T T37VqiWivxNnPBpcDlGHz++YvwUcden23W4X1/I3FynRrKHj/c991tAFideApS6E/pNg 8txi3K7cVFXR1H4JxVCvj6vJ7SL3e68STdChOBPFFKHU0PlCCwA3vIrGUpt6+hI8hkZc H5ZQ== X-Received: by 10.66.141.103 with SMTP id rn7mr37670566pab.126.1448317048782; Mon, 23 Nov 2015 14:17:28 -0800 (PST) Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id fn4sm11691834pab.46.2015.11.23.14.17.26 (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 23 Nov 2015 14:17:26 -0800 (PST) From: John Wiegley X-Google-Original-From: "John Wiegley" Received: by Vulcan.local (Postfix, from userid 501) id DC26F10ABDF34; Mon, 23 Nov 2015 14:17:25 -0800 (PST) To: Glenn Morris Subject: Re: bug#20241: 25.0.50; `setq' with only one argument In-Reply-To: <5lh9o5yxt.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 23 Nov 2015 13:54:22 -0500") Date: Mon, 23 Nov 2015 14:05:16 -0800 Message-ID: References: <16400d25-dff1-4bfb-b929-814714f9e20f@default> <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> <5lh9o5yxt.fsf@fencepost.gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20241 Cc: acm@muc.de, 20241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >>>>> Glenn Morris writes: > Surely the sensible way to do this is just start with the compilation > warning for now. I'm ready for it to be an error, Glenn. It should happen sometime, 25.1 is a major release, and so it is a better time to do it than 25.2. John From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 24 06:30:47 2015 Received: (at 20241) by debbugs.gnu.org; 24 Nov 2015 11:30:47 +0000 Received: from localhost ([127.0.0.1]:50334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1Bo6-0000zQ-87 for submit@debbugs.gnu.org; Tue, 24 Nov 2015 06:30:46 -0500 Received: from mail.muc.de ([193.149.48.3]:40257) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1Bni-0000yu-8v for 20241@debbugs.gnu.org; Tue, 24 Nov 2015 06:30:41 -0500 Received: (qmail 2171 invoked by uid 3782); 24 Nov 2015 11:30:20 -0000 Received: from acm.muc.de (p5B146A6A.dip0.t-ipconnect.de [91.20.106.106]) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 24 Nov 2015 12:30:20 +0100 Received: (qmail 2049 invoked by uid 1000); 24 Nov 2015 11:32:24 -0000 Date: Tue, 24 Nov 2015 11:32:24 +0000 To: Glenn Morris Subject: Re: bug#20241: 25.0.50; `setq' with only one argument Message-ID: <20151124113224.GA2031@acm.fritz.box> References: <16400d25-dff1-4bfb-b929-814714f9e20f@default> <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> <20151123193138.GG2004@acm.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151123193138.GG2004@acm.fritz.box> User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 20241 Cc: 20241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hello, Glenn. On Mon, Nov 23, 2015 at 07:31:38PM +0000, Alan Mackenzie wrote: > On Mon, Nov 23, 2015 at 01:44:51PM -0500, Glenn Morris wrote: > > Alan Mackenzie wrote: > > >> setq' should not be called with only one argument. It "works", with the > > >> effect of assigning a value of nil, but it is poor form. Typically this > > >> is a sign of a typo. > > > > > > Fixed in emacs-25. The interpreter now signals a wrong-number-of-args > > > error, and the byte compiler issues a warning. > > What on earth is this incompatible change doing in a feature-frozen > > release branch? > It's a bug fix. > > Also, the combination of a compiler _warning_ and a run-time _error_ > > makes no sense. > Maybe, maybe not. It's not the byte compiler's habit to signal errors: > it only does so in most exceptional circumstances. Possibly the > thinking is that it's best to produce a .elc anyway, which can be > inspected, rather than just to error out. Apologies for the above: the byte compiler does indeed routinely signal errors as errors. I will change this "odd number of arguments" warning into an error. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 24 12:38:23 2015 Received: (at 20241) by debbugs.gnu.org; 24 Nov 2015 17:38:23 +0000 Received: from localhost ([127.0.0.1]:51605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1HXr-0003PB-Ey for submit@debbugs.gnu.org; Tue, 24 Nov 2015 12:38:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34754) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1HXq-0003P2-28 for 20241@debbugs.gnu.org; Tue, 24 Nov 2015 12:38:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1HXp-0006ZN-B8 for 20241@debbugs.gnu.org; Tue, 24 Nov 2015 12:38:21 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33681) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1HXm-0006WS-RM; Tue, 24 Nov 2015 12:38:18 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1a1HXm-0006V2-AJ; Tue, 24 Nov 2015 12:38:18 -0500 From: Glenn Morris To: Alan Mackenzie Subject: Re: bug#20241: 25.0.50; `setq' with only one argument References: <16400d25-dff1-4bfb-b929-814714f9e20f@default> <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> <20151123193138.GG2004@acm.fritz.box> X-Spook: Tremor Gangs Tony Blair smuggle Axis of Evil Weapons X-Ran: sjqI<@lUxze>3]]FutbC%"a3qUou,Q=:Yx$o`$ZA6.tJes2.`YjeimxI[b8MXUvd!}Z21h X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 24 Nov 2015 12:38:18 -0500 In-Reply-To: <20151123193138.GG2004@acm.fritz.box> (Alan Mackenzie's message of "Mon, 23 Nov 2015 19:31:38 +0000") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: 20241 Cc: 20241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.6 (-----) I'm assuming that any uses of this form were intentional (or even if not intentional, were doing the right thing), rather than errors. (I have no actual data - do you?) So making such code stop working overnight seems too harsh to me. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 24 13:03:11 2015 Received: (at 20241) by debbugs.gnu.org; 24 Nov 2015 18:03:11 +0000 Received: from localhost ([127.0.0.1]:51627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1Hvr-0004DU-Gr for submit@debbugs.gnu.org; Tue, 24 Nov 2015 13:03:11 -0500 Received: from mail.muc.de ([193.149.48.3]:30782) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1HvX-0004Ci-37 for 20241@debbugs.gnu.org; Tue, 24 Nov 2015 13:03:10 -0500 Received: (qmail 4632 invoked by uid 3782); 24 Nov 2015 18:02:48 -0000 Received: from acm.muc.de (p5B146A6A.dip0.t-ipconnect.de [91.20.106.106]) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 24 Nov 2015 19:02:47 +0100 Received: (qmail 18821 invoked by uid 1000); 24 Nov 2015 18:04:52 -0000 Date: Tue, 24 Nov 2015 18:04:52 +0000 To: Glenn Morris Subject: Re: bug#20241: 25.0.50; `setq' with only one argument Message-ID: <20151124180452.GB1840@acm.fritz.box> References: <16400d25-dff1-4bfb-b929-814714f9e20f@default> <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> <20151123193138.GG2004@acm.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 20241 Cc: 20241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hello, Glenn. On Tue, Nov 24, 2015 at 12:38:18PM -0500, Glenn Morris wrote: > I'm assuming that any uses of this form were intentional (or even if > not intentional, were doing the right thing), rather than errors. That wasn't the case. There were 5 deliberate uses of `setq' without the nil, there was one error in bytecomp.el, which had the effect of suppressing warnings given out by the byte compiler. > (I have no actual data - do you?) So making such code stop working > overnight seems too harsh to me. I have data, yes, see above. The point is, that error in bytecomp.el could have been anywhere, causing random breakage. I only noticed it by accident. I don't think the value of allowing an implicit, but undocumented, nil at the end of a `setq' outweighs the danger of accidentally setting a variable to nil. There were, after all, only five uses of this "feature" in the entire Emacs code base. And one of these was in .../obsolete. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 24 14:26:39 2015 Received: (at 20241) by debbugs.gnu.org; 24 Nov 2015 19:26:39 +0000 Received: from localhost ([127.0.0.1]:51649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1JEc-0006fa-Nl for submit@debbugs.gnu.org; Tue, 24 Nov 2015 14:26:39 -0500 Received: from mail-lf0-f44.google.com ([209.85.215.44]:35066) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1JEH-0006et-Ko for 20241@debbugs.gnu.org; Tue, 24 Nov 2015 14:26:36 -0500 Received: by lfdl133 with SMTP id l133so33925255lfd.2 for <20241@debbugs.gnu.org>; Tue, 24 Nov 2015 11:26:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=YBTJ2lb/swro7LqUqaVIKKI7SewTNJpAA/Qq2j681Xk=; b=k34xiAYeg3xt4o0bzh8vz49++V66KfUmkRhx8YkNwGGrlSXSVITF7S8ujEcf78ewNK UM2176cmrnNRgf77A1HVH/wINkEaujLnpyy16HxMY3rcEcfRJstz+7qPwF0oj8bSNPg3 GjbD8E2V/HvXgA+TbBrT8A7U6oJhR6TdwALz9DBi5avnGh4XXnlOllv0s8zKYeYgti/F JVFB+ACjhZveySGgwSeHqGYVRk5uSyPG4DPbPblDE0md/hVGRBtyLuA85gANbfGDHeOg mcp8kmmfLI0qr68dOmYNuzRxP5PeJcHwIkpjUqsHZZvFYNXSfeOM7RtkbU78HKx0IkZH G69g== MIME-Version: 1.0 X-Received: by 10.25.19.69 with SMTP id j66mr14198131lfi.25.1448393176691; Tue, 24 Nov 2015 11:26:16 -0800 (PST) Received: by 10.112.202.99 with HTTP; Tue, 24 Nov 2015 11:26:16 -0800 (PST) Received: by 10.112.202.99 with HTTP; Tue, 24 Nov 2015 11:26:16 -0800 (PST) In-Reply-To: <20151124180452.GB1840@acm.fritz.box> References: <16400d25-dff1-4bfb-b929-814714f9e20f@default> <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> <20151123193138.GG2004@acm.fritz.box> <20151124180452.GB1840@acm.fritz.box> Date: Tue, 24 Nov 2015 19:26:16 +0000 X-Google-Sender-Auth: nSYr-hx1zeFyLie-TfzZ-5Nd33w Message-ID: Subject: Re: bug#20241: 25.0.50; `setq' with only one argument From: Artur Malabarba To: Alan Mackenzie Content-Type: multipart/alternative; boundary=001a114069d4cabcc705254e5006 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20241 Cc: Glenn Morris , 20241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: bruce.connor.am@gmail.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a114069d4cabcc705254e5006 Content-Type: text/plain; charset=UTF-8 On 24 Nov 2015 6:04 pm, "Alan Mackenzie" wrote: > There were, after all, only five uses of this > "feature" in the entire Emacs code base. And one of these was in > .../obsolete. A few months ago Stefan changed save-excursion to no longer restore the mark. IIRC (though I may be forgetting), there were zero uses of this in the codebase, and he even asked about it on the list and nobody said "I use this". Still, after the change was applied, some issues came up on a couple of highly used packages out there, and my guess is that more will come up once 25 is released. I'm not speaking against that change. It was a good change because it fixed more problems than it created. And the same is true here. This change will be good. However, if there are 5 uses of it in the core, then it's likely there are 30 or 100 uses of it in the wild. This change _will_ break things. So it is my opinion that it should go in the master branch. The feature freeze exists for a reason. The emacs 25 branch should only get the warning, instead. A warning really goes a long way, and it doesn't break anything. --001a114069d4cabcc705254e5006 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 24 Nov 2015 6:04 pm, "Alan Mackenzie" <acm@muc.de> wrote:
> There were, after all, only five uses of this
> "feature" in the entire Emacs code base.=C2=A0 And one of th= ese was in
> .../obsolete.

A few months ago Stefan changed save-excursion to no longer = restore the mark. IIRC (though I may be forgetting), there were zero uses o= f this in the codebase, and he even asked about it on the list and nobody s= aid "I use this".
Still, after the change was applied, some issues came up on a couple of hig= hly used packages out there, and my guess is that more will come up once 25= is released.

I'm not speaking against that change. It was a good chan= ge because it fixed more problems than it created. And the same is true her= e. This change will be good.

However, if there are 5 uses of it in the core, then it'= s likely there are 30 or 100 uses of it in the wild. This change _will_ bre= ak things. So it is my opinion that it should go in the master branch. The = feature freeze exists for a reason.

The emacs 25 branch should only get the warning, instead. A = warning really goes a long way, and it doesn't break anything.

--001a114069d4cabcc705254e5006-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 24 16:08:15 2015 Received: (at 20241) by debbugs.gnu.org; 24 Nov 2015 21:08:15 +0000 Received: from localhost ([127.0.0.1]:51695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1Kox-00015V-A9 for submit@debbugs.gnu.org; Tue, 24 Nov 2015 16:08:15 -0500 Received: from mail.muc.de ([193.149.48.3]:11286) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1Koc-00014n-8g for 20241@debbugs.gnu.org; Tue, 24 Nov 2015 16:08:13 -0500 Received: (qmail 49891 invoked by uid 3782); 24 Nov 2015 21:07:52 -0000 Received: from acm.muc.de (p5B146A6A.dip0.t-ipconnect.de [91.20.106.106]) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 24 Nov 2015 22:07:51 +0100 Received: (qmail 2604 invoked by uid 1000); 24 Nov 2015 21:09:56 -0000 Date: Tue, 24 Nov 2015 21:09:56 +0000 To: Artur Malabarba Subject: Re: bug#20241: 25.0.50; `setq' with only one argument Message-ID: <20151124210956.GC1840@acm.fritz.box> References: <16400d25-dff1-4bfb-b929-814714f9e20f@default> <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> <20151123193138.GG2004@acm.fritz.box> <20151124180452.GB1840@acm.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 20241 Cc: Glenn Morris , 20241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hello, Artur. On Tue, Nov 24, 2015 at 07:26:16PM +0000, Artur Malabarba wrote: > On 24 Nov 2015 6:04 pm, "Alan Mackenzie" wrote: > > There were, after all, only five uses of this > > "feature" in the entire Emacs code base. And one of these was in > > .../obsolete. > A few months ago Stefan changed save-excursion to no longer restore the > mark. IIRC (though I may be forgetting), there were zero uses of this in > the codebase, and he even asked about it on the list and nobody said "I use > this". > Still, after the change was applied, some issues came up on a couple of > highly used packages out there, and my guess is that more will come up once > 25 is released. > I'm not speaking against that change. It was a good change because it fixed > more problems than it created. And the same is true here. This change will > be good. > However, if there are 5 uses of it in the core, then it's likely there are > 30 or 100 uses of it in the wild. This change _will_ break things. So it is > my opinion that it should go in the master branch. The feature freeze > exists for a reason. This is a bug fix. One might debate whether or not allowing implicit nils in setq is a bug or not. But the consequence was that our byte compiler was broken. Maybe not badly broken, but broken nonetheless. On finding a bug, I always try to fix not just the bug itself, but the cause of the bug. It seems clear to me that the ultimate cause of the broken byte compiler was the lack of a check on `setq'. > The emacs 25 branch should only get the warning, instead. A warning really > goes a long way, and it doesn't break anything. A warning does indeed go a long way. However, the breakage which will happen out in the field is not serious. A small number of .el files will fail to compile, and will do so with a clear error message. I suspect a larger number of bugs will be revealed than working code broken. I favour leaving the situation as it is. However, it is for John to decide. If he comes round to the view that an error is too strong, I am willing to turn it back into a warning. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 24 20:46:40 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 01:46:40 +0000 Received: from localhost ([127.0.0.1]:51906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1PAN-0008Rg-O2 for submit@debbugs.gnu.org; Tue, 24 Nov 2015 20:46:40 -0500 Received: from mail-vk0-f53.google.com ([209.85.213.53]:35535) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1PAL-0008RY-NZ for 20241@debbugs.gnu.org; Tue, 24 Nov 2015 20:46:38 -0500 Received: by vkha189 with SMTP id a189so25252307vkh.2 for <20241@debbugs.gnu.org>; Tue, 24 Nov 2015 17:46:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mime-version:content-type; bh=xh+QAKcM+kkrytKWg2NTY4kCXLepsCC1d5xgZRbgB8Q=; b=MZYaBRUaqTcZTSydnhfGjDuO8vaQH8LkSEGt9OtnvjYtuqTsnxBlm3Q3guqIyAYtf5 pxyhUV88HVIdlB8t0YyE4Y4i0FrFN6ubaSgYmxKdhYxkz+SEflEj/tyktrb8mfv2ozxF I6WCClgyadPKfiL5c0EBJ9wscfsNkPEgzezGo9uicLsCAE2arJ30E/g9SUojjV/sn52b 0peR9qYzy9oCFelkLnd0DzdpahN5YWA3cO6lTmcF8+6Q3tnA0ZFys/+ecpGWB1aHZGFU sKNJWQParBPL2GXsWtY/au7Xth8Ke6M7VLww1NQkmN9flBE7OGui9DLN69rRn3G6/C3d UDgw== X-Received: by 10.31.9.6 with SMTP id 6mr30186281vkj.25.1448415997210; Tue, 24 Nov 2015 17:46:37 -0800 (PST) Received: from Hermes-2.local (mail.johnwiegley.com. [208.82.103.192]) by smtp.gmail.com with ESMTPSA id 207sm16866498vkc.23.2015.11.24.17.46.36 (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 24 Nov 2015 17:46:36 -0800 (PST) From: John Wiegley X-Google-Original-From: "John Wiegley" Received: by Hermes-2.local (Postfix, from userid 501) id 2079A49CF90F; Tue, 24 Nov 2015 17:46:34 -0800 (PST) To: Alan Mackenzie Subject: Re: bug#20241: 25.0.50; `setq' with only one argument In-Reply-To: <20151124210956.GC1840@acm.fritz.box> (Alan Mackenzie's message of "Tue, 24 Nov 2015 21:09:56 +0000") Date: Tue, 24 Nov 2015 17:46:23 -0800 Message-ID: References: <16400d25-dff1-4bfb-b929-814714f9e20f@default> <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> <20151123193138.GG2004@acm.fritz.box> <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20241 Cc: 20241@debbugs.gnu.org, Artur Malabarba X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >>>>> Alan Mackenzie writes: > I favour leaving the situation as it is. However, it is for John to decide. > If he comes round to the view that an error is too strong, I am willing to > turn it back into a warning. I would like it to appear in 25.1. I'm willing to err against caution this time. It would be stranger to me to have it go from a warning to an error within 25.x, which then means waiting until 26 for it to be an error. Now that it's in the release branch, how about we try out some large packages and see if it's actually a problem? Since I can't imagine anyone intentionally using this just to save themselves from typing "nil", I'd expect people would want to know that their setq is ill-formed. It might indicate a real problem. John From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 04:40:16 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 09:40:16 +0000 Received: from localhost ([127.0.0.1]:52065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1WYi-0004tM-D6 for submit@debbugs.gnu.org; Wed, 25 Nov 2015 04:40:16 -0500 Received: from mail.muc.de ([193.149.48.3]:31221) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1WYO-0004s9-UD for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 04:40:15 -0500 Received: (qmail 72617 invoked by uid 3782); 25 Nov 2015 09:39:51 -0000 Received: from acm.muc.de (p5B146B74.dip0.t-ipconnect.de [91.20.107.116]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 25 Nov 2015 10:39:50 +0100 Received: (qmail 2121 invoked by uid 1000); 25 Nov 2015 09:41:55 -0000 Date: Wed, 25 Nov 2015 09:41:55 +0000 To: John Wiegley Subject: Re: bug#20241: 25.0.50; `setq' with only one argument Message-ID: <20151125094155.GB2007@acm.fritz.box> References: <16400d25-dff1-4bfb-b929-814714f9e20f@default> <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> <20151123193138.GG2004@acm.fritz.box> <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 20241 Cc: 20241@debbugs.gnu.org, Artur Malabarba X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hello, John. On Tue, Nov 24, 2015 at 05:46:23PM -0800, John Wiegley wrote: > >>>>> Alan Mackenzie writes: > > I favour leaving the situation as it is. However, it is for John to decide. > > If he comes round to the view that an error is too strong, I am willing to > > turn it back into a warning. > I would like it to appear in 25.1. I'm willing to err against caution this > time. It would be stranger to me to have it go from a warning to an error > within 25.x, which then means waiting until 26 for it to be an error. > Now that it's in the release branch, how about we try out some large packages > and see if it's actually a problem? We won't see any problem in our own sources, because all the occurrences here have been expunged. Any problems will be with external libraries (or possibly in *ELPA) which people expect just to download, compile and run. I think that was what Artur is worried about. > Since I can't imagine anyone intentionally using this just to save > themselves from typing "nil", I'd expect people would want to know > that their setq is ill-formed. It might indicate a real problem. Of the five non-error former occurrences, all were very old - the last one was touched by Stefan in 2005 (according to git blame). Some of them, possibly all of them, were indeed deliberate: there was a space left between the variable and the closing paren. Personally, I think there will be very few in external sources, and we are more likely to flag up real errors than break working code. > John -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 05:36:48 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 10:36:48 +0000 Received: from localhost ([127.0.0.1]:52082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1XRQ-0006Hl-2o for submit@debbugs.gnu.org; Wed, 25 Nov 2015 05:36:48 -0500 Received: from mail-lf0-f53.google.com ([209.85.215.53]:33401) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1XR5-0006HH-0U for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 05:36:45 -0500 Received: by lfaz4 with SMTP id z4so55104108lfa.0 for <20241@debbugs.gnu.org>; Wed, 25 Nov 2015 02:36:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=cNulREQMtfv7W4UsN5N2+wfsvqBcipVXn1Nkfq4MtcY=; b=QCXVQsYJ0jO74q/w3DNYO7zan0J5BNRYaWhXXQB6HrFSm45BGqfU19tKaV4at3GtZn sp3hIRMuuoGzFS1OYKN2wd666rKRrXU8AN8AcBqTSUvmXqX5DIrUTPX44Rk4LNalCYsi 7OJd95etc4Yq8nj/3aryQnLV8knCj+746pA9PUemH7k7x34qSzmRHamFt1D985LelQma jK8Tc0YeektKhTDaj6gXtF0zhg+6UFVcn1DkJGz+u4fABmXimnpgFAyv08ug1VXOu1Ru gB26jfRQAofIZt/EKLEQSbVoTGHqeUvzqDiRgF0toby+LlkmNDqFdQVQqpJS/VVoT+nV bbRw== MIME-Version: 1.0 X-Received: by 10.112.147.9 with SMTP id tg9mr3837443lbb.38.1448447785993; Wed, 25 Nov 2015 02:36:25 -0800 (PST) Received: by 10.112.202.99 with HTTP; Wed, 25 Nov 2015 02:36:25 -0800 (PST) In-Reply-To: <20151125094155.GB2007@acm.fritz.box> References: <16400d25-dff1-4bfb-b929-814714f9e20f@default> <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> <20151123193138.GG2004@acm.fritz.box> <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> Date: Wed, 25 Nov 2015 10:36:25 +0000 X-Google-Sender-Auth: sog5NtOj32-KZaZIpItYDRKT5P0 Message-ID: Subject: Re: bug#20241: 25.0.50; `setq' with only one argument From: Artur Malabarba To: Alan Mackenzie Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20241 Cc: John Wiegley , 20241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: bruce.connor.am@gmail.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > We won't see any problem in our own sources, because all the occurrences > here have been expunged. Any problems will be with external libraries > (or possibly in *ELPA) which people expect just to download, compile and > run. I think that was what Artur is worried about. Since we're going with this, I quickly grepped 4 occurrences on elpa/packages (didn't try the external branches). We should probably fix those too: ./hydra/hydra-test.el:1312: (setq current-prefix-arg) ./tiny/tiny.el:364: (setq expect-fun) ./gnorb/gnorb-registry.el:294: (setq id ) ./context-coloring/benchmark/fixtures/subr.el:1448: ,@(mapcar (lambda (binder) `(setq ,@binder)) binders) From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 06:06:12 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 11:06:13 +0000 Received: from localhost ([127.0.0.1]:52094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1Xts-000735-J6 for submit@debbugs.gnu.org; Wed, 25 Nov 2015 06:06:12 -0500 Received: from mail.muc.de ([193.149.48.3]:33677) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1XtY-00072I-Qc for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 06:06:11 -0500 Received: (qmail 93500 invoked by uid 3782); 25 Nov 2015 11:05:51 -0000 Received: from acm.muc.de (p5B146B74.dip0.t-ipconnect.de [91.20.107.116]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 25 Nov 2015 12:05:50 +0100 Received: (qmail 2869 invoked by uid 1000); 25 Nov 2015 11:07:55 -0000 Date: Wed, 25 Nov 2015 11:07:55 +0000 To: Artur Malabarba Subject: Re: bug#20241: 25.0.50; `setq' with only one argument Message-ID: <20151125110755.GC2007@acm.fritz.box> References: <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> <20151123193138.GG2004@acm.fritz.box> <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 20241 Cc: John Wiegley , 20241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hello, Artur. On Wed, Nov 25, 2015 at 10:36:25AM +0000, Artur Malabarba wrote: > > We won't see any problem in our own sources, because all the occurrences > > here have been expunged. Any problems will be with external libraries > > (or possibly in *ELPA) which people expect just to download, compile and > > run. I think that was what Artur is worried about. > Since we're going with this, I quickly grepped 4 occurrences on > elpa/packages (didn't try the external branches). We should probably > fix those too: > ./hydra/hydra-test.el:1312: (setq current-prefix-arg) > ./tiny/tiny.el:364: (setq expect-fun) > ./gnorb/gnorb-registry.el:294: (setq id ) > ./context-coloring/benchmark/fixtures/subr.el:1448: ,@(mapcar > (lambda (binder) `(setq ,@binder)) binders) Hmm. That's worrying. Isn't the code in ELPA newer code than in the core? If you found four occurrences merely by grepping, there could well be quite a few more. In the last one, for example, can we be sure that nil is intended, not that the real argument has just been missed out? Is there a way of building the entire repository in batch mode? I've not had anything to do with ELPA, as yet. Where do I find the address of its repository? Maybe having the byte compiler error out in this situation isn't such a brilliant idea after all. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 06:13:44 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 11:13:44 +0000 Received: from localhost ([127.0.0.1]:52112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1Y19-0007G6-Pu for submit@debbugs.gnu.org; Wed, 25 Nov 2015 06:13:43 -0500 Received: from mail-lf0-f51.google.com ([209.85.215.51]:33116) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1Y18-0007Fz-6U for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 06:13:42 -0500 Received: by lfaz4 with SMTP id z4so56197525lfa.0 for <20241@debbugs.gnu.org>; Wed, 25 Nov 2015 03:13:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=rICwo1uIGrqQo6o/szqWnxzDGvXI82n06m+pqxMvHv0=; b=kKyAa+Ic2YV8GlF2Yth2lvCjL4b6coz7Zcw2JPeel6H58/d6k7iIOgujKuuNEa6oqY +JyD+fiKJdyhysODMLjrLnGrrtPMeXs+Ab47zX0v1nVCNzGNmlUntSyZWtnPmnq7AGkb yPtjhYOQvvfT9UQEp9r2Li2lR9I4VAqTZ/J/FvGKVgqE72AcuroCVSrJKFtVtB9686ur ypuN5sGdyel0D/QDgCXu6iUIDhNSuCHE5tul96JVVu+whByy7lI3vgB+FjkvzBsl3ACZ drXLfCYZ/mEpU0qrUOdKb2baw/qraEWVLi4JKSdkwAyh2sZ0CFKXx/R3WzsGom1u7H0C u2ew== MIME-Version: 1.0 X-Received: by 10.25.19.69 with SMTP id j66mr15501015lfi.25.1448450021484; Wed, 25 Nov 2015 03:13:41 -0800 (PST) Received: by 10.112.202.99 with HTTP; Wed, 25 Nov 2015 03:13:41 -0800 (PST) In-Reply-To: <20151125110755.GC2007@acm.fritz.box> References: <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> <20151123193138.GG2004@acm.fritz.box> <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> <20151125110755.GC2007@acm.fritz.box> Date: Wed, 25 Nov 2015 11:13:41 +0000 X-Google-Sender-Auth: D2TRf1XfF2DdmR7fZAbHFdKP1Bw Message-ID: Subject: Re: bug#20241: 25.0.50; `setq' with only one argument From: Artur Malabarba To: Alan Mackenzie Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20241 Cc: John Wiegley , 20241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: bruce.connor.am@gmail.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) (I'll try to address your other comments later) > Is there a way of building the entire repository in batch mode? I think the readme explains how to do that. There's a make command for it that I can't recall right now. > Where do I find the address > of its repository? SAVANNAH-USERNAME@git.sv.gnu.org:/srv/git/emacs/elpa.git From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 06:27:06 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 11:27:06 +0000 Received: from localhost ([127.0.0.1]:52131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1YE6-0007eB-Gl for submit@debbugs.gnu.org; Wed, 25 Nov 2015 06:27:06 -0500 Received: from mail.muc.de ([193.149.48.3]:24690) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1YDm-0007dH-DC for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 06:27:04 -0500 Received: (qmail 98404 invoked by uid 3782); 25 Nov 2015 11:26:45 -0000 Received: from acm.muc.de (p5B146B74.dip0.t-ipconnect.de [91.20.107.116]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 25 Nov 2015 12:26:44 +0100 Received: (qmail 3027 invoked by uid 1000); 25 Nov 2015 11:28:50 -0000 Date: Wed, 25 Nov 2015 11:28:49 +0000 To: Artur Malabarba Subject: Re: bug#20241: 25.0.50; `setq' with only one argument Message-ID: <20151125112849.GD2007@acm.fritz.box> References: <20151123193138.GG2004@acm.fritz.box> <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> <20151125110755.GC2007@acm.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 20241 Cc: John Wiegley , 20241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hello, Artur. On Wed, Nov 25, 2015 at 11:13:41AM +0000, Artur Malabarba wrote: > (I'll try to address your other comments later) No hurry! > > Is there a way of building the entire repository in batch mode? > I think the readme explains how to do that. There's a make command for > it that I can't recall right now. > > Where do I find the address > > of its repository? > SAVANNAH-USERNAME@git.sv.gnu.org:/srv/git/emacs/elpa.git Thanks, I've got it. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 10:18:42 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 15:18:42 +0000 Received: from localhost ([127.0.0.1]:52913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1bqE-0008UN-4N for submit@debbugs.gnu.org; Wed, 25 Nov 2015 10:18:42 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:40207) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1bpt-0008Ti-0Y for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 10:18:39 -0500 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id tAPFIIas007707 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 25 Nov 2015 15:18:19 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id tAPFIIUQ023903 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 25 Nov 2015 15:18:18 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id tAPFIIun008212; Wed, 25 Nov 2015 15:18:18 GMT MIME-Version: 1.0 Message-ID: Date: Wed, 25 Nov 2015 07:18:17 -0800 (PST) From: Drew Adams To: Alan Mackenzie , Artur Malabarba Subject: RE: bug#20241: 25.0.50; `setq' with only one argument References: <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> <20151123193138.GG2004@acm.fritz.box> <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> <20151125110755.GC2007@acm.fritz.box> In-Reply-To: <20151125110755.GC2007@acm.fritz.box> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 20241 Cc: John Wiegley , 20241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) > If you found four occurrences merely by grepping, there could well be > quite a few more. In the last one, for example, can we be sure that nil > is intended, not that the real argument has just been missed out? If you cannot now analyze the code properly to determine TRT, or contact the author to make that determination, then do the obvious (IMO): Assign a `nil' value explicitly where it is now assigned implicitly. AND flag that amended code with a comment saying what you've done, and that you don't currently know whether (a) there is a bug here or (b) `nil' is really what is needed. IOW: (1) At least just ensure that the code does the same thing that it does now, but respects the intended meaning of `setq'. (2) If you have to punt the careful analysis for later or for someone else, then add a comment to that effect. > Maybe having the byte compiler error out in this situation isn't such a > brilliant idea after all. IMO, the bug should be fixed to raise an _error at runtime_, for both interpreted and byte-compiled code. Whatever else the byte-compiler might do is less important, as long as it produces code that is comparable - e.g., code that will also raise an _error at runtime_. It's OK for a byte-compiler to be smart, but not smarter than the actual source code ;-). It should pretty much try to produce code that does the same thing, but hopefully usually does it quicker. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 10:38:49 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 15:38:49 +0000 Received: from localhost ([127.0.0.1]:52920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1c9h-0000Y7-0N for submit@debbugs.gnu.org; Wed, 25 Nov 2015 10:38:49 -0500 Received: from mail.muc.de ([193.149.48.3]:29886) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1c9L-0000Xb-R9 for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 10:38:46 -0500 Received: (qmail 73776 invoked by uid 3782); 25 Nov 2015 15:38:26 -0000 Received: from acm.muc.de (p5B146B74.dip0.t-ipconnect.de [91.20.107.116]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 25 Nov 2015 16:38:24 +0100 Received: (qmail 22275 invoked by uid 1000); 25 Nov 2015 15:40:30 -0000 Date: Wed, 25 Nov 2015 15:40:30 +0000 To: Drew Adams Subject: Re: bug#20241: 25.0.50; `setq' with only one argument Message-ID: <20151125154030.GF2007@acm.fritz.box> References: <20151123193138.GG2004@acm.fritz.box> <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> <20151125110755.GC2007@acm.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 20241 Cc: John Wiegley , 20241@debbugs.gnu.org, Artur Malabarba X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hello, Drew. On Wed, Nov 25, 2015 at 07:18:17AM -0800, Drew Adams wrote: > > If you found four occurrences merely by grepping, there could well be > > quite a few more. In the last one, for example, can we be sure that nil > > is intended, not that the real argument has just been missed out? > If you cannot now analyze the code properly to determine TRT, or > contact the author to make that determination, then do the obvious > (IMO): Assign a `nil' value explicitly where it is now assigned > implicitly. That would be the worst thing: it would leave the code possibly failing exactly the way it did, but remove the evidence (which can be mechanically found). > AND flag that amended code with a comment saying what you've done, > and that you don't currently know whether (a) there is a bug here > or (b) `nil' is really what is needed. Comments are less good than error messages from the byte compiler! > IOW: (1) At least just ensure that the code does the same thing > that it does now, but respects the intended meaning of `setq'. > (2) If you have to punt the careful analysis for later or for > someone else, then add a comment to that effect. > > Maybe having the byte compiler error out in this situation isn't such a > > brilliant idea after all. > IMO, the bug should be fixed to raise an _error at runtime_, for > both interpreted and byte-compiled code. I've just tried it out. The byte compiler generates an error message, but the .elc is written anyway. No runtime error happens from such compiled code. But running it interpreted would signal an error. > Whatever else the byte-compiler might do is less important, as > long as it produces code that is comparable - e.g., code that > will also raise an _error at runtime_. It currently doesn't do that. I'm not convinced it should, either. > It's OK for a byte-compiler to be smart, but not smarter than > the actual source code ;-). It should pretty much try to > produce code that does the same thing, but hopefully usually > does it quicker. Why is this topic suddenly seeming complicated? :-( -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 11:28:09 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 16:28:10 +0000 Received: from localhost ([127.0.0.1]:52958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1cvR-0001n2-27 for submit@debbugs.gnu.org; Wed, 25 Nov 2015 11:28:09 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:20705) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1cv6-0001mI-FT for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 11:28:07 -0500 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id tAPGRkVn013640 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 25 Nov 2015 16:27:46 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id tAPGRj9j025593 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 25 Nov 2015 16:27:45 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id tAPGRiiu006538; Wed, 25 Nov 2015 16:27:45 GMT MIME-Version: 1.0 Message-ID: Date: Wed, 25 Nov 2015 08:27:43 -0800 (PST) From: Drew Adams To: Alan Mackenzie Subject: RE: bug#20241: 25.0.50; `setq' with only one argument References: <20151123193138.GG2004@acm.fritz.box> <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> <20151125110755.GC2007@acm.fritz.box> <20151125154030.GF2007@acm.fritz.box> In-Reply-To: <20151125154030.GF2007@acm.fritz.box> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 20241 Cc: John Wiegley , 20241@debbugs.gnu.org, Artur Malabarba X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) > > If you cannot now analyze the code properly to determine TRT, or > > contact the author to make that determination, then do the obvious > > (IMO): Assign a `nil' value explicitly where it is now assigned > > implicitly. >=20 > That would be the worst thing: it would leave the code possibly failing > exactly the way it did, but remove the evidence (which can be > mechanically found). It would leave the code behaving exactly as it did before. AND it would add information to developers that there is possibly an error here - right here, in this sexp here. AND it would say clearly what that possible error is. That doesn't "remove the evidence". It puts a big sign around the evidence saying "**EVIDENCE** - Check this code to see whether it should really should assign a nil value. But if you can DTRT now - analyze the code sufficiently and fix it properly or contact the author for an opinion - then that's the thing to do. Or if you just leave the code as is, but ensure that a runtime error is raised, that is also TRT. It takes care of THIS bug, but it does not fix that bug (indicated by the error occurrence). That's fine. When the error is raised someone can then work on fixing that bug. They can take the time to analyze and fix it properly. And they can ensure, while they are working on it, that the code at least runs as it did before - by doing what I suggested above: explicitly assign `nil' and add a comment. =20 > > AND flag that amended code with a comment saying what you've done, > > and that you don't currently know whether (a) there is a bug here > > or (b) `nil' is really what is needed. >=20 > Comments are less good than error messages from the byte compiler! I disagree. Each can be helpful in its own way. In this case, we have already located the potential problem, and the (right) message to developers about it is that THERE IS an assignment of `nil' and IT MIGHT BE PROBLEMATIC. The source code is a good place to convey that message, right next to the suspect assignment. > > IOW: (1) At least just ensure that the code does the same thing > > that it does now, but respects the intended meaning of `setq'. > > (2) If you have to punt the careful analysis for later or for > > someone else, then add a comment to that effect. >=20 > > > Maybe having the byte compiler error out in this situation > > > isn't such a brilliant idea after all. >=20 > > IMO, the bug should be fixed to raise an _error at runtime_, > > for both interpreted and byte-compiled code. >=20 > I've just tried it out. The byte compiler generates an error message, > but the .elc is written anyway. No runtime error happens from such > compiled code. But running it interpreted would signal an error. And who will run it interpreted? THIS is worse than nothing, IMO. What counts is the runtime behavior. And that counts for both source code and byte-compiled code. > > Whatever else the byte-compiler might do is less important, as > > long as it produces code that is comparable - e.g., code that > > will also raise an _error at runtime_. >=20 > It currently doesn't do that. I'm not convinced it should, either. What would it take to convince you? What is the purpose of byte-compilation, in terms of the resulting code? Is it to change the behavior in ways other than optimization? I don't think so. The byte-compiler is not just some QA tool to check whether i's are dotted and t's are crossed. It produces _code_ that is _run_, and that runtime behavior should reflect the programmer's intention. And that intention is expressed in the source-code language (which can include declarations to a compiler, but that's beside the point here). > > It's OK for a byte-compiler to be smart, but not smarter than > > the actual source code ;-). It should pretty much try to > > produce code that does the same thing, but hopefully usually > > does it quicker. >=20 > Why is this topic suddenly seeming complicated? :-( I don't think it's complicated. `setq' should raise an error when it is passed an odd number of arguments. _That's all._ The error should be raised when `setq' is invoked, obviously. Anything else we might decide to do is extra communication to programmers _about_ the code. But the code itself should DTRT. Assigning `nil' for a missing value arg is not the right thing; raising an error is the right thing. If you want to leave the problematic code as is, but ensure that a runtime error is raised, that's fine. It is the right thing. But IF you decide to try to fix the problematic code now, and IF you feel you are unsure about the fix, THEN the best thing to do is to keep the behavior as it was (assign `nil'), but make that behavior explicit and question it with a comment. I would rather opt for just leaving the code as it is - erroneous, and let it raise a runtime error. But then we will be in the same boat for fixing that error: analyze or contact the author, etc. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 11:39:59 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 16:39:59 +0000 Received: from localhost ([127.0.0.1]:52964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1d6s-00025q-H9 for submit@debbugs.gnu.org; Wed, 25 Nov 2015 11:39:59 -0500 Received: from mxin.ulb.ac.be ([164.15.128.112]:11500) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1ZsV-0003bO-9j for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 08:12:55 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtEEAAuzVVakD4Xx/2dsb2JhbABegmmCFIJfvVaGDwKCDQEBAQEBAYELhDUBAQMBeRAIAw4TJQ8BBA08E4gZAwoIuQoNR4QlAQEBAQYCASCGVIR+glOGZgWSb4Noiz+LBot4h1ZjhAU9NAGFKwEBAQ Received: from mathsrv4.ulb.ac.be (HELO localhost) ([164.15.133.241]) by smtp.ulb.ac.be with ESMTP; 25 Nov 2015 14:11:21 +0100 From: Nicolas Richard To: Artur Malabarba Subject: Re: bug#20241: 25.0.50; `setq' with only one argument References: <16400d25-dff1-4bfb-b929-814714f9e20f@default> <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> <20151123193138.GG2004@acm.fritz.box> <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> Date: Wed, 25 Nov 2015 14:11:40 +0100 In-Reply-To: (Artur Malabarba's message of "Wed, 25 Nov 2015 10:36:25 +0000") Message-ID: <871tbecjg3.fsf@ulb.ac.be> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 20241 X-Mailman-Approved-At: Wed, 25 Nov 2015 11:39:57 -0500 Cc: Alan Mackenzie , 20241@debbugs.gnu.org, John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) Artur Malabarba writes: >> We won't see any problem in our own sources, because all the occurrences >> here have been expunged. Any problems will be with external libraries >> (or possibly in *ELPA) which people expect just to download, compile and >> run. I think that was what Artur is worried about. > > Since we're going with this, I quickly grepped 4 occurrences on > elpa/packages (didn't try the external branches). We should probably > fix those too: > > ./hydra/hydra-test.el:1312: (setq current-prefix-arg) > ./tiny/tiny.el:364: (setq expect-fun) > ./gnorb/gnorb-registry.el:294: (setq id ) > ./context-coloring/benchmark/fixtures/subr.el:1448: ,@(mapcar > (lambda (binder) `(setq ,@binder)) binders) I just looked at this one, and the docstring says : Each element of BINDERS is a list (SYMBOL VALUEFORM) which binds [...] so IIUC it is correct. -- Nico. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 12:20:29 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 17:20:30 +0000 Received: from localhost ([127.0.0.1]:53032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1dk5-0003AU-0w for submit@debbugs.gnu.org; Wed, 25 Nov 2015 12:20:29 -0500 Received: from mail.muc.de ([193.149.48.3]:45265) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1djk-0003A0-1x for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 12:20:27 -0500 Received: (qmail 2447 invoked by uid 3782); 25 Nov 2015 17:20:06 -0000 Received: from acm.muc.de (p5B146B74.dip0.t-ipconnect.de [91.20.107.116]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 25 Nov 2015 18:20:06 +0100 Received: (qmail 22679 invoked by uid 1000); 25 Nov 2015 17:22:12 -0000 Date: Wed, 25 Nov 2015 17:22:12 +0000 To: Drew Adams Subject: Re: bug#20241: 25.0.50; `setq' with only one argument Message-ID: <20151125172211.GH2007@acm.fritz.box> References: <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> <20151125110755.GC2007@acm.fritz.box> <20151125154030.GF2007@acm.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 20241 Cc: John Wiegley , 20241@debbugs.gnu.org, Artur Malabarba X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hello, Drew. On Wed, Nov 25, 2015 at 08:27:43AM -0800, Drew Adams wrote: [ .... ] > But if you can DTRT now - analyze the code sufficiently and fix > it properly or contact the author for an opinion - then that's > the thing to do. That's already been done with the Emacs core, and that's what I'd like to do with elpa. But code over which we have no control might be problematic. > Or if you just leave the code as is, but ensure that a runtime > error is raised, that is also TRT. It takes care of THIS bug, > but it does not fix that bug (indicated by the error occurrence). That would mean the users will suffer an error rather than the maintainers. And the Emacs team will get blamed for the breakage. [ .... ] > > > IMO, the bug should be fixed to raise an _error at runtime_, > > > for both interpreted and byte-compiled code. I think that a compiler generating a runtime error for a compile time problem isn't a good idea. [ .... ] > The byte-compiler is not just some QA tool to check whether i's > are dotted and t's are crossed. No, but that is a significant part of its job spec. [ .... ] > > Why is this topic suddenly seeming complicated? :-( > I don't think it's complicated. `setq' should raise an error > when it is passed an odd number of arguments. _That's all._ > The error should be raised when `setq' is invoked, obviously. There are several different behaviours possible in both the interpreter and compiler: 1. Interpreter: (a) Current behviour: silently insert a nil into the `setq'. (b) Throw an error (current new behaviour in emacs-25). (c) Issue a warning, but continue otherwise with (a). 2. Compiler: (a) Silently compile code which slips in a nil (current behaviour). (b) Issue a warning, but compile in the nil. (c) Issue an error, but compile in the nil. (current new behaviour in emacs-25.) (d) Issue an error, and abort the compilation: (i) immediately. (ii) at the end of the source file. (e) Issue an error, and generate code to: (i) issue a warning, but carry on with the nil. (ii) throw an error. You seem to favour 1(b) and, I think, 2(d)(ii) or 2(e)(ii). I favour 1(b) and probably 2(c), possibly 2(e)(i). To me, these possibilities are complicated. It's not a technical problem, it's a social problem: who's going to be notified of the problem and when. I would far rather maintainers were hassled than users. [ .... ] -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 13:28:20 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 18:28:20 +0000 Received: from localhost ([127.0.0.1]:53095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1enk-0004t9-0E for submit@debbugs.gnu.org; Wed, 25 Nov 2015 13:28:20 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:26719) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1eni-0004t0-1h for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 13:28:18 -0500 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id tAPISDJj010249 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 25 Nov 2015 18:28:13 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id tAPISCpE028328 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 25 Nov 2015 18:28:13 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id tAPISCT9010221; Wed, 25 Nov 2015 18:28:12 GMT MIME-Version: 1.0 Message-ID: <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> Date: Wed, 25 Nov 2015 10:28:11 -0800 (PST) From: Drew Adams To: Alan Mackenzie Subject: RE: bug#20241: 25.0.50; `setq' with only one argument References: <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> <20151125110755.GC2007@acm.fritz.box> <20151125154030.GF2007@acm.fritz.box> <20151125172211.GH2007@acm.fritz.box> In-Reply-To: <20151125172211.GH2007@acm.fritz.box> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 20241 Cc: John Wiegley , 20241@debbugs.gnu.org, Artur Malabarba X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) > 1. Interpreter: > (a) Current behviour: silently insert a nil into the `setq'. > (b) Throw an error (current new behaviour in emacs-25). > (c) Issue a warning, but continue otherwise with (a). 1b is what I prefer. > 2. Compiler: > (a) Silently compile code which slips in a nil (current behaviour). > (b) Issue a warning, but compile in the nil. > (c) Issue an error, but compile in the nil. (current new behaviour > in emacs-25.) > (d) Issue an error, and abort the compilation: > (i) immediately. > (ii) at the end of the source file. > (e) Issue an error, and generate code to: > (i) issue a warning, but carry on with the nil. > (ii) throw an error. Code that applies `setq' to an odd number of args is erroneous syntactically. The compiler can point out that syntax error. And it need not (and should not) abort the compilation just because it reports that syntax error - it can continue to report other problems. Or if by "abort" you mean just not produce compiled output (but continue to analyze the code and report as many problems as possible), I don't think that is necessary (or good) either, in this case (provided that the resulting code raises a runtime error.) > You seem to favour 1(b) and, I think, 2(d)(ii) or 2(e)(ii). > I favour 1(b) and probably 2(c), possibly 2(e)(i). My preference for the compiler is to (a) let you know there are syntax problems, and where they are, and (b) generate code that acts the same as the interpreted code: in this case, raise a runtime error. > To me, these possibilities are complicated. It's not a > technical problem, it's a social problem: who's going to be > notified of the problem and when. I would far rather > maintainers were hassled than users. As long as the code is erroneous, users should get an error from it. If you can fix the code then they won't get an error. If you cannot fix it now, then they should get an error. If it's important enough that they not get the error then it's important enough that the code should be fixed (e.g., before the release). Anyway, I'm no doubt repeating myself now. At least you know now what I prefer for the behavior, including for the compiler. FWIW. And thanks for working on this. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 14:06:36 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 19:06:36 +0000 Received: from localhost ([127.0.0.1]:53129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1fOl-0007XB-Vq for submit@debbugs.gnu.org; Wed, 25 Nov 2015 14:06:36 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:36055) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1fOk-0007X3-2A for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 14:06:34 -0500 Received: by pacdm15 with SMTP id dm15so65433794pac.3 for <20241@debbugs.gnu.org>; Wed, 25 Nov 2015 11:06:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mime-version:content-type; bh=kH6+buAvBspAsjuBHmNw2xdexcWz44wPuJdidDaYU80=; b=v7jZee8EdxIe7L/vDEJIdtvsSFNKwxu1zeNBEJwnUUoj6scAXukY2R4wgPafv/UiVK SeliOBK7Ww1hs23PN6DCzrnr5Hr+rd00KMaqK57rA+CVua+wmEZ3TY/jksf3z+4NFopX lqBP7syuy5jEdEUDpWebK5HoDNPNS6dLEPkH7GtKxoGU/4W/5dhHhMb+ZW+J6hyzxMAL s5xlzbE417WJ1xm8bHCtEJTA/yRBR9pvTqKiYEMFqoIcKuUZd4TEGCwmlNBbrdBa0YSL OsPQEejj2dq4Ugz2NimYAbJ/dKfyqpJBEL3FLw4X6reNfDgDZZ+QvLC7M62XxbjkR1DB qttQ== X-Received: by 10.66.251.226 with SMTP id zn2mr53932648pac.44.1448478393332; Wed, 25 Nov 2015 11:06:33 -0800 (PST) Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id t73sm22397647pfi.83.2015.11.25.11.06.32 (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 25 Nov 2015 11:06:32 -0800 (PST) From: John Wiegley X-Google-Original-From: "John Wiegley" Received: by Vulcan.local (Postfix, from userid 501) id 1253610AD43B2; Wed, 25 Nov 2015 11:06:32 -0800 (PST) To: Drew Adams Subject: Re: bug#20241: 25.0.50; `setq' with only one argument In-Reply-To: <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> (Drew Adams's message of "Wed, 25 Nov 2015 10:28:11 -0800 (PST)") Date: Wed, 25 Nov 2015 11:06:30 -0800 Message-ID: References: <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> <20151125110755.GC2007@acm.fritz.box> <20151125154030.GF2007@acm.fritz.box> <20151125172211.GH2007@acm.fritz.box> <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20241 Cc: Alan Mackenzie , 20241@debbugs.gnu.org, Artur Malabarba X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >>>>> Drew Adams writes: > My preference for the compiler is to (a) let you know there are syntax > problems, and where they are, and (b) generate code that acts the same as > the interpreted code: in this case, raise a runtime error. Let's take a different case as a behavorial example: The code: (funcall) Interpreted: Raises an error: eval: Wrong number of arguments: funcall, 0 Byte-compilation: No warnings or errors printed. Loading of .elc: Raises an error: load: Wrong number of arguments: funcall, 0 I think that we should be consistent in our behavior. Mis-using Emacs Lisp is not a reason to fail to byte-compile, even if it is a reason for it to fail to evaluate or load. A separate argument could be made that bad code shouldn't compile, but that's orthogonal to this discussion, and too big a pill to swallow for 25.1. John From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 14:22:37 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 19:22:37 +0000 Received: from localhost ([127.0.0.1]:53150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1feH-0007w9-C0 for submit@debbugs.gnu.org; Wed, 25 Nov 2015 14:22:37 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:20168) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1feE-0007w0-5g for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 14:22:35 -0500 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id tAPJMXsI017777 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 25 Nov 2015 19:22:33 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id tAPJMWrt026717 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 25 Nov 2015 19:22:32 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id tAPJMWS4001398; Wed, 25 Nov 2015 19:22:32 GMT MIME-Version: 1.0 Message-ID: <6802dd57-972f-4053-b044-597592a74ba3@default> Date: Wed, 25 Nov 2015 11:22:31 -0800 (PST) From: Drew Adams To: John Wiegley Subject: RE: bug#20241: 25.0.50; `setq' with only one argument References: <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> <20151125110755.GC2007@acm.fritz.box> <20151125154030.GF2007@acm.fritz.box> <20151125172211.GH2007@acm.fritz.box> <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 20241 Cc: Alan Mackenzie , 20241@debbugs.gnu.org, Artur Malabarba X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) > > My preference for the compiler is to (a) let you know there are syntax > > problems, and where they are, and (b) generate code that acts the same > > as the interpreted code: in this case, raise a runtime error. >=20 > Let's take a different case as a behavorial example: The code: (funcall) > Interpreted: Raises an error: eval: Wrong number of arguments: > funcall, 0 > Byte-compilation: No warnings or errors printed. > Loading of .elc: Raises an error: load: Wrong number of arguments: > funcall, 0 >=20 > I think that we should be consistent in our behavior. Mis-using Emacs Lis= p > is not a reason to fail to byte-compile, even if it is a reason for it to > fail to evaluate or load. >=20 > A separate argument could be made that bad code shouldn't compile, but > that's orthogonal to this discussion, and too big a pill to swallow for > 25.1. I think we are agreeing, unless I'm missing something (?). In the case of `funcall', which is a function, the byte-compiler could conceivably, in some cases, point out a syntax error that a missing FUNCTION arg is required for `funcall'. It could not point that out in all cases. For example: (apply #'funcall (some-sexp)), might end up applying `funcall' to (). But in many cases it could find syntax errors of this kind. `setq' is not a function (you cannot pass `setq' to `apply'), so it is generally easier to check its syntax. Whatever problems the byte-compiler finds and reports are welcome, but the mere fact of reporting problems does not obviate the need for runtime errors when incorrect syntax is used. And certainly byte-compilation should not try to "correct" code (any more than the interpreter should) by, for example, implicitly providing a nil arg for `setq'. That's just plain wrong, IMO. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 14:34:24 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 19:34:24 +0000 Received: from localhost ([127.0.0.1]:53158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1fpf-0008GZ-QQ for submit@debbugs.gnu.org; Wed, 25 Nov 2015 14:34:24 -0500 Received: from mail-lf0-f53.google.com ([209.85.215.53]:33926) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1fpL-0008G1-QD for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 14:34:22 -0500 Received: by lffu14 with SMTP id u14so73067549lff.1 for <20241@debbugs.gnu.org>; Wed, 25 Nov 2015 11:34:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=HqKt3tE2f/88hrVzFtlLNLdP7GfXS1CWdYON6YWarhA=; b=TAY/bAuew+dliiVXVyIJQY9AtjH/vVWGYVPXPq+Fjuxj2yCyPpwgU95qma6byrIO3A axK1/7PyzR581JrKol3d6VNOJrLCv2kvlG83BxgyB5LWFM4glbFJWBLEh6s3FQqAegvk y8ux3btsmFgTV+lE49kMvtkH2iqwvNqHe2td0RUT3znPdbKGx0L55hS6fHT7wAgnvASS /NuU4DsYJ+gDN1/GPGnVYD2nK9Vax5aQHmlsBesyqFFvB7rnkq8y87UA9bCIboeTDSFz W/AgxbgFeGo2qGen0D7rUtOGE0sAdaqStQrZCsK5IVHobToUXNkOr2FoESXjtI8kMD6B WpTw== MIME-Version: 1.0 X-Received: by 10.25.137.7 with SMTP id l7mr9527027lfd.63.1448480042960; Wed, 25 Nov 2015 11:34:02 -0800 (PST) Received: by 10.112.202.99 with HTTP; Wed, 25 Nov 2015 11:34:02 -0800 (PST) Received: by 10.112.202.99 with HTTP; Wed, 25 Nov 2015 11:34:02 -0800 (PST) In-Reply-To: References: <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> <20151125110755.GC2007@acm.fritz.box> <20151125154030.GF2007@acm.fritz.box> <20151125172211.GH2007@acm.fritz.box> <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> Date: Wed, 25 Nov 2015 19:34:02 +0000 X-Google-Sender-Auth: mbGd4_wZKoiqzCufy1DKeeSugKA Message-ID: Subject: Re: bug#20241: 25.0.50; `setq' with only one argument From: Artur Malabarba To: John Wiegley Content-Type: multipart/alternative; boundary=001a113fc2606ccf820525628a36 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20241 Cc: Alan Mackenzie , 20241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: bruce.connor.am@gmail.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a113fc2606ccf820525628a36 Content-Type: text/plain; charset=UTF-8 On 25 Nov 2015 7:06 pm, "John Wiegley" wrote: > > The code: (funcall) > > Interpreted: Raises an error: eval: Wrong number of arguments: funcall, 0 > > Byte-compilation: No warnings or errors printed. This is a bug then (probably in the advertised-calling-convention of funcall). Functions called with the wrong number of arguments are usually reported as warnings by the byte-compiler. --001a113fc2606ccf820525628a36 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 25 Nov 2015 7:06 pm, "John Wiegley" <jwiegley@gmail.com> wrote:
>
> =C2=A0 The code: (funcall)
>
> =C2=A0 Interpreted: Raises an error: eval: Wrong number of arguments: = funcall, 0
>
> =C2=A0 Byte-compilation: No warnings or errors printed.

This is a bug then (probably in the advertised-calling-conve= ntion of funcall). Functions called with the wrong number of arguments are = usually reported as warnings by the byte-compiler.

--001a113fc2606ccf820525628a36-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 14:40:23 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 19:40:23 +0000 Received: from localhost ([127.0.0.1]:53163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1fvS-0008Pl-Jy for submit@debbugs.gnu.org; Wed, 25 Nov 2015 14:40:23 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:33674) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1fvQ-0008Pd-Rv for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 14:40:21 -0500 Received: by pabfh17 with SMTP id fh17so68235435pab.0 for <20241@debbugs.gnu.org>; Wed, 25 Nov 2015 11:40:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mime-version:content-type; bh=uHNLaDKFMGW8d1Ut4jlhE0addecIfPzaJOB6qLfynsE=; b=x2lJJFfkQqemKFklDsyXqvfumCcaN1URrjHDh8aSy6BZiiyKNzdGUiFodpztaI+GkI STL1Grz7xfmPbj32Vd4vlzrW29fpkRcvCyXa912QY5xtLR3Dk2gGsZj36hYEx1e5FEg1 1X0li+rCGzD9uHoshs79MpIsdwprgW/yz7LXWdgVk9ODw6HK11E0gyIlIZIEAJopFh+F Osxo/BpoKGk5WKTH69DvcTLNI2wu+fd7X2uWtOK1yI8/Bs4lf4f/SUlcLX47F9e3ScSn lsoICTFftiu0slas/bCgqA17j0/d1lelO0BvPCf4AQFxs0425OB/uNUUyG1JCxXE6TxE Stgw== X-Received: by 10.66.155.197 with SMTP id vy5mr54201129pab.109.1448480419914; Wed, 25 Nov 2015 11:40:19 -0800 (PST) Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id ux3sm23038667pac.18.2015.11.25.11.40.18 (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 25 Nov 2015 11:40:18 -0800 (PST) From: John Wiegley X-Google-Original-From: "John Wiegley" Received: by Vulcan.local (Postfix, from userid 501) id C836510B00C8A; Wed, 25 Nov 2015 11:40:17 -0800 (PST) To: Artur Malabarba Subject: Re: bug#20241: 25.0.50; `setq' with only one argument In-Reply-To: (Artur Malabarba's message of "Wed, 25 Nov 2015 19:34:02 +0000") Date: Wed, 25 Nov 2015 11:40:15 -0800 Message-ID: References: <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> <20151125110755.GC2007@acm.fritz.box> <20151125154030.GF2007@acm.fritz.box> <20151125172211.GH2007@acm.fritz.box> <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20241 Cc: Alan Mackenzie , 20241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >>>>> Artur Malabarba writes: > This is a bug then (probably in the advertised-calling-convention of > funcall). Functions called with the wrong number of arguments are usually > reported as warnings by the byte-compiler. Ok, let's go with this then: Evaluation: Run-time error Compilation: Compile-time warning Execution: Run-time error (same as Evaluation) I think that's the convergence point for the three of us, amirite? John From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 14:56:16 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 19:56:17 +0000 Received: from localhost ([127.0.0.1]:53171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1gAq-0000N7-CK for submit@debbugs.gnu.org; Wed, 25 Nov 2015 14:56:16 -0500 Received: from mail-yk0-f173.google.com ([209.85.160.173]:34717) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1fd6-0007ty-BY for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 14:21:42 -0500 Received: by ykfs79 with SMTP id s79so67417113ykf.1 for <20241@debbugs.gnu.org>; Wed, 25 Nov 2015 11:21:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=8jwBNeu91kIPjSpNlXrGZzrDNgsJUb7OwsrFnWora1Q=; b=H16JBKIPOW53jmBiIHhnzrmrxrVODOJPHd7WuYL4w6HvMnW1vB3hcHJK1KAjBTWxO8 shEMPnpwpOAB59iB1OQ+jo0tX/HjqsOkifjgTcdoJvZ9oC0Csnp0oicV25iiruW1DrPV spkmVeuZ6cqQCo3JrbY6C132++6DynPRztTz2UuxTcHuB7y/spRYtTggjr4+M2B417FS SFqZyYoj7BcRct0KH4HWzdM2/8/qG28Ka33Ub0bDMd53J/PMI/CdC4N4HgnnjtIGcc5N PqedtBmPVap026S9xStOEFNxSokB5xGoVYS0JnuU3FrwO1jus+mayqdvMoKX8k4JI62B oNLg== X-Received: by 10.129.46.76 with SMTP id u73mr35365135ywu.147.1448479283902; Wed, 25 Nov 2015 11:21:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.95.214 with HTTP; Wed, 25 Nov 2015 11:21:04 -0800 (PST) In-Reply-To: References: <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> <20151125110755.GC2007@acm.fritz.box> <20151125154030.GF2007@acm.fritz.box> <20151125172211.GH2007@acm.fritz.box> <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> From: John Mastro Date: Wed, 25 Nov 2015 11:21:04 -0800 Message-ID: Subject: Re: bug#20241: 25.0.50; `setq' with only one argument To: John Wiegley Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20241 X-Mailman-Approved-At: Wed, 25 Nov 2015 14:56:15 -0500 Cc: Alan Mackenzie , 20241@debbugs.gnu.org, Artur Malabarba , Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) John Wiegley wrote: > Let's take a different case as a behavorial example: > > The code: (funcall) > > Interpreted: Raises an error: eval: Wrong number of arguments: funcall,= 0 > > Byte-compilation: No warnings or errors printed. > > Loading of .elc: Raises an error: load: Wrong number of arguments: func= all, 0 > > I think that we should be consistent in our behavior. Mis-using Emacs Lis= p is > not a reason to fail to byte-compile, even if it is a reason for it to fa= il to > evaluate or load. > > A separate argument could be made that bad code shouldn't compile, but th= at's > orthogonal to this discussion, and too big a pill to swallow for 25.1. As an additional point of comparison, the form `(if)' causes a warning (but not an error) during byte-compilation. bad-if.el:3:1:Warning: too few arguments for =E2=80=98if=E2=80=99 I checked its behavior since `funcall' is a function whereas `setq' is a special form, so I was interested to see if the precedent there was different. --=20 john From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 15:20:59 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 20:20:59 +0000 Received: from localhost ([127.0.0.1]:53185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1gYk-0000zX-NO for submit@debbugs.gnu.org; Wed, 25 Nov 2015 15:20:58 -0500 Received: from mail-lf0-f54.google.com ([209.85.215.54]:34580) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1gYj-0000zJ-9z for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 15:20:57 -0500 Received: by lffu14 with SMTP id u14so74385511lff.1 for <20241@debbugs.gnu.org>; Wed, 25 Nov 2015 12:20:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=W2Ne3JadF644Ir6ZnWxhJP/ZGAQWW8otCFzndwY4Ing=; b=jRqjZvdgKKXRwG0wN4soO8SMvGVg50brW3jd+Ms8HgZID2m7viuD+q0M2Y6YltDJZ+ e0MgS2QtPswjctZMlZy0BAU2hZijzhv6Hv53bTKLtizAh4PfAADv1JzfHXPrhRUrJQnU 4yLsJvRiFkwVf0S4NQ+JJF1KmpSAUz1U8PwZ39u0cQLGWuJ6NndatEW/WBj3SRErlahc zCe9Y+j7GFEtnYWzvdXxISj9spiMH89lsyS5Sfc1+b8XOsxXJdMKbHRxbM+uv/nDcZfX PRpkF7QGgIXRplPk9Sk+X4lfiEZNQ4vW/SXNETws+MLmx2OYLkGwHvNjJzyCIp/PFJIE skMw== MIME-Version: 1.0 X-Received: by 10.25.19.69 with SMTP id j66mr16513033lfi.25.1448482856286; Wed, 25 Nov 2015 12:20:56 -0800 (PST) Received: by 10.112.202.99 with HTTP; Wed, 25 Nov 2015 12:20:56 -0800 (PST) Received: by 10.112.202.99 with HTTP; Wed, 25 Nov 2015 12:20:56 -0800 (PST) In-Reply-To: References: <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> <20151125110755.GC2007@acm.fritz.box> <20151125154030.GF2007@acm.fritz.box> <20151125172211.GH2007@acm.fritz.box> <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> Date: Wed, 25 Nov 2015 20:20:56 +0000 X-Google-Sender-Auth: b7ti6rNl0umFGaojP890F9CNZE8 Message-ID: Subject: Re: bug#20241: 25.0.50; `setq' with only one argument From: Artur Malabarba To: John Wiegley Content-Type: multipart/alternative; boundary=001a114069d41cbeda05256332e8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20241 Cc: Alan Mackenzie , 20241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: bruce.connor.am@gmail.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a114069d41cbeda05256332e8 Content-Type: text/plain; charset=UTF-8 On 25 Nov 2015 7:40 pm, "John Wiegley" wrote: > Ok, let's go with this then: > > Evaluation: Run-time error > Compilation: Compile-time warning > Execution: Run-time error (same as Evaluation) > > I think that's the convergence point for the three of us, amirite? Yes, that's the final behaviour we should have. (Though, like I said, I'd prefer it if the errors were postponed to the next release. And Alan was having second thoughts about being so quick with the errors too (IIUC, he's investigating Gelpa code now).) --001a114069d41cbeda05256332e8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 25 Nov 2015 7:40 pm, "John Wiegley" <jwiegley@gmail.com> wrote:
> Ok, let's go with this then:
>
> =C2=A0 =C2=A0 Evaluation:=C2=A0 Run-time error
> =C2=A0 =C2=A0 Compilation: Compile-time warning
> =C2=A0 =C2=A0 Execution:=C2=A0 =C2=A0Run-time error (same as Evaluatio= n)
>
> I think that's the convergence point for the three of us, amirite?=

Yes, that's the final behaviour we should have.
(Though, like I said, I'd prefer it if the errors were postponed to the= next release. And Alan was having second thoughts about being so quick wit= h the errors too (IIUC, he's investigating Gelpa code now).)

--001a114069d41cbeda05256332e8-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 15:37:45 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 20:37:45 +0000 Received: from localhost ([127.0.0.1]:53193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1goy-0001Qu-Q7 for submit@debbugs.gnu.org; Wed, 25 Nov 2015 15:37:45 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:35761) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1god-0001QO-MY for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 15:37:42 -0500 Received: by pacej9 with SMTP id ej9so67311505pac.2 for <20241@debbugs.gnu.org>; Wed, 25 Nov 2015 12:37:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mime-version:content-type; bh=DCEMsO46CuK74mF45Bx8GtcZbbKgwHeNdDuE9iCziFI=; b=KHGsL3CIVy7C75XQ99I41xiTDgbn/pulNpNownzy73fnAoIOEjUkcEwmcWspZ5vQBr kxA0Gm+cIMe4D9XWf0A9FM12TGbsK2YFQo13Xy4jYV7XkMYNXwfQc06HStAN8PmpG22I oXa5Twuy/GTfbNDDr2hSVQ8m5UmzekYdJG8hMmiMbiKtx6H3or61ePCt5lLcPHG2enSV 85bMQlI8kimQ0ZJSc/CrVO6gc2dKk8qzlsiY0lAjqhIPdosd2rOljnkguPs2g2u8LAY5 5Z5tbeiSUjptdWlLV7KTH6JUjKwtC4StVtuxgBLLwR23cuzVIKN21OlJldkm/RZbopav Sr7Q== X-Received: by 10.66.227.231 with SMTP id sd7mr55034367pac.60.1448483842820; Wed, 25 Nov 2015 12:37:22 -0800 (PST) Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id xi8sm7065129pab.9.2015.11.25.12.37.22 (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 25 Nov 2015 12:37:22 -0800 (PST) From: John Wiegley X-Google-Original-From: "John Wiegley" Received: by Vulcan.local (Postfix, from userid 501) id 891FF10B22DED; Wed, 25 Nov 2015 12:37:21 -0800 (PST) To: Artur Malabarba Subject: Re: bug#20241: 25.0.50; `setq' with only one argument In-Reply-To: (Artur Malabarba's message of "Wed, 25 Nov 2015 20:20:56 +0000") Date: Wed, 25 Nov 2015 12:37:20 -0800 Message-ID: References: <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> <20151125110755.GC2007@acm.fritz.box> <20151125154030.GF2007@acm.fritz.box> <20151125172211.GH2007@acm.fritz.box> <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20241 Cc: Alan Mackenzie , 20241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >>>>> Artur Malabarba writes: > On 25 Nov 2015 7:40 pm, "John Wiegley" wrote: >> Ok, let's go with this then: >> >> Evaluation: Run-time error >> Compilation: Compile-time warning >> Execution: Run-time error (same as Evaluation) >> >> I think that's the convergence point for the three of us, amirite? > Yes, that's the final behaviour we should have. > (Though, like I said, I'd prefer it if the errors were postponed to the next > release. And Alan was having second thoughts about being so quick with the > errors too (IIUC, he's investigating Gelpa code now).) I'd accept a deprecation warning that notifies it will become an error in 25.2, then. John From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 15:57:08 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 20:57:08 +0000 Received: from localhost ([127.0.0.1]:53197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1h7j-0001uf-L6 for submit@debbugs.gnu.org; Wed, 25 Nov 2015 15:57:07 -0500 Received: from mail.muc.de ([193.149.48.3]:31129) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1h7P-0001ts-Kk for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 15:57:06 -0500 Received: (qmail 54695 invoked by uid 3782); 25 Nov 2015 20:56:46 -0000 Received: from acm.muc.de (p5B146B74.dip0.t-ipconnect.de [91.20.107.116]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 25 Nov 2015 21:56:45 +0100 Received: (qmail 23708 invoked by uid 1000); 25 Nov 2015 20:58:51 -0000 Date: Wed, 25 Nov 2015 20:58:51 +0000 To: John Wiegley Subject: Re: bug#20241: 25.0.50; `setq' with only one argument Message-ID: <20151125205851.GJ2007@acm.fritz.box> References: <20151125110755.GC2007@acm.fritz.box> <20151125154030.GF2007@acm.fritz.box> <20151125172211.GH2007@acm.fritz.box> <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 20241 Cc: 20241@debbugs.gnu.org, Artur Malabarba X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hello, John. On Wed, Nov 25, 2015 at 11:40:15AM -0800, John Wiegley wrote: > >>>>> Artur Malabarba writes: > > This is a bug then (probably in the advertised-calling-convention of > > funcall). Functions called with the wrong number of arguments are usually > > reported as warnings by the byte-compiler. > Ok, let's go with this then: > Evaluation: Run-time error > Compilation: Compile-time warning > Execution: Run-time error (same as Evaluation) I can live with that. > I think that's the convergence point for the three of us, amirite? Things are never that simple. In evaluation, we now get the signal "wrong-number-of-args setq 17". The first eight set operations are not carried out. In compilation, currently a warning message (called an "Error") is emitted, and code is generated to perform 9 set operations (the last one to nil). This needs to change. How about enhancing the definition of setq to say that with 17 arguments, NONE of the assignments are done? This should be relatively straight forward to code up in the byte compiler, even in the lexical binding case. Or, alternatively, we could explicitly say that whether the first 8 assignments are carried out before signaling the error is undefined. This should deter over-clever hackers from trying to catch the wrong-number-of-args error, expecting the code to have done something predictable. > John -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 16:19:57 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 21:19:57 +0000 Received: from localhost ([127.0.0.1]:53216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1hTo-0002WD-Eq for submit@debbugs.gnu.org; Wed, 25 Nov 2015 16:19:56 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:36099) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1hTT-0002Vl-SC for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 16:19:54 -0500 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id tAPLJYwO004449 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 25 Nov 2015 21:19:34 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id tAPLJY1Q007903 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 25 Nov 2015 21:19:34 GMT Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id tAPLJXf0017975; Wed, 25 Nov 2015 21:19:33 GMT MIME-Version: 1.0 Message-ID: <9493eecd-34c6-4dc6-a881-6d41cf6fcf13@default> Date: Wed, 25 Nov 2015 13:19:32 -0800 (PST) From: Drew Adams To: Alan Mackenzie , John Wiegley Subject: RE: bug#20241: 25.0.50; `setq' with only one argument References: <20151125110755.GC2007@acm.fritz.box> <20151125154030.GF2007@acm.fritz.box> <20151125172211.GH2007@acm.fritz.box> <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> <20151125205851.GJ2007@acm.fritz.box> In-Reply-To: <20151125205851.GJ2007@acm.fritz.box> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0021.oracle.com [156.151.31.71] X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 20241 Cc: 20241@debbugs.gnu.org, Artur Malabarba X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) j> Ok, let's go with this then: j> Evaluation: Run-time error j> Compilation: Compile-time warning j> Execution: Run-time error (same as Evaluation) j> I think that's the convergence point for the three of us, amirite? =20 Exactly what I prefer. (Dunno the difference between a compiler warning and error in our context. To me, this is the compiler letting you know that your code has a syntax error. But the form that message takes is probably a warning.) a> Or, alternatively, we could explicitly say that whether the first 8 a> assignments are carried out before signaling the error is undefined. a> This should deter over-clever hackers from trying to catch the a> wrong-number-of-args error, expecting the code to have done something a> predictable. The behavior should altogether be undefined. This is an implementation detail that users should not count on. Probably we do not need to, and should not, say anything about what happens if you do not respect the syntax. You will get an error, and it will be up to you to figure out what side effects might have occurred before the error was raised. But IMO it would be best if the `setq' implementation tested its arglist and raised an error at the outset, before doing anything. Even if it is fixed to do that, we should not advertise it. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 16:52:32 2015 Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 21:52:32 +0000 Received: from localhost ([127.0.0.1]:53227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1hzL-0003Ll-MG for submit@debbugs.gnu.org; Wed, 25 Nov 2015 16:52:32 -0500 Received: from mail-pa0-f50.google.com ([209.85.220.50]:32794) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1hz1-0003LE-Bh for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 16:52:30 -0500 Received: by pabfh17 with SMTP id fh17so70986203pab.0 for <20241@debbugs.gnu.org>; Wed, 25 Nov 2015 13:52:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mime-version:content-type; bh=fGWdd/0vjcdclBJfdVwQt87qJBCcNk4T6qGX8J+j1+w=; b=lajTcYPUEjAfEAggQj8MBvR2LtFqWpaz4/lAWEIYGPID7iQuod+J2X09mLUraGahXR CtzWy+gc6P+QKhHOKBUJcCwTXolSKVvoMbNCKPzYs8laiQCQ5lQdg0wA0Fac0bKX26ux JtSEqxNM4t7s3QqlwFeFOewBUNZAhyB6k4r9eTSAs3i7xg68ntyU1jECAzXlvzRdvuRZ ZG6CkLOsPbwgBsRuqxSOhBRDB8ICP277V/oFbSVvDt2654klFtspc3d/AhP7Ne5KRjO4 r9PfIEGP79q5nC0rbt/Da1ibLj5ghaef/elJJqlOPp8IvT5AgG69fuKbSsCiaIlrGB2T ArXg== X-Received: by 10.66.194.16 with SMTP id hs16mr54668177pac.93.1448488330404; Wed, 25 Nov 2015 13:52:10 -0800 (PST) Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id w1sm22813657pfa.57.2015.11.25.13.52.09 (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 25 Nov 2015 13:52:09 -0800 (PST) From: John Wiegley X-Google-Original-From: "John Wiegley" Received: by Vulcan.local (Postfix, from userid 501) id 378D510B64E5A; Wed, 25 Nov 2015 13:52:08 -0800 (PST) To: Alan Mackenzie Subject: Re: bug#20241: 25.0.50; `setq' with only one argument In-Reply-To: <20151125205851.GJ2007@acm.fritz.box> (Alan Mackenzie's message of "Wed, 25 Nov 2015 20:58:51 +0000") Date: Wed, 25 Nov 2015 13:52:07 -0800 Message-ID: References: <20151125110755.GC2007@acm.fritz.box> <20151125154030.GF2007@acm.fritz.box> <20151125172211.GH2007@acm.fritz.box> <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> <20151125205851.GJ2007@acm.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20241 Cc: 20241@debbugs.gnu.org, Artur Malabarba X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >>>>> Alan Mackenzie writes: > How about enhancing the definition of setq to say that with 17 > arguments, NONE of the assignments are done? This should be relatively > straight forward to code up in the byte compiler, even in the lexical > binding case. I prefer atomic operations whenever possible, so I'd rather than the whole setq would fail. This catches the error earlier, and leaves the environment in a condition that makes it easier to reproduce that error (it's possible that some of the variable settings might change the code path such that the setq is no longer performed). John From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 19:27:06 2015 Received: (at 20241) by debbugs.gnu.org; 26 Nov 2015 00:27:06 +0000 Received: from localhost ([127.0.0.1]:53275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1kOv-0007K4-OL for submit@debbugs.gnu.org; Wed, 25 Nov 2015 19:27:06 -0500 Received: from smtprelay-b32.telenor.se ([213.150.131.21]:49366) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1kOa-0007JF-N9 for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 19:27:03 -0500 Received: from ipb3.telenor.se (ipb3.telenor.se [195.54.127.166]) by smtprelay-b32.telenor.se (Postfix) with ESMTP id 50C4F87F6C for <20241@debbugs.gnu.org>; Thu, 26 Nov 2015 01:21:32 +0100 (CET) X-SMTPAUTH-B2: [bocjoh] X-SENDER-IP: [85.228.198.110] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2CIBACUTlZWPG7G5FVeGQEBAg8BAQEBgwuBQoJfg363WwENgWSGDwKBOjkUAQEBAQEBAQYBAQEBQT+ENQEBBFYjEAsOEyUPAQQNCwEMChoTiBkDFgG5dw2EYwEBAQEBAQQBAQEBH4tSglOGZgWWV4s/ln6HVh8BAYRHPTSFYAEBAQ X-IPAS-Result: A2CIBACUTlZWPG7G5FVeGQEBAg8BAQEBgwuBQoJfg363WwENgWSGDwKBOjkUAQEBAQEBAQYBAQEBQT+ENQEBBFYjEAsOEyUPAQQNCwEMChoTiBkDFgG5dw2EYwEBAQEBAQQBAQEBH4tSglOGZgWWV4s/ln6HVh8BAYRHPTSFYAEBAQ X-IronPort-AV: E=Sophos;i="5.20,344,1444687200"; d="scan'208";a="1024933376" Received: from c-6ec6e455.04-211-6c6b701.cust.bredbandsbolaget.se (HELO muon.localdomain) ([85.228.198.110]) by ipb3.telenor.se with ESMTP; 26 Nov 2015 01:21:32 +0100 Received: by muon.localdomain (Postfix, from userid 1000) id E1EF8484187; Thu, 26 Nov 2015 01:21:30 +0100 (CET) From: =?utf-8?Q?Johan_Bockg=C3=A5rd?= To: John Wiegley Subject: Re: bug#20241: 25.0.50; `setq' with only one argument References: <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> <20151125110755.GC2007@acm.fritz.box> <20151125154030.GF2007@acm.fritz.box> <20151125172211.GH2007@acm.fritz.box> <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> Date: Thu, 26 Nov 2015 01:21:30 +0100 In-Reply-To: (John Wiegley's message of "Wed, 25 Nov 2015 11:06:30 -0800") Message-ID: <87610pwqyd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 20241 Cc: Alan Mackenzie , 20241@debbugs.gnu.org, Artur Malabarba , Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) John Wiegley writes: >>>>>> Drew Adams writes: > >> My preference for the compiler is to (a) let you know there are syntax >> problems, and where they are, and (b) generate code that acts the same as >> the interpreted code: in this case, raise a runtime error. > > Let's take a different case as a behavorial example: > > The code: (funcall) > > Interpreted: Raises an error: eval: Wrong number of arguments: funcall, 0 > > Byte-compilation: No warnings or errors printed. > > Loading of .elc: Raises an error: load: Wrong number of arguments: funcall, 0 (funcall) (print t) Compile. Load .elc => This consistently gives me one of two results: A segfault, or "Invalid function: 183795961" where the actual number depends on the timestamp of the .elc file. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 26 03:59:03 2015 Received: (at 20241) by debbugs.gnu.org; 26 Nov 2015 08:59:03 +0000 Received: from localhost ([127.0.0.1]:53402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1sOM-0003Cb-Qk for submit@debbugs.gnu.org; Thu, 26 Nov 2015 03:59:03 -0500 Received: from mx2.suse.de ([195.135.220.15]:46744) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1sO2-0003Bs-44 for 20241@debbugs.gnu.org; Thu, 26 Nov 2015 03:59:00 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0AF3AAB13; Thu, 26 Nov 2015 08:57:01 +0000 (UTC) From: Andreas Schwab To: Johan =?utf-8?Q?Bockg=C3=A5rd?= Subject: Re: bug#20241: 25.0.50; `setq' with only one argument References: <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> <20151125110755.GC2007@acm.fritz.box> <20151125154030.GF2007@acm.fritz.box> <20151125172211.GH2007@acm.fritz.box> <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> <87610pwqyd.fsf@gnu.org> X-Yow: BELA LUGOSI is my co-pilot.. Date: Thu, 26 Nov 2015 09:58:39 +0100 In-Reply-To: <87610pwqyd.fsf@gnu.org> ("Johan =?utf-8?Q?Bockg=C3=A5rd=22's?= message of "Thu, 26 Nov 2015 01:21:30 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 20241 Cc: John Wiegley , 20241@debbugs.gnu.org, Artur Malabarba , Alan Mackenzie X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Johan BockgÃ¥rd writes: > (funcall) (print t) > > Compile. Load .elc => > > This consistently gives me one of two results: > A segfault, or "Invalid function: 183795961" where the actual > number depends on the timestamp of the .elc file. That's a bug in the byte compiler, it shouldn't generate call 0 without an operand on the stack. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 26 06:05:17 2015 Received: (at 20241) by debbugs.gnu.org; 26 Nov 2015 11:05:17 +0000 Received: from localhost ([127.0.0.1]:53454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1uMW-0006Nb-VD for submit@debbugs.gnu.org; Thu, 26 Nov 2015 06:05:17 -0500 Received: from mail.muc.de ([193.149.48.3]:24449) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1uMC-0006Mq-EF for 20241@debbugs.gnu.org; Thu, 26 Nov 2015 06:05:15 -0500 Received: (qmail 78728 invoked by uid 3782); 26 Nov 2015 11:04:55 -0000 Received: from acm.muc.de (p5B146E70.dip0.t-ipconnect.de [91.20.110.112]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 26 Nov 2015 12:04:53 +0100 Received: (qmail 18277 invoked by uid 1000); 26 Nov 2015 11:07:00 -0000 Date: Thu, 26 Nov 2015 11:07:00 +0000 To: John Wiegley Subject: Re: bug#20241: 25.0.50; `setq' with only one argument Message-ID: <20151126110700.GA1738@acm.fritz.box> References: <20151125154030.GF2007@acm.fritz.box> <20151125172211.GH2007@acm.fritz.box> <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 20241 Cc: 20241@debbugs.gnu.org, Drew Adams , Artur Malabarba X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hello, John. On Wed, Nov 25, 2015 at 12:37:20PM -0800, John Wiegley wrote: > >>>>> Artur Malabarba writes: > > On 25 Nov 2015 7:40 pm, "John Wiegley" wrote: > >> Ok, let's go with this then: > >> Evaluation: Run-time error > >> Compilation: Compile-time warning > >> Execution: Run-time error (same as Evaluation) > >> I think that's the convergence point for the three of us, amirite? I've committed a fix for the above. The compiler outputs the same message it previously did. The generated code DOESN'T do the first n assignements when there are 2n+1 arguments; it just signals an error like Fsetq does. > > Yes, that's the final behaviour we should have. > > (Though, like I said, I'd prefer it if the errors were postponed to the next > > release. And Alan was having second thoughts about being so quick with the > > errors too (IIUC, he's investigating Gelpa code now).) > I'd accept a deprecation warning that notifies it will become an error in > 25.2, then. I've committed the entire change. If there's going to be pain, let's just get it over with immediately. > John -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 26 07:04:18 2015 Received: (at 20241) by debbugs.gnu.org; 26 Nov 2015 12:04:18 +0000 Received: from localhost ([127.0.0.1]:53465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1vHd-0007tg-Q0 for submit@debbugs.gnu.org; Thu, 26 Nov 2015 07:04:18 -0500 Received: from mail.muc.de ([193.149.48.3]:64495) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1vHb-0007tX-BE for 20241@debbugs.gnu.org; Thu, 26 Nov 2015 07:04:16 -0500 Received: (qmail 91298 invoked by uid 3782); 26 Nov 2015 12:04:13 -0000 Received: from acm.muc.de (p5B146E70.dip0.t-ipconnect.de [91.20.110.112]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 26 Nov 2015 13:04:12 +0100 Received: (qmail 18461 invoked by uid 1000); 26 Nov 2015 12:06:19 -0000 Date: Thu, 26 Nov 2015 12:06:19 +0000 To: Andreas Schwab Subject: Re: bug#20241: 25.0.50; `setq' with only one argument Message-ID: <20151126120619.GB1738@acm.fritz.box> References: <20151125110755.GC2007@acm.fritz.box> <20151125154030.GF2007@acm.fritz.box> <20151125172211.GH2007@acm.fritz.box> <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> <87610pwqyd.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 20241 Cc: John Wiegley , 20241@debbugs.gnu.org, Artur Malabarba , Johan =?iso-8859-1?Q?Bockg=E5rd?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Andreas. On Thu, Nov 26, 2015 at 09:58:39AM +0100, Andreas Schwab wrote: > Johan Bockgård writes: > > (funcall) (print t) > > Compile. Load .elc => > > This consistently gives me one of two results: > > A segfault, or "Invalid function: 183795961" where the actual > > number depends on the timestamp of the .elc file. > That's a bug in the byte compiler, it shouldn't generate call 0 without > an operand on the stack. Try the following fix: diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index ffe73de..842e73d 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -4012,8 +4012,12 @@ byte-compile-while (setq byte-compile--for-effect nil))) (defun byte-compile-funcall (form) - (mapc 'byte-compile-form (cdr form)) - (byte-compile-out 'byte-call (length (cdr (cdr form))))) + (if (cdr form) + (progn + (mapc 'byte-compile-form (cdr form)) + (byte-compile-out 'byte-call (length (cdr (cdr form))))) + (byte-compile-log-warning "`funcall' called with no arguments" nil :error) + (byte-compile-form '(signal 'wrong-number-of-arguments '(funcall 0))))) ;; let binding > Andreas. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 26 11:38:40 2015 Received: (at 20241) by debbugs.gnu.org; 26 Nov 2015 16:38:41 +0000 Received: from localhost ([127.0.0.1]:54516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1zZA-000832-GY for submit@debbugs.gnu.org; Thu, 26 Nov 2015 11:38:40 -0500 Received: from mail-lf0-f49.google.com ([209.85.215.49]:35779) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1zZ8-00082u-Cq for 20241@debbugs.gnu.org; Thu, 26 Nov 2015 11:38:38 -0500 Received: by lfdl133 with SMTP id l133so102959530lfd.2 for <20241@debbugs.gnu.org>; Thu, 26 Nov 2015 08:38:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=HZRFXXQldvSBRm4pLPIb/iqvwIHj1LGEsn1ospue8sA=; b=ARsKwdCpBaKWNKzJGickZZmQ+6nYMvc1MohZRqrFdR2+XjuY7Wu+UNowJm0pXOR9eK QW/U7+14lg30ukQAk7w0XSrY3j7groI9Mxo0A83d+E3y2uv7qnrf/Etbar4nNL5gDz3s AxggoHSvWEPdQeoq0WhIl4l2Z7GnjmZmIbi1CrE7sGVMX6fq0lIGU5ZRpPuYaSprGzi6 gi6kjh34ic4SZMrn0T82muiN17bQrlsl2AEDM6nfUOIB8XoXG+OdDo51TCgi0C9P681w LZh2Z/KH20l7KSNp9LOO/JWnZamOdgTqVU6pPHG5VCrXzss9GU5+O304oE/iQsOPhoEr /udA== MIME-Version: 1.0 X-Received: by 10.112.126.106 with SMTP id mx10mr10895304lbb.3.1448555917503; Thu, 26 Nov 2015 08:38:37 -0800 (PST) Received: by 10.112.202.99 with HTTP; Thu, 26 Nov 2015 08:38:37 -0800 (PST) Received: by 10.112.202.99 with HTTP; Thu, 26 Nov 2015 08:38:37 -0800 (PST) In-Reply-To: <20151126120619.GB1738@acm.fritz.box> References: <20151125110755.GC2007@acm.fritz.box> <20151125154030.GF2007@acm.fritz.box> <20151125172211.GH2007@acm.fritz.box> <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> <87610pwqyd.fsf@gnu.org> <20151126120619.GB1738@acm.fritz.box> Date: Thu, 26 Nov 2015 16:38:37 +0000 X-Google-Sender-Auth: iC1cuLO77q7W4VZRh3Wa7z_ml0Q Message-ID: Subject: Re: bug#20241: 25.0.50; `setq' with only one argument From: Artur Malabarba To: Alan Mackenzie Content-Type: multipart/alternative; boundary=001a11c37a8ee673aa0525743446 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20241 Cc: John Wiegley , 20241@debbugs.gnu.org, =?UTF-8?Q?Johan_Bockg=C3=A5rd?= , Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: bruce.connor.am@gmail.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c37a8ee673aa0525743446 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable > + (mapc 'byte-compile-form (cdr form)) Use #' instead of ' please. =E2=98=BA --001a11c37a8ee673aa0525743446 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (mapc 'byte-compile-fo= rm (cdr form))

Use #' instead of ' please. =E2=98=BA

--001a11c37a8ee673aa0525743446-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 26 16:17:47 2015 Received: (at 20241) by debbugs.gnu.org; 26 Nov 2015 21:17:47 +0000 Received: from localhost ([127.0.0.1]:54689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a23vG-0006f7-U3 for submit@debbugs.gnu.org; Thu, 26 Nov 2015 16:17:47 -0500 Received: from mail.muc.de ([193.149.48.3]:24871) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a23vD-0006ey-Is for 20241@debbugs.gnu.org; Thu, 26 Nov 2015 16:17:44 -0500 Received: (qmail 38563 invoked by uid 3782); 26 Nov 2015 21:17:41 -0000 Received: from acm.muc.de (p5B146E70.dip0.t-ipconnect.de [91.20.110.112]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 26 Nov 2015 22:17:40 +0100 Received: (qmail 16381 invoked by uid 1000); 26 Nov 2015 21:19:47 -0000 Date: Thu, 26 Nov 2015 21:19:47 +0000 To: Artur Malabarba Subject: Re: bug#20241: 25.0.50; `setq' with only one argument Message-ID: <20151126211947.GB2383@acm.fritz.box> References: <20151125154030.GF2007@acm.fritz.box> <20151125172211.GH2007@acm.fritz.box> <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> <87610pwqyd.fsf@gnu.org> <20151126120619.GB1738@acm.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 20241 Cc: John Wiegley , 20241@debbugs.gnu.org, Johan =?iso-8859-1?Q?Bockg=E5rd?= , Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Evening, Artur. On Thu, Nov 26, 2015 at 04:38:37PM +0000, Artur Malabarba wrote: > > + (mapc 'byte-compile-form (cdr form)) > Use #' instead of ' please. ☺ :-). That wasn't my bit of code, I just had to reindent it. It dates from a time before using #' became fashionable. Maybe there's something to be said for replacing all such uses (or which there are 15) in the file. On a more serious note, given how there's potential for `funcall' to segfault (without my latest proposed fix), perhaps I should go through the entire byte compiler checking for similar occurrences. On another note, I've managed to byte compile elpa, and there are indeed three occurrences of bad `setq's, like you said. There were byte-compiler errors (which aborted the compilation) in packages elcs, and rudel-mode, so there just might be more in there. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 26 19:08:02 2015 Received: (at 20241) by debbugs.gnu.org; 27 Nov 2015 00:08:02 +0000 Received: from localhost ([127.0.0.1]:54790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a26a1-0002Lk-7p for submit@debbugs.gnu.org; Thu, 26 Nov 2015 19:08:01 -0500 Received: from mail-lf0-f49.google.com ([209.85.215.49]:36596) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a26Zy-0002Lb-Vv for 20241@debbugs.gnu.org; Thu, 26 Nov 2015 19:07:59 -0500 Received: by lfs39 with SMTP id 39so109221293lfs.3 for <20241@debbugs.gnu.org>; Thu, 26 Nov 2015 16:07:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=yBp5YQLd7i8uGkbjHOq4NxXAjO/LYcDfzcpeBzPhhnE=; b=ClAh0xqzZbz4Y4xbEiP5VTK0DcTaQKJPPF4tvUR7nAg1a+LN/mK1JV9zVLyYsN0Ygp HlFre4X4WqtFEpdCsdCFsnKSSeoa3QPZNQxFHDXtSMqdKVHXX3QtyP/srs8yqdwUTySz hTnhTwTje3vtEjsX3hiVW0bGow9YLQ11gFD3To8qFbKe9dRz9GpDz2YdO7lgJP4LO5oq 88JJZxzxneQD6OTUSAd/aCa9QED8VtpLVv1hzFa6UcFrIB4WcEaxcEhsodSIIjoYqLS5 5/0TmGOjNU3upYj2FOvl1qqQdw7tpPQ+qVO4l8bhati9lHdmxocTWS9Qx4HRriSmWv00 jWcg== MIME-Version: 1.0 X-Received: by 10.25.137.7 with SMTP id l7mr11566722lfd.63.1448582878375; Thu, 26 Nov 2015 16:07:58 -0800 (PST) Received: by 10.112.202.99 with HTTP; Thu, 26 Nov 2015 16:07:58 -0800 (PST) Received: by 10.112.202.99 with HTTP; Thu, 26 Nov 2015 16:07:58 -0800 (PST) In-Reply-To: <20151126211947.GB2383@acm.fritz.box> References: <20151125154030.GF2007@acm.fritz.box> <20151125172211.GH2007@acm.fritz.box> <5c5c14de-444e-4847-b91a-e7dff29b3f58@default> <87610pwqyd.fsf@gnu.org> <20151126120619.GB1738@acm.fritz.box> <20151126211947.GB2383@acm.fritz.box> Date: Fri, 27 Nov 2015 00:07:58 +0000 X-Google-Sender-Auth: IWv7bpHk3e7fAFr8PP2UnE9PB44 Message-ID: Subject: Re: bug#20241: 25.0.50; `setq' with only one argument From: Artur Malabarba To: Alan Mackenzie Content-Type: multipart/alternative; boundary=001a113fc260e4bae705257a7bb0 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20241 Cc: John Wiegley , 20241@debbugs.gnu.org, =?UTF-8?Q?Johan_Bockg=C3=A5rd?= , Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: bruce.connor.am@gmail.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a113fc260e4bae705257a7bb0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable > On Thu, Nov 26, 2015 at 04:38:37PM +0000, Artur Malabarba wrote: > > > + (mapc 'byte-compile-form (cdr form)) > > > Use #' instead of ' please. =E2=98=BA > > :-). That wasn't my bit of code, I know. I just figured that since you changed the indentation, and the line above this, and the line below this. Might as well take this chance to sneak in this small improvement. :-) --001a113fc260e4bae705257a7bb0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

> On Thu, Nov 26, 2015 at 04:38:37PM +0000, Artur Malabar= ba wrote:
> > > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (mapc 'byte-compile-form (c= dr form))
>
> > Use #' instead of ' please. =E2=98=BA
>
> :-).=C2=A0 That wasn't my bit of code,

I know. I just figured that since you changed the indentatio= n, and the line above this, and the line below this. Might as well take thi= s chance to sneak in this small improvement. :-)

--001a113fc260e4bae705257a7bb0-- From unknown Sun Aug 17 10:24:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 25 Dec 2015 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator