From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 01 06:51:44 2015 Received: (at submit) by debbugs.gnu.org; 1 Apr 2015 10:51:45 +0000 Received: from localhost ([127.0.0.1]:41921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YdGFM-0003KW-Gr for submit@debbugs.gnu.org; Wed, 01 Apr 2015 06:51:44 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60199) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YdGFK-0003KG-AW for submit@debbugs.gnu.org; Wed, 01 Apr 2015 06:51:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdGFE-0002Z5-3N for submit@debbugs.gnu.org; Wed, 01 Apr 2015 06:51:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdGFD-0002Yz-VN for submit@debbugs.gnu.org; Wed, 01 Apr 2015 06:51:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdGFC-0003YN-PK for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2015 06:51:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdGF8-0002XD-HN for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2015 06:51:34 -0400 Received: from mail-qg0-f54.google.com ([209.85.192.54]:36861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdGF8-0002X0-D7 for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2015 06:51:30 -0400 Received: by qgf60 with SMTP id 60so38397116qgf.3 for ; Wed, 01 Apr 2015 03:51:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-type; bh=pQG9mn1q9ym+lN434DXRjFot+sYyXl/nxBW/CSj/9a0=; b=PvTw9nd+WmIlXDodppKPcHyaKdMceoS+Y9DxFQVnk6jssfeK0ku9LacKqvobl3YIui UnyRO4Evi6oCjwhNM0YhvlNQSS1gexH/lle40ghEeJEFl4wn7NTcQ4/PN+IUG+ETxDd7 sTmPax9hdjn8/jeSK2ilE0It9HIaNKJjH70uKI5n9C4EvqRtnEjW+0rGZTqzg/6c7gmz yQNfANCB+NvCs4YePpu8YUXnszNfccCETuv96cwEsUXV42E8xQwH91f6fsHtK4ETF6Jv fSa2EjDdwfOQuGd2x9Hm5f76LgOcm5jr+phWYRZbhCNg32Nq20DtJLzzI5t4z+NaUxdr Gi4w== X-Gm-Message-State: ALoCoQldhs/6EQBPxqeabMDxx4JpPw7yQdTgovCIEB/SHefSWGSiF5JRgTUrjZal5cEKIo1uvCOs X-Received: by 10.55.49.143 with SMTP id x137mr13303990qkx.72.1427885489777; Wed, 01 Apr 2015 03:51:29 -0700 (PDT) Received: from holos.localdomain (c-73-163-124-41.hsd1.md.comcast.net. [73.163.124.41]) by mx.google.com with ESMTPSA id 32sm996763qgj.18.2015.04.01.03.51.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Apr 2015 03:51:28 -0700 (PDT) Received: by holos.localdomain (Postfix, from userid 1000) id 12F79691FD; Wed, 1 Apr 2015 06:51:27 -0400 (EDT) From: Mark Oteiza To: bug-gnu-emacs@gnu.org Subject: 25.0.50; CC Mode broken fontification and commenting Date: Wed, 01 Apr 2015 06:51:27 -0400 Message-ID: <87zj6snmts.fsf@udel.edu> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) >From emacs -Q: 1. C-x C-f foo.c RET 2. Insert: { RET } 3. Select the first line and M-; Only `/* ` is inserted at the beginning of the buffer, which is wrong. 4. Undo: C-/ The braces remain fontified as comments. In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw scroll bars) of 2015-03-31 on logos Repository revision: 8d1d8fc474bd9ed22cbe8b80125c8ce89dc62b57 Configured using: `configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --without-gconf --with-x-toolkit=lucid 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong --param=ssp-buffer-size=4' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB Important settings: value of $LC_COLLATE: C value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 01 15:21:44 2015 Received: (at 20240) by debbugs.gnu.org; 1 Apr 2015 19:21:44 +0000 Received: from localhost ([127.0.0.1]:42690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YdOCt-0000JM-QO for submit@debbugs.gnu.org; Wed, 01 Apr 2015 15:21:44 -0400 Received: from colin.muc.de ([193.149.48.1]:23063 helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YdOCq-0000JD-QK for 20240@debbugs.gnu.org; Wed, 01 Apr 2015 15:21:41 -0400 Received: (qmail 20033 invoked by uid 3782); 1 Apr 2015 19:21:39 -0000 Date: 1 Apr 2015 19:21:39 -0000 Message-ID: <20150401192139.20032.qmail@mail.muc.de> From: Alan Mackenzie To: 20240@debbugs.gnu.org Subject: Re: bug#20240: 25.0.50; CC Mode broken fontification and commenting Organization: muc.de e.V. In-Reply-To: X-Newsgroups: gnu.emacs.bug User-Agent: tin/2.2.0-20131224 ("Lochindaal") (UNIX) (FreeBSD/10.1-RELEASE (amd64)) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20240 Cc: Mark Oteiza X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hello, Mark. In article you wrote: >>>From emacs -Q: > 1. C-x C-f foo.c RET > 2. Insert: { RET } > 3. Select the first line and M-; > Only `/* ` is inserted at the beginning of the buffer, which is wrong. It actually signals an error at that point, which is indeed wrong. I've just committed a fix to the Emacs repository. Could you please update your sources, rebuild, and confirm that the fix works, please. Thanks for taking the trouble to report this bug. > 4. Undo: C-/ > The braces remain fontified as comments. > In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw scroll bars) > of 2015-03-31 on logos -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 01 16:05:19 2015 Received: (at submit) by debbugs.gnu.org; 1 Apr 2015 20:05:19 +0000 Received: from localhost ([127.0.0.1]:42700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YdOt5-0001Ml-0M for submit@debbugs.gnu.org; Wed, 01 Apr 2015 16:05:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:32822) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YdOt3-0001MZ-9Y for submit@debbugs.gnu.org; Wed, 01 Apr 2015 16:05:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdOsu-0000ZY-8r for submit@debbugs.gnu.org; Wed, 01 Apr 2015 16:05:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdOsu-0000ZR-6k for submit@debbugs.gnu.org; Wed, 01 Apr 2015 16:05:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdOst-00078e-A8 for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2015 16:05:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdOsp-0000PQ-FC for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2015 16:05:07 -0400 Received: from mail-qg0-f53.google.com ([209.85.192.53]:35983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdOsp-0000PG-By for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2015 16:05:03 -0400 Received: by qgeb100 with SMTP id b100so12091503qge.3 for ; Wed, 01 Apr 2015 13:05:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=b+xUdg/0/Nk6RrXqv8dcvtpjSlZt3XTjeifHSLJvt1w=; b=aVIVlvt+14Q5mKYQoC0hY+4x/1aGo6ZMD0JZBC2h0oDpzCDMReT4SSdpy+zPSsOgwp M1iPWcil/g8rOYhTpbgUTJ8Pwoz8goUudBvrrBSQRP+uYXoKdMukfQ6AtqQ5xSV5TSke ntRozGJeDBuItP+H7qwBwpnFEeU711WtHNSY2KP+jhxn5SALSbvj8rNtA3KRDCrj//2h ddCZB7GWsANN1orKRVSpp+ZMPKhQ3gkwjhvhkWrTP+wUhQn8TlHYfa1sN1oLaXaYKkgj tP+50x0QDBGF4Ccb/HHSS1SznVhlCU9ES6IdAFhA9Nd72rKs2elKqpeRooqhTARJ2xRd AQVQ== X-Gm-Message-State: ALoCoQnHox7rYXuaBGdCg5S5ttOsMawrcmatm4TfHx1/XU2IZUTBhgB4W+s/DX7csosSr22mUt4D X-Received: by 10.140.49.9 with SMTP id p9mr55055459qga.51.1427918702908; Wed, 01 Apr 2015 13:05:02 -0700 (PDT) Received: from holos.localdomain (c-73-163-124-41.hsd1.md.comcast.net. [73.163.124.41]) by mx.google.com with ESMTPSA id 91sm1992097qgl.2.2015.04.01.13.05.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Apr 2015 13:05:01 -0700 (PDT) Received: by holos.localdomain (Postfix, from userid 1000) id 0A8AE691FD; Wed, 1 Apr 2015 16:05:00 -0400 (EDT) From: Mark Oteiza To: bug-gnu-emacs@gnu.org Subject: Re: bug#20240: 25.0.50; CC Mode broken fontification and commenting References: <87zj6snmts.fsf@udel.edu> <20150401192139.20032.qmail@mail.muc.de> Date: Wed, 01 Apr 2015 16:04:59 -0400 In-Reply-To: <20150401192139.20032.qmail@mail.muc.de> (Alan Mackenzie's message of "1 Apr 2015 19:21:39 -0000") Message-ID: <871tk34ntg.fsf@udel.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Alan Mackenzie writes: > In article you wrote: >>>>From emacs -Q: > >> 1. C-x C-f foo.c RET >> 2. Insert: { RET } >> 3. Select the first line and M-; > >> Only `/* ` is inserted at the beginning of the buffer, which is wrong. > > It actually signals an error at that point, which is indeed wrong. Ah, I missed it then, thanks. > I've just committed a fix to the Emacs repository. Could you please update > your sources, rebuild, and confirm that the fix works, please. > > Thanks for taking the trouble to report this bug. You're welcome. You fixed the example I gave, but as it turns out my example was too minimal. Hopefully this is better: uncommenting the commented line in the following will signal a jit-lock error int main(void) { for(;;) { /* return 0; */ } } Repeating M-; on that line, eventually I get `return 0;` uncommented but fontified as a comment. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 03 16:52:24 2015 Received: (at 20240) by debbugs.gnu.org; 3 Apr 2015 20:52:25 +0000 Received: from localhost ([127.0.0.1]:44170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ye8Zk-0003tz-4n for submit@debbugs.gnu.org; Fri, 03 Apr 2015 16:52:24 -0400 Received: from colin.muc.de ([193.149.48.1]:34708 helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ye8Zh-0003tp-24 for 20240@debbugs.gnu.org; Fri, 03 Apr 2015 16:52:22 -0400 Received: (qmail 41892 invoked by uid 3782); 3 Apr 2015 20:52:19 -0000 Date: 3 Apr 2015 20:52:19 -0000 Message-ID: <20150403205219.41891.qmail@mail.muc.de> From: Alan Mackenzie To: Stefan Monnier , Mark Oteiza Subject: Re: bug#20240: 25.0.50; CC Mode broken fontification and commenting Organization: muc.de e.V. In-Reply-To: X-Newsgroups: gnu.emacs.bug User-Agent: tin/2.2.0-20131224 ("Lochindaal") (UNIX) (FreeBSD/10.1-RELEASE (amd64)) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20240 Cc: 20240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hello, Stefan and Mark. In article you wrote: > Alan Mackenzie writes: >> In article you wrote: >>>>>From emacs -Q: >> >>> 1. C-x C-f foo.c RET >>> 2. Insert: { RET } >>> 3. Select the first line and M-; >> >>> Only `/* ` is inserted at the beginning of the buffer, which is wrong. >> >> It actually signals an error at that point, which is indeed wrong. > Ah, I missed it then, thanks. >> I've just committed a fix to the Emacs repository. Could you please update >> your sources, rebuild, and confirm that the fix works, please. >> >> Thanks for taking the trouble to report this bug. > You're welcome. You fixed the example I gave, but as it turns out my > example was too minimal. Hopefully this is better: uncommenting the > commented line in the following will signal a jit-lock error > int main(void) { > for(;;) { > /* return 0; */ > } > } > Repeating M-; on that line, eventually I get `return 0;` uncommented but > fontified as a comment. That is actually a different (though similar) bug. Stefan, do you have any objections to the patch below, which widens the buffer in jit-lock-after-change before setting the 'fontified text properties? Mark's (latest) bug is happening because `comment-dwim' is narrowing to an existing comment which isn't at BOL, and jit-lock-after-change is erroring because it's trying to set the text properties at col 0, but can't (because of the narrowing). Like you said a while back, narrowing can cause problems. diff --git a/lisp/jit-lock.el b/lisp/jit-lock.el index 0faabeb..d5651c6 100644 --- a/lisp/jit-lock.el +++ b/lisp/jit-lock.el @@ -650,12 +650,14 @@ will take place when text is fontified stealthily." (let ((jit-lock-start start) (jit-lock-end end)) (with-buffer-prepared-for-jit-lock - (run-hook-with-args 'jit-lock-after-change-extend-region-functions - start end old-len) - ;; Make sure we change at least one char (in case of deletions). - (setq jit-lock-end (min (max jit-lock-end (1+ start)) (point-max))) - ;; Request refontification. - (put-text-property jit-lock-start jit-lock-end 'fontified nil)) + (save-restriction + (widen) + (run-hook-with-args 'jit-lock-after-change-extend-region-functions + start end old-len) + ;; Make sure we change at least one char (in case of deletions). + (setq jit-lock-end (min (max jit-lock-end (1+ start)) (point-max))) + ;; Request refontification. + (put-text-property jit-lock-start jit-lock-end 'fontified nil))) ;; Mark the change for deferred contextual refontification. (when jit-lock-context-unfontify-pos (setq jit-lock-context-unfontify-pos -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 03 18:09:21 2015 Received: (at 20240) by debbugs.gnu.org; 3 Apr 2015 22:09:21 +0000 Received: from localhost ([127.0.0.1]:44186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ye9mC-0005jq-Nb for submit@debbugs.gnu.org; Fri, 03 Apr 2015 18:09:21 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:55786) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ye9mA-0005jc-HJ for 20240@debbugs.gnu.org; Fri, 03 Apr 2015 18:09:19 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AnEFAGvvdVRBbthL/2dsb2JhbAA3gVOfQYIugQiBdgEFViMQCw4mEhQYDSSqJIwhQwwDgz4DEggDg1MEqDs X-IPAS-Result: AnEFAGvvdVRBbthL/2dsb2JhbAA3gVOfQYIugQiBdgEFViMQCw4mEhQYDSSqJIwhQwwDgz4DEggDg1MEqDs X-IronPort-AV: E=Sophos;i="5.01,1,1400040000"; d="scan'208";a="115364731" Received: from 65-110-216-75.cpe.pppoe.ca (HELO pastel.home) ([65.110.216.75]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 03 Apr 2015 18:09:12 -0400 Received: by pastel.home (Postfix, from userid 20848) id B157019E0; Fri, 3 Apr 2015 18:09:12 -0400 (EDT) From: Stefan Monnier To: Alan Mackenzie Subject: Re: bug#20240: 25.0.50; CC Mode broken fontification and commenting Message-ID: References: <20150403205219.41891.qmail@mail.muc.de> Date: Fri, 03 Apr 2015 18:09:12 -0400 In-Reply-To: <20150403205219.41891.qmail@mail.muc.de> (Alan Mackenzie's message of "3 Apr 2015 20:52:19 -0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 20240 Cc: Mark Oteiza , 20240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > - (run-hook-with-args 'jit-lock-after-change-extend-region-functions > - start end old-len) > - ;; Make sure we change at least one char (in case of deletions). > - (setq jit-lock-end (min (max jit-lock-end (1+ start)) (point-max))) > - ;; Request refontification. > - (put-text-property jit-lock-start jit-lock-end 'fontified nil)) > + (save-restriction > + (widen) > + (run-hook-with-args 'jit-lock-after-change-extend-region-functions > + start end old-len) > + ;; Make sure we change at least one char (in case of deletions). > + (setq jit-lock-end (min (max jit-lock-end (1+ start)) (point-max))) > + ;; Request refontification. > + (put-text-property jit-lock-start jit-lock-end 'fontified nil))) Widening during the call to jit-lock-after-change-extend-region-functions seems wrong. But I guess there can be meaningful cases where jit-lock-after-change-extend-region-functions could return positions outside of the narrowed region, so I'd be OK with widening during the subsequent `put-text-property'. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 04 06:45:52 2015 Received: (at 20240) by debbugs.gnu.org; 4 Apr 2015 10:45:52 +0000 Received: from localhost ([127.0.0.1]:44359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YeLaJ-0007Dd-QY for submit@debbugs.gnu.org; Sat, 04 Apr 2015 06:45:52 -0400 Received: from colin.muc.de ([193.149.48.1]:33994 helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YeLaH-0007DU-Mm for 20240@debbugs.gnu.org; Sat, 04 Apr 2015 06:45:50 -0400 Received: (qmail 16722 invoked by uid 3782); 4 Apr 2015 10:45:48 -0000 Received: from acm.muc.de (pD951883F.dip0.t-ipconnect.de [217.81.136.63]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 04 Apr 2015 12:45:47 +0200 Received: (qmail 4683 invoked by uid 1000); 4 Apr 2015 10:45:39 -0000 Date: Sat, 4 Apr 2015 10:45:39 +0000 To: Stefan Monnier , Mark Oteiza Subject: Re: bug#20240: 25.0.50; CC Mode broken fontification and commenting Message-ID: <20150404104539.GA4362@acm.fritz.box> References: <20150403205219.41891.qmail@mail.muc.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20240 Cc: 20240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hello, Stefan and Mark. On Fri, Apr 03, 2015 at 06:09:12PM -0400, Stefan Monnier wrote: > > - (run-hook-with-args 'jit-lock-after-change-extend-region-functions > > - start end old-len) > > - ;; Make sure we change at least one char (in case of deletions). > > - (setq jit-lock-end (min (max jit-lock-end (1+ start)) (point-max))) > > - ;; Request refontification. > > - (put-text-property jit-lock-start jit-lock-end 'fontified nil)) > > + (save-restriction > > + (widen) > > + (run-hook-with-args 'jit-lock-after-change-extend-region-functions > > + start end old-len) > > + ;; Make sure we change at least one char (in case of deletions). > > + (setq jit-lock-end (min (max jit-lock-end (1+ start)) (point-max))) > > + ;; Request refontification. > > + (put-text-property jit-lock-start jit-lock-end 'fontified nil))) > Widening during the call to > jit-lock-after-change-extend-region-functions seems wrong. But I guess > there can be meaningful cases where > jit-lock-after-change-extend-region-functions could return positions > outside of the narrowed region, so I'd be OK with widening during the > subsequent `put-text-property'. Thanks. I've just committed that change. Mark, would you please update your Emacs and build it again, then test whether or not your bug has finally been fixed, then let us know. Then I can close the bug. Thanks! > Stefan -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 04 10:47:33 2015 Received: (at submit) by debbugs.gnu.org; 4 Apr 2015 14:47:33 +0000 Received: from localhost ([127.0.0.1]:44835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YePMC-00064Q-Uy for submit@debbugs.gnu.org; Sat, 04 Apr 2015 10:47:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44320) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YePMA-00064B-GR for submit@debbugs.gnu.org; Sat, 04 Apr 2015 10:47:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YePM4-0000gN-E9 for submit@debbugs.gnu.org; Sat, 04 Apr 2015 10:47:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YePM4-0000gB-Bt for submit@debbugs.gnu.org; Sat, 04 Apr 2015 10:47:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YePM3-0000KS-KE for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2015 10:47:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YePLy-0000eX-J0 for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2015 10:47:23 -0400 Received: from mail-qg0-f46.google.com ([209.85.192.46]:36458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YePLy-0000dj-GP for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2015 10:47:18 -0400 Received: by qgeb100 with SMTP id b100so67429544qge.3 for ; Sat, 04 Apr 2015 07:47:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=+eJ4WrlF8vjy1FM23tafLCP9HbFke2fV/DpD6k33fOA=; b=bIniohTfIOfH7Ql2ZPBXkr8moGRUCKW9rzx8R0Im0iYGiPibmWBkB3LtbjyxZEBatk NYWxLxohgN58u101lK1njuJ04fHB9gI6jvAOOLoSKDDn5a2bwtRnmIVUrelbKSM4ZZlK Kep4ad8ZfhUjMwnb9rFk67XmonjwN0V0SManNskq6AA3n0WVND5KXBRZyGIu3jTHvDUr VOAvGJpOgRvfErRn+3VTXcmjboTBCUKOniBz1B/Zp75HFps37kkmlHNysCkQaJWpHkb9 fgMnFQk9GsGiQAbZyYV+3Z/fJVaT8TJi6tmhClc3QAyoesQMJbVBAIkdmCpFfM6nMhGN o1Ug== X-Gm-Message-State: ALoCoQkZ+eljvY9QS8PQ3hidSuRfJCW2EPR0DWIkxo9c1LFH6ovregGWccZ5iMJgBR46yUgoxVWl X-Received: by 10.55.31.90 with SMTP id f87mr13202208qkf.38.1428158837152; Sat, 04 Apr 2015 07:47:17 -0700 (PDT) Received: from holos.localdomain (c-73-172-248-173.hsd1.md.comcast.net. [73.172.248.173]) by mx.google.com with ESMTPSA id 77sm7882762qhg.16.2015.04.04.07.47.15 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Apr 2015 07:47:16 -0700 (PDT) Received: by holos.localdomain (Postfix, from userid 1000) id 7F87E691FD; Sat, 4 Apr 2015 10:47:14 -0400 (EDT) From: Mark Oteiza To: bug-gnu-emacs@gnu.org Subject: Re: bug#20240: 25.0.50; CC Mode broken fontification and commenting References: <20150403205219.41891.qmail@mail.muc.de> <20150404104539.GA4362@acm.fritz.box> Date: Sat, 04 Apr 2015 10:47:14 -0400 In-Reply-To: <20150404104539.GA4362@acm.fritz.box> (Alan Mackenzie's message of "Sat, 4 Apr 2015 10:45:39 +0000") Message-ID: <87r3s0lzm5.fsf@udel.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Alan Mackenzie writes: > Thanks. I've just committed that change. > > Mark, would you please update your Emacs and build it again, then test > whether or not your bug has finally been fixed, then let us know. Then > I can close the bug. Thanks! Fixed. Thank you! From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 27 13:43:31 2015 Received: (at control) by debbugs.gnu.org; 27 Aug 2015 17:43:31 +0000 Received: from localhost ([127.0.0.1]:40483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZV1D1-0003kY-3I for submit@debbugs.gnu.org; Thu, 27 Aug 2015 13:43:31 -0400 Received: from mail-qg0-f47.google.com ([209.85.192.47]:33433) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZV1Cz-0003kP-NH for control@debbugs.gnu.org; Thu, 27 Aug 2015 13:43:29 -0400 Received: by qgeh99 with SMTP id h99so17029785qge.0 for ; Thu, 27 Aug 2015 10:43:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=JkVWi1FLSggS1TwTeNFu9Letguzmo5jFmJa440fdBLA=; b=K3rKFDSdHFIVrrcWGHd0EovmyfyU1RQlCfRnoHGznXPo9P4Z+vTUJjIznjmxSzmDQE 0DByAKnLCyGnwxDiWd3xLNiAbbpItPrBO0haYyVPK06MvwyJja3kq8I5LvnMRZlHVxsg mRcgPVdTwkgLV40xMi6y1HXVLJywKzr6GCIW1J3q1Txgybrm0iAbhQKsibkCLCIoHiPG xPLsfEN0GEK1Q/JO0Osew0+Sbgq3XRl/S+a4untBMYdCiyHZy4oX/cx5G9ocRXIBohV2 +Hk03UXcSAWkq/noVanPes4Zc7PZxcu9PK6/+P/ZhWXvhs9PQ9S0v3vEwovA/Zo0OEaq NI3w== X-Gm-Message-State: ALoCoQnX/LiIgG9k96kNp5a9VUOY4gNOmOHXTAHIOLTlaB7ZqoUyyMu8zZMbKROOnJQ7t0IuV07A X-Received: by 10.140.234.133 with SMTP id f127mr9180376qhc.69.1440697409206; Thu, 27 Aug 2015 10:43:29 -0700 (PDT) Received: from holos.localdomain (c-73-172-248-173.hsd1.md.comcast.net. [73.172.248.173]) by smtp.gmail.com with ESMTPSA id o199sm1640901qhb.25.2015.08.27.10.43.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Aug 2015 10:43:28 -0700 (PDT) Received: by holos.localdomain (Postfix, from userid 1000) id 501B168971; Thu, 27 Aug 2015 13:43:28 -0400 (EDT) From: Mark Oteiza To: control@debbugs.gnu.org Subject: Re: bug#20240: 25.0.50; CC Mode broken fontification and commenting References: <20150403205219.41891.qmail@mail.muc.de> <20150404104539.GA4362@acm.fritz.box> <87r3s0lzm5.fsf@udel.edu> Date: Thu, 27 Aug 2015 13:43:28 -0400 In-Reply-To: <87r3s0lzm5.fsf@udel.edu> (Mark Oteiza's message of "Sat, 04 Apr 2015 10:47:14 -0400") Message-ID: <87vbc0fwzj.fsf@udel.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 20240 fixed close 20240 25.1 From unknown Mon Aug 18 11:28:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 25 Sep 2015 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator