Subject: Re: bug#20239: [PATCH 1/4] services: Add qemu-binfmt.

From: [email-masked] (Ludovic Courtès)
Date: Thu, 11 Jan 2018 14:46:15 +0100

Hello,

Ludovic Courtès <[email-masked]> skribis:

> * gnu/services/virtualization.scm (<qemu-platform>): New record type.
> (bv): New macro.
> (%i386, %i486, %alpha, %arm, %armeb, %sparc, %sparc32plus)
> (%ppc, %ppc64, %ppc64le, %m68k, %mips, %mipsel, %mipsn32el)
> (%mips64, %mips64el, %sh4, %sh4eb, %s390x, %aarch64, %hppa)
> (%qemu-platforms): New variables.
> (lookup-qemu-platforms): New procedure.
> (<qemu-binfmt-configuration>): New record type.
> (qemu-platform->binfmt): New procedures.
> (%binfmt-mount-point, %binfmt-register-file, %binfmt-file-system)
> (qemu-binfmt-service-type): New variables.
> (qemu-binfmt-shepherd-services): New procedures.
> * doc/guix.texi (Virtualization Services): Add "Transparent Emulation
> with QEMU" heading.

I fixed a couple of bugs here:

  - open the “…/register” file once for each platform instead of once
    for all;
  - hex-encode all the characters in the magic and mask fields of
    binfmt_misc (before that binfmt_misc would ignore everything after
    the first NUL).

I also added cross-references under the description of --system in the
manual, and a note about the ‘F’ flag of binfmt_misc.

Pushed now!

Thanks,
Ludo’.