From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 27 05:43:52 2015 Received: (at submit) by debbugs.gnu.org; 27 Mar 2015 09:43:52 +0000 Received: from localhost ([127.0.0.1]:37818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YbQnv-00076l-M1 for submit@debbugs.gnu.org; Fri, 27 Mar 2015 05:43:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53885) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YbQnt-00076Y-Kn for submit@debbugs.gnu.org; Fri, 27 Mar 2015 05:43:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbQnn-0005jE-BR for submit@debbugs.gnu.org; Fri, 27 Mar 2015 05:43:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbQnn-0005jA-6W for submit@debbugs.gnu.org; Fri, 27 Mar 2015 05:43:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbQnm-0001Jc-3L for bug-gnu-emacs@gnu.org; Fri, 27 Mar 2015 05:43:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbQnj-0005iV-C3 for bug-gnu-emacs@gnu.org; Fri, 27 Mar 2015 05:43:42 -0400 Received: from mout.gmx.net ([212.227.15.19]:62962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbQnj-0005iE-1p for bug-gnu-emacs@gnu.org; Fri, 27 Mar 2015 05:43:39 -0400 Received: from [192.168.1.3] ([96.232.130.59]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0LgIWi-1ZE2t229uG-00niNh for ; Fri, 27 Mar 2015 10:43:37 +0100 Message-ID: <5515261C.1000904@gmx.com> Date: Fri, 27 Mar 2015 05:42:52 -0400 From: Boruch Baum User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.5.0 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: 24.4: bookmark.el: function hangs on EOF (FIX INCLUDED) (bookmark-bmenu-goto-bookmark) OpenPGP: url=hkp://keys.gnupg.net Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Pf3svLgK1ex5dmLDBsad7QM4EQHkMp1El" X-Provags-ID: V03:K0:9YZXS+YkwzIlKcvAqW1nxNSo0RZK0XBBIyDjyqI6zprEqJQIC/6 0JoS+oJlDfeu4Na2UdQ4OeVEPfQSrDijpdZkYJjiVo6j2Po0p+O/goTpqYzjEr1EKcePS3E pXFAayMj/TbbASfy3jvVeZnvCUCjwxPRZsUWoHCWnAtFtX9uJo7xfRtcjprx0gU9ROrwUd7 +Rx6pAUzTRFdM0Rz1DPbA== X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Pf3svLgK1ex5dmLDBsad7QM4EQHkMp1El Content-Type: multipart/mixed; boundary="------------030002080105050300010700" This is a multi-part message in MIME format. --------------030002080105050300010700 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable While looking to address Stefan Monnier's comments to bug #20150, I encountered this bug in function bookmark-bmenu-goto-bookmark. If the function does not find the requested bookmark before EOF, it continues endlessly. patch attached. --=20 hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 --------------030002080105050300010700 Content-Type: text/x-patch; name="2015-03-27_001.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="2015-03-27_001.patch" --- bookmark.el 2015-03-23 04:52:30.503739608 -0400 +++ bookmark-new.el 2015-03-27 05:32:00.390173984 -0400 @@ -2064,7 +2064,8 @@ (defun bookmark-bmenu-goto-bookmark (name) "Move point to bookmark with name NAME." (goto-char (point-min)) - (while (not (equal name (bookmark-bmenu-bookmark))) + (while (and (not (equal name (bookmark-bmenu-bookmark))) + (not (equal (point) (point-max)))) (forward-line 1)) (forward-line 0)) =20 --------------030002080105050300010700-- --Pf3svLgK1ex5dmLDBsad7QM4EQHkMp1El Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVFSYcAAoJEDvrUfDmCx9L3x4P/3ZTKpSrSUmm/p041fiQZwqZ 9/BjOfRXUwaazNSpO6+lHfl7Dh5bHpIczMSaKvRO3zjvnY2RxvuDw9vKNwUl6E4+ lndafaoHrEr7JdFizHoc+rdfkm5CheA1dztcq4u5iTLJrO5oRqfAB/QwWEkLriQW SGxXeZ0sq0AVXx/cDyuzGs8D8GtM5b+6IKyE2c/dogvk+fZxS9Gb1dziYcCA/dlb m9Imb6823BFXKpFRnJLsdUbErN4hQP/tLi2XvYzirLIAv47sbWv1N3V41q6hvSwZ OTOBJP+FzaY+pTaLkM7yX0c5zrSoS/huZRBju/klf+xl6MmQt+J3ummgAFJ+WlO8 qBTvNNaJqO0AgXLOoffQvtnqijVZsMYjRClThaJr6vClQUIvvzNLEiCjsV03qya+ Z+ZwjuKURNbwlqAB6rHqTm/XapSj4qsc+wcj9TYHS/8jMyYXCZrmW2YWsIVNr3vd eG9s4h4Gkod5n3apnZS/RFAA+EnfUJWyuApcp5t3vMb+7g9OI77L2/LjlwENDCrt RsCPkJ+JN6fbLjmzVRSNz/fsD6T51JaXQprDnhjQTouB+hnrv9HwAkZCZk7J/L5d WnuInCyITdHPXmNAK0SBtEUDmTrKRQ7GDstiIeGbRD26BEblkPAnRkDU8Jr7VArf wDWbuPwN0YI07ZfZwVgV =T41G -----END PGP SIGNATURE----- --Pf3svLgK1ex5dmLDBsad7QM4EQHkMp1El-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 27 12:17:00 2015 Received: (at 20212) by debbugs.gnu.org; 27 Mar 2015 16:17:01 +0000 Received: from localhost ([127.0.0.1]:38284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YbWwO-00011L-FG for submit@debbugs.gnu.org; Fri, 27 Mar 2015 12:17:00 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:19717) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YbWwM-000115-4r for 20212@debbugs.gnu.org; Fri, 27 Mar 2015 12:16:58 -0400 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t2RGGpxm019163 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 27 Mar 2015 16:16:52 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t2RGGpac025236 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 27 Mar 2015 16:16:51 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t2RGGpo5029344; Fri, 27 Mar 2015 16:16:51 GMT MIME-Version: 1.0 Message-ID: <3a03dd52-f3af-44bb-9746-387b9fa8a847@default> Date: Fri, 27 Mar 2015 09:16:51 -0700 (PDT) From: Drew Adams To: Boruch Baum , 20212@debbugs.gnu.org Subject: RE: bug#20212: 24.4: bookmark.el: function hangs on EOF (FIX INCLUDED) (bookmark-bmenu-goto-bookmark) References: <5515261C.1000904@gmx.com> In-Reply-To: <5515261C.1000904@gmx.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20212 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > If the function does not find the requested bookmark before EOF, > it continues endlessly. patch attached. Yes, good catch. FWIW - This is fixed in Bookmark+ (5 years ago). I use `(eobp)', and I put that test first, before the test for the bookmark name: (while (and (not (eobp)) ...) ...) From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 09 11:07:44 2015 Received: (at 20212) by debbugs.gnu.org; 9 Apr 2015 15:07:44 +0000 Received: from localhost ([127.0.0.1]:51298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgE3T-0005qZ-N2 for submit@debbugs.gnu.org; Thu, 09 Apr 2015 11:07:43 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:35242) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgE3R-0005qM-SJ for 20212@debbugs.gnu.org; Thu, 09 Apr 2015 11:07:42 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t39F7eeX021881; Thu, 9 Apr 2015 11:07:40 -0400 Received: by pastel.home (Postfix, from userid 20848) id 636202D4A; Thu, 9 Apr 2015 11:07:40 -0400 (EDT) From: Stefan Monnier To: Boruch Baum Subject: Re: bug#20212: 24.4: bookmark.el: function hangs on EOF (FIX INCLUDED) (bookmark-bmenu-goto-bookmark) Message-ID: References: <5515261C.1000904@gmx.com> Date: Thu, 09 Apr 2015 11:07:40 -0400 In-Reply-To: <5515261C.1000904@gmx.com> (Boruch Baum's message of "Fri, 27 Mar 2015 05:42:52 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5271=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5271> : inlines <2670> : streams <1419633> : uri <1902573> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 20212 Cc: 20212@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > While looking to address Stefan Monnier's comments to bug #20150, I > encountered this bug in function bookmark-bmenu-goto-bookmark. If the > function does not find the requested bookmark before EOF, it continues > endlessly. Thanks, installed, Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 09 11:08:02 2015 Received: (at control) by debbugs.gnu.org; 9 Apr 2015 15:08:02 +0000 Received: from localhost ([127.0.0.1]:51301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgE3m-0005rD-6v for submit@debbugs.gnu.org; Thu, 09 Apr 2015 11:08:02 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:35344) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgE3k-0005qx-88 for control@debbugs.gnu.org; Thu, 09 Apr 2015 11:08:00 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t39F7x9H021969 for ; Thu, 9 Apr 2015 11:07:59 -0400 Received: by pastel.home (Postfix, from userid 20848) id 66EF82D4A; Thu, 9 Apr 2015 11:07:59 -0400 (EDT) From: Stefan Monnier To: control@debbugs.gnu.org Subject: Re: bug#20212: 24.4: bookmark.el: function hangs on EOF (FIX INCLUDED) (bookmark-bmenu-goto-bookmark) Message-ID: References: <5515261C.1000904@gmx.com> Date: Thu, 09 Apr 2015 11:07:59 -0400 In-Reply-To: <5515261C.1000904@gmx.com> (Boruch Baum's message of "Fri, 27 Mar 2015 05:42:52 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5271=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5271> : inlines <2670> : streams <1419634> : uri <1902573> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) close 20212 thanks From unknown Thu Jun 19 14:18:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 08 May 2015 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator