GNU bug report logs - #20212
24.4: bookmark.el: function hangs on EOF (FIX INCLUDED) (bookmark-bmenu-goto-bookmark)

Previous Next

Package: emacs;

Reported by: Boruch Baum <boruch_baum <at> gmx.com>

Date: Fri, 27 Mar 2015 09:44:02 UTC

Severity: normal

Found in version 24.4

Done: Stefan Monnier <monnier <at> IRO.UMontreal.CA>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20212 in the body.
You can then email your comments to 20212 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#20212; Package emacs. (Fri, 27 Mar 2015 09:44:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Boruch Baum <boruch_baum <at> gmx.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 27 Mar 2015 09:44:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Boruch Baum <boruch_baum <at> gmx.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4: bookmark.el: function hangs on EOF (FIX INCLUDED)
 (bookmark-bmenu-goto-bookmark)
Date: Fri, 27 Mar 2015 05:42:52 -0400

[Message part 1 (text/plain, inline)]
While looking to address Stefan Monnier's comments to bug #20150, I
encountered this bug in function bookmark-bmenu-goto-bookmark. If the
function does not find the requested bookmark before EOF, it continues
endlessly.

patch attached.

-- 
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0


[2015-03-27_001.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20212; Package emacs. (Fri, 27 Mar 2015 16:17:02 GMT) Full text and rfc822 format available.

Message #8 received at 20212 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Boruch Baum <boruch_baum <at> gmx.com>, 20212 <at> debbugs.gnu.org
Subject: RE: bug#20212: 24.4: bookmark.el: function hangs on EOF (FIX
 INCLUDED) (bookmark-bmenu-goto-bookmark)
Date: Fri, 27 Mar 2015 09:16:51 -0700 (PDT)

> If the function does not find the requested bookmark before EOF,
> it continues endlessly.  patch attached.

Yes, good catch.  FWIW - This is fixed in Bookmark+ (5 years ago).
I use `(eobp)', and I put that test first, before the test for the
bookmark name: (while (and (not (eobp)) ...) ...)
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20212; Package emacs. (Thu, 09 Apr 2015 15:08:02 GMT) Full text and rfc822 format available.

Message #11 received at 20212 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Boruch Baum <boruch_baum <at> gmx.com>
Cc: 20212 <at> debbugs.gnu.org
Subject: Re: bug#20212: 24.4: bookmark.el: function hangs on EOF (FIX
 INCLUDED) (bookmark-bmenu-goto-bookmark)
Date: Thu, 09 Apr 2015 11:07:40 -0400

> While looking to address Stefan Monnier's comments to bug #20150, I
> encountered this bug in function bookmark-bmenu-goto-bookmark. If the
> function does not find the requested bookmark before EOF, it continues
> endlessly.

Thanks, installed,


        Stefan
bug closed, send any further explanations to 20212 <at> debbugs.gnu.org and Boruch Baum <boruch_baum <at> gmx.com> Request was from Stefan Monnier <monnier <at> IRO.UMontreal.CA> to control <at> debbugs.gnu.org. (Thu, 09 Apr 2015 15:09:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 08 May 2015 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 10 years and 42 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.