From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 26 22:05:29 2015 Received: (at submit) by debbugs.gnu.org; 27 Mar 2015 02:05:29 +0000 Received: from localhost ([127.0.0.1]:37721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YbJeK-0004dB-Jx for submit@debbugs.gnu.org; Thu, 26 Mar 2015 22:05:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56948) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YbIl3-0003IN-BJ for submit@debbugs.gnu.org; Thu, 26 Mar 2015 21:08:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbIkx-0000An-0Q for submit@debbugs.gnu.org; Thu, 26 Mar 2015 21:08:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbIkw-0000AW-TU for submit@debbugs.gnu.org; Thu, 26 Mar 2015 21:08:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbIkv-0002He-MG for bug-gnu-emacs@gnu.org; Thu, 26 Mar 2015 21:08:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbIkr-00008U-Fd for bug-gnu-emacs@gnu.org; Thu, 26 Mar 2015 21:08:13 -0400 Received: from ryniker.ods.org ([71.83.60.62]:47648) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbIkr-00006t-Au for bug-gnu-emacs@gnu.org; Thu, 26 Mar 2015 21:08:09 -0400 Received: from ryniker by ryniker.ods.org with local (Exim 4.80.1) (envelope-from ) id 1YbIkl-0001Lz-Ju for bug-gnu-emacs@gnu.org; Thu, 26 Mar 2015 21:08:03 -0400 To: bug-gnu-emacs@gnu.org Subject: 24.4; sendmail.el From: Richard Ryniker Message-Id: Date: Thu, 26 Mar 2015 21:08:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 26 Mar 2015 22:05:26 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) In file lisp/mail/sendmail.el, in function sendmail-send-it, if variable mail-interactive has been changed from its default value t to nil, no errbuf is created. On the last line of the sendmail-send-it function, errbuf is used as the argument for switch-to-buffer-other-window, which faults because errbuf is not a buffer in this case. Patch to use the appropriate actual buffer when errbuf does not exist: [ryniker@puget ryniker]$ diff -c tmp/sendmail.el sendmail.el *** tmp/sendmail.el Thu Mar 26 20:42:09 2015 --- sendmail.el Thu Mar 26 20:07:32 2015 *************** *** 1302,1308 **** (if (and (bufferp errbuf) (not error)) (kill-buffer errbuf) ! (switch-to-buffer-other-window errbuf))))) (autoload 'rmail-output-to-rmail-buffer "rmailout") --- 1302,1308 ---- (if (and (bufferp errbuf) (not error)) (kill-buffer errbuf) ! (switch-to-buffer-other-window (cond ((bufferp errbuf) errbuf) (t mailbuf))))))) (autoload 'rmail-output-to-rmail-buffer "rmailout") In GNU Emacs 24.4.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.9) of 2015-03-25 on puget Windowing system distributor `Fedora Project', version 11.0.11404000 Important settings: value of $LC_ALL: C value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=none locale-coding-system: utf-8-unix Major mode: Mail Minor modes in effect: shell-dirtrack-mode: t display-time-mode: t tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t auto-fill-function: mail-mode-auto-fill transient-mark-mode: t abbrev-mode: t Recent input: g u n z i p SPC s e n d m c p SPC m k d i c o d d SPC c p SPC / u s r / l o c a l / s h a r e / e m a c ; o l i i s 2 l i s e n d m m a i s e n d m a i l . t m p / g u n z i p SPC t m p / s e n d m d i f f SPC - c SPC s e n d m t m p / s e n d m SPC s e n d m a i M-x r e p o r t - e m a c s e n d m a i l . e l m a i l / e m a m a i l C-s e m a c C-k C-k C-c C-f C-f m a i l / e m a c C-x k SPC m m e - g M-x r e p o r t - e m a c s - Recent messages: Checking 48 files in /usr/local/share/emacs/24.4/lisp/emulation... Checking 151 files in /usr/local/share/emacs/24.4/lisp/emacs-lisp... Checking 24 files in /usr/local/share/emacs/24.4/lisp/cedet... Checking 57 files in /usr/local/share/emacs/24.4/lisp/calendar... Checking 87 files in /usr/local/share/emacs/24.4/lisp/calc... Checking 95 files in /usr/local/share/emacs/24.4/lisp/obsolete... Checking for load-path shadows...done Beginning of buffer [6 times] Mark saved where search started <<< Type SPC or RET to bury the buffer list >>> Load-path shadows: /home/ryniker/sendmail hides /usr/local/share/emacs/24.4/lisp/mail/sendmail Features: (dired-aux shadow emacsbug mule-util pp help-mode misearch multi-isearch qp mailalias rmailmm message format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader mail-parse rfc2231 shell pcomplete comint ansi-color ring dired time rmail sendmail derived rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils jka-compr ebuff-menu time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind gfilenotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) Memory information: ((conses 16 100633 18476) (symbols 48 19099 0) (miscs 40 103 361) (strings 32 15687 3595) (string-bytes 1 442867) (vectors 16 11317) (vector-slots 8 407439 14817) (floats 8 83 832) (intervals 56 1627 522) (buffers 960 19) (heap 1024 48286 931)) From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 28 05:59:58 2015 Received: (at 20211) by debbugs.gnu.org; 28 Mar 2015 09:59:58 +0000 Received: from localhost ([127.0.0.1]:38562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YbnX4-0002NO-E3 for submit@debbugs.gnu.org; Sat, 28 Mar 2015 05:59:58 -0400 Received: from mout.gmx.net ([212.227.15.15]:57630) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YbnX2-0002NB-6v for 20211@debbugs.gnu.org; Sat, 28 Mar 2015 05:59:56 -0400 Received: from [88.117.86.111] ([88.117.86.111]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0McVGq-1YtKPj3GGu-00HdPW; Sat, 28 Mar 2015 10:59:47 +0100 Message-ID: <55167B8B.6030203@gmx.at> Date: Sat, 28 Mar 2015 10:59:39 +0100 From: martin rudalics MIME-Version: 1.0 To: Richard Ryniker , 20211@debbugs.gnu.org Subject: Re: bug#20211: 24.4; sendmail.el References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:O6Z1dTOX2a3cLobHWD+pDoHebEnspnyXazHUU/pG4zj/N+JSmpM 3OXxSi8WGT79tVODsauL9GwXOcCmYSTYhc1VNvCHmpRV3vlpxX2vjoHsmX7e/4/m2qEOnQn FgGsvwsDASRGKV1gVrUVIGcL8ZU3N1DFqQv+7S1FImUgWajT3TMni8m+N2s64PoEGdNMbiX FoM+wTZLeg8bLBh2Q9bQw== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20211 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > ! (switch-to-buffer-other-window (cond ((bufferp errbuf) errbuf) (t mailbuf))))))) Do we really want to switch to a buffer when there was no error? I'd think we should proceed as follows: If `errbuf' exists then if `error' is non-nil switch to `errbuf' in another window and kill it otherwise. Do nothing if `errbuf' does not exist. What do you think? Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 28 09:52:03 2015 Received: (at 20211) by debbugs.gnu.org; 28 Mar 2015 13:52:03 +0000 Received: from localhost ([127.0.0.1]:38595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ybr9e-0000im-NE for submit@debbugs.gnu.org; Sat, 28 Mar 2015 09:52:02 -0400 Received: from ryniker.ods.org ([71.83.60.62]:43363) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ybr9b-0000iG-FR for 20211@debbugs.gnu.org; Sat, 28 Mar 2015 09:51:59 -0400 Received: from ryniker by ryniker.ods.org with local (Exim 4.80.1) (envelope-from ) id 1Ybr9V-0001sL-Aa; Sat, 28 Mar 2015 09:51:53 -0400 To: martin rudalics In-reply-to: <55167B8B.6030203@gmx.at> (rudalics@gmx.at) Subject: Re: bug#20211: 24.4; sendmail.el From: Richard Ryniker References: <55167B8B.6030203@gmx.at> Message-Id: Date: Sat, 28 Mar 2015 09:51:53 -0400 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 20211 Cc: 20211@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Your strategy is better. I focused too closely on simple avoidance of the fault. In fact, I believe the test you want is already present in the previous two lines. Tberefore, I think this does what you suggest: *** 1302,1308 **** (if (and (bufferp errbuf) (not error)) (kill-buffer errbuf) ! (switch-to-buffer-other-window errbuf))))) (autoload 'rmail-output-to-rmail-buffer "rmailout") --- 1305,1312 ---- (if (and (bufferp errbuf) (not error)) (kill-buffer errbuf) ! (if (bufferp errbuf) ! (switch-to-buffer-other-window errbuf)))))) (autoload 'rmail-output-to-rmail-buffer "rmailout") From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 28 11:26:37 2015 Received: (at 20211) by debbugs.gnu.org; 28 Mar 2015 15:26:37 +0000 Received: from localhost ([127.0.0.1]:38987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YbsdB-0002yH-Bg for submit@debbugs.gnu.org; Sat, 28 Mar 2015 11:26:37 -0400 Received: from mout.gmx.net ([212.227.15.19]:59650) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ybsd8-0002y3-VA for 20211@debbugs.gnu.org; Sat, 28 Mar 2015 11:26:35 -0400 Received: from [194.118.141.66] ([194.118.141.66]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MWkep-1YzmUy1lJj-00XrSO; Sat, 28 Mar 2015 16:26:27 +0100 Message-ID: <5516C81B.3040400@gmx.at> Date: Sat, 28 Mar 2015 16:26:19 +0100 From: martin rudalics MIME-Version: 1.0 To: Richard Ryniker Subject: Re: bug#20211: 24.4; sendmail.el References: <55167B8B.6030203@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:/jhr7zQBcfuzZZAwHRn3NOw3dZmRpGxqBCvELVZKFD2ca6xbpHh 862fZJ6gi7wnMsOwBEim5aKbKV2gx4WCdYgwXGqL0bC5HmNR8GVTToz0efReVVsASsA0P6q dUbvCTznfdpLM5cfQoaQG3VRH1U1KFVIaD6qA8OMLz4XetsOOIleYwUomKMX7Z/lQ85dKM7 TxUGuBiQgF/jYvu6n2TXw== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20211 Cc: 20211@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > (if (and (bufferp errbuf) > (not error)) > (kill-buffer errbuf) > ! (if (bufferp errbuf) > ! (switch-to-buffer-other-window errbuf)))))) Still slightly too complicated. We should be able to use the form (bufferp errbuf) once only, preferably starting with (when (bufferp errbuf) ... and avoid the "not" ;-) martin From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 28 16:49:35 2015 Received: (at 20211) by debbugs.gnu.org; 28 Mar 2015 20:49:35 +0000 Received: from localhost ([127.0.0.1]:39126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ybxfj-0002IR-54 for submit@debbugs.gnu.org; Sat, 28 Mar 2015 16:49:35 -0400 Received: from ryniker.ods.org ([71.83.60.62]:43497) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ybxfi-0002IC-08 for 20211@debbugs.gnu.org; Sat, 28 Mar 2015 16:49:34 -0400 Received: from ryniker by ryniker.ods.org with local (Exim 4.80.1) (envelope-from ) id 1Ybxfb-0003YD-U6; Sat, 28 Mar 2015 16:49:27 -0400 To: martin rudalics In-reply-to: <5516C81B.3040400@gmx.at> (rudalics@gmx.at) Subject: Re: bug#20211: 24.4; sendmail.el From: Richard Ryniker References: <55167B8B.6030203@gmx.at> <5516C81B.3040400@gmx.at> Message-Id: Date: Sat, 28 Mar 2015 16:49:27 -0400 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 20211 Cc: 20211@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) > We should be able to use the form (bufferp errbuf) once only I concur. Does the following look sensible to you? Should we endeavor to confirm good behavior when mail-interactive is true and the sendmail program fails? *** 1299,1308 **** (error "Sending...failed to %s" (buffer-substring (point-min) (point-max))))))) (kill-buffer tembuf) ! (if (and (bufferp errbuf) ! (not error)) ! (kill-buffer errbuf) ! (switch-to-buffer-other-window errbuf))))) (autoload 'rmail-output-to-rmail-buffer "rmailout") --- 1302,1310 ---- (error "Sending...failed to %s" (buffer-substring (point-min) (point-max))))))) (kill-buffer tembuf) ! (when (bufferp errbuf) ! (if error (switch-to-buffer-other-window errbuf) ! (kill-buffer errbuf)))))) (autoload 'rmail-output-to-rmail-buffer "rmailout") From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 29 07:20:37 2015 Received: (at 20211) by debbugs.gnu.org; 29 Mar 2015 11:20:37 +0000 Received: from localhost ([127.0.0.1]:39348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YcBGf-0000ip-0T for submit@debbugs.gnu.org; Sun, 29 Mar 2015 07:20:37 -0400 Received: from mout.gmx.net ([212.227.17.20]:50713) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YcBGb-0000iT-Hb for 20211@debbugs.gnu.org; Sun, 29 Mar 2015 07:20:34 -0400 Received: from [178.190.17.197] ([178.190.17.197]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MGWR2-1Ygb6G2KnI-00DKKl; Sun, 29 Mar 2015 13:20:24 +0200 Message-ID: <5517DFEE.9010408@gmx.at> Date: Sun, 29 Mar 2015 13:20:14 +0200 From: martin rudalics MIME-Version: 1.0 To: Richard Ryniker Subject: Re: bug#20211: 24.4; sendmail.el References: <55167B8B.6030203@gmx.at> <5516C81B.3040400@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:cpBqd0Jc0uOVKZ2kho5l3woCUedirHiGcr2f2vrgXW/FMWtYGrc 4zeLL5iZXy0RC70Tba8JS8F7vfXfBmSijjoxJ3ZIJ04bzViWqNm6DfbZNZCg9RT4w4GeZLb JCPzYiXCmfyRmzvPQTF7zxsvGuhAEJ17ibkVEH7S8YycBeyU3efKWYuKCsbZfFDUUrGf7TC dP8abEnxe/EFMpKu3CUjQ== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20211 Cc: 20211@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Does the following look sensible to you? Yes, thanks. Two minor nitpicks: I'd put a newline after (if error and use `buffer-live-p' instead of `bufferp'. Though it's not likely someone might have killed errbuf in between and we want to avoid a confusing error message in that case. And please provide a suitable ChangeLog entry. > Should we endeavor > to confirm good behavior when mail-interactive is true and the > sendmail program fails? I'm not sure I understand you here. IIUC "when mail-interactive is true and the sendmail program fails" we show the error. Don't we? martin From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 30 11:04:23 2015 Received: (at 20211) by debbugs.gnu.org; 30 Mar 2015 15:04:23 +0000 Received: from localhost ([127.0.0.1]:40598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YcbEk-0002NI-PG for submit@debbugs.gnu.org; Mon, 30 Mar 2015 11:04:23 -0400 Received: from ryniker.ods.org ([71.83.60.62]:47232) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YcbEi-0002N1-43 for 20211@debbugs.gnu.org; Mon, 30 Mar 2015 11:04:20 -0400 Received: from ryniker by ryniker.ods.org with local (Exim 4.80.1) (envelope-from ) id 1YcbEc-0005b6-9o; Mon, 30 Mar 2015 11:04:14 -0400 To: martin rudalics In-reply-to: <5517DFEE.9010408@gmx.at> (rudalics@gmx.at) Subject: Re: bug#20211: 24.4; sendmail.el From: Richard Ryniker References: <55167B8B.6030203@gmx.at> <5516C81B.3040400@gmx.at> <5517DFEE.9010408@gmx.at> Message-Id: Date: Mon, 30 Mar 2015 11:04:14 -0400 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 20211 Cc: 20211@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) *** emacs-24.4/lisp/mail/sendmail.el Fri Mar 21 01:34:40 2014 --- /home/ryniker/sendmail.el Sun Mar 29 17:14:53 2015 *************** *** 1299,1308 **** (error "Sending...failed to %s" (buffer-substring (point-min) (point-max))))))) (kill-buffer tembuf) ! (if (and (bufferp errbuf) ! (not error)) ! (kill-buffer errbuf) ! (switch-to-buffer-other-window errbuf))))) (autoload 'rmail-output-to-rmail-buffer "rmailout") --- 1299,1308 ---- (error "Sending...failed to %s" (buffer-substring (point-min) (point-max))))))) (kill-buffer tembuf) ! (when (buffer-live-p errbuf) ! (if error ! (switch-to-buffer-other-window errbuf) ! (kill-buffer errbuf)))))) (autoload 'rmail-output-to-rmail-buffer "rmailout") Proposed emacs-24.4/lisp/Changelog entry: 2015-03-29 Richard Ryniker * mail/sendmail.el (sendmail-send-it): Do not attempt to switch to non-existent buffer. (errbuf is not created when customization variable mail-interactive is nil.) >IIUC "when mail-interactive is true and the sendmail program fails" we >show the error. Don't we? I do not know. I believe this patch only changes the sendmail.el logic in the mail-interactive true case to use buffer-live-p instead of bufferp. The error I encountered occurs only when mail-interactive is nil: in this case, errbuf is never created and the attempt to switch to the non-existant buffer causes a fault. What errors a Mail User Agent reports synchronously, and what errors are reported asynchronously via mail from the Mail Transfer Agent, must depend on the programs actually used. In my case (using exim) all errors I have encountered (unknown recipient, malformed address, etc.) seem to be reported asynchronously by the MTA. To directly test mail-intereactive true, I should have to concoct some test sendmail program that delivers errors as desired. Not difficult; I can do this if you think it useful. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 30 12:02:44 2015 Received: (at 20211) by debbugs.gnu.org; 30 Mar 2015 16:02:44 +0000 Received: from localhost ([127.0.0.1]:40623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ycc9D-0003r8-N3 for submit@debbugs.gnu.org; Mon, 30 Mar 2015 12:02:43 -0400 Received: from mout.gmx.net ([212.227.17.20]:52983) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ycc9B-0003qv-Oz for 20211@debbugs.gnu.org; Mon, 30 Mar 2015 12:02:42 -0400 Received: from [194.166.85.52] ([194.166.85.52]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0Ls8Qd-1ZbQfu2XZ1-013tvK; Mon, 30 Mar 2015 18:02:33 +0200 Message-ID: <55197397.1070802@gmx.at> Date: Mon, 30 Mar 2015 18:02:31 +0200 From: martin rudalics MIME-Version: 1.0 To: Richard Ryniker Subject: Re: bug#20211: 24.4; sendmail.el References: <55167B8B.6030203@gmx.at> <5516C81B.3040400@gmx.at> <5517DFEE.9010408@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:OKvtK1XJqnMpqNFU6yMTg/iMihDBFS+gFcKjuoWqYHDETku9c+B RwuAz7f9iSPxBh0OJVp0Vdl46upecGAqL9eMNJwb/ZAIBRJI1hPD1BVCT7XBAz3NNFesH29 C2Jzj6hH+TDxkOrUgPK6u3CWPIyl5pNwQ4vGH3bYUUyBQhu+UQN2SZFu7obsxqnYav4/L6N KwUbsJ2azmO9UaQph50mQ== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20211 Cc: 20211@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Proposed emacs-24.4/lisp/Changelog entry: Even Emacs 24.5 is frozen now so I installed it in Emacs 25.1 as d16fb74..d9eff02 master -> master Please have a look. If we decide to release 24.6 we can backport it there. >> IIUC "when mail-interactive is true and the sendmail program fails" we >> show the error. Don't we? > > I do not know. I believe this patch only changes the sendmail.el logic > in the mail-interactive true case to use buffer-live-p instead of > bufferp. The error I encountered occurs only when mail-interactive is > nil: in this case, errbuf is never created and the attempt to switch to > the non-existant buffer causes a fault. Yes but due to your patch we can switch to errbuf only if it is live so the error should not happen any more. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 31 16:20:07 2015 Received: (at control) by debbugs.gnu.org; 31 Aug 2015 20:20:07 +0000 Received: from localhost ([127.0.0.1]:44141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWVYk-0004tb-4c for submit@debbugs.gnu.org; Mon, 31 Aug 2015 16:20:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53761) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWVYh-0004tT-BX for control@debbugs.gnu.org; Mon, 31 Aug 2015 16:20:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWVYg-0002qw-Lc for control@debbugs.gnu.org; Mon, 31 Aug 2015 16:20:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([208.118.235.10]:57642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWVYg-0002qk-Jc for control@debbugs.gnu.org; Mon, 31 Aug 2015 16:20:02 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ZWVYg-0006F3-4U for control@debbugs.gnu.org; Mon, 31 Aug 2015 16:20:02 -0400 Subject: control message for bug 20211 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Mon, 31 Aug 2015 16:20:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.10 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) close 20211 25.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 31 16:22:40 2015 Received: (at control) by debbugs.gnu.org; 31 Aug 2015 20:22:40 +0000 Received: from localhost ([127.0.0.1]:44146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWVbE-0004xw-AS for submit@debbugs.gnu.org; Mon, 31 Aug 2015 16:22:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54651) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWVbC-0004xo-Qk for control@debbugs.gnu.org; Mon, 31 Aug 2015 16:22:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWVbC-0004HF-7J for control@debbugs.gnu.org; Mon, 31 Aug 2015 16:22:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([208.118.235.10]:57661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWVbC-0004HB-4G for control@debbugs.gnu.org; Mon, 31 Aug 2015 16:22:38 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ZWVbB-0006YH-9j for control@debbugs.gnu.org; Mon, 31 Aug 2015 16:22:37 -0400 Subject: control message for bug 21388 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Mon, 31 Aug 2015 16:22:37 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.10 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) forcemerge 20211 21388 From unknown Mon Jun 16 23:50:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 29 Sep 2015 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 10:16:06 2016 Received: (at control) by debbugs.gnu.org; 27 Nov 2016 15:16:06 +0000 Received: from localhost ([127.0.0.1]:43701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB1BW-0007Ch-5x for submit@debbugs.gnu.org; Sun, 27 Nov 2016 10:16:06 -0500 Received: from mail-io0-f177.google.com ([209.85.223.177]:33168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB1BU-0007Bv-5d; Sun, 27 Nov 2016 10:16:04 -0500 Received: by mail-io0-f177.google.com with SMTP id j65so192538955iof.0; Sun, 27 Nov 2016 07:16:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=8+6VKfRm1jtpsHmrvvZ4RMX8Z08YkM7KL/5SHPp//os=; b=KZEzXT/gfG8xXlWlmPvEjYDP8VsLVrg/REgd2C6YBN8IQjQKGjUa+ZTijyybOXTe15 CxxaZUXu9nq6hmrdz766/a2TtsqVgKFPCuksYxQJfDZgsdpkYE8eZh09LLAnDHmi/+sn VjoQSshdnf0HzbxNIyreWW/7QibLzmXL1jbAaKXWY/aRyOa9BRPLuhU4IXrliz5zk1JS 3hO7eSJPHXxm8fVgm9Cg3g+EtjzLhNToOWYwDbPGyBAlaoZpG/lAUOKkvPWFlpXO+phd 3mQLlD8W94maOln/RzKNhMTyD0AdkUbESA64D8XFA45+jOWB0JX7gzMjzNaR02/mtFFT 83UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=8+6VKfRm1jtpsHmrvvZ4RMX8Z08YkM7KL/5SHPp//os=; b=BL4fMyESNI0YmIbQAIfU58ScynBJhDquoWTww5NXT+AQqZFBwOWwucMXIfcqf8nk4L jXAmXYRLxJsLYozpmRIS551SQRUxnthkKB491w+Kl9qgviDgAa9tK+PMy8y8kOPlnw1N mgKkGM0JuuvCDEAzdX+mhylO0JhXeEVFj070ZF8flW2FoEv3H5YpxRtko4QDvJNqq0u2 kLkGaEttPYv3A5zzQc/lL3RKQOvWxSJKI/kdFKI45RxusIjk2bzQCfPXGAojHjuF3PYL UJ24ikXRkqb/Q+Ac1xNYO9RJNgnT5y1RLCULM0Md4bsO4MdKUMQhU4pDIKKrQk79VDUh 5IqA== X-Gm-Message-State: AKaTC03KkDgxgL0G2W6phJUd253nR+cP0noqqflhZKul7oMB2xLa84GTdpB9wHjeU7hpBQ== X-Received: by 10.107.141.211 with SMTP id p202mr13734199iod.47.1480259758612; Sun, 27 Nov 2016 07:15:58 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 2sm18378284ioz.30.2016.11.27.07.15.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 27 Nov 2016 07:15:58 -0800 (PST) From: npostavs@users.sourceforge.net To: Francesco =?utf-8?Q?Potort=C3=AC?= Subject: Re: bug#25040: 24.5; setting mail-interactive to nil causes error while sending References: Date: Sun, 27 Nov 2016 10:16:54 -0500 In-Reply-To: ("Francesco \=\?utf-8\?Q\?Potort\=C3\=AC\=22's\?\= message of "Sun, 27 Nov 2016 16:00:27 +0100") Message-ID: <87twaths0p.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control Cc: 25040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) unarchive 20211 forcemerge 20211 25040 quit Francesco Potort=C3=AC writes: > > I was too hasty, sorry about that. Anyway, the problem exists, but it > is different from what I have told. 0 can be put back there. > > Apparently this change at the end of the functions fixes the bug: > > 1302,1305c1302,1305 > < (if (and (bufferp errbuf) > < (not error)) > < (kill-buffer errbuf) > < (switch-to-buffer-other-window errbuf))))) > --- >> (when (bufferp errbuf) >> (if (not error) >> (kill-buffer errbuf) >> (switch-to-buffer-other-window errbuf)))))) Ah, this was fixed in 25.1, where the function ends with (when (buffer-live-p errbuf) (if error (switch-to-buffer-other-window errbuf) (kill-buffer errbuf))) From unknown Mon Jun 16 23:50:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 26 Dec 2016 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator