GNU bug report logs - #20161
Fwd: Requesting review for change to lisp/textmodes/sgml-mode.el

Previous Next

Package: emacs;

Reported by: Jackson Hamilton <jackson <at> jacksonrayhamilton.com>

Date: Sun, 22 Mar 2015 00:05:01 UTC

Severity: minor

Tags: fixed, patch

Fixed in version 25.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 20161 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Jackson Hamilton <jackson <at> jacksonrayhamilton.com>
Cc: 20161 <at> debbugs.gnu.org
Subject: Re: bug#20161: Fwd: Requesting review for change to
 lisp/textmodes/sgml-mode.el
Date: Sun, 22 Mar 2015 10:03:59 -0400

> He could break the attribute onto a new line and it would be indented like
> so:

> <element
>    attribute="value">

> But sgml-basic-offset defaults to 2, not 3, so it doesn't make much sense
> that
> the attribute is indented by 3 spaces.

As is clear from the code you're changing the "1+" is quite deliberate,
which shows some people prefer it that way.

So as discussed, this indentation step should have its own custom var.
You can make it default to the behavior you prefer if you want.

Other than that, the patch looks OK.


        Stefan
This bug report was last modified 9 years and 87 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.