GNU bug report logs - #20161
Fwd: Requesting review for change to lisp/textmodes/sgml-mode.el

Previous Next

Full log

Message #11 received at 20161 <at> debbugs.gnu.org (full text, mbox):

From: Jackson Hamilton <jackson <at> jacksonrayhamilton.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 20161 <at> debbugs.gnu.org
Subject: Re: bug#20161: Fwd: Requesting review for change to
 lisp/textmodes/sgml-mode.el
Date: Sun, 22 Mar 2015 08:39:22 -0700

[Message part 1 (text/plain, inline)]

Okay, created a defcustom for it. Patch is attached.

On Sun, Mar 22, 2015 at 7:03 AM, Stefan Monnier <monnier <at> iro.umontreal.ca>
wrote:

> > He could break the attribute onto a new line and it would be indented
> like
> > so:
>
> > <element
> >    attribute="value">
>
> > But sgml-basic-offset defaults to 2, not 3, so it doesn't make much sense
> > that
> > the attribute is indented by 3 spaces.
>
> As is clear from the code you're changing the "1+" is quite deliberate,
> which shows some people prefer it that way.
>
> So as discussed, this indentation step should have its own custom var.
> You can make it default to the behavior you prefer if you want.
>
> Other than that, the patch looks OK.
>
>
>         Stefan
>

[Message part 2 (text/html, inline)]

[0001-Have-sgml-attribute-offset-control-SGML-attribute-in.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.