GNU bug report logs - #20154
25.0.50; json-encode-string is too slow for large strings

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 20154 <at> debbugs.gnu.org
Subject: bug#20154: 25.0.50; json-encode-string is too slow for large strings
Date: Sun, 22 Mar 2015 18:50:05 +0200

> Date: Sun, 22 Mar 2015 16:52:03 +0200
> From: Dmitry Gutov <dgutov <at> yandex.ru>
> CC: 20154 <at> debbugs.gnu.org
> 
> (defun json-encode-string-3 (string)
>    "Return a JSON representation of STRING."
>    ;; Reimplement the meat of `replace-regexp-in-string', for
>    ;; performance (bug#20154).
>    (let ((l (length string))
>          (start 0)
>          (res (list "\"")))
>      ;; Skip over ASCIIish printable characters.
>      (while (string-match "[\"\\/\b\f\n\r\t]\\|[^ -~]" string start)
>        (let* ((mb (match-beginning 0))
>               (c (aref string mb))
>               (special (rassoc c json-special-chars)))

Did you try a 'cond' with specific characters instead of calling
rassoc every time?  The list in json-special-chars is not long, is it?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.