GNU bug report logs - #20154
25.0.50; json-encode-string is too slow for large strings

Previous Next

Full log

Message #23 received at 20154 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 20154 <at> debbugs.gnu.org
Subject: Re: bug#20154: 25.0.50; json-encode-string is too slow for
 large strings
Date: Fri, 20 Mar 2015 18:21:46 +0200

On 03/20/2015 06:02 PM, Eli Zaretskii wrote:

> I have other things on my plate while I read email.  If my advice
> bothers you, I can shut up in the future.

Very well. Please continue with the advice.

> I suggest to rewrite json-encode-char, it does a lot of unnecessary
> stuff, starting with the call to encode-char (which was needed in
> Emacs 22 and before, but no more).  The call to rassoc is also
> redundant, since you already have that covered in your regexp.

Yes, I thought about that, but as the number of calls to 
`json-encode-char' must have decreased by 10 in the new version (only 
each 10th character needs to be encoded), and the runtime only decreased 
by 3 (or by 2, in a different example I have), the total improvement 
can't be dramatic enough even if `json-encode-char' is lightning-fast.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.