From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 20 03:25:02 2015 Received: (at submit) by debbugs.gnu.org; 20 Mar 2015 07:25:02 +0000 Received: from localhost ([127.0.0.1]:58773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYrIj-0004HM-JS for submit@debbugs.gnu.org; Fri, 20 Mar 2015 03:25:02 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60009) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYrIh-0004H4-7F for submit@debbugs.gnu.org; Fri, 20 Mar 2015 03:24:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYrIa-0008Ef-QP for submit@debbugs.gnu.org; Fri, 20 Mar 2015 03:24:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYrIa-0008Eb-NK for submit@debbugs.gnu.org; Fri, 20 Mar 2015 03:24:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYrIZ-0000yn-BE for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 03:24:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYrIU-0008DV-9t for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 03:24:51 -0400 Received: from mout.gmx.net ([212.227.17.20]:52714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYrIT-0008DQ-VE for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 03:24:46 -0400 Received: from [192.168.1.12] ([96.232.130.59]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MB1C4-1YinRn409M-009v1W for ; Fri, 20 Mar 2015 08:24:44 +0100 Message-ID: <550BCB14.90005@gmx.com> Date: Fri, 20 Mar 2015 03:24:04 -0400 From: Boruch Baum User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) OpenPGP: url=hkp://keys.gnupg.net Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GJXWfnC3gabvPQWof5UOMliMwwFp8mhEn" X-Provags-ID: V03:K0:tMuu2qg/XTYq/aW5513MmQwXdn2LP6J083bPsbb9l2dx+1ntxcR 47gsLIfymCB+Hp+OS4zkX8j9hqtoa/+zaOe1IFfMCOFrzFXC7qYzXJb/rkLjFBSg1RS7MDm 2cCA9ud9q/IfphE+FVo8ABEaXweszAGqLhSTt80G38uGAnbzi116X1w9sFBXEpUf9mF0lHE Jxc9Nw4Y3HnQT6eywWDWw== X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GJXWfnC3gabvPQWof5UOMliMwwFp8mhEn Content-Type: multipart/mixed; boundary="------------060009040803040808050707" This is a multi-part message in MIME format. --------------060009040803040808050707 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable When completing a bookmark annotation edit, the point on the bmenu-list would move to point-max and the selected window would be wherever the annotation buffer had been displayed. The fix restores focus to the bmenu-list window, and restores point to where it had been prior to editing the annotation. (defun bookmark-send-edited-annotation () "Use buffer contents as annotation for a bookmark. Lines beginning with `#' are ignored." (interactive) (if (not (derived-mode-p 'bookmark-edit-annotation-mode)) (error "Not in bookmark-edit-annotation-mode")) (goto-char (point-min)) (while (< (point) (point-max)) (if (looking-at "^#") (bookmark-kill-line t) (forward-line 1))) ;; Take no chances with text properties. (let ((annotation (buffer-substring-no-properties (point-min) (point-max))= ) (bookmark-name bookmark-annotation-name) (return-line (with-current-buffer "*Bookmark List*" (line-number-at-pos))) (return-column (with-current-buffer "*Bookmark List*" (current-column)))) (bookmark-set-annotation bookmark-name annotation) (setq bookmark-alist-modification-count (1+ bookmark-alist-modification-count)) (kill-buffer (current-buffer)) (pop-to-buffer (get-buffer "*Bookmark List*")) (bookmark-bmenu-list) (goto-char (point-min)) (forward-line (1- return-line)) (forward-char return-column))) --=20 hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 --------------060009040803040808050707 Content-Type: text/plain; charset=UTF-8; name="attachment" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment" KGRlZnVuIGJvb2ttYXJrLXNlbmQtZWRpdGVkLWFubm90YXRpb24gKCkKICAiVXNlIGJ1ZmZl ciBjb250ZW50cyBhcyBhbm5vdGF0aW9uIGZvciBhIGJvb2ttYXJrLgpMaW5lcyBiZWdpbm5p bmcgd2l0aCBgIycgYXJlIGlnbm9yZWQuIgogIChpbnRlcmFjdGl2ZSkKICAoaWYgKG5vdCAo ZGVyaXZlZC1tb2RlLXAgJ2Jvb2ttYXJrLWVkaXQtYW5ub3RhdGlvbi1tb2RlKSkKICAgICAg KGVycm9yICJOb3QgaW4gYm9va21hcmstZWRpdC1hbm5vdGF0aW9uLW1vZGUiKSkKICAoZ290 by1jaGFyIChwb2ludC1taW4pKQogICh3aGlsZSAoPCAocG9pbnQpIChwb2ludC1tYXgpKQog ICAgKGlmIChsb29raW5nLWF0ICJeIyIpCiAgICAgICAgKGJvb2ttYXJrLWtpbGwtbGluZSB0 KQogICAgICAoZm9yd2FyZC1saW5lIDEpKSkKICA7OyBUYWtlIG5vIGNoYW5jZXMgd2l0aCB0 ZXh0IHByb3BlcnRpZXMuCiAgKGxldAogICAgKChhbm5vdGF0aW9uIChidWZmZXItc3Vic3Ry aW5nLW5vLXByb3BlcnRpZXMgKHBvaW50LW1pbikgKHBvaW50LW1heCkpKQoJIChib29rbWFy ay1uYW1lIGJvb2ttYXJrLWFubm90YXRpb24tbmFtZSkKICAgICAocmV0dXJuLWxpbmUKICAg ICAgICh3aXRoLWN1cnJlbnQtYnVmZmVyICIqQm9va21hcmsgTGlzdCoiCiAgICAgICAgIChs aW5lLW51bWJlci1hdC1wb3MpKSkKICAgICAocmV0dXJuLWNvbHVtbgogICAgICAgKHdpdGgt Y3VycmVudC1idWZmZXIgIipCb29rbWFyayBMaXN0KiIKICAgICAgICAgKGN1cnJlbnQtY29s dW1uKSkpKQogICAgKGJvb2ttYXJrLXNldC1hbm5vdGF0aW9uIGJvb2ttYXJrLW5hbWUgYW5u b3RhdGlvbikKICAgIChzZXRxIGJvb2ttYXJrLWFsaXN0LW1vZGlmaWNhdGlvbi1jb3VudAog ICAgICAgICAgKDErIGJvb2ttYXJrLWFsaXN0LW1vZGlmaWNhdGlvbi1jb3VudCkpCiAgICAo a2lsbC1idWZmZXIgKGN1cnJlbnQtYnVmZmVyKSkKICAgIChwb3AtdG8tYnVmZmVyIChnZXQt YnVmZmVyICIqQm9va21hcmsgTGlzdCoiKSkKICAgIChib29rbWFyay1ibWVudS1saXN0KQog ICAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkKICAgIChmb3J3YXJkLWxpbmUgKDEtIHJldHVy bi1saW5lKSkKICAgIChmb3J3YXJkLWNoYXIgcmV0dXJuLWNvbHVtbikpKQo= --------------060009040803040808050707-- --GJXWfnC3gabvPQWof5UOMliMwwFp8mhEn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVC8sUAAoJEDvrUfDmCx9LQL8P/iI40MCcGx/AyII718spCsEM 5w4UjYJbyeGch1L7roMHHcmssnhldkwJ3e7DLOL0vgUrSy0bEcH28IXMOnBOgaeQ 52rNDBq/GH0IPX6LtGg3uYNaKWIXN409DJETwKe695DRQfKe9o0L/acMk583QFsT C3FSHnA+FvThUa/sz8R82v4PCLMPRHinR/lkpTy56146jdDIyd4Y+8Veji47+lLC QanMKoYUO1EHZlXmk1MNFo393HwuRHqu4NqnNPLo0gQiSg8eUSSckLk0uQhoDU0B hgBaWUKLc3pqr+WGPaqi4jA1HJNICwEn15rNOHGV439RaSgWVq8X3lxWl0X+FBAp nS95SLbQEkEbBOITia3yxLAAKKJLjVvAHO/0nuvU/BL40SHUoswwt8VBz7P1eaRJ iG58d/8GZ5VhejWD7oJUZ0t1zCi1d6vPvWOmNfclQwSTl/9Uq9ciqVx+ICDo6e6M Rt7vrZGs6T7Y6Fc9NLlLoRSg9ZKzzLgngasTsxIHjyO099HSqripj2uN+ezaUfIP atk3ypCnt0ZHfD5Qd6FX1BhOXmOAY6p6epKFh7g9JengzAnMwjKlqOkc34qsDVm6 HnQJC2AfdtVLOP6hRy9kgdZTe5nRpe1VFaKB5/cNDIXAszAZaLBWieMHZKktW1wQ vk4/l7oKRmeMYMwNEL19 =IxbK -----END PGP SIGNATURE----- --GJXWfnC3gabvPQWof5UOMliMwwFp8mhEn-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 20 10:29:03 2015 Received: (at 20150) by debbugs.gnu.org; 20 Mar 2015 14:29:03 +0000 Received: from localhost ([127.0.0.1]:59216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYxv5-0007Ly-AO for submit@debbugs.gnu.org; Fri, 20 Mar 2015 10:29:03 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:57119) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYxv3-0007Lb-JD for 20150@debbugs.gnu.org; Fri, 20 Mar 2015 10:29:01 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t2KESwOr024464; Fri, 20 Mar 2015 10:28:59 -0400 Received: by pastel.home (Postfix, from userid 20848) id CAC25F63; Fri, 20 Mar 2015 10:28:58 -0400 (EDT) From: Stefan Monnier To: Boruch Baum Subject: Re: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) Message-ID: References: <550BCB14.90005@gmx.com> Date: Fri, 20 Mar 2015 10:28:58 -0400 In-Reply-To: <550BCB14.90005@gmx.com> (Boruch Baum's message of "Fri, 20 Mar 2015 03:24:04 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5251=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5251> : inlines <2452> : streams <1408630> : uri <1885574> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 20150 Cc: 20150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > The fix restores focus to the bmenu-list window, and restores point to > where it had been prior to editing the annotation. Could you send it as a patch, otherwise I can't really see what's different. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 20 12:23:12 2015 Received: (at 20150) by debbugs.gnu.org; 20 Mar 2015 16:23:13 +0000 Received: from localhost ([127.0.0.1]:59307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYzhY-0001fz-Jy for submit@debbugs.gnu.org; Fri, 20 Mar 2015 12:23:12 -0400 Received: from mout.gmx.net ([212.227.15.18]:58222) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYzhV-0001fi-Iz for 20150@debbugs.gnu.org; Fri, 20 Mar 2015 12:23:10 -0400 Received: from [192.168.1.12] ([96.232.130.59]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0M8m7Q-1YeWXA3SSC-00CAy7; Fri, 20 Mar 2015 17:23:01 +0100 Message-ID: <550C4947.9080900@gmx.com> Date: Fri, 20 Mar 2015 12:22:31 -0400 From: Boruch Baum User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) References: <550BCB14.90005@gmx.com> In-Reply-To: OpenPGP: url=hkp://keys.gnupg.net Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HweGtk4LCJuwtKMx2Tl5qFpVMWP3Vc6Ro" X-Provags-ID: V03:K0:3sPVfkxGUSmGbEzHQTTFVfaO/DJ2KQ5hg2O6ybzE65I09yUPmXP jPBev6hyYrv1L1ACtthfWAsh3erFV/eQdDsuQKIcpmlBT6N47Ke7JxzysovNIR1mREfQzTZ /gC4dJSTVyuE3WJxQT9lqLVws5o3EbqY2iIQMqwk8iaREmX2F1/1Cy7Ezk+5HAqP+HNfW1o E/joZ1/TNmnxsCLKfNoxQ== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20150 Cc: 20150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HweGtk4LCJuwtKMx2Tl5qFpVMWP3Vc6Ro Content-Type: multipart/mixed; boundary="------------070900000908030204040407" This is a multi-part message in MIME format. --------------070900000908030204040407 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Pleasure. On 03/20/2015 10:28 AM, Stefan Monnier wrote: >> The fix restores focus to the bmenu-list window, and restores point to= >> where it had been prior to editing the annotation. >=20 > Could you send it as a patch, otherwise I can't really see what's diffe= rent. >=20 >=20 > Stefan >=20 --=20 hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 --------------070900000908030204040407 Content-Type: text/x-patch; name="emacs_bug_20150.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="emacs_bug_20150.patch" --- bookmark.el 2015-03-20 12:08:33.477496667 -0400 +++ bookmark-new.el 2015-03-20 12:09:49.401494206 -0400 @@ -889,13 +889,24 @@ (bookmark-kill-line t) (forward-line 1))) ;; Take no chances with text properties. - (let ((annotation (buffer-substring-no-properties (point-min) (point-m= ax))) - (bookmark-name bookmark-annotation-name)) + (let + ((annotation (buffer-substring-no-properties (point-min) (point-max)= )) + (bookmark-name bookmark-annotation-name) + (return-line + (with-current-buffer "*Bookmark List*" + (line-number-at-pos))) + (return-column + (with-current-buffer "*Bookmark List*" + (current-column)))) (bookmark-set-annotation bookmark-name annotation) (setq bookmark-alist-modification-count (1+ bookmark-alist-modification-count)) - (bookmark-bmenu-surreptitiously-rebuild-list)) - (kill-buffer (current-buffer))) + (kill-buffer (current-buffer)) + (pop-to-buffer (get-buffer "*Bookmark List*")) + (bookmark-bmenu-list) + (goto-char (point-min)) + (forward-line (1- return-line)) + (forward-char return-column))) =20 =20 (defun bookmark-edit-annotation (bookmark-name-or-record) --------------070900000908030204040407-- --HweGtk4LCJuwtKMx2Tl5qFpVMWP3Vc6Ro Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVDElHAAoJEDvrUfDmCx9LqZgP/3bXOL0nVwKKDsZVTtjwp9fW rxHVW6j9MX4XU+aSaDSdLnJHZ7dYnmp0GwHhrmjl0ciBh071N7PHikee3WTusl5c w9SJ0ZfC/Y4QB1ccjaWXDv5a3QX8j2GFBuaapvYagmeXDIF+Jn6BLIWxuR52IbTE Pi35D1hCrI/WcKdTJkQ67eT/OFZtjvPedwGxCB2Y82o28gXLNQ5JLMwbZ/fHeKwe Hfy5eyjL1WZihbg6yXUdZGF5HTrqZ51KuHImWWYNzppoNfUs/le6VVsX3LmLykt8 xscTkusRz31mxtChj4X5AfioOyfBueme0nLSKCBM+OYFu7R9P3fP29qtIq5nxiKw 1coqQmTXzbVYMyLQMNdJa9dDuO0HoJBLhYcXzC3ZwZqUIyu7EjCI5LLvY7wsauWI UeexsOwCLewiptCQlTCDeLyBGcbYS/mVje4Ez3F0Ad25c/ZTpCS7Dw4Etcdpndnq jvhToMrET11g3FTmFGRnQ8FOBh3EjIY/Jkqr44uVU4LsbJtV457xgFlZMXK5MSfc /k64vBmoEIggygOu+nJfj8iCphYlRi38bnqXc9rIVl7n4Xlml5PSNbWqjSWFv0Ah NN9hRgSVEDX1X0Y2JqaOBHrD6s756FI+da9RxvgEuWQKYjrCjc/iHaVZsQU02oSz zFHuDdvwmM/MPr6ehhyv =KIzS -----END PGP SIGNATURE----- --HweGtk4LCJuwtKMx2Tl5qFpVMWP3Vc6Ro-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 01 21:54:47 2019 Received: (at 20150) by debbugs.gnu.org; 2 Jul 2019 01:54:47 +0000 Received: from localhost ([127.0.0.1]:46370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hi80N-0007Ea-Cd for submit@debbugs.gnu.org; Mon, 01 Jul 2019 21:54:47 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:55746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hi80K-0007E8-Ek for 20150@debbugs.gnu.org; Mon, 01 Jul 2019 21:54:44 -0400 Received: by mail-wm1-f44.google.com with SMTP id a15so1262457wmj.5 for <20150@debbugs.gnu.org>; Mon, 01 Jul 2019 18:54:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=eYUPgGqoLLexHhIkOrxdIG/9zTTdRM9e/b7+F6Dy2mE=; b=n+hVZbtNOP3FsW6y6iaRcitNw9dN2A4vIbb+Jo34/3fafHqE3udx6LVexXhRg6ADlB V1bNpa0+/QVz61VSBgGSJxySDbNKGI2Nb/d4AtRH1fVDQqwLdkxmOz1WAzCWV/qQ7ext ycw583qYk8VpkGlY6UuwIvs0kz40wjPYtPe/yyXqU129gXMS+FyqjoLJZx+5gfYmZgLB z4yk/hWg25FYnck0mQn1M8/kppNErDzbyXMhIq2Rvh4BZSnt49/vKP3NyW80utrpozWM wbiiz2ByuUTm0L4SBtXbhgeKiFnmXDJD5ug7XOca5I89ZLlzxfx4Ghk2Vm07A6wDLnSr BhbA== X-Gm-Message-State: APjAAAUM9d3tazherahrY4h2r8KNtgVGGKbU4Z0WdRlLiikkHiq9dtjx 1IcTTMglC4EwtxvNZHXdhH3Q+I+tPmsoioLtoFo= X-Google-Smtp-Source: APXvYqy91kUr0jDzYrlWM+HDfIHRTmJrDA1PQW91X1J3uVf/t3LVqe9h7mR2jdL79St6rKa1Dllkbh8knCjdusAXomI= X-Received: by 2002:a7b:c04f:: with SMTP id u15mr399088wmc.106.1562032477659; Mon, 01 Jul 2019 18:54:37 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Tue, 2 Jul 2019 03:54:25 +0200 Message-ID: Subject: Re: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) To: Boruch Baum Content-Type: multipart/mixed; boundary="000000000000f59357058ca906ed" X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 20150 Cc: 20150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) --000000000000f59357058ca906ed Content-Type: text/plain; charset="UTF-8" Boruch Baum writes: > When completing a bookmark annotation edit, the point on the bmenu-list > would move to point-max and the selected window would be wherever the > annotation buffer had been displayed. I can confirm this bug, and suggest the attached fix. Thanks, Stefan Kangas --000000000000f59357058ca906ed Content-Type: application/octet-stream; name="0001-Restore-focus-to-Bookmark-List-after-editing-annotat.patch" Content-Disposition: attachment; filename="0001-Restore-focus-to-Bookmark-List-after-editing-annotat.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxl5q7pl0 RnJvbSA0ZmQzN2RlNDJmNzA5NzgxYzg5YTNiMGRiOWY0NTNmNWQ3MTdlMTgwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUdWUsIDIgSnVsIDIwMTkgMDM6MDY6MzcgKzAyMDAKU3ViamVjdDogW1BBVENIXSBS ZXN0b3JlIGZvY3VzIHRvIEJvb2ttYXJrIExpc3QgYWZ0ZXIgZWRpdGluZyBhbm5vdGF0aW9uCgoq IGxpc3AvYm9va21hcmsuZWwgKGJvb2ttYXJrLXNlbmQtZWRpdGVkLWFubm90YXRpb24pOiBSZXN0 b3JlIGZvY3VzIHRvCkJvb2ttYXJrIExpc3QgYWZ0ZXIgZWRpdGluZyB0aGUgYW5ub3RhdGlvbi4g IEFsc28gdGFrZSBjYXJlIHRvIGRlbGV0ZQp3aW5kb3cgd2hlbiBuZWVkZWQsIGFuZCBtb3ZlIHBv aW50IGJhY2sgdG8gYm9va21hcmsuIChCdWcjMjAxNTApCgooYm9va21hcmstYW5ub3RhdGlvbi1u YW1lKTogSW1wcm92ZSBkb2NzdHJpbmcuCihib29rbWFyay1ibWVudS1idWZmZXIpOiBOZXcgdmFy aWFibGUuCihib29rbWFyay1ibWVudS1zdXJyZXB0aXRpb3VzbHktcmVidWlsZC1saXN0KQooYm9v a21hcmstYm1lbnUtbGlzdCk6IFVzZSBpdC4KLS0tCiBsaXNwL2Jvb2ttYXJrLmVsIHwgMzIgKysr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRp b25zKCspLCAxMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2Jvb2ttYXJrLmVsIGIv bGlzcC9ib29rbWFyay5lbAppbmRleCBiYmVmMGE5MjdkLi5lNmQ1MjEyOTAxIDEwMDY0NAotLS0g YS9saXNwL2Jvb2ttYXJrLmVsCisrKyBiL2xpc3AvYm9va21hcmsuZWwKQEAgLTkwMCwxMSArOTAw LDkgQEAgYm9va21hcmsta2lsbC1saW5lCiAgICAgICAoZGVsZXRlLWNoYXIgMSkpKSkKIAogCi07 OyBEZWZ2YXJzIHRvIGF2b2lkIGNvbXBpbGF0aW9uIHdhcm5pbmdzOgogKGRlZnZhciBib29rbWFy ay1hbm5vdGF0aW9uLW5hbWUgbmlsCi0gICJWYXJpYWJsZSBob2xkaW5nIHRoZSBuYW1lIG9mIHRo ZSBib29rbWFyay4KLVRoaXMgaXMgdXNlZCBpbiBgYm9va21hcmstZWRpdC1hbm5vdGF0aW9uJyB0 byByZWNvcmQgdGhlIGJvb2ttYXJrCi13aG9zZSBhbm5vdGF0aW9uIGlzIGJlaW5nIGVkaXRlZC4i KQorICAiTmFtZSBvZiBib29rbWFyayB3aG9zZSBhbm5vdGF0aW9uIGlzIGJlaW5nIGVkaXRlZC4K K1RoaXMgaXMgdXNlZCBieSBgYm9va21hcmstZWRpdC1hbm5vdGF0aW9uLW1vZGUnLiIpCiAKIAog KGRlZnVuIGJvb2ttYXJrLWRlZmF1bHQtYW5ub3RhdGlvbi10ZXh0IChib29rbWFyay1uYW1lKQpA QCAtOTYzLDEyICs5NjEsMjQgQEAgYm9va21hcmstc2VuZC1lZGl0ZWQtYW5ub3RhdGlvbgogICAg ICAgKGZvcndhcmQtbGluZSAxKSkpCiAgIDs7IFRha2Ugbm8gY2hhbmNlcyB3aXRoIHRleHQgcHJv cGVydGllcy4KICAgKGxldCAoKGFubm90YXRpb24gKGJ1ZmZlci1zdWJzdHJpbmctbm8tcHJvcGVy dGllcyAocG9pbnQtbWluKSAocG9pbnQtbWF4KSkpCi0JKGJvb2ttYXJrLW5hbWUgYm9va21hcmst YW5ub3RhdGlvbi1uYW1lKSkKKyAgICAgICAgKGJvb2ttYXJrLW5hbWUgYm9va21hcmstYW5ub3Rh dGlvbi1uYW1lKQorICAgICAgICAoYnVmZmVyIChjdXJyZW50LWJ1ZmZlcikpKQogICAgIChib29r bWFyay1zZXQtYW5ub3RhdGlvbiBib29rbWFyay1uYW1lIGFubm90YXRpb24pCiAgICAgKHNldHEg Ym9va21hcmstYWxpc3QtbW9kaWZpY2F0aW9uLWNvdW50CiAgICAgICAgICAgKDErIGJvb2ttYXJr LWFsaXN0LW1vZGlmaWNhdGlvbi1jb3VudCkpCi0gICAgKGJvb2ttYXJrLWJtZW51LXN1cnJlcHRp dGlvdXNseS1yZWJ1aWxkLWxpc3QpKQotICAoa2lsbC1idWZmZXIgKGN1cnJlbnQtYnVmZmVyKSkp CisgICAgOzsgSWYgdGhlIGN1cnJlbnQgd2luZG93IHdhcyBvbmx5IGV2ZXIgdXNlZCBmb3IgZWRp dGluZyB0aGUKKyAgICA7OyBhbm5vdGF0aW9uLCBkZWxldGUgaXQuCisgICAgKHdoZW4gKG5vdCAo d2luZG93LXByZXYtYnVmZmVycykpCisgICAgICAoZGVsZXRlLXdpbmRvdykpCisgICAgOzsgUmVz dG9yZSBmb2N1cyB0byBCb29rbWFyayBMaXN0LgorICAgIChwb3AtdG8tYnVmZmVyIChnZXQtYnVm ZmVyIGJvb2ttYXJrLWJtZW51LWJ1ZmZlcikpCisgICAgKGJvb2ttYXJrLWJtZW51LWxpc3QpCisg ICAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkKKyAgICA7OyBSZXN0b3JlIHBvaW50IHRvIHRoZSBi b29rbWFyayB3ZSBqdXN0IGVkaXRlZC4KKyAgICAodW5sZXNzICh0ZXh0LXByb3BlcnR5LXNlYXJj aC1mb3J3YXJkICdib29rbWFyay1uYW1lLXByb3AgYm9va21hcmstbmFtZSkKKyAgICAgIChnb3Rv LWNoYXIgKHBvaW50LW1pbikpKQorICAgIChtZXNzYWdlICJTZXQgYW5ub3RhdGlvbiBmb3IgXCIl c1wiIiBib29rbWFyay1uYW1lKQorICAgIChraWxsLWJ1ZmZlciBidWZmZXIpKSkKIAogCiAoZGVm dW4gYm9va21hcmstZWRpdC1hbm5vdGF0aW9uIChib29rbWFyay1uYW1lLW9yLXJlY29yZCkKQEAg LTE1NjMsOSArMTU3MywxMSBAQCBib29rbWFyay1sb2FkCiAJKHByb2dyZXNzLXJlcG9ydGVyLWRv bmUgcmVwb3J0ZXIpKSkpKQogCiAMCi07OzsgQ29kZSBzdXBwb3J0aW5nIHRoZSBkaXJlZC1saWtl IGJvb2ttYXJrIG1lbnUuCis7OzsgQ29kZSBzdXBwb3J0aW5nIHRoZSBkaXJlZC1saWtlIGJvb2tt YXJrIGxpc3QuCiA7OyBQcmVmaXggaXMgImJvb2ttYXJrLWJtZW51IiBmb3IgImJ1ZmZlci1tZW51 IjoKIAorKGRlZmNvbnN0IGJvb2ttYXJrLWJtZW51LWJ1ZmZlciAiKkJvb2ttYXJrIExpc3QqIgor ICAiTmFtZSBvZiBidWZmZXIgdXNlZCBmb3IgQm9va21hcmsgTGlzdC4iKQogCiAoZGVmdmFyIGJv b2ttYXJrLWJtZW51LWhpZGRlbi1ib29rbWFya3MgKCkpCiAKQEAgLTE2NTAsNyArMTY2Miw3IEBA IGJvb2ttYXJrLWJtZW51LW1vZGUtbWFwCiAoZGVmdW4gYm9va21hcmstYm1lbnUtc3VycmVwdGl0 aW91c2x5LXJlYnVpbGQtbGlzdCAoKQogICAiUmVidWlsZCB0aGUgQm9va21hcmsgTGlzdCBpZiBp dCBleGlzdHMuCiBEb24ndCBhZmZlY3QgdGhlIGJ1ZmZlciByaW5nIG9yZGVyLiIKLSAgKGlmIChn ZXQtYnVmZmVyICIqQm9va21hcmsgTGlzdCoiKQorICAoaWYgKGdldC1idWZmZXIgYm9va21hcmst Ym1lbnUtYnVmZmVyKQogICAgICAgKHNhdmUtZXhjdXJzaW9uCiAgICAgICAgIChzYXZlLXdpbmRv dy1leGN1cnNpb24KICAgICAgICAgICAoYm9va21hcmstYm1lbnUtbGlzdCkpKSkpCkBAIC0xNjY0 LDcgKzE2NzYsNyBAQCBib29rbWFyay1ibWVudS1saXN0CiBkZWxldGlvbiwgb3IgPiBpZiBpdCBp cyBmbGFnZ2VkIGZvciBkaXNwbGF5aW5nLiIKICAgKGludGVyYWN0aXZlKQogICAoYm9va21hcmst bWF5YmUtbG9hZC1kZWZhdWx0LWZpbGUpCi0gIChsZXQgKChidWYgKGdldC1idWZmZXItY3JlYXRl ICIqQm9va21hcmsgTGlzdCoiKSkpCisgIChsZXQgKChidWYgKGdldC1idWZmZXItY3JlYXRlIGJv b2ttYXJrLWJtZW51LWJ1ZmZlcikpKQogICAgIChpZiAoY2FsbGVkLWludGVyYWN0aXZlbHktcCAn aW50ZXJhY3RpdmUpCiAgICAgICAgIChzd2l0Y2gtdG8tYnVmZmVyIGJ1ZikKICAgICAgIChzZXQt YnVmZmVyIGJ1ZikpKQotLSAKMi4yMS4wCgo= --000000000000f59357058ca906ed-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 01 22:02:52 2019 Received: (at control) by debbugs.gnu.org; 2 Jul 2019 02:02:52 +0000 Received: from localhost ([127.0.0.1]:46394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hi88C-0007Uq-Gz for submit@debbugs.gnu.org; Mon, 01 Jul 2019 22:02:52 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:51143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hi88B-0007Uc-3j for control@debbugs.gnu.org; Mon, 01 Jul 2019 22:02:51 -0400 Received: by mail-wm1-f42.google.com with SMTP id n9so1305730wmi.0 for ; Mon, 01 Jul 2019 19:02:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=mjZxJfLhQemiz4e3Ts9/bWVMcYba9VHP+o9+J8vk4ls=; b=PE2k1ZgWsW4No33jzN8XZTowM/vBVgTH/S7aH2dfwxpcZ0H3XfhrlkzcPKDKEnQZP2 VOT6EUayWiEZ4MxmraaAcRjLm5Ebt0d0ZG0e6IET+SVZtsrnmyhKxrf5m6xSBVXfsCoe SxwwxWf/cM9WWXOmGr2vB9U946CUhxVYsfxGcNwRLOprWdgOvgvNKnjUWUtKRJ6i+k/U IqUBBQcQ6o0gAADpz75LEAk+Au2VSzag5uvKJW8k2IomRdMOCjYAmk/CuSKaiY6102W1 OyPiW1IHOGDoMKN9jtQHQUJyXGny1/5cCXiJcdAXqmHjjW4RkRuNa+ERWDhFOW7Rf1dh J4ew== X-Gm-Message-State: APjAAAV+Gb5RpGes6nAtB4LYEMAotd7D1GaDjj4hrFg1c87xNSWRIuGi mSrKczmbwTPN8JlFpfVNw09vtUmyEXFOI9oiGA9tRDYZ X-Google-Smtp-Source: APXvYqx0srOM8Cf/NSx7Ov0J5RrSxKlgAXYrQQ1NlX8DC8ZtyRJRpvj4S5mzTd9J2Uibwspq/SBQ2EhSsF6MltfB4vA= X-Received: by 2002:a1c:9696:: with SMTP id y144mr1196527wmd.73.1562032964855; Mon, 01 Jul 2019 19:02:44 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Tue, 2 Jul 2019 04:02:33 +0200 Message-ID: Subject: tags 20150 patch To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) tags 20150 patch quit From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 01 23:24:19 2019 Received: (at 20150) by debbugs.gnu.org; 2 Jul 2019 03:24:19 +0000 Received: from localhost ([127.0.0.1]:46428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hi9P0-00036r-UQ for submit@debbugs.gnu.org; Mon, 01 Jul 2019 23:24:19 -0400 Received: from mail-wm1-f49.google.com ([209.85.128.49]:37861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hi9Oy-00036e-Od for 20150@debbugs.gnu.org; Mon, 01 Jul 2019 23:24:17 -0400 Received: by mail-wm1-f49.google.com with SMTP id f17so1559276wme.2 for <20150@debbugs.gnu.org>; Mon, 01 Jul 2019 20:24:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ROiw/wnaluJ8txXhd5LzK80HY7EfADb7K41syHHRJKo=; b=VifjIPLg/B9okhJsLLtMCSh8qBTiWCC5CDkATb/dFddl765Bk6m9SOHDvFAb4Sg7K3 bq8DmZVThhbDGaMI+ypEZopRuGW1m7rMPJ5aVTgS3m5HQzPWuOpHAFzIqeoZSsG00bqY u8v/ZgFwHbcgqr/sI8ikgR4rA1CE5B2seZh3T326oHM0Hm/+mWUgy4VD+qn274ZC9AAl R8IoWRtwHaVb9LZFRf3CHZ3oAd4dntremATMjaP1wq6IrjV6dNAI8brNCwwjU3ojbopu 4x7toKo8y1QSmbzXapBOnMaSMlwHwyeBkXsaIY3vOREx+cJU5kIRvKYY+0YD0aWjO605 strQ== X-Gm-Message-State: APjAAAV6RZ0ldgUJFJIcNNXFKT10c2cBmD4bhvJ1hQKWCRLmufoiBpXY uMuUUlkjPg8cbFIcrRENYqwN3P9B8ne01l6GKTk= X-Google-Smtp-Source: APXvYqyZs/BgscarNpMfK/AbbCck3dOSnVk7wWsOLQRDRysCfiegvaaHwcIFMQn27VRy2YSjpoaJv8Cb+bTbLGvoZag= X-Received: by 2002:a1c:cb0c:: with SMTP id b12mr1431736wmg.93.1562037850993; Mon, 01 Jul 2019 20:24:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Stefan Kangas Date: Tue, 2 Jul 2019 05:23:59 +0200 Message-ID: Subject: Re: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) To: Boruch Baum Content-Type: multipart/mixed; boundary="0000000000003c4ca6058caa47b8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 20150 Cc: 20150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --0000000000003c4ca6058caa47b8 Content-Type: text/plain; charset="UTF-8" Stefan Kangas writes: > > When completing a bookmark annotation edit, the point on the bmenu-list > > would move to point-max and the selected window would be wherever the > > annotation buffer had been displayed. > > I can confirm this bug, and suggest the attached fix. Please see this somewhat improved patch instead. Thanks, Stefan Kangas --0000000000003c4ca6058caa47b8 Content-Type: application/octet-stream; name="0001-Restore-focus-to-Bookmark-List-after-editing-annotat-2.patch" Content-Disposition: attachment; filename="0001-Restore-focus-to-Bookmark-List-after-editing-annotat-2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxl8ylgt0 RnJvbSBmZWI4OTRhZTEwMTZjMmEwNzM1YjU4ZjBkYWJmMTFlNWY3NTBkNzViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUdWUsIDIgSnVsIDIwMTkgMDM6MDY6MzcgKzAyMDAKU3ViamVjdDogW1BBVENIXSBS ZXN0b3JlIGZvY3VzIHRvIEJvb2ttYXJrIExpc3QgYWZ0ZXIgZWRpdGluZyBhbm5vdGF0aW9uCgoq IGxpc3AvYm9va21hcmsuZWwgKGJvb2ttYXJrLXNlbmQtZWRpdGVkLWFubm90YXRpb24pOiBSZXN0 b3JlIGZvY3VzIHRvCkJvb2ttYXJrIExpc3QgYWZ0ZXIgZWRpdGluZyB0aGUgYW5ub3RhdGlvbi4g IEFsc28gdGFrZSBjYXJlIHRvIGRlbGV0ZQp3aW5kb3cgd2hlbiBuZWVkZWQsIGFuZCBtb3ZlIHBv aW50IGJhY2sgdG8gYm9va21hcmsuIChCdWcjMjAxNTApCgooYm9va21hcmstYW5ub3RhdGlvbi1u YW1lKTogSW1wcm92ZSBkb2NzdHJpbmcuCihib29rbWFyay1ibWVudS1idWZmZXIpOiBOZXcgdmFy aWFibGUuCihib29rbWFyay1ibWVudS1zdXJyZXB0aXRpb3VzbHktcmVidWlsZC1saXN0KQooYm9v a21hcmstYm1lbnUtbGlzdCk6IFVzZSBpdC4KLS0tCiBsaXNwL2Jvb2ttYXJrLmVsIHwgMjcgKysr KysrKysrKysrKysrKystLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygr KSwgMTAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9ib29rbWFyay5lbCBiL2xpc3Av Ym9va21hcmsuZWwKaW5kZXggYmJlZjBhOTI3ZC4uZmFmN2Q1Njk2ZSAxMDA2NDQKLS0tIGEvbGlz cC9ib29rbWFyay5lbAorKysgYi9saXNwL2Jvb2ttYXJrLmVsCkBAIC05MDAsMTEgKzkwMCw5IEBA IGJvb2ttYXJrLWtpbGwtbGluZQogICAgICAgKGRlbGV0ZS1jaGFyIDEpKSkpCiAKIAotOzsgRGVm dmFycyB0byBhdm9pZCBjb21waWxhdGlvbiB3YXJuaW5nczoKIChkZWZ2YXIgYm9va21hcmstYW5u b3RhdGlvbi1uYW1lIG5pbAotICAiVmFyaWFibGUgaG9sZGluZyB0aGUgbmFtZSBvZiB0aGUgYm9v a21hcmsuCi1UaGlzIGlzIHVzZWQgaW4gYGJvb2ttYXJrLWVkaXQtYW5ub3RhdGlvbicgdG8gcmVj b3JkIHRoZSBib29rbWFyawotd2hvc2UgYW5ub3RhdGlvbiBpcyBiZWluZyBlZGl0ZWQuIikKKyAg Ik5hbWUgb2YgYm9va21hcmsgd2hvc2UgYW5ub3RhdGlvbiBpcyBiZWluZyBlZGl0ZWQuCitUaGlz IGlzIHVzZWQgYnkgYGJvb2ttYXJrLWVkaXQtYW5ub3RhdGlvbi1tb2RlJy4iKQogCiAKIChkZWZ1 biBib29rbWFyay1kZWZhdWx0LWFubm90YXRpb24tdGV4dCAoYm9va21hcmstbmFtZSkKQEAgLTk2 MywxMiArOTYxLDE5IEBAIGJvb2ttYXJrLXNlbmQtZWRpdGVkLWFubm90YXRpb24KICAgICAgIChm b3J3YXJkLWxpbmUgMSkpKQogICA7OyBUYWtlIG5vIGNoYW5jZXMgd2l0aCB0ZXh0IHByb3BlcnRp ZXMuCiAgIChsZXQgKChhbm5vdGF0aW9uIChidWZmZXItc3Vic3RyaW5nLW5vLXByb3BlcnRpZXMg KHBvaW50LW1pbikgKHBvaW50LW1heCkpKQotCShib29rbWFyay1uYW1lIGJvb2ttYXJrLWFubm90 YXRpb24tbmFtZSkpCisgICAgICAgIChib29rbWFyay1uYW1lIGJvb2ttYXJrLWFubm90YXRpb24t bmFtZSkKKyAgICAgICAgKG9sZC1idWZmZXIgKGN1cnJlbnQtYnVmZmVyKSkpCiAgICAgKGJvb2tt YXJrLXNldC1hbm5vdGF0aW9uIGJvb2ttYXJrLW5hbWUgYW5ub3RhdGlvbikKICAgICAoc2V0cSBi b29rbWFyay1hbGlzdC1tb2RpZmljYXRpb24tY291bnQKICAgICAgICAgICAoMSsgYm9va21hcmst YWxpc3QtbW9kaWZpY2F0aW9uLWNvdW50KSkKLSAgICAoYm9va21hcmstYm1lbnUtc3VycmVwdGl0 aW91c2x5LXJlYnVpbGQtbGlzdCkpCi0gIChraWxsLWJ1ZmZlciAoY3VycmVudC1idWZmZXIpKSkK KyAgICAocXVpdC13aW5kb3cpCisgICAgKHBvcC10by1idWZmZXIgKGdldC1idWZmZXIgYm9va21h cmstYm1lbnUtYnVmZmVyKSkKKyAgICAoYm9va21hcmstYm1lbnUtbGlzdCkKKyAgICAoZ290by1j aGFyIChwb2ludC1taW4pKQorICAgICh1bmxlc3MgKHRleHQtcHJvcGVydHktc2VhcmNoLWZvcndh cmQgJ2Jvb2ttYXJrLW5hbWUtcHJvcCBib29rbWFyay1uYW1lKQorICAgICAgKGdvdG8tY2hhciAo cG9pbnQtbWluKSkpCisgICAgKG1lc3NhZ2UgIlNldCBhbm5vdGF0aW9uIGZvciBcIiVzXCIiIGJv b2ttYXJrLW5hbWUpCisgICAgKGtpbGwtYnVmZmVyIG9sZC1idWZmZXIpKSkKIAogCiAoZGVmdW4g Ym9va21hcmstZWRpdC1hbm5vdGF0aW9uIChib29rbWFyay1uYW1lLW9yLXJlY29yZCkKQEAgLTE1 NjMsOSArMTU2OCwxMSBAQCBib29rbWFyay1sb2FkCiAJKHByb2dyZXNzLXJlcG9ydGVyLWRvbmUg cmVwb3J0ZXIpKSkpKQogCiAMCi07OzsgQ29kZSBzdXBwb3J0aW5nIHRoZSBkaXJlZC1saWtlIGJv b2ttYXJrIG1lbnUuCis7OzsgQ29kZSBzdXBwb3J0aW5nIHRoZSBkaXJlZC1saWtlIGJvb2ttYXJr IGxpc3QuCiA7OyBQcmVmaXggaXMgImJvb2ttYXJrLWJtZW51IiBmb3IgImJ1ZmZlci1tZW51IjoK IAorKGRlZmNvbnN0IGJvb2ttYXJrLWJtZW51LWJ1ZmZlciAiKkJvb2ttYXJrIExpc3QqIgorICAi TmFtZSBvZiBidWZmZXIgdXNlZCBmb3IgQm9va21hcmsgTGlzdC4iKQogCiAoZGVmdmFyIGJvb2tt YXJrLWJtZW51LWhpZGRlbi1ib29rbWFya3MgKCkpCiAKQEAgLTE2NTAsNyArMTY1Nyw3IEBAIGJv b2ttYXJrLWJtZW51LW1vZGUtbWFwCiAoZGVmdW4gYm9va21hcmstYm1lbnUtc3VycmVwdGl0aW91 c2x5LXJlYnVpbGQtbGlzdCAoKQogICAiUmVidWlsZCB0aGUgQm9va21hcmsgTGlzdCBpZiBpdCBl eGlzdHMuCiBEb24ndCBhZmZlY3QgdGhlIGJ1ZmZlciByaW5nIG9yZGVyLiIKLSAgKGlmIChnZXQt YnVmZmVyICIqQm9va21hcmsgTGlzdCoiKQorICAoaWYgKGdldC1idWZmZXIgYm9va21hcmstYm1l bnUtYnVmZmVyKQogICAgICAgKHNhdmUtZXhjdXJzaW9uCiAgICAgICAgIChzYXZlLXdpbmRvdy1l eGN1cnNpb24KICAgICAgICAgICAoYm9va21hcmstYm1lbnUtbGlzdCkpKSkpCkBAIC0xNjY0LDcg KzE2NzEsNyBAQCBib29rbWFyay1ibWVudS1saXN0CiBkZWxldGlvbiwgb3IgPiBpZiBpdCBpcyBm bGFnZ2VkIGZvciBkaXNwbGF5aW5nLiIKICAgKGludGVyYWN0aXZlKQogICAoYm9va21hcmstbWF5 YmUtbG9hZC1kZWZhdWx0LWZpbGUpCi0gIChsZXQgKChidWYgKGdldC1idWZmZXItY3JlYXRlICIq Qm9va21hcmsgTGlzdCoiKSkpCisgIChsZXQgKChidWYgKGdldC1idWZmZXItY3JlYXRlIGJvb2tt YXJrLWJtZW51LWJ1ZmZlcikpKQogICAgIChpZiAoY2FsbGVkLWludGVyYWN0aXZlbHktcCAnaW50 ZXJhY3RpdmUpCiAgICAgICAgIChzd2l0Y2gtdG8tYnVmZmVyIGJ1ZikKICAgICAgIChzZXQtYnVm ZmVyIGJ1ZikpKQotLSAKMi4yMS4wCgo= --0000000000003c4ca6058caa47b8-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 03 16:05:59 2019 Received: (at 20150) by debbugs.gnu.org; 3 Jul 2019 20:05:59 +0000 Received: from localhost ([127.0.0.1]:50129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hilVv-0000eE-Gm for submit@debbugs.gnu.org; Wed, 03 Jul 2019 16:05:59 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:42691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hilVp-0000dx-UB for 20150@debbugs.gnu.org; Wed, 03 Jul 2019 16:05:55 -0400 Received: by mail-wr1-f45.google.com with SMTP id a10so3073038wrp.9 for <20150@debbugs.gnu.org>; Wed, 03 Jul 2019 13:05:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=13ssDhPhOnU7EBEsdmJpaJ7fsOSpk+JJDDPZihTOses=; b=qpwfltM7UaREoyI1IYalot5Vf21AMXINMLILJN8W7TSRJcg6fjZ3e72HmrpPmpUMEN F22/TOLubYlVaYev8WclfewNglQ50mKVs0IMTxb+LgWE3NEcDiVv3Hkn0oA1akgGzSyZ PaMQBePYXfSOIQ8YrPYqYh6n0cL0oueeq5AOYyiasX6xOCN3DalY1evtdYWqhF2Z/4Kx cI2BuEJf/G9gUI6gnBjJxFMJ668S3oKSGuc1EXr0eKEHxJiFc/EeNGByIbYPEydEIbx7 l8PMQa4t9proKqcwWOGFBkw0oNTmMuebefCwOurmAj9QaWe5PUhFzUirCQdpyVllRXOy BmcQ== X-Gm-Message-State: APjAAAWrmis1htg1DQ7t4BkK7fVmdYNLXkGuTAw8g/uIU+aYaAL7AX9s p/uZgwUJS+kf/Nt7cLOQ2HpZ6UzNsna046pdkgc= X-Google-Smtp-Source: APXvYqz89RKDtFBQLKxs+bhjibeVNhozYgQfCy7L9WHL9ljmo5kbZtJMrCUjJ6EOV7+cPyRZniTGCn7PuJ1EZ8ZJmVE= X-Received: by 2002:adf:f904:: with SMTP id b4mr3861324wrr.291.1562184347805; Wed, 03 Jul 2019 13:05:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Stefan Kangas Date: Wed, 3 Jul 2019 22:05:35 +0200 Message-ID: Subject: Re: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) To: Boruch Baum Content-Type: multipart/mixed; boundary="000000000000201e87058ccc637b" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 20150 Cc: 20150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000201e87058ccc637b Content-Type: text/plain; charset="UTF-8" Stefan Kangas writes: > > > When completing a bookmark annotation edit, the point on the bmenu-list > > > would move to point-max and the selected window would be wherever the > > > annotation buffer had been displayed. > > > > I can confirm this bug, and suggest the attached fix. > > Please see this somewhat improved patch instead. Now that the test suite for bookmark.el has hit master, I reworked this to also include tests. Please find attached an updated patch. Thanks, Stefan Kangas --000000000000201e87058ccc637b Content-Type: application/octet-stream; name="0001-Restore-focus-to-Bookmark-List-after-editing-annotat-3.patch" Content-Disposition: attachment; filename="0001-Restore-focus-to-Bookmark-List-after-editing-annotat-3.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxno7mqi0 RnJvbSA3OTVmZjk0YzYzNTMwZmU3YTIyZmE4OGMyNWI1M2ZlNTFmNWU2NzU4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUdWUsIDIgSnVsIDIwMTkgMDM6MDY6MzcgKzAyMDAKU3ViamVjdDogW1BBVENIXSBS ZXN0b3JlIGZvY3VzIHRvIEJvb2ttYXJrIExpc3QgYWZ0ZXIgZWRpdGluZyBhbm5vdGF0aW9uCgoq IGxpc3AvYm9va21hcmsuZWwgKGJvb2ttYXJrLXNlbmQtZWRpdGVkLWFubm90YXRpb24pOiBSZXN0 b3JlIGZvY3VzIHRvCkJvb2ttYXJrIExpc3QsIHF1aXQgd2luZG93IGFuZCBtb3ZlIHBvaW50IGJh Y2sgdG8gZWRpdGVkCmJvb2ttYXJrLiAoQnVnIzIwMTUwKQoKKHRleHQtcHJvcGVydHktc2VhcmNo KTogUmVxdWlyZS4KKGJvb2ttYXJrLWFubm90YXRpb24tbmFtZSk6IEltcHJvdmUgZG9jc3RyaW5n LgooYm9va21hcmstYm1lbnUtYnVmZmVyKTogTmV3IHZhcmlhYmxlLgooYm9va21hcmstYm1lbnUt c3VycmVwdGl0aW91c2x5LXJlYnVpbGQtbGlzdCkKKGJvb2ttYXJrLWJtZW51LWxpc3QpOiBVc2Ug aXQuCgoqIHRlc3QvbGlzcC9ib29rbWFyay10ZXN0cy5lbCAod2l0aC1ib29rbWFyay1ibWVudS10 ZXN0KTogTmV3IG1hY3JvLgooYm9va21hcmstYmVudS1lZGl0LWFubm90YXRpb24vc2hvdy1hbm5v dGF0aW9uKQooYm9va21hcmstYm1lbnUtc2VuZC1lZGl0ZWQtYW5ub3RhdGlvbikKKGJvb2ttYXJr LWJtZW51LXNlbmQtZWRpdGVkLWFubm90YXRpb24vcmVzdG9yZS1mb2N1cyk6IE5ldyB0ZXN0IGNh c2VzLgotLS0KIGxpc3AvYm9va21hcmsuZWwgICAgICAgICAgICB8IDI5ICsrKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0tCiB0ZXN0L2xpc3AvYm9va21hcmstdGVzdHMuZWwgfCAzNiArKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgNTMgaW5zZXJ0 aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9ib29rbWFyay5lbCBi L2xpc3AvYm9va21hcmsuZWwKaW5kZXggOTJkMGRhMzU5NC4uZDNkNjMxMDY3YiAxMDA2NDQKLS0t IGEvbGlzcC9ib29rbWFyay5lbAorKysgYi9saXNwL2Jvb2ttYXJrLmVsCkBAIC0zMiw2ICszMiw3 IEBACiA7OzsgQ29kZToKIAogKHJlcXVpcmUgJ3BwKQorKHJlcXVpcmUgJ3RleHQtcHJvcGVydHkt c2VhcmNoKQogKGV2YWwtd2hlbi1jb21waWxlIChyZXF1aXJlICdjbC1saWIpKQogCiA7OzsgTWlz YyBjb21tZW50czoKQEAgLTEyMiw2ICsxMjMsOSBAQCBib29rbWFyay1hdXRvbWF0aWNhbGx5LXNo b3ctYW5ub3RhdGlvbnMKICAgIk5vbi1uaWwgbWVhbnMgc2hvdyBhbm5vdGF0aW9ucyB3aGVuIGp1 bXBpbmcgdG8gYSBib29rbWFyay4iCiAgIDp0eXBlICdib29sZWFuKQogCisoZGVmY29uc3QgYm9v a21hcmstYm1lbnUtYnVmZmVyICIqQm9va21hcmsgTGlzdCoiCisgICJOYW1lIG9mIGJ1ZmZlciB1 c2VkIGZvciBCb29rbWFyayBMaXN0LiIpCisKIChkZWZjdXN0b20gYm9va21hcmstYm1lbnUtdXNl LWhlYWRlci1saW5lIHQKICAgIk5vbi1uaWwgbWVhbnMgdG8gdXNlIGFuIGltbW92YWJsZSBoZWFk ZXIgbGluZS4KIFRoaXMgaXMgYXMgb3Bwb3NlZCB0byBpbmxpbmUgdGV4dCBhdCB0aGUgdG9wIG9m IHRoZSBidWZmZXIuIgpAQCAtODgyLDExICs4ODYsOSBAQCBib29rbWFyay1raWxsLWxpbmUKICAg ICAgIChkZWxldGUtY2hhciAxKSkpKQogCiAKLTs7IERlZnZhcnMgdG8gYXZvaWQgY29tcGlsYXRp b24gd2FybmluZ3M6CiAoZGVmdmFyIGJvb2ttYXJrLWFubm90YXRpb24tbmFtZSBuaWwKLSAgIlZh cmlhYmxlIGhvbGRpbmcgdGhlIG5hbWUgb2YgdGhlIGJvb2ttYXJrLgotVGhpcyBpcyB1c2VkIGlu IGBib29rbWFyay1lZGl0LWFubm90YXRpb24nIHRvIHJlY29yZCB0aGUgYm9va21hcmsKLXdob3Nl IGFubm90YXRpb24gaXMgYmVpbmcgZWRpdGVkLiIpCisgICJOYW1lIG9mIGJvb2ttYXJrIHdob3Nl IGFubm90YXRpb24gaXMgYmVpbmcgZWRpdGVkLgorVGhpcyBpcyB1c2VkIGJ5IGBib29rbWFyay1l ZGl0LWFubm90YXRpb24tbW9kZScuIikKIAogCiAoZGVmdW4gYm9va21hcmstZGVmYXVsdC1hbm5v dGF0aW9uLXRleHQgKGJvb2ttYXJrLW5hbWUpCkBAIC05NDcsMTIgKzk0OSwxOCBAQCBib29rbWFy ay1zZW5kLWVkaXRlZC1hbm5vdGF0aW9uCiAgICAgICAoZm9yd2FyZC1saW5lIDEpKSkKICAgOzsg VGFrZSBubyBjaGFuY2VzIHdpdGggdGV4dCBwcm9wZXJ0aWVzLgogICAobGV0ICgoYW5ub3RhdGlv biAoYnVmZmVyLXN1YnN0cmluZy1uby1wcm9wZXJ0aWVzIChwb2ludC1taW4pIChwb2ludC1tYXgp KSkKLQkoYm9va21hcmstbmFtZSBib29rbWFyay1hbm5vdGF0aW9uLW5hbWUpKQorICAgICAgICAo Ym9va21hcmstbmFtZSBib29rbWFyay1hbm5vdGF0aW9uLW5hbWUpCisgICAgICAgIChvbGQtYnVm ZmVyIChjdXJyZW50LWJ1ZmZlcikpKQogICAgIChib29rbWFyay1zZXQtYW5ub3RhdGlvbiBib29r bWFyay1uYW1lIGFubm90YXRpb24pCiAgICAgKHNldHEgYm9va21hcmstYWxpc3QtbW9kaWZpY2F0 aW9uLWNvdW50CiAgICAgICAgICAgKDErIGJvb2ttYXJrLWFsaXN0LW1vZGlmaWNhdGlvbi1jb3Vu dCkpCi0gICAgKGJvb2ttYXJrLWJtZW51LXN1cnJlcHRpdGlvdXNseS1yZWJ1aWxkLWxpc3QpKQot ICAoa2lsbC1idWZmZXIgKGN1cnJlbnQtYnVmZmVyKSkpCisgICAgKHF1aXQtd2luZG93KQorICAg IChwb3AtdG8tYnVmZmVyIChnZXQtYnVmZmVyIGJvb2ttYXJrLWJtZW51LWJ1ZmZlcikpCisgICAg KGJvb2ttYXJrLWJtZW51LWxpc3QpCisgICAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkKKyAgICAo dGV4dC1wcm9wZXJ0eS1zZWFyY2gtZm9yd2FyZCAnYm9va21hcmstbmFtZS1wcm9wIGJvb2ttYXJr LW5hbWUpCisgICAgKG1lc3NhZ2UgIkFubm90YXRpb24gdXBkYXRlZCBmb3IgXCIlc1wiIiBib29r bWFyay1uYW1lKQorICAgIChraWxsLWJ1ZmZlciBvbGQtYnVmZmVyKSkpCiAKIAogKGRlZnVuIGJv b2ttYXJrLWVkaXQtYW5ub3RhdGlvbiAoYm9va21hcmstbmFtZS1vci1yZWNvcmQpCkBAIC0xNTQ3 LDEwICsxNTU1LDkgQEAgYm9va21hcmstbG9hZAogCShwcm9ncmVzcy1yZXBvcnRlci1kb25lIHJl cG9ydGVyKSkpKSkKIAogDAotOzs7IENvZGUgc3VwcG9ydGluZyB0aGUgZGlyZWQtbGlrZSBib29r bWFyayBtZW51LgorOzs7IENvZGUgc3VwcG9ydGluZyB0aGUgZGlyZWQtbGlrZSBib29rbWFyayBs aXN0LgogOzsgUHJlZml4IGlzICJib29rbWFyay1ibWVudSIgZm9yICJidWZmZXItbWVudSI6CiAK LQogKGRlZnZhciBib29rbWFyay1ibWVudS1oaWRkZW4tYm9va21hcmtzICgpKQogCiAKQEAgLTE2 MzQsNyArMTY0MSw3IEBAIGJvb2ttYXJrLWJtZW51LW1vZGUtbWFwCiAoZGVmdW4gYm9va21hcmst Ym1lbnUtc3VycmVwdGl0aW91c2x5LXJlYnVpbGQtbGlzdCAoKQogICAiUmVidWlsZCB0aGUgQm9v a21hcmsgTGlzdCBpZiBpdCBleGlzdHMuCiBEb24ndCBhZmZlY3QgdGhlIGJ1ZmZlciByaW5nIG9y ZGVyLiIKLSAgKGlmIChnZXQtYnVmZmVyICIqQm9va21hcmsgTGlzdCoiKQorICAoaWYgKGdldC1i dWZmZXIgYm9va21hcmstYm1lbnUtYnVmZmVyKQogICAgICAgKHNhdmUtZXhjdXJzaW9uCiAgICAg ICAgIChzYXZlLXdpbmRvdy1leGN1cnNpb24KICAgICAgICAgICAoYm9va21hcmstYm1lbnUtbGlz dCkpKSkpCkBAIC0xNjQ4LDcgKzE2NTUsNyBAQCBib29rbWFyay1ibWVudS1saXN0CiBkZWxldGlv biwgb3IgPiBpZiBpdCBpcyBmbGFnZ2VkIGZvciBkaXNwbGF5aW5nLiIKICAgKGludGVyYWN0aXZl KQogICAoYm9va21hcmstbWF5YmUtbG9hZC1kZWZhdWx0LWZpbGUpCi0gIChsZXQgKChidWYgKGdl dC1idWZmZXItY3JlYXRlICIqQm9va21hcmsgTGlzdCoiKSkpCisgIChsZXQgKChidWYgKGdldC1i dWZmZXItY3JlYXRlIGJvb2ttYXJrLWJtZW51LWJ1ZmZlcikpKQogICAgIChpZiAoY2FsbGVkLWlu dGVyYWN0aXZlbHktcCAnaW50ZXJhY3RpdmUpCiAgICAgICAgIChzd2l0Y2gtdG8tYnVmZmVyIGJ1 ZikKICAgICAgIChzZXQtYnVmZmVyIGJ1ZikpKQpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2Jvb2tt YXJrLXRlc3RzLmVsIGIvdGVzdC9saXNwL2Jvb2ttYXJrLXRlc3RzLmVsCmluZGV4IDZmYTBiMWU5 OGQuLmE4Zjc1YjljNjEgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9ib29rbWFyay10ZXN0cy5lbAor KysgYi90ZXN0L2xpc3AvYm9va21hcmstdGVzdHMuZWwKQEAgLTMxMyw3ICszMTMsNDEgQEAgYm9v a21hcmstdGVzdHMtbG9hZAogICAgICAgICAgICAgICAgICAgICAobGlzdCBib29rbWFyay10ZXN0 cy1ib29rbWFyawogICAgICAgICAgICAgICAgICAgICAgICAgICAoY29ucyAibmFtZTwyPiIgKGNk ciBib29rbWFyay10ZXN0cy1ib29rbWFyaykpKSkpKSkpCiAKLTs7IFRPRE86IEFkZCB0ZXN0cyBm b3IgYm9va21hcmstYm1lbnUuCis7OyBUT0RPOiBBZGQgbW9yZSB0ZXN0cyBmb3IgYm9va21hcmst Ym1lbnUuCisKKyhkZWZtYWNybyB3aXRoLWJvb2ttYXJrLWJtZW51LXRlc3QgKCZyZXN0IGJvZHkp CisgICJDcmVhdGUgZW52aXJvbm1lbnQgZm9yIHRlc3RpbmcgYGJvb2ttYXJrLWJtZW51LWxpc3Qn IGFuZCBldmFsdWF0ZSBCT0RZLgorU2FtZSBhcyBgd2l0aC1ib29rbWFyay10ZXN0JyBidXQgd2l0 aCBhZGRpdGlvbnMgc3VpdGFibGUgZm9yCit0ZXN0aW5nIGBib29rbWFyay1ibWVudS1saXN0Jy4i CisgIGAod2l0aC1ib29rbWFyay10ZXN0CisgICAgKGxldCAoKGJvb2ttYXJrLWJtZW51LWJ1ZmZl ciAiKkJvb2ttYXJrIExpc3QgLSBUZXN0aW5nKiIpKQorICAgICAgKHVud2luZC1wcm90ZWN0Cisg ICAgICAgICAgKHNhdmUtd2luZG93LWV4Y3Vyc2lvbgorICAgICAgICAgICAgKGJvb2ttYXJrLWJt ZW51LWxpc3QpCisgICAgICAgICAgICAsQGJvZHkpCisgICAgICAgIChraWxsLWJ1ZmZlciBib29r bWFyay1ibWVudS1idWZmZXIpKSkpKQorCisoZXJ0LWRlZnRlc3QgYm9va21hcmstYmVudS1lZGl0 LWFubm90YXRpb24vc2hvdy1hbm5vdGF0aW9uICgpCisgICh3aXRoLWJvb2ttYXJrLWJtZW51LXRl c3QKKyAgIChib29rbWFyay1zZXQtYW5ub3RhdGlvbiAibmFtZSIgImZvbyIpCisgICAoYm9va21h cmstYm1lbnUtZWRpdC1hbm5vdGF0aW9uKQorICAgKHNob3VsZCAoc3RyaW5nLW1hdGNoICJmb28i IChidWZmZXItc3RyaW5nKSkpKSkKKworKGVydC1kZWZ0ZXN0IGJvb2ttYXJrLWJtZW51LXNlbmQt ZWRpdGVkLWFubm90YXRpb24gKCkKKyAgKHdpdGgtYm9va21hcmstYm1lbnUtdGVzdAorICAgKGJv b2ttYXJrLWJtZW51LWVkaXQtYW5ub3RhdGlvbikKKyAgIChpbnNlcnQgImZvbyIpCisgICAoYm9v a21hcmstc2VuZC1lZGl0ZWQtYW5ub3RhdGlvbikKKyAgIChzaG91bGQgKGVxdWFsIChib29rbWFy ay1nZXQtYW5ub3RhdGlvbiAibmFtZSIpICJmb28iKSkpKQorCisoZXJ0LWRlZnRlc3QgYm9va21h cmstYm1lbnUtc2VuZC1lZGl0ZWQtYW5ub3RhdGlvbi9yZXN0b3JlLWZvY3VzICgpCisgICJUZXN0 IGZvciBodHRwczovL2RlYmJ1Z3MuZ251Lm9yZy8yMDE1MCAuIgorICAod2l0aC1ib29rbWFyay1i bWVudS10ZXN0CisgICAoYm9va21hcmstYm1lbnUtZWRpdC1hbm5vdGF0aW9uKQorICAgKGluc2Vy dCAiZm9vIikKKyAgIChib29rbWFyay1zZW5kLWVkaXRlZC1hbm5vdGF0aW9uKQorICAgKHNob3Vs ZCAoZXF1YWwgKGJ1ZmZlci1uYW1lIChjdXJyZW50LWJ1ZmZlcikpIGJvb2ttYXJrLWJtZW51LWJ1 ZmZlcikpCisgICAoc2hvdWxkIChsb29raW5nLWF0ICJuYW1lIikpKSkKIAogKHByb3ZpZGUgJ2Jv b2ttYXJrLXRlc3RzKQogOzs7IGJvb2ttYXJrLXRlc3RzLmVsIGVuZHMgaGVyZQotLSAKMi4yMS4w Cgo= --000000000000201e87058ccc637b-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 04 15:20:40 2019 Received: (at 20150) by debbugs.gnu.org; 4 Jul 2019 19:20:40 +0000 Received: from localhost ([127.0.0.1]:51896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hj7Hb-0004UD-OG for submit@debbugs.gnu.org; Thu, 04 Jul 2019 15:20:40 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:55760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hj7HZ-0004Tv-TF for 20150@debbugs.gnu.org; Thu, 04 Jul 2019 15:20:38 -0400 Received: by mail-wm1-f43.google.com with SMTP id a15so6659124wmj.5 for <20150@debbugs.gnu.org>; Thu, 04 Jul 2019 12:20:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H3JREPaRUdjkw77dM0PFV/w/f2WtorCP5sbxvrDRvN8=; b=axlRftzY+PQ5gjuZjXCowW5wPOJxIaiQpLq+h6j1BUVnWYJTDJlfXZwVeVrU5t+EOQ hl/mFzOq5XVHb+03TJnQ9YykiD69z9R4oG0F9Ki/oJ5BfDxWxqKXcZf1mAWSRneMYt7Q 9C6Q+oqcTVnG4HWbSqK8wow0pO8jOLH5JJJx9VI/K0+F5IsKRZdNk+vvwSY38UYgqzxB QdzcvxFHJb4WhidypPNS5cczRx2+alXVHmkezipIe1As/EanQ9LnnuxgIoUqX7bXELSO 0a5lI86y267KOFY4LOEDOmu1oVnRYtjZD4qZm9nXew0ckWSJo06r51Cc6uR0Xo8hObk1 czTg== X-Gm-Message-State: APjAAAUMTa6R7iJvxHItiKGnHNYVj/goO33GXKwIR1k903kgtmRKcaM+ 09LfsZDyh0ystyyrA5WibNigee8nxDpgC3AY29w= X-Google-Smtp-Source: APXvYqzMLkwEIXBF6RvDCrIh+Qlonn7jHLBSztUf2AQWlBnM/qHJSotSGdVv3VBa95hyDfPTwO5Z88TcMskaG6RKrfE= X-Received: by 2002:a1c:7c08:: with SMTP id x8mr632812wmc.19.1562268032090; Thu, 04 Jul 2019 12:20:32 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Stefan Kangas Date: Thu, 4 Jul 2019 21:20:20 +0200 Message-ID: Subject: Re: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) To: Boruch Baum Content-Type: multipart/mixed; boundary="000000000000190f48058cdfdf50" X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 20150 Cc: 20150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) --000000000000190f48058cdfdf50 Content-Type: text/plain; charset="UTF-8" Stefan Kangas writes: > Now that the test suite for bookmark.el has hit master, I reworked > this to also include tests. Please find attached an updated patch. I thought about this a bit more and realized there is a problem with the fix: we can of course also edit an annotation when bookmark-use-annotations is t. In this case we would not want to return to the bookmark list. The fix will therefore have to be a bit more involved to handle both cases correctly. I have attached a fourth (and hopefully final) patch here. I also ran into a suspected bug in with-current-buffer (Bug#36497). I added a FIXME in one of the test cases so we can clean it up once that's fixed. This is my first patch with this many changes, and I did my best to document it thoroughly. Not sure if we like that or prefer something more terse. Comments would be much appreciated. Thanks, Stefan Kangas --000000000000190f48058cdfdf50 Content-Type: application/octet-stream; name="0001-Restore-focus-to-Bookmark-List-after-editing-annotat-4.patch" Content-Disposition: attachment; filename="0001-Restore-focus-to-Bookmark-List-after-editing-annotat-4.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxp20oaj0 RnJvbSBmNjMyYjA0OWU2MDM3YzliZWI0MGYwNTkyN2YyNGQ3ZmU2NDE0NDMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUdWUsIDIgSnVsIDIwMTkgMDM6MDY6MzcgKzAyMDAKU3ViamVjdDogW1BBVENIXSBS ZXN0b3JlIGZvY3VzIHRvIEJvb2ttYXJrIExpc3QgYWZ0ZXIgZWRpdGluZyBhbm5vdGF0aW9uCgpU aGVyZSBhcmUgdHdvIGVudHJ5IHBvaW50cyB0byBib29rbWFyay1lZGl0LWFubm90YXRpb24tbW9k ZTogdGhlIGZpcnN0CndoZW4gd2UgYWRkIGEgYm9va21hcmsgYW5kIGJvb2ttYXJrLXVzZS1hbm5v dGF0aW9ucyBpcyBub24tbmlsOyB0aGUKc2Vjb25kIHdoZW4gYm9va21hcmstYm1lbnUtZWRpdC1h bm5vdGF0aW9uIGlzIHJ1biBmcm9tIHRoZSBib29rbWFyawpsaXN0LiAgV2hlbiBlZGl0aW5nIGlz IGNvbmNsdWRlZCwgaW4gdGhlIGZpcnN0IGNhc2UsIHdlIHNob3VsZCBqdXN0CnF1aXQgd2luZG93 LiAgSW4gdGhlIHNlY29uZCBjYXNlLCB3ZSBzaG91bGQgaW5zdGVhZCByZXR1cm4gdG8gdGhlCmJv b2ttYXJrIGxpc3QuCgoqIGxpc3AvYm9va21hcmsuZWwgKHRleHQtcHJvcGVydHktc2VhcmNoKTog UmVxdWlyZS4KKGJvb2ttYXJrLWFubm90YXRpb24tLW5hbWUpOiBSZW5hbWUgZnJvbSBib29rbWFy ay1hbm5vdGF0aW9uLW5hbWUsCm1ha2UgYnVmZmVyLWxvY2FsIGFuZCBpbXByb3ZlIGRvYyBzdHJp bmcuCihib29rbWFyay1hbm5vdGF0aW9uLW5hbWUpOiBNYXJrIGFzIG9ic29sZXRlIHZhcmlhYmxl IGFsaWFzIGZvcgpib29rbWFyay1hbm5vdGF0aW9uLS1uYW1lLgooYm9va21hcmstYW5ub3RhdGlv bi0tZnJvbS1ib29rbWFyay1saXN0KTogTmV3IGJ1ZmZlci1sb2NhbCB2YXJpYWJsZS4KKGJvb2tt YXJrLWVkaXQtYW5ub3RhdGlvbik6IFVzZSBhYm92ZSByZW5hbWVkIHZhcmlhYmxlLiAgTmV3IGFy Z3VtZW50CmZyb20tYm9va21hcmstbGlzdCBzZXRzIGJvb2ttYXJrLWFubm90YXRpb24tLWZyb20t Ym9va21hcmstbGlzdC4KKGJvb2ttYXJrLWJtZW51LWVkaXQtYW5ub3RhdGlvbik6IENhbGwgYm9v a21hcmstZWRpdC1hbm5vdGF0aW9uIHdpdGgKYXJndW1lbnQgZnJvbS1ib29rbWFyay1saXN0IHNl dCB0byB0LgooYm9va21hcmstc2VuZC1lZGl0ZWQtYW5ub3RhdGlvbik6IFdoZW4gZWRpdGluZyBv cmlnaW5hdGVkIGluIHRoZQpib29rbWFyayBsaXN0LCByZXN0b3JlIGZvY3VzIHRvIGJvb2ttYXJr IGxpc3QgYW5kIG1vdmUgcG9pbnQgYmFjayB0bwplZGl0ZWQgYm9va21hcmsuIChCdWcjMjAxNTAp CgooYm9va21hcmstZWRpdC1hbm5vdGF0aW9uLW1vZGUpOiBGaXggdHlwby4KKGJvb2ttYXJrLWJt ZW51LWJ1ZmZlcik6IE5ldyB2YXJpYWJsZS4KKGJvb2ttYXJrLWJtZW51LXN1cnJlcHRpdGlvdXNs eS1yZWJ1aWxkLWxpc3QpCihib29rbWFyay1ibWVudS1saXN0KTogVXNlIGl0LgoKKiB0ZXN0L2xp c3AvYm9va21hcmstdGVzdHMuZWwgKHdpdGgtYm9va21hcmstYm1lbnUtdGVzdCk6IE5ldyBtYWNy by4KKGJvb2ttYXJrLXRlc3RzLXNldC9ib29rbWFyay11c2UtYW5ub3RhdGlvbnMtdCkKKGJvb2tt YXJrLWJtZW51LWVkaXQtYW5ub3RhdGlvbi9zaG93LWFubm90YXRpb24pCihib29rbWFyay1ibWVu dS1zZW5kLWVkaXRlZC1hbm5vdGF0aW9uKQooYm9va21hcmstYm1lbnUtc2VuZC1lZGl0ZWQtYW5u b3RhdGlvbi9yZXN0b3JlLWZvY3VzKTogTmV3IHRlc3QgY2FzZXMuCi0tLQogbGlzcC9ib29rbWFy ay5lbCAgICAgICAgICAgIHwgNTMgKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0t LQogdGVzdC9saXNwL2Jvb2ttYXJrLXRlc3RzLmVsIHwgNTAgKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrLQogMiBmaWxlcyBjaGFuZ2VkLCA4MyBpbnNlcnRpb25zKCspLCAyMCBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2Jvb2ttYXJrLmVsIGIvbGlzcC9ib29rbWFyay5l bAppbmRleCA5MmQwZGEzNTk0Li45MzUxYTkwMTJjIDEwMDY0NAotLS0gYS9saXNwL2Jvb2ttYXJr LmVsCisrKyBiL2xpc3AvYm9va21hcmsuZWwKQEAgLTMyLDYgKzMyLDcgQEAKIDs7OyBDb2RlOgog CiAocmVxdWlyZSAncHApCisocmVxdWlyZSAndGV4dC1wcm9wZXJ0eS1zZWFyY2gpCiAoZXZhbC13 aGVuLWNvbXBpbGUgKHJlcXVpcmUgJ2NsLWxpYikpCiAKIDs7OyBNaXNjIGNvbW1lbnRzOgpAQCAt MTIyLDYgKzEyMyw5IEBAIGJvb2ttYXJrLWF1dG9tYXRpY2FsbHktc2hvdy1hbm5vdGF0aW9ucwog ICAiTm9uLW5pbCBtZWFucyBzaG93IGFubm90YXRpb25zIHdoZW4ganVtcGluZyB0byBhIGJvb2tt YXJrLiIKICAgOnR5cGUgJ2Jvb2xlYW4pCiAKKyhkZWZjb25zdCBib29rbWFyay1ibWVudS1idWZm ZXIgIipCb29rbWFyayBMaXN0KiIKKyAgIk5hbWUgb2YgYnVmZmVyIHVzZWQgZm9yIEJvb2ttYXJr IExpc3QuIikKKwogKGRlZmN1c3RvbSBib29rbWFyay1ibWVudS11c2UtaGVhZGVyLWxpbmUgdAog ICAiTm9uLW5pbCBtZWFucyB0byB1c2UgYW4gaW1tb3ZhYmxlIGhlYWRlciBsaW5lLgogVGhpcyBp cyBhcyBvcHBvc2VkIHRvIGlubGluZSB0ZXh0IGF0IHRoZSB0b3Agb2YgdGhlIGJ1ZmZlci4iCkBA IC04ODEsMTMgKzg4NSwxNSBAQCBib29rbWFyay1raWxsLWxpbmUKICAgICAod2hlbiAoYW5kIG5l d2xpbmUtdG9vICg9IChmb2xsb3dpbmctY2hhcikgP1xuKSkKICAgICAgIChkZWxldGUtY2hhciAx KSkpKQogCisoZGVmaW5lLW9ic29sZXRlLXZhcmlhYmxlLWFsaWFzICdib29rbWFyay1hbm5vdGF0 aW9uLW5hbWUKKyAgJ2Jvb2ttYXJrLWFubm90YXRpb24tLW5hbWUgIjI3LjEiKQorKGRlZnZhciBi b29rbWFyay1hbm5vdGF0aW9uLS1uYW1lIG5pbAorICAiTmFtZSBvZiBib29rbWFyayB1bmRlciBl ZGl0IGluIGBib29rbWFyay1lZGl0LWFubm90YXRpb24tbW9kZScuIikKKyhtYWtlLXZhcmlhYmxl LWJ1ZmZlci1sb2NhbCAnYm9va21hcmstYW5ub3RhdGlvbi0tbmFtZSkKIAotOzsgRGVmdmFycyB0 byBhdm9pZCBjb21waWxhdGlvbiB3YXJuaW5nczoKLShkZWZ2YXIgYm9va21hcmstYW5ub3RhdGlv bi1uYW1lIG5pbAotICAiVmFyaWFibGUgaG9sZGluZyB0aGUgbmFtZSBvZiB0aGUgYm9va21hcmsu Ci1UaGlzIGlzIHVzZWQgaW4gYGJvb2ttYXJrLWVkaXQtYW5ub3RhdGlvbicgdG8gcmVjb3JkIHRo ZSBib29rbWFyawotd2hvc2UgYW5ub3RhdGlvbiBpcyBiZWluZyBlZGl0ZWQuIikKLQorKGRlZnZh ciBib29rbWFyay1hbm5vdGF0aW9uLS1mcm9tLWJvb2ttYXJrLWxpc3QgbmlsCisgICJJZiBub24t bmlsLCByZXR1cm4gdG8gYm9va21hcmsgbGlzdCBmcm9tIGBib29rbWFyay1lZGl0LWFubm90YXRp b24tbW9kZScuIikKKyhtYWtlLXZhcmlhYmxlLWJ1ZmZlci1sb2NhbCAnYm9va21hcmstYW5ub3Rh dGlvbi0tZnJvbS1ib29rbWFyay1saXN0KQogCiAoZGVmdW4gYm9va21hcmstZGVmYXVsdC1hbm5v dGF0aW9uLXRleHQgKGJvb2ttYXJrLW5hbWUpCiAgICJSZXR1cm4gZGVmYXVsdCBhbm5vdGF0aW9u IHRleHQgZm9yIEJPT0tNQVJLLU5BTUUuCkBAIC05MjksNyArOTM1LDcgQEAgYm9va21hcmstaW5z ZXJ0LWFubm90YXRpb24KIChkZWZpbmUtZGVyaXZlZC1tb2RlIGJvb2ttYXJrLWVkaXQtYW5ub3Rh dGlvbi1tb2RlCiAgIHRleHQtbW9kZSAiRWRpdCBCb29rbWFyayBBbm5vdGF0aW9uIgogICAiTW9k ZSBmb3IgZWRpdGluZyB0aGUgYW5ub3RhdGlvbiBvZiBib29rbWFya3MuCi1XaGVuIHlvdSBoYXZl IGZpbmlzaGVkIGNvbXBvc2luZywgdHlwZSBcXFtib29rbWFyay1zZW5kLWFubm90YXRpb25dLgor V2hlbiB5b3UgaGF2ZSBmaW5pc2hlZCBjb21wb3NpbmcsIHR5cGUgXFxbYm9va21hcmstc2VuZC1l ZGl0ZWQtYW5ub3RhdGlvbl0uCiAKIFxce2Jvb2ttYXJrLWVkaXQtYW5ub3RhdGlvbi1tb2RlLW1h cH0iKQogCkBAIC05NDcsMjEgKzk1MywzMSBAQCBib29rbWFyay1zZW5kLWVkaXRlZC1hbm5vdGF0 aW9uCiAgICAgICAoZm9yd2FyZC1saW5lIDEpKSkKICAgOzsgVGFrZSBubyBjaGFuY2VzIHdpdGgg dGV4dCBwcm9wZXJ0aWVzLgogICAobGV0ICgoYW5ub3RhdGlvbiAoYnVmZmVyLXN1YnN0cmluZy1u by1wcm9wZXJ0aWVzIChwb2ludC1taW4pIChwb2ludC1tYXgpKSkKLQkoYm9va21hcmstbmFtZSBi b29rbWFyay1hbm5vdGF0aW9uLW5hbWUpKQorICAgICAgICAoYm9va21hcmstbmFtZSBib29rbWFy ay1hbm5vdGF0aW9uLS1uYW1lKQorICAgICAgICAoZnJvbS1ib29rbWFyay1saXN0IGJvb2ttYXJr LWFubm90YXRpb24tLWZyb20tYm9va21hcmstbGlzdCkKKyAgICAgICAgKG9sZC1idWZmZXIgKGN1 cnJlbnQtYnVmZmVyKSkpCiAgICAgKGJvb2ttYXJrLXNldC1hbm5vdGF0aW9uIGJvb2ttYXJrLW5h bWUgYW5ub3RhdGlvbikKICAgICAoc2V0cSBib29rbWFyay1hbGlzdC1tb2RpZmljYXRpb24tY291 bnQKICAgICAgICAgICAoMSsgYm9va21hcmstYWxpc3QtbW9kaWZpY2F0aW9uLWNvdW50KSkKLSAg ICAoYm9va21hcmstYm1lbnUtc3VycmVwdGl0aW91c2x5LXJlYnVpbGQtbGlzdCkpCi0gIChraWxs LWJ1ZmZlciAoY3VycmVudC1idWZmZXIpKSkKKyAgICAobWVzc2FnZSAiQW5ub3RhdGlvbiB1cGRh dGVkIGZvciBcIiVzXCIiIGJvb2ttYXJrLW5hbWUpCisgICAgKHF1aXQtd2luZG93KQorICAgIChi b29rbWFyay1ibWVudS1zdXJyZXB0aXRpb3VzbHktcmVidWlsZC1saXN0KQorICAgICh3aGVuIGZy b20tYm9va21hcmstbGlzdAorICAgICAgKHBvcC10by1idWZmZXIgKGdldC1idWZmZXIgYm9va21h cmstYm1lbnUtYnVmZmVyKSkKKyAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikpCisgICAgICAo dGV4dC1wcm9wZXJ0eS1zZWFyY2gtZm9yd2FyZCAnYm9va21hcmstbmFtZS1wcm9wIGJvb2ttYXJr LW5hbWUpKQorICAgIChraWxsLWJ1ZmZlciBvbGQtYnVmZmVyKSkpCiAKIAotKGRlZnVuIGJvb2tt YXJrLWVkaXQtYW5ub3RhdGlvbiAoYm9va21hcmstbmFtZS1vci1yZWNvcmQpCi0gICJQb3AgdXAg YSBidWZmZXIgZm9yIGVkaXRpbmcgYm9va21hcmsgQk9PS01BUkstTkFNRS1PUi1SRUNPUkQncyBh bm5vdGF0aW9uLiIKKyhkZWZ1biBib29rbWFyay1lZGl0LWFubm90YXRpb24gKGJvb2ttYXJrLW5h bWUtb3ItcmVjb3JkICZvcHRpb25hbCBmcm9tLWJvb2ttYXJrLWxpc3QpCisgICJQb3AgdXAgYSBi dWZmZXIgZm9yIGVkaXRpbmcgYm9va21hcmsgQk9PS01BUkstTkFNRS1PUi1SRUNPUkQncyBhbm5v dGF0aW9uLgorSWYgb3B0aW9uYWwgYXJndW1lbnQgRlJPTS1CT09LTUFSSy1MSVNUIGlzIG5vbi1u aWwsIHJldHVybiB0byB0aGUKK2Jvb2ttYXJrIGxpc3Qgd2hlbiBlZGl0aW5nIGlzIGRvbmUuIgog ICAocG9wLXRvLWJ1ZmZlciAoZ2VuZXJhdGUtbmV3LWJ1ZmZlci1uYW1lICIqQm9va21hcmsgQW5u b3RhdGlvbiBDb21wb3NlKiIpKQogICAoYm9va21hcmstaW5zZXJ0LWFubm90YXRpb24gYm9va21h cmstbmFtZS1vci1yZWNvcmQpCiAgIChib29rbWFyay1lZGl0LWFubm90YXRpb24tbW9kZSkKLSAg KHNldCAobWFrZS1sb2NhbC12YXJpYWJsZSAnYm9va21hcmstYW5ub3RhdGlvbi1uYW1lKQotICAg ICAgIGJvb2ttYXJrLW5hbWUtb3ItcmVjb3JkKSkKKyAgKHNldHEgYm9va21hcmstYW5ub3RhdGlv bi0tZnJvbS1ib29rbWFyay1saXN0IGZyb20tYm9va21hcmstbGlzdCkKKyAgKHNldHEgYm9va21h cmstYW5ub3RhdGlvbi0tbmFtZSBib29rbWFyay1uYW1lLW9yLXJlY29yZCkpCiAKIAogKGRlZnVu IGJvb2ttYXJrLWJ1ZmZlci1uYW1lICgpCkBAIC0xNTQ3LDEwICsxNTYzLDkgQEAgYm9va21hcmst bG9hZAogCShwcm9ncmVzcy1yZXBvcnRlci1kb25lIHJlcG9ydGVyKSkpKSkKIAogDAotOzs7IENv ZGUgc3VwcG9ydGluZyB0aGUgZGlyZWQtbGlrZSBib29rbWFyayBtZW51LgorOzs7IENvZGUgc3Vw cG9ydGluZyB0aGUgZGlyZWQtbGlrZSBib29rbWFyayBsaXN0LgogOzsgUHJlZml4IGlzICJib29r bWFyay1ibWVudSIgZm9yICJidWZmZXItbWVudSI6CiAKLQogKGRlZnZhciBib29rbWFyay1ibWVu dS1oaWRkZW4tYm9va21hcmtzICgpKQogCiAKQEAgLTE2MzQsNyArMTY0OSw3IEBAIGJvb2ttYXJr LWJtZW51LW1vZGUtbWFwCiAoZGVmdW4gYm9va21hcmstYm1lbnUtc3VycmVwdGl0aW91c2x5LXJl YnVpbGQtbGlzdCAoKQogICAiUmVidWlsZCB0aGUgQm9va21hcmsgTGlzdCBpZiBpdCBleGlzdHMu CiBEb24ndCBhZmZlY3QgdGhlIGJ1ZmZlciByaW5nIG9yZGVyLiIKLSAgKGlmIChnZXQtYnVmZmVy ICIqQm9va21hcmsgTGlzdCoiKQorICAoaWYgKGdldC1idWZmZXIgYm9va21hcmstYm1lbnUtYnVm ZmVyKQogICAgICAgKHNhdmUtZXhjdXJzaW9uCiAgICAgICAgIChzYXZlLXdpbmRvdy1leGN1cnNp b24KICAgICAgICAgICAoYm9va21hcmstYm1lbnUtbGlzdCkpKSkpCkBAIC0xNjQ4LDcgKzE2NjMs NyBAQCBib29rbWFyay1ibWVudS1saXN0CiBkZWxldGlvbiwgb3IgPiBpZiBpdCBpcyBmbGFnZ2Vk IGZvciBkaXNwbGF5aW5nLiIKICAgKGludGVyYWN0aXZlKQogICAoYm9va21hcmstbWF5YmUtbG9h ZC1kZWZhdWx0LWZpbGUpCi0gIChsZXQgKChidWYgKGdldC1idWZmZXItY3JlYXRlICIqQm9va21h cmsgTGlzdCoiKSkpCisgIChsZXQgKChidWYgKGdldC1idWZmZXItY3JlYXRlIGJvb2ttYXJrLWJt ZW51LWJ1ZmZlcikpKQogICAgIChpZiAoY2FsbGVkLWludGVyYWN0aXZlbHktcCAnaW50ZXJhY3Rp dmUpCiAgICAgICAgIChzd2l0Y2gtdG8tYnVmZmVyIGJ1ZikKICAgICAgIChzZXQtYnVmZmVyIGJ1 ZikpKQpAQCAtMjA1MSw3ICsyMDY2LDcgQEAgYm9va21hcmstYm1lbnUtZWRpdC1hbm5vdGF0aW9u CiAgICJFZGl0IHRoZSBhbm5vdGF0aW9uIGZvciB0aGUgY3VycmVudCBib29rbWFyayBpbiBhbm90 aGVyIHdpbmRvdy4iCiAgIChpbnRlcmFjdGl2ZSkKICAgKGxldCAoKGJvb2ttYXJrIChib29rbWFy ay1ibWVudS1ib29rbWFyaykpKQotICAgIChib29rbWFyay1lZGl0LWFubm90YXRpb24gYm9va21h cmspKSkKKyAgICAoYm9va21hcmstZWRpdC1hbm5vdGF0aW9uIGJvb2ttYXJrIHQpKSkKIAogCiAo ZGVmdW4gYm9va21hcmstYm1lbnUtdW5tYXJrICgmb3B0aW9uYWwgYmFja3VwKQpkaWZmIC0tZ2l0 IGEvdGVzdC9saXNwL2Jvb2ttYXJrLXRlc3RzLmVsIGIvdGVzdC9saXNwL2Jvb2ttYXJrLXRlc3Rz LmVsCmluZGV4IDZmYTBiMWU5OGQuLmM3Mzg5ZjM2NDMgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9i b29rbWFyay10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvYm9va21hcmstdGVzdHMuZWwKQEAgLTE4 Niw2ICsxODYsMTkgQEAgYm9va21hcmstdGVzdHMtc2V0CiAgICAgICAgOzsgMy4gYm9va21hcmst c2V0LWludGVybmFsCiAgICAgICAgKHNob3VsZC1lcnJvciAoYm9va21hcmstc2V0LWludGVybmFs ICJmb28iICJiYXIiIHQpKSkpKSkKIAorKGVydC1kZWZ0ZXN0IGJvb2ttYXJrLXRlc3RzLXNldC9i b29rbWFyay11c2UtYW5ub3RhdGlvbnMtdCAoKQorICAod2l0aC1ib29rbWFyay10ZXN0LWZpbGUK KyAgIChsZXQgKChib29rbWFyay11c2UtYW5ub3RhdGlvbnMgdCkpCisgICAgIDs7IEZJWE1FOiBD YW4ndCB1c2Ugd2l0aC1jdXJyZW50LWJ1ZmZlciBkdWUgdG8gQnVnIzM2NDk3LgorICAgICAoc2F2 ZS13aW5kb3ctZXhjdXJzaW9uCisgICAgICAgKHN3aXRjaC10by1idWZmZXIgYnVmZmVyKQorICAg ICAgIDs7IFNob3VsZCBqdW1wIHRvIGVkaXQgYW5ub3RhdGlvbiBidWZmZXIKKyAgICAgICAoYm9v a21hcmstc2V0ICJmb28iKQorICAgICAgIChzaG91bGQgKGVxdWFsIG1ham9yLW1vZGUgJ2Jvb2tt YXJrLWVkaXQtYW5ub3RhdGlvbi1tb2RlKSkKKyAgICAgICA7OyBTaG91bGQgcmV0dXJuIHRvIHRo ZSBvcmlnaW5hbCBidWZmZXIKKyAgICAgICAoYm9va21hcmstc2VuZC1lZGl0ZWQtYW5ub3RhdGlv bikKKyAgICAgICAoc2hvdWxkIChlcXVhbCAoY3VycmVudC1idWZmZXIpIGJ1ZmZlcikpKSkpKQor CiAoZXJ0LWRlZnRlc3QgYm9va21hcmstdGVzdHMta2lsbC1saW5lICgpCiAgICh3aXRoLXRlbXAt YnVmZmVyCiAgICAgKGluc2VydCAiZm9vYmFyXG4iKQpAQCAtMzEzLDcgKzMyNiw0MiBAQCBib29r bWFyay10ZXN0cy1sb2FkCiAgICAgICAgICAgICAgICAgICAgIChsaXN0IGJvb2ttYXJrLXRlc3Rz LWJvb2ttYXJrCiAgICAgICAgICAgICAgICAgICAgICAgICAgIChjb25zICJuYW1lPDI+IiAoY2Ry IGJvb2ttYXJrLXRlc3RzLWJvb2ttYXJrKSkpKSkpKSkKIAotOzsgVE9ETzogQWRkIHRlc3RzIGZv ciBib29rbWFyay1ibWVudS4KKzs7IFRPRE86IEFkZCBtb3JlIHRlc3RzIGZvciBib29rbWFyay1i bWVudS4KKworKGRlZm1hY3JvIHdpdGgtYm9va21hcmstYm1lbnUtdGVzdCAoJnJlc3QgYm9keSkK KyAgIkNyZWF0ZSBlbnZpcm9ubWVudCBmb3IgdGVzdGluZyBgYm9va21hcmstYm1lbnUtbGlzdCcg YW5kIGV2YWx1YXRlIEJPRFkuCitTYW1lIGFzIGB3aXRoLWJvb2ttYXJrLXRlc3QnIGJ1dCB3aXRo IGFkZGl0aW9ucyBzdWl0YWJsZSBmb3IKK3Rlc3RpbmcgYGJvb2ttYXJrLWJtZW51LWxpc3QnLiIK KyAgYCh3aXRoLWJvb2ttYXJrLXRlc3QKKyAgICAobGV0ICgoYm9va21hcmstYm1lbnUtYnVmZmVy ICIqQm9va21hcmsgTGlzdCAtIFRlc3RpbmcqIikpCisgICAgICAodW53aW5kLXByb3RlY3QKKyAg ICAgICAgICAoc2F2ZS13aW5kb3ctZXhjdXJzaW9uCisgICAgICAgICAgICAoYm9va21hcmstYm1l bnUtbGlzdCkKKyAgICAgICAgICAgICxAYm9keSkKKyAgICAgICAgKGtpbGwtYnVmZmVyIGJvb2tt YXJrLWJtZW51LWJ1ZmZlcikpKSkpCisKKyhlcnQtZGVmdGVzdCBib29rbWFyay1ibWVudS5lbnUt ZWRpdC1hbm5vdGF0aW9uL3Nob3ctYW5ub3RhdGlvbiAoKQorICAod2l0aC1ib29rbWFyay1ibWVu dS10ZXN0CisgICAoYm9va21hcmstc2V0LWFubm90YXRpb24gIm5hbWUiICJmb28iKQorICAgKGJv b2ttYXJrLWJtZW51LWVkaXQtYW5ub3RhdGlvbikKKyAgIChzaG91bGQgKHN0cmluZy1tYXRjaCAi Zm9vIiAoYnVmZmVyLXN0cmluZykpKQorICAgKGtpbGwtYnVmZmVyIChjdXJyZW50LWJ1ZmZlcikp KSkKKworKGVydC1kZWZ0ZXN0IGJvb2ttYXJrLWJtZW51LXNlbmQtZWRpdGVkLWFubm90YXRpb24g KCkKKyAgKHdpdGgtYm9va21hcmstYm1lbnUtdGVzdAorICAgKGJvb2ttYXJrLWJtZW51LWVkaXQt YW5ub3RhdGlvbikKKyAgIChpbnNlcnQgImZvbyIpCisgICAoYm9va21hcmstc2VuZC1lZGl0ZWQt YW5ub3RhdGlvbikKKyAgIChzaG91bGQgKGVxdWFsIChib29rbWFyay1nZXQtYW5ub3RhdGlvbiAi bmFtZSIpICJmb28iKSkpKQorCisoZXJ0LWRlZnRlc3QgYm9va21hcmstYm1lbnUtc2VuZC1lZGl0 ZWQtYW5ub3RhdGlvbi9yZXN0b3JlLWZvY3VzICgpCisgICJUZXN0IGZvciBodHRwczovL2RlYmJ1 Z3MuZ251Lm9yZy8yMDE1MCAuIgorICAod2l0aC1ib29rbWFyay1ibWVudS10ZXN0CisgICAoYm9v a21hcmstYm1lbnUtZWRpdC1hbm5vdGF0aW9uKQorICAgKGluc2VydCAiZm9vIikKKyAgIChib29r bWFyay1zZW5kLWVkaXRlZC1hbm5vdGF0aW9uKQorICAgKHNob3VsZCAoZXF1YWwgKGJ1ZmZlci1u YW1lIChjdXJyZW50LWJ1ZmZlcikpIGJvb2ttYXJrLWJtZW51LWJ1ZmZlcikpCisgICAoc2hvdWxk IChsb29raW5nLWF0ICJuYW1lIikpKSkKIAogKHByb3ZpZGUgJ2Jvb2ttYXJrLXRlc3RzKQogOzs7 IGJvb2ttYXJrLXRlc3RzLmVsIGVuZHMgaGVyZQotLSAKMi4yMS4wCgo= --000000000000190f48058cdfdf50-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 04 15:41:06 2019 Received: (at 20150) by debbugs.gnu.org; 4 Jul 2019 19:41:06 +0000 Received: from localhost ([127.0.0.1]:51948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hj7bO-00055y-5O for submit@debbugs.gnu.org; Thu, 04 Jul 2019 15:41:06 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:55256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hj7bL-00054v-8h for 20150@debbugs.gnu.org; Thu, 04 Jul 2019 15:41:04 -0400 Received: by mail-wm1-f66.google.com with SMTP id p74so3666227wme.4 for <20150@debbugs.gnu.org>; Thu, 04 Jul 2019 12:41:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:cc; bh=ylC90EuMy4MvG5HPExKeCRUoNPAbgaUnEbfXCRGGAUE=; b=LK/DlYnvWNpbutd9OZLoGwsccm/dBZmtmETkZj2abcDODCav/UDairt6/o5Y2ul/US 6CcWAKrUr/YjdV4f38WzV5U03O2uvBFbvkn7kvzm+/Z3rOsyeBBDc2Fs+JeVKOBtBro1 oOE4nSAOmTVWcjEJvck49KFnOybFkmrzyqgB+7XWm0oh8VNNc7IrbOuM0wYlDQl5XmHM /457cb1PSU7Sa4B32N3q6qeChvUQEc1mGzKfbNDxvT5CX45GWeEV95+x4cR71dcWm7v/ IMI5uICq79Nd0gchuim2r8QBgasEdGihgMs58vWIOfkBkm2QjyyKu71UhGomK1lEXHCi 0OGg== X-Gm-Message-State: APjAAAV564Nurc2K7yYp4htfv1BQzFDDm9Oa3SQ8t0q4D+6nrIAkHSCk 4icNiHainmVM38Zp7Cl0H5mUbiUIMyqKz8dIuY4KPW4x X-Google-Smtp-Source: APXvYqzvRPh7h0gV8oEFR+vaVn7QJW+W87LCgLmzqsDNlBSnpY6JDmUFYMZ9TFo1EwTaXMRE9YFcsXEYJhRGHG5by9Y= X-Received: by 2002:a1c:7c08:: with SMTP id x8mr668067wmc.19.1562269257071; Thu, 04 Jul 2019 12:40:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Stefan Kangas Date: Thu, 4 Jul 2019 21:40:45 +0200 Message-ID: Subject: Re: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) Content-Type: multipart/mixed; boundary="0000000000001cbf42058ce0287d" X-Spam-Score: 2.8 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Stefan Kangas writes: > I also ran into a suspected bug in with-current-buffer (Bug#36497). I > added a FIXME in one of the test cases so we can clean it up once > that's fixed. Turns out this was not a bug, but only my own confusion. Gmail had helpfully put the reply to the bug report in the spam folder, so I only realized *after* I sent this email that it had been replied t [...] Content analysis details: (2.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: marxist.se] -0.0 SPF_PASS SPF: sender matches SPF record 1.2 MISSING_HEADERS Missing To: header 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.66 listed in list.dnswl.org] 0.1 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 0.0 T_PDS_NO_HELO_DNS High profile HELO but no A record 1.5 MALFORMED_FREEMAIL Bad headers on message from free email service X-Debbugs-Envelope-To: 20150 Cc: 20150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Stefan Kangas writes: > I also ran into a suspected bug in with-current-buffer (Bug#36497). I > added a FIXME in one of the test cases so we can clean it up once > that's fixed. Turns out this was not a bug, but only my own confusion. Gmail had helpfully put the reply to the bug report in the spam folder, so I only realized *after* I sent this email that it had been replied t [...] Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: marxist.se] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.66 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 1.2 MISSING_HEADERS Missing To: header 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.1 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 0.0 T_PDS_NO_HELO_DNS High profile HELO but no A record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 1.5 MALFORMED_FREEMAIL Bad headers on message from free email service --0000000000001cbf42058ce0287d Content-Type: text/plain; charset="UTF-8" Stefan Kangas writes: > I also ran into a suspected bug in with-current-buffer (Bug#36497). I > added a FIXME in one of the test cases so we can clean it up once > that's fixed. Turns out this was not a bug, but only my own confusion. Gmail had helpfully put the reply to the bug report in the spam folder, so I only realized *after* I sent this email that it had been replied to hours ago. I've attached an updated patch without this FIXME. Other than that, it's identical. Thanks, Stefan Kangas --0000000000001cbf42058ce0287d Content-Type: application/octet-stream; name="0001-Restore-focus-to-Bookmark-List-after-editing-annotat-5.patch" Content-Disposition: attachment; filename="0001-Restore-focus-to-Bookmark-List-after-editing-annotat-5.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxp2r59x0 RnJvbSA0ZWEzYWRhY2E2ZGFiNGM2ODAzOTkyNDUzOTJhM2RiNGM5ZDg2NWZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUdWUsIDIgSnVsIDIwMTkgMDM6MDY6MzcgKzAyMDAKU3ViamVjdDogW1BBVENIXSBS ZXN0b3JlIGZvY3VzIHRvIEJvb2ttYXJrIExpc3QgYWZ0ZXIgZWRpdGluZyBhbm5vdGF0aW9uCgpU aGVyZSBhcmUgdHdvIGVudHJ5IHBvaW50cyB0byBib29rbWFyay1lZGl0LWFubm90YXRpb24tbW9k ZTogdGhlIGZpcnN0CndoZW4gd2UgYWRkIGEgYm9va21hcmsgYW5kIGJvb2ttYXJrLXVzZS1hbm5v dGF0aW9ucyBpcyBub24tbmlsOyB0aGUKc2Vjb25kIHdoZW4gYm9va21hcmstYm1lbnUtZWRpdC1h bm5vdGF0aW9uIGlzIHJ1biBmcm9tIHRoZSBib29rbWFyawpsaXN0LiAgV2hlbiBlZGl0aW5nIGlz IGNvbmNsdWRlZCwgaW4gdGhlIGZpcnN0IGNhc2UsIHdlIHNob3VsZCBqdXN0CnF1aXQgd2luZG93 LiAgSW4gdGhlIHNlY29uZCBjYXNlLCB3ZSBzaG91bGQgaW5zdGVhZCByZXR1cm4gdG8gdGhlCmJv b2ttYXJrIGxpc3QuCgoqIGxpc3AvYm9va21hcmsuZWwgKHRleHQtcHJvcGVydHktc2VhcmNoKTog UmVxdWlyZS4KKGJvb2ttYXJrLWFubm90YXRpb24tLW5hbWUpOiBSZW5hbWUgZnJvbSBib29rbWFy ay1hbm5vdGF0aW9uLW5hbWUsCm1ha2UgYnVmZmVyLWxvY2FsIGFuZCBpbXByb3ZlIGRvYyBzdHJp bmcuCihib29rbWFyay1hbm5vdGF0aW9uLW5hbWUpOiBNYXJrIGFzIG9ic29sZXRlIHZhcmlhYmxl IGFsaWFzIGZvcgpib29rbWFyay1hbm5vdGF0aW9uLS1uYW1lLgooYm9va21hcmstYW5ub3RhdGlv bi0tZnJvbS1ib29rbWFyay1saXN0KTogTmV3IGJ1ZmZlci1sb2NhbCB2YXJpYWJsZS4KKGJvb2tt YXJrLWVkaXQtYW5ub3RhdGlvbik6IFVzZSBhYm92ZSByZW5hbWVkIHZhcmlhYmxlLiAgTmV3IGFy Z3VtZW50CmZyb20tYm9va21hcmstbGlzdCBzZXRzIGJvb2ttYXJrLWFubm90YXRpb24tLWZyb20t Ym9va21hcmstbGlzdC4KKGJvb2ttYXJrLWJtZW51LWVkaXQtYW5ub3RhdGlvbik6IENhbGwgYm9v a21hcmstZWRpdC1hbm5vdGF0aW9uIHdpdGgKYXJndW1lbnQgZnJvbS1ib29rbWFyay1saXN0IHNl dCB0byB0LgooYm9va21hcmstc2VuZC1lZGl0ZWQtYW5ub3RhdGlvbik6IFdoZW4gZWRpdGluZyBv cmlnaW5hdGVkIGluIHRoZQpib29rbWFyayBsaXN0LCByZXN0b3JlIGZvY3VzIHRvIGJvb2ttYXJr IGxpc3QgYW5kIG1vdmUgcG9pbnQgYmFjayB0bwplZGl0ZWQgYm9va21hcmsuIChCdWcjMjAxNTAp CgooYm9va21hcmstZWRpdC1hbm5vdGF0aW9uLW1vZGUpOiBGaXggdHlwby4KKGJvb2ttYXJrLWJt ZW51LWJ1ZmZlcik6IE5ldyB2YXJpYWJsZS4KKGJvb2ttYXJrLWJtZW51LXN1cnJlcHRpdGlvdXNs eS1yZWJ1aWxkLWxpc3QpCihib29rbWFyay1ibWVudS1saXN0KTogVXNlIGl0LgoKKiB0ZXN0L2xp c3AvYm9va21hcmstdGVzdHMuZWwgKHdpdGgtYm9va21hcmstYm1lbnUtdGVzdCk6IE5ldyBtYWNy by4KKGJvb2ttYXJrLXRlc3RzLXNldC9ib29rbWFyay11c2UtYW5ub3RhdGlvbnMtdCkKKGJvb2tt YXJrLWJtZW51LWVkaXQtYW5ub3RhdGlvbi9zaG93LWFubm90YXRpb24pCihib29rbWFyay1ibWVu dS1zZW5kLWVkaXRlZC1hbm5vdGF0aW9uKQooYm9va21hcmstYm1lbnUtc2VuZC1lZGl0ZWQtYW5u b3RhdGlvbi9yZXN0b3JlLWZvY3VzKTogTmV3IHRlc3QgY2FzZXMuCi0tLQogbGlzcC9ib29rbWFy ay5lbCAgICAgICAgICAgIHwgNTMgKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0t LQogdGVzdC9saXNwL2Jvb2ttYXJrLXRlc3RzLmVsIHwgNDkgKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrLQogMiBmaWxlcyBjaGFuZ2VkLCA4MiBpbnNlcnRpb25zKCspLCAyMCBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2Jvb2ttYXJrLmVsIGIvbGlzcC9ib29rbWFyay5l bAppbmRleCA5MmQwZGEzNTk0Li45MzUxYTkwMTJjIDEwMDY0NAotLS0gYS9saXNwL2Jvb2ttYXJr LmVsCisrKyBiL2xpc3AvYm9va21hcmsuZWwKQEAgLTMyLDYgKzMyLDcgQEAKIDs7OyBDb2RlOgog CiAocmVxdWlyZSAncHApCisocmVxdWlyZSAndGV4dC1wcm9wZXJ0eS1zZWFyY2gpCiAoZXZhbC13 aGVuLWNvbXBpbGUgKHJlcXVpcmUgJ2NsLWxpYikpCiAKIDs7OyBNaXNjIGNvbW1lbnRzOgpAQCAt MTIyLDYgKzEyMyw5IEBAIGJvb2ttYXJrLWF1dG9tYXRpY2FsbHktc2hvdy1hbm5vdGF0aW9ucwog ICAiTm9uLW5pbCBtZWFucyBzaG93IGFubm90YXRpb25zIHdoZW4ganVtcGluZyB0byBhIGJvb2tt YXJrLiIKICAgOnR5cGUgJ2Jvb2xlYW4pCiAKKyhkZWZjb25zdCBib29rbWFyay1ibWVudS1idWZm ZXIgIipCb29rbWFyayBMaXN0KiIKKyAgIk5hbWUgb2YgYnVmZmVyIHVzZWQgZm9yIEJvb2ttYXJr IExpc3QuIikKKwogKGRlZmN1c3RvbSBib29rbWFyay1ibWVudS11c2UtaGVhZGVyLWxpbmUgdAog ICAiTm9uLW5pbCBtZWFucyB0byB1c2UgYW4gaW1tb3ZhYmxlIGhlYWRlciBsaW5lLgogVGhpcyBp cyBhcyBvcHBvc2VkIHRvIGlubGluZSB0ZXh0IGF0IHRoZSB0b3Agb2YgdGhlIGJ1ZmZlci4iCkBA IC04ODEsMTMgKzg4NSwxNSBAQCBib29rbWFyay1raWxsLWxpbmUKICAgICAod2hlbiAoYW5kIG5l d2xpbmUtdG9vICg9IChmb2xsb3dpbmctY2hhcikgP1xuKSkKICAgICAgIChkZWxldGUtY2hhciAx KSkpKQogCisoZGVmaW5lLW9ic29sZXRlLXZhcmlhYmxlLWFsaWFzICdib29rbWFyay1hbm5vdGF0 aW9uLW5hbWUKKyAgJ2Jvb2ttYXJrLWFubm90YXRpb24tLW5hbWUgIjI3LjEiKQorKGRlZnZhciBi b29rbWFyay1hbm5vdGF0aW9uLS1uYW1lIG5pbAorICAiTmFtZSBvZiBib29rbWFyayB1bmRlciBl ZGl0IGluIGBib29rbWFyay1lZGl0LWFubm90YXRpb24tbW9kZScuIikKKyhtYWtlLXZhcmlhYmxl LWJ1ZmZlci1sb2NhbCAnYm9va21hcmstYW5ub3RhdGlvbi0tbmFtZSkKIAotOzsgRGVmdmFycyB0 byBhdm9pZCBjb21waWxhdGlvbiB3YXJuaW5nczoKLShkZWZ2YXIgYm9va21hcmstYW5ub3RhdGlv bi1uYW1lIG5pbAotICAiVmFyaWFibGUgaG9sZGluZyB0aGUgbmFtZSBvZiB0aGUgYm9va21hcmsu Ci1UaGlzIGlzIHVzZWQgaW4gYGJvb2ttYXJrLWVkaXQtYW5ub3RhdGlvbicgdG8gcmVjb3JkIHRo ZSBib29rbWFyawotd2hvc2UgYW5ub3RhdGlvbiBpcyBiZWluZyBlZGl0ZWQuIikKLQorKGRlZnZh ciBib29rbWFyay1hbm5vdGF0aW9uLS1mcm9tLWJvb2ttYXJrLWxpc3QgbmlsCisgICJJZiBub24t bmlsLCByZXR1cm4gdG8gYm9va21hcmsgbGlzdCBmcm9tIGBib29rbWFyay1lZGl0LWFubm90YXRp b24tbW9kZScuIikKKyhtYWtlLXZhcmlhYmxlLWJ1ZmZlci1sb2NhbCAnYm9va21hcmstYW5ub3Rh dGlvbi0tZnJvbS1ib29rbWFyay1saXN0KQogCiAoZGVmdW4gYm9va21hcmstZGVmYXVsdC1hbm5v dGF0aW9uLXRleHQgKGJvb2ttYXJrLW5hbWUpCiAgICJSZXR1cm4gZGVmYXVsdCBhbm5vdGF0aW9u IHRleHQgZm9yIEJPT0tNQVJLLU5BTUUuCkBAIC05MjksNyArOTM1LDcgQEAgYm9va21hcmstaW5z ZXJ0LWFubm90YXRpb24KIChkZWZpbmUtZGVyaXZlZC1tb2RlIGJvb2ttYXJrLWVkaXQtYW5ub3Rh dGlvbi1tb2RlCiAgIHRleHQtbW9kZSAiRWRpdCBCb29rbWFyayBBbm5vdGF0aW9uIgogICAiTW9k ZSBmb3IgZWRpdGluZyB0aGUgYW5ub3RhdGlvbiBvZiBib29rbWFya3MuCi1XaGVuIHlvdSBoYXZl IGZpbmlzaGVkIGNvbXBvc2luZywgdHlwZSBcXFtib29rbWFyay1zZW5kLWFubm90YXRpb25dLgor V2hlbiB5b3UgaGF2ZSBmaW5pc2hlZCBjb21wb3NpbmcsIHR5cGUgXFxbYm9va21hcmstc2VuZC1l ZGl0ZWQtYW5ub3RhdGlvbl0uCiAKIFxce2Jvb2ttYXJrLWVkaXQtYW5ub3RhdGlvbi1tb2RlLW1h cH0iKQogCkBAIC05NDcsMjEgKzk1MywzMSBAQCBib29rbWFyay1zZW5kLWVkaXRlZC1hbm5vdGF0 aW9uCiAgICAgICAoZm9yd2FyZC1saW5lIDEpKSkKICAgOzsgVGFrZSBubyBjaGFuY2VzIHdpdGgg dGV4dCBwcm9wZXJ0aWVzLgogICAobGV0ICgoYW5ub3RhdGlvbiAoYnVmZmVyLXN1YnN0cmluZy1u by1wcm9wZXJ0aWVzIChwb2ludC1taW4pIChwb2ludC1tYXgpKSkKLQkoYm9va21hcmstbmFtZSBi b29rbWFyay1hbm5vdGF0aW9uLW5hbWUpKQorICAgICAgICAoYm9va21hcmstbmFtZSBib29rbWFy ay1hbm5vdGF0aW9uLS1uYW1lKQorICAgICAgICAoZnJvbS1ib29rbWFyay1saXN0IGJvb2ttYXJr LWFubm90YXRpb24tLWZyb20tYm9va21hcmstbGlzdCkKKyAgICAgICAgKG9sZC1idWZmZXIgKGN1 cnJlbnQtYnVmZmVyKSkpCiAgICAgKGJvb2ttYXJrLXNldC1hbm5vdGF0aW9uIGJvb2ttYXJrLW5h bWUgYW5ub3RhdGlvbikKICAgICAoc2V0cSBib29rbWFyay1hbGlzdC1tb2RpZmljYXRpb24tY291 bnQKICAgICAgICAgICAoMSsgYm9va21hcmstYWxpc3QtbW9kaWZpY2F0aW9uLWNvdW50KSkKLSAg ICAoYm9va21hcmstYm1lbnUtc3VycmVwdGl0aW91c2x5LXJlYnVpbGQtbGlzdCkpCi0gIChraWxs LWJ1ZmZlciAoY3VycmVudC1idWZmZXIpKSkKKyAgICAobWVzc2FnZSAiQW5ub3RhdGlvbiB1cGRh dGVkIGZvciBcIiVzXCIiIGJvb2ttYXJrLW5hbWUpCisgICAgKHF1aXQtd2luZG93KQorICAgIChi b29rbWFyay1ibWVudS1zdXJyZXB0aXRpb3VzbHktcmVidWlsZC1saXN0KQorICAgICh3aGVuIGZy b20tYm9va21hcmstbGlzdAorICAgICAgKHBvcC10by1idWZmZXIgKGdldC1idWZmZXIgYm9va21h cmstYm1lbnUtYnVmZmVyKSkKKyAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikpCisgICAgICAo dGV4dC1wcm9wZXJ0eS1zZWFyY2gtZm9yd2FyZCAnYm9va21hcmstbmFtZS1wcm9wIGJvb2ttYXJr LW5hbWUpKQorICAgIChraWxsLWJ1ZmZlciBvbGQtYnVmZmVyKSkpCiAKIAotKGRlZnVuIGJvb2tt YXJrLWVkaXQtYW5ub3RhdGlvbiAoYm9va21hcmstbmFtZS1vci1yZWNvcmQpCi0gICJQb3AgdXAg YSBidWZmZXIgZm9yIGVkaXRpbmcgYm9va21hcmsgQk9PS01BUkstTkFNRS1PUi1SRUNPUkQncyBh bm5vdGF0aW9uLiIKKyhkZWZ1biBib29rbWFyay1lZGl0LWFubm90YXRpb24gKGJvb2ttYXJrLW5h bWUtb3ItcmVjb3JkICZvcHRpb25hbCBmcm9tLWJvb2ttYXJrLWxpc3QpCisgICJQb3AgdXAgYSBi dWZmZXIgZm9yIGVkaXRpbmcgYm9va21hcmsgQk9PS01BUkstTkFNRS1PUi1SRUNPUkQncyBhbm5v dGF0aW9uLgorSWYgb3B0aW9uYWwgYXJndW1lbnQgRlJPTS1CT09LTUFSSy1MSVNUIGlzIG5vbi1u aWwsIHJldHVybiB0byB0aGUKK2Jvb2ttYXJrIGxpc3Qgd2hlbiBlZGl0aW5nIGlzIGRvbmUuIgog ICAocG9wLXRvLWJ1ZmZlciAoZ2VuZXJhdGUtbmV3LWJ1ZmZlci1uYW1lICIqQm9va21hcmsgQW5u b3RhdGlvbiBDb21wb3NlKiIpKQogICAoYm9va21hcmstaW5zZXJ0LWFubm90YXRpb24gYm9va21h cmstbmFtZS1vci1yZWNvcmQpCiAgIChib29rbWFyay1lZGl0LWFubm90YXRpb24tbW9kZSkKLSAg KHNldCAobWFrZS1sb2NhbC12YXJpYWJsZSAnYm9va21hcmstYW5ub3RhdGlvbi1uYW1lKQotICAg ICAgIGJvb2ttYXJrLW5hbWUtb3ItcmVjb3JkKSkKKyAgKHNldHEgYm9va21hcmstYW5ub3RhdGlv bi0tZnJvbS1ib29rbWFyay1saXN0IGZyb20tYm9va21hcmstbGlzdCkKKyAgKHNldHEgYm9va21h cmstYW5ub3RhdGlvbi0tbmFtZSBib29rbWFyay1uYW1lLW9yLXJlY29yZCkpCiAKIAogKGRlZnVu IGJvb2ttYXJrLWJ1ZmZlci1uYW1lICgpCkBAIC0xNTQ3LDEwICsxNTYzLDkgQEAgYm9va21hcmst bG9hZAogCShwcm9ncmVzcy1yZXBvcnRlci1kb25lIHJlcG9ydGVyKSkpKSkKIAogDAotOzs7IENv ZGUgc3VwcG9ydGluZyB0aGUgZGlyZWQtbGlrZSBib29rbWFyayBtZW51LgorOzs7IENvZGUgc3Vw cG9ydGluZyB0aGUgZGlyZWQtbGlrZSBib29rbWFyayBsaXN0LgogOzsgUHJlZml4IGlzICJib29r bWFyay1ibWVudSIgZm9yICJidWZmZXItbWVudSI6CiAKLQogKGRlZnZhciBib29rbWFyay1ibWVu dS1oaWRkZW4tYm9va21hcmtzICgpKQogCiAKQEAgLTE2MzQsNyArMTY0OSw3IEBAIGJvb2ttYXJr LWJtZW51LW1vZGUtbWFwCiAoZGVmdW4gYm9va21hcmstYm1lbnUtc3VycmVwdGl0aW91c2x5LXJl YnVpbGQtbGlzdCAoKQogICAiUmVidWlsZCB0aGUgQm9va21hcmsgTGlzdCBpZiBpdCBleGlzdHMu CiBEb24ndCBhZmZlY3QgdGhlIGJ1ZmZlciByaW5nIG9yZGVyLiIKLSAgKGlmIChnZXQtYnVmZmVy ICIqQm9va21hcmsgTGlzdCoiKQorICAoaWYgKGdldC1idWZmZXIgYm9va21hcmstYm1lbnUtYnVm ZmVyKQogICAgICAgKHNhdmUtZXhjdXJzaW9uCiAgICAgICAgIChzYXZlLXdpbmRvdy1leGN1cnNp b24KICAgICAgICAgICAoYm9va21hcmstYm1lbnUtbGlzdCkpKSkpCkBAIC0xNjQ4LDcgKzE2NjMs NyBAQCBib29rbWFyay1ibWVudS1saXN0CiBkZWxldGlvbiwgb3IgPiBpZiBpdCBpcyBmbGFnZ2Vk IGZvciBkaXNwbGF5aW5nLiIKICAgKGludGVyYWN0aXZlKQogICAoYm9va21hcmstbWF5YmUtbG9h ZC1kZWZhdWx0LWZpbGUpCi0gIChsZXQgKChidWYgKGdldC1idWZmZXItY3JlYXRlICIqQm9va21h cmsgTGlzdCoiKSkpCisgIChsZXQgKChidWYgKGdldC1idWZmZXItY3JlYXRlIGJvb2ttYXJrLWJt ZW51LWJ1ZmZlcikpKQogICAgIChpZiAoY2FsbGVkLWludGVyYWN0aXZlbHktcCAnaW50ZXJhY3Rp dmUpCiAgICAgICAgIChzd2l0Y2gtdG8tYnVmZmVyIGJ1ZikKICAgICAgIChzZXQtYnVmZmVyIGJ1 ZikpKQpAQCAtMjA1MSw3ICsyMDY2LDcgQEAgYm9va21hcmstYm1lbnUtZWRpdC1hbm5vdGF0aW9u CiAgICJFZGl0IHRoZSBhbm5vdGF0aW9uIGZvciB0aGUgY3VycmVudCBib29rbWFyayBpbiBhbm90 aGVyIHdpbmRvdy4iCiAgIChpbnRlcmFjdGl2ZSkKICAgKGxldCAoKGJvb2ttYXJrIChib29rbWFy ay1ibWVudS1ib29rbWFyaykpKQotICAgIChib29rbWFyay1lZGl0LWFubm90YXRpb24gYm9va21h cmspKSkKKyAgICAoYm9va21hcmstZWRpdC1hbm5vdGF0aW9uIGJvb2ttYXJrIHQpKSkKIAogCiAo ZGVmdW4gYm9va21hcmstYm1lbnUtdW5tYXJrICgmb3B0aW9uYWwgYmFja3VwKQpkaWZmIC0tZ2l0 IGEvdGVzdC9saXNwL2Jvb2ttYXJrLXRlc3RzLmVsIGIvdGVzdC9saXNwL2Jvb2ttYXJrLXRlc3Rz LmVsCmluZGV4IDZmYTBiMWU5OGQuLmE3NzRkYWU4OWQgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9i b29rbWFyay10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvYm9va21hcmstdGVzdHMuZWwKQEAgLTE4 Niw2ICsxODYsMTggQEAgYm9va21hcmstdGVzdHMtc2V0CiAgICAgICAgOzsgMy4gYm9va21hcmst c2V0LWludGVybmFsCiAgICAgICAgKHNob3VsZC1lcnJvciAoYm9va21hcmstc2V0LWludGVybmFs ICJmb28iICJiYXIiIHQpKSkpKSkKIAorKGVydC1kZWZ0ZXN0IGJvb2ttYXJrLXRlc3RzLXNldC9i b29rbWFyay11c2UtYW5ub3RhdGlvbnMtdCAoKQorICAod2l0aC1ib29rbWFyay10ZXN0LWZpbGUK KyAgIChsZXQgKChib29rbWFyay11c2UtYW5ub3RhdGlvbnMgdCkpCisgICAgIChzYXZlLXdpbmRv dy1leGN1cnNpb24KKyAgICAgICAoc3dpdGNoLXRvLWJ1ZmZlciBidWZmZXIpCisgICAgICAgOzsg U2hvdWxkIGp1bXAgdG8gZWRpdCBhbm5vdGF0aW9uIGJ1ZmZlcgorICAgICAgIChib29rbWFyay1z ZXQgImZvbyIpCisgICAgICAgKHNob3VsZCAoZXF1YWwgbWFqb3ItbW9kZSAnYm9va21hcmstZWRp dC1hbm5vdGF0aW9uLW1vZGUpKQorICAgICAgIDs7IFNob3VsZCByZXR1cm4gdG8gdGhlIG9yaWdp bmFsIGJ1ZmZlcgorICAgICAgIChib29rbWFyay1zZW5kLWVkaXRlZC1hbm5vdGF0aW9uKQorICAg ICAgIChzaG91bGQgKGVxdWFsIChjdXJyZW50LWJ1ZmZlcikgYnVmZmVyKSkpKSkpCisKIChlcnQt ZGVmdGVzdCBib29rbWFyay10ZXN0cy1raWxsLWxpbmUgKCkKICAgKHdpdGgtdGVtcC1idWZmZXIK ICAgICAoaW5zZXJ0ICJmb29iYXJcbiIpCkBAIC0zMTMsNyArMzI1LDQyIEBAIGJvb2ttYXJrLXRl c3RzLWxvYWQKICAgICAgICAgICAgICAgICAgICAgKGxpc3QgYm9va21hcmstdGVzdHMtYm9va21h cmsKICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNvbnMgIm5hbWU8Mj4iIChjZHIgYm9va21h cmstdGVzdHMtYm9va21hcmspKSkpKSkpKQogCi07OyBUT0RPOiBBZGQgdGVzdHMgZm9yIGJvb2tt YXJrLWJtZW51LgorOzsgVE9ETzogQWRkIG1vcmUgdGVzdHMgZm9yIGJvb2ttYXJrLWJtZW51Lgor CisoZGVmbWFjcm8gd2l0aC1ib29rbWFyay1ibWVudS10ZXN0ICgmcmVzdCBib2R5KQorICAiQ3Jl YXRlIGVudmlyb25tZW50IGZvciB0ZXN0aW5nIGBib29rbWFyay1ibWVudS1saXN0JyBhbmQgZXZh bHVhdGUgQk9EWS4KK1NhbWUgYXMgYHdpdGgtYm9va21hcmstdGVzdCcgYnV0IHdpdGggYWRkaXRp b25zIHN1aXRhYmxlIGZvcgordGVzdGluZyBgYm9va21hcmstYm1lbnUtbGlzdCcuIgorICBgKHdp dGgtYm9va21hcmstdGVzdAorICAgIChsZXQgKChib29rbWFyay1ibWVudS1idWZmZXIgIipCb29r bWFyayBMaXN0IC0gVGVzdGluZyoiKSkKKyAgICAgICh1bndpbmQtcHJvdGVjdAorICAgICAgICAg IChzYXZlLXdpbmRvdy1leGN1cnNpb24KKyAgICAgICAgICAgIChib29rbWFyay1ibWVudS1saXN0 KQorICAgICAgICAgICAgLEBib2R5KQorICAgICAgICAoa2lsbC1idWZmZXIgYm9va21hcmstYm1l bnUtYnVmZmVyKSkpKSkKKworKGVydC1kZWZ0ZXN0IGJvb2ttYXJrLWJtZW51LmVudS1lZGl0LWFu bm90YXRpb24vc2hvdy1hbm5vdGF0aW9uICgpCisgICh3aXRoLWJvb2ttYXJrLWJtZW51LXRlc3QK KyAgIChib29rbWFyay1zZXQtYW5ub3RhdGlvbiAibmFtZSIgImZvbyIpCisgICAoYm9va21hcmst Ym1lbnUtZWRpdC1hbm5vdGF0aW9uKQorICAgKHNob3VsZCAoc3RyaW5nLW1hdGNoICJmb28iIChi dWZmZXItc3RyaW5nKSkpCisgICAoa2lsbC1idWZmZXIgKGN1cnJlbnQtYnVmZmVyKSkpKQorCiso ZXJ0LWRlZnRlc3QgYm9va21hcmstYm1lbnUtc2VuZC1lZGl0ZWQtYW5ub3RhdGlvbiAoKQorICAo d2l0aC1ib29rbWFyay1ibWVudS10ZXN0CisgICAoYm9va21hcmstYm1lbnUtZWRpdC1hbm5vdGF0 aW9uKQorICAgKGluc2VydCAiZm9vIikKKyAgIChib29rbWFyay1zZW5kLWVkaXRlZC1hbm5vdGF0 aW9uKQorICAgKHNob3VsZCAoZXF1YWwgKGJvb2ttYXJrLWdldC1hbm5vdGF0aW9uICJuYW1lIikg ImZvbyIpKSkpCisKKyhlcnQtZGVmdGVzdCBib29rbWFyay1ibWVudS1zZW5kLWVkaXRlZC1hbm5v dGF0aW9uL3Jlc3RvcmUtZm9jdXMgKCkKKyAgIlRlc3QgZm9yIGh0dHBzOi8vZGViYnVncy5nbnUu b3JnLzIwMTUwIC4iCisgICh3aXRoLWJvb2ttYXJrLWJtZW51LXRlc3QKKyAgIChib29rbWFyay1i bWVudS1lZGl0LWFubm90YXRpb24pCisgICAoaW5zZXJ0ICJmb28iKQorICAgKGJvb2ttYXJrLXNl bmQtZWRpdGVkLWFubm90YXRpb24pCisgICAoc2hvdWxkIChlcXVhbCAoYnVmZmVyLW5hbWUgKGN1 cnJlbnQtYnVmZmVyKSkgYm9va21hcmstYm1lbnUtYnVmZmVyKSkKKyAgIChzaG91bGQgKGxvb2tp bmctYXQgIm5hbWUiKSkpKQogCiAocHJvdmlkZSAnYm9va21hcmstdGVzdHMpCiA7OzsgYm9va21h cmstdGVzdHMuZWwgZW5kcyBoZXJlCi0tIAoyLjIxLjAKCg== --0000000000001cbf42058ce0287d-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 13 03:30:13 2019 Received: (at 20150) by debbugs.gnu.org; 13 Jul 2019 07:30:14 +0000 Received: from localhost ([127.0.0.1]:41394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmCU1-0004Fa-D5 for submit@debbugs.gnu.org; Sat, 13 Jul 2019 03:30:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmCTz-0004FK-DA for 20150@debbugs.gnu.org; Sat, 13 Jul 2019 03:30:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hmCTt-0003HR-Vg; Sat, 13 Jul 2019 03:30:06 -0400 Received: from [176.228.60.248] (port=2954 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hmCTt-0005DG-4P; Sat, 13 Jul 2019 03:30:05 -0400 Date: Sat, 13 Jul 2019 10:30:01 +0300 Message-Id: <83r26u1jeu.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Thu, 4 Jul 2019 21:40:45 +0200) Subject: Re: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20150 Cc: 20150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Thu, 4 Jul 2019 21:40:45 +0200 > Cc: 20150@debbugs.gnu.org > > I've attached an updated patch without this FIXME. Other than that, > it's identical. Thanks. > +(define-obsolete-variable-alias 'bookmark-annotation-name > + 'bookmark-annotation--name "27.1") Hmm... we declare a non-internal variable obsolete and replace it with an internal variable? Why is that a good idea? Does the new variable have to be internal? From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 13 09:09:59 2019 Received: (at 20150) by debbugs.gnu.org; 13 Jul 2019 13:09:59 +0000 Received: from localhost ([127.0.0.1]:41589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmHmo-00024O-Ql for submit@debbugs.gnu.org; Sat, 13 Jul 2019 09:09:59 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:54590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmHmm-000249-S3 for 20150@debbugs.gnu.org; Sat, 13 Jul 2019 09:09:57 -0400 Received: by mail-wm1-f41.google.com with SMTP id p74so11149174wme.4 for <20150@debbugs.gnu.org>; Sat, 13 Jul 2019 06:09:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9be06F2bMUiS4CfPkpMKnrSZdPZ57hD0XSdkJPpYt/E=; b=toKqC+QosV38tjWyiKMGtk4mgjhdhfUaaoqCJCRb23RUpq9U8coWLRirHsqKPcA53c Cjtjzi+yTJGRCHDKtCxKWwvURgw39kwNnQLHXvPudLkUX7y3NGZrguOwqMYJlkmHgfS3 gfF2gaCwa71Xe8iWm+9jm3t526n1HBqXp7p1oWsm/IIZhUgxtEhO01lpXkIga0025QPV 3LSOKncpFVXCdbnipWL9WJNM8BIPwj01bETHju2HpGX4HD1xYj6TRWTV+I03ppQZb5Vo kn34b+sTVHmH5pXpQiwOrKGt2+LKHJejni0ZZ+DhToFIMq3aFQvbe+B2Tx6+rtFXmc6m nFqA== X-Gm-Message-State: APjAAAXSrjY4i2JQzVZxB0JMD5YAF+fEYSJjVfpyOroCWkLvVWIcYRdW QlXJeYmpXDWX+KC+AiMtP8jMwXPIZOYplKzWtjtszpFl X-Google-Smtp-Source: APXvYqwgWdWbwY5jgkbafFRP5+fKa1n2OcryYLKgVZdd0o0uZYXIJc5CJAHF8YCjoqPqNw8CDFquX37QG8hScQ4OE30= X-Received: by 2002:a7b:c04f:: with SMTP id u15mr14611732wmc.106.1563023391029; Sat, 13 Jul 2019 06:09:51 -0700 (PDT) MIME-Version: 1.0 References: <83r26u1jeu.fsf@gnu.org> In-Reply-To: <83r26u1jeu.fsf@gnu.org> From: Stefan Kangas Date: Sat, 13 Jul 2019 15:09:39 +0200 Message-ID: Subject: Re: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000ffaaf5058d8fbd34" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 20150 Cc: 20150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000ffaaf5058d8fbd34 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: > > +(define-obsolete-variable-alias 'bookmark-annotation-name > > + 'bookmark-annotation--name "27.1") > > Hmm... we declare a non-internal variable obsolete and replace it with > an internal variable? Why is that a good idea? Does the new variable > have to be internal? I thought about it a bit more, and I guess it doesn't have to be internal. I suggest that the new variable should be kept internal for now though. I also don't know why I named the new variable bookmark-annotation--name, so I've changed that to bookmark--annotation-name to better reflect current practices. Please see this updated patch with those two changes. Thanks, Stefan Kangas --000000000000ffaaf5058d8fbd34 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Restore-focus-to-Bookmark-List-after-editing-annotat.patch" Content-Disposition: attachment; filename="0001-Restore-focus-to-Bookmark-List-after-editing-annotat.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jy1jr2lr0 RnJvbSA2NjUwYzRmNTFlZWFiNGJmYWYyZTE5ZDBiYTIwOTI4N2EwNTgwNGE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUdWUsIDIgSnVsIDIwMTkgMDM6MDY6MzcgKzAyMDAKU3ViamVjdDogW1BBVENIXSBS ZXN0b3JlIGZvY3VzIHRvIEJvb2ttYXJrIExpc3QgYWZ0ZXIgZWRpdGluZyBhbm5vdGF0aW9uCgpU aGVyZSBhcmUgdHdvIGVudHJ5IHBvaW50cyB0byBib29rbWFyay1lZGl0LWFubm90YXRpb24tbW9k ZTogdGhlIGZpcnN0CndoZW4gd2UgYWRkIGEgYm9va21hcmsgYW5kIGJvb2ttYXJrLXVzZS1hbm5v dGF0aW9ucyBpcyBub24tbmlsOyB0aGUKc2Vjb25kIHdoZW4gYm9va21hcmstYm1lbnUtZWRpdC1h bm5vdGF0aW9uIGlzIHJ1biBmcm9tIHRoZSBib29rbWFyawpsaXN0LiAgV2hlbiBlZGl0aW5nIGlz IGNvbmNsdWRlZCwgaW4gdGhlIGZpcnN0IGNhc2UsIHdlIHNob3VsZCBqdXN0CnF1aXQgd2luZG93 LiAgSW4gdGhlIHNlY29uZCBjYXNlLCB3ZSBzaG91bGQgaW5zdGVhZCByZXR1cm4gdG8gdGhlCmJv b2ttYXJrIGxpc3QuCgoqIGxpc3AvYm9va21hcmsuZWwgKHRleHQtcHJvcGVydHktc2VhcmNoKTog UmVxdWlyZS4KKGJvb2ttYXJrLWFubm90YXRpb24tbmFtZSk6IE1ha2UgYnVmZmVyLWxvY2FsIGFu ZCBpbXByb3ZlIGRvYyBzdHJpbmcuCihib29rbWFyay0tYW5ub3RhdGlvbi1mcm9tLWJvb2ttYXJr LWxpc3QpOiBOZXcgYnVmZmVyLWxvY2FsIHZhcmlhYmxlLgooYm9va21hcmstZWRpdC1hbm5vdGF0 aW9uKTogTmV3IGFyZ3VtZW50IGZyb20tYm9va21hcmstbGlzdCBzZXRzCmJvb2ttYXJrLS1hbm5v dGF0aW9uLWZyb20tYm9va21hcmstbGlzdC4KKGJvb2ttYXJrLWJtZW51LWVkaXQtYW5ub3RhdGlv bik6IENhbGwgYm9va21hcmstZWRpdC1hbm5vdGF0aW9uIHdpdGgKYXJndW1lbnQgZnJvbS1ib29r bWFyay1saXN0IHNldCB0byB0LgooYm9va21hcmstc2VuZC1lZGl0ZWQtYW5ub3RhdGlvbik6IFdo ZW4gZWRpdGluZyBvcmlnaW5hdGVkIGluIHRoZQpib29rbWFyayBsaXN0LCByZXN0b3JlIGZvY3Vz IHRvIGJvb2ttYXJrIGxpc3QgYW5kIG1vdmUgcG9pbnQgYmFjayB0bwplZGl0ZWQgYm9va21hcmsu IChCdWcjMjAxNTApCgooYm9va21hcmstZWRpdC1hbm5vdGF0aW9uLW1vZGUpOiBGaXggdHlwby4K KGJvb2ttYXJrLWJtZW51LWJ1ZmZlcik6IE5ldyB2YXJpYWJsZS4KKGJvb2ttYXJrLWJtZW51LXN1 cnJlcHRpdGlvdXNseS1yZWJ1aWxkLWxpc3QpCihib29rbWFyay1ibWVudS1saXN0KTogVXNlIGl0 LgoKKiB0ZXN0L2xpc3AvYm9va21hcmstdGVzdHMuZWwgKHdpdGgtYm9va21hcmstYm1lbnUtdGVz dCk6IE5ldyBtYWNyby4KKGJvb2ttYXJrLXRlc3RzLXNldC9ib29rbWFyay11c2UtYW5ub3RhdGlv bnMtdCkKKGJvb2ttYXJrLWJtZW51LWVkaXQtYW5ub3RhdGlvbi9zaG93LWFubm90YXRpb24pCihi b29rbWFyay1ibWVudS1zZW5kLWVkaXRlZC1hbm5vdGF0aW9uKQooYm9va21hcmstYm1lbnUtc2Vu ZC1lZGl0ZWQtYW5ub3RhdGlvbi9yZXN0b3JlLWZvY3VzKTogTmV3IHRlc3QgY2FzZXMuCi0tLQog bGlzcC9ib29rbWFyay5lbCAgICAgICAgICAgIHwgNDkgKysrKysrKysrKysrKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0tLS0tLS0tCiB0ZXN0L2xpc3AvYm9va21hcmstdGVzdHMuZWwgfCA0OSAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KIDIgZmlsZXMgY2hh bmdlZCwgNzkgaW5zZXJ0aW9ucygrKSwgMTkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlz cC9ib29rbWFyay5lbCBiL2xpc3AvYm9va21hcmsuZWwKaW5kZXggMjY0MGIyMTU3YS4uZjU2NGNk NmI0MyAxMDA2NDQKLS0tIGEvbGlzcC9ib29rbWFyay5lbAorKysgYi9saXNwL2Jvb2ttYXJrLmVs CkBAIC0zMiw2ICszMiw3IEBACiA7OzsgQ29kZToKIAogKHJlcXVpcmUgJ3BwKQorKHJlcXVpcmUg J3RleHQtcHJvcGVydHktc2VhcmNoKQogKGV2YWwtd2hlbi1jb21waWxlIChyZXF1aXJlICdjbC1s aWIpKQogCiA7OzsgTWlzYyBjb21tZW50czoKQEAgLTEyMiw2ICsxMjMsOSBAQCBib29rbWFyay1h dXRvbWF0aWNhbGx5LXNob3ctYW5ub3RhdGlvbnMKICAgIk5vbi1uaWwgbWVhbnMgc2hvdyBhbm5v dGF0aW9ucyB3aGVuIGp1bXBpbmcgdG8gYSBib29rbWFyay4iCiAgIDp0eXBlICdib29sZWFuKQog CisoZGVmY29uc3QgYm9va21hcmstYm1lbnUtYnVmZmVyICIqQm9va21hcmsgTGlzdCoiCisgICJO YW1lIG9mIGJ1ZmZlciB1c2VkIGZvciBCb29rbWFyayBMaXN0LiIpCisKIChkZWZjdXN0b20gYm9v a21hcmstYm1lbnUtdXNlLWhlYWRlci1saW5lIHQKICAgIk5vbi1uaWwgbWVhbnMgdG8gdXNlIGFu IGltbW92YWJsZSBoZWFkZXIgbGluZS4KIFRoaXMgaXMgYXMgb3Bwb3NlZCB0byBpbmxpbmUgdGV4 dCBhdCB0aGUgdG9wIG9mIHRoZSBidWZmZXIuIgpAQCAtODg5LDEzICs4OTMsMTMgQEAgYm9va21h cmsta2lsbC1saW5lCiAgICAgKHdoZW4gKGFuZCBuZXdsaW5lLXRvbyAoPSAoZm9sbG93aW5nLWNo YXIpID9cbikpCiAgICAgICAoZGVsZXRlLWNoYXIgMSkpKSkKIAotCi07OyBEZWZ2YXJzIHRvIGF2 b2lkIGNvbXBpbGF0aW9uIHdhcm5pbmdzOgogKGRlZnZhciBib29rbWFyay1hbm5vdGF0aW9uLW5h bWUgbmlsCi0gICJWYXJpYWJsZSBob2xkaW5nIHRoZSBuYW1lIG9mIHRoZSBib29rbWFyay4KLVRo aXMgaXMgdXNlZCBpbiBgYm9va21hcmstZWRpdC1hbm5vdGF0aW9uJyB0byByZWNvcmQgdGhlIGJv b2ttYXJrCi13aG9zZSBhbm5vdGF0aW9uIGlzIGJlaW5nIGVkaXRlZC4iKQorICAiTmFtZSBvZiBi b29rbWFyayB1bmRlciBlZGl0IGluIGBib29rbWFyay1lZGl0LWFubm90YXRpb24tbW9kZScuIikK KyhtYWtlLXZhcmlhYmxlLWJ1ZmZlci1sb2NhbCAnYm9va21hcmstYW5ub3RhdGlvbi1uYW1lKQog CisoZGVmdmFyIGJvb2ttYXJrLS1hbm5vdGF0aW9uLWZyb20tYm9va21hcmstbGlzdCBuaWwKKyAg IklmIG5vbi1uaWwsIGBib29rbWFyay1lZGl0LWFubm90YXRpb24tbW9kZScgc2hvdWxkIHJldHVy biB0byBib29rbWFyayBsaXN0LiIpCisobWFrZS12YXJpYWJsZS1idWZmZXItbG9jYWwgJ2Jvb2tt YXJrLS1hbm5vdGF0aW9uLWZyb20tYm9va21hcmstbGlzdCkKIAogKGRlZnVuIGJvb2ttYXJrLWRl ZmF1bHQtYW5ub3RhdGlvbi10ZXh0IChib29rbWFyay1uYW1lKQogICAiUmV0dXJuIGRlZmF1bHQg YW5ub3RhdGlvbiB0ZXh0IGZvciBCT09LTUFSSy1OQU1FLgpAQCAtOTM3LDcgKzk0MSw3IEBAIGJv b2ttYXJrLWluc2VydC1hbm5vdGF0aW9uCiAoZGVmaW5lLWRlcml2ZWQtbW9kZSBib29rbWFyay1l ZGl0LWFubm90YXRpb24tbW9kZQogICB0ZXh0LW1vZGUgIkVkaXQgQm9va21hcmsgQW5ub3RhdGlv biIKICAgIk1vZGUgZm9yIGVkaXRpbmcgdGhlIGFubm90YXRpb24gb2YgYm9va21hcmtzLgotV2hl biB5b3UgaGF2ZSBmaW5pc2hlZCBjb21wb3NpbmcsIHR5cGUgXFxbYm9va21hcmstc2VuZC1hbm5v dGF0aW9uXS4KK1doZW4geW91IGhhdmUgZmluaXNoZWQgY29tcG9zaW5nLCB0eXBlIFxcW2Jvb2tt YXJrLXNlbmQtZWRpdGVkLWFubm90YXRpb25dLgogCiBcXHtib29rbWFyay1lZGl0LWFubm90YXRp b24tbW9kZS1tYXB9IikKIApAQCAtOTU1LDIxICs5NTksMzEgQEAgYm9va21hcmstc2VuZC1lZGl0 ZWQtYW5ub3RhdGlvbgogICAgICAgKGZvcndhcmQtbGluZSAxKSkpCiAgIDs7IFRha2Ugbm8gY2hh bmNlcyB3aXRoIHRleHQgcHJvcGVydGllcy4KICAgKGxldCAoKGFubm90YXRpb24gKGJ1ZmZlci1z dWJzdHJpbmctbm8tcHJvcGVydGllcyAocG9pbnQtbWluKSAocG9pbnQtbWF4KSkpCi0JKGJvb2tt YXJrLW5hbWUgYm9va21hcmstYW5ub3RhdGlvbi1uYW1lKSkKKyAgICAgICAgKGJvb2ttYXJrLW5h bWUgYm9va21hcmstYW5ub3RhdGlvbi1uYW1lKQorICAgICAgICAoZnJvbS1ib29rbWFyay1saXN0 IGJvb2ttYXJrLS1hbm5vdGF0aW9uLWZyb20tYm9va21hcmstbGlzdCkKKyAgICAgICAgKG9sZC1i dWZmZXIgKGN1cnJlbnQtYnVmZmVyKSkpCiAgICAgKGJvb2ttYXJrLXNldC1hbm5vdGF0aW9uIGJv b2ttYXJrLW5hbWUgYW5ub3RhdGlvbikKICAgICAoc2V0cSBib29rbWFyay1hbGlzdC1tb2RpZmlj YXRpb24tY291bnQKICAgICAgICAgICAoMSsgYm9va21hcmstYWxpc3QtbW9kaWZpY2F0aW9uLWNv dW50KSkKLSAgICAoYm9va21hcmstYm1lbnUtc3VycmVwdGl0aW91c2x5LXJlYnVpbGQtbGlzdCkp Ci0gIChraWxsLWJ1ZmZlciAoY3VycmVudC1idWZmZXIpKSkKKyAgICAobWVzc2FnZSAiQW5ub3Rh dGlvbiB1cGRhdGVkIGZvciBcIiVzXCIiIGJvb2ttYXJrLW5hbWUpCisgICAgKHF1aXQtd2luZG93 KQorICAgIChib29rbWFyay1ibWVudS1zdXJyZXB0aXRpb3VzbHktcmVidWlsZC1saXN0KQorICAg ICh3aGVuIGZyb20tYm9va21hcmstbGlzdAorICAgICAgKHBvcC10by1idWZmZXIgKGdldC1idWZm ZXIgYm9va21hcmstYm1lbnUtYnVmZmVyKSkKKyAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikp CisgICAgICAodGV4dC1wcm9wZXJ0eS1zZWFyY2gtZm9yd2FyZCAnYm9va21hcmstbmFtZS1wcm9w IGJvb2ttYXJrLW5hbWUpKQorICAgIChraWxsLWJ1ZmZlciBvbGQtYnVmZmVyKSkpCiAKIAotKGRl ZnVuIGJvb2ttYXJrLWVkaXQtYW5ub3RhdGlvbiAoYm9va21hcmstbmFtZS1vci1yZWNvcmQpCi0g ICJQb3AgdXAgYSBidWZmZXIgZm9yIGVkaXRpbmcgYm9va21hcmsgQk9PS01BUkstTkFNRS1PUi1S RUNPUkQncyBhbm5vdGF0aW9uLiIKKyhkZWZ1biBib29rbWFyay1lZGl0LWFubm90YXRpb24gKGJv b2ttYXJrLW5hbWUtb3ItcmVjb3JkICZvcHRpb25hbCBmcm9tLWJvb2ttYXJrLWxpc3QpCisgICJQ b3AgdXAgYSBidWZmZXIgZm9yIGVkaXRpbmcgYm9va21hcmsgQk9PS01BUkstTkFNRS1PUi1SRUNP UkQncyBhbm5vdGF0aW9uLgorSWYgb3B0aW9uYWwgYXJndW1lbnQgRlJPTS1CT09LTUFSSy1MSVNU IGlzIG5vbi1uaWwsIHJldHVybiB0byB0aGUKK2Jvb2ttYXJrIGxpc3Qgd2hlbiBlZGl0aW5nIGlz IGRvbmUuIgogICAocG9wLXRvLWJ1ZmZlciAoZ2VuZXJhdGUtbmV3LWJ1ZmZlci1uYW1lICIqQm9v a21hcmsgQW5ub3RhdGlvbiBDb21wb3NlKiIpKQogICAoYm9va21hcmstaW5zZXJ0LWFubm90YXRp b24gYm9va21hcmstbmFtZS1vci1yZWNvcmQpCiAgIChib29rbWFyay1lZGl0LWFubm90YXRpb24t bW9kZSkKLSAgKHNldCAobWFrZS1sb2NhbC12YXJpYWJsZSAnYm9va21hcmstYW5ub3RhdGlvbi1u YW1lKQotICAgICAgIGJvb2ttYXJrLW5hbWUtb3ItcmVjb3JkKSkKKyAgKHNldHEgYm9va21hcmst LWFubm90YXRpb24tZnJvbS1ib29rbWFyay1saXN0IGZyb20tYm9va21hcmstbGlzdCkKKyAgKHNl dHEgYm9va21hcmstYW5ub3RhdGlvbi1uYW1lIGJvb2ttYXJrLW5hbWUtb3ItcmVjb3JkKSkKIAog CiAoZGVmdW4gYm9va21hcmstYnVmZmVyLW5hbWUgKCkKQEAgLTE1NTUsMTAgKzE1NjksOSBAQCBi b29rbWFyay1sb2FkCiAJKHByb2dyZXNzLXJlcG9ydGVyLWRvbmUgcmVwb3J0ZXIpKSkpKQogCiAM Ci07OzsgQ29kZSBzdXBwb3J0aW5nIHRoZSBkaXJlZC1saWtlIGJvb2ttYXJrIG1lbnUuCis7Ozsg Q29kZSBzdXBwb3J0aW5nIHRoZSBkaXJlZC1saWtlIGJvb2ttYXJrIGxpc3QuCiA7OyBQcmVmaXgg aXMgImJvb2ttYXJrLWJtZW51IiBmb3IgImJ1ZmZlci1tZW51IjoKIAotCiAoZGVmdmFyIGJvb2tt YXJrLWJtZW51LWhpZGRlbi1ib29rbWFya3MgKCkpCiAKIApAQCAtMTY0Miw3ICsxNjU1LDcgQEAg Ym9va21hcmstYm1lbnUtbW9kZS1tYXAKIChkZWZ1biBib29rbWFyay1ibWVudS1zdXJyZXB0aXRp b3VzbHktcmVidWlsZC1saXN0ICgpCiAgICJSZWJ1aWxkIHRoZSBCb29rbWFyayBMaXN0IGlmIGl0 IGV4aXN0cy4KIERvbid0IGFmZmVjdCB0aGUgYnVmZmVyIHJpbmcgb3JkZXIuIgotICAoaWYgKGdl dC1idWZmZXIgIipCb29rbWFyayBMaXN0KiIpCisgIChpZiAoZ2V0LWJ1ZmZlciBib29rbWFyay1i bWVudS1idWZmZXIpCiAgICAgICAoc2F2ZS1leGN1cnNpb24KICAgICAgICAgKHNhdmUtd2luZG93 LWV4Y3Vyc2lvbgogICAgICAgICAgIChib29rbWFyay1ibWVudS1saXN0KSkpKSkKQEAgLTE2NTYs NyArMTY2OSw3IEBAIGJvb2ttYXJrLWJtZW51LWxpc3QKIGRlbGV0aW9uLCBvciA+IGlmIGl0IGlz IGZsYWdnZWQgZm9yIGRpc3BsYXlpbmcuIgogICAoaW50ZXJhY3RpdmUpCiAgIChib29rbWFyay1t YXliZS1sb2FkLWRlZmF1bHQtZmlsZSkKLSAgKGxldCAoKGJ1ZiAoZ2V0LWJ1ZmZlci1jcmVhdGUg IipCb29rbWFyayBMaXN0KiIpKSkKKyAgKGxldCAoKGJ1ZiAoZ2V0LWJ1ZmZlci1jcmVhdGUgYm9v a21hcmstYm1lbnUtYnVmZmVyKSkpCiAgICAgKGlmIChjYWxsZWQtaW50ZXJhY3RpdmVseS1wICdp bnRlcmFjdGl2ZSkKICAgICAgICAgKHN3aXRjaC10by1idWZmZXIgYnVmKQogICAgICAgKHNldC1i dWZmZXIgYnVmKSkpCkBAIC0yMDU5LDcgKzIwNzIsNyBAQCBib29rbWFyay1ibWVudS1lZGl0LWFu bm90YXRpb24KICAgIkVkaXQgdGhlIGFubm90YXRpb24gZm9yIHRoZSBjdXJyZW50IGJvb2ttYXJr IGluIGFub3RoZXIgd2luZG93LiIKICAgKGludGVyYWN0aXZlKQogICAobGV0ICgoYm9va21hcmsg KGJvb2ttYXJrLWJtZW51LWJvb2ttYXJrKSkpCi0gICAgKGJvb2ttYXJrLWVkaXQtYW5ub3RhdGlv biBib29rbWFyaykpKQorICAgIChib29rbWFyay1lZGl0LWFubm90YXRpb24gYm9va21hcmsgdCkp KQogCiAKIChkZWZ1biBib29rbWFyay1ibWVudS11bm1hcmsgKCZvcHRpb25hbCBiYWNrdXApCmRp ZmYgLS1naXQgYS90ZXN0L2xpc3AvYm9va21hcmstdGVzdHMuZWwgYi90ZXN0L2xpc3AvYm9va21h cmstdGVzdHMuZWwKaW5kZXggNmZhMGIxZTk4ZC4uYTc3NGRhZTg5ZCAxMDA2NDQKLS0tIGEvdGVz dC9saXNwL2Jvb2ttYXJrLXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9ib29rbWFyay10ZXN0cy5l bApAQCAtMTg2LDYgKzE4NiwxOCBAQCBib29rbWFyay10ZXN0cy1zZXQKICAgICAgICA7OyAzLiBi b29rbWFyay1zZXQtaW50ZXJuYWwKICAgICAgICAoc2hvdWxkLWVycm9yIChib29rbWFyay1zZXQt aW50ZXJuYWwgImZvbyIgImJhciIgdCkpKSkpKQogCisoZXJ0LWRlZnRlc3QgYm9va21hcmstdGVz dHMtc2V0L2Jvb2ttYXJrLXVzZS1hbm5vdGF0aW9ucy10ICgpCisgICh3aXRoLWJvb2ttYXJrLXRl c3QtZmlsZQorICAgKGxldCAoKGJvb2ttYXJrLXVzZS1hbm5vdGF0aW9ucyB0KSkKKyAgICAgKHNh dmUtd2luZG93LWV4Y3Vyc2lvbgorICAgICAgIChzd2l0Y2gtdG8tYnVmZmVyIGJ1ZmZlcikKKyAg ICAgICA7OyBTaG91bGQganVtcCB0byBlZGl0IGFubm90YXRpb24gYnVmZmVyCisgICAgICAgKGJv b2ttYXJrLXNldCAiZm9vIikKKyAgICAgICAoc2hvdWxkIChlcXVhbCBtYWpvci1tb2RlICdib29r bWFyay1lZGl0LWFubm90YXRpb24tbW9kZSkpCisgICAgICAgOzsgU2hvdWxkIHJldHVybiB0byB0 aGUgb3JpZ2luYWwgYnVmZmVyCisgICAgICAgKGJvb2ttYXJrLXNlbmQtZWRpdGVkLWFubm90YXRp b24pCisgICAgICAgKHNob3VsZCAoZXF1YWwgKGN1cnJlbnQtYnVmZmVyKSBidWZmZXIpKSkpKSkK KwogKGVydC1kZWZ0ZXN0IGJvb2ttYXJrLXRlc3RzLWtpbGwtbGluZSAoKQogICAod2l0aC10ZW1w LWJ1ZmZlcgogICAgIChpbnNlcnQgImZvb2JhclxuIikKQEAgLTMxMyw3ICszMjUsNDIgQEAgYm9v a21hcmstdGVzdHMtbG9hZAogICAgICAgICAgICAgICAgICAgICAobGlzdCBib29rbWFyay10ZXN0 cy1ib29rbWFyawogICAgICAgICAgICAgICAgICAgICAgICAgICAoY29ucyAibmFtZTwyPiIgKGNk ciBib29rbWFyay10ZXN0cy1ib29rbWFyaykpKSkpKSkpCiAKLTs7IFRPRE86IEFkZCB0ZXN0cyBm b3IgYm9va21hcmstYm1lbnUuCis7OyBUT0RPOiBBZGQgbW9yZSB0ZXN0cyBmb3IgYm9va21hcmst Ym1lbnUuCisKKyhkZWZtYWNybyB3aXRoLWJvb2ttYXJrLWJtZW51LXRlc3QgKCZyZXN0IGJvZHkp CisgICJDcmVhdGUgZW52aXJvbm1lbnQgZm9yIHRlc3RpbmcgYGJvb2ttYXJrLWJtZW51LWxpc3Qn IGFuZCBldmFsdWF0ZSBCT0RZLgorU2FtZSBhcyBgd2l0aC1ib29rbWFyay10ZXN0JyBidXQgd2l0 aCBhZGRpdGlvbnMgc3VpdGFibGUgZm9yCit0ZXN0aW5nIGBib29rbWFyay1ibWVudS1saXN0Jy4i CisgIGAod2l0aC1ib29rbWFyay10ZXN0CisgICAgKGxldCAoKGJvb2ttYXJrLWJtZW51LWJ1ZmZl ciAiKkJvb2ttYXJrIExpc3QgLSBUZXN0aW5nKiIpKQorICAgICAgKHVud2luZC1wcm90ZWN0Cisg ICAgICAgICAgKHNhdmUtd2luZG93LWV4Y3Vyc2lvbgorICAgICAgICAgICAgKGJvb2ttYXJrLWJt ZW51LWxpc3QpCisgICAgICAgICAgICAsQGJvZHkpCisgICAgICAgIChraWxsLWJ1ZmZlciBib29r bWFyay1ibWVudS1idWZmZXIpKSkpKQorCisoZXJ0LWRlZnRlc3QgYm9va21hcmstYm1lbnUuZW51 LWVkaXQtYW5ub3RhdGlvbi9zaG93LWFubm90YXRpb24gKCkKKyAgKHdpdGgtYm9va21hcmstYm1l bnUtdGVzdAorICAgKGJvb2ttYXJrLXNldC1hbm5vdGF0aW9uICJuYW1lIiAiZm9vIikKKyAgIChi b29rbWFyay1ibWVudS1lZGl0LWFubm90YXRpb24pCisgICAoc2hvdWxkIChzdHJpbmctbWF0Y2gg ImZvbyIgKGJ1ZmZlci1zdHJpbmcpKSkKKyAgIChraWxsLWJ1ZmZlciAoY3VycmVudC1idWZmZXIp KSkpCisKKyhlcnQtZGVmdGVzdCBib29rbWFyay1ibWVudS1zZW5kLWVkaXRlZC1hbm5vdGF0aW9u ICgpCisgICh3aXRoLWJvb2ttYXJrLWJtZW51LXRlc3QKKyAgIChib29rbWFyay1ibWVudS1lZGl0 LWFubm90YXRpb24pCisgICAoaW5zZXJ0ICJmb28iKQorICAgKGJvb2ttYXJrLXNlbmQtZWRpdGVk LWFubm90YXRpb24pCisgICAoc2hvdWxkIChlcXVhbCAoYm9va21hcmstZ2V0LWFubm90YXRpb24g Im5hbWUiKSAiZm9vIikpKSkKKworKGVydC1kZWZ0ZXN0IGJvb2ttYXJrLWJtZW51LXNlbmQtZWRp dGVkLWFubm90YXRpb24vcmVzdG9yZS1mb2N1cyAoKQorICAiVGVzdCBmb3IgaHR0cHM6Ly9kZWJi dWdzLmdudS5vcmcvMjAxNTAgLiIKKyAgKHdpdGgtYm9va21hcmstYm1lbnUtdGVzdAorICAgKGJv b2ttYXJrLWJtZW51LWVkaXQtYW5ub3RhdGlvbikKKyAgIChpbnNlcnQgImZvbyIpCisgICAoYm9v a21hcmstc2VuZC1lZGl0ZWQtYW5ub3RhdGlvbikKKyAgIChzaG91bGQgKGVxdWFsIChidWZmZXIt bmFtZSAoY3VycmVudC1idWZmZXIpKSBib29rbWFyay1ibWVudS1idWZmZXIpKQorICAgKHNob3Vs ZCAobG9va2luZy1hdCAibmFtZSIpKSkpCiAKIChwcm92aWRlICdib29rbWFyay10ZXN0cykKIDs7 OyBib29rbWFyay10ZXN0cy5lbCBlbmRzIGhlcmUKLS0gCjIuMTEuMAoK --000000000000ffaaf5058d8fbd34-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 13 09:25:27 2019 Received: (at 20150) by debbugs.gnu.org; 13 Jul 2019 13:25:27 +0000 Received: from localhost ([127.0.0.1]:41617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmI1n-0002Vl-5W for submit@debbugs.gnu.org; Sat, 13 Jul 2019 09:25:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmI1l-0002VX-J4 for 20150@debbugs.gnu.org; Sat, 13 Jul 2019 09:25:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hmI1f-0007bq-Uy; Sat, 13 Jul 2019 09:25:20 -0400 Received: from [176.228.60.248] (port=1506 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hmI1Q-0002hy-VJ; Sat, 13 Jul 2019 09:25:08 -0400 Date: Sat, 13 Jul 2019 16:24:56 +0300 Message-Id: <8336ja12zb.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Sat, 13 Jul 2019 15:09:39 +0200) Subject: Re: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) References: <83r26u1jeu.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20150 Cc: 20150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Sat, 13 Jul 2019 15:09:39 +0200 > Cc: 20150@debbugs.gnu.org > > > Hmm... we declare a non-internal variable obsolete and replace it with > > an internal variable? Why is that a good idea? Does the new variable > > have to be internal? > > I thought about it a bit more, and I guess it doesn't have to be internal. I > suggest that the new variable should be kept internal for now though. You mean, it doesn't have to be obsolete? > I also don't know why I named the new variable bookmark-annotation--name, so > I've changed that to bookmark--annotation-name to better reflect current > practices. Hmm... I don't see bookmark--annotation-name in the patch. Did you send the correct patch? From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 13 09:52:17 2019 Received: (at 20150) by debbugs.gnu.org; 13 Jul 2019 13:52:17 +0000 Received: from localhost ([127.0.0.1]:41630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmIRk-00038R-Sd for submit@debbugs.gnu.org; Sat, 13 Jul 2019 09:52:17 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:38505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmIRj-00038C-3s for 20150@debbugs.gnu.org; Sat, 13 Jul 2019 09:52:15 -0400 Received: by mail-wm1-f53.google.com with SMTP id s15so11241201wmj.3 for <20150@debbugs.gnu.org>; Sat, 13 Jul 2019 06:52:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BEcOHUnE4+9l+hizPu5FoF8oc9mdk+/e+YguqMU4+nk=; b=CJc1ZcvbbhERVa/SkVyJm44CCMJENC9eSRYSJo6teIoCJ+F9hUTkThmQx73visrspe XCVmgLa9C1avAPe+i/P+YEYd9GvbORY6a4sH3FwVSZYBbXURA8friavceYQzm94+yPos NbSZYAvwpQqG++98ZsfXnQofUgIt8gdJSp6joRY4wiuvQGwzNRRJUU4HrV81NDSDNBD2 KD4gMwmtVt7haPn7BsC8MpTZuD59S+hgbDk0yQdqOW1LRL/GZFzLNIW5zhyTMkNkucmL YbTTCOeT2QGACOcsl+2y8KsF+WXSBxZsuxov1niMYYed2I6gZzq/ld3mVHUPK9EHE+x4 fefw== X-Gm-Message-State: APjAAAVOjCUFY/CW7bB4iHtMz6x3WfQiS0SsYecSK+2s/2VI2a4Dg8PQ UI0UTtv5VkAwSQdue4F8GHET/yFLtNGIkz9fU7c= X-Google-Smtp-Source: APXvYqwGWyaOIzFKHBfFfCty6dik43aVpKrqdukBl1oy6ts9ruPNkYJ/yjfDVaE6XrjdRk7noVc3+9H/QFrCH5Q3mSw= X-Received: by 2002:a1c:7c08:: with SMTP id x8mr14967978wmc.19.1563025929217; Sat, 13 Jul 2019 06:52:09 -0700 (PDT) MIME-Version: 1.0 References: <83r26u1jeu.fsf@gnu.org> <8336ja12zb.fsf@gnu.org> In-Reply-To: <8336ja12zb.fsf@gnu.org> From: Stefan Kangas Date: Sat, 13 Jul 2019 15:51:57 +0200 Message-ID: Subject: Re: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 20150 Cc: 20150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > > I also don't know why I named the new variable bookmark-annotation--name, so > > I've changed that to bookmark--annotation-name to better reflect current > > practices. > > Hmm... I don't see bookmark--annotation-name in the patch. Did you > send the correct patch? Oops, please ignore that part. I wrote the wrong variable name, and actually meant to say: I also don't know why I initially named the new variable bookmark-annotation--from-bookmark-list, so in the updated patch I've changed that to bookmark--annotation-from-bookmark-list to better reflect current practices. (Note the placement of dashes.) bookmark-annotation-name is unchanged in the updated patch. I didn't rename it nor make it obsolete. I don't think it matters too much -- it could be internal, but it might not be worth renaming. Sorry for the confusion. Thanks, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 13 21:48:39 2019 Received: (at 20150) by debbugs.gnu.org; 14 Jul 2019 01:48:40 +0000 Received: from localhost ([127.0.0.1]:43656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmTd1-0002Q8-MJ for submit@debbugs.gnu.org; Sat, 13 Jul 2019 21:48:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmTd0-0002Pt-D2 for 20150@debbugs.gnu.org; Sat, 13 Jul 2019 21:48:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hmTcv-0000Yg-2y; Sat, 13 Jul 2019 21:48:33 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1hmTct-0005sJ-1C; Sat, 13 Jul 2019 21:48:31 -0400 From: Glenn Morris To: Stefan Kangas Subject: Re: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) References: <83r26u1jeu.fsf@gnu.org> <8336ja12zb.fsf@gnu.org> X-Spook: Toxic ASDIC Consul spies Recall Europol UOP Uzi X-Ran: 4ai%%zJRVzAU6TU7d"3/oa+BAs{"vzN6=:1UdyABr&siwYymQ14+4oyJ!6VhF (Stefan Kangas's message of "Sat, 13 Jul 2019 15:51:57 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20150 Cc: Eli Zaretskii , 20150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Off topic, but it seems to me like you should request write access so you can apply changes directly. I believe you use "request for inclusion form" at https://savannah.gnu.org/project/memberlist.php?group=emacs From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 02:04:54 2019 Received: (at 20150) by debbugs.gnu.org; 14 Jul 2019 06:04:55 +0000 Received: from localhost ([127.0.0.1]:43730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmXd0-0004ea-OC for submit@debbugs.gnu.org; Sun, 14 Jul 2019 02:04:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmXcz-0004eO-Am for 20150@debbugs.gnu.org; Sun, 14 Jul 2019 02:04:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48099) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hmXcu-0006NP-0Z; Sun, 14 Jul 2019 02:04:48 -0400 Received: from [176.228.60.248] (port=2718 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hmXcs-0005os-7c; Sun, 14 Jul 2019 02:04:46 -0400 Date: Sun, 14 Jul 2019 09:04:29 +0300 Message-Id: <83a7dhywwi.fsf@gnu.org> From: Eli Zaretskii To: Glenn Morris In-reply-to: (message from Glenn Morris on Sat, 13 Jul 2019 21:48:30 -0400) Subject: Re: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) References: <83r26u1jeu.fsf@gnu.org> <8336ja12zb.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20150 Cc: 20150@debbugs.gnu.org, stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Glenn Morris > Cc: Eli Zaretskii , 20150@debbugs.gnu.org > Date: Sat, 13 Jul 2019 21:48:30 -0400 > > > Off topic, but it seems to me like you should request write access He did. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 02:29:24 2019 Received: (at 20150-done) by debbugs.gnu.org; 14 Jul 2019 06:29:24 +0000 Received: from localhost ([127.0.0.1]:43741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmY0i-0005FY-1h for submit@debbugs.gnu.org; Sun, 14 Jul 2019 02:29:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmY0g-0005FK-Pz for 20150-done@debbugs.gnu.org; Sun, 14 Jul 2019 02:29:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hmY0b-0001UK-L3; Sun, 14 Jul 2019 02:29:17 -0400 Received: from [176.228.60.248] (port=4211 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hmY0b-0000Qj-33; Sun, 14 Jul 2019 02:29:17 -0400 Date: Sun, 14 Jul 2019 09:29:01 +0300 Message-Id: <837e8lyvrm.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Sat, 13 Jul 2019 15:09:39 +0200) Subject: Re: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) References: <83r26u1jeu.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20150-done Cc: 20150-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Sat, 13 Jul 2019 15:09:39 +0200 > Cc: 20150@debbugs.gnu.org > > Please see this updated patch with those two changes. Thanks, pushed to the master branch. From unknown Mon Jun 23 22:03:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 11 Aug 2019 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator