From unknown Thu Aug 14 12:20:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20149: Cannot byte-compile 'undo-tree' since commit 801eda8a2 Resent-From: Vladimir Lomov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Mar 2015 05:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 20149@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14268285474693 (code B ref -1); Fri, 20 Mar 2015 05:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 20 Mar 2015 05:15:47 +0000 Received: from localhost ([127.0.0.1]:58742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYpHf-0001Dc-0b for submit@debbugs.gnu.org; Fri, 20 Mar 2015 01:15:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41763) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYpHd-0001DQ-B0 for submit@debbugs.gnu.org; Fri, 20 Mar 2015 01:15:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYpHX-0005bY-JC for submit@debbugs.gnu.org; Fri, 20 Mar 2015 01:15:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYpHX-0005bS-Fh for submit@debbugs.gnu.org; Fri, 20 Mar 2015 01:15:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYpHW-0007uF-L6 for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 01:15:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYpHS-0005YG-K5 for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 01:15:38 -0400 Received: from mail-lb0-x22d.google.com ([2a00:1450:4010:c04::22d]:33981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYpHS-0005XJ-Co for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 01:15:34 -0400 Received: by lbbsy1 with SMTP id sy1so67798806lbb.1 for ; Thu, 19 Mar 2015 22:15:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=Unsrp/MMf9WJqNvHFrt1z6muEYXhs5yJJ25w1hNMJ0A=; b=IX+gL2hEJhEHU7WpoPZFJUKMSEuZZx+WK3BbLImqnSqJoUWCKUkdd+v9D2swVK3HQC 7FFkxyO5z4ArTSaU8jZQfo4u0nSuRP/BDgFqftGhbWkIMPswwf7YoW79XBVa02Blb6XJ 9Ra2JBKw9G6OqUgT3HZvFstVPZfkuQz5ZZu61ME2Z1py0HvB39/WuZFm8BoGPoK445EZ z0uJsnh1uNG9Ig4Cz8Z+BlVo+kSy6rAMQajzdi6MnonGNCRSpE0xs/Oit1WTbFhmJe5W CoBK40FiQ0LI3bWbF4XZxfPdvexrDTdnpUN06ePRYfFoQ9+nlg8GQ8gJaWaQPYuY+tLc qAqw== X-Received: by 10.152.87.199 with SMTP id ba7mr65096996lab.75.1426828533199; Thu, 19 Mar 2015 22:15:33 -0700 (PDT) Received: from smoon ([31.47.187.164]) by mx.google.com with ESMTPSA id rk3sm687027lbb.23.2015.03.19.22.15.31 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Mar 2015 22:15:31 -0700 (PDT) Date: Fri, 20 Mar 2015 13:15:29 +0800 From: Vladimir Lomov Message-ID: <20150320051529.GC857@smoon.vl-lomov.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hello, I was able to byte-compile 'undo-tree' package using Emacs from commit f925fc93 but since that commit Emacs stops compilation with message: In undo-tree-update-menu-bar: undo-tree.el:1232:7:Warning: reference to free variable `undo-tree-mode' undo-tree.el:1481:1:Error: Symbol's function definition is void: undo-tree-make-node I don't think this is a problem of the package, because the next four commits: 801eda8a2, a961dcedeb, b0743354e, 508049aa have some trouble(s), so I wasn't able to compile Emacs. Below is terminal output before the stop: Loading /home/vladimir/works/projects/pkgbuild/emacs/src/emacs/lisp/select.el (source)... Loading /home/vladimir/works/projects/pkgbuild/emacs/src/emacs/lisp/emacs-lisp/timer.el (source)... Eager macro-expansion failure: (void-function cl-every) Eager macro-expansion failure: (void-function cl-every) Symbol's function definition is void: cl-every --- WBR, Vladimir Lomov -- new, adj.: Different color from previous model. From unknown Thu Aug 14 12:20:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20149: Cannot byte-compile 'undo-tree' since commit 801eda8a2 Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Mar 2015 07:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Vladimir Lomov Cc: 20149@debbugs.gnu.org Received: via spool by 20149-submit@debbugs.gnu.org id=B20149.142683760218700 (code B ref 20149); Fri, 20 Mar 2015 07:47:02 +0000 Received: (at 20149) by debbugs.gnu.org; 20 Mar 2015 07:46:42 +0000 Received: from localhost ([127.0.0.1]:58790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYrdh-0004rX-Q6 for submit@debbugs.gnu.org; Fri, 20 Mar 2015 03:46:42 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:52389) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYrde-0004rM-Tk for 20149@debbugs.gnu.org; Fri, 20 Mar 2015 03:46:40 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 3A70F207F6 for <20149@debbugs.gnu.org>; Fri, 20 Mar 2015 03:46:36 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Fri, 20 Mar 2015 03:46:38 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:to:cc:subject:references :date:in-reply-to:message-id:mime-version:content-type; s= smtpout; bh=H0cOnEKunjzY1u0cTKhD2eg34BI=; b=scun5NA1qglrTWUvM9vq s8VQ+Sr/bTxYCBkX/ebPHwDndoOb71t1cQlj26zq5hoPkoX+KXZTJoT1Gc63dXrL TPidhZnqufvsZ4qneaygelTf+o7b1C3XRVl4nS7yShy/jPMQI2Uu/F+eR9ACRQoG sfbYo7ilJBnx952REQN69wU= X-Sasl-enc: r+X3F5leeHFL8g6LhLhPRi9mKgacNEYxLdWu1yU4Kp8u 1426837597 Received: from thinkpad-t440p (unknown [2.161.210.144]) by mail.messagingengine.com (Postfix) with ESMTPA id 7150B6800F3; Fri, 20 Mar 2015 03:46:37 -0400 (EDT) From: Tassilo Horn References: <20150320051529.GC857@smoon.vl-lomov.ru> Date: Fri, 20 Mar 2015 08:46:34 +0100 In-Reply-To: <20150320051529.GC857@smoon.vl-lomov.ru> (Vladimir Lomov's message of "Fri, 20 Mar 2015 13:15:29 +0800") Message-ID: <87pp84ru05.fsf@gnu.org> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Vladimir Lomov writes: > I was able to byte-compile 'undo-tree' package using Emacs from > commit f925fc93 but since that commit Emacs stops compilation with > message: > > In undo-tree-update-menu-bar: > undo-tree.el:1232:7:Warning: reference to free variable `undo-tree-mode' > undo-tree.el:1481:1:Error: Symbol's function definition is void: undo-tree-make-node > > I don't think this is a problem of the package, because the next four > commits: 801eda8a2, a961dcedeb, b0743354e, 508049aa have some > trouble(s), so I wasn't able to compile Emacs. Below is terminal output > before the stop: > > Loading /home/vladimir/works/projects/pkgbuild/emacs/src/emacs/lisp/select.el (source)... > Loading > /home/vladimir/works/projects/pkgbuild/emacs/src/emacs/lisp/emacs-lisp/timer.el > (source)... > Eager macro-expansion failure: (void-function cl-every) > Eager macro-expansion failure: (void-function cl-every) > Symbol's function definition is void: cl-every This has already been reported as bug#20125, and it's already fixed. Could you please verify that compiling undo-tree works again with the current emacs git version? If so, feel free to close this bug by replying to 20149-done@debbugs.gnu.org. Bye, Tassilo From unknown Thu Aug 14 12:20:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20149: Cannot byte-compile 'undo-tree' since commit 801eda8a2 Resent-From: Vladimir Lomov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Mar 2015 08:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 20149@debbugs.gnu.org Cc: Tassilo Horn Received: via spool by 20149-submit@debbugs.gnu.org id=B20149.142683941721439 (code B ref 20149); Fri, 20 Mar 2015 08:17:01 +0000 Received: (at 20149) by debbugs.gnu.org; 20 Mar 2015 08:16:57 +0000 Received: from localhost ([127.0.0.1]:58808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYs6z-0005Zj-1G for submit@debbugs.gnu.org; Fri, 20 Mar 2015 04:16:57 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:34113) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYs6w-0005ZS-BY for 20149@debbugs.gnu.org; Fri, 20 Mar 2015 04:16:54 -0400 Received: by lbbsy1 with SMTP id sy1so70023813lbb.1 for <20149@debbugs.gnu.org>; Fri, 20 Mar 2015 01:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=T7gHacjJvyGTdTDyAz3SaFVZV4g9MzyaXCockUfy6hM=; b=UqeN3KUzbFgoAAYtBiJ/bEPHomUfyfi5G7PDFu1AauDiRo0XW2jDRTUh+fa2u7+A8X PAOv2hhzrDX6V7PJ2LD6g/nXfg3TChqx9QFpvsV28Wqs/z7dFiD3eOuwtwV8OM1eM2uM ohZXr5T1n0eZiCJAZ39KSQXMpSuyU9VmAjqF47D8NOB6Axm0kSOQrw1btd7ybrLB+iyE 7NiYmmLcBL9QtJyaDmkNzrK/663sbG7W7+5AAgjxWWpj61fuspuvDFtfrDuqDMzYNYt9 ZC7g5DaRoaxQQKHGQZHZ/OsZ0HuhVDg+dnDSguqaC/ca/fWaxs2/nIo1mrBLGKjRmND5 SOcA== X-Received: by 10.152.183.196 with SMTP id eo4mr9741585lac.22.1426839408637; Fri, 20 Mar 2015 01:16:48 -0700 (PDT) Received: from smoon ([31.47.187.164]) by mx.google.com with ESMTPSA id g6sm771477lab.2.2015.03.20.01.16.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Mar 2015 01:16:47 -0700 (PDT) Date: Fri, 20 Mar 2015 16:16:45 +0800 From: Vladimir Lomov Message-ID: <20150320081645.GD857@smoon.vl-lomov.ru> References: <20150320051529.GC857@smoon.vl-lomov.ru> <87pp84ru05.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87pp84ru05.fsf@gnu.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hello, ** Tassilo Horn [2015-03-20 08:46:34 +0100]: > Vladimir Lomov writes: > >> I was able to byte-compile 'undo-tree' package using Emacs from >> commit f925fc93 but since that commit Emacs stops compilation with >> message: >> >> In undo-tree-update-menu-bar: >> undo-tree.el:1232:7:Warning: reference to free variable `undo-tree-mode' >> undo-tree.el:1481:1:Error: Symbol's function definition is void: undo-tree-make-node >> >> I don't think this is a problem of the package, because the next four >> commits: 801eda8a2, a961dcedeb, b0743354e, 508049aa have some >> trouble(s), so I wasn't able to compile Emacs. Below is terminal output >> before the stop: >> >> Loading /home/vladimir/works/projects/pkgbuild/emacs/src/emacs/lisp/select.el (source)... >> Loading >> /home/vladimir/works/projects/pkgbuild/emacs/src/emacs/lisp/emacs-lisp/timer.el >> (source)... >> Eager macro-expansion failure: (void-function cl-every) >> Eager macro-expansion failure: (void-function cl-every) >> Symbol's function definition is void: cl-every > > This has already been reported as bug#20125, and it's already fixed. I'm sorry, but you got me wrong. I wasn't concerned by this error (bug#20125) and these messages: Eager macro-expansion failure: (void-function cl-every) Eager macro-expansion failure: (void-function cl-every) Symbol's function definition is void: cl-every but with package 'undo-tree' and this message from Emacs: In undo-tree-update-menu-bar: undo-tree.el:1232:7:Warning: reference to free variable `undo-tree-mode' undo-tree.el:1481:1:Error: Symbol's function definition is void: undo-tree-make-node I tracked down to the commit when Emacs was able to compile the 'undo-tree' package, this is commit f925fc93 but starting from next commit, 801eda8a2, the package isn't byte-compiled. Actually, I wasn't able to compile Emacs taking source from commit 801eda8a2 and next three ones. > Could you please verify that compiling undo-tree works again with the > current emacs git version? If so, feel free to close this bug by > replying to 20149-done@debbugs.gnu.org. I did fresh Emacs build (commit 395a76a) and I see the same message when byte-compile 'undo-tree' package. > Bye, > Tassilo --- WBR, Vladimir Lomov -- "The rotter who simpers that he sees no difference between a five-dollar bill and a whip deserves to learn the difference on his own back -- as, I think, he will." -- Francisco d'Anconia, in Ayn Rand's _Atlas Shrugged_ From unknown Thu Aug 14 12:20:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20149: Cannot byte-compile 'undo-tree' since commit 801eda8a2 Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Mar 2015 08:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Vladimir Lomov Cc: 20149@debbugs.gnu.org Received: via spool by 20149-submit@debbugs.gnu.org id=B20149.142684180524949 (code B ref 20149); Fri, 20 Mar 2015 08:57:02 +0000 Received: (at 20149) by debbugs.gnu.org; 20 Mar 2015 08:56:45 +0000 Received: from localhost ([127.0.0.1]:58820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYsjV-0006UK-4j for submit@debbugs.gnu.org; Fri, 20 Mar 2015 04:56:45 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:44894) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYsjS-0006UB-0x for 20149@debbugs.gnu.org; Fri, 20 Mar 2015 04:56:43 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4BD1A20926 for <20149@debbugs.gnu.org>; Fri, 20 Mar 2015 04:56:39 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 20 Mar 2015 04:56:41 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:to:cc:subject:references :date:in-reply-to:message-id:mime-version:content-type; s= smtpout; bh=7kpvJT1dhdpUGSaTh2z9AcMstII=; b=D5Zp3v9OAOGSXl8QCKyz 8N14NU495ZUDfI6Eki26N0OWJsupaHfu8Ag4i825U2pQYiS3KKbIXofvhJxFALt8 ZN+qMcJMPJSho6nB+AMLUyDgaMuON5TF9UhdB1g6/zBzCd/5tcG3W7ZrZnRQszSw 1i3kC0jO5SplfbPgzdgU/Z4= X-Sasl-enc: PslYeGf0hqYk6drTYjnGOvBCbmjJ5XwoIAEOJD/DNIT3 1426841800 Received: from thinkpad-t440p (unknown [2.161.210.144]) by mail.messagingengine.com (Postfix) with ESMTPA id 879736800BC; Fri, 20 Mar 2015 04:56:40 -0400 (EDT) From: Tassilo Horn References: <20150320051529.GC857@smoon.vl-lomov.ru> <87pp84ru05.fsf@gnu.org> <20150320081645.GD857@smoon.vl-lomov.ru> Date: Fri, 20 Mar 2015 09:56:38 +0100 In-Reply-To: <20150320081645.GD857@smoon.vl-lomov.ru> (Vladimir Lomov's message of "Fri, 20 Mar 2015 16:16:45 +0800") Message-ID: <87lhisrqrd.fsf@gnu.org> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Vladimir Lomov writes: > In undo-tree-update-menu-bar: > undo-tree.el:1232:7:Warning: reference to free variable `undo-tree-mode' > undo-tree.el:1481:1:Error: Symbol's function definition is void: undo-tree-make-node > > I tracked down to the commit when Emacs was able to compile the > 'undo-tree' package, this is commit f925fc93 but starting from next > commit, 801eda8a2, the package isn't byte-compiled. Actually, I wasn't > able to compile Emacs taking source from commit 801eda8a2 and next three > ones. > >> Could you please verify that compiling undo-tree works again with the >> current emacs git version? If so, feel free to close this bug by >> replying to 20149-done@debbugs.gnu.org. > > I did fresh Emacs build (commit 395a76a) and I see the same message when > byte-compile 'undo-tree' package. Ok, I see, and I confirm the compile error. `undo-tree-make-node' is an undo-tree-node constructor. So it seems to be another problem with Stefan's latest cl-defstruct changes. I've added him to Cc. undo-tree is here: http://www.dr-qubit.org/git/undo-tree.git The definition of the constructor is this: --8<---------------cut here---------------start------------->8--- (defstruct (undo-tree-node (:type vector) ; create unnamed struct (:constructor nil) (:constructor undo-tree-make-node (previous undo &optional redo &aux (timestamp (current-time)) (branch 0))) (:constructor undo-tree-make-node-backwards (next-node undo &optional redo &aux (next (list next-node)) (timestamp (current-time)) (branch 0))) (:copier nil)) previous next undo redo timestamp branch meta-data) --8<---------------cut here---------------end--------------->8--- The error location (which looks strange to me) is this: --8<---------------cut here---------------start------------->8--- (defun undo-tree-register-data-p (data) ;; <== HERE (and (vectorp data) (= (length data) 2) (undo-tree-node-p (undo-tree-register-data-node data)))) --8<---------------cut here---------------end--------------->8--- Bye, Tassilo From unknown Thu Aug 14 12:20:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20149: Cannot byte-compile 'undo-tree' since commit 801eda8a2 Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Mar 2015 11:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Vladimir Lomov Cc: 20149@debbugs.gnu.org, Stefan Monnier Received: via spool by 20149-submit@debbugs.gnu.org id=B20149.14268496204617 (code B ref 20149); Fri, 20 Mar 2015 11:07:02 +0000 Received: (at 20149) by debbugs.gnu.org; 20 Mar 2015 11:07:00 +0000 Received: from localhost ([127.0.0.1]:58844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYulX-0001CO-Qh for submit@debbugs.gnu.org; Fri, 20 Mar 2015 07:07:00 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:54850) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYulV-0001CG-CK for 20149@debbugs.gnu.org; Fri, 20 Mar 2015 07:06:58 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EE0FD209B8 for <20149@debbugs.gnu.org>; Fri, 20 Mar 2015 07:06:54 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 20 Mar 2015 07:06:57 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:to:cc:subject:references :date:in-reply-to:message-id:mime-version:content-type; s= smtpout; bh=GplmLueU/zZ3XVtHdSM79HVLSY4=; b=CSNQMNvSztoKQHQfxMAJ 9QRWbUkpsOykJdcpV63lBvrcmbrKe0LI5WJH1trCB6lXzusqyMOv16kn2enSvhlP XXz24Tet4ISqkCFSOC/VUGxQaxosuRty/G6ndjtOR3qIavimYmXTQqeJ3v+5ukJL jMZkX+hyKtos/79e4i12U5s= X-Sasl-enc: rd1cMHfGZTqf/SRz0iLD/nuYaixc4v4pneaj/S6D7TOd 1426849616 Received: from thinkpad-t440p (unknown [2.161.210.144]) by mail.messagingengine.com (Postfix) with ESMTPA id 1BB03C00025; Fri, 20 Mar 2015 07:06:55 -0400 (EDT) From: Tassilo Horn References: <20150320051529.GC857@smoon.vl-lomov.ru> <87pp84ru05.fsf@gnu.org> <20150320081645.GD857@smoon.vl-lomov.ru> <87lhisrqrd.fsf@gnu.org> Date: Fri, 20 Mar 2015 12:06:53 +0100 In-Reply-To: <87lhisrqrd.fsf@gnu.org> (Tassilo Horn's message of "Fri, 20 Mar 2015 09:56:38 +0100") Message-ID: <87h9tgrkqa.fsf@gnu.org> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Tassilo Horn writes: > Vladimir Lomov writes: > >> In undo-tree-update-menu-bar: >> undo-tree.el:1232:7:Warning: reference to free variable `undo-tree-mode' >> undo-tree.el:1481:1:Error: Symbol's function definition is void: undo-tree-make-node >> >> I tracked down to the commit when Emacs was able to compile the >> 'undo-tree' package, this is commit f925fc93 but starting from next >> commit, 801eda8a2, the package isn't byte-compiled. Actually, I wasn't >> able to compile Emacs taking source from commit 801eda8a2 and next three >> ones. >> >>> Could you please verify that compiling undo-tree works again with the >>> current emacs git version? If so, feel free to close this bug by >>> replying to 20149-done@debbugs.gnu.org. >> >> I did fresh Emacs build (commit 395a76a) and I see the same message when >> byte-compile 'undo-tree' package. > > Ok, I see, and I confirm the compile error. `undo-tree-make-node' is an > undo-tree-node constructor. So it seems to be another problem with > Stefan's latest cl-defstruct changes. I've added him to Cc. Ups, of course I didn't. ;-) So now he is. > undo-tree is here: http://www.dr-qubit.org/git/undo-tree.git > > The definition of the constructor is this: > > (defstruct > (undo-tree-node > (:type vector) ; create unnamed struct > (:constructor nil) > (:constructor undo-tree-make-node > (previous undo > &optional redo > &aux > (timestamp (current-time)) > (branch 0))) > (:constructor undo-tree-make-node-backwards > (next-node undo > &optional redo > &aux > (next (list next-node)) > (timestamp (current-time)) > (branch 0))) > (:copier nil)) > previous next undo redo timestamp branch meta-data) > > > The error location (which looks strange to me) is this: > > (defun undo-tree-register-data-p (data) ;; <== HERE > (and (vectorp data) > (= (length data) 2) > (undo-tree-node-p (undo-tree-register-data-node data)))) > > Bye, > Tassilo From unknown Thu Aug 14 12:20:07 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Vladimir Lomov Subject: bug#20149: closed (Re: bug#20149: Cannot byte-compile 'undo-tree' since commit 801eda8a2) Message-ID: References: <20150320051529.GC857@smoon.vl-lomov.ru> X-Gnu-PR-Message: they-closed 20149 X-Gnu-PR-Package: emacs Reply-To: 20149@debbugs.gnu.org Date: Fri, 20 Mar 2015 20:31:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1426883462-18129-1" This is a multi-part message in MIME format... ------------=_1426883462-18129-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #20149: Cannot byte-compile 'undo-tree' since commit 801eda8a2 which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 20149@debbugs.gnu.org. --=20 20149: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D20149 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1426883462-18129-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 20149-done) by debbugs.gnu.org; 20 Mar 2015 20:30:19 +0000 Received: from localhost ([127.0.0.1]:59386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZ3Yg-0004hV-Ow for submit@debbugs.gnu.org; Fri, 20 Mar 2015 16:30:19 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:57164) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZ3Yd-0004hN-Vl for 20149-done@debbugs.gnu.org; Fri, 20 Mar 2015 16:30:16 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t2KKUERb015153; Fri, 20 Mar 2015 16:30:14 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 5862166144; Fri, 20 Mar 2015 16:30:14 -0400 (EDT) From: Stefan Monnier To: Tassilo Horn Subject: Re: bug#20149: Cannot byte-compile 'undo-tree' since commit 801eda8a2 Message-ID: References: <20150320051529.GC857@smoon.vl-lomov.ru> <87pp84ru05.fsf@gnu.org> <20150320081645.GD857@smoon.vl-lomov.ru> <87lhisrqrd.fsf@gnu.org> Date: Fri, 20 Mar 2015 16:30:14 -0400 In-Reply-To: <87lhisrqrd.fsf@gnu.org> (Tassilo Horn's message of "Fri, 20 Mar 2015 09:56:38 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.4 X-NAI-Spam-Rules: 3 Rules triggered GEN_SPAM_FEATRE=0.2, SUBJECT_ENDS_LC_DIG=0.2, RV5251=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5251> : inlines <2455> : streams <1408768> : uri <1885812> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 20149-done Cc: Vladimir Lomov , 20149-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) I installed a patch which should fix it, Stefan ------------=_1426883462-18129-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 20 Mar 2015 05:15:47 +0000 Received: from localhost ([127.0.0.1]:58742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYpHf-0001Dc-0b for submit@debbugs.gnu.org; Fri, 20 Mar 2015 01:15:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41763) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYpHd-0001DQ-B0 for submit@debbugs.gnu.org; Fri, 20 Mar 2015 01:15:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYpHX-0005bY-JC for submit@debbugs.gnu.org; Fri, 20 Mar 2015 01:15:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYpHX-0005bS-Fh for submit@debbugs.gnu.org; Fri, 20 Mar 2015 01:15:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYpHW-0007uF-L6 for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 01:15:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYpHS-0005YG-K5 for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 01:15:38 -0400 Received: from mail-lb0-x22d.google.com ([2a00:1450:4010:c04::22d]:33981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYpHS-0005XJ-Co for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 01:15:34 -0400 Received: by lbbsy1 with SMTP id sy1so67798806lbb.1 for ; Thu, 19 Mar 2015 22:15:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=Unsrp/MMf9WJqNvHFrt1z6muEYXhs5yJJ25w1hNMJ0A=; b=IX+gL2hEJhEHU7WpoPZFJUKMSEuZZx+WK3BbLImqnSqJoUWCKUkdd+v9D2swVK3HQC 7FFkxyO5z4ArTSaU8jZQfo4u0nSuRP/BDgFqftGhbWkIMPswwf7YoW79XBVa02Blb6XJ 9Ra2JBKw9G6OqUgT3HZvFstVPZfkuQz5ZZu61ME2Z1py0HvB39/WuZFm8BoGPoK445EZ z0uJsnh1uNG9Ig4Cz8Z+BlVo+kSy6rAMQajzdi6MnonGNCRSpE0xs/Oit1WTbFhmJe5W CoBK40FiQ0LI3bWbF4XZxfPdvexrDTdnpUN06ePRYfFoQ9+nlg8GQ8gJaWaQPYuY+tLc qAqw== X-Received: by 10.152.87.199 with SMTP id ba7mr65096996lab.75.1426828533199; Thu, 19 Mar 2015 22:15:33 -0700 (PDT) Received: from smoon ([31.47.187.164]) by mx.google.com with ESMTPSA id rk3sm687027lbb.23.2015.03.19.22.15.31 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Mar 2015 22:15:31 -0700 (PDT) Date: Fri, 20 Mar 2015 13:15:29 +0800 From: Vladimir Lomov To: bug-gnu-emacs@gnu.org Subject: Cannot byte-compile 'undo-tree' since commit 801eda8a2 Message-ID: <20150320051529.GC857@smoon.vl-lomov.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hello, I was able to byte-compile 'undo-tree' package using Emacs from commit f925fc93 but since that commit Emacs stops compilation with message: In undo-tree-update-menu-bar: undo-tree.el:1232:7:Warning: reference to free variable `undo-tree-mode' undo-tree.el:1481:1:Error: Symbol's function definition is void: undo-tree-make-node I don't think this is a problem of the package, because the next four commits: 801eda8a2, a961dcedeb, b0743354e, 508049aa have some trouble(s), so I wasn't able to compile Emacs. Below is terminal output before the stop: Loading /home/vladimir/works/projects/pkgbuild/emacs/src/emacs/lisp/select.el (source)... Loading /home/vladimir/works/projects/pkgbuild/emacs/src/emacs/lisp/emacs-lisp/timer.el (source)... Eager macro-expansion failure: (void-function cl-every) Eager macro-expansion failure: (void-function cl-every) Symbol's function definition is void: cl-every --- WBR, Vladimir Lomov -- new, adj.: Different color from previous model. ------------=_1426883462-18129-1-- From unknown Thu Aug 14 12:20:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20149: Cannot byte-compile 'undo-tree' since commit 801eda8a2 Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Mar 2015 21:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Vladimir Lomov , 20149-done@debbugs.gnu.org Received: via spool by 20149-done@debbugs.gnu.org id=D20149.142688758324113 (code D ref 20149); Fri, 20 Mar 2015 21:40:02 +0000 Received: (at 20149-done) by debbugs.gnu.org; 20 Mar 2015 21:39:43 +0000 Received: from localhost ([127.0.0.1]:59398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZ4dr-0006Gr-4j for submit@debbugs.gnu.org; Fri, 20 Mar 2015 17:39:43 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:33721) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZ4do-0006Gi-Jn for 20149-done@debbugs.gnu.org; Fri, 20 Mar 2015 17:39:41 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 8F25320268 for <20149-done@debbugs.gnu.org>; Fri, 20 Mar 2015 17:39:37 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute3.internal (MEProxy); Fri, 20 Mar 2015 17:39:39 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:to:cc:subject:references :date:in-reply-to:message-id:mime-version:content-type; s= smtpout; bh=ieh1nWWohVGQyLaj8TsGY9Qx4J8=; b=nGDIh8FGgs8+2sLLcdIi K+3c4VcrT8RdNh/wu28RRbfI8remZ177h91T7woaZEv2BInVJ4uCbiG1XZaxQiqW ztGgfcAZYdOTesXKhwUYF66O+pshdfuz7etpUT5yoJ0A7SrL91J8geOya4lxyRky NqVZH5omyU+eI5Q3hBW+l6M= X-Sasl-enc: 2wjAODVATLxbSULb5sah0ADiqvY6vCyzJupbN1f1CZwP 1426887579 Received: from thinkpad-t440p (unknown [2.161.210.144]) by mail.messagingengine.com (Postfix) with ESMTPA id B9022C00013; Fri, 20 Mar 2015 17:39:38 -0400 (EDT) From: Tassilo Horn References: <20150320051529.GC857@smoon.vl-lomov.ru> <87pp84ru05.fsf@gnu.org> <20150320081645.GD857@smoon.vl-lomov.ru> <87lhisrqrd.fsf@gnu.org> Date: Fri, 20 Mar 2015 22:39:35 +0100 In-Reply-To: (Stefan Monnier's message of "Fri, 20 Mar 2015 16:30:14 -0400") Message-ID: <874mpfs608.fsf@gnu.org> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Stefan Monnier writes: > I installed a patch which should fix it, Yes, compiles again. Bye, Tassilo