From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 20 00:43:15 2015 Received: (at submit) by debbugs.gnu.org; 20 Mar 2015 04:43:15 +0000 Received: from localhost ([127.0.0.1]:58717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYomA-0000LP-QT for submit@debbugs.gnu.org; Fri, 20 Mar 2015 00:43:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37522) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYom8-0000LC-Fd for submit@debbugs.gnu.org; Fri, 20 Mar 2015 00:43:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYom2-0003ar-3F for submit@debbugs.gnu.org; Fri, 20 Mar 2015 00:43:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43172) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYom2-0003an-07 for submit@debbugs.gnu.org; Fri, 20 Mar 2015 00:43:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYom0-0006ht-Qi for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 00:43:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYolx-0003a1-Lz for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 00:43:04 -0400 Received: from mout.gmx.net ([212.227.17.20]:54946) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYolx-0003Zr-D6 for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 00:43:01 -0400 Received: from [192.168.1.12] ([96.232.130.59]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MFctN-1YmosA1d6j-00Eb0g for ; Fri, 20 Mar 2015 05:42:59 +0100 Message-ID: <550BA52D.1080805@gmx.com> Date: Fri, 20 Mar 2015 00:42:21 -0400 From: Boruch Baum User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: 24.4: function `bookmark-get-bookmark' OpenPGP: url=hkp://keys.gnupg.net Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DVq2GgrEnOTF8rBBHJGUpJl3x7QxPDDs4" X-Provags-ID: V03:K0:RTOWU61eJSrU0afBi1yZpJsTsjNFyE0sBZxWmFdaS+9cZnFf8xm rWMZUK2ppfJMLMU/oZSgCT5fdgaJcw2O3YgI9FToUAn7T3elfKtYxaOhkcgkv5ZaGdhA25Y OFVnZFp2o3l/Xo3/CfD0xbXszN3G513rcfA4iLZ7y4KnLz34uQgldVJlS2IesooFJsHvJAz aSdCfwbairRJDFB8WE97Q== X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DVq2GgrEnOTF8rBBHJGUpJl3x7QxPDDs4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Function `bookmark-get-bookmark' ... 1] tests for the existence of a bookmark by checking whether the input string matches a cons cell. This casts a net much wider than desirable, and might better be (assoc bookmark-name-or-record bookmark-alist). 2] returns only a string value on error, without passing nil back to the calling function. My usage case is that I was scripting a function to find org-mode files in a directory tree, and add them to a bookmark list if they aren't already bookmarked according to my naming convention. Originally, I had tried checking for the existence of a bookmark using a few of the bookmark.el functions, such as bookmark-get-bookmark, but that looked inconvenient because they returned string values on failure. --=20 hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 --DVq2GgrEnOTF8rBBHJGUpJl3x7QxPDDs4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVC6UtAAoJEDvrUfDmCx9LCdcP/RL8JY2ZvDYlK3RmhVqXt8wS hEKoMH3v5mOUBnsEcxWcFZENNHSRPx2yYGNmnjgW/2kWuW/iS0g/1GsEhS5CdnC5 fqct8j0oYQK45y8TwBVZVJ0aevKlmb58Bh2taDemtOWWw05SauswHRi/8vrZTTnk 5/UFawUQGBSAzOBkPUCG0Tl+VItS5W6gXYvd40cv536atEljLC5GHgwKhxxfUsn/ 4nJT8XI3/I54jbyMtV8l5d+bVpbbUP2lOHzmifKkxCy1Lyq0UCOZveu0nA4/YvxS I9Ld7R7fG6OpAvhjyFsUgIErQk/AGNkrAVEVtrHsHGIRBU+0YJtMTR/DEqUoVsAL 55AENtIl7hhX6f97ftp9xiNcWstMiuFh7ehxzgFmE89PjC+k6m6FGdAgs56YdAbJ NMzECOmq2g44Du8XQrzbF4kbUhq4JqZfFt7Nv80OPX+UZ+72Qmj0RGVwP3pkvgN7 h+5BgEvkxfWSDQfahD1Y+tPe+qT9Q7LwSwLwlDHeJsy0nK0aJbXJxtGn9aI3ZFC+ vF5Dcp0oKbQWk4gLdkXevwIyftuSSPOdZa/32oKkwg+Q4OJnHTn78wJ2Zo1mnsvN uRYF1qAtvMmzzjN7sPPGN39WXXGPEvPYYx3he8mlydHJlHUrJe51J/5K18vucKib rPQEa+Qq8nfK+WIRxMlV =P86V -----END PGP SIGNATURE----- --DVq2GgrEnOTF8rBBHJGUpJl3x7QxPDDs4-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 20 01:04:53 2015 Received: (at 20148) by debbugs.gnu.org; 20 Mar 2015 05:04:53 +0000 Received: from localhost ([127.0.0.1]:58722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYp77-0000sq-1Y for submit@debbugs.gnu.org; Fri, 20 Mar 2015 01:04:53 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:48582) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYp74-0000sc-Nh for 20148@debbugs.gnu.org; Fri, 20 Mar 2015 01:04:51 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t2K54h30029806 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 20 Mar 2015 05:04:44 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id t2K54hun024591 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 20 Mar 2015 05:04:43 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id t2K54h2p021774; Fri, 20 Mar 2015 05:04:43 GMT MIME-Version: 1.0 Message-ID: <1c3990cf-d1db-45e5-8b31-9055cdab20bd@default> Date: Thu, 19 Mar 2015 22:04:42 -0700 (PDT) From: Drew Adams To: Boruch Baum , 20148@debbugs.gnu.org Subject: RE: bug#20148: 24.4: function `bookmark-get-bookmark' References: <550BA52D.1080805@gmx.com> In-Reply-To: <550BA52D.1080805@gmx.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20148 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > Function `bookmark-get-bookmark' ... >=20 > 1] tests for the existence of a bookmark by checking whether the input > string matches a cons cell. This casts a net much wider than desirable, > and might better be (assoc bookmark-name-or-record bookmark-alist). See the actual code. > 2] returns only a string value on error, without passing nil back to the > calling function. >=20 > My usage case is that I was scripting a function to find org-mode files > in a directory tree, and add them to a bookmark list if they aren't > already bookmarked according to my naming convention. Originally, I had > tried checking for the existence of a bookmark using a few of the > bookmark.el functions, such as bookmark-get-bookmark, but that looked > inconvenient because they returned string values on failure. See the actual code. The doc string neglects to mention the optional argument. It should say something like this (taken from Bookmark+): Non-nil optional arg NOERROR means return nil if BOOKMARK is not a valid bookmark. If NOERROR is nil then raise an error in this case. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 20 07:04:49 2015 Received: (at 20148) by debbugs.gnu.org; 20 Mar 2015 11:04:49 +0000 Received: from localhost ([127.0.0.1]:58840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYujR-00019D-81 for submit@debbugs.gnu.org; Fri, 20 Mar 2015 07:04:49 -0400 Received: from mout.gmx.net ([212.227.17.21]:49543) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYujO-000190-Mr for 20148@debbugs.gnu.org; Fri, 20 Mar 2015 07:04:47 -0400 Received: from [192.168.1.12] ([96.232.130.59]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0M9eHT-1Yfjxo0YqF-00Cx6Y; Fri, 20 Mar 2015 12:04:39 +0100 Message-ID: <550BFEA1.8080100@gmx.com> Date: Fri, 20 Mar 2015 07:04:01 -0400 From: Boruch Baum User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Drew Adams , 20148@debbugs.gnu.org Subject: Re: bug#20148: 24.4: function `bookmark-get-bookmark' References: <550BA52D.1080805@gmx.com> <1c3990cf-d1db-45e5-8b31-9055cdab20bd@default> In-Reply-To: <1c3990cf-d1db-45e5-8b31-9055cdab20bd@default> OpenPGP: url=hkp://keys.gnupg.net Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VmPDs3KPghbDSKcIL5EnIBjMxgn3hDq9b" X-Provags-ID: V03:K0:gqR8gcBDQmyngmPT/r8eapbwVfXfpKGClZp39YGIA7JkkNMpt/j esAKIroH8gpdKvTupzaleLpuwP/Sn0wMgDveuYcIVsa+auzdB8iS2/misnPFd5bAK/B4yWh xSZi9RaUmLJphdjtUKans7U5E73iJIR3KTJbI2lMJ18g/YY09fXiSJgSd+n13RECsYu6se4 8gTnETRd1uKCBvOlibHtg== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20148 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VmPDs3KPghbDSKcIL5EnIBjMxgn3hDq9b Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Drew. Apology for the inconvenience. On 03/20/2015 01:04 AM, Drew Adams wrote: >> Function `bookmark-get-bookmark' ... >> >> 1] tests for the existence of a bookmark by checking whether the input= >> string matches a cons cell. This casts a net much wider than desirable= , >> and might better be (assoc bookmark-name-or-record bookmark-alist). >=20 > See the actual code. You're right. You could have just said 'line 336, not 335'. >=20 >> 2] returns only a string value on error, without passing nil back to t= he >> calling function. >> >> My usage case is that I was scripting a function to find org-mode file= s >> in a directory tree, and add them to a bookmark list if they aren't >> already bookmarked according to my naming convention. Originally, I ha= d >> tried checking for the existence of a bookmark using a few of the >> bookmark.el functions, such as bookmark-get-bookmark, but that looked >> inconvenient because they returned string values on failure. >=20 > See the actual code. >=20 > The doc string neglects to mention the optional argument. It should > say something like this (taken from Bookmark+): >=20 > Non-nil optional arg NOERROR means return nil if BOOKMARK is not a > valid bookmark. If NOERROR is nil then raise an error in this case. Missed that also. --=20 hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 --VmPDs3KPghbDSKcIL5EnIBjMxgn3hDq9b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVC/6hAAoJEDvrUfDmCx9LxPYP/jjR8aksMxhTNEtGOwPOeTtK qk10y9ZIlxndEJOL/zNOiyB4XRC0XRIoZE4dN2Pe8fE9aB2dRhwkR5lEjQDjRtsz 2zvOv3AECk8qm01Wo+9ypC/bjyX8KgZj5TFBP/Uice+sy+bvn0pYQ5xcmmrpgLIF P0n0AgrChNJW/q9CJVij3Cw9gFusxhcsg5pFXQVAnoq4Iy+8LliAzCtD2fAyuQNk 3RSF9tFMTH6QDLDPqz0SOaSrgg0F6sWf6/2AOM2wjDLtZPrEM4Id9NaBfCKhZLb9 f5eoUYbj5hbX8ZkcOkanUdNiKgFbqc/eE2TMPe5ZxK9xfVmzzZN9N2Of/7ov+GA2 zFwgOym45qZ6p4T6SwAm6BpwDfH+/GoK51Xmr216oJlIN0JHV7I8/HS7cMdkCTBU HVWHp+Dj/ZsnGD9J2pHCCqBfxquuZ66LxpP+hdqwKgSKNK/0HHcXq5oq+NyzLRPK G7jJW003OSCB+Yu7IWbO4xsb3+eG7Ta05+P6NyDQelMh5mYeEmwm9TzbY748lKbv R7zAEEMEUzGwSYYnQQmOjcZwaQcCQSXhlt3CcoHY7Ci5KYvkLZSm6VNkogzfBbSt L+TKXIUJwOJJjTxb2bGP7MDhNMeqNPze8nhJTgmYtSVYnx7vA12YOKaUzEumNdSg 31CgxT6nEqa45YfE/XRt =QahC -----END PGP SIGNATURE----- --VmPDs3KPghbDSKcIL5EnIBjMxgn3hDq9b-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 20 10:31:56 2015 Received: (at 20148) by debbugs.gnu.org; 20 Mar 2015 14:31:56 +0000 Received: from localhost ([127.0.0.1]:59227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYxxs-0007RY-2O for submit@debbugs.gnu.org; Fri, 20 Mar 2015 10:31:56 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:41226) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYxxp-0007RO-PA for 20148@debbugs.gnu.org; Fri, 20 Mar 2015 10:31:54 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t2KEVpMi031750; Fri, 20 Mar 2015 10:31:52 -0400 Received: by pastel.home (Postfix, from userid 20848) id C0462F63; Fri, 20 Mar 2015 10:31:51 -0400 (EDT) From: Stefan Monnier To: Boruch Baum Subject: Re: bug#20148: 24.4: function `bookmark-get-bookmark' Message-ID: References: <550BA52D.1080805@gmx.com> <1c3990cf-d1db-45e5-8b31-9055cdab20bd@default> <550BFEA1.8080100@gmx.com> Date: Fri, 20 Mar 2015 10:31:51 -0400 In-Reply-To: <550BFEA1.8080100@gmx.com> (Boruch Baum's message of "Fri, 20 Mar 2015 07:04:01 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5251=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5251> : inlines <2452> : streams <1408631> : uri <1885575> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 20148 Cc: 20148@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Does that mean the bug can be closed? Stefan >>>>> "Boruch" == Boruch Baum writes: > Hello Drew. Apology for the inconvenience. > On 03/20/2015 01:04 AM, Drew Adams wrote: >>> Function `bookmark-get-bookmark' ... >>> >>> 1] tests for the existence of a bookmark by checking whether the input >>> string matches a cons cell. This casts a net much wider than desirable, >>> and might better be (assoc bookmark-name-or-record bookmark-alist). >> >> See the actual code. > You're right. You could have just said 'line 336, not 335'. >> >>> 2] returns only a string value on error, without passing nil back to the >>> calling function. >>> >>> My usage case is that I was scripting a function to find org-mode files >>> in a directory tree, and add them to a bookmark list if they aren't >>> already bookmarked according to my naming convention. Originally, I had >>> tried checking for the existence of a bookmark using a few of the >>> bookmark.el functions, such as bookmark-get-bookmark, but that looked >>> inconvenient because they returned string values on failure. >> >> See the actual code. >> >> The doc string neglects to mention the optional argument. It should >> say something like this (taken from Bookmark+): >> >> Non-nil optional arg NOERROR means return nil if BOOKMARK is not a >> valid bookmark. If NOERROR is nil then raise an error in this case. > Missed that also. > -- > hkp://keys.gnupg.net > CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 20 10:45:50 2015 Received: (at 20148) by debbugs.gnu.org; 20 Mar 2015 14:45:50 +0000 Received: from localhost ([127.0.0.1]:59259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYyBJ-0007mI-Tm for submit@debbugs.gnu.org; Fri, 20 Mar 2015 10:45:50 -0400 Received: from mout.gmx.net ([212.227.15.18]:57812) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYyBI-0007m1-0P for 20148@debbugs.gnu.org; Fri, 20 Mar 2015 10:45:48 -0400 Received: from [192.168.1.12] ([96.232.130.59]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MN1j6-1YbA2C0ooq-006jR7; Fri, 20 Mar 2015 15:45:36 +0100 Message-ID: <550C3265.5030709@gmx.com> Date: Fri, 20 Mar 2015 10:44:53 -0400 From: Boruch Baum User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#20148: 24.4: function `bookmark-get-bookmark' References: <550BA52D.1080805@gmx.com> <1c3990cf-d1db-45e5-8b31-9055cdab20bd@default> <550BFEA1.8080100@gmx.com> In-Reply-To: OpenPGP: url=hkp://keys.gnupg.net Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CA9QfXjmesQnjxxv3CNrsMjMjoVKmChnv" X-Provags-ID: V03:K0:3KetXVUxeU6rwprJ2WZO+HOWgWdLDZX3/pSdQupp8VdP7SHlaFL GliRV0T/LpqoEwP/kWrSTemLr28LzRi6psXgY1VUDo+aPKiqit++N71B+XadCJEquJvf7tM STOSU3m7q2nU7pks4dJDAOOMt2u+JEb8Mp3JLDLxTLtLDVPgufglKUTSutrBcjg8AupUM/F wDSuAs/HaXwAoqgjDEE8w== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20148 Cc: 20148@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CA9QfXjmesQnjxxv3CNrsMjMjoVKmChnv Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/20/2015 10:31 AM, Stefan Monnier wrote: > Does that mean the bug can be closed? Yes. Though, you might want to tweak the documentation, per Drew's observation. >> On 03/20/2015 01:04 AM, Drew Adams wrote: >>> The doc string neglects to mention the optional argument. It should >>> say something like this (taken from Bookmark+): >>> >>> Non-nil optional arg NOERROR means return nil if BOOKMARK is not a >>> valid bookmark. If NOERROR is nil then raise an error in this case. --=20 hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 --CA9QfXjmesQnjxxv3CNrsMjMjoVKmChnv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVDDJmAAoJEDvrUfDmCx9LARkP/Rrcra0Y8hK7/6SWKyw4VT72 JPBcDhO6nUFAZ4wnePcDvlPQ2yzPa/GICTG9Fr+5m94qvUfT3Bj3n/+7PWMXvBUW QIOqLNAOWrgBIqy3jW6RIyRkfeWG83e0vwJhFeul5HsCB9kWdnOwFQJ5Utq7YsQJ kk+4gk+hZJQEZ5LE5BAE9ETr0Mp4+bae23Frl/6grisYvu0UqiQRWrui9TzBGRxZ bC4RSSTOryGghzQLkXd+eDpzdwGKTAlz3ebRbZ79E2qA59yim8g0tozqf04DWxUe Qoy5KFFw86ycjVJphIy4dW5lkHvo1S1u47zmmrQuDloT6aIfzwD7yFkrD2zqF08/ 8gs2L6JsQcM7zdW5iEBw31PrP5y+XhTdS1rsXjQzyG7MEb7QV4Ojbd5wPg6/oW9i 5RPsFWlHOWGPXvZJJ2TsrPDiEalGF64QoGZV48HGrezASZOOPCzw44Tvbmn/8aZl Wg/RXdBQ743Yuf+DLUzXhrtbr6CkwoAG3zIh60QdVRTG0fbGyHfoEnhG6yVBBZEL Rhhnzl1Vi5rRULQqqesvOHnHixkAUudbvwQkb0yIi8felwa0FnD8jatFH4E+iFns /q+X21YqOwXtoHMbrZIlqo1BlK3+vhc70H9To/ONzsadmftLlz57LmDTJ4TaAI6E Bxoqrffrqb58ar3pksPD =q7m9 -----END PGP SIGNATURE----- --CA9QfXjmesQnjxxv3CNrsMjMjoVKmChnv-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 26 11:35:12 2019 Received: (at 20148) by debbugs.gnu.org; 26 May 2019 15:35:12 +0000 Received: from localhost ([127.0.0.1]:51454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUvB2-0002M5-4f for submit@debbugs.gnu.org; Sun, 26 May 2019 11:35:12 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:37261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUq95-0005nr-3t for 20148@debbugs.gnu.org; Sun, 26 May 2019 06:12:51 -0400 Received: by mail-wm1-f44.google.com with SMTP id 7so12996878wmo.2 for <20148@debbugs.gnu.org>; Sun, 26 May 2019 03:12:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=qs4xyRxjzHS39E667U4+KShFl6JIyMe1uP1zbzHDNuc=; b=byrWEgdnjMssZ6Zqt/LI80QyGpBsJ1B0paRNF82LLZULy/MyV+wgr13+QNTDJwcBCu akJq0IobWRNY1MVBqJMEpy1e777qyPPZI7e1dPHl+7oXv5umLRRohwmL8H23y+Y8fbwx +pOsRuO+oqehIj8F5Rn2tUttdkbKSNkUqT+h7RWTpm5n09d4iBG3gvLkzM6hTKw6rE0r zykVb4F36A7BjfCGSxmZMhqVhFi77O/gZooDzEnhqeeK85UR/Mvrt1glGO7amUqlNgqr F1n7xCmQ0jLIsXfovwakg47XlD/350fg9lD6sCUr16Pq0qMB00sYgV5BzDEMBVdZaPGl Zmxw== X-Gm-Message-State: APjAAAUf6h9RAFQT7riSzOY3DQC+W6hMCKgmzrHBZfAgqQucEMaV+Gwj 8ILkjU0LvMvlsiQ3ijQUY/ToxmAi1v3wjCLUOtHFVWj+ X-Google-Smtp-Source: APXvYqw/OXXy4cIq75PsWZz5RGwMzeGIYTB2F+sB2iSAaTQIODblwuxssfgaBKOjUOp8Smj7lREC9VMnno4eyQQl1MQ= X-Received: by 2002:a1c:9a83:: with SMTP id c125mr21458095wme.39.1558865564965; Sun, 26 May 2019 03:12:44 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Sun, 26 May 2019 12:12:33 +0200 Message-ID: Subject: Re: bug#20148: 24.4: function `bookmark-get-bookmark' To: 20148@debbugs.gnu.org Content-Type: multipart/mixed; boundary="0000000000004143f40589c7acd9" X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 20148 X-Mailman-Approved-At: Sun, 26 May 2019 11:35:10 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) --0000000000004143f40589c7acd9 Content-Type: multipart/alternative; boundary="0000000000004143f00589c7acd7" --0000000000004143f00589c7acd7 Content-Type: text/plain; charset="UTF-8" The attached patch fixes the docstring as suggested above. >From the above discussion, I believe this bug report can be closed once this has been applied. Thanks, Stefan Kangas --0000000000004143f00589c7acd7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
The attached patch fixes the docstring as suggested a= bove.

From the above discussion, I believe this bu= g report can be closed once this has
been applied.
=
Thanks,
Stefan Kangas

--0000000000004143f00589c7acd7-- --0000000000004143f40589c7acd9 Content-Type: text/x-patch; charset="US-ASCII"; name="fix-docstring-of-bookmark-get-bookmark.patch" Content-Disposition: attachment; filename="fix-docstring-of-bookmark-get-bookmark.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jw4s7q5r0 RnJvbSBhODc0ZjIzMWJhMDIxNmNhMmMzZmVlZGFhZThkZGIzMmYzNzhmODBlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDI2IE1heSAyMDE5IDEyOjA0OjU2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g Rml4IGRvY3N0cmluZyBvZiBib29rbWFyay1nZXQtYm9va21hcmsKCiogYm9va21hcmsuZWwgKGJv b2ttYXJrLWdldC1ib29rbWFyayk6IEZpeCBkb2NzdHJpbmcuCi0tLQogbGlzcC9ib29rbWFyay5l bCB8IDQgKysrLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigt KQoKZGlmZiAtLWdpdCBhL2xpc3AvYm9va21hcmsuZWwgYi9saXNwL2Jvb2ttYXJrLmVsCmluZGV4 IGIxZmU2OTBkYWMuLjVjMTRmNzA1ZWIgMTAwNjQ0Ci0tLSBhL2xpc3AvYm9va21hcmsuZWwKKysr IGIvbGlzcC9ib29rbWFyay5lbApAQCAtMzM0LDcgKzMzNCw5IEBAIGJvb2ttYXJrLWdldC1ib29r bWFyawogSWYgQk9PS01BUkstTkFNRS1PUi1SRUNPUkQgaXMgYSBzdHJpbmcsIGxvb2sgZm9yIHRo ZSBjb3JyZXNwb25kaW5nCiBib29rbWFyayByZWNvcmQgaW4gYGJvb2ttYXJrLWFsaXN0JzsgcmV0 dXJuIGl0IGlmIGZvdW5kLCBvdGhlcndpc2UKIGVycm9yLiAgRWxzZSBpZiBCT09LTUFSSy1OQU1F LU9SLVJFQ09SRCBpcyBhbHJlYWR5IGEgYm9va21hcmsgcmVjb3JkLAotanVzdCByZXR1cm4gaXQu IgoranVzdCByZXR1cm4gaXQuCitTaWduYWwgYW4gZXJyb3IgaWYgYm9va21hcmsgaXMgaW52YWxp ZC4gIElmIG9wdGlvbmFsIGFyZ3VtZW50CitOT0VSUk9SIGlzIG5vbi1uaWwsIHJldHVybiBuaWwg aW5zdGVhZC4iCiAgIChjb25kCiAgICAoKGNvbnNwIGJvb2ttYXJrLW5hbWUtb3ItcmVjb3JkKSBi b29rbWFyay1uYW1lLW9yLXJlY29yZCkKICAgICgoc3RyaW5ncCBib29rbWFyay1uYW1lLW9yLXJl Y29yZCkKLS0gCjIuMTEuMAoK --0000000000004143f40589c7acd9-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 30 08:38:13 2019 Received: (at control) by debbugs.gnu.org; 30 May 2019 12:38:13 +0000 Received: from localhost ([127.0.0.1]:60942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWKJw-0007uZ-Mg for submit@debbugs.gnu.org; Thu, 30 May 2019 08:38:12 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:41938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWKJu-0007uE-LA for control@debbugs.gnu.org; Thu, 30 May 2019 08:38:11 -0400 Received: by mail-ed1-f68.google.com with SMTP id y15so2958229edo.8 for ; Thu, 30 May 2019 05:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/uEtQCQSZjPToJL2ao5f8gGFxzAc9kpl/ftRqInay2I=; b=Cr42rgVrpfyMXJZifYvW38oErk9OJbGl/p0p/8IINwgXq04p6qUJWpGVAu9LqLNXp0 A4M0ZRSk0AbJ3rT4Mfo9TCmt7LChoRUlRlVo50WLfCUhrJ+d4zZhIX7mUgXOAoajQ98f WfB8tXAscW8TVmtKlg1YcSCPCP8qkAnXgaz4YhNIp5th4+X8bJ+EajLWfvPyLSqt8Cmm +7aqpHXn3LpdfvNRlp+sgoemu5xzrqmgjxO34sI7mAcqBg3kHyt6We4Sk4jK3wXfHRCI 0+IEXKCKdLOaNDWK3mp8glcgvFEOuvchcaVQgVob5vkJBfzxbF7cFR7ZsvbJs3ULoliH GRpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/uEtQCQSZjPToJL2ao5f8gGFxzAc9kpl/ftRqInay2I=; b=DSOa+rsl2MrOsJTCUX8O2f8QyBQqOsvv2nJcE6fsbLgwBJxc4up6tRGAFTA3jL8Ux4 ND+ioitcR6IV91B3lHtFgUPhMzFO1awhmW58bpWMmJU5bfhw+2kIyNjQXFLXkBiA3r+p B6LYnbUrkBrrolg05zgV3UadmRNo5vBGS5phR9Wqo46SVDFDHPzeP+RYFw68zZlhK7j6 Nq06UajOr0KpVFFzvGGkdn6nfBBL6VmOt+YQCxk5Ak0z9NZOwZlFHK2JflyCxK/p2ULW g2CeUSudCAHV4k0NyigJ/hOmk6T3NJFjA3lQ3gXViW4S9if3jlbr8efRwzfc4NysBW1d Iepw== X-Gm-Message-State: APjAAAXiQ8j4tBQ96EuWWE2V9PrHLjhv/VXK6uKqiL61u9PV51I2181P EeimmILi2PBWajcrmieiqJrylA== X-Google-Smtp-Source: APXvYqz1uKY2iopjWYDrQi86Qojrk/+rflxZfcfhehgMqZFZoA+VA9+m1pzV39b+gKvNZ2gUwsKE2A== X-Received: by 2002:a17:906:1483:: with SMTP id x3mr3269080ejc.90.1559219884590; Thu, 30 May 2019 05:38:04 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:8cad:ae29:555d:852d]) by smtp.gmail.com with ESMTPSA id k37sm710992edb.11.2019.05.30.05.38.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 30 May 2019 05:38:03 -0700 (PDT) From: "Basil L. Contovounesios" To: Stefan Kangas Subject: Re: bug#20148: 24.4: function `bookmark-get-bookmark' References: <550BA52D.1080805@gmx.com> Date: Thu, 30 May 2019 13:38:02 +0100 In-Reply-To: (Stefan Kangas's message of "Sun, 26 May 2019 12:12:33 +0200") Message-ID: <87y32ot8wl.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 20148-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 20148 fixed close 20148 26.3 quit > From a874f231ba0216ca2c3feedaae8ddb32f378f80e Mon Sep 17 00:00:00 2001 > From: Stefan Kangas > Date: Sun, 26 May 2019 12:04:56 +0200 > Subject: [PATCH] Fix docstring of bookmark-get-bookmark > > * bookmark.el (bookmark-get-bookmark): Fix docstring. > --- > lisp/bookmark.el | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lisp/bookmark.el b/lisp/bookmark.el > index b1fe690dac..5c14f705eb 100644 > --- a/lisp/bookmark.el > +++ b/lisp/bookmark.el > @@ -334,7 +334,9 @@ bookmark-get-bookmark > If BOOKMARK-NAME-OR-RECORD is a string, look for the corresponding > bookmark record in `bookmark-alist'; return it if found, otherwise > error. Else if BOOKMARK-NAME-OR-RECORD is already a bookmark record, > -just return it." > +just return it. > +Signal an error if bookmark is invalid. If optional argument > +NOERROR is non-nil, return nil instead." > (cond > ((consp bookmark-name-or-record) bookmark-name-or-record) > ((stringp bookmark-name-or-record) The docstring already mentioned signalling an error, so I tweaked your patch to include only the second of the two new sentences, as well as to mention the full relative file name (lisp/bookmark.el) and the bug reference (bug#20148) in the commit log, and pushed to emacs-26[1], and am therefore closing this report. [1: 1b2f83bb79]: Fix docstring of bookmark-get-bookmark 2019-05-30 13:32:10 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1b2f83bb7984269b92eb0afb323e3e74baf87068 Thanks, -- Basil From unknown Tue Jun 24 08:45:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 28 Jun 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator