GNU bug report logs - #20146
font-lock-extend-jit-lock-region-after-change: results are discarded instead of being returned.

Previous Next

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Alan Mackenzie <acm <at> muc.de>
Cc: 20146 <at> debbugs.gnu.org
Subject: bug#20146: font-lock-extend-jit-lock-region-after-change: results are discarded instead of being returned.
Date: Fri, 20 Mar 2015 10:20:24 -0400

> In font-lock-extend-jit-lock-region-after-change in font-lock.el, the
> new fontification region is calculated by funcalling
> font-lock-extend-after-change-region-function.  The result of this
> funcall is assigned to internal variables beg and end.

> To return these values to the caller, they should be written to the
> dynamically bound variables jit-lock-start and jit-lock-end.  This is
> only done in the case

>     (memq 'font-lock-extend-region-wholelines
>            font-lock-extend-region-functions)

> .  It should be done in all cases.

I'm thinking of removing font-lock-extend-after-change-region-function
altogether anyway: cc-mode is the only user and it has a workaround in
place for when the "feature" is absent, so it's really just useless.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.