GNU bug report logs - #20145
(guix build download) leaks file descriptor on TLS connections

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: tracker <at> debbugs.gnu.org
Subject: bug#20145: closed ((guix build download) leaks file descriptor on
 TLS connections)
Date: Thu, 17 Mar 2016 22:58:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 17 Mar 2016 23:57:45 +0100
with message-id <87oaac1zme.fsf <at> gnu.org>
and subject line Re: bug#20145: (guix build download) leaks file descriptor on TLS connections
has caused the debbugs.gnu.org bug report #20145,
regarding (guix build download) leaks file descriptor on TLS connections
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
20145: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20145
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: bug-guix <at> gnu.org
Subject: (guix build download) leaks file descriptor on TLS connections
Date: Thu, 19 Mar 2015 19:16:24 +0100

When opening an HTTPS connection, the file descriptor beneath the port
returned by ‘tls-wrap’ is leaked.

This is not a problem in most cases (downloads) because the process is
left as soon as the download is over.

This is more problematic for ‘guix lint’, which may open a large number
of HTTPS connections for the ‘source’ and ‘home-page’ checkers when
working on all the packages.

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: 20145-done <at> debbugs.gnu.org
Subject: Re: bug#20145: (guix build download) leaks file descriptor on TLS
 connections
Date: Thu, 17 Mar 2016 23:57:45 +0100

ludo <at> gnu.org (Ludovic Courtès) skribis:

> When opening an HTTPS connection, the file descriptor beneath the port
> returned by ‘tls-wrap’ is leaked.
>
> This is not a problem in most cases (downloads) because the process is
> left as soon as the download is over.
>
> This is more problematic for ‘guix lint’, which may open a large number
> of HTTPS connections for the ‘source’ and ‘home-page’ checkers when
> working on all the packages.

This is essentially solved by commits
14d6ca3e4dd23ee92adb5e2fcf58546e67534631 and
097a951e96718a037dbfa6d579e2d26f7dab3e82.

One still needs to be careful, though, for instance because closing a
chunked encoding port (which is a custom binary input port wrapped
around the real socket port) still fails to close the raw socket port
that’s behind the TLS session record port.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.