GNU bug report logs - #20122
auto-revert and list-buffers cause buffer recentering

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20122 in the body.
You can then email your comments to 20122 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mario Valencia <mariovalspi <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: auto-revert and list-buffers cause buffer recentering
Date: Mon, 16 Mar 2015 12:20:03 -0600

[Message part 1 (text/plain, inline)]

do the following:
(global-auto-revert-mode)
(setq global-auto-revert-non-file-buffers t)

then M-x list-buffers

now open a file and move down a page at least. the file begins
auto-recentering. the line with the cursor moves toward the center.

Emacs with -Q

GNU Emacs 24.4.1 (i686-pc-mingw32)
 of 2014-10-24 on LEG570

Windows 8.

[Message part 2 (text/html, inline)]

Message #8 received at 20122 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mario Valencia <mariovalspi <at> gmail.com>
Cc: 20122 <at> debbugs.gnu.org
Subject: Re: bug#20122: auto-revert and list-buffers cause buffer recentering
Date: Mon, 16 Mar 2015 22:07:28 +0200

> Date: Mon, 16 Mar 2015 12:20:03 -0600
> From: Mario Valencia <mariovalspi <at> gmail.com>
> 
> do the following:
> (global-auto-revert-mode)
> (setq global-auto-revert-non-file-buffers t)
> 
> then M-x list-buffers
> now open a file and move down a page at least. the file begins
> auto-recentering. the line with the cursor moves toward the center.

It's a bug in tabulated-list-print: it calls 'recenter' without
ensuring that its buffer, in this case "*Buffer List*", is in the
selected window.  Here's the Lisp backtrace to prove this:

  Lisp Backtrace:
  "recenter" (0x82dd80)
  "tabulated-list-print" (0x82e08c)
  "tabulated-list-revert" (0x82e384)
  "revert-buffer" (0x82e678)
  "auto-revert-handler" (0x82e978)
  "auto-revert-buffers" (0x82ed4c)
  "apply" (0x82ed48)
  "byte-code" (0x82efcc)
  "timer-event-handler" (0x82f40c)

I think the easiest solution is simply to remove the call to
'recenter', it's not really needed there, just a nicety.

Message #11 received at 20122 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 20122 <at> debbugs.gnu.org, Mario Valencia <mariovalspi <at> gmail.com>
Subject: Re: bug#20122: auto-revert and list-buffers cause buffer recentering
Date: Mon, 16 Mar 2015 18:39:37 -0400

Seems this is already fixed

http://lists.gnu.org/archive/html/emacs-diffs/2014-06/msg00088.html

Message #16 received at 20122 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 20122 <at> debbugs.gnu.org, mariovalspi <at> gmail.com
Subject: Re: bug#20122: auto-revert and list-buffers cause buffer recentering
Date: Tue, 17 Mar 2015 09:17:48 +0200

> From: Glenn Morris <rgm <at> gnu.org>
> Cc: Mario Valencia <mariovalspi <at> gmail.com>,  20122 <at> debbugs.gnu.org
> Date: Mon, 16 Mar 2015 18:39:37 -0400
> 
> 
> Seems this is already fixed
> 
> http://lists.gnu.org/archive/html/emacs-diffs/2014-06/msg00088.html

On master, but not on emacs-24.  I wonder why it was committed to
trunk in June 2014 and never back-ported.  Maybe we should back-port
it now.

Message #19 received at 20122 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Glenn Morris <rgm <at> gnu.org>, 20122 <at> debbugs.gnu.org, mariovalspi <at> gmail.com
Subject: Re: bug#20122: auto-revert and list-buffers cause buffer recentering
Date: Tue, 17 Mar 2015 12:39:47 -0400

> On master, but not on emacs-24.  I wonder why it was committed to
> trunk in June 2014 and never back-ported.

Probably an oversight.

> Maybe we should back-port it now.

If it's safe enough, yes it should be backported,


        Stefan

Message #22 received at 20122 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: rgm <at> gnu.org, 20122 <at> debbugs.gnu.org, mariovalspi <at> gmail.com
Subject: Re: bug#20122: auto-revert and list-buffers cause buffer recentering
Date: Sat, 21 Mar 2015 12:05:10 +0200

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: Glenn Morris <rgm <at> gnu.org>,  20122 <at> debbugs.gnu.org,  mariovalspi <at> gmail.com
> Date: Tue, 17 Mar 2015 12:39:47 -0400
> 
> > On master, but not on emacs-24.  I wonder why it was committed to
> > trunk in June 2014 and never back-ported.
> 
> Probably an oversight.
> 
> > Maybe we should back-port it now.
> 
> If it's safe enough, yes it should be backported,

Done.

Message #25 received at 20122-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: 20122-done <at> debbugs.gnu.org
Subject: Re: bug#20122: auto-revert and list-buffers cause buffer recentering
Date: Sat, 21 Mar 2015 12:05:52 +0200

Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.