From unknown Mon Jun 23 13:10:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20116: 24.4.91; [PATCH]Don't use iswitchb in erc. Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Mar 2015 07:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20116 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 20116@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.142649196113396 (code B ref -1); Mon, 16 Mar 2015 07:47:02 +0000 Received: (at submit) by debbugs.gnu.org; 16 Mar 2015 07:46:01 +0000 Received: from localhost ([127.0.0.1]:48026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YXPiq-0003Tu-8y for submit@debbugs.gnu.org; Mon, 16 Mar 2015 03:46:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40748) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YXPio-0003Tm-5f for submit@debbugs.gnu.org; Mon, 16 Mar 2015 03:45:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXPii-0000Xl-M0 for submit@debbugs.gnu.org; Mon, 16 Mar 2015 03:45:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXPii-0000Xh-IV for submit@debbugs.gnu.org; Mon, 16 Mar 2015 03:45:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXPig-0001qa-Bu for bug-gnu-emacs@gnu.org; Mon, 16 Mar 2015 03:45:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXPiZ-0000Vc-3Q for bug-gnu-emacs@gnu.org; Mon, 16 Mar 2015 03:45:50 -0400 Received: from mail-wg0-x234.google.com ([2a00:1450:400c:c00::234]:33135) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXPiY-0000Us-Or for bug-gnu-emacs@gnu.org; Mon, 16 Mar 2015 03:45:43 -0400 Received: by wgbcc7 with SMTP id cc7so32563060wgb.0 for ; Mon, 16 Mar 2015 00:45:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=kw6/bE5VXTdYZWrTlX551Fv/Wkwo5xTQ+35AoC6l13M=; b=viA7VCvfWX71X97gggvd2tc5mCXfeIoYD1xbAVvE2zCRuvfiGEcG53v1ShcO1Wx8Sr MqpfxityZKOQu5TXF5FDtM8soH9erMXRRa69jTRK/P8juRF7VEZ6KMDHVl4dSWm4RkLp bEWYst/3V7rD6OMXMufsCksXVpTZerNyf8DVXNainJc8ez80skJ/A6ouMWLS5NqI26ah SUBgt7BGvmJ1AxIImKSjemRfUZoj1Q5cw4GCyfWYTi0pU2tyV+W221xT8lZptvz5EYNe sRZL1Tlk869uLczKNxU2xgXJ5KRL81WVjdt851kMgqgwcAClqF8akHYnMRL9CIKdR1ed xpHQ== X-Received: by 10.180.187.19 with SMTP id fo19mr83835621wic.2.1426491941143; Mon, 16 Mar 2015 00:45:41 -0700 (PDT) Received: from dell-14z ([37.162.130.213]) by mx.google.com with ESMTPSA id r14sm14093823wiv.13.2015.03.16.00.45.36 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 16 Mar 2015 00:45:40 -0700 (PDT) From: Thierry Volpiatto Date: Mon, 16 Mar 2015 08:45:32 +0100 Message-ID: <878uexpeqr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hi, erc is still using iswitchb which is deprecated, thus using this directly does not allow other packages (at least helm) to use their own completion. Using completing-read allow ido user to use ido, helm users helm etc... 8c03a0e7352eeb3e40d94897623a5ce5d68a0789 HEAD erc_no_iswitchb Author: Thierry Volpiatto Date: Mon Mar 16 08:37:59 2015 +0100 Don't use iswitchb in erc. * lisp/erc/erc.el (erc-switch-to-buffer): Renamed from erc-iswitchb. Use completing-read. (erc-mode-map): Bind it. 1 file changed, 13 insertions(+), 31 deletions(-) lisp/erc/erc.el | 44 +++++++++++++------------------------------- Modified lisp/erc/erc.el diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index a84f9f0..e76becd 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -1110,7 +1110,7 @@ which the local user typed." (define-key map "\C-a" 'erc-bol) (define-key map [home] 'erc-bol) (define-key map "\C-c\C-a" 'erc-bol) - (define-key map "\C-c\C-b" 'erc-iswitchb) + (define-key map "\C-c\C-b" 'erc-switch-to-buffer) (define-key map "\C-c\C-c" 'erc-toggle-interpret-controls) (define-key map "\C-c\C-d" 'erc-input-action) (define-key map "\C-c\C-e" 'erc-toggle-ctcp-autoresponse) @@ -1697,40 +1697,22 @@ nil." ;; a variable. res))) -;; (iswitchb-mode) will autoload iswitchb.el -(defvar iswitchb-temp-buflist) -(declare-function iswitchb-read-buffer "iswitchb" - (prompt &optional default require-match start matches-set)) -(defvar iswitchb-make-buflist-hook) - -(defun erc-iswitchb (&optional arg) - "Use `iswitchb-read-buffer' to prompt for a ERC buffer to switch to. +(defun erc-switch-to-buffer (&optional arg) + "Prompt for a ERC buffer to switch to. When invoked with prefix argument, use all erc buffers. Without prefix ARG, allow only buffers related to same session server. If `erc-track-mode' is in enabled, put the last element of -`erc-modified-channels-alist' in front of the buffer list. - -Due to some yet unresolved reason, global function `iswitchb-mode' -needs to be active for this function to work." +`erc-modified-channels-alist' in front of the buffer list." (interactive "P") - (let ((enabled (bound-and-true-p iswitchb-mode))) - (or enabled (iswitchb-mode 1)) - (unwind-protect - (let ((iswitchb-make-buflist-hook - (lambda () - (setq iswitchb-temp-buflist - (mapcar 'buffer-name - (erc-buffer-list - nil - (when arg erc-server-process))))))) - (switch-to-buffer - (iswitchb-read-buffer - "Switch-to: " - (if (boundp 'erc-modified-channels-alist) - (buffer-name (caar (last erc-modified-channels-alist))) - nil) - t))) - (or enabled (iswitchb-mode -1))))) + (switch-to-buffer + (completing-read "Switch-to: " + (mapcar 'buffer-name + (erc-buffer-list + nil + (when arg erc-server-process))) + nil t nil nil + (when (boundp 'erc-modified-channels-alist) + (buffer-name (caar (last erc-modified-channels-alist))))))) (defun erc-channel-list (proc) "Return a list of channel buffers. In GNU Emacs 24.4.91.1 (x86_64-unknown-linux-gnu, X toolkit) of 2015-03-12 on dell-14z Repository revision: b21a56ac91e39e75051ad07bb608c39af057adee Windowing system distributor `The X.Org Foundation', version 11.0.11501000 System Description: Ubuntu 14.04.2 LTS Configured using: `configure --with-x-toolkit=lucid --without-toolkit-scroll-bars --without-gconf --without-gsettings' Important settings: value of $LANG: fr_FR.UTF-8 locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: magit-auto-revert-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t diff-auto-refine-mode: t git-gutter-mode: t psession-mode: t golden-ratio-mode: t winner-mode: t global-undo-tree-mode: t undo-tree-mode: t auto-image-file-mode: t eldoc-in-minibuffer-mode: t show-paren-mode: t display-time-mode: t recentf-mode: t savehist-mode: t eldoc-mode: t minibuffer-depth-indicate-mode: t helm-descbinds-mode: t helm-mode: t shell-dirtrack-mode: t helm-adaptive-mode: t helm-match-plugin-mode: t helm-autoresize-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent messages: Running git commit -- When done with a buffer, type C-c C-c Type C-c C-c to commit (C-c C-k to abort). Auto-saving...done Saving file /home/thierry/labo/emacs/.git/COMMIT_EDITMSG... Wrote /home/thierry/labo/emacs/.git/COMMIT_EDITMSG Git finished Type a prefix key to toggle it. Run 'actions' with their prefixes. '?' for more help. Mark set Saved text from "8c03a0e7352eeb3e40d94897623a5ce5d68a0789" Load-path shadows: /home/thierry/.emacs.d/elpa/emms-20150310.458/tq hides /usr/local/share/emacs/24.4.91/lisp/emacs-lisp/tq ~/elisp/auctex/lpath hides ~/elisp/emacs-wget/lpath Features: (shadow emacsbug magit-key-mode magit view help-mode autorevert filenotify git-rebase-mode git-commit-mode log-edit add-log helm-ls-git vc vc-dispatcher cl-indent helm-ring mail-extr helm-dabbrev epa-mail smiley gnus-art mm-uu mml2015 mm-view mml-smime smime dig mule-util network-stream starttls tls erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete erc-track erc-match erc-button erc-fill erc-stamp erc-netsplit erc-goodies erc erc-backend erc-compat helm-command helm-elisp helm-eval package-build lisp-mnt org-element org-rmail org-mhe org-irc org-info org-gnus org-docview org-bibtex bibtex org-bbdb org-w3m sh-script smie executable conf-mode make-mode cc-langs cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs markdown-mode vc-rcs diff-mode vc-git naquadah-theme em-unix em-script em-prompt em-ls em-hist em-pred em-glob em-dirs em-cmpl em-basic em-banner em-alias align-let git-gutter server psession golden-ratio winner undo-tree diff slime-xref-browser slime-banner slime-tramp slime-asdf slime-fancy slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree slime-scratch slime-presentations bridge slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl slime-parse slime etags arc-mode archive-mode image-file xdvi-search preview-latex tex-site auto-loads pcomplete-extension pcmpl-unix pcmpl-gnu em-term term disp-table ehelp python eldoc-eval warnings whitespace paren time recentf tree-widget savehist mu4e-config org-mu4e helm-mu mu4e-contrib mu4e mu4e-speedbar speedbar sb-image ezimage dframe mu4e-main mu4e-view mu4e-headers mu4e-compose mu4e-draft mu4e-actions ido rfc2368 mu4e-mark mu4e-message html2text mu4e-proc mu4e-utils mu4e-lists mu4e-about mu4e-vars hl-line mu4e-meta gnus-dired nnir gnus-sum gnus-group gnus-undo nnmail mail-source gnus-start gnus-spec gnus-int gnus-range gnus-win nnoo config-w3m w3m-search w3m doc-view jka-compr image-mode timezone w3m-hist w3m-fb bookmark-w3m w3m-ems w3m-ccl ccl w3m-favicon w3m-image w3m-proc w3m-util smtpmail-async smtpmail sendmail dired-async iterator lacarte iedit-rect iedit iedit-lib smallurl mm-url gnus gnus-ems nnheader wid-edit rectangle-utils rect ledger-config ledger esh-var esh-io esh-cmd esh-opt esh-ext esh-proc eldoc esh-groups eshell esh-module esh-mode esh-arg esh-util tv-utils pcvs vc-cvs pcvs-parse pcvs-info pcvs-defs pcvs-util ewoc mb-depth cl-info hyperspec esh-toggle flymake no-word htmlize cl dired-extension emms-vlc-config emms-librefm-stream emms-librefm-scrobbler emms-playlist-limit emms-volume emms-volume-amixer emms-i18n emms-history emms-score emms-stream-info emms-metaplaylist-mode emms-bookmarks emms-cue emms-mode-line-icon emms-browser sort emms-playlist-sort emms-last-played emms-player-xine emms-player-mpd tq emms-playing-time emms-lyrics emms-url emms-tag-editor emms-mark emms-mode-line emms-cache emms-info-ogginfo emms-info-mp3info emms-playlist-mode emms-player-vlc emms-player-mplayer emms-info emms-streams later-do emms-source-playlist emms-source-file locate emms-player-simple emms-setup emms emms-compat org-config-thierry ob-sh org-crypt appt diary-lib diary-loaddefs org-annotation-helper addressbook-bookmark message rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader bookmark-firefox-handler bookmark-extensions init-helm-thierry helm-descbinds helm-extensions-autoloads helm-mode helm-files image-dired tramp tramp-compat tramp-loaddefs trampver shell dired-x dired-aux ffap thingatpt helm-buffers helm-elscreen helm-tags helm-bookmark helm-adaptive helm-info bookmark pp helm-locate helm-help helm-org org-location-google-maps org-agenda google-maps google-maps-static google-maps-geocode google-maps-base json org org-macro org-footnote org-pcomplete pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs format-spec find-func cal-menu calendar cal-loaddefs helm-match-plugin helm-grep wgrep-helm wgrep helm-regexp helm-plugin grep helm-external helm-net browse-url xml url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse url-vars mailcap helm-utils dired compile comint ansi-color ring helm easy-mmode helm-source helm-config helm-autoloads async-bytecomp async helm-aliases epa-file epa derived epg auth-source eieio byte-opt bytecomp byte-compile cl-extra cconv eieio-core gnus-util mm-util mail-prsvr password-cache cl-macs gv slime-autoloads package epg-config time-date avoid cus-start cus-load w3m-wget info easymenu edmacro kmacro advice help-fns net-utils cl-loaddefs cl-lib tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind gfilenotify dynamic-setting font-render-setting x-toolkit x multi-tty emacs) Memory information: ((conses 16 630268 48383) (symbols 48 67566 0) (miscs 40 2227 1485) (strings 32 178215 24587) (string-bytes 1 5234753) (vectors 16 68597) (vector-slots 8 1767252 27510) (floats 8 1828 1180) (intervals 56 7470 1145) (buffers 960 185) (heap 1024 62416 3341)) -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997 From unknown Mon Jun 23 13:10:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20116: 24.4.91; [PATCH]Don't use iswitchb in erc. Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Mar 2015 13:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20116 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Thierry Volpiatto Cc: 20116@debbugs.gnu.org Received: via spool by 20116-submit@debbugs.gnu.org id=B20116.142651123616670 (code B ref 20116); Mon, 16 Mar 2015 13:08:01 +0000 Received: (at 20116) by debbugs.gnu.org; 16 Mar 2015 13:07:16 +0000 Received: from localhost ([127.0.0.1]:48210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YXUjj-0004Kn-RG for submit@debbugs.gnu.org; Mon, 16 Mar 2015 09:07:16 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:1674) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YXUjh-0004Ke-Ti for 20116@debbugs.gnu.org; Mon, 16 Mar 2015 09:07:14 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ar8TAPOG1lQXW5EB/2dsb2JhbABbgwaDX4VTvhyCSQQCAoENRAEBAQEBAXyEDQEEAVYjBQsLNBIUGA0kiDgIziMBAQEBAQUBAQEBHo94B4QqBZlfhUmMDyKECiKCcwEBAQ X-IPAS-Result: Ar8TAPOG1lQXW5EB/2dsb2JhbABbgwaDX4VTvhyCSQQCAoENRAEBAQEBAXyEDQEEAVYjBQsLNBIUGA0kiDgIziMBAQEBAQUBAQEBHo94B4QqBZlfhUmMDyKECiKCcwEBAQ X-IronPort-AV: E=Sophos;i="5.09,536,1418101200"; d="scan'208";a="113672129" Received: from 23-91-145-1.cpe.pppoe.ca (HELO pastel.home) ([23.91.145.1]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 16 Mar 2015 09:07:12 -0400 Received: by pastel.home (Postfix, from userid 20848) id B7EF6F89; Mon, 16 Mar 2015 09:07:12 -0400 (EDT) From: Stefan Monnier Message-ID: References: <878uexpeqr.fsf@gmail.com> Date: Mon, 16 Mar 2015 09:07:12 -0400 In-Reply-To: <878uexpeqr.fsf@gmail.com> (Thierry Volpiatto's message of "Mon, 16 Mar 2015 08:45:32 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Using completing-read allow ido user to use ido, helm users helm etc... Indeed, thanks. > + (switch-to-buffer > + (completing-read "Switch-to: " > + (mapcar 'buffer-name > + (erc-buffer-list > + nil > + (when arg erc-server-process))) > + nil t nil nil > + (when (boundp 'erc-modified-channels-alist) > + (buffer-name (caar (last erc-modified-channels-alist))))))) Compared to `C-x b' this loses the ability to obey the completion-category-overrides setting for buffers (i.e. it won't default to substring matches). Also it won't obey read-buffer-completion-ignore-case. I suggest you try and use `read-buffer' instead of `completing-read'. IIUC this will require changes at the C level to add a `predicate' argument to `read-buffer'. And I see this will then have to break backward compatibility since read-buffer-function will end up with a new argument. Stefan From unknown Mon Jun 23 13:10:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20116: 24.4.91; [PATCH]Don't use iswitchb in erc. Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Mar 2015 14:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20116 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: 20116@debbugs.gnu.org Received: via spool by 20116-submit@debbugs.gnu.org id=B20116.142651448022333 (code B ref 20116); Mon, 16 Mar 2015 14:02:02 +0000 Received: (at 20116) by debbugs.gnu.org; 16 Mar 2015 14:01:20 +0000 Received: from localhost ([127.0.0.1]:48677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YXVa3-0005o8-Tu for submit@debbugs.gnu.org; Mon, 16 Mar 2015 10:01:20 -0400 Received: from mail-we0-f178.google.com ([74.125.82.178]:33725) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YXVa0-0005no-Pu for 20116@debbugs.gnu.org; Mon, 16 Mar 2015 10:01:17 -0400 Received: by weop45 with SMTP id p45so13646948weo.0 for <20116@debbugs.gnu.org>; Mon, 16 Mar 2015 07:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; bh=hs2vZnLQrkcuBxdODym39/85PxH2JAlp/Ba/6vKmIUA=; b=o3uZJ4O4oyPRuGj/b9nk80KftQDCVsGkLsZ8/Ak49sAJp/S8aDkwwDGDprKoSLUJyh gwM6qCGYeD4FZ6fAUyZxcZqLNsjsWyIVJ3MWnixh0VRCxfBbxjJDwsa/zcJqVODoMl1l YGZDpw/36wRvL9U327U1/IkoNXbIhxZLNRzzlYsf6klL5/KWyegl3byHLGe3iuUVsU9B pvzM7gkMM56D4Kdscc6q+Npoua37vScSO1/rAmtpdKjrNDY+cvNyZ5XiTzfYOZO2Ox4O wygUAefZ9I5LHNHNg47VNDhbjuimjnONBa4plb/hrSQMZddojIVzEEBY97CMALpy+FvV jI6A== X-Received: by 10.194.85.233 with SMTP id k9mr56934788wjz.31.1426514475398; Mon, 16 Mar 2015 07:01:15 -0700 (PDT) Received: from dell-14z ([37.160.6.250]) by mx.google.com with ESMTPSA id ei3sm15523977wib.4.2015.03.16.07.01.12 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 16 Mar 2015 07:01:14 -0700 (PDT) References: <878uexpeqr.fsf@gmail.com> From: Thierry Volpiatto In-reply-to: Date: Mon, 16 Mar 2015 15:01:09 +0100 Message-ID: <8761a1oxcq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Stefan Monnier writes: >> Using completing-read allow ido user to use ido, helm users helm etc... > > Indeed, thanks. > >> + (switch-to-buffer >> + (completing-read "Switch-to: " >> + (mapcar 'buffer-name >> + (erc-buffer-list >> + nil >> + (when arg erc-server-process))) >> + nil t nil nil >> + (when (boundp 'erc-modified-channels-alist) >> + (buffer-name (caar (last erc-modified-channels-alist))))))) > > Compared to `C-x b' this loses the ability to obey the > completion-category-overrides setting for buffers (i.e. it won't > default to substring matches). Also it won't obey > read-buffer-completion-ignore-case. > > I suggest you try and use `read-buffer' instead of `completing-read'. > IIUC this will require changes at the C level to add a `predicate' > argument to `read-buffer'. And I see this will then have to break > backward compatibility since read-buffer-function will end up with > a new argument. IOW you suggest using something that doesn't exists yet, sorry, but this is out of my scope, well you have my patch "A titre informatif" in case somebody wants to make this change (I personally don't use erc, but I have users that do use it). Thanks. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997 From unknown Mon Jun 23 13:10:20 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Thierry Volpiatto Subject: bug#20116: closed (Re: bug#20116: 24.4.91; [PATCH]Don't use iswitchb in erc.) Message-ID: References: <878uexpeqr.fsf@gmail.com> X-Gnu-PR-Message: they-closed 20116 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 20116@debbugs.gnu.org Date: Mon, 16 Mar 2015 18:50:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1426531804-18032-1" This is a multi-part message in MIME format... ------------=_1426531804-18032-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #20116: 24.4.91; [PATCH]Don't use iswitchb in erc. which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 20116@debbugs.gnu.org. --=20 20116: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D20116 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1426531804-18032-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 20116-done) by debbugs.gnu.org; 16 Mar 2015 18:49:28 +0000 Received: from localhost ([127.0.0.1]:48853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YXa4u-0004g0-Kw for submit@debbugs.gnu.org; Mon, 16 Mar 2015 14:49:28 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:52502) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YXa4s-0004fs-L2 for 20116-done@debbugs.gnu.org; Mon, 16 Mar 2015 14:49:27 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t2GInPmw001113; Mon, 16 Mar 2015 14:49:25 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 05DDE6615C; Mon, 16 Mar 2015 14:49:25 -0400 (EDT) From: Stefan Monnier To: Thierry Volpiatto Subject: Re: bug#20116: 24.4.91; [PATCH]Don't use iswitchb in erc. Message-ID: References: <878uexpeqr.fsf@gmail.com> <8761a1oxcq.fsf@gmail.com> Date: Mon, 16 Mar 2015 14:49:25 -0400 In-Reply-To: <8761a1oxcq.fsf@gmail.com> (Thierry Volpiatto's message of "Mon, 16 Mar 2015 15:01:09 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5247=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5247> : inlines <2424> : streams <1406526> : uri <1882034> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 20116-done Cc: 20116-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > IOW you suggest using something that doesn't exists yet, sorry, but this > is out of my scope, well you have my patch "A titre informatif" in case > somebody wants to make this change (I personally don't use erc, but I > have users that do use it). I believe it's now done, Stefan ------------=_1426531804-18032-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 16 Mar 2015 07:46:01 +0000 Received: from localhost ([127.0.0.1]:48026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YXPiq-0003Tu-8y for submit@debbugs.gnu.org; Mon, 16 Mar 2015 03:46:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40748) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YXPio-0003Tm-5f for submit@debbugs.gnu.org; Mon, 16 Mar 2015 03:45:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXPii-0000Xl-M0 for submit@debbugs.gnu.org; Mon, 16 Mar 2015 03:45:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXPii-0000Xh-IV for submit@debbugs.gnu.org; Mon, 16 Mar 2015 03:45:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXPig-0001qa-Bu for bug-gnu-emacs@gnu.org; Mon, 16 Mar 2015 03:45:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXPiZ-0000Vc-3Q for bug-gnu-emacs@gnu.org; Mon, 16 Mar 2015 03:45:50 -0400 Received: from mail-wg0-x234.google.com ([2a00:1450:400c:c00::234]:33135) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXPiY-0000Us-Or for bug-gnu-emacs@gnu.org; Mon, 16 Mar 2015 03:45:43 -0400 Received: by wgbcc7 with SMTP id cc7so32563060wgb.0 for ; Mon, 16 Mar 2015 00:45:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=kw6/bE5VXTdYZWrTlX551Fv/Wkwo5xTQ+35AoC6l13M=; b=viA7VCvfWX71X97gggvd2tc5mCXfeIoYD1xbAVvE2zCRuvfiGEcG53v1ShcO1Wx8Sr MqpfxityZKOQu5TXF5FDtM8soH9erMXRRa69jTRK/P8juRF7VEZ6KMDHVl4dSWm4RkLp bEWYst/3V7rD6OMXMufsCksXVpTZerNyf8DVXNainJc8ez80skJ/A6ouMWLS5NqI26ah SUBgt7BGvmJ1AxIImKSjemRfUZoj1Q5cw4GCyfWYTi0pU2tyV+W221xT8lZptvz5EYNe sRZL1Tlk869uLczKNxU2xgXJ5KRL81WVjdt851kMgqgwcAClqF8akHYnMRL9CIKdR1ed xpHQ== X-Received: by 10.180.187.19 with SMTP id fo19mr83835621wic.2.1426491941143; Mon, 16 Mar 2015 00:45:41 -0700 (PDT) Received: from dell-14z ([37.162.130.213]) by mx.google.com with ESMTPSA id r14sm14093823wiv.13.2015.03.16.00.45.36 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 16 Mar 2015 00:45:40 -0700 (PDT) From: Thierry Volpiatto To: bug-gnu-emacs@gnu.org Subject: 24.4.91; [PATCH]Don't use iswitchb in erc. Date: Mon, 16 Mar 2015 08:45:32 +0100 Message-ID: <878uexpeqr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hi, erc is still using iswitchb which is deprecated, thus using this directly does not allow other packages (at least helm) to use their own completion. Using completing-read allow ido user to use ido, helm users helm etc... 8c03a0e7352eeb3e40d94897623a5ce5d68a0789 HEAD erc_no_iswitchb Author: Thierry Volpiatto Date: Mon Mar 16 08:37:59 2015 +0100 Don't use iswitchb in erc. * lisp/erc/erc.el (erc-switch-to-buffer): Renamed from erc-iswitchb. Use completing-read. (erc-mode-map): Bind it. 1 file changed, 13 insertions(+), 31 deletions(-) lisp/erc/erc.el | 44 +++++++++++++------------------------------- Modified lisp/erc/erc.el diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index a84f9f0..e76becd 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -1110,7 +1110,7 @@ which the local user typed." (define-key map "\C-a" 'erc-bol) (define-key map [home] 'erc-bol) (define-key map "\C-c\C-a" 'erc-bol) - (define-key map "\C-c\C-b" 'erc-iswitchb) + (define-key map "\C-c\C-b" 'erc-switch-to-buffer) (define-key map "\C-c\C-c" 'erc-toggle-interpret-controls) (define-key map "\C-c\C-d" 'erc-input-action) (define-key map "\C-c\C-e" 'erc-toggle-ctcp-autoresponse) @@ -1697,40 +1697,22 @@ nil." ;; a variable. res))) -;; (iswitchb-mode) will autoload iswitchb.el -(defvar iswitchb-temp-buflist) -(declare-function iswitchb-read-buffer "iswitchb" - (prompt &optional default require-match start matches-set)) -(defvar iswitchb-make-buflist-hook) - -(defun erc-iswitchb (&optional arg) - "Use `iswitchb-read-buffer' to prompt for a ERC buffer to switch to. +(defun erc-switch-to-buffer (&optional arg) + "Prompt for a ERC buffer to switch to. When invoked with prefix argument, use all erc buffers. Without prefix ARG, allow only buffers related to same session server. If `erc-track-mode' is in enabled, put the last element of -`erc-modified-channels-alist' in front of the buffer list. - -Due to some yet unresolved reason, global function `iswitchb-mode' -needs to be active for this function to work." +`erc-modified-channels-alist' in front of the buffer list." (interactive "P") - (let ((enabled (bound-and-true-p iswitchb-mode))) - (or enabled (iswitchb-mode 1)) - (unwind-protect - (let ((iswitchb-make-buflist-hook - (lambda () - (setq iswitchb-temp-buflist - (mapcar 'buffer-name - (erc-buffer-list - nil - (when arg erc-server-process))))))) - (switch-to-buffer - (iswitchb-read-buffer - "Switch-to: " - (if (boundp 'erc-modified-channels-alist) - (buffer-name (caar (last erc-modified-channels-alist))) - nil) - t))) - (or enabled (iswitchb-mode -1))))) + (switch-to-buffer + (completing-read "Switch-to: " + (mapcar 'buffer-name + (erc-buffer-list + nil + (when arg erc-server-process))) + nil t nil nil + (when (boundp 'erc-modified-channels-alist) + (buffer-name (caar (last erc-modified-channels-alist))))))) (defun erc-channel-list (proc) "Return a list of channel buffers. In GNU Emacs 24.4.91.1 (x86_64-unknown-linux-gnu, X toolkit) of 2015-03-12 on dell-14z Repository revision: b21a56ac91e39e75051ad07bb608c39af057adee Windowing system distributor `The X.Org Foundation', version 11.0.11501000 System Description: Ubuntu 14.04.2 LTS Configured using: `configure --with-x-toolkit=lucid --without-toolkit-scroll-bars --without-gconf --without-gsettings' Important settings: value of $LANG: fr_FR.UTF-8 locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: magit-auto-revert-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t diff-auto-refine-mode: t git-gutter-mode: t psession-mode: t golden-ratio-mode: t winner-mode: t global-undo-tree-mode: t undo-tree-mode: t auto-image-file-mode: t eldoc-in-minibuffer-mode: t show-paren-mode: t display-time-mode: t recentf-mode: t savehist-mode: t eldoc-mode: t minibuffer-depth-indicate-mode: t helm-descbinds-mode: t helm-mode: t shell-dirtrack-mode: t helm-adaptive-mode: t helm-match-plugin-mode: t helm-autoresize-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent messages: Running git commit -- When done with a buffer, type C-c C-c Type C-c C-c to commit (C-c C-k to abort). Auto-saving...done Saving file /home/thierry/labo/emacs/.git/COMMIT_EDITMSG... Wrote /home/thierry/labo/emacs/.git/COMMIT_EDITMSG Git finished Type a prefix key to toggle it. Run 'actions' with their prefixes. '?' for more help. Mark set Saved text from "8c03a0e7352eeb3e40d94897623a5ce5d68a0789" Load-path shadows: /home/thierry/.emacs.d/elpa/emms-20150310.458/tq hides /usr/local/share/emacs/24.4.91/lisp/emacs-lisp/tq ~/elisp/auctex/lpath hides ~/elisp/emacs-wget/lpath Features: (shadow emacsbug magit-key-mode magit view help-mode autorevert filenotify git-rebase-mode git-commit-mode log-edit add-log helm-ls-git vc vc-dispatcher cl-indent helm-ring mail-extr helm-dabbrev epa-mail smiley gnus-art mm-uu mml2015 mm-view mml-smime smime dig mule-util network-stream starttls tls erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete erc-track erc-match erc-button erc-fill erc-stamp erc-netsplit erc-goodies erc erc-backend erc-compat helm-command helm-elisp helm-eval package-build lisp-mnt org-element org-rmail org-mhe org-irc org-info org-gnus org-docview org-bibtex bibtex org-bbdb org-w3m sh-script smie executable conf-mode make-mode cc-langs cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs markdown-mode vc-rcs diff-mode vc-git naquadah-theme em-unix em-script em-prompt em-ls em-hist em-pred em-glob em-dirs em-cmpl em-basic em-banner em-alias align-let git-gutter server psession golden-ratio winner undo-tree diff slime-xref-browser slime-banner slime-tramp slime-asdf slime-fancy slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree slime-scratch slime-presentations bridge slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl slime-parse slime etags arc-mode archive-mode image-file xdvi-search preview-latex tex-site auto-loads pcomplete-extension pcmpl-unix pcmpl-gnu em-term term disp-table ehelp python eldoc-eval warnings whitespace paren time recentf tree-widget savehist mu4e-config org-mu4e helm-mu mu4e-contrib mu4e mu4e-speedbar speedbar sb-image ezimage dframe mu4e-main mu4e-view mu4e-headers mu4e-compose mu4e-draft mu4e-actions ido rfc2368 mu4e-mark mu4e-message html2text mu4e-proc mu4e-utils mu4e-lists mu4e-about mu4e-vars hl-line mu4e-meta gnus-dired nnir gnus-sum gnus-group gnus-undo nnmail mail-source gnus-start gnus-spec gnus-int gnus-range gnus-win nnoo config-w3m w3m-search w3m doc-view jka-compr image-mode timezone w3m-hist w3m-fb bookmark-w3m w3m-ems w3m-ccl ccl w3m-favicon w3m-image w3m-proc w3m-util smtpmail-async smtpmail sendmail dired-async iterator lacarte iedit-rect iedit iedit-lib smallurl mm-url gnus gnus-ems nnheader wid-edit rectangle-utils rect ledger-config ledger esh-var esh-io esh-cmd esh-opt esh-ext esh-proc eldoc esh-groups eshell esh-module esh-mode esh-arg esh-util tv-utils pcvs vc-cvs pcvs-parse pcvs-info pcvs-defs pcvs-util ewoc mb-depth cl-info hyperspec esh-toggle flymake no-word htmlize cl dired-extension emms-vlc-config emms-librefm-stream emms-librefm-scrobbler emms-playlist-limit emms-volume emms-volume-amixer emms-i18n emms-history emms-score emms-stream-info emms-metaplaylist-mode emms-bookmarks emms-cue emms-mode-line-icon emms-browser sort emms-playlist-sort emms-last-played emms-player-xine emms-player-mpd tq emms-playing-time emms-lyrics emms-url emms-tag-editor emms-mark emms-mode-line emms-cache emms-info-ogginfo emms-info-mp3info emms-playlist-mode emms-player-vlc emms-player-mplayer emms-info emms-streams later-do emms-source-playlist emms-source-file locate emms-player-simple emms-setup emms emms-compat org-config-thierry ob-sh org-crypt appt diary-lib diary-loaddefs org-annotation-helper addressbook-bookmark message rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader bookmark-firefox-handler bookmark-extensions init-helm-thierry helm-descbinds helm-extensions-autoloads helm-mode helm-files image-dired tramp tramp-compat tramp-loaddefs trampver shell dired-x dired-aux ffap thingatpt helm-buffers helm-elscreen helm-tags helm-bookmark helm-adaptive helm-info bookmark pp helm-locate helm-help helm-org org-location-google-maps org-agenda google-maps google-maps-static google-maps-geocode google-maps-base json org org-macro org-footnote org-pcomplete pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs format-spec find-func cal-menu calendar cal-loaddefs helm-match-plugin helm-grep wgrep-helm wgrep helm-regexp helm-plugin grep helm-external helm-net browse-url xml url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse url-vars mailcap helm-utils dired compile comint ansi-color ring helm easy-mmode helm-source helm-config helm-autoloads async-bytecomp async helm-aliases epa-file epa derived epg auth-source eieio byte-opt bytecomp byte-compile cl-extra cconv eieio-core gnus-util mm-util mail-prsvr password-cache cl-macs gv slime-autoloads package epg-config time-date avoid cus-start cus-load w3m-wget info easymenu edmacro kmacro advice help-fns net-utils cl-loaddefs cl-lib tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind gfilenotify dynamic-setting font-render-setting x-toolkit x multi-tty emacs) Memory information: ((conses 16 630268 48383) (symbols 48 67566 0) (miscs 40 2227 1485) (strings 32 178215 24587) (string-bytes 1 5234753) (vectors 16 68597) (vector-slots 8 1767252 27510) (floats 8 1828 1180) (intervals 56 7470 1145) (buffers 960 185) (heap 1024 62416 3341)) -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997 ------------=_1426531804-18032-1-- From unknown Mon Jun 23 13:10:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20116: 24.4.91; [PATCH]Don't use iswitchb in erc. Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Mar 2015 18:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20116 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: 20116-done@debbugs.gnu.org Received: via spool by 20116-done@debbugs.gnu.org id=D20116.142653232618959 (code D ref 20116); Mon, 16 Mar 2015 18:59:02 +0000 Received: (at 20116-done) by debbugs.gnu.org; 16 Mar 2015 18:58:46 +0000 Received: from localhost ([127.0.0.1]:48876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YXaDt-0004vi-AY for submit@debbugs.gnu.org; Mon, 16 Mar 2015 14:58:45 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:33140) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YXaDq-0004va-TO for 20116-done@debbugs.gnu.org; Mon, 16 Mar 2015 14:58:43 -0400 Received: by wgbcc7 with SMTP id cc7so47702225wgb.0 for <20116-done@debbugs.gnu.org>; Mon, 16 Mar 2015 11:58:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; bh=XWw4eWmj5iKlKSmiGymjJ6XFmSDaOAgsNU1PvgsHbWU=; b=oA211evxCqM39mJ0YHijBVYAVvnKaiier+EF7OX89oxTPlv9p1BSqaTBh6PudIJCXW BVzhEUdv5M0Bk6W+urmrIzhkZ/taK5xfOGJxbz0PABGdMlRdPwCJWLv29mMfU2SKE1X0 syoZun7SFgrcdX9pwr7tXCjYUPLu7tVDDHGz3aJLSUsC32x2BF0KK2HAX4G+isD2w/Tp 5boyl2Vl01uZU+FDVQ5eQkzZCWJqvr7837yBNURfkCIdPXiMs+c1eTU32jcCeq8v4Cm/ mqKhiQNWS73MWyzM8kqywRPJqublGYjOiY0/AnYxA8MXmOxOET0uGOm0fAkhesapON3L oHTA== X-Received: by 10.180.79.232 with SMTP id m8mr170957118wix.81.1426532322032; Mon, 16 Mar 2015 11:58:42 -0700 (PDT) Received: from dell-14z ([37.160.6.250]) by mx.google.com with ESMTPSA id ub1sm16589970wjc.43.2015.03.16.11.58.39 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 16 Mar 2015 11:58:40 -0700 (PDT) References: <878uexpeqr.fsf@gmail.com> <8761a1oxcq.fsf@gmail.com> From: Thierry Volpiatto In-reply-to: Date: Mon, 16 Mar 2015 19:58:35 +0100 Message-ID: <878uewojl0.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Stefan Monnier writes: > I believe it's now done, Great, thanks stefan. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997