From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 11 11:02:28 2015 Received: (at submit) by debbugs.gnu.org; 11 Mar 2015 15:02:28 +0000 Received: from localhost ([127.0.0.1]:42914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YVi9U-0000wh-Cd for submit@debbugs.gnu.org; Wed, 11 Mar 2015 11:02:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47836) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YVi9S-0000wT-61 for submit@debbugs.gnu.org; Wed, 11 Mar 2015 11:02:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVi9M-00073s-53 for submit@debbugs.gnu.org; Wed, 11 Mar 2015 11:02:21 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49395) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVi9M-00073o-2X for submit@debbugs.gnu.org; Wed, 11 Mar 2015 11:02:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVi9L-0005YS-06 for bug-guix@gnu.org; Wed, 11 Mar 2015 11:02:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVi9F-000711-19 for bug-guix@gnu.org; Wed, 11 Mar 2015 11:02:18 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56691 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVi9E-00070i-QO for bug-guix@gnu.org; Wed, 11 Mar 2015 11:02:12 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id B189AAAC8 for ; Wed, 11 Mar 2015 15:02:11 +0000 (UTC) Date: Wed, 11 Mar 2015 16:02:11 +0100 From: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= To: bug-guix@gnu.org Subject: patch-source-shebangs crashes on broken symlink Message-ID: <20150311150211.GK16813@crashnator.suse.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fmvA4kSBHQVZhkR6" Content-Disposition: inline User-Agent: Mutt/1.5.21 (2011-07-01) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --fmvA4kSBHQVZhkR6 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline I'm trying to create package for taskwarrior. Source tarball contain symlinks to nonexisting file `task': $ tar tvf /gnu/store/*-task*.tar.gz | grep -E '/src/(tw|cal |calendar|task)' lrwxr-xr-x ultrafredde/staff 0 2015-02-16 23:45 task-2.4.1/src/cal -> task lrwxr-xr-x ultrafredde/staff 0 2015-02-16 23:45 task-2.4.1/src/calendar -> task lrwxr-xr-x ultrafredde/staff 0 2015-02-16 23:45 task-2.4.1/src/tw -> task When I run build, I got this backtrace: phase `unpack' succeeded after 0 seconds starting phase `patch-usr-bin-file' phase `patch-usr-bin-file' succeeded after 0 seconds starting phase `patch-source-shebangs' Backtrace: In ice-9/boot-9.scm: 157: 15 [catch #t # ...] In unknown file: ?: 14 [apply-smob/1 #] In ice-9/boot-9.scm: 63: 13 [call-with-prompt prompt0 ...] In ice-9/eval.scm: 432: 12 [eval # #] In ice-9/boot-9.scm: 2401: 11 [save-module-excursion #] 4050: 10 [#] 1724: 9 [%start-stack load-stack #] 1729: 8 [#] In unknown file: ?: 7 [primitive-load "/gnu/store/ix1s7q448frw02wy9xvzhd66vh08lxcw-taskwarrior-2.4.1-guile-builder"] In ice-9/eval.scm: 387: 6 [eval # ()] In srfi/srfi-1.scm: 830: 5 [every1 # ...] In /gnu/store/dyv4k9p9na96q4yzahdlvij3nadaz65h-module-import/guix/build/gnu-build-system.scm: 511: 4 [# #] 164: 3 [patch-source-shebangs # ...] In unknown file: ?: 2 [remove # #] In ice-9/boot-9.scm: 1461: 1 [# "./src/cal"] In unknown file: ?: 0 [stat "./src/cal" #] ERROR: In procedure stat: ERROR: In procedure stat: No such file or directory: "./src/cal" builder for `/gnu/store/vr408ijifflkqjk9lgpj3sv469fj2pik-taskwarrior-2.4.1.drv' failed with exit code 1 cannot build derivation `/gnu/store/367g51d6vh8v5m1q58hls6bn40ha1262-profile.drv': 1 dependencies couldn't be built guix package: error: build failed: build of `/gnu/store/367g51d6vh8v5m1q58hls6bn40ha1262-profile.drv' failed --fmvA4kSBHQVZhkR6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlUAWPEACgkQ37XrCapiVCNJlACfYdl5qB/BCOfX0YsWUzttEsyl rd8AoLKf85+cP8ouNZwZuWy89aVopn/g =YQo8 -----END PGP SIGNATURE----- --fmvA4kSBHQVZhkR6-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 11 13:32:42 2015 Received: (at 20081) by debbugs.gnu.org; 11 Mar 2015 17:32:42 +0000 Received: from localhost ([127.0.0.1]:43046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YVkUs-0004yK-Eu for submit@debbugs.gnu.org; Wed, 11 Mar 2015 13:32:42 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:52273) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YVkUp-0004xx-86 for 20081@debbugs.gnu.org; Wed, 11 Mar 2015 13:32:40 -0400 Received: from debian.math.u-bordeaux1.fr ([147.210.21.57]) by mrelayeu.kundenserver.de (mreue102) with ESMTPSA (Nemesis) id 0LiCiR-1ZJ3nw3qrb-00nTXS; Wed, 11 Mar 2015 18:32:32 +0100 Date: Wed, 11 Mar 2015 18:32:30 +0100 From: Andreas Enge To: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= Subject: Re: bug#20081: patch-source-shebangs crashes on broken symlink Message-ID: <20150311173230.GA12508@debian.math.u-bordeaux1.fr> References: <20150311150211.GK16813@crashnator.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150311150211.GK16813@crashnator.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) X-Provags-ID: V03:K0:EX9NzIWW/ErU22xGwXzDqcNbzrDLqOsx8qBrp6dxIUDCGxRoYSY pYPTl0bw8X6NPjSO52Ec/19emHhYlz+HBGIOm8OPCwRErkYmdSLLYz87FAwkgWp5TGeytPj LdUHRIg7D1rRgMB9BWH1ZZEtPtbKtHmNzWd/YZ48oVG20sxvJzaVnuSegs8jMru+02YryJw 6DQBCsN34EU5Zt/Rg4LDw== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20081 Cc: 20081@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Wed, Mar 11, 2015 at 04:02:11PM +0100, Tomáš Čech wrote: > I'm trying to create package for taskwarrior. > Source tarball contain symlinks to nonexisting file `task': I would argue that this is not a bug in guix, but in the tarball. You can remove the link with an additional phase before 'configure, see, for instance, the dvdisaster package in cdrom.scm. Andreas From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 11 15:13:43 2015 Received: (at 20081) by debbugs.gnu.org; 11 Mar 2015 19:13:43 +0000 Received: from localhost ([127.0.0.1]:43146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YVm4d-0002Av-4T for submit@debbugs.gnu.org; Wed, 11 Mar 2015 15:13:43 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39989 helo=mx2.suse.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YVm4b-0002Al-E9 for 20081@debbugs.gnu.org; Wed, 11 Mar 2015 15:13:42 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 90EC2ACF1; Wed, 11 Mar 2015 19:13:40 +0000 (UTC) Date: Wed, 11 Mar 2015 20:13:39 +0100 From: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= To: Andreas Enge Subject: Re: bug#20081: patch-source-shebangs crashes on broken symlink Message-ID: <20150311191235.GA29520@venom> References: <20150311150211.GK16813@crashnator.suse.cz> <20150311173230.GA12508@debian.math.u-bordeaux1.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20150311173230.GA12508@debian.math.u-bordeaux1.fr> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 20081 Cc: 20081@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On Wed, Mar 11, 2015 at 06:32:30PM +0100, Andreas Enge wrote: >On Wed, Mar 11, 2015 at 04:02:11PM +0100, Tom=C3=A1=C5=A1 =C4=8Cech wrote: >> I'm trying to create package for taskwarrior. >> Source tarball contain symlinks to nonexisting file `task': > >I would argue that this is not a bug in guix, but in the tarball. >You can remove the link with an additional phase before 'configure, see, f= or >instance, the dvdisaster package in cdrom.scm. I agree with you that the fishy part is in tarball, but we could make build more robust. Getting backtrace is not nice way to end a build. And we alone are getting into this problem it is not usual to preprocess source files before compilation. I already worked around the bug to confirm I correctly identified the cause. S_W From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 11 16:18:40 2015 Received: (at 20081) by debbugs.gnu.org; 11 Mar 2015 20:18:40 +0000 Received: from localhost ([127.0.0.1]:43163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YVn5U-00042e-1u for submit@debbugs.gnu.org; Wed, 11 Mar 2015 16:18:40 -0400 Received: from world.peace.net ([50.252.239.5]:44601 ident=hope4) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YVn5R-00042S-BV for 20081@debbugs.gnu.org; Wed, 11 Mar 2015 16:18:38 -0400 Received: from [10.1.10.78] (helo=jojen) by world.peace.net with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1YVn5J-0004zG-LC; Wed, 11 Mar 2015 16:18:29 -0400 From: Mark H Weaver To: Andreas Enge Subject: Re: bug#20081: patch-source-shebangs crashes on broken symlink References: <20150311150211.GK16813@crashnator.suse.cz> <20150311173230.GA12508@debian.math.u-bordeaux1.fr> Date: Wed, 11 Mar 2015 16:18:53 -0400 In-Reply-To: <20150311173230.GA12508@debian.math.u-bordeaux1.fr> (Andreas Enge's message of "Wed, 11 Mar 2015 18:32:30 +0100") Message-ID: <87fv9bz3rm.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20081 Cc: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= , 20081@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Andreas Enge writes: > On Wed, Mar 11, 2015 at 04:02:11PM +0100, Tom=C3=A1=C5=A1 =C4=8Cech wrote: >> I'm trying to create package for taskwarrior. >> Source tarball contain symlinks to nonexisting file `task': > > I would argue that this is not a bug in guix, but in the tarball. > You can remove the link with an additional phase before 'configure, see, = for > instance, the dvdisaster package in cdrom.scm. The phase should go after the 'unpack' phase rather than before configure, but otherwise I agree with Andreas. Mark From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 12 05:31:00 2015 Received: (at 20081) by debbugs.gnu.org; 12 Mar 2015 09:31:00 +0000 Received: from localhost ([127.0.0.1]:43450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YVzSG-0007Mi-BJ for submit@debbugs.gnu.org; Thu, 12 Mar 2015 05:31:00 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:53312 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YVzSE-0007Ma-4g for 20081@debbugs.gnu.org; Thu, 12 Mar 2015 05:30:58 -0400 Received: from pluto.bordeaux.inria.fr ([193.50.110.57]:56089 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1YVzSD-0003Wf-Az; Thu, 12 Mar 2015 05:30:57 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= Subject: Re: bug#20081: patch-source-shebangs crashes on broken symlink References: <20150311150211.GK16813@crashnator.suse.cz> <20150311173230.GA12508@debian.math.u-bordeaux1.fr> <20150311191235.GA29520@venom> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 =?utf-8?Q?Vent=C3=B4se?= an 223 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu Date: Thu, 12 Mar 2015 10:30:55 +0100 In-Reply-To: <20150311191235.GA29520@venom> (=?utf-8?B?IlRvbcOhxaEgxIxl?= =?utf-8?B?Y2giJ3M=?= message of "Wed, 11 Mar 2015 20:13:39 +0100") Message-ID: <87oanyv9yo.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 20081 Cc: Andreas Enge , 20081@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tom=C3=A1=C5=A1 =C4=8Cech skribis: > On Wed, Mar 11, 2015 at 06:32:30PM +0100, Andreas Enge wrote: >>On Wed, Mar 11, 2015 at 04:02:11PM +0100, Tom=C3=A1=C5=A1 =C4=8Cech wrote: >>> I'm trying to create package for taskwarrior. >>> Source tarball contain symlinks to nonexisting file `task': >> >>I would argue that this is not a bug in guix, but in the tarball. >>You can remove the link with an additional phase before 'configure, see, = for >>instance, the dvdisaster package in cdrom.scm. > > I agree with you that the fishy part is in tarball, but we could make > build more robust. Getting backtrace is not nice way to end a build. I agree. I think we should patch =E2=80=98find-files=E2=80=99 in core-upda= tes to not follow symlinks: --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/guix/build/utils.scm b/guix/build/utils.scm index a5a6167..9cbddcd 100644 --- a/guix/build/utils.scm +++ b/guix/build/utils.scm @@ -288,7 +288,8 @@ matches REGEXP." file (strerror errno)) result) '() - dir) + dir + lstat) string) id 1YVzXq-0007VM-4c for submit@debbugs.gnu.org; Thu, 12 Mar 2015 05:36:46 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39097 helo=mx2.suse.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YVzXj-0007V7-LD for 20081@debbugs.gnu.org; Thu, 12 Mar 2015 05:36:44 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A9694AE06; Thu, 12 Mar 2015 09:36:38 +0000 (UTC) Date: Thu, 12 Mar 2015 10:36:33 +0100 From: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= To: Ludovic =?iso-8859-1?Q?Court=E8s?= Subject: Re: bug#20081: patch-source-shebangs crashes on broken symlink Message-ID: <20150312093633.GN16813@crashnator.suse.cz> References: <20150311150211.GK16813@crashnator.suse.cz> <20150311173230.GA12508@debian.math.u-bordeaux1.fr> <20150311191235.GA29520@venom> <87oanyv9yo.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1X+6QtwRodzgDPAC" Content-Disposition: inline In-Reply-To: <87oanyv9yo.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2011-07-01) X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 20081 Cc: Andreas Enge , 20081@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --1X+6QtwRodzgDPAC Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 12, 2015 at 10:30:55AM +0100, Ludovic Court=C3=A8s wrote: >Tom=C3=A1=C5=A1 =C4=8Cech skribis: > >> On Wed, Mar 11, 2015 at 06:32:30PM +0100, Andreas Enge wrote: >>>On Wed, Mar 11, 2015 at 04:02:11PM +0100, Tom=C3=A1=C5=A1 =C4=8Cech wrot= e: >>>> I'm trying to create package for taskwarrior. >>>> Source tarball contain symlinks to nonexisting file `task': >>> >>>I would argue that this is not a bug in guix, but in the tarball. >>>You can remove the link with an additional phase before 'configure, see,= for >>>instance, the dvdisaster package in cdrom.scm. >> >> I agree with you that the fishy part is in tarball, but we could make >> build more robust. Getting backtrace is not nice way to end a build. > >I agree. I think we should patch =E2=80=98find-files=E2=80=99 in core-upd= ates to not >follow symlinks: > >=1B[1;32mdiff --git a/guix/build/utils.scm b/guix/build/utils.scm=1B[0;0m >=1B[0;0mindex a5a6167..9cbddcd 100644=1B[0;0m >=1B[1;31m--- a/guix/build/utils.scm=1B[0;0m >=1B[1;34m+++ b/guix/build/utils.scm=1B[0;0m >=1B[1;35m@@ -288,7 +288,8 @@ matches REGEXP."=1B[0;0m >=1B[0;0m file (strerror errno))=1B[0;0m >=1B[0;0m result)=1B[0;0m >=1B[0;0m '()=1B[0;0m >=1B[1;31m- dir)=1B[0;0m >=1B[1;34m+ dir=1B[0;0m >=1B[1;34m+ lstat)=1B[0;0m >=1B[0;0m string=1B[0;0m =1B[0;0m >=1B[0;0m =0C=1B[0;0m > >Thoughts? Ignoring symlinks is nice solution. I'd add comment: We won't touch broken symlinks, symlinks pointing within the sources will be fixed anyway. Thanks! S_W --1X+6QtwRodzgDPAC Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlUBXh4ACgkQ37XrCapiVCPEogCgmuX0kWgAXthUXzweqbpl/PeI 5MwAoKkmg7jZ0h0dRIpxAPo3NcN3S+Hi =rC0J -----END PGP SIGNATURE----- --1X+6QtwRodzgDPAC-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 06 17:22:47 2015 Received: (at 20081-done) by debbugs.gnu.org; 6 Apr 2015 21:22:47 +0000 Received: from localhost ([127.0.0.1]:46604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YfETm-0001Eu-Ox for submit@debbugs.gnu.org; Mon, 06 Apr 2015 17:22:47 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:39455 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YfETl-0001Em-0o for 20081-done@debbugs.gnu.org; Mon, 06 Apr 2015 17:22:45 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:49796 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1YfETk-0006DS-BF; Mon, 06 Apr 2015 17:22:44 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= Subject: Re: bug#20081: patch-source-shebangs crashes on broken symlink References: <20150311150211.GK16813@crashnator.suse.cz> <20150311173230.GA12508@debian.math.u-bordeaux1.fr> <20150311191235.GA29520@venom> <87oanyv9yo.fsf@gnu.org> Date: Mon, 06 Apr 2015 23:22:41 +0200 In-Reply-To: <87oanyv9yo.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 12 Mar 2015 10:30:55 +0100") Message-ID: <87384d6jfi.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 20081-done Cc: Andreas Enge , 20081-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > Tom=C3=A1=C5=A1 =C4=8Cech skribis: > >> On Wed, Mar 11, 2015 at 06:32:30PM +0100, Andreas Enge wrote: >>>On Wed, Mar 11, 2015 at 04:02:11PM +0100, Tom=C3=A1=C5=A1 =C4=8Cech wrot= e: >>>> I'm trying to create package for taskwarrior. >>>> Source tarball contain symlinks to nonexisting file `task': >>> >>>I would argue that this is not a bug in guix, but in the tarball. >>>You can remove the link with an additional phase before 'configure, see,= for >>>instance, the dvdisaster package in cdrom.scm. >> >> I agree with you that the fishy part is in tarball, but we could make >> build more robust. Getting backtrace is not nice way to end a build. > > I agree. I think we should patch =E2=80=98find-files=E2=80=99 in core-up= dates to not > follow symlinks: Done in 347f54e. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 22 15:07:03 2015 Received: (at 20081) by debbugs.gnu.org; 22 Apr 2015 19:07:03 +0000 Received: from localhost ([127.0.0.1]:36762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YkzzC-0000nV-LV for submit@debbugs.gnu.org; Wed, 22 Apr 2015 15:07:02 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44549 helo=mx2.suse.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ykzz9-0000n5-PT for 20081@debbugs.gnu.org; Wed, 22 Apr 2015 15:07:00 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C88CEAB5F for <20081@debbugs.gnu.org>; Wed, 22 Apr 2015 19:06:58 +0000 (UTC) Date: Wed, 22 Apr 2015 21:06:59 +0200 From: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= To: 20081@debbugs.gnu.org Subject: issue is still not fixed Message-ID: <20150422190659.GF9813@venom> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="f0KYrhQ4vYSV2aJu" Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 20081 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --f0KYrhQ4vYSV2aJu Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Hi, during my clean-up of taskwarrior package I removed section which removes broken symlinks. Even though this bug is considered as fixed, I believe I reproduced it after 347f54e. ... task-2.4.3/src/ViewText.cpp task-2.4.3/src/ViewText.h task-2.4.3/src/wcwidth6.cpp phase `unpack' succeeded after 0 seconds starting phase `patch-usr-bin-file' phase `patch-usr-bin-file' succeeded after 0 seconds starting phase `patch-source-shebangs' Backtrace: In ice-9/boot-9.scm: 157: 15 [catch #t # ...] In unknown file: ?: 14 [apply-smob/1 #] In ice-9/boot-9.scm: 63: 13 [call-with-prompt prompt0 ...] In ice-9/eval.scm: 432: 12 [eval # #] In ice-9/boot-9.scm: 2401: 11 [save-module-excursion #] 4050: 10 [#] 1724: 9 [%start-stack load-stack ...] 1729: 8 [#] In unknown file: ?: 7 [primitive-load "/gnu/store/06l4f3al56cg49rfiy79risam0f8yb4y-taskwarrior-2.4.3-guile-builder"] In ice-9/eval.scm: 387: 6 [eval # ()] In srfi/srfi-1.scm: 830: 5 [every1 # ...] In /gnu/store/j8w9vf3diyvkccsa21p9fqpwsl3wlsy3-module-import/guix/build/gnu-build-system.scm: 584: 4 [# #] 167: 3 [patch-source-shebangs # ...] In unknown file: ?: 2 [remove # #] In ice-9/boot-9.scm: 1461: 1 [# "./src/cal"] In unknown file: ?: 0 [stat "./src/cal" #] ERROR: In procedure stat: ERROR: In procedure stat: No such file or directory: "./src/cal" --f0KYrhQ4vYSV2aJu Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlU38U0ACgkQ37XrCapiVCO7HQCfVUy2tXHjy19ykcITrURvy8sb JNcAoJPX6rjP0v+OMNZDcvGbnBcW3eP1 =/IJh -----END PGP SIGNATURE----- --f0KYrhQ4vYSV2aJu-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 23 14:59:04 2015 Received: (at 20081) by debbugs.gnu.org; 23 Apr 2015 18:59:04 +0000 Received: from localhost ([127.0.0.1]:38013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YlML1-0003Zx-UU for submit@debbugs.gnu.org; Thu, 23 Apr 2015 14:59:04 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:50092 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YlML0-0003Zf-A0 for 20081@debbugs.gnu.org; Thu, 23 Apr 2015 14:59:02 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:48916 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1YlMKz-0000cn-2H; Thu, 23 Apr 2015 14:59:01 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= Subject: Dangling symlinks gracelessly handled by =?utf-8?Q?=E2=80=98patch?= =?utf-8?Q?-shebangs=E2=80=99?= & co. References: <20150311150211.GK16813@crashnator.suse.cz> <20150422190659.GF9813@venom> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 4 =?utf-8?Q?Flor=C3=A9al?= an 223 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x3D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Thu, 23 Apr 2015 20:58:58 +0200 In-Reply-To: <20150422190659.GF9813@venom> (=?utf-8?B?IlRvbcOhxaEgxIxlY2gi?= =?utf-8?B?J3M=?= message of "Wed, 22 Apr 2015 21:06:59 +0200") Message-ID: <87618meknh.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 20081 Cc: 20081@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Tom=C3=A1=C5=A1 =C4=8Cech skribis: > starting phase `patch-source-shebangs' > Backtrace: > In ice-9/boot-9.scm: > 157: 15 [catch #t # ...] > In unknown file: > ?: 14 [apply-smob/1 #] > In ice-9/boot-9.scm: > 63: 13 [call-with-prompt prompt0 ...] > In ice-9/eval.scm: > 432: 12 [eval # #] > In ice-9/boot-9.scm: > 2401: 11 [save-module-excursion #] > 4050: 10 [#] > 1724: 9 [%start-stack load-stack ...] > 1729: 8 [#] > In unknown file: > ?: 7 [primitive-load "/gnu/store/06l4f3al56cg49rfiy79risam0f8yb4y-taskw= arrior-2.4.3-guile-builder"] > In ice-9/eval.scm: > 387: 6 [eval # ()] > In srfi/srfi-1.scm: > 830: 5 [every1 # ...] > In /gnu/store/j8w9vf3diyvkccsa21p9fqpwsl3wlsy3-module-import/guix/build/g= nu-build-system.scm: > 584: 4 [# #] > 167: 3 [patch-source-shebangs # ...] > In unknown file: > ?: 2 [remove # #] > In ice-9/boot-9.scm: > 1461: 1 [# "./src/cal= "] > In unknown file: > ?: 0 [stat "./src/cal" #] I believe this is Really Fixed=E2=84=A2 by cb85eb5 (in core-updates.) Thanks! Ludo=E2=80=99. From unknown Mon Jun 23 11:26:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 22 May 2015 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator