GNU bug report logs - #20062
[PATCH] diff: add support for --color

Previous Next

Package: diffutils;

Reported by: Giuseppe Scrivano <gscrivan <at> redhat.com>

Date: Sun, 8 Mar 2015 21:57:02 UTC

Severity: normal

Tags: patch

Done: Jim Meyering <jim <at> meyering.net>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Andreas Grünbacher <agruen <at> gnu.org>
To: Giuseppe Scrivano <gscrivan <at> redhat.com>
Cc: Paul Eggert <eggert <at> cs.ucla.edu>, 20062 <at> debbugs.gnu.org
Subject: bug#20062: [bug-diffutils] bug#20062: bug#20062: bug#20062: [PATCH] diff: add support for --color
Date: Sat, 14 Mar 2015 19:59:52 +0100

Giuseppe,

2015-03-13 19:08 GMT+01:00 Giuseppe Scrivano <gscrivan <at> redhat.com>:
> Giuseppe Scrivano <gscrivan <at> redhat.com> writes:
>
>> I'll send an updated version later today.

here are some more comments:

 * Please have a look at your changes to doc/diffutils.texi, they make no sense.

 * colors_style is never initialized and defaults to NEVER; it should
default to AUTO.

 * Please colorize the output of non-unified diffs as well.

 * Please use one of the common existing color schemes, not a new one -- for
   example, the one used by vim or "git diff". Those colorize patch
header lines as well.

Thanks,
Andreas
This bug report was last modified 8 years and 98 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.