GNU bug report logs - #20062
[PATCH] diff: add support for --color

Previous Next

Full log

View this message in rfc822 format

From: Giuseppe Scrivano <gscrivan <at> redhat.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Eric Blake <eblake <at> redhat.com>, 20062 <at> debbugs.gnu.org
Subject: bug#20062: [bug-diffutils] bug#20062: bug#20062: [PATCH] diff: add support for --color
Date: Thu, 12 Mar 2015 10:14:03 +0100

Hi Paul,

Paul Eggert <eggert <at> cs.ucla.edu> writes:

> Also, I'm a bit dubious about all those calls to sigprocmask.  Can't
> we solve this without having to execute a sigmask-related system call
> for each buffer? How about using the method that 'ls' uses instead?
> Install a signal handler that merely sets a static variable.  Perhaps
> the relevant 'ls' code should be Gnulib-ized, so that it can be shared
> between 'ls' and 'diff'.

is it ok for now to keep these calls to sigprocmask and fix all the
other issues you reported (until the ls.c code is Gnulib-ized)?
They won't affect any existing use-case anyway as they will be used only
when --color is used on a tty.

Thanks for the detailed review.

Giuseppe

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.