GNU bug report logs - #20062
[PATCH] diff: add support for --color

Previous Next

Package: diffutils;

Reported by: Giuseppe Scrivano <gscrivan <at> redhat.com>

Date: Sun, 8 Mar 2015 21:57:02 UTC

Severity: normal

Tags: patch

Done: Jim Meyering <jim <at> meyering.net>

Bug is archived. No further changes may be made.

Full log


Message #251 received at 20062 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Giuseppe Scrivano <gscrivano <at> gnu.org>
Cc: Eric Blake <eblake <at> redhat.com>, 20062 <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#20062: [PATCH] diff: add support for --color
Date: Sun, 29 Nov 2015 08:40:20 -0800
On Sun, Nov 29, 2015 at 5:45 AM, Giuseppe Scrivano <gscrivano <at> gnu.org> wrote:
> Jim Meyering <jim <at> meyering.net> writes:
>
>> On Sat, Nov 28, 2015 at 12:36 PM, Giuseppe Scrivano <gscrivano <at> gnu.org> wrote:
>> ....
>>> As it is hopefully getting closer to be accepted, I am attaching the
>>> full series with the amended changes.  I've verified that each patch
>>> passes "make check" and "make syntax-check".
>>
>> Thanks, I see no problem.
>> I can push as-is, but wondered if you wanted to merge
>> your 0005 patch into the others? Probably not worth the work.
>> Either way is fine.
>
> it was not much work as there were no conflicts to solve, so I splitted
> 0005 into 0001 and 0004.  I verified again that each step passes all the
> tests.

Good! Worthwhile after all. Thank you.
I have just pushed those commits.




This bug report was last modified 8 years and 78 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.