GNU bug report logs - #20062
[PATCH] diff: add support for --color

Previous Next

Full log

Message #224 received at 20062 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Eric Blake <eblake <at> redhat.com>
Cc: Giuseppe Scrivano <gscrivano <at> gnu.org>, 20062 <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#20062: [PATCH] diff: add support for --color
Date: Tue, 3 Nov 2015 09:30:42 -0800

On Tue, Nov 3, 2015 at 9:27 AM, Eric Blake <eblake <at> redhat.com> wrote:
> On 11/03/2015 10:05 AM, Giuseppe Scrivano wrote:
>
>> I have attached the patches that implement --palette, the missing tests
>> and update the NEWS file.
>>
>
>> +++ b/doc/diffutils.texi
>> @@ -3763,6 +3763,7 @@ Always use color.
>>  Specifying @option{--color} and no @var{when} is equivalent to
>>  @option{--color=auto}.
>>
>> +
>>  @item -C @var{lines}
>
> Spurious change?
>
>>  @itemx --context <at> r{[}=@var{lines}@r{]}
>>  Use the context output format, showing @var{lines} (an integer) lines of
>> @@ -3890,6 +3891,11 @@ if-then-else format.  @xref{Line Formats}.
>>  @itemx --show-c-function
>>  Show which C function each change is in.  @xref{C Function Headings}.
>>
>> +@item --palette=@var{scheme}
>> +It allows to specify what colors are used to colorize the output.  It
>
> Passive voice.  Would sound better as:
>
> Specify what color palette to use when colored output to use.

Thanks for the quick review, Eric.
I'll wait for the next iteration.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.