GNU bug report logs - #20062
[PATCH] diff: add support for --color

Previous Next

Full log

Message #155 received at 20062 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eric Blake <eblake <at> redhat.com>, Giuseppe Scrivano <gscrivan <at> redhat.com>
Cc: 20062 <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#20062: bug#20062: bug#20062: bug#20062:
 [PATCH] diff: add support for --color
Date: Fri, 11 Sep 2015 15:14:53 -0700

Eric Blake wrote:
> It seems like the only safe way is to block
> TSTP except for in places where you know that you do NOT have pending
> data that would mess with the terminal, even if the cost of getting the
> process to a point where it will actually stop in response to the user
> request takes longer.

That's one way to do it, yes.  In practice, though, it's easier (and probably 
faster) to do what GNU ls does, namely to have the the signal handler just set a 
volatile flag, and to periodically inspect the flag during normal computation in 
places where you can easily arrange for the terminal to be in a known state 
before acting on the signal.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.