Subject: bug#20062: [bug-diffutils] bug#20062: bug#20062: bug#20062: [PATCH] diff: add support for --color

From: Andreas Grünbacher <[email-masked]>
Date: Sat, 14 Mar 2015 19:59:52 +0100

Giuseppe,

2015-03-13 19:08 GMT+01:00 Giuseppe Scrivano <[email-masked]>:
> Giuseppe Scrivano <[email-masked]> writes:
>
>> I'll send an updated version later today.

here are some more comments:

 * Please have a look at your changes to doc/diffutils.texi, they make no sense.

 * colors_style is never initialized and defaults to NEVER; it should
default to AUTO.

 * Please colorize the output of non-unified diffs as well.

 * Please use one of the common existing color schemes, not a new one -- for
   example, the one used by vim or "git diff". Those colorize patch
header lines as well.

Thanks,
Andreas