From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 07 14:46:08 2015 Received: (at submit) by debbugs.gnu.org; 7 Mar 2015 19:46:08 +0000 Received: from localhost ([127.0.0.1]:38886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUKfn-0007OA-NN for submit@debbugs.gnu.org; Sat, 07 Mar 2015 14:46:08 -0500 Received: from fely.am-1.org ([78.47.74.50]:58440) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUKfk-0007Nw-So for submit@debbugs.gnu.org; Sat, 07 Mar 2015 14:46:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=BzgNs7PLs79HPYr1wuHBwh9k99XkDbUYEaFDQlHhqd8=; b=b7d2IJZv22vDkgIF0qtMdlCLH1oVkVI9tBhI5Oit5R7mtUby6JzNfBFyCRBD/NlL+zx6l8bPsfy3yrZMdsWXjgDWBHQ/0Uwgqx5RyrPl9g2hlNNPQYSwSP2x2HK7PPPClS4F9/mbvQ4pNq13IhYrvJ7A86mmcB1qhEJRPSOruKM=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YUKfi-00005E-6c for submit@debbugs.gnu.org; Sat, 07 Mar 2015 19:46:02 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YUKfa-0004XI-Ti for submit@debbugs.gnu.org; Sun, 08 Mar 2015 02:45:54 +0700 From: Ivan Shmakov To: submit@debbugs.gnu.org Subject: eww: access bookmarks right from the URI prompt Date: Sat, 07 Mar 2015 19:45:53 +0000 Message-ID: <87fv9gzj4e.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs Severity: wishlist Tags: patch Please consider the tentative patch MIMEd. * lisp/net/eww.el (eww-suggest-uris): Add eww-suggest-bookmarks to the default value and :options. (Bug#???) (eww-suggest-bookmarks, eww-remove-annotation): New functions. (eww-suggested-uris, eww): Use eww-remove-annotation. Somehow, I believe that eww-remove-annotation may be generalized into something worthy of subr.el. On a related note, can we please make eww-bookmarks a defcustom and thus replace eww-write-bookmarks, eww-read-bookmarks with customize-save-variable and the regular custom-set-variables mechanism, respectively? --=20 FSF associate member #7257 np. Begin Again =E2=80=94 Jami Sieber 3013 B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -64,7 +64,8 @@ defcustom eww-download-directory "~/Downloads/" (defcustom eww-suggest-uris '(eww-links-at-point url-get-url-at-point - eww-current-url) + eww-current-url + eww-suggest-bookmarks) "List of functions called to form the list of default URIs for `eww'. Each of the elements is a function returning either a string or a list of strings. The results will be joined into a single list with @@ -74,7 +75,8 @@ defcustom eww-suggest-uris :type 'hook :options '(eww-links-at-point url-get-url-at-point - eww-current-url)) + eww-current-url + eww-suggest-bookmarks)) (defcustom eww-bookmarks-directory user-emacs-directory "Directory where bookmark files will be stored." @@ -234,11 +243,30 @@ defun eww-suggested-uris nil (dolist (fun eww-suggest-uris) (let ((ret (funcall fun))) (dolist (uri (if (stringp ret) (list ret) ret)) - (when (and uri (not (intern-soft uri obseen))) - (intern uri obseen) - (push uri uris))))) + (let ((key (and uri (eww-remove-annotation uri)))) + (when (and key (not (intern-soft key obseen))) + (intern key obseen) + (push uri uris)))))) (nreverse uris))) +(defun eww-remove-annotation (string &optional start) + (unless start + (setq start 0)) + (let ((init (get-text-property start 'annotation string)) + (chan (next-single-property-change start 'annotation string))) + (if (not chan) + (if init nil ; The whole string is an annotation. + string) + (let ((acc nil) + (from (if init chan start))) + (while from + (let ((to (next-single-property-change from 'annotation string))) + (setq acc (concat acc (substring string from to)) + from (and to + (next-single-property-change + to 'annotation string))))) + acc)))) + ;;;###autoload (defun eww (url) "Fetch URL and render the page. @@ -249,7 +277,8 @@ defun eww (url) (prompt (concat "Enter URL or keywords" (if uris (format " (default %s)" (car uris)) "") ": "))) - (list (read-string prompt nil nil uris)))) + (when-let ((uri (read-string prompt nil nil uris))) + (list (eww-remove-annotation uri))))) (setq url (string-trim url)) (cond ((string-match-p "\\`file:/" url)) ;; Don't mangle file: URLs at all. @@ -549,6 +564,22 @@ defun eww-links-at-point () (list (get-text-property (point) 'shr-url) (get-text-property (point) 'image-url)))) +(defun eww-suggest-bookmarks () + "Return list of bookmarked URIs, if any. +The URIs returned may contain arbitrary annotations. Apply +`eww-remove-annotation' on elements of the list returned to obtain the +URIs proper." + (mapcar (lambda (elt) + (let ((uri (plist-get elt :url)) + (title (plist-get elt :title))) + (when uri + (concat uri + (propertize " " + 'display (concat " (" title ")") + 'annotation t + 'face 'minibuffer-prompt))))) + eww-bookmarks)) + (defun eww-view-source () "View the HTML source code of the current page." (interactive) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 08 06:26:09 2015 Received: (at 20032) by debbugs.gnu.org; 8 Mar 2015 10:26:09 +0000 Received: from localhost ([127.0.0.1]:39163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUYPQ-0003vj-Nm for submit@debbugs.gnu.org; Sun, 08 Mar 2015 06:26:09 -0400 Received: from fely.am-1.org ([78.47.74.50]:58535) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUYPN-0003vV-4k for 20032@debbugs.gnu.org; Sun, 08 Mar 2015 06:26:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=owcmVHL2vgUrs2SetfkWINLxFadIq04I0C0kHyJFQHU=; b=MaqsEMBTrCu7NjQGyPJ3SzbwWSydyxTnF9FUtp6earVFy8sl1wVIogpVOHuxbDi+PvZtsaizzH7s/6YixfWyIWPjjrzrVDq0JobDa7dJP1sradNJ8ourL8BwanbE7MKPATa66Uyr7dX/FiNeK8WZXSUCRhiNz0bgGAQAmkziy/g=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YUYPK-0006df-I1 for 20032@debbugs.gnu.org; Sun, 08 Mar 2015 10:26:02 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YUYP8-0006Ii-Uk for 20032@debbugs.gnu.org; Sun, 08 Mar 2015 17:25:51 +0700 From: Ivan Shmakov To: 20032@debbugs.gnu.org Subject: Re: bug#20032: eww: access bookmarks right from the URI prompt References: <87fv9gzj4e.fsf@violet.siamics.net> Date: Sun, 08 Mar 2015 10:25:49 +0000 In-Reply-To: <87fv9gzj4e.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sat, 07 Mar 2015 19:45:53 +0000") Message-ID: <878uf7zsya.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 20032 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> Ivan Shmakov writes: [=E2=80=A6] That variant didn=E2=80=99t work quite well in practice. The primary issue was that using 'display meant it wasn=E2=80=99t possible to search /annotations/ (using C-s, C-r, etc.) =E2=80=93 only the URIs proper, which isn=E2=80=99t as nice as it could be. One another is that once we replace the use of 'display with appending the actual annotation to the value, with a non-nil 'field property (for navigation purposes), move-end-of-line starts to misbehave in certain cases, apparently due to the fact that =E2=80=98line-move=E2=80=99 returns t after moving point to another /= field/ (as opposed to /line/.) I haven=E2=80=99t identified the cause as of yet, but placing the title /before/ URI seems to make this problem harder to actually stumble upon. Now given that there may be different preferences anyway, I=E2=80=99ve decided to introduce a new customizable variable for this one. (I=E2=80=99ve cleaned the new code up somewhat as well.) Please consider the revised patch MIMEd. * lisp/net/eww.el (eww-suggest-uris): Add eww-suggest-bookmarks to the default value and :options. (Bug#20032) (eww-suggested-bookmarks-annotation): New customizable variable. (eww-suggest-bookmarks, eww-remove-annotation) (eww-substring-nil-property): New functions. (eww-suggested-uris, eww): Use eww-remove-annotation. > Somehow, I believe that eww-remove-annotation may be generalized > into something worthy of subr.el. (Or subr-x.el; or some other library.) Generalized in the current revision of the patch as eww-substring-nil-property. --=20 FSF associate member #7257 np. In the Garden =E2=80=94 David Modica =E2=80= =A6 B6A0 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -64,7 +64,8 @@ (defcustom eww-suggest-uris '(eww-links-at-point url-get-url-at-point - eww-current-url) + eww-current-url + eww-suggest-bookmarks) "List of functions called to form the list of default URIs for `eww'. Each of the elements is a function returning either a string or a list of strings. The results will be joined into a single list with @@ -74,7 +75,21 @@ defcustom eww-suggest-uris :type 'hook :options '(eww-links-at-point url-get-url-at-point - eww-current-url)) + eww-current-url + eww-suggest-bookmarks)) + +(defcustom eww-suggested-bookmarks-annotation 'before + "Where to place annotation in the list of bookmarks at the URI prompt. +This variable controls where the bookmark annotation (title) is placed. + +If 'before, annotation goes before URI. +If 'after, annotation goes after URI. +If nil, no annotation is provided." + :version "25.1" + :group 'eww + :type '(choice (const :tag "Annotation before URI" before) + (const :tag "Annotation after URI" after) + (const :tag "No annotation" nil))) (defcustom eww-bookmarks-directory user-emacs-directory "Directory where bookmark files will be stored." @@ -234,9 +256,10 @@ defun eww-suggested-uris nil (dolist (fun eww-suggest-uris) (let ((ret (funcall fun))) (dolist (uri (if (stringp ret) (list ret) ret)) - (when (and uri (not (intern-soft uri obseen))) - (intern uri obseen) - (push uri uris))))) + (let ((key (and uri (eww-remove-annotation uri)))) + (when (and key (not (intern-soft key obseen))) + (intern key obseen) + (push uri uris)))))) (nreverse uris))) ;;;###autoload @@ -249,7 +272,9 @@ defun eww (url) (prompt (concat "Enter URL or keywords" (if uris (format " (default %s)" (car uris)) "") ": "))) - (list (read-string prompt nil nil uris)))) + (let ((minibuffer-allow-text-properties t)) + (list (eww-remove-annotation + (read-string prompt nil nil uris)))))) (setq url (string-trim url)) (cond ((string-match-p "\\`file:/" url)) ;; Don't mangle file: URLs at all. @@ -549,6 +560,67 @@ (list (get-text-property (point) 'shr-url) (get-text-property (point) 'image-url)))) +(defun eww-suggested-bookmarks () + "Return list of bookmarked URIs, if any. +The URIs returned may contain arbitrary annotations. Apply +`eww-remove-annotation' on elements of the list returned to obtain the +URIs proper." + (let* ((afterp (eq 'after eww-suggested-bookmarks-annotation)) + (prop (and eww-suggested-bookmarks-annotation + (nconc (if afterp nil + (list 'front-sticky t + 'rear-nonsticky t)) + '(field eww-title + annotation t + ; read-only t + face minibuffer-prompt)))) + (fmt (and prop + (apply #'propertize + (if afterp " (%s)" "(%s) ") + prop)))) + (mapcar (lambda (elt) + (let ((uri (plist-get elt :url)) + (title (plist-get elt :title))) + (when uri + (cond ((not fmt) uri) + (afterp (concat uri (format fmt title))) + (t (concat (format fmt title) uri)))))) + eww-bookmarks))) + +(defun eww-remove-annotation (string &optional start limit) + (eww-substring-nil-property 'annotation string start limit)) + +(defun eww-substring-nil-property (property &optional object start limit) + "Return the contents of OBJECT where PROPERTY is not set or nil. +Return nil if all the contents of OBJECT has PROPERTY set and non-nil. + +OBJECT is either a string, buffer, or nil (which means the +current buffer). + +If START is nil, use 0 for a string, or point for a buffer OBJECT. +If LIMIT is nil, use string length for a string or (point-max) for a +buffer." + (save-current-buffer + (cond ((stringp object)) + (object + (set-buffer object) + (setq object nil))) + ;; From now on, object is either a string or nil. + (unless start + (setq start (if object 0 (point)))) + (unless (or object limit) + (setq limit (point-max))) + (let ((acc nil) + (from start)) + (while from + (let ((to (next-single-property-change from property object))) + (unless (get-text-property from property object) + (setq acc (concat acc + (if object + (substring object from to) + (buffer-substring from (or to limit)))))) + (setq from to))) + acc))) (defun eww-view-source () "View the HTML source code of the current page." (interactive) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 25 01:25:33 2015 Received: (at 20032) by debbugs.gnu.org; 25 Dec 2015 06:25:33 +0000 Received: from localhost ([127.0.0.1]:34122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCLoj-0002e2-7R for submit@debbugs.gnu.org; Fri, 25 Dec 2015 01:25:33 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:41331) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCLoh-0002dt-7Y for 20032@debbugs.gnu.org; Fri, 25 Dec 2015 01:25:32 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aCLoJ-0002Qc-KR; Fri, 25 Dec 2015 07:25:07 +0100 From: Lars Ingebrigtsen To: Ivan Shmakov Subject: Re: bug#20032: eww: access bookmarks right from the URI prompt References: <87fv9gzj4e.fsf@violet.siamics.net> Date: Fri, 25 Dec 2015 07:25:01 +0100 In-Reply-To: <87fv9gzj4e.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sat, 07 Mar 2015 19:45:53 +0000") Message-ID: <87fuyrdozm.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aCLoJ-0002Qc-KR X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451629507.99019@rLPhViUfq3/qwKkI5a8u3w X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20032 Cc: 20032@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ivan Shmakov writes: > On a related note, can we please make eww-bookmarks a defcustom > and thus replace eww-write-bookmarks, eww-read-bookmarks with > customize-save-variable and the regular custom-set-variables > mechanism, respectively? No, I think it makes more sense to keep the bookmarks separate, since there may be many of them. They would just be noise in .emacs. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 25 01:35:39 2015 Received: (at 20032) by debbugs.gnu.org; 25 Dec 2015 06:35:39 +0000 Received: from localhost ([127.0.0.1]:34132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCLyV-0002xA-Jd for submit@debbugs.gnu.org; Fri, 25 Dec 2015 01:35:39 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:40606) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCLyU-0002x2-4F for 20032@debbugs.gnu.org; Fri, 25 Dec 2015 01:35:38 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aCLy8-0002Xb-Q3; Fri, 25 Dec 2015 07:35:16 +0100 From: Lars Ingebrigtsen To: Ivan Shmakov Subject: Re: bug#20032: eww: access bookmarks right from the URI prompt References: <87fv9gzj4e.fsf@violet.siamics.net> <878uf7zsya.fsf@violet.siamics.net> Date: Fri, 25 Dec 2015 07:35:16 +0100 In-Reply-To: <878uf7zsya.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sun, 08 Mar 2015 10:25:49 +0000") Message-ID: <878u4jdoij.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aCLy8-0002Xb-Q3 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451630117.41171@//eZ7AWuIul3oEh9PNXuZA X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20032 Cc: 20032@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ivan Shmakov writes: > Please consider the revised patch MIMEd. > > * lisp/net/eww.el (eww-suggest-uris): Add eww-suggest-bookmarks > to the default value and :options. (Bug#20032) > (eww-suggested-bookmarks-annotation): New customizable variable. > (eww-suggest-bookmarks, eww-remove-annotation) > (eww-substring-nil-property): New functions. > (eww-suggested-uris, eww): Use eww-remove-annotation. I get a compilation warning after applying the patch... (The defvar for eww-bookmarks should be moved.) But conceptually I'm not sure this is a good idea. If you have a bookmarks file, then if you say `M-x eww', you will apparently default to the first entry in the bookmarks file? That doesn't seem very helpful. It would be OK to have that as the first entry in the `M-n' history, but not as the default. If I read the code correctly. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 26 03:58:01 2015 Received: (at 20032) by debbugs.gnu.org; 26 Dec 2015 08:58:01 +0000 Received: from localhost ([127.0.0.1]:36732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCkfm-0000rA-24 for submit@debbugs.gnu.org; Sat, 26 Dec 2015 03:58:01 -0500 Received: from fely.am-1.org ([78.47.74.50]:60314) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCkfh-0000qx-5H for 20032@debbugs.gnu.org; Sat, 26 Dec 2015 03:57:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=vCLHYam6S88zBfNKm7+s6e/SNtKwB7frif84huzxxyc=; b=YG5Bjjv47IyEU2VnS8xgK84fR0xDqDK1959ylw/51tTKrmCFOl4dw7Srri0BkJmZ4Ej9EAaASCMEJGsM/T8Q8LpzMDQrKcOvh05TImXmF86jD+jSnjWK8Sb6D3/6VR6jfa0gIkYsElOjl2ZrRJIh/myx+QwM3Sl5ztpTupXbJas=; Received: from violet.siamics.net ([2001:470:1f13:1eb::1:1d]) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1aCkfd-0000PI-PB for 20032@debbugs.gnu.org; Sat, 26 Dec 2015 08:57:49 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1aCkfW-0000Ve-SX for 20032@debbugs.gnu.org; Sat, 26 Dec 2015 15:57:42 +0700 From: Ivan Shmakov To: 20032@debbugs.gnu.org Subject: Re: bug#20032: eww: access bookmarks right from the URI prompt References: <87fv9gzj4e.fsf@violet.siamics.net> <878uf7zsya.fsf@violet.siamics.net> <878u4jdoij.fsf@gnus.org> Date: Sat, 26 Dec 2015 08:57:41 +0000 In-Reply-To: <878u4jdoij.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 25 Dec 2015 07:35:16 +0100") Message-ID: <87oaddziwq.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 20032 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Lars Ingebrigtsen writes: >>>>> Ivan Shmakov writes: >> Please consider the revised patch MIMEd. >> * lisp/net/eww.el (eww-suggest-uris): Add eww-suggest-bookmarks to >> the default value and :options. (Bug#20032) >> (eww-suggested-bookmarks-annotation): New customizable variable. >> (eww-suggest-bookmarks, eww-remove-annotation) >> (eww-substring-nil-property): New functions. >> (eww-suggested-uris, eww): Use eww-remove-annotation. > I get a compilation warning after applying the patch... (The defvar > for eww-bookmarks should be moved.) Yes. > But conceptually I'm not sure this is a good idea. If you have a > bookmarks file, then if you say `M-x eww', you will apparently > default to the first entry in the bookmarks file? Indeed; unless the point is on a URI, where you=E2=80=99d get that URI as the default. Speaking of the bookmarks file, eww-suggested-bookmarks is missing a eww-read-bookmarks call in that patch. > That doesn't seem very helpful. Actually, it is: I=E2=80=99ve set the eww-bookmarks variable so that the resources I visit the most often are at the top of the list, and now I can access them with just a few M-ns, or, for the topmost, just RET. > It would be OK to have that as the first entry in the `M-n' history, > but not as the default. If I read the code correctly. I guess that could be fixed by using a modified version of read-string and flagging the values returned by eww-suggest-bookmarks in such a way as to never be considered as the default by that function. I doubt that that=E2=80=99s worth the effort, however. (Unless such a function already exists.) What bothers me more is that the sheer corpus of contemporary software will generally filter the list of bookmarks per the search terms typed in by the user first, and only then present the result for their respective equivalents of M-n. Which gets handy if your bookmarks (or history, or pretty much anything of that kind) number in the hundreds (or more.) I know of no similar facility in the current Emacs, however. --=20 FSF associate member #7257 http://am-1.org/~ivan/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 26 04:42:54 2015 Received: (at 20032) by debbugs.gnu.org; 26 Dec 2015 09:42:54 +0000 Received: from localhost ([127.0.0.1]:36760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aClND-0001v9-7o for submit@debbugs.gnu.org; Sat, 26 Dec 2015 04:42:54 -0500 Received: from fely.am-1.org ([78.47.74.50]:60330) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aClN8-0001ux-Pd for 20032@debbugs.gnu.org; Sat, 26 Dec 2015 04:42:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=ZAP4NKAVwpg+nyVOdjk3mek/DmgFRh+UL0FgDJCqjeg=; b=o7vZKLn6fOQ3RR8DsXJvdtDZh8pBMw+Rz0MseazFNMHjndct4EmNAVdhzy3+06L1lQckl7557UMipPndC0Mad/uAVFPO8hWN/VeIRaOkYcKkTp4LnJ8H6oFt/tESK5VsJivZgy3W3w4J1LMMD2CdsQc1xr8E4QhFZ3OUFsQrluU=; Received: from violet.siamics.net ([2001:470:1f13:1eb::1:1d]) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1aClN8-0000ly-4E for 20032@debbugs.gnu.org; Sat, 26 Dec 2015 09:42:46 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1aClN1-0000dQ-Cg for 20032@debbugs.gnu.org; Sat, 26 Dec 2015 16:42:39 +0700 From: Ivan Shmakov To: 20032@debbugs.gnu.org Subject: Re: bug#20032: eww: access bookmarks right from the URI prompt References: <87fv9gzj4e.fsf@violet.siamics.net> <87fuyrdozm.fsf@gnus.org> Date: Sat, 26 Dec 2015 09:42:38 +0000 In-Reply-To: <87fuyrdozm.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 25 Dec 2015 07:25:01 +0100") Message-ID: <87fuypzgtt.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 20032 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Lars Ingebrigtsen writes: >>>>> Ivan Shmakov writes: >> On a related note, can we please make eww-bookmarks a defcustom and >> thus replace eww-write-bookmarks, eww-read-bookmarks with >> customize-save-variable and the regular custom-set-variables >> mechanism, respectively? > No, I think it makes more sense to keep the bookmarks separate, since > there may be many of them. They would just be noise in .emacs. The customizations are saved to custom-file, which is not necessarily ~/.emacs. Alternatively, we may decide to use 'bookmark for the URI bookmarks as well. I have no idea what the benefits (apart from getting rid of potential code duplication) it may bring, if any. But personally, I=E2=80=99ve ended up just using a plain setq in my ~/.emacs, with neither Customize nor EWW native bookmark support getting in the way. (One may want to redefine both eww-read-bookmarks and eww-write-bookmarks to no-op when going this way, BTW.) --=20 FSF associate member #7257 http://am-1.org/~ivan/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 26 08:05:32 2015 Received: (at 20032) by debbugs.gnu.org; 26 Dec 2015 13:05:32 +0000 Received: from localhost ([127.0.0.1]:36978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCoXM-00057l-C0 for submit@debbugs.gnu.org; Sat, 26 Dec 2015 08:05:32 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:52317) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCoXL-00057e-8n for 20032@debbugs.gnu.org; Sat, 26 Dec 2015 08:05:31 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aCoWy-0007Ep-23; Sat, 26 Dec 2015 14:05:08 +0100 From: Lars Ingebrigtsen To: Ivan Shmakov Subject: Re: bug#20032: eww: access bookmarks right from the URI prompt References: <87fv9gzj4e.fsf@violet.siamics.net> <878uf7zsya.fsf@violet.siamics.net> <878u4jdoij.fsf@gnus.org> <87oaddziwq.fsf@violet.siamics.net> Date: Sat, 26 Dec 2015 14:05:07 +0100 In-Reply-To: <87oaddziwq.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sat, 26 Dec 2015 08:57:41 +0000") Message-ID: <8760zl5pj0.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-MailScanner-ID: 1aCoWy-0007Ep-23 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451739908.38634@E3WCg/IyOY57KU/0Gl+a0g X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20032 Cc: 20032@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ivan Shmakov writes: >> It would be OK to have that as the first entry in the `M-n' history, >> but not as the default. If I read the code correctly. > > I guess that could be fixed by using a modified version of > read-string and flagging the values returned by > eww-suggest-bookmarks in such a way as to never be considered as > the default by that function. I doubt that that=92s worth the > effort, however. (Unless such a function already exists.) `read-string' with nil initial-input and default-value will have no defaults. > What bothers me more is that the sheer corpus of contemporary > software will generally filter the list of bookmarks per the > search terms typed in by the user first, and only then present > the result for their respective equivalents of M-n. Which gets > handy if your bookmarks (or history, or pretty much anything of > that kind) number in the hundreds (or more.) I know of no > similar facility in the current Emacs, however. Yeah, just sticking the bookmarks in the history isn't very useful. Message uses ecomplete to do "electric" completion. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 26 11:48:54 2015 Received: (at 20032) by debbugs.gnu.org; 26 Dec 2015 16:48:55 +0000 Received: from localhost ([127.0.0.1]:41856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCs1W-0000Zm-2R for submit@debbugs.gnu.org; Sat, 26 Dec 2015 11:48:54 -0500 Received: from fely.am-1.org ([78.47.74.50]:60385) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCs1Q-0000ZW-Gk for 20032@debbugs.gnu.org; Sat, 26 Dec 2015 11:48:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=JUl+dJTJPFDPpJmxbIkkV/kULCpjiYtPeZ3vovgfaJQ=; b=HdTOm81iBTtbNbeN/GYB3LX8Z7efQF8eEwBQ+5eAeW0fF+N/0x8KutboFoyJQzg2tbZTosJnnYUUwM3LmznKTotVA+tLvpZ6D7HUfxQpOGuPXui5b9t796YxTxinw5DKAcbLAqgb8pPZeutxMWxAhWj/otyeqog69J0X77qWHdI=; Received: from violet.siamics.net ([2001:470:1f13:1eb::1:1d]) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1aCs1O-0004I6-03 for 20032@debbugs.gnu.org; Sat, 26 Dec 2015 16:48:46 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1aCs1E-0001Te-9v for 20032@debbugs.gnu.org; Sat, 26 Dec 2015 23:48:36 +0700 From: Ivan Shmakov To: 20032@debbugs.gnu.org Subject: Re: bug#20032: eww: access bookmarks right from the URI prompt References: <87fv9gzj4e.fsf@violet.siamics.net> <878uf7zsya.fsf@violet.siamics.net> <878u4jdoij.fsf@gnus.org> <87oaddziwq.fsf@violet.siamics.net> <8760zl5pj0.fsf@gnus.org> Date: Sat, 26 Dec 2015 16:48:35 +0000 In-Reply-To: <8760zl5pj0.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 26 Dec 2015 14:05:07 +0100") Message-ID: <87oaddxijg.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 20032 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Lars Ingebrigtsen writes: >>>>> Ivan Shmakov writes: >>> It would be OK to have that as the first entry in the `M-n' >>> history, but not as the default. If I read the code correctly. >> I guess that could be fixed by using a modified version of >> read-string and flagging the values returned by >> eww-suggest-bookmarks in such a way as to never be considered as the >> default by that function. I doubt that that=E2=80=99s worth the effort, >> however. (Unless such a function already exists.) > `read-string' with nil initial-input and default-value will have no > defaults. So? I don=E2=80=99t see how this is supposed to help in this case. >> What bothers me more is that the sheer corpus of contemporary >> software will generally filter the list of bookmarks per the search >> terms typed in by the user first, and only then present the result >> for their respective equivalents of M-n. Which gets handy if your >> bookmarks (or history, or pretty much anything of that kind) number >> in the hundreds (or more.) I know of no similar facility in the >> current Emacs, however. > Yeah, just sticking the bookmarks in the history isn't very useful. Having used this feature ever since I=E2=80=99ve got it implemented, I tend to disagree. > Message uses ecomplete to do "electric" completion. AIUI, it currently allows for only a single completion table, and I doubt that it will make much sense to have that table shared among Message and EWW (and perhaps other possible users.) --=20 FSF associate member #7257 http://am-1.org/~ivan/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 26 12:01:05 2015 Received: (at 20032) by debbugs.gnu.org; 26 Dec 2015 17:01:05 +0000 Received: from localhost ([127.0.0.1]:41909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCsDJ-0001zx-4t for submit@debbugs.gnu.org; Sat, 26 Dec 2015 12:01:05 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:34180) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCsDH-0001xu-Pv for 20032@debbugs.gnu.org; Sat, 26 Dec 2015 12:01:04 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aCsCu-0002OP-HK; Sat, 26 Dec 2015 18:00:40 +0100 From: Lars Ingebrigtsen To: Ivan Shmakov Subject: Re: bug#20032: eww: access bookmarks right from the URI prompt References: <87fv9gzj4e.fsf@violet.siamics.net> <878uf7zsya.fsf@violet.siamics.net> <878u4jdoij.fsf@gnus.org> <87oaddziwq.fsf@violet.siamics.net> <8760zl5pj0.fsf@gnus.org> <87oaddxijg.fsf@violet.siamics.net> Date: Sat, 26 Dec 2015 18:00:39 +0100 In-Reply-To: <87oaddxijg.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sat, 26 Dec 2015 16:48:35 +0000") Message-ID: <877fk1m9fs.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aCsCu-0002OP-HK X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451754040.88296@horNrsAJQHT79HjNaIuH0Q X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20032 Cc: 20032@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ivan Shmakov writes: > AIUI, it currently allows for only a single completion table, > and I doubt that it will make much sense to have that table > shared among Message and EWW (and perhaps other possible users.) That can be fixed rather trivially. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 23:34:13 2016 Received: (at 20032) by debbugs.gnu.org; 2 Feb 2016 04:34:13 +0000 Received: from localhost ([127.0.0.1]:55546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQSfK-0002Qe-0U for submit@debbugs.gnu.org; Mon, 01 Feb 2016 23:34:13 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:49756) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQSfE-0002QS-Ff for 20032@debbugs.gnu.org; Mon, 01 Feb 2016 23:34:08 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aQSek-0002Aa-Ff; Tue, 02 Feb 2016 05:33:35 +0100 From: Lars Ingebrigtsen To: Ivan Shmakov Subject: Re: bug#20032: eww: access bookmarks right from the URI prompt References: <87fv9gzj4e.fsf@violet.siamics.net> <878uf7zsya.fsf@violet.siamics.net> <878u4jdoij.fsf@gnus.org> <87oaddziwq.fsf@violet.siamics.net> <8760zl5pj0.fsf@gnus.org> <87oaddxijg.fsf@violet.siamics.net> <877fk1m9fs.fsf@gnus.org> Date: Tue, 02 Feb 2016 05:33:30 +0100 In-Reply-To: <877fk1m9fs.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 26 Dec 2015 18:00:39 +0100") Message-ID: <878u333f51.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aQSek-0002Aa-Ff X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1454992415.4723@wZjV7NOB0Hhs0VWO41OFRQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20032 Cc: 20032@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Lars Ingebrigtsen writes: > Ivan Shmakov writes: > >> AIUI, it currently allows for only a single completion table, >> and I doubt that it will make much sense to have that table >> shared among Message and EWW (and perhaps other possible users.) > > That can be fixed rather trivially. If you want to implement bookmark completion with ecomplete, I think that would be a nice idea. Using the "normal" completion just doesn't fit how I think users want to be presented with partial match completion of these long items. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 24 17:44:55 2017 Received: (at 20032) by debbugs.gnu.org; 24 Jan 2017 22:44:55 +0000 Received: from localhost ([127.0.0.1]:41003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cW9pe-00036E-6U for submit@debbugs.gnu.org; Tue, 24 Jan 2017 17:44:55 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:51394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cW9pZ-00035z-68 for 20032@debbugs.gnu.org; Tue, 24 Jan 2017 17:44:52 -0500 Received: from 2.150.49.21.tmi.telenormobil.no ([2.150.49.21] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cW9pR-0005rj-Og; Tue, 24 Jan 2017 23:44:47 +0100 From: Lars Ingebrigtsen To: Ivan Shmakov Subject: Re: bug#20032: eww: access bookmarks right from the URI prompt References: <87fv9gzj4e.fsf@violet.siamics.net> <878uf7zsya.fsf@violet.siamics.net> <878u4jdoij.fsf@gnus.org> <87oaddziwq.fsf@violet.siamics.net> <8760zl5pj0.fsf@gnus.org> <87oaddxijg.fsf@violet.siamics.net> <877fk1m9fs.fsf@gnus.org> <878u333f51.fsf@gnus.org> Date: Tue, 24 Jan 2017 23:44:35 +0100 In-Reply-To: <878u333f51.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 02 Feb 2016 05:33:30 +0100") Message-ID: <87fuk8dqng.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20032 Cc: 20032@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Lars Ingebrigtsen writes: > Lars Ingebrigtsen writes: > >> Ivan Shmakov writes: >> >>> AIUI, it currently allows for only a single completion table, >>> and I doubt that it will make much sense to have that table >>> shared among Message and EWW (and perhaps other possible users.) >> >> That can be fixed rather trivially. > > If you want to implement bookmark completion with ecomplete, I think > that would be a nice idea. Using the "normal" completion just doesn't > fit how I think users want to be presented with partial match completion > of these long items. I still agree with myself that completing normally over the bookmarks would be confusing, so I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 24 17:44:59 2017 Received: (at control) by debbugs.gnu.org; 24 Jan 2017 22:44:59 +0000 Received: from localhost ([127.0.0.1]:41006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cW9pj-00036W-GI for submit@debbugs.gnu.org; Tue, 24 Jan 2017 17:44:59 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:51401) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cW9pi-00036O-1o for control@debbugs.gnu.org; Tue, 24 Jan 2017 17:44:58 -0500 Received: from 2.150.49.21.tmi.telenormobil.no ([2.150.49.21] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cW9pf-0006ix-QH for control@debbugs.gnu.org; Tue, 24 Jan 2017 23:44:57 +0100 Date: Tue, 24 Jan 2017 23:44:49 +0100 Message-Id: <87efzsdqn2.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #20032 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 20032 wontfix close 20032 From unknown Tue Jun 24 17:22:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 22 Feb 2017 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator