From unknown Wed Jun 25 05:40:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20030: plstore caches invalid passphrases Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Mar 2015 14:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20030 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 20030@debbugs.gnu.org X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.142573774129592 (code B ref -1); Sat, 07 Mar 2015 14:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Mar 2015 14:15:41 +0000 Received: from localhost ([127.0.0.1]:38248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUFW1-0007hE-2n for submit@debbugs.gnu.org; Sat, 07 Mar 2015 09:15:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43485) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUFVz-0007h1-Gs for submit@debbugs.gnu.org; Sat, 07 Mar 2015 09:15:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUFVt-0006rQ-Bf for submit@debbugs.gnu.org; Sat, 07 Mar 2015 09:15:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUFVs-0006rM-Vu for submit@debbugs.gnu.org; Sat, 07 Mar 2015 09:15:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUFVs-00021t-0r for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2015 09:15:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUFVm-0006qq-Kl for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2015 09:15:31 -0500 Received: from mail.hostpark.net ([212.243.197.30]:53794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUFVm-0006qX-EP for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2015 09:15:26 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 92E3417979 for ; Sat, 7 Mar 2015 15:15:23 +0100 (CET) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id yj88avsrzNf3 for ; Sat, 7 Mar 2015 15:15:23 +0100 (CET) Received: from lem (80-218-80-138.dclient.hispeed.ch [80.218.80.138]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 66BE11786E for ; Sat, 7 Mar 2015 15:15:23 +0100 (CET) From: Jonas Bernoulli Date: Sat, 07 Mar 2015 15:11:36 +0100 Message-ID: <87ioecdhif.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) When using symmetric encryption and `plstore-cache-passphrase-for-symmetric-encryption' is non-nil, `plstore-passphrase-callback-function' stores the passphrase entered by the user in `plstore-passphrase-alist'. This happens *before* the passphrase is used to decrypt, and if it turns out that it was wrong, then it is *not* removed from the cache. So if caching is turned on and the user enters the wrong passphrase, subsequent attempts to decrypt the same information will always fail, because the cached but invalid passphrase is used. The user has to manually remove the invalid entry from `plstore-passphrase-alist' to get a second chance at entering the passphrase correctly. From unknown Wed Jun 25 05:40:01 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jonas Bernoulli Subject: bug#20030: closed (Re: bug#20030: plstore caches invalid passphrases) Message-ID: References: <87ioecdhif.fsf@bernoul.li> X-Gnu-PR-Message: they-closed 20030 X-Gnu-PR-Package: emacs Reply-To: 20030@debbugs.gnu.org Date: Tue, 31 Mar 2015 01:18:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1427764682-6775-1" This is a multi-part message in MIME format... ------------=_1427764682-6775-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #20030: plstore caches invalid passphrases which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 20030@debbugs.gnu.org. --=20 20030: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D20030 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1427764682-6775-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 20030-done) by debbugs.gnu.org; 31 Mar 2015 01:17:58 +0000 Received: from localhost ([127.0.0.1]:40759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YckoY-0001l2-2H for submit@debbugs.gnu.org; Mon, 30 Mar 2015 21:17:58 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:57447 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YckoV-0001ks-CH for 20030-done@debbugs.gnu.org; Mon, 30 Mar 2015 21:17:56 -0400 Received: from du-a.org ([2001:e41:db5e:fb14::1]:36819 helo=localhost.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1YckoU-0003Mj-2L; Mon, 30 Mar 2015 21:17:54 -0400 Message-ID: From: Daiki Ueno To: Jonas Bernoulli Subject: Re: bug#20030: plstore caches invalid passphrases References: <87ioecdhif.fsf@bernoul.li> Date: Tue, 31 Mar 2015 10:17:49 +0900 In-Reply-To: <87ioecdhif.fsf@bernoul.li> (Jonas Bernoulli's message of "Sat, 07 Mar 2015 15:11:36 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 20030-done Cc: 20030-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Jonas Bernoulli writes: > When using symmetric encryption and > `plstore-cache-passphrase-for-symmetric-encryption' is non-nil, > `plstore-passphrase-callback-function' stores the passphrase entered > by the user in `plstore-passphrase-alist'. This happens *before* the > passphrase is used to decrypt, and if it turns out that it was wrong, > then it is *not* removed from the cache. Thanks, good catch. I've installed a fix: http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2e4b0c98 ------------=_1427764682-6775-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Mar 2015 14:15:41 +0000 Received: from localhost ([127.0.0.1]:38248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUFW1-0007hE-2n for submit@debbugs.gnu.org; Sat, 07 Mar 2015 09:15:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43485) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUFVz-0007h1-Gs for submit@debbugs.gnu.org; Sat, 07 Mar 2015 09:15:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUFVt-0006rQ-Bf for submit@debbugs.gnu.org; Sat, 07 Mar 2015 09:15:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUFVs-0006rM-Vu for submit@debbugs.gnu.org; Sat, 07 Mar 2015 09:15:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUFVs-00021t-0r for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2015 09:15:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUFVm-0006qq-Kl for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2015 09:15:31 -0500 Received: from mail.hostpark.net ([212.243.197.30]:53794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUFVm-0006qX-EP for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2015 09:15:26 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 92E3417979 for ; Sat, 7 Mar 2015 15:15:23 +0100 (CET) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id yj88avsrzNf3 for ; Sat, 7 Mar 2015 15:15:23 +0100 (CET) Received: from lem (80-218-80-138.dclient.hispeed.ch [80.218.80.138]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 66BE11786E for ; Sat, 7 Mar 2015 15:15:23 +0100 (CET) From: Jonas Bernoulli To: Subject: plstore caches invalid passphrases Date: Sat, 07 Mar 2015 15:11:36 +0100 Message-ID: <87ioecdhif.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) When using symmetric encryption and `plstore-cache-passphrase-for-symmetric-encryption' is non-nil, `plstore-passphrase-callback-function' stores the passphrase entered by the user in `plstore-passphrase-alist'. This happens *before* the passphrase is used to decrypt, and if it turns out that it was wrong, then it is *not* removed from the cache. So if caching is turned on and the user enters the wrong passphrase, subsequent attempts to decrypt the same information will always fail, because the cached but invalid passphrase is used. The user has to manually remove the invalid entry from `plstore-passphrase-alist' to get a second chance at entering the passphrase correctly. ------------=_1427764682-6775-1--