GNU bug report logs - #20029
'yes' surprisingly slow

Previous Next

Full log

Message #23 received at 20029 <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Pádraig Brady <P <at> draigbrady.com>,
 Ole Tange <tange <at> gnu.org>, 20029 <at> debbugs.gnu.org
Subject: Re: bug#20029: 'yes' surprisingly slow
Date: Mon, 09 Mar 2015 17:09:29 -0600

[Message part 1 (text/plain, inline)]

On 03/09/2015 04:14 PM, Pádraig Brady wrote:

>>> +
>>> +for size in 1 4095 4096 8191 8192 16383 16384; do
>>
>> Should you also test 4097 8193 and 16385 (that is, a likely
>> 1-more-than-BUFSIZ in the mix)?
> 
> The 1 more is implicit with the \n added by yes(1).

Then you should also test 4094 8190 and 16382, to make sure that a
multiple of a non-aligned subset with a small unused tail also works
(although I guess the 4097 tests the case of an unused tail if BUFSIZ is
8192, although in that case the unused tail is much larger than a few
bytes).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.