From unknown Sat Aug 09 13:08:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#19972 <19972@debbugs.gnu.org> To: bug#19972 <19972@debbugs.gnu.org> Subject: Status: 24.4; Font size change doesn't update (window-total-width) Reply-To: bug#19972 <19972@debbugs.gnu.org> Date: Sat, 09 Aug 2025 20:08:45 +0000 retitle 19972 24.4; Font size change doesn't update (window-total-width) reassign 19972 emacs submitter 19972 Joost Kremers severity 19972 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 28 21:31:33 2015 Received: (at submit) by debbugs.gnu.org; 1 Mar 2015 02:31:33 +0000 Received: from localhost ([127.0.0.1]:32786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRtfH-0002D2-Qj for submit@debbugs.gnu.org; Sat, 28 Feb 2015 21:31:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:32991) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRtfA-0002Bw-OH for submit@debbugs.gnu.org; Sat, 28 Feb 2015 21:31:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRtf3-0004sz-Su for submit@debbugs.gnu.org; Sat, 28 Feb 2015 21:31:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRtf3-0004sv-Ps for submit@debbugs.gnu.org; Sat, 28 Feb 2015 21:31:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRtf2-0007Kk-66 for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 21:31:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRtey-0004se-38 for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 21:31:16 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:58000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRtex-0004pd-Ti for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 21:31:11 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 8E6AC2095F for ; Sat, 28 Feb 2015 21:31:07 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Sat, 28 Feb 2015 21:31:08 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.fm; h= x-sasl-enc:from:to:subject:date:message-id:mime-version :content-type:content-transfer-encoding; s=mesmtp; bh=w6TMYDfGVb 2lnZCiN+IhkI0deXE=; b=VAMEcuxQd8zVzRa74gNV+tdnUCgnWIaIs5n4Y12Lk8 l9jM1Y8Ynrmn7Pt1XX1+HsVMCIBuzamW2+DY3kaHVghVXPmIrFnOlkSPC6amAVd6 eB1q2OGaYntHgKVk/B0jfHzarJLvL7lIPFc6DrHm87mG3j4IYU6cD13XifitOgXQ o= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:to:subject:date :message-id:mime-version:content-type:content-transfer-encoding; s=smtpout; bh=w6TMYDfGVb2lnZCiN+IhkI0deXE=; b=jx59O5/nSl9dLpgos 7ncsdygZi0KhE1MZIxcxJJpIfflIP8JFrS6rUtwPWp7VltjL5QFjvHAn55uIUOGl loMqGGy2nxMPB6T7jUMB2gxOn7ltazVuXSGsycL4zXZXUBPEdeotoQNYrnKeChpX 39FQsFJTNBXJbFGVLaMAQkQKD0= X-Sasl-enc: V6+6T/IaLx4MjHpvYxVqiQ+w9CG2Rd+RFDgTJ+x+657w 1425177067 Received: from IdeaPad.messagingengine.com (unknown [217.187.210.105]) by mail.messagingengine.com (Postfix) with ESMTPA id 8753F68011E for ; Sat, 28 Feb 2015 21:31:07 -0500 (EST) From: Joost Kremers To: bug-gnu-emacs@gnu.org Subject: 24.4; Font size change doesn't update (window-total-width) Date: Sun, 01 Mar 2015 03:31:05 +0100 Message-ID: <874mq5o3di.fsf@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) After changing the font size (with `custom-push-theme' and `face-spec-recalc'), the value returned by `window-total-width' is not updated. To reproduce, run `emacs -Q' and do: - (window-total-width) ; shows the initial value - (custom-push-theme 'theme-face 'default 'user 'set '((t (:height 128)))) ; use a :height value that's actually different from the default height. - (face-spec-recalc 'default (selected-frame)) - (window-total-width) ; still shows the initial value - C-x 3 ; split window horizontally - C-x 1 ; delete other window - (window-total-width) ; shows the new value The second call to `window-total-width' should already have returned the new value. The following IELM transcript (recorded directly after `emacs -Q') shows the problem: ELISP> (window-total-width) 240 (#o360, #xf0, ?ð) ELISP> (custom-push-theme 'theme-face 'default 'user 'set '((t (:height 128)))) ((theme-face default user ((t (:height 128))))) ELISP> (face-spec-recalc 'default (selected-frame)) nil ELISP> (window-total-width) 240 (#o360, #xf0, ?ð) ;; now press `C-x 3` followed by `C-x 1' ELISP> (window-total-width) 192 (#o300, #xc0, ?À) ELISP> The second call to `window-total-width` returns 240, but it should have returned 192. After splitting the window and deleting the other window again, the correct value is returned. Note that splitting the window vertically (`C-x 2`) does *not* fix the value returned by `window-total-width'. In GNU Emacs 24.4.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) of 2014-10-22 on IdeaPad Windowing system distributor `The X.Org Foundation', version 11.0.11501000 System Description: elementary OS Luna Important settings: value of $LC_MONETARY: en_IE.UTF-8 value of $LC_NUMERIC: en_IE.UTF-8 value of $LC_TIME: en_IE.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: IELM Minor modes in effect: tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: M-x i e l m ( w i n d o w - w t o t a l - w i d t h ) C-y M-b M-b M-d M-d 1 2 8 M-b M-b M-b M-b M-f C-f C-d ' C-e ( f a c e - s p e c - r e c SPC ' d e f a u l t SPC ' ( s e l e t c t e d - f r a m e ) ) C-x 3 C-x 1 C-SPC C-t C-f C-SPC C-a C-a a C-/ M-w M-x r e p o r t - e m a c - s - b u g Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Mark set Making completion list... Mark set transpose-subr-1: Text is read-only Mark activated Undo! Mark set End of buffer Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils help-mode mule-util ielm easymenu pp comint ansi-color ring time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind gfilenotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) Memory information: ((conses 16 76433 3869) (symbols 48 18021 0) (miscs 40 52 174) (strings 32 10420 4770) (string-bytes 1 294096) (vectors 16 9633) (vector-slots 8 392165 12847) (floats 8 66 361) (intervals 56 294 16) (buffers 960 13) (heap 1024 45822 783)) -- Joost Kremers Life has its moments From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 01 10:14:59 2015 Received: (at 19972) by debbugs.gnu.org; 1 Mar 2015 15:14:59 +0000 Received: from localhost ([127.0.0.1]:33424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YS5a6-00051m-Sk for submit@debbugs.gnu.org; Sun, 01 Mar 2015 10:14:59 -0500 Received: from mout.gmx.net ([212.227.15.18]:55930) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YS5a5-00051X-1Z for 19972@debbugs.gnu.org; Sun, 01 Mar 2015 10:14:57 -0500 Received: from [194.118.137.119] ([194.118.137.119]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MQzIE-1Y4SoR3NoE-00UGn0; Sun, 01 Mar 2015 16:14:50 +0100 Message-ID: <54F32CDE.9080308@gmx.at> Date: Sun, 01 Mar 2015 16:14:38 +0100 From: martin rudalics MIME-Version: 1.0 To: Joost Kremers , 19972@debbugs.gnu.org Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> In-Reply-To: <874mq5o3di.fsf@fastmail.fm> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:pGJ8zTaVUZX/iWaiB8Ei5lpGG454Jcw9IMeIO3XTBR2Rbw5jGwu 8doFxgAtWKSD9pXc9dZIRiaxnSNMsw0gER5nL4xGRTHD0xJxzUIIMx8UtGS7fba34D90fKM 3WzVU16WrJnlD+Co8lTwBKBfD74yQtvU7eu5Mk/u3e0trxKg+4U1RVyliNtZ75EIrHAvOu2 VbR9+W3k0HNfJHKJI8XLA== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > After changing the font size (with `custom-push-theme' and > `face-spec-recalc'), the value returned by `window-total-width' is not= > updated. > > To reproduce, run `emacs -Q' and do: > > - (window-total-width) ; shows the initial value > - (custom-push-theme 'theme-face 'default 'user 'set '((t (:height 128= )))) > ; use a :height value that's actually different from the default he= ight. > - (face-spec-recalc 'default (selected-frame)) > - (window-total-width) ; still shows the initial value > - C-x 3 ; split window horizontally > - C-x 1 ; delete other window > - (window-total-width) ; shows the new value > > The second call to `window-total-width' should already have returned t= he > new value. > > The following IELM transcript (recorded directly after `emacs -Q') sho= ws > the problem: > > ELISP> (window-total-width) > 240 (#o360, #xf0, ?=C3=B0) > ELISP> (custom-push-theme 'theme-face 'default 'user 'set '((t (:heigh= t 128)))) > ((theme-face default user > ((t > (:height 128))))) > > ELISP> (face-spec-recalc 'default (selected-frame)) > nil > ELISP> (window-total-width) > 240 (#o360, #xf0, ?=C3=B0) > > ;; now press `C-x 3` followed by `C-x 1' > > ELISP> (window-total-width) > 192 (#o300, #xc0, ?=C3=80) > ELISP> > > The second call to `window-total-width` returns 240, but it should hav= e > returned 192. I must admit that I don't have the faintest idea what `face-spec-recalc' is supposed to do. I don't understand its doc-string and don't know where further documentation about it can be found in the manuals. So I would be grateful if you or someone else provided me with the necessary information. Anyway. Why do you think that `window-total-width' should return 192 in the first call? In principle, face/font changes are supposed to keep the number of columns/lines unchanged so returning 240 seems reasonable to me. Unfortunately, the fact that ... > After splitting the window and deleting the other window > again, the correct value is returned. =2E.. seems to consitute a bug which, however, I haven't been able to reproduce here. One further puzzling aspect: Here, `face-spec-recalc' makes the frame so large that it goes off-screen and I can't see the modeline any more. And you seem to expect the window to shrink ... > Note that splitting the window vertically (`C-x 2`) does *not* fix the= > value returned by `window-total-width'. Hopefully not. Everything else would be strange. In any case, please evaluate (window--dump-frame) in IELM once immediately before you invoke `face-spec-recalc', once immediately after you invoked it, and once after you did C-x 1. You have to copy the results from a buffer called *window-frame-dump* (three times, because each dump overwrites the previous one). Please post the results here. > In GNU Emacs 24.4.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) > of 2014-10-22 on IdeaPad Could you try with current master/trunk? Lots of things changed in this area recently. martin From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 01 10:29:12 2015 Received: (at 19972) by debbugs.gnu.org; 1 Mar 2015 15:29:12 +0000 Received: from localhost ([127.0.0.1]:33432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YS5ns-0005NI-57 for submit@debbugs.gnu.org; Sun, 01 Mar 2015 10:29:12 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:41731) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YS5np-0005N1-2C for 19972@debbugs.gnu.org; Sun, 01 Mar 2015 10:29:10 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NKJ00K00HK9M400@a-mtaout22.012.net.il> for 19972@debbugs.gnu.org; Sun, 01 Mar 2015 17:29:02 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKJ00KN1HOEG640@a-mtaout22.012.net.il>; Sun, 01 Mar 2015 17:29:02 +0200 (IST) Date: Sun, 01 Mar 2015 17:28:49 +0200 From: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) In-reply-to: <54F32CDE.9080308@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <83pp8sspn2.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: joostkremers@fastmail.fm, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sun, 01 Mar 2015 16:14:38 +0100 > From: martin rudalics > > > ELISP> (face-spec-recalc 'default (selected-frame)) > > nil > > ELISP> (window-total-width) > > 240 (#o360, #xf0, ?ð) > > > > ;; now press `C-x 3` followed by `C-x 1' > > > > ELISP> (window-total-width) > > 192 (#o300, #xc0, ?À) > > ELISP> > > > > The second call to `window-total-width` returns 240, but it should have > > returned 192. > > I must admit that I don't have the faintest idea what `face-spec-recalc' > is supposed to do. For the purposes of this discussion, I think the only thing that matters is that it applies the change in the default face's font. > Anyway. Why do you think that `window-total-width' should return 192 in > the first call? In principle, face/font changes are supposed to keep > the number of columns/lines unchanged so returning 240 seems reasonable > to me. Indeed. It does for me. Could this be something specific to GTK or the window manager? Also, I don't understand why the initial value is 240 in the first place. By default, "emacs -Q" creates a 80-column window, so I'd expect window-total-width to return a value slightly larger than 80 (I get 84 here). So it sounds like some additional factors are at work here. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 01 10:54:47 2015 Received: (at 19972) by debbugs.gnu.org; 1 Mar 2015 15:54:47 +0000 Received: from localhost ([127.0.0.1]:33452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YS6Cd-00061H-4u for submit@debbugs.gnu.org; Sun, 01 Mar 2015 10:54:47 -0500 Received: from mout.gmx.net ([212.227.15.19]:61727) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YS6Ca-000612-Is for 19972@debbugs.gnu.org; Sun, 01 Mar 2015 10:54:45 -0500 Received: from [194.118.137.119] ([194.118.137.119]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MH0eg-1YEIPc1lpa-00DnDm; Sun, 01 Mar 2015 16:54:38 +0100 Message-ID: <54F33632.6090507@gmx.at> Date: Sun, 01 Mar 2015 16:54:26 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> In-Reply-To: <83pp8sspn2.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:8SFLM4eZzHvOnMBjRTaO+40aA+rLKQfTyXXrZEredzn5zxLIi7m Z3ONGW1HnSzb8vIpRTCtWaHc9m5ZW5R5XRqiniL/CQIRzmyTYIJjbDEuA13+05AzKGWQ6Pm T07DapTy0joK1cDUohMiMjz/7mWisIeGE26CyoaRReKdt0SHR5PrcjYDQGk01e4U1bxZ1yR 1Ap+GBKbF5O19G86xyMyA== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: joostkremers@fastmail.fm, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > For the purposes of this discussion, I think the only thing that > matters is that it applies the change in the default face's font. If `set-frame-font' were involved, then it has a `keep-size' argument which, when set, should keep the frame's pixel size constant. But I nowhere see `set-frame-font' getting called with that argument non-nil. >> Anyway. Why do you think that `window-total-width' should return 192 in >> the first call? In principle, face/font changes are supposed to keep >> the number of columns/lines unchanged so returning 240 seems reasonable >> to me. > > Indeed. It does for me. Could this be something specific to GTK or > the window manager? I tried with Gtk and the numbers of lines/columns remain unaltered. On Windows I lose one line because the tool bar gets larger by one pixel. > Also, I don't understand why the initial value is 240 in the first > place. By default, "emacs -Q" creates a 80-column window, so I'd > expect window-total-width to return a value slightly larger than 80 (I > get 84 here). > > So it sounds like some additional factors are at work here. Indeed. This issue needs clarification too. martin From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 01 12:06:16 2015 Received: (at 19972) by debbugs.gnu.org; 1 Mar 2015 17:06:16 +0000 Received: from localhost ([127.0.0.1]:33499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YS7Jo-0007lq-27 for submit@debbugs.gnu.org; Sun, 01 Mar 2015 12:06:16 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:52626) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YS7Jm-0007li-Mh for 19972@debbugs.gnu.org; Sun, 01 Mar 2015 12:06:15 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 39CDE20780 for <19972@debbugs.gnu.org>; Sun, 1 Mar 2015 12:06:13 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute2.internal (MEProxy); Sun, 01 Mar 2015 12:06:14 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.fm; h= x-sasl-enc:references:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; s=mesmtp; bh=yEoEzl3vsu9I kTU6VoYXwaUOycU=; b=OUs+WERcMqMwOmHu37E520AiEkeHafUcTGdb+phV/15J +z1n063L9yQKlXChdXgeKlYBPaR42QZwIEvoduY0jKNiLBqu1ek0JX1yY8C11oRh unUpoKnaFmt+McQglJiCnq42UBKC8/U5FBFyWcQ2tL8X5rUwPT0UBCDJedf63LU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-type; s= smtpout; bh=yEoEzl3vsu9IkTU6VoYXwaUOycU=; b=EzixgW0UV9r6g/OSaQcx r5i6FLojS8DbGz0pzZckm67gUhYjPEBt/Ambl/boayMmaotEz2kCD+enU7gWLceV wHktIlixLoJWyYvJ06lJHReWfSK1dQWnLYcWvtEfXnCw8lPeglL8blaOP3O1bf21 f3eZbhIN2unfrXW2gvlGm7A= X-Sasl-enc: UZS8mvaPFoQEAAHRMbCsXsFnPjMkN14+nWKawYFolE9d 1425229573 Received: from IdeaPad.messagingengine.com (unknown [95.119.111.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 759D06800BB; Sun, 1 Mar 2015 12:06:13 -0500 (EST) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> From: Joost Kremers To: martin rudalics Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) In-reply-to: <54F32CDE.9080308@gmx.at> Date: Sun, 01 Mar 2015 18:06:11 +0100 Message-ID: <871tl8odfg.fsf@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, Mar 01 2015, martin rudalics wrote: > > The second call to `window-total-width` returns 240, but it should have > > returned 192. > > I must admit that I don't have the faintest idea what `face-spec-recalc' > is supposed to do. I must admit, neither do I. The report results from an issue reported for a package of mine: https://github.com/joostkremers/visual-fill-column/issues/2 I took the calls to `custom-push-theme' and `face-spec-recalc' from the code of the `default-text-scale' package. > Anyway. Why do you think that `window-total-width' should return 192 in > the first call? In principle, face/font changes are supposed to keep > the number of columns/lines unchanged so returning 240 seems reasonable > to me. Well, the fact is that after the font size change, the number of characters that fit in the window changes as well. AFAIU the return value of `window-total-width' depends on that, at least in part. Unless I'm wrong in that assumption... > In any case, please evaluate (window--dump-frame) in IELM once > immediately before you invoke `face-spec-recalc', once immediately after > you invoked it, and once after you did C-x 1. You have to copy the > results from a buffer called *window-frame-dump* (three times, because > each dump overwrites the previous one). Please post the results here. > > > In GNU Emacs 24.4.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) > > of 2014-10-22 on IdeaPad > > Could you try with current master/trunk? Lots of things changed in this > area recently. I'll try with the latest Emacs and provide the output of window--dump-frame ASAP. -- Joost Kremers Life has its moments From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 01 12:07:39 2015 Received: (at 19972) by debbugs.gnu.org; 1 Mar 2015 17:07:39 +0000 Received: from localhost ([127.0.0.1]:33504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YS7L8-0007nz-Sm for submit@debbugs.gnu.org; Sun, 01 Mar 2015 12:07:39 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:40594) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YS7L6-0007nr-Df for 19972@debbugs.gnu.org; Sun, 01 Mar 2015 12:07:36 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 527462039B for <19972@debbugs.gnu.org>; Sun, 1 Mar 2015 12:07:35 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Sun, 01 Mar 2015 12:07:36 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.fm; h= x-sasl-enc:references:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; s=mesmtp; bh=VKi+soW2qwWw uCP9QEunPcwOnBI=; b=l1Uet3+yoMIYULee0IyVwpFqNO9cMYlHQjKbrokcmkKD yL0kjszsxGK1BC8QX5QbhfOzoc1fghGYxVfjWrBaXvpzJ69fAfq4L/wCsl9Jz9K6 j9lj+X+wUghsz1danSapN5TiawlaiZfcVhxd40d7GuqvSKiAGdLMYnCXumOav7E= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-type; s= smtpout; bh=VKi+soW2qwWwuCP9QEunPcwOnBI=; b=imF1rm2CwVk8R0K/NIh3 D1XF7csgaT+zCByKqRV2FwkImbLhTzEQAobNPGgn8X5tSq6kEm0KekdRPIp/b9jj 1em2lQtHK5/fD/1xHiI6tcqL9imQS3m1jIETRoRW3qKDqOMSDQDYUktVG4MGiIB2 6BslVH8UhArYT0bgkplaDkU= X-Sasl-enc: 6lqcPVoU8UGA4gP5TCJwavQGvAt95nQwU83QcVq1BFFx 1425229655 Received: from IdeaPad.messagingengine.com (unknown [95.119.111.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 7F53EC002A2; Sun, 1 Mar 2015 12:07:35 -0500 (EST) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> From: Joost Kremers To: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) In-reply-to: <83pp8sspn2.fsf@gnu.org> Date: Sun, 01 Mar 2015 18:07:33 +0100 Message-ID: <87zj7wmysq.fsf@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19972 Cc: martin rudalics , 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, Mar 01 2015, Eli Zaretskii wrote: > Also, I don't understand why the initial value is 240 in the first > place. By default, "emacs -Q" creates a 80-column window, so I'd > expect window-total-width to return a value slightly larger than 80 (I > get 84 here). > > So it sounds like some additional factors are at work here. Sorry, my mistake. I should have added that I maximised the frame first. -- Joost Kremers Life has its moments From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 01 12:47:13 2015 Received: (at 19972) by debbugs.gnu.org; 1 Mar 2015 17:47:13 +0000 Received: from localhost ([127.0.0.1]:33512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YS7xR-0000HU-6n for submit@debbugs.gnu.org; Sun, 01 Mar 2015 12:47:13 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:35728) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YS7xN-0000HE-KI for 19972@debbugs.gnu.org; Sun, 01 Mar 2015 12:47:11 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NKJ00L00NPAKG00@a-mtaout22.012.net.il> for 19972@debbugs.gnu.org; Sun, 01 Mar 2015 19:46:57 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKJ00L24O29LV00@a-mtaout22.012.net.il>; Sun, 01 Mar 2015 19:46:57 +0200 (IST) Date: Sun, 01 Mar 2015 19:46:45 +0200 From: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) In-reply-to: <87zj7wmysq.fsf@fastmail.fm> X-012-Sender: halo1@inter.net.il To: Joost Kremers Message-id: <83lhjgsj96.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: rudalics@gmx.at, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Joost Kremers > Cc: martin rudalics , 19972@debbugs.gnu.org > Date: Sun, 01 Mar 2015 18:07:33 +0100 > > On Sun, Mar 01 2015, Eli Zaretskii wrote: > > Also, I don't understand why the initial value is 240 in the first > > place. By default, "emacs -Q" creates a 80-column window, so I'd > > expect window-total-width to return a value slightly larger than 80 (I > > get 84 here). > > > > So it sounds like some additional factors are at work here. > > Sorry, my mistake. I should have added that I maximised the frame first. FWIW, I don't see a different value after evaluating the face-spec-recalc form, even if I start with a maximized frame. What I see is a frame whose part is invisible because it is beyond the screen edges. Which is what I'd expect. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 01 15:43:43 2015 Received: (at 19972) by debbugs.gnu.org; 1 Mar 2015 20:43:43 +0000 Received: from localhost ([127.0.0.1]:33563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSAiE-0004TV-RE for submit@debbugs.gnu.org; Sun, 01 Mar 2015 15:43:43 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:39565) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSAiC-0004TN-QW for 19972@debbugs.gnu.org; Sun, 01 Mar 2015 15:43:41 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id C6F5F2035D for <19972@debbugs.gnu.org>; Sun, 1 Mar 2015 15:43:37 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute2.internal (MEProxy); Sun, 01 Mar 2015 15:43:38 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.fm; h= x-sasl-enc:references:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; s=mesmtp; bh=3qgsU48PDw1Y hRYB8LjFLdNV2/A=; b=qF2ZV2Stv98SDVIFg3pJ/FFqgIWNZwkBpa9pxn//Uv+v UL9//ZhNwQ9oJxeF3l0jNx/wANzznVQIFcyvyNYUODwruvPvOHAfBHi64VuJrQS8 Jjih/oZjaah13WGmfW/IZ3LnCYE2NBEowNdrkR6xfu7Zd9HDUPMpKNME21mmEA8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-type; s= smtpout; bh=3qgsU48PDw1YhRYB8LjFLdNV2/A=; b=bQYkTvitNXv1gQwSjkkG Kub/xIRk40aMiFqeAYr8UfOf/goWWdrFJdl481vmj3QfkrbKrcE0tVlmb7bimoLA hNQ7El+RNpuwxZEHj+6Ue+HAftNf0bPWGEBSfTALeY+ltLwf7fco3uogq3kjtCCT GVqDxxs1+Z7G4g5l2l5JDO0= X-Sasl-enc: xJrpjIss1x3z1JdtaXqlf38hjtknFsnblyIhzxXECEfs 1425242618 Received: from IdeaPad.messagingengine.com (unknown [95.119.111.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 766E9680119; Sun, 1 Mar 2015 15:43:37 -0500 (EST) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> From: Joost Kremers To: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) In-reply-to: <83lhjgsj96.fsf@gnu.org> Date: Sun, 01 Mar 2015 21:43:35 +0100 Message-ID: <87y4ngmoso.fsf@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19972 Cc: rudalics@gmx.at, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, Mar 01 2015, Eli Zaretskii wrote: >> Sorry, my mistake. I should have added that I maximised the frame first. > > FWIW, I don't see a different value after evaluating the > face-spec-recalc form, even if I start with a maximized frame. What I > see is a frame whose part is invisible because it is beyond the screen > edges. Which is what I'd expect. On my system (Elementary OS, which is based on Ubuntu, but uses a different graphical environment), the frame doesn't change its size. Since the font size changes, there are fewer characters on a line, which, AFAIU, should be reflected in the value returned by `window-total-width'. -- Joost Kremers Life has its moments From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 01 22:18:30 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 03:18:30 +0000 Received: from localhost ([127.0.0.1]:33702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSGsI-0001Ac-3c for submit@debbugs.gnu.org; Sun, 01 Mar 2015 22:18:30 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:49180) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSGsE-0001AQ-Gt for 19972@debbugs.gnu.org; Sun, 01 Mar 2015 22:18:27 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 1BA2F20AE7 for <19972@debbugs.gnu.org>; Sun, 1 Mar 2015 22:18:25 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Sun, 01 Mar 2015 22:18:26 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.fm; h= x-sasl-enc:references:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; s=mesmtp; bh=BrizX7sVp3Zu SLo/1qV3Ew5SLiQ=; b=IzqgdmRbcUpVPm9yIDvWZBy3A3/Ip2DRj6+C7Gi5VOjK D7y8hkjQIa6Uoc31WP8xq/zaOQeFpTJaBNLSJN8DfKO8hSA2rETjV+Vj6qrI/Dfv nSOk6iXP3PHJh+OrtvJprknSeVRMBFkVtxYLCgCxp9fH9S5I6qEgsPXMSW2KHOs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-type; s= smtpout; bh=BrizX7sVp3ZuSLo/1qV3Ew5SLiQ=; b=jA0Xk88xh1R6+O+8Zv1I swmg3xAJvMRy8ENXay7tlxDv9HmEB1W3wK1xe+dWCx7wxaYtSSFKkWspZm8WGo4e DtmX757ucvQYEMfxd5B5e2UWvLhLrp4C+jrAGfuHK1PJ3HCYtb0/THCbvSAq3tzQ s/aHpWkRxojUQ9c4iMPkC+Q= X-Sasl-enc: Bjx3s9yQ/jb86EyH0shS7/dmGOJAeoYevONu84BceVCL 1425266305 Received: from IdeaPad.messagingengine.com (unknown [95.119.111.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 09F1AC0028C; Sun, 1 Mar 2015 22:18:24 -0500 (EST) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> From: Joost Kremers To: martin rudalics Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) In-reply-to: <54F32CDE.9080308@gmx.at> Date: Mon, 02 Mar 2015 04:18:23 +0100 Message-ID: <87egp8rssg.fsf@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, Mar 01 2015, martin rudalics wrote: > > In GNU Emacs 24.4.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) > > of 2014-10-22 on IdeaPad > > Could you try with current master/trunk? Lots of things changed in this > area recently. I cloned the git master branch and compiled Emacs (version says it's 25.0.50.1) and still see the same problem. After Eli's comments, it's now clear that the problem is slightly different than what I initially thought, though. The issue is not with font size changes in general, because the frame is usually adjusted to match. The problem arises when a font size change takes place *without* the frame changing its size accordingly. In this case, the number of columns on a frame is changed, but this is not reflected in the return value of `window-total-width`. This happened in my case because I ran the test on a maximised Emacs frame, which wasn't adjusted. (Though I don't know whether that's due to Emacs not resizing its frame or due to the window manager preventing it.) Here are the results from the calls to `window--dump-frame` (done on Emacs 25.0.50.1): ========== one ============================== right before `face-spec-recalc' frame pixel: 1920 x 971 cols/lines: 240 x 57 units: 8 x 17 frame text pixel: 1888 x 971 cols/lines: 236 x 57 tool: 0 scroll: 16/0 fringe: 16 border: 0 right: 0 bottom: 0 # parent: nil pixel left: 0 top: 0 size: 1920 x 954 new: 0 char left: 0 top: 0 size: 240 x 56 new: 0 normal: 1.0 x 1.0 new: 0 body pixel: 1888 x 937 char: 236 x 55 width left fringe: 8 left margin: 0 right margin: 0 width right fringe: 8 scroll-bar: 16 divider: 0 height header-line: 0 mode-line: 17 divider: 0 # parent: nil pixel left: 0 top: 954 size: 1920 x 17 new: 0 char left: 0 top: 56 size: 1920 x 1 new: 0 normal: 1.0 x 1.0 new: 0 body pixel: 1888 x 17 char: 236 x 1 width left fringe: 8 left margin: 0 right margin: 0 width right fringe: 8 scroll-bar: 16 divider: 0 height header-line: 0 mode-line: 0 divider: 0 ============================================= ========== two ============================== right after `face-spec-recalc` frame pixel: 1920 x 971 cols/lines: 192 x 46 units: 10 x 21 frame text pixel: 1888 x 971 cols/lines: 188 x 46 tool: 0 scroll: 16/0 fringe: 16 border: 0 right: 0 bottom: 0 # parent: nil pixel left: 0 top: 0 size: 1920 x 950 new: 950 char left: 0 top: 0 size: 240 x 45 new: 56 normal: 1.0 x 1.0 new: ignore body pixel: 1888 x 929 char: 188 x 44 width left fringe: 8 left margin: 0 right margin: 0 width right fringe: 8 scroll-bar: 16 divider: 0 height header-line: 0 mode-line: 21 divider: 0 # parent: nil pixel left: 0 top: 950 size: 1920 x 21 new: 0 char left: 0 top: 45 size: 1920 x 1 new: 0 normal: 1.0 x 1.0 new: 0 body pixel: 1888 x 21 char: 188 x 1 width left fringe: 8 left margin: 0 right margin: 0 width right fringe: 8 scroll-bar: 16 divider: 0 height header-line: 0 mode-line: 0 divider: 0 ============================================= ========== three ============================ after doing `C-x 3` + `C-x 1` frame pixel: 1920 x 971 cols/lines: 192 x 46 units: 10 x 21 frame text pixel: 1888 x 971 cols/lines: 188 x 46 tool: 0 scroll: 16/0 fringe: 16 border: 0 right: 0 bottom: 0 # parent: nil pixel left: 0 top: 0 size: 1920 x 950 new: 960 char left: 0 top: 0 size: 192 x 45 new: 96 normal: 1.0 x 1.0 new: 0.5 body pixel: 1888 x 929 char: 188 x 44 width left fringe: 8 left margin: 0 right margin: 0 width right fringe: 8 scroll-bar: 16 divider: 0 height header-line: 0 mode-line: 21 divider: 0 # parent: nil pixel left: 0 top: 950 size: 1920 x 21 new: 0 char left: 0 top: 45 size: 192 x 1 new: 192 normal: 1.0 x 1.0 new: 0 body pixel: 1888 x 21 char: 188 x 1 width left fringe: 8 left margin: 0 right margin: 0 width right fringe: 8 scroll-bar: 16 divider: 0 height header-line: 0 mode-line: 0 divider: 0 ============================================= -- Joost Kremers Life has its moments From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 01 22:30:37 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 03:30:37 +0000 Received: from localhost ([127.0.0.1]:33721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSH40-0001UR-JC for submit@debbugs.gnu.org; Sun, 01 Mar 2015 22:30:36 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:40022) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSH3x-0001U9-5j for 19972@debbugs.gnu.org; Sun, 01 Mar 2015 22:30:34 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NKK00M00DVJ4V00@a-mtaout21.012.net.il> for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 05:30:26 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKK00M94F2P6G00@a-mtaout21.012.net.il>; Mon, 02 Mar 2015 05:30:26 +0200 (IST) Date: Mon, 02 Mar 2015 05:30:15 +0200 From: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) In-reply-to: <87y4ngmoso.fsf@fastmail.fm> X-012-Sender: halo1@inter.net.il To: Joost Kremers Message-id: <83k2z0rs8o.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: rudalics@gmx.at, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Joost Kremers > Cc: rudalics@gmx.at, 19972@debbugs.gnu.org > Date: Sun, 01 Mar 2015 21:43:35 +0100 > > > FWIW, I don't see a different value after evaluating the > > face-spec-recalc form, even if I start with a maximized frame. What I > > see is a frame whose part is invisible because it is beyond the screen > > edges. Which is what I'd expect. > > On my system (Elementary OS, which is based on Ubuntu, but uses a > different graphical environment), the frame doesn't change its size. What is your window manager? > Since the font size changes, there are fewer characters on a line, > which, AFAIU, should be reflected in the value returned by > `window-total-width'. I think Emacs doesn't expect the frame size to remain unchanged in pixels. I asked about values returned by window-width in this scenario, can you provide them? From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 01 22:59:30 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 03:59:30 +0000 Received: from localhost ([127.0.0.1]:33730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSHVx-0002AH-GN for submit@debbugs.gnu.org; Sun, 01 Mar 2015 22:59:29 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36594) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSHVv-0002A9-Nl for 19972@debbugs.gnu.org; Sun, 01 Mar 2015 22:59:28 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 69DBA207DC for <19972@debbugs.gnu.org>; Sun, 1 Mar 2015 22:59:26 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute3.internal (MEProxy); Sun, 01 Mar 2015 22:59:27 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.fm; h= x-sasl-enc:references:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; s=mesmtp; bh=XgWAcy3d7Ptq yL+CMFCvSK9Qb0M=; b=jwv0OSZ5GOW/roX1qqJfSqNSS7u6aMFYy1Jd/kvo1xbP h+mqCR3Sm58nDko6lRYUL56bAyImmRS4r/ZpwaV0+HqjrRTrSA72iD5RxBG2fDRW 59iINRbmajpXe6RT8yvOxhe9lOoL8EiO6IvqFhucxq0JMLOeXZU4NVn+G6slVTA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-type; s= smtpout; bh=XgWAcy3d7PtqyL+CMFCvSK9Qb0M=; b=LBExN8UHB5URhhj5UKR3 F2HspPujM1R7toxfjseVgmbge7bE/bJbXxSpLwjsW9eCG2ud0eywgTrx83NhzStu Di9DIZwpFhj7xiE5/D/NHXoQPM2wdA1LE9vXjq0XYisf9aTWu/70BiFi/d9MtPfM jfePjP0rrjqD7REjNo3kVAU= X-Sasl-enc: wF6GTxO+UGT+9rKYacH5lDY1ioVIvWvMoQV7WpoAt1eA 1425268766 Received: from IdeaPad.messagingengine.com (unknown [95.119.111.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 7BE446801F3; Sun, 1 Mar 2015 22:59:26 -0500 (EST) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> <83k2z0rs8o.fsf@gnu.org> From: Joost Kremers To: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) In-reply-to: <83k2z0rs8o.fsf@gnu.org> Date: Mon, 02 Mar 2015 04:59:25 +0100 Message-ID: <87d24srqw2.fsf@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 19972 Cc: rudalics@gmx.at, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, Mar 02 2015, Eli Zaretskii wrote: >> From: Joost Kremers >> Cc: rudalics@gmx.at, 19972@debbugs.gnu.org >> Date: Sun, 01 Mar 2015 21:43:35 +0100 >> >> > FWIW, I don't see a different value after evaluating the >> > face-spec-recalc form, even if I start with a maximized frame. What I >> > see is a frame whose part is invisible because it is beyond the screen >> > edges. Which is what I'd expect. >> >> On my system (Elementary OS, which is based on Ubuntu, but uses a >> different graphical environment), the frame doesn't change its size. > > What is your window manager? Gala: https://code.launchpad.net/~gala-dev/gala/trunk >> Since the font size changes, there are fewer characters on a line, >> which, AFAIU, should be reflected in the value returned by >> `window-total-width'. > > I think Emacs doesn't expect the frame size to remain unchanged in > pixels. > > I asked about values returned by window-width in this scenario, can > you provide them? Sorry, forgot that. `window-width' doesn't have the same issue. On my system, with a maximised Emacs frame (Emacs version 25.0.50.1), it returns 236 before `custom-push-theme' + `face-spec-recalc', and 188 after it, even without doing `C-x 3' followed by `C-x 1'. -- Joost Kremers Life has its moments From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 02:57:37 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 07:57:37 +0000 Received: from localhost ([127.0.0.1]:33769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSLEP-0007s6-L8 for submit@debbugs.gnu.org; Mon, 02 Mar 2015 02:57:37 -0500 Received: from purcellpeople.com ([85.214.32.38]:57249 helo=h1189701.stratoserver.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSLEN-0007rk-Nr for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 02:57:36 -0500 Received: from [192.168.1.103] (host86-175-248-64.range86-175.btcentralplus.com [86.175.248.64]) by h1189701.stratoserver.net (Postfix) with ESMTPSA id 05A3D8201B9 for <19972@debbugs.gnu.org>; Mon, 2 Mar 2015 08:57:27 +0100 (CET) From: Steve Purcell Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: Font size change doesn't update (window-total-width) Message-Id: <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> Date: Mon, 2 Mar 2015 07:57:26 +0000 To: 19972@debbugs.gnu.org Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) X-Mailer: Apple Mail (2.2070.6) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19972 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) - Consider the case of full-screen frames, which never change in pixel = size. The window-width should change when the font size changes in this = case too. - set-frame-font is a built-in function with a KEEP-SIZE param which = tells it to try to preserve the pixel-size of the frame after the font = has changed: my code is copied from there. So there really shouldn=E2=80=99t be any assumption that the frame size = will necessarily change when the font changes. -Steve= From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 08:27:48 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 13:27:48 +0000 Received: from localhost ([127.0.0.1]:33907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSQNv-0001tI-Um for submit@debbugs.gnu.org; Mon, 02 Mar 2015 08:27:48 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:44068) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSQNq-0001sv-Sc for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 08:27:44 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NKL000006JJVJ00@a-mtaout21.012.net.il> for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 15:27:36 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKL0008M6PZVT00@a-mtaout21.012.net.il>; Mon, 02 Mar 2015 15:27:35 +0200 (IST) Date: Mon, 02 Mar 2015 15:27:25 +0200 From: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) In-reply-to: <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> X-012-Sender: halo1@inter.net.il To: Steve Purcell Message-id: <83bnkbsf5u.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Steve Purcell > Date: Mon, 2 Mar 2015 07:57:26 +0000 > > - Consider the case of full-screen frames, which never change in pixel size. They do for me. See the previous messages. > So there really shouldn’t be any assumption that the frame size will necessarily change when the font changes. In this case, Emacs itself changes the frame size, so it can expect it to change. I think there's some X event due to the window manager that then resizes the frame back, but we either don't react to it, or somehow interpret it incorrectly. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 09:05:22 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 14:05:22 +0000 Received: from localhost ([127.0.0.1]:33933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSQyH-0002mr-7F for submit@debbugs.gnu.org; Mon, 02 Mar 2015 09:05:22 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:60936) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSQyC-0002mY-RV for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 09:05:18 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NKL0070089NK900@a-mtaout22.012.net.il> for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 16:05:10 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKL007VV8GL50B0@a-mtaout22.012.net.il>; Mon, 02 Mar 2015 16:05:10 +0200 (IST) Date: Mon, 02 Mar 2015 16:04:59 +0200 From: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) In-reply-to: <87d24srqw2.fsf@fastmail.fm> X-012-Sender: halo1@inter.net.il To: Joost Kremers Message-id: <834mq3sdf8.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> <83k2z0rs8o.fsf@gnu.org> <87d24srqw2.fsf@fastmail.fm> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: rudalics@gmx.at, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Joost Kremers > Cc: rudalics@gmx.at, 19972@debbugs.gnu.org > Date: Mon, 02 Mar 2015 04:59:25 +0100 > > > I asked about values returned by window-width in this scenario, can > > you provide them? > > Sorry, forgot that. `window-width' doesn't have the same issue. On my > system, with a maximised Emacs frame (Emacs version 25.0.50.1), it > returns 236 before `custom-push-theme' + `face-spec-recalc', and 188 > after it, even without doing `C-x 3' followed by `C-x 1'. In that case, I guess if you call (window-total-width 'round), you will see the correct value even before "C-x 3", right? Also, what does frame-total-cols return during your recipe? Martin, I show below a backtrace that explains how face-spec-recalc causes the frame to be resized, I hope this will help you see what's going on. My guess is that immediately after resizing the frame, as shown below in the backtrace, we get some X event from the window manager telling us to size the frame back, but we either don't interpret that event correctly, or delay its handling. This second resize doesn't happen on my system, so I cannot show more information about it. Joost, could you find out where does w->pixel_size change in your recipe (where 'w' is the pointer to the window displaying *scratch*)? If my guess is correct, it should change twice: once as shown below in the backtrace I produced, and then once more, where it changes back to the dimensions of your display. We are interested to know where is that second time, and who calls that code. One way of finding this out is to put a watchpoint in GDB on w->pixel_size. Let me know if you need more detailed instructions for how to do it. Here's the backtrace from the code that resizes the frame as result of face-spec-recalc: 0x0109bc93 in resize_frame_windows (f=0x17d7a30 , size=833, horflag=true, pixelwise=true) at window.c:4192 4192 r->pixel_width = new_pixel_size; (gdb) bt #0 0x0109bc93 in resize_frame_windows (f=0x17d7a30 , size=833, horflag=true, pixelwise=true) at window.c:4192 #1 0x01011f3e in adjust_frame_size (f=0x17d7a30 , new_width=800, new_height=700, inhibit=5, pretend=false, parameter=8064) at frame.c:524 #2 0x0100f0cc in change_frame_size_1 (f=0x17d7a30 , new_width=800, new_height=700, pretend=false, delay=false, safe=false, pixelwise=true) at dispnew.c:5501 #3 0x0100f12a in change_frame_size (f=0x17d7a30 , new_width=800, new_height=700, pretend=false, delay=false, safe=false, pixelwise=true) at dispnew.c:5533 #4 0x0100eeb8 in do_pending_window_change (safe=false) at dispnew.c:5459 #5 0x0123f29d in x_set_window_size (f=0x17d7a30 , change_gravity=false, width=800, height=700, pixelwise=true) at w32term.c:6194 #6 0x01011e7e in adjust_frame_size (f=0x17d7a30 , new_width=800, new_height=700, inhibit=3, pretend=false, parameter=14464) at frame.c:490 #7 0x0123e411 in x_new_font (f=0x17d7a30 , font_object=98909453, fontset=23) at w32term.c:5858 #8 0x0101b3b4 in x_set_font (f=0x17d7a30 , arg=101384204, oldval=98121716) at frame.c:3611 #9 0x01019339 in x_set_frame_parameters (f=0x17d7a30 , alist=0) at frame.c:3140 #10 0x010186e3 in Fmodify_frame_parameters (frame=25000501, alist=8969667) at frame.c:2663 #11 0x010fab62 in set_font_frame_param (frame=25000501, lface=25182821) at xfaces.c:3321 #12 0x010fa43c in Finternal_set_lisp_face_attribute (face=10592, attr=1792, value=514, frame=25000501) at xfaces.c:3135 #13 0x011a23f2 in Ffuncall (nargs=5, args=0x88df24) at eval.c:2729 #14 0x011e5ffb in exec_byte_code (bytestr=19792668, vector=19792685, maxdepth=30, args_template=0, nargs=0, args=0x0) at bytecode.c:919 #15 0x011a306d in funcall_lambda (fun=19792629, nargs=4, arg_vector=0x12e032d ) at eval.c:2951 #16 0x011a25dd in Ffuncall (nargs=5, args=0x88e250) at eval.c:2767 #17 0x011a182c in Fapply (nargs=4, args=0x88e388) at eval.c:2337 #18 0x011a2235 in Ffuncall (nargs=5, args=0x88e384) at eval.c:2698 #19 0x011e5ffb in exec_byte_code (bytestr=19801932, vector=19801949, maxdepth=26, args_template=0, nargs=0, args=0x0) at bytecode.c:919 #20 0x011a306d in funcall_lambda (fun=19801893, nargs=3, arg_vector=0x12e275d ) at eval.c:2951 #21 0x011a25dd in Ffuncall (nargs=4, args=0x88e6b4) at eval.c:2767 #22 0x011e5ffb in exec_byte_code (bytestr=19801788, vector=19801805, maxdepth=22, args_template=0, nargs=0, args=0x0) at bytecode.c:919 #23 0x011a306d in funcall_lambda (fun=19801765, nargs=2, arg_vector=0x12e26cd ) at eval.c:2951 #24 0x011a2918 in apply_lambda (fun=19801765, args=98601339, count=13) at eval.c:2826 #25 0x011a1118 in eval_sub (form=98601363) at eval.c:2226 #26 0x011a069d in Feval (form=98601363, lexical=0) at eval.c:1996 #27 0x011a2376 in Ffuncall (nargs=3, args=0x88eb9c) at eval.c:2721 #28 0x011e5ffb in exec_byte_code (bytestr=20304908, vector=20304925, maxdepth=22, args_template=1030, nargs=1, args=0x88eed0) at bytecode.c:919 #29 0x011a2c42 in funcall_lambda (fun=20304885, nargs=1, arg_vector=0x88eecc) at eval.c:2885 #30 0x011a25dd in Ffuncall (nargs=2, args=0x88eec8) at eval.c:2767 #31 0x011e5ffb in exec_byte_code (bytestr=20305284, vector=20305301, maxdepth=18, args_template=1030, nargs=1, args=0x88f2dc) at bytecode.c:919 #32 0x011a2c42 in funcall_lambda (fun=20305253, nargs=1, arg_vector=0x88f2d8) at eval.c:2885 #33 0x011a25dd in Ffuncall (nargs=2, args=0x88f2d4) at eval.c:2767 #34 0x011990dc in Ffuncall_interactively (nargs=2, args=0x88f2d4) at callint.c:252 #35 0x011a2235 in Ffuncall (nargs=3, args=0x88f2d0) at eval.c:2698 #36 0x0119b2b5 in Fcall_interactively (function=-10501392, record_flag=0, keys=22605245) at callint.c:849 #37 0x011a23ae in Ffuncall (nargs=4, args=0x88f55c) at eval.c:2725 #38 0x011e5ffb in exec_byte_code (bytestr=19977892, vector=19977909, maxdepth=54, args_template=4102, nargs=1, args=0x88f8a0) at bytecode.c:919 #39 0x011a2c42 in funcall_lambda (fun=19977869, nargs=1, arg_vector=0x88f89c) at eval.c:2885 #40 0x011a25dd in Ffuncall (nargs=2, args=0x88f898) at eval.c:2767 #41 0x011a1e40 in call1 (fn=9184, arg1=-10501392) at eval.c:2573 #42 0x0110b3b3 in command_loop_1 () at keyboard.c:1521 #43 0x0119ee3b in internal_condition_case (bfun=0x110ab87 , handlers=12224, hfun=0x110a281 ) at eval.c:1348 #44 0x0110a7c2 in command_loop_2 (ignore=0) at keyboard.c:1139 #45 0x0119e376 in internal_catch (tag=31904, func=0x110a797 , arg=0) at eval.c:1108 #46 0x0110a761 in command_loop () at keyboard.c:1118 #47 0x01109de1 in recursive_edit_1 () at keyboard.c:728 #48 0x01109fd3 in Frecursive_edit () at keyboard.c:799 #49 0x01107f3d in main (argc=2, argv=0xca1f38) at emacs.c:1607 Lisp Backtrace: "internal-set-lisp-face-attribute" (0x88df28) "set-face-attribute" (0x88e254) "apply" (0x88e388) "face-spec-set-2" (0x88e6b8) "face-spec-recalc" (0x88e940) "eval" (0x88eba0) "elisp--eval-last-sexp" (0x88eecc) "eval-last-sexp" (0x88f2d8) "funcall-interactively" (0x88f2d4) "call-interactively" (0x88f560) "command-execute" (0x88f89c) From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 09:07:37 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 14:07:37 +0000 Received: from localhost ([127.0.0.1]:33944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSR0T-0002r7-3y for submit@debbugs.gnu.org; Mon, 02 Mar 2015 09:07:37 -0500 Received: from purcellpeople.com ([85.214.32.38]:60623 helo=h1189701.stratoserver.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSR0Q-0002qq-4p for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 09:07:35 -0500 Received: from [192.168.1.103] (host86-175-248-64.range86-175.btcentralplus.com [86.175.248.64]) by h1189701.stratoserver.net (Postfix) with ESMTPSA id BFAA282008E for <19972@debbugs.gnu.org>; Mon, 2 Mar 2015 15:07:27 +0100 (CET) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: bug#19972: Font size change doesn't update (window-total-width) From: Steve Purcell In-Reply-To: <83bnkbsf5u.fsf@gnu.org> Date: Mon, 2 Mar 2015 14:07:27 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: <8B7604B9-1637-4C35-B03D-BABE7D5271FA@sanityinc.com> References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> To: 19972@debbugs.gnu.org X-Mailer: Apple Mail (2.2070.6) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19972 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) >=20 > On 2 Mar 2015, at 13:27, Eli Zaretskii wrote: >=20 >> From: Steve Purcell >> Date: Mon, 2 Mar 2015 07:57:26 +0000 >>=20 >> - Consider the case of full-screen frames, which never change in = pixel size. >=20 > They do for me. See the previous messages. I=E2=80=99m on OS X, and NS Emacs uses the native full-screen support = there, so Emacs isn=E2=80=99t managing the pixel size directly. And indeed it=E2=80=99s only in that native full-screen mode that = window-size doesn=E2=80=99t get updated for me, so perhaps that=E2=80=99s = the only real problem here. Given that window-width returns a number based on both the current = frame/window size and the width of the =E2=80=98default face, then if = the value is going to be stored for later re-use, any change to the = default face should also cause it to be recomputed. What I=E2=80=99m picking up is that only frame/window size changes = currently cause that recomputation, hence this issue.= From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 09:09:53 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 14:09:53 +0000 Received: from localhost ([127.0.0.1]:33948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSR2e-0002ue-Lr for submit@debbugs.gnu.org; Mon, 02 Mar 2015 09:09:52 -0500 Received: from purcellpeople.com ([85.214.32.38]:60638 helo=h1189701.stratoserver.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSR2d-0002uS-6D for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 09:09:51 -0500 Received: from [192.168.1.103] (host86-175-248-64.range86-175.btcentralplus.com [86.175.248.64]) by h1189701.stratoserver.net (Postfix) with ESMTPSA id 8D5A082008E for <19972@debbugs.gnu.org>; Mon, 2 Mar 2015 15:09:45 +0100 (CET) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: bug#19972: Font size change doesn't update (window-total-width) From: Steve Purcell In-Reply-To: <8B7604B9-1637-4C35-B03D-BABE7D5271FA@sanityinc.com> Date: Mon, 2 Mar 2015 14:09:45 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: <13451CB2-185E-4238-A19E-37DA0BB359DD@sanityinc.com> References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <8B7604B9-1637-4C35-B03D-BABE7D5271FA@sanityinc.com> To: 19972@debbugs.gnu.org X-Mailer: Apple Mail (2.2070.6) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19972 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) I should also mention that toggling between fullscreen and normal (at = least on NS) is another operation which tangibly changes the window = width, but doesn=E2=80=99t seem to result in the result of = =E2=80=9C(window-width)=E2=80=9D changing.= From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 09:23:32 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 14:23:32 +0000 Received: from localhost ([127.0.0.1]:33986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSRFs-0003Gf-GS for submit@debbugs.gnu.org; Mon, 02 Mar 2015 09:23:32 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:45419) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSRFp-0003GQ-RV for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 09:23:30 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NKL00D00980O300@a-mtaout20.012.net.il> for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 16:23:23 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKL00DYB9AZLV30@a-mtaout20.012.net.il>; Mon, 02 Mar 2015 16:23:23 +0200 (IST) Date: Mon, 02 Mar 2015 16:23:13 +0200 From: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) In-reply-to: <8B7604B9-1637-4C35-B03D-BABE7D5271FA@sanityinc.com> X-012-Sender: halo1@inter.net.il To: Steve Purcell Message-id: <831tl7scku.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <8B7604B9-1637-4C35-B03D-BABE7D5271FA@sanityinc.com> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Steve Purcell > Date: Mon, 2 Mar 2015 14:07:27 +0000 > > Given that window-width returns a number based on both the current frame/window size and the width of the ‘default face, then if the value is going to be stored for later re-use, any change to the default face should also cause it to be recomputed. That's not how things work in Emacs. We recompute window metrics when we resize the window, and frame metrics when we resize the frame. Changing the default face's font triggers one such resize, and the values that are supposed to change are recomputed. > What I’m picking up is that only frame/window size changes currently cause that recomputation, hence this issue. Maybe you are right, but I'm not yet convinced, because I don't yet have a clear picture of what causes the frame to be resized back to the display size. The OP is on GNU/Linux, so native NS features cannot be the explanation there. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 09:24:23 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 14:24:23 +0000 Received: from localhost ([127.0.0.1]:33990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSRGg-0003IB-Tc for submit@debbugs.gnu.org; Mon, 02 Mar 2015 09:24:23 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:45575) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSRGe-0003Hu-C8 for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 09:24:20 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NKL00D00980O300@a-mtaout20.012.net.il> for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 16:24:14 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKL00D839CEOO00@a-mtaout20.012.net.il>; Mon, 02 Mar 2015 16:24:14 +0200 (IST) Date: Mon, 02 Mar 2015 16:24:04 +0200 From: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) In-reply-to: <13451CB2-185E-4238-A19E-37DA0BB359DD@sanityinc.com> X-012-Sender: halo1@inter.net.il To: Steve Purcell Message-id: <83zj7vqxyz.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <8B7604B9-1637-4C35-B03D-BABE7D5271FA@sanityinc.com> <13451CB2-185E-4238-A19E-37DA0BB359DD@sanityinc.com> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Steve Purcell > Date: Mon, 2 Mar 2015 14:09:45 +0000 > > I should also mention that toggling between fullscreen and normal (at least on NS) is another operation which tangibly changes the window width, but doesn’t seem to result in the result of “(window-width)” changing. It does here. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 09:45:07 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 14:45:08 +0000 Received: from localhost ([127.0.0.1]:33999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSRal-0003oN-8p for submit@debbugs.gnu.org; Mon, 02 Mar 2015 09:45:07 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:24165) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSRai-0003na-Fz for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 09:45:05 -0500 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t22EiwGR000732 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 2 Mar 2015 14:44:58 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t22EivOL003905 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 2 Mar 2015 14:44:57 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id t22Eiv0I010609; Mon, 2 Mar 2015 14:44:57 GMT MIME-Version: 1.0 Message-ID: <0e33901c-e4ae-4dbd-986f-1b4a594c356f@default> Date: Mon, 2 Mar 2015 06:44:57 -0800 (PST) From: Drew Adams To: Steve Purcell , 19972@debbugs.gnu.org Subject: RE: bug#19972: Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> In-Reply-To: <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19972 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > So there really shouldn=E2=80=99t be any assumption that the frame size > will necessarily change when the font changes. I disagree strongly. And several of my libraries depend on this longstanding feature. I have no objection, if you want to be able to do things differently, e.g., as a user option. But please do not consider removing this Emacs feature. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 10:02:16 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 15:02:16 +0000 Received: from localhost ([127.0.0.1]:34410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSRrM-0004J9-3v for submit@debbugs.gnu.org; Mon, 02 Mar 2015 10:02:16 -0500 Received: from purcellpeople.com ([85.214.32.38]:32867 helo=h1189701.stratoserver.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSRrJ-0004Is-4l for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 10:02:14 -0500 Received: from [192.168.1.103] (host86-175-248-64.range86-175.btcentralplus.com [86.175.248.64]) by h1189701.stratoserver.net (Postfix) with ESMTPSA id 6398B82008E for <19972@debbugs.gnu.org>; Mon, 2 Mar 2015 16:02:05 +0100 (CET) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: bug#19972: Font size change doesn't update (window-total-width) From: Steve Purcell X-Priority: 3 In-Reply-To: <0e33901c-e4ae-4dbd-986f-1b4a594c356f@default> Date: Mon, 2 Mar 2015 15:02:05 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: <9F35A5B7-25EA-4D80-9E1A-C496F3A29B0E@sanityinc.com> References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <0e33901c-e4ae-4dbd-986f-1b4a594c356f@default> To: 19972@debbugs.gnu.org X-Mailer: Apple Mail (2.2070.6) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19972 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) > On 2 Mar 2015, at 14:44, Drew Adams wrote: >=20 >> So there really shouldn=E2=80=99t be any assumption that the frame = size >> will necessarily change when the font changes. >=20 > I disagree strongly. And several of my libraries depend on this > longstanding feature. >=20 > I have no objection, if you want to be able to do things > differently, e.g., as a user option. But please do not consider > removing this Emacs feature. This concern is really tangential to the issue at hand: we would = presumably all like window-total-width to reliably return an up-to-date = value, and I doubt that any fix for that specific failure would affect = anyone's existing code. In any case, it=E2=80=99s already possible for the frame=E2=80=99s pixel = size to remain unchanged even when the font changes: that=E2=80=99s what = inevitably happens in the OS-managed fullscreen case described here.= From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 12:06:51 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 17:06:51 +0000 Received: from localhost ([127.0.0.1]:33002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSTnu-0002Do-HZ for submit@debbugs.gnu.org; Mon, 02 Mar 2015 12:06:50 -0500 Received: from mout.gmx.net ([212.227.15.15]:54684) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSTnr-0002DX-Kw for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 12:06:48 -0500 Received: from [188.23.120.185] ([188.23.120.185]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0LqiJO-1XpHMU0cra-00eIF2; Mon, 02 Mar 2015 18:06:36 +0100 Message-ID: <54F49898.3080905@gmx.at> Date: Mon, 02 Mar 2015 18:06:32 +0100 From: martin rudalics MIME-Version: 1.0 To: Joost Kremers , Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> In-Reply-To: <87zj7wmysq.fsf@fastmail.fm> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:KBDaCBCzq84q8wASAZgcg16HmIeLUXjxm+MR9Xxkd3+pPQWLUIo gups99PmYBKhiH4QR67Y1VScbjksdBmzPPcQFjhv4UXDz4lPKVby9PrATxGGDxhW5j2JbES y7SGtU7L+tcefh7GgVKw9HzUzPUFHYAxDw4BFwEgRRyJURw3d47BIilMdmfzcMdlpkEYMe/ n6C39pABytS5YHe6lVaww== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Sorry, my mistake. I should have added that I maximised the frame first. This alone would have explained lots of things. For Emacs 25 only, though ;-) martin From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 12:07:34 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 17:07:34 +0000 Received: from localhost ([127.0.0.1]:33006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSToc-0002FF-7X for submit@debbugs.gnu.org; Mon, 02 Mar 2015 12:07:34 -0500 Received: from mout.gmx.net ([212.227.15.18]:50232) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSToa-0002F3-9F for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 12:07:32 -0500 Received: from [188.23.120.185] ([188.23.120.185]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0LmKag-1XthE325AI-00Zuh4; Mon, 02 Mar 2015 18:07:21 +0100 Message-ID: <54F498C6.9090800@gmx.at> Date: Mon, 02 Mar 2015 18:07:18 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii , Joost Kremers Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> In-Reply-To: <83lhjgsj96.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:S5lfYIunezyKTQAF8h8N3oPsHqRUkhnghnYhGxk0bVzIHAVofGZ 8KTzylJtqTUGsbl0oVLqTbHMLytQwMEiM/Pe+IjBnFJJf44wvP68jRamIhXg6jlESyX51IC fQ1zYL3z4SVTXuc1uDrQa730GmynfVPjRsYoR2WSvSx1915UFJlU8wLOVUzZ37uBLbGRhOB I1MFztoZq6o09Q0yDDGzQ== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > FWIW, I don't see a different value after evaluating the > face-spec-recalc form, even if I start with a maximized frame. What I > see is a frame whose part is invisible because it is beyond the screen > edges. Which is what I'd expect. On Emacs 24.5, I presume. With Emacs 25 a maximized frame should not change its size any more. martin From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 12:08:21 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 17:08:22 +0000 Received: from localhost ([127.0.0.1]:33010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSTpN-0002Gb-JY for submit@debbugs.gnu.org; Mon, 02 Mar 2015 12:08:21 -0500 Received: from mout.gmx.net ([212.227.15.18]:55666) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSTpL-0002GN-AK for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 12:08:19 -0500 Received: from [188.23.120.185] ([188.23.120.185]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0Lw285-1XPns73exh-017i8Y; Mon, 02 Mar 2015 18:08:11 +0100 Message-ID: <54F498F8.9060100@gmx.at> Date: Mon, 02 Mar 2015 18:08:08 +0100 From: martin rudalics MIME-Version: 1.0 To: Joost Kremers , Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> In-Reply-To: <87y4ngmoso.fsf@fastmail.fm> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:9W8hirY384Xll5RjwySiC6wschRgUgQXbgW/3KhQeCWIT1v7ecR ULlBVTymN4zVKOsIWp79jY7pcuvBk2B6/SSB9XEhJmVGr3uzp+RkWlG4qT1kj3Y9SL6zSaP BAcTQRsNsSPey4Vx9zXFNYvDXNQQa0gC4Siw9Verqm3rB8RxzWmPyzYzFFQs32Nf5nakpRH bSyJCB74b2eWh5R4ShaRg== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > On my system (Elementary OS, which is based on Ubuntu, but uses a > different graphical environment), the frame doesn't change its size. Well, this was the missing link. > Since the font size changes, there are fewer characters on a line, > which, AFAIU, should be reflected in the value returned by > `window-total-width'. Correct. martin From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 12:09:00 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 17:09:00 +0000 Received: from localhost ([127.0.0.1]:33013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSTpz-0002Hd-WB for submit@debbugs.gnu.org; Mon, 02 Mar 2015 12:09:00 -0500 Received: from mout.gmx.net ([212.227.15.19]:60677) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSTpy-0002HM-3u for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 12:08:58 -0500 Received: from [188.23.120.185] ([188.23.120.185]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0Mg3Vt-1Y5iC50ZeP-00NVT4; Mon, 02 Mar 2015 18:08:48 +0100 Message-ID: <54F4991D.6080600@gmx.at> Date: Mon, 02 Mar 2015 18:08:45 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii , Joost Kremers Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> <83k2z0rs8o.fsf@gnu.org> <87d24srqw2.fsf@fastmail.fm> <834mq3sdf8.fsf@gnu.org> In-Reply-To: <834mq3sdf8.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:GT3e9RoHYI9WHrYDqQEMSBrUP5vHFzCpt/ByccE27JrFneF69p6 HQya5yLx4CZBv36wv+h0hxVKGMOYahIocCfNtScF/4cfEGKSLBMZZf3KqEYN2OncYtkFHJs DogHsL55cmNBj3TvRHWkOPFFamQtvKOG2+rb99I7f95b6f3KLhUIibJNkRcWDNen+xjMMSa 3wlZpENHVrQP2XlpxaubQ== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > In that case, I guess if you call (window-total-width 'round), you > will see the correct value even before "C-x 3", right? I guess so too. `window-total-width' is very special because it tries to support `windmove'. Suppose I have two adjacent side-by-side windows both 49.5 columns wide. Then `window-total-width' returns something like 49 columns for one and 50 for the other window because otherwise `windmove' would be broken. `window-left-column' behaves accordingly. Basically, for windows whose width is not an integral multiple of the default character width, `window-total-width' is not accurate. But it should obviously be "more" correct in Joost's case. > Martin, I show below a backtrace that explains how face-spec-recalc > causes the frame to be resized, I hope this will help you see what's > going on. > > My guess is that immediately after resizing the frame, as shown below > in the backtrace, we get some X event from the window manager telling > us to size the frame back, but we either don't interpret that event > correctly, or delay its handling. This second resize doesn't happen > on my system, so I cannot show more information about it. No. The problem is more trivial. Every request to resize a frame is eventually processed by adjust_frame_size. But if the latter decides that the width of the frame's root window does not change pixelwise, it does not call resize_frame_windows. And it's the latter who's responsible for updating the total widths and heights of windows (all for the sake of windmove only). > Here's the backtrace from the code that resizes the frame as result of > face-spec-recalc: > > 0x0109bc93 in resize_frame_windows (f=0x17d7a30 , > size=833, horflag=true, pixelwise=true) at window.c:4192 > 4192 r->pixel_width = new_pixel_size; > (gdb) bt > #0 0x0109bc93 in resize_frame_windows (f=0x17d7a30 , > size=833, horflag=true, pixelwise=true) at window.c:4192 Here you see resize_frame_windows getting called which will eventually call `window--pixel-to-total' to assign the new total sizes of windows. For Joost this call doesn't happen because new_windows_width equals old_windows_width. > #1 0x01011f3e in adjust_frame_size (f=0x17d7a30 , > new_width=800, new_height=700, inhibit=5, pretend=false, parameter=8064) > at frame.c:524 > #2 0x0100f0cc in change_frame_size_1 (f=0x17d7a30 , > new_width=800, new_height=700, pretend=false, delay=false, safe=false, > pixelwise=true) at dispnew.c:5501 > #3 0x0100f12a in change_frame_size (f=0x17d7a30 , > new_width=800, new_height=700, pretend=false, delay=false, safe=false, > pixelwise=true) at dispnew.c:5533 > #4 0x0100eeb8 in do_pending_window_change (safe=false) at dispnew.c:5459 > #5 0x0123f29d in x_set_window_size (f=0x17d7a30 , > change_gravity=false, width=800, height=700, pixelwise=true) > at w32term.c:6194 > #6 0x01011e7e in adjust_frame_size (f=0x17d7a30 , > new_width=800, new_height=700, inhibit=3, pretend=false, parameter=14464) > at frame.c:490 Note that x_new_font _always_ calls adjust_frame_size (even for the `set-frame-font' KEEP-SIZE non-nil case) trying to adjust the frame size. I sincerely hope your frame was not maximized here. Otherwise, resize_frame_windows should not have been called ... > #7 0x0123e411 in x_new_font (f=0x17d7a30 , > font_object=98909453, fontset=23) at w32term.c:5858 > #8 0x0101b3b4 in x_set_font (f=0x17d7a30 , > arg=101384204, oldval=98121716) at frame.c:3611 > #9 0x01019339 in x_set_frame_parameters (f=0x17d7a30 , > alist=0) at frame.c:3140 > #10 0x010186e3 in Fmodify_frame_parameters (frame=25000501, alist=8969667) > at frame.c:2663 > #11 0x010fab62 in set_font_frame_param (frame=25000501, lface=25182821) > at xfaces.c:3321 > #12 0x010fa43c in Finternal_set_lisp_face_attribute (face=10592, attr=1792, > value=514, frame=25000501) at xfaces.c:3135 martin From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 12:09:54 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 17:09:54 +0000 Received: from localhost ([127.0.0.1]:33018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSTqr-0002JV-RX for submit@debbugs.gnu.org; Mon, 02 Mar 2015 12:09:54 -0500 Received: from mout.gmx.net ([212.227.15.19]:56725) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSTqp-0002JH-Vc for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 12:09:52 -0500 Received: from [188.23.120.185] ([188.23.120.185]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0Mdr7l-1Y7u1a0UrF-00PeGl; Mon, 02 Mar 2015 18:09:43 +0100 Message-ID: <54F49954.6090502@gmx.at> Date: Mon, 02 Mar 2015 18:09:40 +0100 From: martin rudalics MIME-Version: 1.0 To: Joost Kremers Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <87egp8rssg.fsf@fastmail.fm> In-Reply-To: <87egp8rssg.fsf@fastmail.fm> Content-Type: multipart/mixed; boundary="------------040304050708080306050501" X-Provags-ID: V03:K0:Gb6LJ2/oRZ5JKrrr4dDCFVTu0ZKRekYrm/eZV2frTfngwJHnIKp fetG/bXDBxwASnxIUW2TexRDl/h7mjL1KbhjDJR4PCvPLk4BfeyI9eP5FYEU8PYojCOBsCh qG4pcYREDgd5g0yWBMJLQu/2rFOEVi9YKh+Jwu0xBb5hoNYMWpBF4mAO2xMMwhizBtQdns0 rVF0nXxT+cBWYjPJcN1XQ== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is a multi-part message in MIME format. --------------040304050708080306050501 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit > Here are the results from the calls to `window--dump-frame` (done on > Emacs 25.0.50.1): Thanks. Presumably with a maximized frame. > ========== one ============================== > right before `face-spec-recalc' > > frame pixel: 1920 x 971 cols/lines: 240 x 57 units: 8 x 17 > frame text pixel: 1888 x 971 cols/lines: 236 x 57 > tool: 0 scroll: 16/0 fringe: 16 border: 0 right: 0 bottom: 0 > > # parent: nil > pixel left: 0 top: 0 size: 1920 x 954 new: 0 > char left: 0 top: 0 size: 240 x 56 new: 0 240 is the "old" total width of your window. > normal: 1.0 x 1.0 new: 0 > body pixel: 1888 x 937 char: 236 x 55 > width left fringe: 8 left margin: 0 right margin: 0 > width right fringe: 8 scroll-bar: 16 divider: 0 > height header-line: 0 mode-line: 17 divider: 0 > > # parent: nil > pixel left: 0 top: 954 size: 1920 x 17 new: 0 > char left: 0 top: 56 size: 1920 x 1 new: 0 > normal: 1.0 x 1.0 new: 0 > body pixel: 1888 x 17 char: 236 x 1 > width left fringe: 8 left margin: 0 right margin: 0 > width right fringe: 8 scroll-bar: 16 divider: 0 > height header-line: 0 mode-line: 0 divider: 0 > > ============================================= > > ========== two ============================== > right after `face-spec-recalc` > > frame pixel: 1920 x 971 cols/lines: 192 x 46 units: 10 x 21 > frame text pixel: 1888 x 971 cols/lines: 188 x 46 Here we see the new default font set to 10 x 21, the various frame sizes remain unaltered as you observed. > tool: 0 scroll: 16/0 fringe: 16 border: 0 right: 0 bottom: 0 > > # parent: nil > pixel left: 0 top: 0 size: 1920 x 950 new: 950 > char left: 0 top: 0 size: 240 x 45 new: 56 The total width of your window remained unaltered at 240. Clearly the bug you observed. > normal: 1.0 x 1.0 new: ignore > body pixel: 1888 x 929 char: 188 x 44 > width left fringe: 8 left margin: 0 right margin: 0 > width right fringe: 8 scroll-bar: 16 divider: 0 > height header-line: 0 mode-line: 21 divider: 0 > > # parent: nil > pixel left: 0 top: 950 size: 1920 x 21 new: 0 > char left: 0 top: 45 size: 1920 x 1 new: 0 > normal: 1.0 x 1.0 new: 0 > body pixel: 1888 x 21 char: 188 x 1 > width left fringe: 8 left margin: 0 right margin: 0 > width right fringe: 8 scroll-bar: 16 divider: 0 > height header-line: 0 mode-line: 0 divider: 0 > > ============================================= > > ========== three ============================ > after doing `C-x 3` + `C-x 1` > > frame pixel: 1920 x 971 cols/lines: 192 x 46 units: 10 x 21 > frame text pixel: 1888 x 971 cols/lines: 188 x 46 > tool: 0 scroll: 16/0 fringe: 16 border: 0 right: 0 bottom: 0 > > # parent: nil > pixel left: 0 top: 0 size: 1920 x 950 new: 960 > char left: 0 top: 0 size: 192 x 45 new: 96 The total width got updated now to 192 as you observed. > normal: 1.0 x 1.0 new: 0.5 > body pixel: 1888 x 929 char: 188 x 44 > width left fringe: 8 left margin: 0 right margin: 0 > width right fringe: 8 scroll-bar: 16 divider: 0 > height header-line: 0 mode-line: 21 divider: 0 > > # parent: nil > pixel left: 0 top: 950 size: 1920 x 21 new: 0 > char left: 0 top: 45 size: 192 x 1 new: 192 > normal: 1.0 x 1.0 new: 0 > body pixel: 1888 x 21 char: 188 x 1 > width left fringe: 8 left margin: 0 right margin: 0 > width right fringe: 8 scroll-bar: 16 divider: 0 > height header-line: 0 mode-line: 0 divider: 0 > > ============================================= OK. The fix for Emacs 25 is attached. Please try it. I'm not yet sure whether to fix this for Emacs 24.5 as well. Basically, the fix "should" be harmless and resolve a problem not present in Emacs 24.3. However, wrong values for `window-total-width' or `window-left-column' should not really harm if they occur _only_ after setting the default font on a system whose window manager refuses to resize the Emacs frame as requested. Thanks, martin --------------040304050708080306050501 Content-Type: text/plain; charset=windows-1252; name="frame.c.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="frame.c.diff" diff --git a/src/frame.c b/src/frame.c index 4a526e2..bac2b24 100644 --- a/src/frame.c +++ b/src/frame.c @@ -537,6 +537,8 @@ adjust_frame_size (struct frame *f, int new_width, int new_height, int inhibit, } #endif } + else if (new_cols != old_cols) + call2 (Qwindow_pixel_to_total, frame, Qt); if (new_windows_height != old_windows_height /* When the top margin has changed we have to recalculate the top @@ -551,6 +553,8 @@ adjust_frame_size (struct frame *f, int new_width, int new_height, int inhibit, if ((FRAME_TERMCAP_P (f) && !pretend) || FRAME_MSDOS_P (f)) FrameRows (FRAME_TTY (f)) = new_lines + FRAME_TOP_MARGIN (f); } + else if (new_lines != old_lines) + call2 (Qwindow_pixel_to_total, frame, Qnil); frame_size_history_add (f, Qadjust_frame_size_3, new_text_width, new_text_height, @@ -4831,6 +4835,7 @@ syms_of_frame (void) DEFSYM (Qframep, "framep"); DEFSYM (Qframe_live_p, "frame-live-p"); DEFSYM (Qframe_windows_min_size, "frame-windows-min-size"); + DEFSYM (Qwindow_pixel_to_total, "window--pixel-to-total"); DEFSYM (Qexplicit_name, "explicit-name"); DEFSYM (Qheight, "height"); DEFSYM (Qicon, "icon"); --------------040304050708080306050501-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 12:10:46 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 17:10:46 +0000 Received: from localhost ([127.0.0.1]:33022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSTrh-0002L8-Nu for submit@debbugs.gnu.org; Mon, 02 Mar 2015 12:10:46 -0500 Received: from mout.gmx.net ([212.227.15.15]:63828) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSTrf-0002Ku-8G for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 12:10:43 -0500 Received: from [188.23.120.185] ([188.23.120.185]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MRWzQ-1Y4NRV2T8K-00Scc1; Mon, 02 Mar 2015 18:10:37 +0100 Message-ID: <54F4998B.40507@gmx.at> Date: Mon, 02 Mar 2015 18:10:35 +0100 From: martin rudalics MIME-Version: 1.0 To: Steve Purcell , 19972@debbugs.gnu.org Subject: Re: bug#19972: Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> In-Reply-To: <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:PT7zV6AQFtP7pL5TSqqlFzqqDawYQ8CoNMJKPF91DH/EcL03wkc oYsfkLGyEdIceArCkuwCfUDJcHXkVBYfrQoY0D0vycRPS1Oo6SJCzMG51zLWxKES1ovBtPt cC5imu6Kk1sXfbsvmx5a7h/RU4WPukmIu6+sbduepzcXnLLFTUK9gPKt8xCdhIfDKyQp8ta ersx8ue4wni5hLFVDY7gw== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > - Consider the case of full-screen frames, which never change in pixel= > size. The window-width should change when the font size changes in > this case too. This is the case (hopefully) with Emacs 25 but not with Emacs 24.5. Although some window managers may refuse to change the frame size even with Emacs 24.5 as we've learned here. > - set-frame-font is a built-in function with a KEEP-SIZE param which > tells it to try to preserve the pixel-size of the frame after the > font has changed: my code is copied from there. If you look at the implementation of this you will see that it first resizes the frame (via x_new_font) and then tries to size it back to the original size. This will fail miserably when the frame was maximized before (because maximization is a state and not just a specific size) and will fail when the frame size was not an integral multiple of its default character size (because `set-frame-font' does some strange rounding). So never ever use `set-frame-font' with KEEP-SIZE non-nil. With Emacs 25 you can do, for example, (let ((frame-inhibit-implied-resize t)) (custom-push-theme 'theme-face 'default 'user 'set '((t (:height 128))= )) (face-spec-recalc 'default (selected-frame))) unless you have set `frame-inhibit-implied-resize' to non-nil already. Which currently causes `window-total-width' to return a wrong value ;-) > So there really shouldn=E2=80=99t be any assumption that the frame siz= e will > necessarily change when the font changes. Emacas <=3D 24.5 at least _always_ tries to change it. martin From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 12:24:09 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 17:24:09 +0000 Received: from localhost ([127.0.0.1]:33046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSU4f-0002g6-Dm for submit@debbugs.gnu.org; Mon, 02 Mar 2015 12:24:09 -0500 Received: from purcellpeople.com ([85.214.32.38]:33945 helo=h1189701.stratoserver.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSU4c-0002fT-EI for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 12:24:07 -0500 Received: from [192.168.1.103] (host86-175-248-64.range86-175.btcentralplus.com [86.175.248.64]) by h1189701.stratoserver.net (Postfix) with ESMTPSA id CB3EC8201B1; Mon, 2 Mar 2015 18:23:59 +0100 (CET) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: bug#19972: Font size change doesn't update (window-total-width) From: Steve Purcell In-Reply-To: <54F4998B.40507@gmx.at> Date: Mon, 2 Mar 2015 17:23:58 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: <547071A4-097B-43D7-8C8E-F65107A68E6C@sanityinc.com> References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <54F4998B.40507@gmx.at> To: martin rudalics X-Mailer: Apple Mail (2.2070.6) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On 2 Mar 2015, at 17:10, martin rudalics wrote: >=20 > > - Consider the case of full-screen frames, which never change in = pixel > > size. The window-width should change when the font size changes in > > this case too. >=20 > This is the case (hopefully) with Emacs 25 but not with Emacs 24.5. > Although some window managers may refuse to change the frame size even > with Emacs 24.5 as we've learned here. It=E2=80=99s not the case on OS X with Emacs HEAD from 19th Feb, at = least. > > - set-frame-font is a built-in function with a KEEP-SIZE param which > > tells it to try to preserve the pixel-size of the frame after the > > font has changed: my code is copied from there. >=20 > If you look at the implementation of this you will see that it first > resizes the frame (via x_new_font) and then tries to size it back to = the > original size. This will fail miserably when the frame was maximized > before (because maximization is a state and not just a specific size) > and will fail when the frame size was not an integral multiple of its > default character size (because `set-frame-font' does some strange > rounding). So never ever use `set-frame-font' with KEEP-SIZE non-nil. > With Emacs 25 you can do, for example, >=20 > (let ((frame-inhibit-implied-resize t)) > (custom-push-theme 'theme-face 'default 'user 'set '((t (:height = 128)))) > (face-spec-recalc 'default (selected-frame))) >=20 > unless you have set `frame-inhibit-implied-resize' to non-nil already. Interesting: I hadn=E2=80=99t seen that. The above snippet still results = in a changed frame size on my system, though. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 12:25:18 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 17:25:18 +0000 Received: from localhost ([127.0.0.1]:33050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSU5k-0002i5-Uh for submit@debbugs.gnu.org; Mon, 02 Mar 2015 12:25:17 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:34746) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSU5h-0002hn-Ep for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 12:25:14 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NKL00900H7O7J00@a-mtaout22.012.net.il> for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 19:25:02 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKL009C4HPP4Y90@a-mtaout22.012.net.il>; Mon, 02 Mar 2015 19:25:02 +0200 (IST) Date: Mon, 02 Mar 2015 19:24:52 +0200 From: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) In-reply-to: <54F49954.6090502@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <83vbijqpln.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <87egp8rssg.fsf@fastmail.fm> <54F49954.6090502@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: joostkremers@fastmail.fm, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Mon, 02 Mar 2015 18:09:40 +0100 > From: martin rudalics > Cc: 19972@debbugs.gnu.org > > OK. The fix for Emacs 25 is attached. Please try it. > > I'm not yet sure whether to fix this for Emacs 24.5 as well. Depends on whether this is a regression, and if so, since when. Do you know? From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 12:35:25 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 17:35:25 +0000 Received: from localhost ([127.0.0.1]:33063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSUFY-0002yI-FC for submit@debbugs.gnu.org; Mon, 02 Mar 2015 12:35:25 -0500 Received: from mtaout28.012.net.il ([80.179.55.184]:60991) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSUFT-0002xz-J6 for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 12:35:21 -0500 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NKL00500HY52J00@mtaout28.012.net.il> for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 19:33:38 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKL001KNI426F40@mtaout28.012.net.il>; Mon, 02 Mar 2015 19:33:38 +0200 (IST) Date: Mon, 02 Mar 2015 19:35:03 +0200 From: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) In-reply-to: <54F4991D.6080600@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <83twy3qp4o.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> <83k2z0rs8o.fsf@gnu.org> <87d24srqw2.fsf@fastmail.fm> <834mq3sdf8.fsf@gnu.org> <54F4991D.6080600@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: joostkremers@fastmail.fm, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Mon, 02 Mar 2015 18:08:45 +0100 > From: martin rudalics > CC: 19972@debbugs.gnu.org > > > Here's the backtrace from the code that resizes the frame as result of > > face-spec-recalc: > > > > 0x0109bc93 in resize_frame_windows (f=0x17d7a30 , > > size=833, horflag=true, pixelwise=true) at window.c:4192 > > 4192 r->pixel_width = new_pixel_size; > > (gdb) bt > > #0 0x0109bc93 in resize_frame_windows (f=0x17d7a30 , > > size=833, horflag=true, pixelwise=true) at window.c:4192 > > Here you see resize_frame_windows getting called which will eventually > call `window--pixel-to-total' to assign the new total sizes of windows. > For Joost this call doesn't happen because new_windows_width equals > old_windows_width. I don't understand why that would happen. It doesn't seem to happen for me, with the current emacs-24 branch. > > #1 0x01011f3e in adjust_frame_size (f=0x17d7a30 , > > new_width=800, new_height=700, inhibit=5, pretend=false, parameter=8064) > > at frame.c:524 > > #2 0x0100f0cc in change_frame_size_1 (f=0x17d7a30 , > > new_width=800, new_height=700, pretend=false, delay=false, safe=false, > > pixelwise=true) at dispnew.c:5501 > > #3 0x0100f12a in change_frame_size (f=0x17d7a30 , > > new_width=800, new_height=700, pretend=false, delay=false, safe=false, > > pixelwise=true) at dispnew.c:5533 > > #4 0x0100eeb8 in do_pending_window_change (safe=false) at dispnew.c:5459 > > #5 0x0123f29d in x_set_window_size (f=0x17d7a30 , > > change_gravity=false, width=800, height=700, pixelwise=true) > > at w32term.c:6194 > > #6 0x01011e7e in adjust_frame_size (f=0x17d7a30 , > > new_width=800, new_height=700, inhibit=3, pretend=false, parameter=14464) > > at frame.c:490 > > Note that x_new_font _always_ calls adjust_frame_size (even for the > `set-frame-font' KEEP-SIZE non-nil case) trying to adjust the frame > size. > > I sincerely hope your frame was not maximized here. Otherwise, > resize_frame_windows should not have been called ... It is called with maximized frames as well, see the backtrace below. #0 0x010913a4 in resize_frame_windows (f=0x3a7b5d0, size=2396, horflag=true, pixelwise=true) at window.c:4211 #1 0x0100ea3e in change_frame_size_1 (f=0x3a7b5d0, new_width=2360, new_height=1300, pretend=false, delay=false, safe=false, pixelwise=true) at dispnew.c:5610 #2 0x0100e719 in change_frame_size (f=0x3a7b5d0, new_width=2360, new_height=1300, pretend=false, delay=false, safe=false, pixelwise=true) at dispnew.c:5518 #3 0x0100e60c in do_pending_window_change (safe=false) at dispnew.c:5479 #4 0x010199eb in x_set_font (f=0x3a7b5d0, arg=62956977, oldval=58852321) at frame.c:3355 #5 0x01017c73 in x_set_frame_parameters (f=0x3a7b5d0, alist=58296354) at frame.c:2889 #6 0x01016c55 in Fmodify_frame_parameters (frame=61322709, alist=58675454) at frame.c:2350 #7 0x010e9f66 in set_font_frame_param (frame=61322709, lface=61590461) at xfaces.c:3418 #8 0x010e9975 in Finternal_set_lisp_face_attribute (face=58325890, attr=58296898, value=512, frame=61322709) at xfaces.c:3233 #9 0x01185d95 in Ffuncall (nargs=5, args=0x82e1a4) at eval.c:2822 #10 0x011c67a9 in exec_byte_code (bytestr=19629633, vector=19629653, maxdepth=28, args_template=58296354, nargs=0, args=0x0) at bytecode.c:916 #11 0x011868da in funcall_lambda (fun=19629597, nargs=4, arg_vector=0x12b8655 ) at eval.c:3044 #12 0x01185f42 in Ffuncall (nargs=5, args=0x82e4a0) at eval.c:2860 #13 0x01185268 in Fapply (nargs=4, args=0x82e5a8) at eval.c:2350 #14 0x01185bfb in Ffuncall (nargs=5, args=0x82e5a4) at eval.c:2792 #15 0x011c67a9 in exec_byte_code (bytestr=19638793, vector=19638813, maxdepth=24, args_template=58296354, nargs=0, args=0x0) at bytecode.c:916 #16 0x011868da in funcall_lambda (fun=19638757, nargs=3, arg_vector=0x12baa1d ) at eval.c:3044 #17 0x01185f42 in Ffuncall (nargs=4, args=0x82e8a4) at eval.c:2860 #18 0x011c67a9 in exec_byte_code (bytestr=19638649, vector=19638669, maxdepth=20, args_template=58296354, nargs=0, args=0x0) at bytecode.c:916 #19 0x011868da in funcall_lambda (fun=19638629, nargs=2, arg_vector=0x12ba98d ) at eval.c:3044 #20 0x01186216 in apply_lambda (fun=19638629, args=58677654, count=13) at eval.c:2919 #21 0x01184bcf in eval_sub (form=58677678) at eval.c:2226 #22 0x011841dd in Feval (form=58677678, lexical=58296354) at eval.c:1996 #23 0x01185d2e in Ffuncall (nargs=3, args=0x82ed4c) at eval.c:2814 #24 0x011c67a9 in exec_byte_code (bytestr=20150481, vector=20150501, maxdepth=20, args_template=1028, nargs=1, args=0x82f050) at bytecode.c:916 #25 0x01186516 in funcall_lambda (fun=20150461, nargs=1, arg_vector=0x82f04c) at eval.c:2978 #26 0x01185f42 in Ffuncall (nargs=2, args=0x82f048) at eval.c:2860 #27 0x011c67a9 in exec_byte_code (bytestr=20150857, vector=20150877, maxdepth=16, args_template=1028, nargs=1, args=0x82f398) at bytecode.c:916 #28 0x01186516 in funcall_lambda (fun=20150829, nargs=1, arg_vector=0x82f394) at eval.c:2978 #29 0x01185f42 in Ffuncall (nargs=2, args=0x82f390) at eval.c:2860 #30 0x0117f504 in Fcall_interactively (function=60483810, record_flag=58296354, keys=58317685) at callint.c:836 #31 0x01185d5d in Ffuncall (nargs=4, args=0x82f57c) at eval.c:2818 #32 0x011c67a9 in exec_byte_code (bytestr=19837345, vector=19837365, maxdepth=52, args_template=4100, nargs=1, args=0x82f890) at bytecode.c:916 #33 0x01186516 in funcall_lambda (fun=19837325, nargs=1, arg_vector=0x82f88c) at eval.c:2978 #34 0x01185f42 in Ffuncall (nargs=2, args=0x82f888) at eval.c:2860 #35 0x011857ec in call1 (fn=58342562, arg1=60483810) at eval.c:2610 #36 0x010f97bf in command_loop_1 () at keyboard.c:1560 #37 0x01182c4f in internal_condition_case (bfun=0x10f915e , handlers=58347874, hfun=0x10f89c3 ) at eval.c:1348 #38 0x010f8e13 in command_loop_2 (ignore=58296354) at keyboard.c:1178 #39 0x011821ff in internal_catch (tag=58343234, func=0x10f8def , arg=58296354) at eval.c:1112 #40 0x010f8dc9 in command_loop () at keyboard.c:1157 #41 0x010f8560 in recursive_edit_1 () at keyboard.c:778 #42 0x010f871c in Frecursive_edit () at keyboard.c:849 #43 0x010f6936 in main (argc=2, argv=0xa427e0) at emacs.c:1642 Lisp Backtrace: "internal-set-lisp-face-attribute" (0x82e1a8) "set-face-attribute" (0x82e4a4) "apply" (0x82e5a8) "face-spec-set-2" (0x82e8a8) "face-spec-recalc" (0x82eb30) "eval" (0x82ed50) "eval-last-sexp-1" (0x82f04c) "eval-last-sexp" (0x82f394) "call-interactively" (0x82f580) "command-execute" (0x82f88c) From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 12:38:13 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 17:38:13 +0000 Received: from localhost ([127.0.0.1]:33067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSUIG-00032i-Ox for submit@debbugs.gnu.org; Mon, 02 Mar 2015 12:38:12 -0500 Received: from mailfe06.swip.net ([212.247.154.161]:54616 helo=swip.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSUID-00032R-RK for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 12:38:10 -0500 X-T2-Spam-Status: No, hits=0.8 required=5.0 tests=BAYES_50 Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe06.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 574291503; Mon, 02 Mar 2015 18:38:03 +0100 Message-ID: <54F49FF6.7010308@swipnet.se> Date: Mon, 02 Mar 2015 18:37:58 +0100 From: "Jan D." User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Steve Purcell , 19972@debbugs.gnu.org Subject: Re: bug#19972: Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <8B7604B9-1637-4C35-B03D-BABE7D5271FA@sanityinc.com> <13451CB2-185E-4238-A19E-37DA0BB359DD@sanityinc.com> In-Reply-To: <13451CB2-185E-4238-A19E-37DA0BB359DD@sanityinc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19972 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Steve Purcell skrev den 2015-03-02 15:09: > I should also mention that toggling between fullscreen and normal (at > least on NS) is another operation which tangibly changes the window > width, but doesn’t seem to result in the result of “(window-width)” > changing. > It does here (on NS). 80 => 360 and then 80 again. Jan D. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 12:43:06 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 17:43:06 +0000 Received: from localhost ([127.0.0.1]:33081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSUMz-0003AL-QR for submit@debbugs.gnu.org; Mon, 02 Mar 2015 12:43:06 -0500 Received: from mailfe05.swip.net ([212.247.154.129]:46492 helo=swip.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSUMx-00039k-Qv for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 12:43:04 -0500 X-T2-Spam-Status: No, hits=0.8 required=5.0 tests=BAYES_50 Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe05.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 572592409; Mon, 02 Mar 2015 18:42:57 +0100 Message-ID: <54F4A120.2060506@swipnet.se> Date: Mon, 02 Mar 2015 18:42:56 +0100 From: "Jan D." User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Eli Zaretskii , Steve Purcell Subject: Re: bug#19972: Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> In-Reply-To: <83bnkbsf5u.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi. Eli Zaretskii skrev den 2015-03-02 14:27: >> From: Steve Purcell >> Date: Mon, 2 Mar 2015 07:57:26 +0000 >> >> - Consider the case of full-screen frames, which never change in pixel size. > > They do for me. See the previous messages. > >> So there really shouldn’t be any assumption that the frame size will necessarily change when the font changes. > > In this case, Emacs itself changes the frame size, so it can expect it > to change. In X you can never be sure. You can request a frame change but it can be denied. For example, fullscreen or tiling window manager. There should be no assumption that what Emacs request w.r.t. frame size actually occurs. > > I think there's some X event due to the window manager that then > resizes the frame back, but we either don't react to it, or somehow > interpret it incorrectly. No, the window manager denies the original frame resize. There is no "resizing back". Jan D. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 12:56:35 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 17:56:35 +0000 Received: from localhost ([127.0.0.1]:33101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSUa3-0003Ti-2e for submit@debbugs.gnu.org; Mon, 02 Mar 2015 12:56:35 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:39881) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSUa0-0003TT-9M for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 12:56:33 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NKL00900ITCFK00@a-mtaout22.012.net.il> for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 19:56:25 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKL009Z2J61DO50@a-mtaout22.012.net.il>; Mon, 02 Mar 2015 19:56:25 +0200 (IST) Date: Mon, 02 Mar 2015 19:56:16 +0200 From: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) In-reply-to: <54F4A120.2060506@swipnet.se> X-012-Sender: halo1@inter.net.il To: "Jan D." Message-id: <83r3t7qo5b.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: steve@sanityinc.com, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Mon, 02 Mar 2015 18:42:56 +0100 > From: "Jan D." > CC: 19972@debbugs.gnu.org > > No, the window manager denies the original frame resize. There is no > "resizing back". Where in the code does this denial happen? From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 13:12:24 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 18:12:24 +0000 Received: from localhost ([127.0.0.1]:33106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSUpL-0003rZ-RJ for submit@debbugs.gnu.org; Mon, 02 Mar 2015 13:12:24 -0500 Received: from mout.gmx.net ([212.227.15.19]:61955) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSUpJ-0003rH-Qt for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 13:12:22 -0500 Received: from [188.23.120.185] ([188.23.120.185]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0LrNl6-1XTtsQ2NuG-0136NW; Mon, 02 Mar 2015 19:12:14 +0100 Message-ID: <54F4A7FC.6090901@gmx.at> Date: Mon, 02 Mar 2015 19:12:12 +0100 From: martin rudalics MIME-Version: 1.0 To: Steve Purcell Subject: Re: bug#19972: Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <54F4998B.40507@gmx.at> <547071A4-097B-43D7-8C8E-F65107A68E6C@sanityinc.com> In-Reply-To: <547071A4-097B-43D7-8C8E-F65107A68E6C@sanityinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:/qFrt5vTLqhOk4/BlQeb6Sa4BSP+Kj3P+Ln9FCUwzhJIYdun9P4 9E5JGZTF4L3qSFDKniGq2AnPzbWlwfMz8z3JHuyeeXs07flZkFmS8s9+AegDnH5z+6gBylb OapXfQMnDMQ/1SWYSI76xGiHud+AgZZaAUqrd2yAJ03LtTBotJPIdHB9hkH6G8mpF79aOlL cI0CkZeGqPxW3rnEJshvw== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >>> - Consider the case of full-screen frames, which never change in pix= el >>> size. The window-width should change when the font size changes i= n >>> this case too. >> >> This is the case (hopefully) with Emacs 25 but not with Emacs 24.5. >> Although some window managers may refuse to change the frame size eve= n >> with Emacs 24.5 as we've learned here. > > > > It=E2=80=99s not the case on OS X with Emacs HEAD from 19th Feb, at le= ast. I meant that with Emacs 25 full-screen frames should never change in pixel size when the default font changes. On all platforms. And people should see the `window-total-width' problem on all systems with current trunk. Have you tried the patch I posted in this thread? >> With Emacs 25 you can do, for example, >> >> (let ((frame-inhibit-implied-resize t)) >> (custom-push-theme 'theme-face 'default 'user 'set '((t (:height 12= 8)))) >> (face-spec-recalc 'default (selected-frame))) >> >> unless you have set `frame-inhibit-implied-resize' to non-nil already= =2E > > > Interesting: I hadn=E2=80=99t seen that. The above snippet still resul= ts in a changed frame size on my system, though. We would have to investigate that. It might mean that OS X changes the frame size deliberately. But Emacs should not request such a change with the above snippet. martin From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 13:12:43 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 18:12:43 +0000 Received: from localhost ([127.0.0.1]:33112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSUpf-0003sN-8K for submit@debbugs.gnu.org; Mon, 02 Mar 2015 13:12:43 -0500 Received: from mout.gmx.net ([212.227.15.18]:52706) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSUpd-0003s9-TR for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 13:12:42 -0500 Received: from [188.23.120.185] ([188.23.120.185]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0LtIZH-1XVok00CNf-012mVr; Mon, 02 Mar 2015 19:12:31 +0100 Message-ID: <54F4A80C.5000606@gmx.at> Date: Mon, 02 Mar 2015 19:12:28 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <87egp8rssg.fsf@fastmail.fm> <54F49954.6090502@gmx.at> <83vbijqpln.fsf@gnu.org> In-Reply-To: <83vbijqpln.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:SNgOIay5cuH6T0mN5agvrpnxafRZiSx8Xl9FujZhooq4tM5aSYp P/caAiE6uAbTuK8k6GOaQ5NQjpysjgCEahkNWeM/LBVXV1UTv4KPAhOXDYb4cv1K9wDs23k xyGXSoICKWdsCZ9t/FpLH/BuOFLo8UNXRG8ZkeG7vjQsYaSWpUjNGzpH7cMkEnOMTmxefYh k6RBk5a8ix17HYkxfcpxQ== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: joostkremers@fastmail.fm, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> I'm not yet sure whether to fix this for Emacs 24.5 as well. > > Depends on whether this is a regression, and if so, since when. Do > you know? 2013-12-13 or 2013-12-04 I think. The problem is that the fix would have to be applied in change_frame_size_1 in dispnew.c and the relevant parts have changed a lot in Emacs 25. So it would not get any reliable testing from users of Emacs 25. martin From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 13:12:57 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 18:12:58 +0000 Received: from localhost ([127.0.0.1]:33115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSUpt-0003sq-II for submit@debbugs.gnu.org; Mon, 02 Mar 2015 13:12:57 -0500 Received: from mout.gmx.net ([212.227.15.19]:50052) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSUpr-0003sb-B0 for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 13:12:55 -0500 Received: from [188.23.120.185] ([188.23.120.185]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0LhfN3-1XgDmu3PpB-00mq98; Mon, 02 Mar 2015 19:12:45 +0100 Message-ID: <54F4A81A.2090102@gmx.at> Date: Mon, 02 Mar 2015 19:12:42 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> <83k2z0rs8o.fsf@gnu.org> <87d24srqw2.fsf@fastmail.fm> <834mq3sdf8.fsf@gnu.org> <54F4991D.6080600@gmx.at> <83twy3qp4o.fsf@gnu.org> In-Reply-To: <83twy3qp4o.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:aJmQrre/CrlcONZfshdA4oUxAVa+yGbjZ5XhTJaZFtUAvYie1Qj P6zLPf3d3uPa05TQAvXprX+yLGf2ohKLn+Tk12Y1rPOyqxDt3O31maeM0uqFz8V46WlSLbC nHjqybe5HnYZ4H4Q8UpG02zy/KY8s3ldYp8oMTx0mXmSnSgnz91RpodaTGREVfuPv7Ob9B0 UZMbkM1Rz9UW7diKGaEHA== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: joostkremers@fastmail.fm, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> Here you see resize_frame_windows getting called which will eventually >> call `window--pixel-to-total' to assign the new total sizes of windows. >> For Joost this call doesn't happen because new_windows_width equals >> old_windows_width. > > I don't understand why that would happen. It doesn't seem to happen > for me, with the current emacs-24 branch. Your backtrace was from Emacs 25. Emacs 24 doesn't have adjust_frame_size. >> > #1 0x01011f3e in adjust_frame_size (f=0x17d7a30 , >> > new_width=800, new_height=700, inhibit=5, pretend=false, parameter=8064) >> > at frame.c:524 [...] >> Note that x_new_font _always_ calls adjust_frame_size (even for the >> `set-frame-font' KEEP-SIZE non-nil case) trying to adjust the frame >> size. >> >> I sincerely hope your frame was not maximized here. Otherwise, >> resize_frame_windows should not have been called ... > > It is called with maximized frames as well, see the backtrace below. > > #0 0x010913a4 in resize_frame_windows (f=0x3a7b5d0, size=2396, horflag=true, > pixelwise=true) at window.c:4211 > #1 0x0100ea3e in change_frame_size_1 (f=0x3a7b5d0, new_width=2360, > new_height=1300, pretend=false, delay=false, safe=false, pixelwise=true) > at dispnew.c:5610 This backtrace is from Emacs 24 where resize_frame_windows gets called by change_frame_size_1. martin From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 13:26:15 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 18:26:15 +0000 Received: from localhost ([127.0.0.1]:33124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSV2k-0004Cu-UZ for submit@debbugs.gnu.org; Mon, 02 Mar 2015 13:26:15 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:44707) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSV2i-0004Cf-AY for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 13:26:13 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NKL00900KDFN500@a-mtaout22.012.net.il> for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 20:26:04 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKL009YAKJGLP30@a-mtaout22.012.net.il>; Mon, 02 Mar 2015 20:26:04 +0200 (IST) Date: Mon, 02 Mar 2015 20:25:54 +0200 From: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) In-reply-to: <54F4A81A.2090102@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <83pp8rqmrx.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> <83k2z0rs8o.fsf@gnu.org> <87d24srqw2.fsf@fastmail.fm> <834mq3sdf8.fsf@gnu.org> <54F4991D.6080600@gmx.at> <83twy3qp4o.fsf@gnu.org> <54F4A81A.2090102@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: joostkremers@fastmail.fm, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Mon, 02 Mar 2015 19:12:42 +0100 > From: martin rudalics > CC: joostkremers@fastmail.fm, 19972@debbugs.gnu.org > > > I don't understand why that would happen. It doesn't seem to happen > > for me, with the current emacs-24 branch. > > Your backtrace was from Emacs 25. Emacs 24 doesn't have > adjust_frame_size. > > >> > #1 0x01011f3e in adjust_frame_size (f=0x17d7a30 , > >> > new_width=800, new_height=700, inhibit=5, pretend=false, parameter=8064) > >> > at frame.c:524 > [...] > >> Note that x_new_font _always_ calls adjust_frame_size (even for the > >> `set-frame-font' KEEP-SIZE non-nil case) trying to adjust the frame > >> size. > >> > >> I sincerely hope your frame was not maximized here. Otherwise, > >> resize_frame_windows should not have been called ... > > > > It is called with maximized frames as well, see the backtrace below. > > > > #0 0x010913a4 in resize_frame_windows (f=0x3a7b5d0, size=2396, horflag=true, > > pixelwise=true) at window.c:4211 > > #1 0x0100ea3e in change_frame_size_1 (f=0x3a7b5d0, new_width=2360, > > new_height=1300, pretend=false, delay=false, safe=false, pixelwise=true) > > at dispnew.c:5610 > > This backtrace is from Emacs 24 where resize_frame_windows gets called > by change_frame_size_1. Sorry, I didn't realize you were talking about the master branch. Yes, there resize_frame_windows doesn't get called, and the frame dimensions don't change, if it is maximized to begin with. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 13:26:44 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 18:26:44 +0000 Received: from localhost ([127.0.0.1]:33127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSV3D-0004Di-GV for submit@debbugs.gnu.org; Mon, 02 Mar 2015 13:26:43 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:44786) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSV3B-0004DS-Cr for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 13:26:41 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NKL00900KDFN500@a-mtaout22.012.net.il> for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 20:26:35 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKL0094XKKALP40@a-mtaout22.012.net.il>; Mon, 02 Mar 2015 20:26:35 +0200 (IST) Date: Mon, 02 Mar 2015 20:26:25 +0200 From: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) In-reply-to: <54F4A80C.5000606@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <83oaobqmr2.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <87egp8rssg.fsf@fastmail.fm> <54F49954.6090502@gmx.at> <83vbijqpln.fsf@gnu.org> <54F4A80C.5000606@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: joostkremers@fastmail.fm, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Mon, 02 Mar 2015 19:12:28 +0100 > From: martin rudalics > CC: joostkremers@fastmail.fm, 19972@debbugs.gnu.org > > >> I'm not yet sure whether to fix this for Emacs 24.5 as well. > > > > Depends on whether this is a regression, and if so, since when. Do > > you know? > > 2013-12-13 or 2013-12-04 I think. The problem is that the fix would > have to be applied in change_frame_size_1 in dispnew.c and the relevant > parts have changed a lot in Emacs 25. So it would not get any reliable > testing from users of Emacs 25. Then let's wait with applying to the branch until after 24.5 is released. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 13:43:39 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 18:43:39 +0000 Received: from localhost ([127.0.0.1]:33143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSVJb-0004cm-Ay for submit@debbugs.gnu.org; Mon, 02 Mar 2015 13:43:39 -0500 Received: from mout.gmx.net ([212.227.15.18]:57331) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSVJa-0004cP-1V for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 13:43:38 -0500 Received: from [188.23.120.185] ([188.23.120.185]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0M1Fe4-1XdpXN1Zsm-00tEpj; Mon, 02 Mar 2015 19:43:29 +0100 Message-ID: <54F4AF4E.3050200@gmx.at> Date: Mon, 02 Mar 2015 19:43:26 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> <83k2z0rs8o.fsf@gnu.org> <87d24srqw2.fsf@fastmail.fm> <834mq3sdf8.fsf@gnu.org> <54F4991D.6080600@gmx.at> <83twy3qp4o.fsf@gnu.org> <54F4A81A.2090102@gmx.at> <83pp8rqmrx.fsf@gnu.org> In-Reply-To: <83pp8rqmrx.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Nun8DhAzBWox+cLpGEg1H8LtEud9LDpcb9ApaQgZk8o/cvqCgVj z8z6Yw+HSDAPTP8pq4gnYO0sYGQaofrTIvKm9AmpytkyjEoxhOehRu/EGPI0KDJz/E+z6gn 2ISqHs0GDiLoBkAPPBdnnqkL+iP7hsxeB7zqidL/NKQgyuxEEn6zxsMiyMK3EPOCrxbmfPP QRNpYF9q5utbPLdlyH7Hw== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: joostkremers@fastmail.fm, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Sorry, I didn't realize you were talking about the master branch. I was because your first backtrace was from the master branch. > Yes, there resize_frame_windows doesn't get called, and the frame > dimensions don't change, if it is maximized to begin with. Relieving. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 13:47:14 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 18:47:14 +0000 Received: from localhost ([127.0.0.1]:33147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSVN4-0004iZ-3T for submit@debbugs.gnu.org; Mon, 02 Mar 2015 13:47:14 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:59972) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSVN1-0004iJ-9j for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 13:47:12 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NKL00100LBKVH00@a-mtaout21.012.net.il> for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 20:47:04 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKL001KELIGSFA0@a-mtaout21.012.net.il>; Mon, 02 Mar 2015 20:47:04 +0200 (IST) Date: Mon, 02 Mar 2015 20:46:55 +0200 From: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) In-reply-to: <54F4AF4E.3050200@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <83mw3vqlsw.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> <83k2z0rs8o.fsf@gnu.org> <87d24srqw2.fsf@fastmail.fm> <834mq3sdf8.fsf@gnu.org> <54F4991D.6080600@gmx.at> <83twy3qp4o.fsf@gnu.org> <54F4A81A.2090102@gmx.at> <83pp8rqmrx.fsf@gnu.org> <54F4AF4E.3050200@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: joostkremers@fastmail.fm, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Mon, 02 Mar 2015 19:43:26 +0100 > From: martin rudalics > CC: joostkremers@fastmail.fm, 19972@debbugs.gnu.org > > > Sorry, I didn't realize you were talking about the master branch. > > I was because your first backtrace was from the master branch. I didn't realize there was any difference regarding this issue between the two branches. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 14:07:12 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 19:07:12 +0000 Received: from localhost ([127.0.0.1]:33152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSVgN-0005DJ-Vm for submit@debbugs.gnu.org; Mon, 02 Mar 2015 14:07:12 -0500 Received: from mailfe09.swip.net ([212.247.155.1]:41364 helo=swip.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSVgK-0005D5-Mz for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 14:07:10 -0500 X-T2-Spam-Status: No, hits=-0.0 required=5.0 tests=BAYES_40 Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe09.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 404045874; Mon, 02 Mar 2015 20:07:01 +0100 Message-ID: <54F4B4CF.90905@swipnet.se> Date: Mon, 02 Mar 2015 20:06:55 +0100 From: "Jan D." User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> In-Reply-To: <83r3t7qo5b.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: steve@sanityinc.com, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii skrev 2015-03-02 18:56: >> Date: Mon, 02 Mar 2015 18:42:56 +0100 >> From: "Jan D." >> CC: 19972@debbugs.gnu.org >> >> No, the window manager denies the original frame resize. There is no >> "resizing back". > > Where in the code does this denial happen? > In the window manager code. Jan D. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 14:53:04 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 19:53:04 +0000 Received: from localhost ([127.0.0.1]:33162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSWOl-0006HD-QQ for submit@debbugs.gnu.org; Mon, 02 Mar 2015 14:53:04 -0500 Received: from mtaout24.012.net.il ([80.179.55.180]:59225) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSWOi-0006GZ-Pd for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 14:53:02 -0500 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NKL00000NY8LB00@mtaout24.012.net.il> for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 21:44:55 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKL00JNSO6S5M70@mtaout24.012.net.il>; Mon, 02 Mar 2015 21:44:55 +0200 (IST) Date: Mon, 02 Mar 2015 21:52:41 +0200 From: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) In-reply-to: <54F4B4CF.90905@swipnet.se> X-012-Sender: halo1@inter.net.il To: "Jan D." Message-id: <83lhjfqira.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: steve@sanityinc.com, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Mon, 02 Mar 2015 20:06:55 +0100 > From: "Jan D." > CC: steve@sanityinc.com, 19972@debbugs.gnu.org > > Eli Zaretskii skrev 2015-03-02 18:56: > >> Date: Mon, 02 Mar 2015 18:42:56 +0100 > >> From: "Jan D." > >> CC: 19972@debbugs.gnu.org > >> > >> No, the window manager denies the original frame resize. There is no > >> "resizing back". > > > > Where in the code does this denial happen? > > > > In the window manager code. I meant where/how does Emacs know that its request to resize was denied? From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 15:19:21 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 20:19:21 +0000 Received: from localhost ([127.0.0.1]:33173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSWoD-0006tx-1r for submit@debbugs.gnu.org; Mon, 02 Mar 2015 15:19:21 -0500 Received: from mailfe01.swip.net ([212.247.154.1]:47174 helo=swip.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSWo9-0006tg-NF for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 15:19:19 -0500 X-T2-Spam-Status: No, hits=-0.0 required=5.0 tests=BAYES_20 Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe01.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 564802144; Mon, 02 Mar 2015 21:19:09 +0100 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: bug#19972: Font size change doesn't update (window-total-width) From: "Jan D." X-Mailer: iPad Mail (12B466) In-Reply-To: <83lhjfqira.fsf@gnu.org> Date: Mon, 2 Mar 2015 21:19:14 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> To: Eli Zaretskii X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: "steve@sanityinc.com" , "19972@debbugs.gnu.org" <19972@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi. 2 mar 2015 kl. 20:52 skrev Eli Zaretskii : >> Date: Mon, 02 Mar 2015 20:06:55 +0100 >> From: "Jan D." >> CC: steve@sanityinc.com, 19972@debbugs.gnu.org >>=20 >> Eli Zaretskii skrev 2015-03-02 18:56: >>>> Date: Mon, 02 Mar 2015 18:42:56 +0100 >>>> From: "Jan D." >>>> CC: 19972@debbugs.gnu.org >>>>=20 >>>> No, the window manager denies the original frame resize. There is no >>>> "resizing back". >>>=20 >>> Where in the code does this denial happen? >>=20 >> In the window manager code. >=20 > I meant where/how does Emacs know that its request to resize was > denied? When an X window is resized, it gets a ConfigureNotify event. When the resi= ze is denied, no event arrives. That is why Emacs on X only considers Confi= gureNotify as resizes. If lisp code tries to resize, we make the request, b= ut nothing is updated until we get a ConfigureNotify. Jan D. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 17:27:10 2015 Received: (at 19972) by debbugs.gnu.org; 2 Mar 2015 22:27:10 +0000 Received: from localhost ([127.0.0.1]:33191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSYnu-0001X2-37 for submit@debbugs.gnu.org; Mon, 02 Mar 2015 17:27:10 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:50690) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSYnr-0001Wr-0p for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 17:27:08 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 6054C20B11 for <19972@debbugs.gnu.org>; Mon, 2 Mar 2015 17:27:05 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute2.internal (MEProxy); Mon, 02 Mar 2015 17:27:06 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.fm; h= x-sasl-enc:references:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; s=mesmtp; bh=BSSeXogrIRpW m5Jg4tOmUmOnQ+Q=; b=S7mw0RgT0Pruc6URbli7o0G330YV+1DzRO9zxNVxemjM 8R0giph8P7rSN5JtTBEWdFL41OlnxobIFlyMIJiCfgAI0TL6QBSfz60OCPjqrcFq W5fXIl/u5rm27OQ9XSbIOVPEm5VjLwPhCfePzW2n7ifZYjndlptG7tsYav8cqhg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-type; s= smtpout; bh=BSSeXogrIRpWm5Jg4tOmUmOnQ+Q=; b=j23AN4QlmvtyMfgR0oks kplHSPh8V6h+aH9bdBb7nAPa9XRwTMHVqLAGm7mQOx1RsK8H9w2o0KbKotZWLDEY Eee7ZBg7JdKYYkeut4wR3v8Duk6B04V3vBP101TgCP132PH08OnFKD+ZxnJaK9TL zl1p0gDIbBPclnOizl12Q8U= X-Sasl-enc: Z1a8Pa18CPcx0kmYeAZqBaD4whr2lSmx/qpayzXNc8ug 1425335224 Received: from IdeaPad.messagingengine.com (unknown [95.119.121.43]) by mail.messagingengine.com (Postfix) with ESMTPA id 03F3C680205; Mon, 2 Mar 2015 17:27:02 -0500 (EST) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> <83k2z0rs8o.fsf@gnu.org> <87d24srqw2.fsf@fastmail.fm> <834mq3sdf8.fsf@gnu.org> From: Joost Kremers To: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) In-reply-to: <834mq3sdf8.fsf@gnu.org> Date: Mon, 02 Mar 2015 23:26:58 +0100 Message-ID: <87a8zvrq6l.fsf@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 19972 Cc: rudalics@gmx.at, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, Mar 02 2015, Eli Zaretskii wrote: >> From: Joost Kremers >> Cc: rudalics@gmx.at, 19972@debbugs.gnu.org >> Date: Mon, 02 Mar 2015 04:59:25 +0100 >> >> > I asked about values returned by window-width in this scenario, can >> > you provide them? >> >> Sorry, forgot that. `window-width' doesn't have the same issue. On my >> system, with a maximised Emacs frame (Emacs version 25.0.50.1), it >> returns 236 before `custom-push-theme' + `face-spec-recalc', and 188 >> after it, even without doing `C-x 3' followed by `C-x 1'. > > In that case, I guess if you call (window-total-width 'round), you > will see the correct value even before "C-x 3", right? No, it doesn't. It still returns 240, i.e., the same value returned by (window-total-width). (window-width) returns 188. (frame-total-cols) returns 192. After C-x 3 C-x 1, (window-total-width) also returns 192. (All of this with Emacs 25.0.50.1 and a maximised frame.) > Joost, could you find out where does w->pixel_size change in your > recipe (where 'w' is the pointer to the window displaying *scratch*)? I'd be happy to, but... > If my guess is correct, it should change twice: once as shown below in > the backtrace I produced, and then once more, where it changes back to > the dimensions of your display. We are interested to know where is > that second time, and who calls that code. > > One way of finding this out is to put a watchpoint in GDB on > w->pixel_size. Let me know if you need more detailed instructions for > how to do it. That would be great, since I have only basic knowledge of GDB. -- Joost Kremers Life has its moments From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 22:36:20 2015 Received: (at 19972) by debbugs.gnu.org; 3 Mar 2015 03:36:20 +0000 Received: from localhost ([127.0.0.1]:33264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSdd6-0000Jm-62 for submit@debbugs.gnu.org; Mon, 02 Mar 2015 22:36:20 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:59044) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSdd2-0000JW-Uv for 19972@debbugs.gnu.org; Mon, 02 Mar 2015 22:36:18 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NKM00D009EN4M00@a-mtaout22.012.net.il> for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 05:36:08 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKM00DMNA087310@a-mtaout22.012.net.il>; Tue, 03 Mar 2015 05:36:08 +0200 (IST) Date: Tue, 03 Mar 2015 05:36:00 +0200 From: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) In-reply-to: <87a8zvrq6l.fsf@fastmail.fm> X-012-Sender: halo1@inter.net.il To: Joost Kremers Message-id: <83ioeirbvj.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> <83k2z0rs8o.fsf@gnu.org> <87d24srqw2.fsf@fastmail.fm> <834mq3sdf8.fsf@gnu.org> <87a8zvrq6l.fsf@fastmail.fm> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: rudalics@gmx.at, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Joost Kremers > Cc: rudalics@gmx.at, 19972@debbugs.gnu.org > Date: Mon, 02 Mar 2015 23:26:58 +0100 > > >> Sorry, forgot that. `window-width' doesn't have the same issue. On my > >> system, with a maximised Emacs frame (Emacs version 25.0.50.1), it > >> returns 236 before `custom-push-theme' + `face-spec-recalc', and 188 > >> after it, even without doing `C-x 3' followed by `C-x 1'. > > > > In that case, I guess if you call (window-total-width 'round), you > > will see the correct value even before "C-x 3", right? > > No, it doesn't. It still returns 240, i.e., the same value returned by > (window-total-width). > > (window-width) returns 188. That's very strange, since they use the same data. But if Martin's patch fixes the issue for you (does it?), we don't need to pursue this further. > > Joost, could you find out where does w->pixel_size change in your > > recipe (where 'w' is the pointer to the window displaying *scratch*)? > > I'd be happy to, but... > > > If my guess is correct, it should change twice: once as shown below in > > the backtrace I produced, and then once more, where it changes back to > > the dimensions of your display. We are interested to know where is > > that second time, and who calls that code. > > > > One way of finding this out is to put a watchpoint in GDB on > > w->pixel_size. Let me know if you need more detailed instructions for > > how to do it. > > That would be great, since I have only basic knowledge of GDB. Given Jan's explanation of the issue, I don't think this is needed anymore. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 03 03:06:25 2015 Received: (at 19972) by debbugs.gnu.org; 3 Mar 2015 08:06:25 +0000 Received: from localhost ([127.0.0.1]:33306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YShqS-0006lJ-Sl for submit@debbugs.gnu.org; Tue, 03 Mar 2015 03:06:25 -0500 Received: from mout.gmx.net ([212.227.15.18]:63857) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YShqR-0006l6-CK for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 03:06:23 -0500 Received: from [188.23.120.148] ([188.23.120.148]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0McVGq-1YB2Qt3fmK-00HiBd; Tue, 03 Mar 2015 09:06:12 +0100 Message-ID: <54F56B71.30401@gmx.at> Date: Tue, 03 Mar 2015 09:06:09 +0100 From: martin rudalics MIME-Version: 1.0 To: Joost Kremers , Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> <83k2z0rs8o.fsf@gnu.org> <87d24srqw2.fsf@fastmail.fm> <834mq3sdf8.fsf@gnu.org> <87a8zvrq6l.fsf@fastmail.fm> In-Reply-To: <87a8zvrq6l.fsf@fastmail.fm> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Y1IYCLTJkonrQc2a4tKKKDSn/kFiTzrX3/ZUx3MC0bWpOrvCNss tFfkdJ3inIjXJyfGPbmaBbjlU52HkQfWJLDDiDQY3r2/zdLtsHz0QFhB46OoLdyMMxNUiE/ iAP12E31nkzqaxs3obxQ5MvQk8Rjt3wt90Ur5sU7yDhiDZb94Jd7ejY0rDy+p7IbNvhh6UZ IddVUgRSrrVSBdOVrAsQg== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> In that case, I guess if you call (window-total-width 'round), you >> will see the correct value even before "C-x 3", right? > > No, it doesn't. It still returns 240, i.e., the same value returned by > (window-total-width). Observe that (window-total-width 'round) should get you (wrong-type-argument window-valid-p round) As a rule `window-' prefixed functions require a window as first argument. The form to evaluate should be either (window-total-width nil 'ceiling) or (window-total-width nil 'floor). Any other value for ROUND behaves like `window-total-width' called without ROUND argument. martin From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 03 03:08:02 2015 Received: (at 19972) by debbugs.gnu.org; 3 Mar 2015 08:08:02 +0000 Received: from localhost ([127.0.0.1]:33310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YShs2-0006ny-9W for submit@debbugs.gnu.org; Tue, 03 Mar 2015 03:08:02 -0500 Received: from mout.gmx.net ([212.227.15.19]:59744) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YShs1-0006nU-3h for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 03:08:01 -0500 Received: from [188.23.120.148] ([188.23.120.148]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MfW5D-1Y97Rb1RSl-00P9Po; Tue, 03 Mar 2015 09:07:52 +0100 Message-ID: <54F56BD5.1080001@gmx.at> Date: Tue, 03 Mar 2015 09:07:49 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii , Joost Kremers Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> <83k2z0rs8o.fsf@gnu.org> <87d24srqw2.fsf@fastmail.fm> <834mq3sdf8.fsf@gnu.org> <87a8zvrq6l.fsf@fastmail.fm> <83ioeirbvj.fsf@gnu.org> In-Reply-To: <83ioeirbvj.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Kjdt6Ovg0JdBuOR9JsKxnWPS94TGV4m9crHQg/B57qSMPV1erYK vy9sIOUwfW2imBrsvkAB2EV5eeB7fkRwb6ws7ciA5Gu8azXNNmp0l1edZv2GkaipSn5QW6g ceRb0pMfvl+v5ugZv/d/7sCPDWoDJLkp9qOrvoO+7uZ24V/Yle2ndrDeYiEqQYmIkNaxotb 8YWwW1r6hadFRbkKIfkJw== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Given Jan's explanation of the issue, I don't think this is needed > anymore. Jan's explanation was for X. NS behaves differently IIUC. martin From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 03 04:06:43 2015 Received: (at 19972) by debbugs.gnu.org; 3 Mar 2015 09:06:43 +0000 Received: from localhost ([127.0.0.1]:33319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSimo-0008Df-QO for submit@debbugs.gnu.org; Tue, 03 Mar 2015 04:06:43 -0500 Received: from mailfe02.swip.net ([212.247.154.33]:42763 helo=swip.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSimk-0008DK-U4 for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 04:06:40 -0500 X-T2-Spam-Status: No, hits=0.8 required=5.0 tests=BAYES_50 Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe02.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 578131491; Tue, 03 Mar 2015 10:06:31 +0100 Received: from [172.16.2.178] (unknown [176.57.193.190]) (Authenticated sender: jhd) by hosdjarv.se (Postfix) with ESMTPSA id 2DE2B1A0117; Tue, 3 Mar 2015 09:06:31 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) From: =?utf-8?Q?Jan_Dj=C3=A4rv?= X-Mailer: iPhone Mail (12B466) In-Reply-To: <54F56BD5.1080001@gmx.at> Date: Tue, 3 Mar 2015 10:06:29 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> <83k2z0rs8o.fsf@gnu.org> <87d24srqw2.fsf@fastmail.fm> <834mq3sdf8.fsf@gnu.org> <87a8zvrq6l.fsf@fastmail.fm> <83ioeirbvj.fsf@gnu.org> <54F56BD5.1080001@gmx.at> To: martin rudalics X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: Joost Kremers , Eli Zaretskii , "19972@debbugs.gnu.org" <19972@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi.=20 > 3 mar 2015 kl. 09:07 skrev martin rudalics : >=20 > > Given Jan's explanation of the issue, I don't think this is needed > > anymore. >=20 > Jan's explanation was for X. NS behaves differently IIUC. Actually not. NS also only changes stuff when it gets an event that informs a= bout resize.=20 Jan D.=20= From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 03 05:17:27 2015 Received: (at 19972) by debbugs.gnu.org; 3 Mar 2015 10:17:27 +0000 Received: from localhost ([127.0.0.1]:33511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSjtG-0001c5-QP for submit@debbugs.gnu.org; Tue, 03 Mar 2015 05:17:27 -0500 Received: from mout.gmx.net ([212.227.15.15]:55543) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSjtE-0001bt-TB for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 05:17:25 -0500 Received: from [188.23.120.148] ([188.23.120.148]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0Ld1CS-1Xkdh61nSS-00iCNy; Tue, 03 Mar 2015 11:17:16 +0100 Message-ID: <54F58A29.30709@gmx.at> Date: Tue, 03 Mar 2015 11:17:13 +0100 From: martin rudalics MIME-Version: 1.0 To: =?ISO-8859-1?Q?Jan_Dj=E4rv?= Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> <83k2z0rs8o.fsf@gnu.org> <87d24srqw2.fsf@fastmail.fm> <834mq3sdf8.fsf@gnu.org> <87a8zvrq6l.fsf@fastmail.fm> <83ioeirbvj.fsf@gnu.org> <54F56BD5.1080001@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:IE2ace4o0X3jS3lJJf8o9/+WeRioC80lqj/d9HLa8zX965jtO96 VDFmwfLlFjUKp8cLyPhqXn99Hl+f2lQwGuA5UgXRBSJYq4ikn2TDRvWGjzGRqXmhYcVAZYG sZUMB60bZoOmq9FmscMeMwA+2kh/IcbbVCUkNvtf1KiUOjUhDB1sfvV0++ckikJjPcN+PJ/ CniSQ8UrFowmkBXEmjYRQ== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: Joost Kremers , Eli Zaretskii , "19972@debbugs.gnu.org" <19972@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Actually not. NS also only changes stuff when it gets an event that informs about resize. IIUC Emacs doesn't run a timer when issuing a resize request on NS. So I have no idea how two subsequent resize requests are handled there. Consider the case where Lisp code sends a height change request first and a width change request afterwards: Which is the height Emacs asks for in the second request? The one before the first request or the one after the first request has been honored? martin From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 03 05:38:27 2015 Received: (at 19972) by debbugs.gnu.org; 3 Mar 2015 10:38:27 +0000 Received: from localhost ([127.0.0.1]:33536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSkDb-000296-Hi for submit@debbugs.gnu.org; Tue, 03 Mar 2015 05:38:27 -0500 Received: from mout.gmx.net ([212.227.15.18]:53113) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSkDa-00028t-1g for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 05:38:26 -0500 Received: from [188.23.120.148] ([188.23.120.148]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MNq4h-1YQpCZ0F7j-007XAW; Tue, 03 Mar 2015 11:38:20 +0100 Message-ID: <54F58F19.1070401@gmx.at> Date: Tue, 03 Mar 2015 11:38:17 +0100 From: martin rudalics MIME-Version: 1.0 To: Joost Kremers Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <87egp8rssg.fsf@fastmail.fm> <54F49954.6090502@gmx.at> In-Reply-To: <54F49954.6090502@gmx.at> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:NqzEHHpAf3hyYH2UvjDORqKw53SV7KwS3JNT4lnQv6O/XHYPZrA rqt6peFhxbo80RkMjTqdq755SZF1oqZnDJ5BCnKNSY5mvlbHFJ9ZphQ5PwiSXhpFub4QO9q 1ILavEvFdhrzKDkAYgReSlgiAWIbctArTDFC9yqVT1FaNrYC3sYgC6xd/8y39L2/4Yw/FJc tFkyUx6xt/26Zy1f0fG5g== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > OK. The fix for Emacs 25 is attached. Please try it. Pushed as 2cc23f1..1903e25 master -> master. Please try again with most recent trunk/master. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 03 06:05:36 2015 Received: (at 19972) by debbugs.gnu.org; 3 Mar 2015 11:05:36 +0000 Received: from localhost ([127.0.0.1]:33554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSkdr-0002nC-9z for submit@debbugs.gnu.org; Tue, 03 Mar 2015 06:05:35 -0500 Received: from mailfe01.swip.net ([212.247.154.1]:41204 helo=swip.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSkdo-0002mu-0b for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 06:05:33 -0500 X-T2-Spam-Status: No, hits=0.8 required=5.0 tests=BAYES_50 Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe01.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 564916206; Tue, 03 Mar 2015 12:05:23 +0100 Received: from jdvpro.hq.ismobile.com (unknown [176.57.193.190]) (Authenticated sender: jhd) by hosdjarv.se (Postfix) with ESMTPSA id D8BF91A0117; Tue, 3 Mar 2015 11:05:22 +0000 (UTC) Message-ID: <54F5956F.10009@swipnet.se> Date: Tue, 03 Mar 2015 12:05:19 +0100 From: "Jan D." User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: martin rudalics Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> <83k2z0rs8o.fsf@gnu.org> <87d24srqw2.fsf@fastmail.fm> <834mq3sdf8.fsf@gnu.org> <87a8zvrq6l.fsf@fastmail.fm> <83ioeirbvj.fsf@gnu.org> <54F56BD5.1080001@gmx.at> <54F58A29.30709@gmx.at> In-Reply-To: <54F58A29.30709@gmx.at> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: Joost Kremers , Eli Zaretskii , "19972@debbugs.gnu.org" <19972@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) martin rudalics skrev den 2015-03-03 11:17: > > Actually not. NS also only changes stuff when it gets an event that > informs about resize. > > IIUC Emacs doesn't run a timer when issuing a resize request on NS. So > I have no idea how two subsequent resize requests are handled there. > Consider the case where Lisp code sends a height change request first > and a width change request afterwards: Which is the height Emacs asks > for in the second request? The one before the first request or the one > after the first request has been honored? Lisp code that expects resize changes to be handeled synchronously and in order are fundamentally broken. That said, it may very well be a race here, i.e. the wrong height gets sent. But this is only because bad Lisp code assumes synchronous handling. Jan D. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 03 06:27:06 2015 Received: (at 19972) by debbugs.gnu.org; 3 Mar 2015 11:27:06 +0000 Received: from localhost ([127.0.0.1]:33563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSkyf-0003Lq-US for submit@debbugs.gnu.org; Tue, 03 Mar 2015 06:27:06 -0500 Received: from mout.gmx.net ([212.227.15.15]:57413) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSkyd-0003LH-Rn for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 06:27:04 -0500 Received: from [188.23.120.148] ([188.23.120.148]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MMCFR-1YPA4B2Gez-0081jT; Tue, 03 Mar 2015 12:26:54 +0100 Message-ID: <54F59A7A.9030407@gmx.at> Date: Tue, 03 Mar 2015 12:26:50 +0100 From: martin rudalics MIME-Version: 1.0 To: "Jan D." Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> <83k2z0rs8o.fsf@gnu.org> <87d24srqw2.fsf@fastmail.fm> <834mq3sdf8.fsf@gnu.org> <87a8zvrq6l.fsf@fastmail.fm> <83ioeirbvj.fsf@gnu.org> <54F56BD5.1080001@gmx.at> <54F58A29.30709@gmx.at> <54F5956F.10009@swipnet.se> In-Reply-To: <54F5956F.10009@swipnet.se> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:7NIQiQI6S+1VDYJqgR4+VF5FTRaBpFErRydG4FiwtN0J2uSZyKk IleJtwq37STjHTp4E1PNcadV2vNx1/gFfZC6c0NlhDyY7b0J/sUIF94nhW1OiRgBtvGUFs9 TkVkakgn2uf6TRTFfqN0wiYKIAJIh57ZY0nKGAqjK6EuBYO5j96omcQVMHl6M2r6E//RQsS 6IQKHobplr2BHNN1fQnuw== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: Joost Kremers , Eli Zaretskii , "19972@debbugs.gnu.org" <19972@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Lisp code that expects resize changes to be handeled synchronously and in order are fundamentally broken. > > That said, it may very well be a race here, i.e. the wrong height gets sent. But this is only because bad Lisp code assumes synchronous handling. Fully agreed. Unfortunately, it can be very difficult to explain this to users :-( BTW what is the x_wait_for_event in x_set_window_size_1 then really needed for? martin From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 03 07:08:06 2015 Received: (at 19972) by debbugs.gnu.org; 3 Mar 2015 12:08:06 +0000 Received: from localhost ([127.0.0.1]:33581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSlcM-0004Lx-4o for submit@debbugs.gnu.org; Tue, 03 Mar 2015 07:08:06 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:49060) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSlcJ-0004Ln-Qe for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 07:08:04 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 4998020668 for <19972@debbugs.gnu.org>; Tue, 3 Mar 2015 07:08:02 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Tue, 03 Mar 2015 07:08:03 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.fm; h= x-sasl-enc:references:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; s=mesmtp; bh=R7fI6CuhQPKZ DcQcQ3G/F72cSm4=; b=S9VayUybxfNyQJ37c+HRFt057edzYP27AbH+WX/YrRzy Cl5dGB41lkTh2vXn/FUC1Z0uxb2Fnt22rEuiLEfaNP3KNdkOd4WmpM7UJjkd+eFh dXqbYbs4Pu4/X7QRrDus3A96Oo8yL+OFQhzLohFITVkoZVMm7PhExwgtHj/KTOw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-type; s= smtpout; bh=R7fI6CuhQPKZDcQcQ3G/F72cSm4=; b=DjrUb2DISyOZaZem0im2 nxJPNg049ePTvP9XnJaO0u3M5VAeqyki+QrMV2hBGqYWnG1Xe4MKEMywvumlf4dw set+biRmPvhalOHN46/Pq6n7E3lqVSJxK3iUIybR+qxZrJLRaaREI5RWLN2bRWpT gk5OWVuWpIIYN7cnDDl4xOI= X-Sasl-enc: G0VbcdC0dUviiCjlDXoA+rOI7eRizVcGbyJaJAHBxMMi 1425384482 Received: from IdeaPad.messagingengine.com (unknown [77.10.216.117]) by mail.messagingengine.com (Postfix) with ESMTPA id 7BC52C0028C; Tue, 3 Mar 2015 07:08:02 -0500 (EST) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> <83k2z0rs8o.fsf@gnu.org> <87d24srqw2.fsf@fastmail.fm> <834mq3sdf8.fsf@gnu.org> <87a8zvrq6l.fsf@fastmail.fm> <83ioeirbvj.fsf@gnu.org> From: Joost Kremers To: Eli Zaretskii Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) In-reply-to: <83ioeirbvj.fsf@gnu.org> Date: Tue, 03 Mar 2015 13:08:00 +0100 Message-ID: <878ufes2qn.fsf@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 19972 Cc: rudalics@gmx.at, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, Mar 03 2015, Eli Zaretskii wrote: >> From: Joost Kremers >> Cc: rudalics@gmx.at, 19972@debbugs.gnu.org >> Date: Mon, 02 Mar 2015 23:26:58 +0100 >> >> >> Sorry, forgot that. `window-width' doesn't have the same issue. On my >> >> system, with a maximised Emacs frame (Emacs version 25.0.50.1), it >> >> returns 236 before `custom-push-theme' + `face-spec-recalc', and 188 >> >> after it, even without doing `C-x 3' followed by `C-x 1'. >> > >> > In that case, I guess if you call (window-total-width 'round), you >> > will see the correct value even before "C-x 3", right? >> >> No, it doesn't. It still returns 240, i.e., the same value returned by >> (window-total-width). >> >> (window-width) returns 188. > > That's very strange, since they use the same data. But if Martin's > patch fixes the issue for you (does it?), we don't need to pursue this > further. As Martin says, with `ceiling' or `floor' the return value is 192 instead of 240. -- Joost Kremers Life has its moments From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 03 07:08:51 2015 Received: (at 19972) by debbugs.gnu.org; 3 Mar 2015 12:08:51 +0000 Received: from localhost ([127.0.0.1]:33584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSld4-0004N7-Om for submit@debbugs.gnu.org; Tue, 03 Mar 2015 07:08:51 -0500 Received: from mailfe07.swip.net ([212.247.154.193]:35369 helo=swip.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSld1-0004Ms-Q4 for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 07:08:48 -0500 X-T2-Spam-Status: No, hits=0.8 required=5.0 tests=BAYES_50 Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe07.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 576048238; Tue, 03 Mar 2015 13:08:40 +0100 Received: from jdvpro.hq.ismobile.com (unknown [176.57.193.190]) (Authenticated sender: jhd) by hosdjarv.se (Postfix) with ESMTPSA id 1CCBF1A01AA; Tue, 3 Mar 2015 12:08:40 +0000 (UTC) Message-ID: <54F5A444.4050402@swipnet.se> Date: Tue, 03 Mar 2015 13:08:36 +0100 From: "Jan D." User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: martin rudalics Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <83pp8sspn2.fsf@gnu.org> <87zj7wmysq.fsf@fastmail.fm> <83lhjgsj96.fsf@gnu.org> <87y4ngmoso.fsf@fastmail.fm> <83k2z0rs8o.fsf@gnu.org> <87d24srqw2.fsf@fastmail.fm> <834mq3sdf8.fsf@gnu.org> <87a8zvrq6l.fsf@fastmail.fm> <83ioeirbvj.fsf@gnu.org> <54F56BD5.1080001@gmx.at> <54F58A29.30709@gmx.at> <54F5956F.10009@swipnet.se> <54F59A7A.9030407@gmx.at> In-Reply-To: <54F59A7A.9030407@gmx.at> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: Joost Kremers , Eli Zaretskii , "19972@debbugs.gnu.org" <19972@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) martin rudalics skrev den 2015-03-03 12:26: > > Lisp code that expects resize changes to be handeled synchronously > and in order are fundamentally broken. > > > > That said, it may very well be a race here, i.e. the wrong height > gets sent. But this is only because bad Lisp code assumes synchronous > handling. > > Fully agreed. Unfortunately, it can be very difficult to explain this > to users :-( > > BTW what is the x_wait_for_event in x_set_window_size_1 then really > needed for? Its an attempt to be nice to Lisp. It can fail and time out. Jan D. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 03 07:23:14 2015 Received: (at 19972) by debbugs.gnu.org; 3 Mar 2015 12:23:14 +0000 Received: from localhost ([127.0.0.1]:33604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSlr0-0004iX-HM for submit@debbugs.gnu.org; Tue, 03 Mar 2015 07:23:14 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:52955) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSlqz-0004iQ-7p for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 07:23:13 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EE792204F0 for <19972@debbugs.gnu.org>; Tue, 3 Mar 2015 07:23:11 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 03 Mar 2015 07:23:13 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.fm; h= x-sasl-enc:references:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; s=mesmtp; bh=PqUXRDCWVUeB 6aq8d37lFTCfGxc=; b=k14cZzkq8sH515DwDoTWS8D0Pyq0iIYzOXy76PeLvNz7 xc1HtDkqov73TLp4+iYroETyl3frNlWagxC2CIBtPzIYV4utC5YKWWVBmREsUUZX XnpleNT22mmld7iiruPpSG9i4+vTm7sAFTwWVnGa4LX7OKDiMYVwwGXmqS4eJZU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-type; s= smtpout; bh=PqUXRDCWVUeB6aq8d37lFTCfGxc=; b=H9bIEuOUubAoODA+r2bI ITUZ/6LPka9SbPs0kv5mUT8MY8Yk3/OyxNIFW0e8Tf9v1MfSAqjT5gSo/arEgGL6 QM48IZH9mSzbmg4ekKtqWwoIxy6NbUcCokDQfAdNdfGycwAgBGtckGAExRwwEgUJ DYkoBcM+DpPURitVpPB2Gw8= X-Sasl-enc: I9F1VqXeKX6LwxxXlF7jmu8skOjyS089MRqtSZ862N52 1425385392 Received: from IdeaPad.messagingengine.com (unknown [77.10.216.117]) by mail.messagingengine.com (Postfix) with ESMTPA id 5F761C002A3; Tue, 3 Mar 2015 07:23:12 -0500 (EST) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <87egp8rssg.fsf@fastmail.fm> <54F49954.6090502@gmx.at> <54F58F19.1070401@gmx.at> From: Joost Kremers To: martin rudalics Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) In-reply-to: <54F58F19.1070401@gmx.at> Date: Tue, 03 Mar 2015 13:23:10 +0100 Message-ID: <877fuys21d.fsf@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, Mar 03 2015, martin rudalics wrote: > > OK. The fix for Emacs 25 is attached. Please try it. > > Pushed as 2cc23f1..1903e25 master -> master. > > Please try again with most recent trunk/master. Current master (1903e25) fixes it. -- Joost Kremers Life has its moments From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 03 11:11:19 2015 Received: (at 19972) by debbugs.gnu.org; 3 Mar 2015 16:11:19 +0000 Received: from localhost ([127.0.0.1]:34086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSpPi-0003AI-Fg for submit@debbugs.gnu.org; Tue, 03 Mar 2015 11:11:18 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:56588) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSpPf-0003A3-Lw for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 11:11:16 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NKN005008XEFQ00@a-mtaout21.012.net.il> for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 18:11:09 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKN005UD8YKFE00@a-mtaout21.012.net.il>; Tue, 03 Mar 2015 18:11:09 +0200 (IST) Date: Tue, 03 Mar 2015 18:11:02 +0200 From: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) In-reply-to: X-012-Sender: halo1@inter.net.il To: "Jan D." Message-id: <837fuyqcx5.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: steve@sanityinc.com, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: "Jan D." > Date: Mon, 2 Mar 2015 21:19:14 +0100 > Cc: "steve@sanityinc.com" , > "19972@debbugs.gnu.org" <19972@debbugs.gnu.org> > > > I meant where/how does Emacs know that its request to resize was > > denied? > > When an X window is resized, it gets a ConfigureNotify event. When the resize is denied, no event arrives. That is why Emacs on X only considers ConfigureNotify as resizes. If lisp code tries to resize, we make the request, but nothing is updated until we get a ConfigureNotify. OK, thanks. But I don't see anything like that on MS-Windows: we do have a call to change_frame_size when we receive a WM_SIZE message, but running the recipe in this thread doesn't cause WM_SIZE to be received, and the call to change_frame_size, if it is done, comes via internal-set-lisp-face-attribute and modify-frame-parameters, i.e. directly from Lisp. (When the frame is maximized, change_frame_size is not called at all.) Martin, can you tell what is the equivalent of the above X processing on MS-Windows? Does Emacs implement a similar logic internally? From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 03 12:47:36 2015 Received: (at 19972) by debbugs.gnu.org; 3 Mar 2015 17:47:37 +0000 Received: from localhost ([127.0.0.1]:34164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSquu-0005Ww-F2 for submit@debbugs.gnu.org; Tue, 03 Mar 2015 12:47:36 -0500 Received: from mout.gmx.net ([212.227.17.20]:52113) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSqus-0005Wi-EQ for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 12:47:35 -0500 Received: from [88.117.57.151] ([88.117.57.151]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MdXSC-1Y7sgb0ZFk-00PKs0; Tue, 03 Mar 2015 18:47:25 +0100 Message-ID: <54F5F3A9.1090108@gmx.at> Date: Tue, 03 Mar 2015 18:47:21 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii , "Jan D." Subject: Re: bug#19972: Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> <837fuyqcx5.fsf@gnu.org> In-Reply-To: <837fuyqcx5.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:iX69yVMR8Hu8WQItHMNYOAN2hGoyVC//masL2R/kbInbKY1jIk3 xOexzwFnm7v80UZ/+FsvSH/cnRJqT5LJg7UjWFJ4Wop/pkuIiLPB5zELSeWM0brF69qL61L EmLAcKYMXw5roCSHzhVQcxeuf8bWin0sm0+XUOogLt7Ts//eMn1kSaYQLnqfhytCXQDSpBR 1ZkUz1xmjm9agWNzX1X8A== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: steve@sanityinc.com, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > But I don't see anything like that on MS-Windows: we do have a call to > change_frame_size when we receive a WM_SIZE message, but running the > recipe in this thread doesn't cause WM_SIZE to be received, There should be one for a normally sized frame. > and the > call to change_frame_size, if it is done, comes via > internal-set-lisp-face-attribute and modify-frame-parameters, > i.e. directly from Lisp. (When the frame is maximized, > change_frame_size is not called at all. Neither on X, hopefully ;-) > ) > > Martin, can you tell what is the equivalent of the above X processing > on MS-Windows? Does Emacs implement a similar logic internally? I'm not sure I understand what you mean. Basically, on Windows we process the sizes immediately when issuing a size request. "Process" in this context means to store the sizes in the frame structure and resize the frame's windows accordingly. We do that in the change_frame_size call on line 6173 of w32term.c (because Drew wanted to see the possible future effect immediately in the frame sizes). When Windows gets back to us via a WM_SIZE message we might eventually call change_frame_size too (on line 5180 of w32term.c) but do so only if the requested sizes differ from the already stored ones. The sizes usually differ when the request was initiated by Windows (like when the user clicks at the maximize button or mouse-drags a frame edge) and usually do not differ when the request was initiated by Lisp code before. On X we don't process the sizes immediately but rather loop until we get a notifcation event (similar to WM_SIZE) or a timeout expires. In the latter case the frame would have remained unchanged while on Windows it would have changed (due to the call of line 6173). So far I have not seen any inconsistencies on Windows. These would appear as decorations that are either too large or too small for our frame. In any case, a refusal to resize our window without any notification (like seen by the OP of the current thread on NS) would obviously hit us on Windows. When I asked you back then whether we could implement something similar to the X code on Windows you told me that Windows doesn't have anything comparable to ConfigureNotify so I didn't pursue the idea any further. If and when problems pop up with the current code we might have to reconsider that. martin From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 03 13:02:27 2015 Received: (at 19972) by debbugs.gnu.org; 3 Mar 2015 18:02:27 +0000 Received: from localhost ([127.0.0.1]:34195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSr9D-0005uj-Ka for submit@debbugs.gnu.org; Tue, 03 Mar 2015 13:02:27 -0500 Received: from mtaout27.012.net.il ([80.179.55.183]:45910) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSr98-0005u6-Sk for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 13:02:22 -0500 Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NKN00M00DJFJQ00@mtaout27.012.net.il> for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 19:56:44 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKN00H94DUKRJ60@mtaout27.012.net.il>; Tue, 03 Mar 2015 19:56:44 +0200 (IST) Date: Tue, 03 Mar 2015 20:02:05 +0200 From: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) In-reply-to: <54F5F3A9.1090108@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <83zj7uot7m.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> <837fuyqcx5.fsf@gnu.org> <54F5F3A9.1090108@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: steve@sanityinc.com, jan.h.d@swipnet.se, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Tue, 03 Mar 2015 18:47:21 +0100 > From: martin rudalics > CC: steve@sanityinc.com, 19972@debbugs.gnu.org > > > But I don't see anything like that on MS-Windows: we do have a call to > > change_frame_size when we receive a WM_SIZE message, but running the > > recipe in this thread doesn't cause WM_SIZE to be received, > > There should be one for a normally sized frame. We don't do anything with it, probably because the frame was already resized. > > Martin, can you tell what is the equivalent of the above X processing > > on MS-Windows? Does Emacs implement a similar logic internally? > > I'm not sure I understand what you mean. Basically, on Windows we > process the sizes immediately when issuing a size request. "Process" in > this context means to store the sizes in the frame structure and resize > the frame's windows accordingly. > > We do that in the change_frame_size call on line 6173 of w32term.c > (because Drew wanted to see the possible future effect immediately in > the frame sizes). When Windows gets back to us via a WM_SIZE message we > might eventually call change_frame_size too (on line 5180 of w32term.c) > but do so only if the requested sizes differ from the already stored > ones. The sizes usually differ when the request was initiated by > Windows (like when the user clicks at the maximize button or mouse-drags > a frame edge) and usually do not differ when the request was initiated > by Lisp code before. IOW, we don't wait with a resize until we get a notification, but instead resize the frame itself, and then might resize again when we receive WM_SIZE. Question: why not wait for WM_SIZE, and only resize after it arrives? That would emulate better what X does, and also prevent the second resize. No? > When I asked you back then whether we could implement something similar > to the X code on Windows you told me that Windows doesn't have anything > comparable to ConfigureNotify so I didn't pursue the idea any further. I don't remember saying that (and don't know X well enough to make such assertions to begin with), but in any case, you just explained that I was wrong, and there is a Windows message equivalent to ConfigureNotify. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 03 13:36:15 2015 Received: (at 19972) by debbugs.gnu.org; 3 Mar 2015 18:36:15 +0000 Received: from localhost ([127.0.0.1]:34216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSrfy-0006jT-TZ for submit@debbugs.gnu.org; Tue, 03 Mar 2015 13:36:15 -0500 Received: from mout.gmx.net ([212.227.17.22]:54979) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSrfx-0006jE-CD for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 13:36:14 -0500 Received: from [88.117.57.151] ([88.117.57.151]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MQih7-1Y3AtP031Z-00U5u5; Tue, 03 Mar 2015 19:36:06 +0100 Message-ID: <54F5FF12.10401@gmx.at> Date: Tue, 03 Mar 2015 19:36:02 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> <837fuyqcx5.fsf@gnu.org> <54F5F3A9.1090108@gmx.at> <83zj7uot7m.fsf@gnu.org> In-Reply-To: <83zj7uot7m.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:ccbnrQp3fcTCDdZm1peuC4XttzJmv/eOMZSxPBxlh1bfY50SD9o q0Rw7MAcXyYLe24JDOpbKmqJgZGb0j1drc0Z3Bf66nMcq2AbCV/9/7G1MRTRZm1mUDwEalD zMkwAOusGeoZFXomL4kCykw16pOghoeCWSULEjw0ic5l4DhOrXsZnl8gupGDaHzLLOirAZG ZBLMwOd6xAmrrBpyG6ohA== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: steve@sanityinc.com, jan.h.d@swipnet.se, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> There should be one for a normally sized frame. > > We don't do anything with it, probably because the frame was already > resized. Precisely. > IOW, we don't wait with a resize until we get a notification, but > instead resize the frame itself, and then might resize again when we > receive WM_SIZE. Question: why not wait for WM_SIZE, and only resize > after it arrives? That would emulate better what X does, and also > prevent the second resize. No? Usually there's no second resize because Windows does what we asked for. And the first resize is here to fix bug#16028. >> When I asked you back then whether we could implement something similar >> to the X code on Windows you told me that Windows doesn't have anything >> comparable to ConfigureNotify so I didn't pursue the idea any further. > > I don't remember saying that (and don't know X well enough to make > such assertions to begin with), but in any case, you just explained > that I was wrong, and there is a Windows message equivalent to > ConfigureNotify. Which? martin From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 03 13:39:11 2015 Received: (at 19972) by debbugs.gnu.org; 3 Mar 2015 18:39:11 +0000 Received: from localhost ([127.0.0.1]:34220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSrio-0006nv-Pt for submit@debbugs.gnu.org; Tue, 03 Mar 2015 13:39:11 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:49352) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSril-0006nK-CK for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 13:39:08 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NKN00K00FS7RH00@a-mtaout22.012.net.il> for 19972@debbugs.gnu.org; Tue, 03 Mar 2015 20:39:00 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKN00KZ1FT0QS00@a-mtaout22.012.net.il>; Tue, 03 Mar 2015 20:39:00 +0200 (IST) Date: Tue, 03 Mar 2015 20:38:53 +0200 From: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) In-reply-to: <54F5FF12.10401@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <83sidmoria.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> <837fuyqcx5.fsf@gnu.org> <54F5F3A9.1090108@gmx.at> <83zj7uot7m.fsf@gnu.org> <54F5FF12.10401@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: steve@sanityinc.com, jan.h.d@swipnet.se, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Tue, 03 Mar 2015 19:36:02 +0100 > From: martin rudalics > CC: jan.h.d@swipnet.se, steve@sanityinc.com, 19972@debbugs.gnu.org > > >> When I asked you back then whether we could implement something similar > >> to the X code on Windows you told me that Windows doesn't have anything > >> comparable to ConfigureNotify so I didn't pursue the idea any further. > > > > I don't remember saying that (and don't know X well enough to make > > such assertions to begin with), but in any case, you just explained > > that I was wrong, and there is a Windows message equivalent to > > ConfigureNotify. > > Which? WM_SIZE, no? From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 04 10:10:48 2015 Received: (at 19972) by debbugs.gnu.org; 4 Mar 2015 15:10:48 +0000 Received: from localhost ([127.0.0.1]:35137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTAwi-0005K8-04 for submit@debbugs.gnu.org; Wed, 04 Mar 2015 10:10:48 -0500 Received: from mout.gmx.net ([212.227.15.19]:55793) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTAwg-0005Jl-55 for 19972@debbugs.gnu.org; Wed, 04 Mar 2015 10:10:46 -0500 Received: from [88.117.118.171] ([88.117.118.171]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0LsCdj-1XU2hH3MVj-013sOH; Wed, 04 Mar 2015 16:10:36 +0100 Message-ID: <54F72068.2040401@gmx.at> Date: Wed, 04 Mar 2015 16:10:32 +0100 From: martin rudalics MIME-Version: 1.0 To: Joost Kremers Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <87egp8rssg.fsf@fastmail.fm> <54F49954.6090502@gmx.at> <54F58F19.1070401@gmx.at> <877fuys21d.fsf@fastmail.fm> In-Reply-To: <877fuys21d.fsf@fastmail.fm> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:eKassAFQ+tI8eJdJQyRwO/Bvq/Iu1dUbVVUXL9KA4onH9wAfNdw DB4LB35AXLWX05IatWdwdcbI9lRGWJGStlIJu3iEpFQ5Cx83gBp4GmPuJxD95FQOwQogQM4 ILLC5ISdipzz4U3aDxfcN164pcjGgHcU75/gT6A/07HZJfDhRLwEc+lm++sL0qpyWvMKl07 +SlbsVnvsa5Oj78SRvJZg== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Current master (1903e25) fixes it. Thanks for checking. I doubt that I will fix this for Emacs 24.5. If I'm not mistaken, this bug must have existed ever since. martin From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 04 10:11:01 2015 Received: (at 19972) by debbugs.gnu.org; 4 Mar 2015 15:11:01 +0000 Received: from localhost ([127.0.0.1]:35140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTAwv-0005KY-9U for submit@debbugs.gnu.org; Wed, 04 Mar 2015 10:11:01 -0500 Received: from mout.gmx.net ([212.227.15.15]:56263) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTAwt-0005KM-HB for 19972@debbugs.gnu.org; Wed, 04 Mar 2015 10:11:00 -0500 Received: from [88.117.118.171] ([88.117.118.171]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MO7ee-1YNhIJ1WJ2-005VzH; Wed, 04 Mar 2015 16:10:47 +0100 Message-ID: <54F72070.8040709@gmx.at> Date: Wed, 04 Mar 2015 16:10:40 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> <837fuyqcx5.fsf@gnu.org> <54F5F3A9.1090108@gmx.at> <83zj7uot7m.fsf@gnu.org> <54F5FF12.10401@gmx.at> <83sidmoria.fsf@gnu.org> In-Reply-To: <83sidmoria.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:m7eZ/+TrumYbWtLe3x0hTenfaLlru1zyXmvkvN2APoyRD96z30Z 1uxV5PdPdk3OKUaElWMNozpF5S7u8qPI1TjMelAkIznL93DL1/MpzmQTpnhYEXrcZyMBO+Z G9M2CglDRsopayz1isKUziV/foEQVEzct29RcyVnBd0G9YY8Lk8a/YY+GglOtelHwHzS4wD 5Dc6kEczQx62ZMluq504Q== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: steve@sanityinc.com, jan.h.d@swipnet.se, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> Which? > > WM_SIZE, no? Hmmm... I have to think this over. martin From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 04 12:47:31 2015 Received: (at 19972) by debbugs.gnu.org; 4 Mar 2015 17:47:31 +0000 Received: from localhost ([127.0.0.1]:35217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTDOM-00022w-RK for submit@debbugs.gnu.org; Wed, 04 Mar 2015 12:47:31 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:42643) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTDOK-00022i-UQ for 19972@debbugs.gnu.org; Wed, 04 Mar 2015 12:47:30 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NKP008007V45800@a-mtaout22.012.net.il> for 19972@debbugs.gnu.org; Wed, 04 Mar 2015 19:47:22 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKP0086M82W3K30@a-mtaout22.012.net.il>; Wed, 04 Mar 2015 19:47:22 +0200 (IST) Date: Wed, 04 Mar 2015 19:47:16 +0200 From: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) In-reply-to: <54F72070.8040709@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <83fv9kpsd7.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> <837fuyqcx5.fsf@gnu.org> <54F5F3A9.1090108@gmx.at> <83zj7uot7m.fsf@gnu.org> <54F5FF12.10401@gmx.at> <83sidmoria.fsf@gnu.org> <54F72070.8040709@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: steve@sanityinc.com, jan.h.d@swipnet.se, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Wed, 04 Mar 2015 16:10:40 +0100 > From: martin rudalics > CC: jan.h.d@swipnet.se, steve@sanityinc.com, 19972@debbugs.gnu.org > > >> Which? > > > > WM_SIZE, no? > > Hmmm... I have to think this over. Feel free to ignore, btw. But to clarify, what I had in mind was call MoveWindow, and wait for WM_SIZE before we call change_frame_size. I have no idea whether this is a good idea, though. But in any case, are you saying that if we call change_frame_size with dimensions that Windows doesn't like (can that happen?), then we will get a WM_SIZE message telling us to change the size to something else? Does this really happen under some conditions? From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 04 13:45:57 2015 Received: (at 19972) by debbugs.gnu.org; 4 Mar 2015 18:45:57 +0000 Received: from localhost ([127.0.0.1]:35249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTEIv-0003Qv-3E for submit@debbugs.gnu.org; Wed, 04 Mar 2015 13:45:57 -0500 Received: from mout.gmx.net ([212.227.17.20]:50525) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTEIt-0003Qj-6P for 19972@debbugs.gnu.org; Wed, 04 Mar 2015 13:45:55 -0500 Received: from [88.117.118.171] ([88.117.118.171]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MPppG-1YOGDb32TS-0050TI; Wed, 04 Mar 2015 19:45:45 +0100 Message-ID: <54F752D3.7050800@gmx.at> Date: Wed, 04 Mar 2015 19:45:39 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> <837fuyqcx5.fsf@gnu.org> <54F5F3A9.1090108@gmx.at> <83zj7uot7m.fsf@gnu.org> <54F5FF12.10401@gmx.at> <83sidmoria.fsf@gnu.org> <54F72070.8040709@gmx.at> <83fv9kpsd7.fsf@gnu.org> In-Reply-To: <83fv9kpsd7.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:ntAvG3dyoaizcFER7WrsENo++GB7Z95abhqi5D5na95SqFERpua mNI2TvUKBu891NvwtTkcVWtnkVE8CV6y4gVmd0ewoxFi5O8T4So7gK8DsfrfwqTt/4He80j JBOAEyZRu7HXmuUPU5MDjPOo95QCJ3w8gg5/u15CLrl3RaEdofJxDCP7qm22XEgDd6zX/fS qW19w+szCe0I69h1zVjlQ== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: steve@sanityinc.com, jan.h.d@swipnet.se, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Feel free to ignore, btw. But to clarify, what I had in mind was call > MoveWindow, and wait for WM_SIZE before we call change_frame_size. I > have no idea whether this is a good idea, though. It's not the idea that bothers me but the implementation. Looking at what Jan did in x_wait_for_event it seems very unlikely that I could come up with an equivalent solution. Think of the input un-/blocking part: int level = interrupt_input_blocked; ... while (f->wait_event_type) { pending_signals = true; totally_unblock_input (); /* XTread_socket is called after unblock. */ block_input (); interrupt_input_blocked = level; Would this work on Windows? And on Gtk he does (void)gtk_events_pending (); gdk_flush (); before calling x_wait_for_event. Would we have to flush old messages on Windows and if so how? All this is probably over my head. > But in any case, are you saying that if we call change_frame_size with > dimensions that Windows doesn't like (can that happen? I'm quite confident that Drew will eventually come up with an appropriate scenario. > ), then we will > get a WM_SIZE message telling us to change the size to something else? > Does this really happen under some conditions? ISTR that I was suprised by Windows once or twice doing that but I can't give you any details any more. Windows is very attentive in this regard. OTOH it is by far the most permissive system wrt which changes it allows. martin From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 04 13:59:45 2015 Received: (at 19972) by debbugs.gnu.org; 4 Mar 2015 18:59:45 +0000 Received: from localhost ([127.0.0.1]:35263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTEWG-0003lW-Sc for submit@debbugs.gnu.org; Wed, 04 Mar 2015 13:59:45 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:44765) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTEWD-0003lI-OD for 19972@debbugs.gnu.org; Wed, 04 Mar 2015 13:59:43 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NKP00B00BDOZ000@a-mtaout20.012.net.il> for 19972@debbugs.gnu.org; Wed, 04 Mar 2015 20:59:34 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKP00BY3BFALAD0@a-mtaout20.012.net.il>; Wed, 04 Mar 2015 20:59:34 +0200 (IST) Date: Wed, 04 Mar 2015 20:59:30 +0200 From: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) In-reply-to: <54F752D3.7050800@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <838ufcpp0t.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> <837fuyqcx5.fsf@gnu.org> <54F5F3A9.1090108@gmx.at> <83zj7uot7m.fsf@gnu.org> <54F5FF12.10401@gmx.at> <83sidmoria.fsf@gnu.org> <54F72070.8040709@gmx.at> <83fv9kpsd7.fsf@gnu.org> <54F752D3.7050800@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: steve@sanityinc.com, jan.h.d@swipnet.se, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Wed, 04 Mar 2015 19:45:39 +0100 > From: martin rudalics > CC: jan.h.d@swipnet.se, steve@sanityinc.com, 19972@debbugs.gnu.org > > > Feel free to ignore, btw. But to clarify, what I had in mind was call > > MoveWindow, and wait for WM_SIZE before we call change_frame_size. I > > have no idea whether this is a good idea, though. > > It's not the idea that bothers me but the implementation. Looking at > what Jan did in x_wait_for_event it seems very unlikely that I could > come up with an equivalent solution. Think of the input un-/blocking > part: > > int level = interrupt_input_blocked; > ... > while (f->wait_event_type) > { > pending_signals = true; > totally_unblock_input (); > /* XTread_socket is called after unblock. */ > block_input (); > interrupt_input_blocked = level; > > Would this work on Windows? And on Gtk he does > > (void)gtk_events_pending (); > gdk_flush (); > > before calling x_wait_for_event. Would we have to flush old messages on > Windows and if so how? All this is probably over my head. I don't see why do we have to block and wait. Why not simply go about our business, and let the WM_SIZE message come in when it does, and be handled? From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 04 14:25:24 2015 Received: (at 19972) by debbugs.gnu.org; 4 Mar 2015 19:25:24 +0000 Received: from localhost ([127.0.0.1]:35283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTEv5-0004Pj-Rs for submit@debbugs.gnu.org; Wed, 04 Mar 2015 14:25:24 -0500 Received: from mailfe03.swip.net ([212.247.154.65]:35477 helo=swip.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTEv4-0004PU-8g for 19972@debbugs.gnu.org; Wed, 04 Mar 2015 14:25:22 -0500 X-T2-Spam-Status: No, hits=0.8 required=5.0 tests=BAYES_50 Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe03.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 411171663; Wed, 04 Mar 2015 20:25:13 +0100 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: bug#19972: Font size change doesn't update (window-total-width) From: "Jan D." In-Reply-To: <838ufcpp0t.fsf@gnu.org> Date: Wed, 4 Mar 2015 20:25:12 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <1441AB4F-ADD5-49F2-A78F-DE3D1CB66AD4@swipnet.se> References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> <837fuyqcx5.fsf@gnu.org> <54F5F3A9.1090108@gmx.at> <83zj7uot7m.fsf@gnu.org> <54F5FF12.10401@gmx.at> <83sidmoria.fsf@gnu.org> <54F72070.8040709@gmx.at> <83fv9kpsd7.fsf@gnu.org> <54F752D3.7050800@gmx.at> <838ufcpp0t.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.2070.6) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: martin rudalics , 19972@debbugs.gnu.org, steve@sanityinc.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi. > 4 mar 2015 kl. 19:59 skrev Eli Zaretskii : >=20 > I don't see why do we have to block and wait. Why not simply go about > our business, and let the WM_SIZE message come in when it does, and be > handled? x_wait_for_event is only to try to cater for Lisp code that expects a = resize to occur at once. I think there was a bug for it. In general, X (and NS) does go about its business and wait for the = equivalent of WM_SIZE to arrive. There is no=20 corresponding x_wait_for_event in NS, so it does just that. Jan D. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 05 03:06:41 2015 Received: (at 19972) by debbugs.gnu.org; 5 Mar 2015 08:06:41 +0000 Received: from localhost ([127.0.0.1]:35549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTQnp-0005iP-7J for submit@debbugs.gnu.org; Thu, 05 Mar 2015 03:06:41 -0500 Received: from mout.gmx.net ([212.227.17.21]:54738) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTQnn-0005iA-Ea for 19972@debbugs.gnu.org; Thu, 05 Mar 2015 03:06:39 -0500 Received: from [62.47.255.182] ([62.47.255.182]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MHrk1-1YSav71aV3-003h7m; Thu, 05 Mar 2015 09:06:32 +0100 Message-ID: <54F80E7D.8050303@gmx.at> Date: Thu, 05 Mar 2015 09:06:21 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> <837fuyqcx5.fsf@gnu.org> <54F5F3A9.1090108@gmx.at> <83zj7uot7m.fsf@gnu.org> <54F5FF12.10401@gmx.at> <83sidmoria.fsf@gnu.org> <54F72070.8040709@gmx.at> <83fv9kpsd7.fsf@gnu.org> <54F752D3.7050800@gmx.at> <838ufcpp0t.fsf@gnu.org> In-Reply-To: <838ufcpp0t.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:/gkwv/TzvJr1QywU+BOwEesLE5DftnjvTbhNEyPxgEvYH7DQLhZ wKiNSJsQWDmr8ZkHlAR94tXrp+69L/TTld51j8sg5jSV1FSE4U+V2gR1d7Scl5Ac4Po3nt4 3GKnNMD8w/Bpq8VmN9zFLRXmfpqb5OV4VRZptjRnDP3mwTXKjalJT1Xk8kyW8SpX82G0bir WjwOQQX1/Lro6t1v/XpWA== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: steve@sanityinc.com, jan.h.d@swipnet.se, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > I don't see why do we have to block and wait. Why not simply go about > our business, and let the WM_SIZE message come in when it does, and be > handled? Because of Bug#16028 :-( martin From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 05 11:35:05 2015 Received: (at 19972) by debbugs.gnu.org; 5 Mar 2015 16:35:05 +0000 Received: from localhost ([127.0.0.1]:36163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTYjp-0005tF-A0 for submit@debbugs.gnu.org; Thu, 05 Mar 2015 11:35:05 -0500 Received: from mtaout28.012.net.il ([80.179.55.184]:33404) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTYjm-0005sf-C4 for 19972@debbugs.gnu.org; Thu, 05 Mar 2015 11:35:03 -0500 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NKQ00500Z6H2900@mtaout28.012.net.il> for 19972@debbugs.gnu.org; Thu, 05 Mar 2015 18:33:22 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKQ00M4AZBM2480@mtaout28.012.net.il>; Thu, 05 Mar 2015 18:33:22 +0200 (IST) Date: Thu, 05 Mar 2015 18:34:55 +0200 From: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) In-reply-to: <54F80E7D.8050303@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <834mpzpfm8.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> <837fuyqcx5.fsf@gnu.org> <54F5F3A9.1090108@gmx.at> <83zj7uot7m.fsf@gnu.org> <54F5FF12.10401@gmx.at> <83sidmoria.fsf@gnu.org> <54F72070.8040709@gmx.at> <83fv9kpsd7.fsf@gnu.org> <54F752D3.7050800@gmx.at> <838ufcpp0t.fsf@gnu.org> <54F80E7D.8050303@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: steve@sanityinc.com, jan.h.d@swipnet.se, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Thu, 05 Mar 2015 09:06:21 +0100 > From: martin rudalics > CC: jan.h.d@swipnet.se, steve@sanityinc.com, 19972@debbugs.gnu.org > > > I don't see why do we have to block and wait. Why not simply go about > > our business, and let the WM_SIZE message come in when it does, and be > > handled? > > Because of Bug#16028 :-( Which part of that bug disallows the above? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 05 13:14:55 2015 Received: (at 19972) by debbugs.gnu.org; 5 Mar 2015 18:14:56 +0000 Received: from localhost ([127.0.0.1]:36244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTaIR-0001cd-FI for submit@debbugs.gnu.org; Thu, 05 Mar 2015 13:14:55 -0500 Received: from mout.gmx.net ([212.227.17.20]:60335) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTaIP-0001cN-7s for 19972@debbugs.gnu.org; Thu, 05 Mar 2015 13:14:53 -0500 Received: from [194.166.87.46] ([194.166.87.46]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MTSmp-1Y5D9t2NCp-00SSEK; Thu, 05 Mar 2015 19:14:46 +0100 Message-ID: <54F89D0F.9000205@gmx.at> Date: Thu, 05 Mar 2015 19:14:39 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> <837fuyqcx5.fsf@gnu.org> <54F5F3A9.1090108@gmx.at> <83zj7uot7m.fsf@gnu.org> <54F5FF12.10401@gmx.at> <83sidmoria.fsf@gnu.org> <54F72070.8040709@gmx.at> <83fv9kpsd7.fsf@gnu.org> <54F752D3.7050800@gmx.at> <838ufcpp0t.fsf@gnu.org> <54F80E7D.8050303@gmx.at> <834mpzpfm8.fsf@gnu.org> In-Reply-To: <834mpzpfm8.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:9cTAlW8xd1PEkXU04tsYr3oVazxyZqrsoh6O/xDIiZJAyNOJ7VQ HlzUBQhNVI+Jm64wiy0zq3cSUebG+oev8p1p2e/ezMtjNJLyWfQzsf76XoE6NtbiCg/DHRn rM+e/Qx0+G/3wFVxp7rEzj5CCAWTN83+LzFBZFpj9dDp6Fn1/AjK6jzFsbNVzOL4SF8IeRj 1UzofVv1lQiC5prrbMRUQ== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: steve@sanityinc.com, jan.h.d@swipnet.se, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> > I don't see why do we have to block and wait. Why not simply go about >> > our business, and let the WM_SIZE message come in when it does, and be >> > handled? >> >> Because of Bug#16028 :-( > > Which part of that bug disallows the above? Well, before the "fix" of bug#16028 Emacs behaved as you described above. Suppose an application wants to add 5 lines and 5 columns to a frame. It can do that in one call (set-frame-size nil (+ (frame-width) 5) (+ (frame-height) 5)) or via (progn (set-frame-width nil (+ (frame-width) 5)) (set-frame-height nil (+ (frame-height) 5))) I suppose that most people would consider these forms idempotent. However, before the fix, `set-frame-height' could fail because Emacs has to tell Windows (via AdjustWindowRect) what the desired window width is. But the width Emacs knows about at that time is still that from before the `set-frame-width' call. On X this scenario doesn't fail because Emacs usually loops long enough until the width value has been updated. I don't know how NS handles it. Similar scenarios can be devised when changing any of the values affected by `frame-inhibit-implied-resize'. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 05 15:22:48 2015 Received: (at 19972) by debbugs.gnu.org; 5 Mar 2015 20:22:48 +0000 Received: from localhost ([127.0.0.1]:36452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTcIB-00058p-VG for submit@debbugs.gnu.org; Thu, 05 Mar 2015 15:22:48 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]:59892) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTcI9-00058a-GQ for 19972@debbugs.gnu.org; Thu, 05 Mar 2015 15:22:46 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NKR00H009ECO700@a-mtaout23.012.net.il> for 19972@debbugs.gnu.org; Thu, 05 Mar 2015 22:22:39 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKR00H0L9XQN640@a-mtaout23.012.net.il>; Thu, 05 Mar 2015 22:22:39 +0200 (IST) Date: Thu, 05 Mar 2015 22:22:38 +0200 From: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) In-reply-to: <54F89D0F.9000205@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <83pp8nnqi9.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> <837fuyqcx5.fsf@gnu.org> <54F5F3A9.1090108@gmx.at> <83zj7uot7m.fsf@gnu.org> <54F5FF12.10401@gmx.at> <83sidmoria.fsf@gnu.org> <54F72070.8040709@gmx.at> <83fv9kpsd7.fsf@gnu.org> <54F752D3.7050800@gmx.at> <838ufcpp0t.fsf@gnu.org> <54F80E7D.8050303@gmx.at> <834mpzpfm8.fsf@gnu.org> <54F89D0F.9000205@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: steve@sanityinc.com, jan.h.d@swipnet.se, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Thu, 05 Mar 2015 19:14:39 +0100 > From: martin rudalics > CC: jan.h.d@swipnet.se, steve@sanityinc.com, 19972@debbugs.gnu.org > > Suppose an application wants to add 5 lines and 5 columns to a frame. > It can do that in one call > > (set-frame-size nil (+ (frame-width) 5) (+ (frame-height) 5)) > > or via > > (progn > (set-frame-width nil (+ (frame-width) 5)) > (set-frame-height nil (+ (frame-height) 5))) > > I suppose that most people would consider these forms idempotent. > > However, before the fix, `set-frame-height' could fail because Emacs has > to tell Windows (via AdjustWindowRect) what the desired window width is. > But the width Emacs knows about at that time is still that from before > the `set-frame-width' call. Did we try back then to sleep a few tens of milliseconds after each such call? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 05 16:15:53 2015 Received: (at 19972) by debbugs.gnu.org; 5 Mar 2015 21:15:53 +0000 Received: from localhost ([127.0.0.1]:36472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTd7Z-0006bG-9B for submit@debbugs.gnu.org; Thu, 05 Mar 2015 16:15:53 -0500 Received: from mout.gmx.net ([212.227.17.22]:65000) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTd7W-0006b1-Th for 19972@debbugs.gnu.org; Thu, 05 Mar 2015 16:15:51 -0500 Received: from [194.166.86.230] ([194.166.86.230]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MZwYd-1YBgj908wZ-00Lo5D; Thu, 05 Mar 2015 22:15:28 +0100 Message-ID: <54F8C768.1080400@gmx.at> Date: Thu, 05 Mar 2015 22:15:20 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> <837fuyqcx5.fsf@gnu.org> <54F5F3A9.1090108@gmx.at> <83zj7uot7m.fsf@gnu.org> <54F5FF12.10401@gmx.at> <83sidmoria.fsf@gnu.org> <54F72070.8040709@gmx.at> <83fv9kpsd7.fsf@gnu.org> <54F752D3.7050800@gmx.at> <838ufcpp0t.fsf@gnu.org> <54F80E7D.8050303@gmx.at> <834mpzpfm8.fsf@gnu.org> <54F89D0F.9000205@gmx.at> <83pp8nnqi9.fsf@gnu.org> In-Reply-To: <83pp8nnqi9.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:I5+pkNjNoDsidMiE3RNxCCzNRGHiJheBFneO1at0hnhD2PkOlBv OR1+qM1xcjR49GwC8AlaE4UfWzWo2cw1ju6sGj/wSgWVwFD2SPcnwixhZ/UqwP7s4y336LQ 0iRYD5rEb4VvFNE2i4tj45ePh0EVG80Hdq42bvy/ZwJAoPiCsMqwg2stFZU1aA+RSViR8f3 uvhBT7FgJw0ERQA1j39+g== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: steve@sanityinc.com, jan.h.d@swipnet.se, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Did we try back then to sleep a few tens of milliseconds after each > such call? On Windows never. On X we do so since Jan's change from 2009-10-21. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 06 03:09:27 2015 Received: (at 19972) by debbugs.gnu.org; 6 Mar 2015 08:09:27 +0000 Received: from localhost ([127.0.0.1]:36756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTnK2-00038j-KH for submit@debbugs.gnu.org; Fri, 06 Mar 2015 03:09:26 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]:50151) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTnJz-00038R-QS for 19972@debbugs.gnu.org; Fri, 06 Mar 2015 03:09:25 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NKS00J0069WD900@a-mtaout23.012.net.il> for 19972@debbugs.gnu.org; Fri, 06 Mar 2015 10:09:17 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKS00JG16NG9U90@a-mtaout23.012.net.il>; Fri, 06 Mar 2015 10:09:17 +0200 (IST) Date: Fri, 06 Mar 2015 10:09:18 +0200 From: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) In-reply-to: <54F8C768.1080400@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <83mw3qo8cx.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> <837fuyqcx5.fsf@gnu.org> <54F5F3A9.1090108@gmx.at> <83zj7uot7m.fsf@gnu.org> <54F5FF12.10401@gmx.at> <83sidmoria.fsf@gnu.org> <54F72070.8040709@gmx.at> <83fv9kpsd7.fsf@gnu.org> <54F752D3.7050800@gmx.at> <838ufcpp0t.fsf@gnu.org> <54F80E7D.8050303@gmx.at> <834mpzpfm8.fsf@gnu.org> <54F89D0F.9000205@gmx.at> <83pp8nnqi9.fsf@gnu.org> <54F8C768.1080400@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: steve@sanityinc.com, jan.h.d@swipnet.se, 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Thu, 05 Mar 2015 22:15:20 +0100 > From: martin rudalics > CC: jan.h.d@swipnet.se, steve@sanityinc.com, 19972@debbugs.gnu.org > > > Did we try back then to sleep a few tens of milliseconds after each > > such call? > > On Windows never. Maybe we should. Just sleeping 20 milliseconds, say, shouldn't be a problem when resizing is in progress. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 06 04:21:46 2015 Received: (at 19972) by debbugs.gnu.org; 6 Mar 2015 09:21:46 +0000 Received: from localhost ([127.0.0.1]:36826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YToS2-00057I-Fu for submit@debbugs.gnu.org; Fri, 06 Mar 2015 04:21:46 -0500 Received: from mout.gmx.net ([212.227.17.20]:56902) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YToS0-000575-Ta for 19972@debbugs.gnu.org; Fri, 06 Mar 2015 04:21:45 -0500 Received: from [91.113.0.241] ([91.113.0.241]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MfVzj-1Y5oUN0gqR-00P69V; Fri, 06 Mar 2015 10:21:36 +0100 Message-ID: <54F97198.5060404@gmx.at> Date: Fri, 06 Mar 2015 10:21:28 +0100 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> <837fuyqcx5.fsf@gnu.org> <54F5F3A9.1090108@gmx.at> <83zj7uot7m.fsf@gnu.org> <54F5FF12.10401@gmx.at> <83sidmoria.fsf@gnu.org> <54F72070.8040709@gmx.at> <83fv9kpsd7.fsf@gnu.org> <54F752D3.7050800@gmx.at> <838ufcpp0t.fsf@gnu.org> <54F80E7D.8050303@gmx.at> <834mpzpfm8.fsf@gnu.org> <54F89D0F.9000205@gmx.at> <83pp8nnqi9.fsf@gnu.org> <54F8C768.1080400@gmx.at> <83mw3qo8cx.fsf@gnu.org> In-Reply-To: <83mw3qo8cx.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:oAgKhQyPPsytsrM4+s2N6wUr9Qb1ylaHw0ueqQ4nZJAgqb4+axn p9j7f2MlT+62ORR+7hKarNDEb5JKRvw7rV3yLaZcQj93txfjHdGIQRGx6KQvQfY5RoyOE7e v+5ujxnah9/4eIwlz0WdXEl4Xj999dfR4Sl215x3h8BIsswP3ATpJcqBI8b2dCpKtRw7ysb XRQmZESma/P8/6tgzKgGw== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Maybe we should. Just sleeping 20 milliseconds, say, shouldn't be a > problem when resizing is in progress. Looking at x_wait_for_event I wonder what the Windows equivalents for event->type and ConnectionNumber might be. If only you could come up with some preliminary code ... martin From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 06 05:58:17 2015 Received: (at 19972) by debbugs.gnu.org; 6 Mar 2015 10:58:17 +0000 Received: from localhost ([127.0.0.1]:36893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTpxR-0007iZ-7M for submit@debbugs.gnu.org; Fri, 06 Mar 2015 05:58:17 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:41328) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTpxO-0007iJ-Ed for 19972@debbugs.gnu.org; Fri, 06 Mar 2015 05:58:15 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NKS00200ECPCI00@a-mtaout22.012.net.il> for 19972@debbugs.gnu.org; Fri, 06 Mar 2015 12:58:08 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKS002BNEGV9O30@a-mtaout22.012.net.il>; Fri, 06 Mar 2015 12:58:08 +0200 (IST) Date: Fri, 06 Mar 2015 12:58:09 +0200 From: Eli Zaretskii Subject: Re: bug#19972: Font size change doesn't update (window-total-width) In-reply-to: <54F97198.5060404@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <837fuuo0ji.fsf@gnu.org> References: <874mq5o3di.fsf@fastmail.fm> <2B9A60CD-AAAA-40E8-B116-8A75A78B0DDC@sanityinc.com> <83bnkbsf5u.fsf@gnu.org> <54F4A120.2060506@swipnet.se> <83r3t7qo5b.fsf@gnu.org> <54F4B4CF.90905@swipnet.se> <83lhjfqira.fsf@gnu.org> <837fuyqcx5.fsf@gnu.org> <54F5F3A9.1090108@gmx.at> <83zj7uot7m.fsf@gnu.org> <54F5FF12.10401@gmx.at> <83sidmoria.fsf@gnu.org> <54F72070.8040709@gmx.at> <83fv9kpsd7.fsf@gnu.org> <54F752D3.7050800@gmx.at> <838ufcpp0t.fsf@gnu.org> <54F80E7D.8050303@gmx.at> <834mpzpfm8.fsf@gnu.org> <54F89D0F.9000205@gmx.at> <83pp8nnqi9.fsf@gnu.org> <54F8C768.1080400@gmx.at> <83mw3qo8cx.fsf@gnu.org> <54F97198.5060404@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19972 Cc: 19972@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Fri, 06 Mar 2015 10:21:28 +0100 > From: martin rudalics > CC: 19972@debbugs.gnu.org > > > Maybe we should. Just sleeping 20 milliseconds, say, shouldn't be a > > problem when resizing is in progress. > > Looking at x_wait_for_event I wonder what the Windows equivalents for > event->type and ConnectionNumber might be. Maybe I'm missing something obvious, but the Windows equivalent of event->type quite clearly seems to be the WM_* messages handled by w32_read_socket. As for ConnectionNumber: Windows doesn't have any such thing, since we only support a single "X display" on Windows. > If only you could come up with some preliminary code ... I don't think I will have time for that, sorry. And that's not a big loss, since I'm hardly an expert on this stuff. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 02 04:48:21 2017 Received: (at 19972-done) by debbugs.gnu.org; 2 Oct 2017 08:48:21 +0000 Received: from localhost ([127.0.0.1]:43423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dywOj-0005KW-Cb for submit@debbugs.gnu.org; Mon, 02 Oct 2017 04:48:21 -0400 Received: from mout.gmx.net ([212.227.15.15]:60908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dywOi-0005KI-5K for 19972-done@debbugs.gnu.org; Mon, 02 Oct 2017 04:48:20 -0400 Received: from [192.168.1.100] ([46.125.250.7]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LrvWY-1dKXh63nsk-013eJ5; Mon, 02 Oct 2017 10:48:11 +0200 Message-ID: <59D1FD43.7000901@gmx.at> Date: Mon, 02 Oct 2017 10:48:03 +0200 From: martin rudalics MIME-Version: 1.0 To: Joost Kremers Subject: Re: bug#19972: 24.4; Font size change doesn't update (window-total-width) References: <874mq5o3di.fsf@fastmail.fm> <54F32CDE.9080308@gmx.at> <87egp8rssg.fsf@fastmail.fm> <54F49954.6090502@gmx.at> <54F58F19.1070401@gmx.at> <877fuys21d.fsf@fastmail.fm> <54F72068.2040401@gmx.at> In-Reply-To: <54F72068.2040401@gmx.at> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:q0Qat6fWSD+lydN0sx/UoAa9aTmgm4PJxcY1CEB8XrkvpEWKEKt a3yrEv8/KtCSLrGtco12TVawBfiTY7hIBLeNney+VkCo/BF/8Jg45N8fm1+ePvMR7aC/WJj VSE4PDgWMOQ5h47VQDMJXajk0yVfz4JUjuAu6dBXMazlEJkCxvaI3gx8PjHcLYq2Dm0xxOE AJRWKlMqBqd5csyXpy6JA== X-UI-Out-Filterresults: notjunk:1;V01:K0:iwxW6iv6e6k=:ziiwGMsBN+6AOJ9ZmDMptC ZoUynCrLRMW9egHXux1rYGGyprBjNI5n/ignblicijteWsjFpOdlM3O0q+9kViT9BChPMbdB0 TcXbdUcuET6qzbdDa6SkPs9zWNKE39lgQvrCsox2H+vgaRwunp8qBh3xkWs1WCmElbEZbxQ3y OJ5LAZPI9KvVRcRdouViv8+I/GxU97g6hwqGDrbGG1cs8PBSNdWOFFaVIiwderfvapmWsayrx W6zTHuE+SKjxVIasYV3ovBSvLNYRsIUziENwA8fKcQ0lG8+onED+ilp6nxbk4p1jNCFw2Bj9z 4TMmCMPdTHkpJMTKU0sBe1W1jcEhLuR+5X9XeWnhvADxj40//N5KPg723n0s1/gAIv1inluM3 K8WhAPLp04+9BjkG4ASsgcrfpJjlF85j/Xt1oM5kJK6p0GnAywYmysMauRDAqEXVeojREr2Xv 8w4kc9kr3E89UWQ5Be16cLta9/YRh3Kn7IYpkNniVL+k3qWwj3U7+1CnRCVBn4nuUqc21Bkxo VpJlkoRtBG4EvIVY6Kh0RgVCH7q+ge4KOE7lixTLZlnRMRx4bGSsQCWyqDo8rQ6BcpfALJEj2 7Tv7bRAuS+dVpP5oCvSZS5DXX3hRMDWbQyklqiYqw7MyBv4zA8pytu5QbF3tM7+/2lOJJdkIW bSBtK3y4dSu8wqZZChQVctCs8Y/ZIda4l55RKVh/MQhQDHBPZxHTlNBUb7a/rKoaY25LeJoqD G7ODfyDTOb40nkpypShDwZbOvf7sWGF5dpD0yr/hxNWKFkAsj1ju9jkxRKiG/4BFY3ei2hYA7 XshSb+sCGX8vMfowgZadkNQyx26+3yBNBqfh124VTKvy+KbMDMtnWqy/VW8PfBpqxWnKoWg X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 19972-done Cc: 19972-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) > > Current master (1903e25) fixes it. > > Thanks for checking. I doubt that I will fix this for Emacs 24.5. If > I'm not mistaken, this bug must have existed ever since. Closing this bug which should have been fixed with Emacs 25 long ago. Thanks, martin From unknown Sat Aug 09 13:08:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 30 Oct 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator