GNU bug report logs - #19954
python.el: more consistent sexp navigation

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19954 in the body.
You can then email your comments to 19954 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Carlos Pita <carlosjosepita <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: python.el: more consistent sexp navigation
Date: Thu, 26 Feb 2015 14:26:04 -0300

X-Debbugs-CC: fgallina <at> gnu.org

If this is a feature I recognize I don't understand the rationally
behind it:

        [...]
            (and (not forward-p)
                 (eq (syntax-class (syntax-after (1- (point))))
                     (car (string-to-syntax ")")))))
        ;; Inside a paren or looking at it, lisp knows what to do.

Say * is the point. The inconsistency I find is that C-M-left will do
very different things while at the end of different lines:

A)
from sklearn.cross_validation import KFold*
-->
*from sklearn.cross_validation import KFold

B)
n = len(train.y)*
-->
n = len*(train.y)

I think the intention is to nav at the "statement/block level" when the point
is at the end of the line. The difference of behaviour between A and B
can't be reconciled at any level: sexp, list, statement, block. My
expectation would be:

B')
n = len(train.y)*
-->
*n = len(train.y)

B'')
n = len(train.y*)
-->
n = len(train.*y)

Notice that this is even more conspicuous at the end of a block:

C)
for x in range(0, 10):
    x = 2
    print("hello")*
-->
for x in range(0, 10):
    x = 2
    print*("hello")

D)
for x in range(0, 10):
    print("hello")
    x = 2*
-->
*for x in range(0, 10):
    print("hello")
    x = 2

I vote for removing the (syntax-after (1- (point)) special case as IMO
it only adds confussion to the already complex nav rules.

Cheers
--
Carlos

Message #10 received at 19954-done <at> debbugs.gnu.org (full text, mbox):

From: fgallina <at> gnu.org (Fabián Ezequiel Gallina)
To: 19954-done <at> debbugs.gnu.org
Subject: python.el: more consistent sexp navigation
Date: Sun, 12 Apr 2015 22:44:52 -0300

Fixed at 659609d in the master branch.

Thanks,
Fabián.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.