From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 22 13:19:12 2015 Received: (at submit) by debbugs.gnu.org; 22 Feb 2015 18:19:12 +0000 Received: from localhost ([127.0.0.1]:50829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YPb7X-0002ii-DJ for submit@debbugs.gnu.org; Sun, 22 Feb 2015 13:19:12 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46157) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YPb7U-0002iZ-HF for submit@debbugs.gnu.org; Sun, 22 Feb 2015 13:19:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YPb7S-0008If-Gi for submit@debbugs.gnu.org; Sun, 22 Feb 2015 13:19:08 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPb7S-0008Ib-DU for submit@debbugs.gnu.org; Sun, 22 Feb 2015 13:19:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPb7Q-0004Jg-La for bug-gnu-emacs@gnu.org; Sun, 22 Feb 2015 13:19:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YPb7K-0008Gz-Du for bug-gnu-emacs@gnu.org; Sun, 22 Feb 2015 13:19:04 -0500 Received: from mout.gmx.com ([74.208.4.200]:50436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPb7K-0008GY-7N for bug-gnu-emacs@gnu.org; Sun, 22 Feb 2015 13:18:58 -0500 Received: from [10.201.12.185] ([47.21.4.242]) by mail.gmx.com (mrgmxus002) with ESMTPSA (Nemesis) id 0M70Cp-1Xel7d0hbp-00wlNQ for ; Sun, 22 Feb 2015 19:18:56 +0100 Message-ID: <54EA1A7F.60701@gmx.com> Date: Sun, 22 Feb 2015 13:05:51 -0500 From: Boruch Baum User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: 24.4: diredp-do-bookmark fails: claims "Wrong number of arguments" OpenPGP: url=hkp://keys.gnupg.net Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CKbetQjAbPfbc3WKCkOa61cGek3Ln3Th4" X-Provags-ID: V03:K0:MdrRaVe9+McUbi0by13YGs5o/GqJ81yKVuykIsYTPO2SATLWm/d ozalGbmdaH8IzdEIFssCCT200PpDnihlxysVJLwXrUqiXKe9hwewHznv3RGqiabMkxHhF0B iwRT2oZOrABcq+DKdgEkb2lVH5BFKXD7S4xsVbEgPyhC7LCUHGn+9OcUX/PvImWO9AsVHL9 mjKImJK0nlIY+z6IqJTvw== X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CKbetQjAbPfbc3WKCkOa61cGek3Ln3Th4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable When performing M-x diredp-do-bookmark on a selected file from a dired buffer, (keybinding M-b) the minibuffer correctly prompts, "Bookmark ? (y or n). However, when answering `y', it responds: Failed to create bookmark for `': Wrong number of arguments: #[(name alist no-overwrite) "\306 \210\307^H!^Y\310\311 G\312 $\210\204#^@\313 \314\"\203#^@\313 !^K\241\210\202)^@ ^KB^LB^T ^U^N^PT^V^P\315 \2038^@\316 \210 ^U\317 )\207" [name stripped-name no-overwrite alist bookmark-alist bookmark-current-bookmark bookmark-maybe-load-default-file copy-sequence set-text-properties 0 nil bookmark-get-bookmark noerror bookmark-time-to-save-p bookmark-save bookmark-bmenu-surreptitiously-rebuild-list bookmark-alist-modification-count] 5 ("/usr/share/emacs/24.4/lisp/bookmark.elc" . 16242)], 4 This reproduces consistently. The files tested had `simple' filenames (only [a-zA-Z] characters, no whitespace in filenames) in my home directo= ry. The source of the error seems to be in function `diredp-bookmark' in file dired+.el. There (my line #6102), a call to function `bookkmark-store' includes an extra parameter no-msg-p. When I removed that parameter, the function did work. A secondary problem may be why function `diredp-bookmark' has parameter no-msg-p in the first place. A second secondary problem may be why the funky error message. A third secondary problem may be that `diredp-do-bookmark' doesn't prompt the user for a bookmark, and just assumes that the user wants the bookmark-name to be the filename. Personally, my preference / vote would be to have a user prompt, with the minibuffer pre-filled with the filenam= e. A final issue is that the function includes a comment, "NEED to keep this code sync'd with `bmkp-make-record-for-target-file'.", but I can't find such a function. In GNU Emacs 24.4.1 (x86_64-pc-linux-gnu) of 2014-12-09 on gaia, modified by Debian System Description: Debian 7.0 GNU/Linux wheezy/testing Configured using: `configure --build x86_64-linux-gnu --prefix=3D/usr --sharedstatedir=3D/var/lib --libexecdir=3D/usr/lib --localstatedir=3D/var/lib --infodir=3D/usr/share/info --mandir=3D/usr/share/man --with-pop=3Dyes --enable-locallisppath=3D/etc/emacs24:/etc/emacs:/usr/local/share/emacs/= 24.4/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.4/sit= e-lisp:/usr/share/emacs/s\ ite-lisp --build x86_64-linux-gnu --prefix=3D/usr --sharedstatedir=3D/var/lib --libexecdir=3D/usr/lib --localstatedir=3D/var/lib --infodir=3D/usr/share/info --mandir=3D/usr/share/man --with-pop=3Dyes --enable-locallisppath=3D/etc/emacs24:/etc/emacs:/usr/local/share/emacs/= 24.4/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.4/sit= e-lisp:/usr/share/emacs/s\ ite-lisp --with-x=3Dno --without-gconf --without-gsettings 'CFLAGS=3D-g -O2 -fstack-protector-strong -Wformat -Werror=3Dformat-security -Wall' CPPFLAGS=3D-D_FORTIFY_SOURCE=3D2 LDFLAGS=3D-Wl,-z,relro' Important settings: value of $LANG: en_US.utf8 locale-coding-system: utf-8-unix Major mode: IBuffer Minor modes in effect: highlight-current-line-minor-mode: t desktop-save-mode: t savehist-mode: t winner-mode: t global-hi-lock-mode: t hi-lock-mode: t delete-selection-mode: t shell-dirtrack-mode: t tooltip-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-favicon hides /usr/share/emacs24/site-lisp/w3m/w3m-favicon home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-symbol hides /usr/share/emacs24/site-lisp/w3m/w3m-symbol home/boruch.emacs.d/elpa/w3m-20140107.1708/bookmark-w3m hides /usr/share/emacs24/site-lisp/w3m/bookmark-w3m home/boruch.emacs.d/elpa/w3m-20140107.1708/mime-w3m hides /usr/share/emacs24/site-lisp/w3m/mime-w3m home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-filter hides /usr/share/emacs24/site-lisp/w3m/w3m-filter home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-ccl hides /usr/share/emacs24/site-lisp/w3m/w3m-ccl home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-namazu hides /usr/share/emacs24/site-lisp/w3m/w3m-namazu home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-ems hides /usr/share/emacs24/site-lisp/w3m/w3m-ems home/boruch.emacs.d/elpa/w3m-20140107.1708/octet hides /usr/share/emacs24/site-lisp/w3m/octet home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-bookmark hides /usr/share/emacs24/site-lisp/w3m/w3m-bookmark home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-perldoc hides /usr/share/emacs24/site-lisp/w3m/w3m-perldoc home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-dtree hides /usr/share/emacs24/site-lisp/w3m/w3m-dtree home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-session hides /usr/share/emacs24/site-lisp/w3m/w3m-session home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-mail hides /usr/share/emacs24/site-lisp/w3m/w3m-mail home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-search hides /usr/share/emacs24/site-lisp/w3m/w3m-search home/boruch.emacs.d/elpa/w3m-20140107.1708/w3mhack hides /usr/share/emacs24/site-lisp/w3m/w3mhack home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-proc hides /usr/share/emacs24/site-lisp/w3m/w3m-proc home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-tabmenu hides /usr/share/emacs24/site-lisp/w3m/w3m-tabmenu home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-rss hides /usr/share/emacs24/site-lisp/w3m/w3m-rss home/boruch.emacs.d/elpa/w3m-20140107.1708/mew-w3m hides /usr/share/emacs24/site-lisp/w3m/mew-w3m home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m hides /usr/share/emacs24/site-lisp/w3m/w3m home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m hides /usr/share/emacs24/site-lisp/w3m/w3m home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-image hides /usr/share/emacs24/site-lisp/w3m/w3m-image home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-hist hides /usr/share/emacs24/site-lisp/w3m/w3m-hist home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-lnum hides /usr/share/emacs24/site-lisp/w3m/w3m-lnum home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-form hides /usr/share/emacs24/site-lisp/w3m/w3m-form home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-cookie hides /usr/share/emacs24/site-lisp/w3m/w3m-cookie home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-weather hides /usr/share/emacs24/site-lisp/w3m/w3m-weather home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-bug hides /usr/share/emacs24/site-lisp/w3m/w3m-bug home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-fb hides /usr/share/emacs24/site-lisp/w3m/w3m-fb home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-antenna hides /usr/share/emacs24/site-lisp/w3m/w3m-antenna home/boruch.emacs.d/elpa/w3m-20140107.1708/w3m-util hides /usr/share/emacs24/site-lisp/w3m/w3m-util home/boruch.emacs.d/elpa/csv-mode-1.2/csv-mode hides /usr/share/emacs24/site-lisp/emacs-goodies-el/csv-mode /usr/share/emacs/24.4/site-lisp/cdargs hides /usr/share/emacs/site-lisp/cdargs /usr/share/emacs/24.4/site-lisp/debian-startup hides /usr/share/emacs/site-lisp/debian-startup /usr/share/emacs24/site-lisp/flim/md4 hides /usr/share/emacs/24.4/lisp/md= 4 /usr/share/emacs24/site-lisp/flim/hex-util hides /usr/share/emacs/24.4/lisp/hex-util /usr/share/emacs24/site-lisp/dictionaries-common/flyspell hides /usr/share/emacs/24.4/lisp/textmodes/flyspell /usr/share/emacs24/site-lisp/dictionaries-common/ispell hides /usr/share/emacs/24.4/lisp/textmodes/ispell /usr/share/emacs/site-lisp/rst hides /usr/share/emacs/24.4/lisp/textmodes/rst /usr/share/emacs24/site-lisp/flim/sasl-ntlm hides /usr/share/emacs/24.4/lisp/net/sasl-ntlm /usr/share/emacs24/site-lisp/flim/hmac-def hides /usr/share/emacs/24.4/lisp/net/hmac-def /usr/share/emacs24/site-lisp/flim/hmac-md5 hides /usr/share/emacs/24.4/lisp/net/hmac-md5 /usr/share/emacs24/site-lisp/flim/sasl-cram hides /usr/share/emacs/24.4/lisp/net/sasl-cram /usr/share/emacs24/site-lisp/flim/ntlm hides /usr/share/emacs/24.4/lisp/net/ntlm /usr/share/emacs24/site-lisp/flim/sasl hides /usr/share/emacs/24.4/lisp/net/sasl /usr/share/emacs24/site-lisp/flim/sasl-digest hides /usr/share/emacs/24.4/lisp/net/sasl-digest /usr/share/emacs/24.4/lisp/emacs-lisp/ert-x hides /usr/share/emacs/24.4/site-lisp/slime/lib/ert-x /usr/share/emacs/24.4/lisp/emacs-lisp/cl-lib hides /usr/share/emacs/24.4/site-lisp/slime/lib/cl-lib /usr/share/emacs/24.4/lisp/emacs-lisp/ert hides /usr/share/emacs/24.4/site-lisp/slime/lib/ert Features: (shadow sort mail-extr emacsbug message rfc822 mml mml-sec mm-decode mm-bodies mm-encode mailabbrev ...) Memory information: ((conses 16 459100 69911) (symbols 48 42873 0) (miscs 40 2286 3515) (strings 32 125530 18155) (string-bytes 1 3397524) (vectors 16 43381) (vector-slots 8 1545011 166125) (floats 8 374 644) (intervals 56 10688 1329) (buffers 960 72) (heap 1024 42235 1854)) --=20 hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 --CKbetQjAbPfbc3WKCkOa61cGek3Ln3Th4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU6hp/AAoJEDvrUfDmCx9LVUwP/1eO4KZUMoMoTcC17KXiUJg4 lGYwP/U6kAGYcvIG4IpSD/Pg0Ai1/hhmaoEIG0jRgf7a3a5CQFnZbu0ZN+4kVLmh 0mMb0h5zNmgMHjACrfutOWJrIJ6SxMHi+AWaxhTJSrmzA0JWTypSYjGyy8u4D3E9 apc01RL5/gBKeCzyXdYX36x2RKcG37XUyLHygvt0BZXoKDgYtE6yIi3GNPln/p4F hvnW+OooRqlBeavdZVEDmJKUznEI/80FMqyLWwdy882B5ilIrq7ZR3QivRHZRTpk eeuIh1rXgiPKBD7rGuXKyrMoT3x4FVhTcZhSDfypf/RPz74kMKnizNof7ReLHVgp NKVRkY9b7LetQD0uZmr16pWD/qcZ9XXQci5TM/DOA0ml897Nnv0WGYOhSe+zMzel VtAczRFUHd9WOQtyVQcW70dIt6o8nR+XxwTA5854GzTQV/+7a9IzRwHafQ1eUJO0 BGwm8xR3SCFnDlmuxQ2r1ZS7tom/Dxd+rhAnKTFtmURmUYLnxiOcimm/66/nFmUv 977mKtxBXuS36JBkinJhoZiZPD6jFvrnmGTjT7e/BaT5sg/9DTwkqLjNVVcqWM4A D9Ax4U0daJzuCNa9VjQ/jAcSq0DGA6IkHp6J9uzV6b9DhGU29YOR8APN8k5IwKwO QTDbi9re+NmSX9931TrZ =ccyD -----END PGP SIGNATURE----- --CKbetQjAbPfbc3WKCkOa61cGek3Ln3Th4-- From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 22 14:30:01 2015 Received: (at 19923) by debbugs.gnu.org; 22 Feb 2015 19:30:01 +0000 Received: from localhost ([127.0.0.1]:50892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YPcE4-0004NE-P1 for submit@debbugs.gnu.org; Sun, 22 Feb 2015 14:30:01 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:21116) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YPcE2-0004N6-Pi for 19923@debbugs.gnu.org; Sun, 22 Feb 2015 14:29:59 -0500 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t1MJTunV024655 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 22 Feb 2015 19:29:57 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t1MJTuLk005665 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sun, 22 Feb 2015 19:29:56 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id t1MJTupi023372; Sun, 22 Feb 2015 19:29:56 GMT MIME-Version: 1.0 Message-ID: <907e250a-494d-4e5a-a151-4d1923724fe1@default> Date: Sun, 22 Feb 2015 11:29:50 -0800 (PST) From: Drew Adams To: Boruch Baum , 19923@debbugs.gnu.org Subject: RE: bug#19923: 24.4: diredp-do-bookmark fails: claims "Wrong number of arguments" References: <54EA1A7F.60701@gmx.com> In-Reply-To: <54EA1A7F.60701@gmx.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19923 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Functions `diredp-*' are dired+.el functions. I will close this Emacs bug and follow up with the OP for the Dired+ issue. > When performing M-x diredp-do-bookmark on a selected file from a dired > buffer, (keybinding M-b) the minibuffer correctly prompts, "Bookmark > ? (y or n). However, when answering `y', it responds: >=20 > Failed to create bookmark for `': > Wrong number of arguments: ... From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 22 14:31:16 2015 Received: (at control) by debbugs.gnu.org; 22 Feb 2015 19:31:16 +0000 Received: from localhost ([127.0.0.1]:50896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YPcFI-0004Qd-8T for submit@debbugs.gnu.org; Sun, 22 Feb 2015 14:31:16 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:43762) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YPcFG-0004QV-2n for control@debbugs.gnu.org; Sun, 22 Feb 2015 14:31:14 -0500 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t1MJVCDg005371 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 22 Feb 2015 19:31:13 GMT Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id t1MJVAMF025562 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 22 Feb 2015 19:31:12 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userz7022.oracle.com (8.14.5+Sun/8.14.4) with ESMTP id t1MJVATr018498 for ; Sun, 22 Feb 2015 19:31:10 GMT MIME-Version: 1.0 Message-ID: Date: Sun, 22 Feb 2015 11:31:03 -0800 (PST) From: Drew Adams To: control@debbugs.gnu.org Subject: close 19923 X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) close 19923 thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 22 15:34:13 2015 Received: (at 19923) by debbugs.gnu.org; 22 Feb 2015 20:34:13 +0000 Received: from localhost ([127.0.0.1]:50902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YPdED-0007Iy-38 for submit@debbugs.gnu.org; Sun, 22 Feb 2015 15:34:13 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:28910) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YPdE9-0007Im-3J for 19923@debbugs.gnu.org; Sun, 22 Feb 2015 15:34:10 -0500 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t1MKY6FP030854 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 22 Feb 2015 20:34:07 GMT Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id t1MKY5RG001970 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 22 Feb 2015 20:34:06 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userz7022.oracle.com (8.14.5+Sun/8.14.4) with ESMTP id t1MKY4AE020107; Sun, 22 Feb 2015 20:34:05 GMT MIME-Version: 1.0 Message-ID: <6b84fedc-a350-4b34-924f-3da4fd0e937b@default> Date: Sun, 22 Feb 2015 12:33:58 -0800 (PST) From: Drew Adams To: Boruch Baum , 19923@debbugs.gnu.org Subject: RE: bug#19923: 24.4: diredp-do-bookmark fails: claims "Wrong number of arguments" References: <54EA1A7F.60701@gmx.com> In-Reply-To: <54EA1A7F.60701@gmx.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19923 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Boruch, Should be OK now. Please download the latest dired+.el from Emacs Wiki, or wait up to a day for it to be mirrored on MELPA. http://www.emacswiki.org/emacs/download/dired%2b.el. Thanks for the bug report. In answer to your questions: 1. Why function `diredp-bookmark' has parameter NO-MSG-P? Non-nil is passed for that arg when called from `diredp-do-bookmark' and `diredp-do-bookmark-recursive', which create multiple bookmarks. This is to prevent umpteen progress messages. 2. Why the funky error message? Dunno why the file name was shown as `', unless somehow `dired-get-file-for-visit' returned that. The rest of the error message is from `error-message-string', from the error that was raised. Why that looks like byte-code, I don't know. That part looks like an Emacs bug, to me. And the error is raised by the vanilla `bookmark-store' code in bookmark.el. 3. Why doesn't `diredp-do-bookmark' prompt the user for a bookmark, and just assumes that the user wants the bookmark name to be the filename? That's the feature. ;-) `diredp-do-bookmark' etc. are really aimed at quickly creating multiple bookmarks without naming them, in which case you (I, at least)) would not want to have to provide a bookmark name for each file. In addition, these commands are most useful in conjunction with library Bookmark+, in which case the aim is precisely to have (so-called "autofile") bookmarks whose names are the (non-directory) file names, so they can be manipulated using file commands etc. It might be possible to have these commands prompt for the bookmark name in the case where they act on only one bookmark, but I'm not in favor of that either; sorry. You can easily write a modified version of `diredp-bookmark' that does that, for your own use. 4. Why the comment about keeping part of the code in sync with the code for `bmkp-make-record-for-target-file', and where is that function? This is a note to myself, so that if I improve one of these functions later I will remember to consider improving the other one similarly. Function `bmkp-make-record-for-target-file' is in library Bookmark+: http://www.emacswiki.org/emacs/BookmarkPlus HTH. From unknown Fri Aug 15 03:56:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 23 Mar 2015 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator