GNU bug report logs - #19921
Support URL open for upcomming Mozilla Firefox 36

Previous Next

Package: emacs;

Reported by: Ryo ONODERA <ryo_on <at> yk.rim.or.jp>

Date: Sun, 22 Feb 2015 08:44:03 UTC

Severity: normal

Fixed in version 24.5

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#19921: closed (Support URL open for upcomming Mozilla Firefox 36)
Date: Tue, 24 Feb 2015 23:06:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Tue, 24 Feb 2015 18:05:25 -0500
with message-id <mx7fv6ykp6.fsf <at> fencepost.gnu.org>
and subject line Re: bug#19921: Support URL open for upcomming Mozilla Firefox 36
has caused the debbugs.gnu.org bug report #19921,
regarding Support URL open for upcomming Mozilla Firefox 36
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
19921: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19921
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ryo ONODERA <ryo_on <at> yk.rim.or.jp>
To: bug-gnu-emacs <at> gnu.org
Subject: Support URL open for upcomming Mozilla Firefox 36
Date: Sun, 22 Feb 2015 17:01:13 +0900 (JST)
Hi,

Firefox 36 or later has no "-remote" command line option anymore.
browse-url-firefox of Emacs uses this "-remote" option
to open URL as new window or new tab.
We should use "--new-tab URLString" or "--new-window URLString" instead.

See
https://developer.mozilla.org/en-US/docs/Mozilla/Command_Line_Options#-remote_remote_command
> This feature has been removed in Firefox 36.


Following patch uses --new-tab or --new-window command line option.
This works with Mozilla Firefox 36.0 build 10.

diff --git a/lisp/net/browse-url.el b/lisp/net/browse-url.el
index 42fb954..6ad14a2 100644
--- a/lisp/net/browse-url.el
+++ b/lisp/net/browse-url.el
@@ -1137,15 +1137,12 @@ URL in a new window."
 		 (append
 		  browse-url-firefox-arguments
 		  (if use-remote
-		      (list "-remote"
-			    (concat
-			     "openURL("
-			     url
-			     (if (browse-url-maybe-new-window new-window)
-				 (if browse-url-firefox-new-window-is-tab
-				     ",new-tab"
-				   ",new-window"))
-			     ")"))
+		      (list
+		       (if (browse-url-maybe-new-window new-window)
+			   (if browse-url-firefox-new-window-is-tab
+			       "--new-tab"
+			     "--new-window"))
+		       url)
 		    (list url))))))
     ;; If we use -remote, the process exits with status code 2 if
     ;; Firefox is not already running.  The sentinel runs firefox

--
Ryo ONODERA // ryo_on <at> yk.rim.or.jp
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3


[Message part 3 (message/rfc822, inline)]
From: Glenn Morris <rgm <at> gnu.org>
To: 19921-done <at> debbugs.gnu.org
Subject: Re: bug#19921: Support URL open for upcomming Mozilla Firefox 36
Date: Tue, 24 Feb 2015 18:05:25 -0500
Version: 24.5

I see that Firefox 36 is now released, so fixed in emacs-24.

(Someone really needs to take a sledgehammer to the plethora of options
and functions in browse-url.)


This bug report was last modified 10 years and 135 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.