From unknown Fri Aug 15 04:05:10 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#19921 <19921@debbugs.gnu.org> To: bug#19921 <19921@debbugs.gnu.org> Subject: Status: Support URL open for upcomming Mozilla Firefox 36 Reply-To: bug#19921 <19921@debbugs.gnu.org> Date: Fri, 15 Aug 2025 11:05:10 +0000 retitle 19921 Support URL open for upcomming Mozilla Firefox 36 reassign 19921 emacs submitter 19921 Ryo ONODERA severity 19921 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 22 03:44:02 2015 Received: (at submit) by debbugs.gnu.org; 22 Feb 2015 08:44:02 +0000 Received: from localhost ([127.0.0.1]:50493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YPS8v-00039Q-LG for submit@debbugs.gnu.org; Sun, 22 Feb 2015 03:44:02 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58408) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YPRTo-000274-DY for submit@debbugs.gnu.org; Sun, 22 Feb 2015 03:01:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YPRTn-0003Gm-85 for submit@debbugs.gnu.org; Sun, 22 Feb 2015 03:01:32 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPRTn-0003Gi-5E for submit@debbugs.gnu.org; Sun, 22 Feb 2015 03:01:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPRTm-0004dr-2b for bug-gnu-emacs@gnu.org; Sun, 22 Feb 2015 03:01:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YPRTi-00039f-Pi for bug-gnu-emacs@gnu.org; Sun, 22 Feb 2015 03:01:30 -0500 Received: from mail117.siriuscloud.jp ([219.118.72.117]:45724 helo=mail07.SiriusCloud.jp) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPRTi-000316-Gn for bug-gnu-emacs@gnu.org; Sun, 22 Feb 2015 03:01:26 -0500 Received: from localhost (p8222-ipngn201funabasi.chiba.ocn.ne.jp [114.158.215.222]) (Authenticated sender: ryo_on@yk.rim.or.jp) by access07.SiriusCloud.jp (Postfix) with ESMTPA id 0139D400E86DA; Sun, 22 Feb 2015 17:01:21 +0900 (JST) Authentication-Results: access07.SiriusCloud.jp; dkim=none (no signature) header.i=unknown; x-dkim-adsp=none (insecure policy) Date: Sun, 22 Feb 2015 17:01:13 +0900 (JST) Message-Id: <20150222.170113.1017436961048435194.ryo_on@yk.rim.or.jp> To: bug-gnu-emacs@gnu.org Subject: Support URL open for upcomming Mozilla Firefox 36 From: Ryo ONODERA X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.8 at si-mail07 X-Virus-Status: Clean X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 22 Feb 2015 03:44:00 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hi, Firefox 36 or later has no "-remote" command line option anymore. browse-url-firefox of Emacs uses this "-remote" option to open URL as new window or new tab. We should use "--new-tab URLString" or "--new-window URLString" instead. See https://developer.mozilla.org/en-US/docs/Mozilla/Command_Line_Options#-remote_remote_command > This feature has been removed in Firefox 36. Following patch uses --new-tab or --new-window command line option. This works with Mozilla Firefox 36.0 build 10. diff --git a/lisp/net/browse-url.el b/lisp/net/browse-url.el index 42fb954..6ad14a2 100644 --- a/lisp/net/browse-url.el +++ b/lisp/net/browse-url.el @@ -1137,15 +1137,12 @@ URL in a new window." (append browse-url-firefox-arguments (if use-remote - (list "-remote" - (concat - "openURL(" - url - (if (browse-url-maybe-new-window new-window) - (if browse-url-firefox-new-window-is-tab - ",new-tab" - ",new-window")) - ")")) + (list + (if (browse-url-maybe-new-window new-window) + (if browse-url-firefox-new-window-is-tab + "--new-tab" + "--new-window")) + url) (list url)))))) ;; If we use -remote, the process exits with status code 2 if ;; Firefox is not already running. The sentinel runs firefox -- Ryo ONODERA // ryo_on@yk.rim.or.jp PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB FD1B F404 27FA C7D1 15F3 From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 23 12:06:19 2015 Received: (at control) by debbugs.gnu.org; 23 Feb 2015 17:06:19 +0000 Received: from localhost ([127.0.0.1]:51611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YPwSZ-0006Ab-30 for submit@debbugs.gnu.org; Mon, 23 Feb 2015 12:06:19 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:39828) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YPwSX-0006AU-Ep for control@debbugs.gnu.org; Mon, 23 Feb 2015 12:06:17 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YPwSX-0002e1-3l for control@debbugs.gnu.org; Mon, 23 Feb 2015 12:06:17 -0500 Date: Mon, 23 Feb 2015 12:06:17 -0500 Message-Id: Subject: control message for bug 19759 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) block 19759 by 19921 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 24 15:12:26 2015 Received: (at control) by debbugs.gnu.org; 24 Feb 2015 20:12:26 +0000 Received: from localhost ([127.0.0.1]:57015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQLqD-0005W7-OV for submit@debbugs.gnu.org; Tue, 24 Feb 2015 15:12:26 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:37427 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQLqC-0005Vz-Gm for control@debbugs.gnu.org; Tue, 24 Feb 2015 15:12:24 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YQLqC-0001rr-0y for control@debbugs.gnu.org; Tue, 24 Feb 2015 15:12:24 -0500 Date: Tue, 24 Feb 2015 15:12:24 -0500 Message-Id: Subject: control message for bug 19758 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) block 19758 by 19921 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 24 18:05:29 2015 Received: (at 19921-done) by debbugs.gnu.org; 24 Feb 2015 23:05:29 +0000 Received: from localhost ([127.0.0.1]:57099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQOXg-0002U6-MX for submit@debbugs.gnu.org; Tue, 24 Feb 2015 18:05:28 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:41893 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQOXe-0002Tx-BP for 19921-done@debbugs.gnu.org; Tue, 24 Feb 2015 18:05:27 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YQOXd-0000Lt-TU; Tue, 24 Feb 2015 18:05:25 -0500 From: Glenn Morris To: 19921-done@debbugs.gnu.org Subject: Re: bug#19921: Support URL open for upcomming Mozilla Firefox 36 References: <20150222.170113.1017436961048435194.ryo_on@yk.rim.or.jp> X-Spook: SWAT CIA ISEC corporate security covert video X-Ran: A:FbcKh)KP_\CUXk9~kC14iqOu)oV.U)!Mk<^tl]*L(]ale'}REe>MCH^_2C),&Tfmt11@ X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 24 Feb 2015 18:05:25 -0500 In-Reply-To: <20150222.170113.1017436961048435194.ryo_on@yk.rim.or.jp> (Ryo ONODERA's message of "Sun, 22 Feb 2015 17:01:13 +0900 (JST)") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 19921-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Version: 24.5 I see that Firefox 36 is now released, so fixed in emacs-24. (Someone really needs to take a sledgehammer to the plethora of options and functions in browse-url.) From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 27 03:13:05 2015 Received: (at 19921) by debbugs.gnu.org; 27 Feb 2015 08:13:05 +0000 Received: from localhost ([127.0.0.1]:59221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRG2i-0000IU-Fs for submit@debbugs.gnu.org; Fri, 27 Feb 2015 03:13:04 -0500 Received: from mout.gmx.com ([74.208.4.200]:64269) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRG2g-0000Hz-G8 for 19921@debbugs.gnu.org; Fri, 27 Feb 2015 03:13:03 -0500 Received: from localhost ([123.218.132.201]) by mail.gmx.com (mrgmxus002) with ESMTPSA (Nemesis) id 0LeMRv-1XiYm038JR-00qChz; Fri, 27 Feb 2015 09:12:54 +0100 Date: Fri, 27 Feb 2015 17:12:20 +0900 (JST) Message-Id: <20150227.171220.1674422297465467874.teika@gmx.com> To: 19921@debbugs.gnu.org Subject: SIGHUP related subtlety remains From: Teika Kazura Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:OSJ1/xFgSNYSIW9VfsE2ivFJgXh5oN0CbKXLbpbdZlzjvAE5ECZ RqmY/nNrxj55L2zXaaoa45wTGfS2AGI1wzbGY/y1PU1AtKxMoeDCdEmFYjDBt9VbVtHo2hG Yt30N3fEJLoeS1s/e+9jr3+Qgf7+DkbB9jreKK0B0ugPVQpsMrwrb+KJ1UKC37U3x9876u9 sKAdMum+mRQ5zAMLDq0Zg== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19921 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Thanks for fixing, but there remains a flaw, at least for me. Starting from firefox-36, it (`browse-url-firefox') doesn't work, due to bug #16019 (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16019) My fix is to make firefox SIGHUP-immune, by adding the following line to /usr/bin/firefox (I'm using Linux.): ------------------------------------------------------------------------ trap "" SIGHUP ------------------------------------------------------------------------ Should I open a separate bug report? Dropping "-remote" was handled correctly by the commit http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-24&id=1b0ebbdb566a8dfa5f45ce121b2c835e9760091f, and my complaint may not be reproduced by others. (Perhaps this bug is due to the fact that my PC is slower than most's.) From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 03:50:00 2015 Received: (at 19921) by debbugs.gnu.org; 2 Mar 2015 08:50:00 +0000 Received: from localhost ([127.0.0.1]:33799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSM36-0000j4-81 for submit@debbugs.gnu.org; Mon, 02 Mar 2015 03:50:00 -0500 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:58373 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSM34-0000iq-5t for 19921@debbugs.gnu.org; Mon, 02 Mar 2015 03:49:58 -0500 Received: from micropit.roche-blanche.homenet.org ([2.2.93.102]) by mwinf5d01 with ME id yYpr1p00K2CWnca03Yprib; Mon, 02 Mar 2015 09:49:52 +0100 X-ME-Helo: micropit.roche-blanche.homenet.org X-ME-Auth: ZHJwbUB3YW5hZG9vLmZy X-ME-Date: Mon, 02 Mar 2015 09:49:52 +0100 X-ME-IP: 2.2.93.102 Received: by micropit.roche-blanche.homenet.org (Postfix, from userid 1000) id 575D14270; Mon, 2 Mar 2015 09:49:51 +0100 (CET) From: =?utf-8?Q?Peter_M=C3=BCnster?= To: 19921@debbugs.gnu.org, Glenn Morris Subject: Re: bug#19921: Support URL open for upcomming Mozilla Firefox 36 References: <20150222.170113.1017436961048435194.ryo_on@yk.rim.or.jp> Date: Mon, 02 Mar 2015 09:49:51 +0100 In-Reply-To: (Glenn Morris's message of "Tue, 24 Feb 2015 18:05:25 -0500") Message-ID: <87y4nf2380.fsf@roche-blanche.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19921 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Tue, Feb 24 2015, Glenn Morris wrote: > Version: 24.5 > > I see that Firefox 36 is now released, so fixed in emacs-24. Hi, About when will this be fixed in the master-branch please? Thanks, -- Peter From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 12:01:52 2015 Received: (at 19921) by debbugs.gnu.org; 2 Mar 2015 17:01:52 +0000 Received: from localhost ([127.0.0.1]:32994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSTj5-0001sA-Ve for submit@debbugs.gnu.org; Mon, 02 Mar 2015 12:01:52 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:35517 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSTj2-0001oO-W0 for 19921@debbugs.gnu.org; Mon, 02 Mar 2015 12:01:49 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YSTj1-0002ZP-GI; Mon, 02 Mar 2015 12:01:47 -0500 From: Glenn Morris To: Peter =?utf-8?Q?M=C3=BCnster?= Subject: Re: bug#19921: Support URL open for upcomming Mozilla Firefox 36 References: <20150222.170113.1017436961048435194.ryo_on@yk.rim.or.jp> <87y4nf2380.fsf@roche-blanche.net> X-Spook: electronic surveillance Chobetsu data haven insurgency X-Ran: >"}8L_hZz-~2,X*&U&a`a>ymys}01*bc6k'&l5=]|2W&+$?&PK?AtrXJ#Q}Cfv.Zn7W9/^ X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 02 Mar 2015 12:01:47 -0500 In-Reply-To: <87y4nf2380.fsf@roche-blanche.net> ("Peter =?utf-8?Q?M=C3=BCn?= =?utf-8?Q?ster=22's?= message of "Mon, 02 Mar 2015 09:49:51 +0100") Message-ID: <5wwq2zl4ec.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 19921 Cc: 19921@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Peter M=C3=BCnster wrote: > About when will this be fixed in the master-branch please? Whenever someone complies with my request to merge emacs-24 to master. http://lists.gnu.org/archive/html/emacs-devel/2015-02/msg01345.html From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 07 06:16:33 2015 Received: (at 19921) by debbugs.gnu.org; 7 Mar 2015 11:16:33 +0000 Received: from localhost ([127.0.0.1]:38155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUCie-0001fH-Nr for submit@debbugs.gnu.org; Sat, 07 Mar 2015 06:16:33 -0500 Received: from a1www.kph.uni-mainz.de ([134.93.134.1]:36322) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUCic-0001f4-MR for 19921@debbugs.gnu.org; Sat, 07 Mar 2015 06:16:31 -0500 Received: from a1i15.kph.uni-mainz.de (a1i15.kph.uni-mainz.de [134.93.134.92]) by a1www.kph.uni-mainz.de (8.14.9/8.14.7) with ESMTP id t27BGO4l026818 for <19921@debbugs.gnu.org>; Sat, 7 Mar 2015 12:16:24 +0100 Received: from a1i15.kph.uni-mainz.de (localhost [127.0.0.1]) by a1i15.kph.uni-mainz.de (8.14.8/8.14.2) with ESMTP id t27BGO4K025924; Sat, 7 Mar 2015 12:16:24 +0100 Received: (from ulm@localhost) by a1i15.kph.uni-mainz.de (8.14.8/8.14.8/Submit) id t27BGNxp025920; Sat, 7 Mar 2015 12:16:23 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <21754.56839.582479.848900@a1i15.kph.uni-mainz.de> Date: Sat, 7 Mar 2015 12:16:23 +0100 To: 19921@debbugs.gnu.org Subject: [PATCH] browse-url-firefox: Remove MS-Windows special case. X-Mailer: VM 8.2.0b under 24.3.1 (x86_64-pc-linux-gnu) From: Ulrich Mueller X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19921 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Firefox on MS-Windows supports both the -new-tab and -new-window options, so the special case is no longer necessary there. I have tested this with Firefox 11.0 under Windows XP and Firefox 36.0.1 under MS-Windows 8.1. See patch below. It should be pushed to the emacs-24 branch, I guess? >From 3e3f9ade6aa13fbeb93ee2eee117ef8e04aec5d2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulrich=20M=C3=BCller?= Date: Sat, 7 Mar 2015 11:47:56 +0100 Subject: [PATCH] browse-url-firefox: Remove MS-Windows special case. * lisp/net/browse-url.el (browse-url-firefox): Remove MS-Windows special case. --- lisp/ChangeLog | 5 +++++ lisp/net/browse-url.el | 17 +++++------------ 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 0e4e463..95ab6cc 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2015-03-07 Ulrich Müller + + * net/browse-url.el (browse-url-firefox): Remove MS-Windows + special case. + 2015-03-07 Eli Zaretskii * dired.el (dired-delete-file): Doc fix. (Bug#20021) diff --git a/lisp/net/browse-url.el b/lisp/net/browse-url.el index 4819cdc..d82d447 100644 --- a/lisp/net/browse-url.el +++ b/lisp/net/browse-url.el @@ -1117,11 +1117,7 @@ whenever a document would otherwise be loaded in a new window, it is loaded in a new tab in an existing window instead. Non-interactively, this uses the optional second argument NEW-WINDOW -instead of `browse-url-new-window-flag'. - -On MS Windows, this ignores `browse-url-new-window-flag' and -`browse-url-firefox-new-window-is-tab', as well as the NEW-WINDOW argument. -It always uses a new window." +instead of `browse-url-new-window-flag'." (interactive (browse-url-interactive-arg "URL: ")) (setq url (browse-url-encode-url url)) (let* ((process-environment (browse-url-process-environment))) @@ -1130,13 +1126,10 @@ It always uses a new window." browse-url-firefox-program (append browse-url-firefox-arguments - ;; FIXME someone should check if this limitation - ;; still applies. - (unless (memq system-type '(windows-nt ms-dos)) - (if (browse-url-maybe-new-window new-window) - (if browse-url-firefox-new-window-is-tab - '("-new-tab") - '("-new-window")))) + (if (browse-url-maybe-new-window new-window) + (if browse-url-firefox-new-window-is-tab + '("-new-tab") + '("-new-window"))) (list url))))) ;;;###autoload -- 2.3.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 07 07:16:52 2015 Received: (at 19921) by debbugs.gnu.org; 7 Mar 2015 12:16:52 +0000 Received: from localhost ([127.0.0.1]:38183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUDf1-0003ME-PL for submit@debbugs.gnu.org; Sat, 07 Mar 2015 07:16:51 -0500 Received: from mtaout26.012.net.il ([80.179.55.182]:46391) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUDez-0003Lp-Bs for 19921@debbugs.gnu.org; Sat, 07 Mar 2015 07:16:50 -0500 Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0NKU00900CJ92900@mtaout26.012.net.il> for 19921@debbugs.gnu.org; Sat, 07 Mar 2015 14:17:16 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKU007INCSSN920@mtaout26.012.net.il>; Sat, 07 Mar 2015 14:17:16 +0200 (IST) Date: Sat, 07 Mar 2015 14:16:39 +0200 From: Eli Zaretskii Subject: Re: bug#19921: [PATCH] browse-url-firefox: Remove MS-Windows special case. In-reply-to: <21754.56839.582479.848900@a1i15.kph.uni-mainz.de> X-012-Sender: halo1@inter.net.il To: Ulrich Mueller Message-id: <83385hm28o.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-transfer-encoding: 8BIT References: <20150222.170113.1017436961048435194.ryo_on@yk.rim.or.jp> <21754.56839.582479.848900@a1i15.kph.uni-mainz.de> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19921 Cc: 19921@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sat, 7 Mar 2015 12:16:23 +0100 > From: Ulrich Mueller > > Firefox on MS-Windows supports both the -new-tab and -new-window > options, so the special case is no longer necessary there. I have > tested this with Firefox 11.0 under Windows XP and Firefox 36.0.1 > under MS-Windows 8.1. AFAIU, this was already fixed on master by Óscar, see commit 20c6b22. > It should be pushed to the emacs-24 branch, I guess? No, emacs-24 is only for fixing regressions wrt 24.3. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 07 07:50:52 2015 Received: (at 19921) by debbugs.gnu.org; 7 Mar 2015 12:50:52 +0000 Received: from localhost ([127.0.0.1]:38193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUEBv-0005f5-Ou for submit@debbugs.gnu.org; Sat, 07 Mar 2015 07:50:52 -0500 Received: from a1www.kph.uni-mainz.de ([134.93.134.1]:36866) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUEBt-0005eo-W5 for 19921@debbugs.gnu.org; Sat, 07 Mar 2015 07:50:50 -0500 Received: from a1i15.kph.uni-mainz.de (a1i15.kph.uni-mainz.de [134.93.134.92]) by a1www.kph.uni-mainz.de (8.14.9/8.14.7) with ESMTP id t27Coh7Y030395; Sat, 7 Mar 2015 13:50:43 +0100 Received: from a1i15.kph.uni-mainz.de (localhost [127.0.0.1]) by a1i15.kph.uni-mainz.de (8.14.8/8.14.2) with ESMTP id t27CohcJ027047; Sat, 7 Mar 2015 13:50:43 +0100 Received: (from ulm@localhost) by a1i15.kph.uni-mainz.de (8.14.8/8.14.8/Submit) id t27CohRF027043; Sat, 7 Mar 2015 13:50:43 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <21754.62498.928681.607539@a1i15.kph.uni-mainz.de> Date: Sat, 7 Mar 2015 13:50:42 +0100 To: Eli Zaretskii Subject: Re: bug#19921: [PATCH] browse-url-firefox: Remove MS-Windows special case. In-Reply-To: <83385hm28o.fsf@gnu.org> References: <20150222.170113.1017436961048435194.ryo_on@yk.rim.or.jp> <21754.56839.582479.848900@a1i15.kph.uni-mainz.de> <83385hm28o.fsf@gnu.org> X-Mailer: VM 8.2.0b under 24.3.1 (x86_64-pc-linux-gnu) From: Ulrich Mueller X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19921 Cc: 19921@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) >>>>> On Sat, 07 Mar 2015, Eli Zaretskii wrote: > AFAIU, this was already fixed on master by Óscar, see commit 20c6b22. Right. I had missed this. >> It should be pushed to the emacs-24 branch, I guess? > No, emacs-24 is only for fixing regressions wrt 24.3. Then I wonder why commit 1b0ebbd (which introduces the -new-tab and -new-window options) was applied to the branch. I is not a regression fix because the issue already existed in 24.3 and 24.4. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 07 08:17:36 2015 Received: (at 19921) by debbugs.gnu.org; 7 Mar 2015 13:17:36 +0000 Received: from localhost ([127.0.0.1]:38197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUEbo-0006Iw-11 for submit@debbugs.gnu.org; Sat, 07 Mar 2015 08:17:36 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:57101) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUEbl-0006Ic-Eq for 19921@debbugs.gnu.org; Sat, 07 Mar 2015 08:17:34 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NKU00C00FFTV500@a-mtaout22.012.net.il> for 19921@debbugs.gnu.org; Sat, 07 Mar 2015 15:17:26 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKU00CXYFL2V200@a-mtaout22.012.net.il>; Sat, 07 Mar 2015 15:17:26 +0200 (IST) Date: Sat, 07 Mar 2015 15:17:22 +0200 From: Eli Zaretskii Subject: Re: bug#19921: [PATCH] browse-url-firefox: Remove MS-Windows special case. In-reply-to: <21754.62498.928681.607539@a1i15.kph.uni-mainz.de> X-012-Sender: halo1@inter.net.il To: Ulrich Mueller Message-id: <83vbidkkv1.fsf@gnu.org> References: <20150222.170113.1017436961048435194.ryo_on@yk.rim.or.jp> <21754.56839.582479.848900@a1i15.kph.uni-mainz.de> <83385hm28o.fsf@gnu.org> <21754.62498.928681.607539@a1i15.kph.uni-mainz.de> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19921 Cc: 19921@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sat, 7 Mar 2015 13:50:42 +0100 > Cc: 19921@debbugs.gnu.org > From: Ulrich Mueller > > > No, emacs-24 is only for fixing regressions wrt 24.3. > > Then I wonder why commit 1b0ebbd (which introduces the -new-tab and > -new-window options) was applied to the branch. I is not a regression > fix because the issue already existed in 24.3 and 24.4. I share your wondering. From unknown Fri Aug 15 04:05:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 05 Apr 2015 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator